- 20 Oct, 2018 16 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/93277a7fc8ef..98f1e59b41c6 git log 93277a7fc8ef..98f1e59b41c6 --date=short --no-merges --format='%ad %ae %s' 2018-10-19 iannucci@chromium.org [git] Stop using git-retry wrapper on LUCI. Created with: gclient setdep -r src/third_party/depot_tools@98f1e59b41c6 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Id3e109f3e431c49ad9e50e6ce2963180ccd56ee4 Reviewed-on: https://chromium-review.googlesource.com/c/1292285Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#601377}
-
Xi Cheng authored
This reverts commit b011ab56. Reason for revert: caused test failures -- see crbug/897352 Original change's description: > Upgrade image file management for Win 10 native notification > > This CL makes the following changes: > 1) Change to run image folder cleanup after Chrome startup using a background > task, rather than running it at Chrome shutdown using a high priority task. > 2) Retain the image folder to avoid deleting and creating it repeatedly. > 3) Remove <subdir> from the full path for the temp file, which is unnecessary. > 4) Delete the temp files in batch. > > These changes have the following benefits: > 1) Fix the issue of Chrome shutdown being blocked by image file IO for some users > as in the current implementation. > 2) Save some disk IO related to the sub-directories in the image folder and the > image folder itself. > 3) Avoid creating a deletion task for each file, otherwise the overhead can be > large when there is a steady stream of notifications coming rapidly. > > Bug: 888276 > Change-Id: I214680aa00bd7f19e84e207e82ada553583a094b > Reviewed-on: https://chromium-review.googlesource.com/c/1260498 > Commit-Queue: Xi Cheng <chengx@chromium.org> > Reviewed-by: Ilya Sherman <isherman@chromium.org> > Reviewed-by: Greg Thompson <grt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#601227} TBR=isherman@chromium.org,finnur@chromium.org,grt@chromium.org,chengx@chromium.org Change-Id: Ie79e62373c0076346499e450e48c2d16b55c6dc4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 888276, 897352 Reviewed-on: https://chromium-review.googlesource.com/c/1292834Reviewed-by:
Xi Cheng <chengx@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#601376}
-
Shakti Sahu authored
Bug: 896480 Change-Id: I9a0b2b041991a1dbcc63f3190df4dec650f4c25a Reviewed-on: https://chromium-review.googlesource.com/c/1286826 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#601375}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/41ba826ad7b4..773e141a83e3 git log 41ba826ad7b4..773e141a83e3 --date=short --no-merges --format='%ad %ae %s' 2018-10-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader d55d997310c2..17dfe1b679af (1 commits) 2018-10-19 herb@google.com Remove unused methods from SkTDArray 2018-10-19 mtklein@google.com any idea why SkReadBuffer has a vtable? 2018-10-19 bsalomon@google.com Use preallocated space for default vertex and index buffer sizes 2018-10-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 9e4d040cb93c..d55d997310c2 (1 commits) 2018-10-19 egdaniel@google.com Add drawDrawable support to GrRenderTargetContext. 2018-10-19 brianosman@google.com Remove texColorSpace output param from various producer APIs Created with: gclient setdep -r src/third_party/skia@773e141a83e3 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=egdaniel@chromium.org Change-Id: I6693036561c1ade1710d8972b3472821d18bb954 Reviewed-on: https://chromium-review.googlesource.com/c/1292789Reviewed-by:
-
Roberto Carrillo authored
This change should instruct the code coverage testers to include the raw profile data in the isolated output. R=jbudorick Change-Id: Iac30af93faa67179a2b61ef12ec52d65e18a1e08 Reviewed-on: https://chromium-review.googlesource.com/c/1272080 Commit-Queue: Roberto Carrillo <robertocn@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#601373}
-
David Black authored
Previously we hid Assistant on widget deactivation. Then we removed that logic to instead use an event handler that dismissed Assistant on press. We actually need both since Assistant widget can be deactivated w/o a press event, such as happens when opening feedback via Alt+Shift+i. Bug: b:117990949 Change-Id: I75338ef112f5cef3445bf88903adaef2ccd56c48 Reviewed-on: https://chromium-review.googlesource.com/c/1292604Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#601372}
-
Krishna Govind authored
R=kariah@chromium.org Change-Id: Ic132d8e5e9d2848862285e95dab69ad24040f424 Reviewed-on: https://chromium-review.googlesource.com/c/1292818Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#601371}
-
Carlos Knippschild authored
Updates the OfflineContentOnDinoPage experiment group name and param value to comply with the upcoming Finch experiment configuration change. Bug: 852872 Change-Id: If110b3d215e9e6fd3184eaff6c33c9f3c5ac5ff7 Reviewed-on: https://chromium-review.googlesource.com/c/1292523Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#601370}
-
Takuto Ikuta authored
This CL is part of https://chromium-review.googlesource.com/c/chromium/src/+/1286016 This CL was uploaded by git cl split. R=imcheng@chromium.org Bug: 753973 Change-Id: I37354ffed6f228bb85ac3d05a19bdf6bf606b6f3 Reviewed-on: https://chromium-review.googlesource.com/c/1288154Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#601369}
-
Fabrice de Gans-Riberi authored
Previously, the http_service_tests suite was not using the TestLauncher facilities, which caused it to fail on the waterfall. Bug: 896884 Change-Id: I9ce03cf45f0bd75944dce62bed5e16e2df6a4191 Tested: Locally Reviewed-on: https://chromium-review.googlesource.com/c/1292591 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#601368}
-
Min Qin authored
We already started removing cancelled and non-resumable download from history DB. And we should do the same for download DB. This CL moves all the logic of clearing those download into DownloadManagerImpl. Here is the work flow: 1. when in-progress download manager is loaded, clear all the non-resumable downloads. 2. When DownloadHistory loads all the history items, a nullptr will be returned if the history item should be cleaned, and history DB will remove the item. 3. After DownloadHistory finished loading, in-progress download manager will remove all the non-resumable downloads, so that we are guaranteed that changes in Download DB are propagated to DownloadHistory This CL also fixes issues that cancelled download in Download DB are not propagated to history DB. BUG=851650 Change-Id: Ieeec319cd429ecca7a327e463e2a869dd00a7f4e Reviewed-on: https://chromium-review.googlesource.com/c/1285318Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/cb21ffe8996b..51cc30c12411 git log cb21ffe8996b..51cc30c12411 --date=short --no-merges --format='%ad %ae %s' 2018-10-19 qingsi@google.com Fix a null reference bug in NetworkMonitorAutoDetect.getNetworkState. Created with: gclient setdep -r src/third_party/webrtc@51cc30c12411 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I19446610dbcd4927d5e92c3e2054c4b6069c5452 Reviewed-on: https://chromium-review.googlesource.com/c/1292284Reviewed-by:
-
Xing Liu authored
This CL checks if the user has SD card. Don't show download location dialog if user don't have SD card. Bug: 896873 Change-Id: I157b8958669c0692247f7cf3798f32867675b11c Reviewed-on: https://chromium-review.googlesource.com/c/1290509Reviewed-by:
-
Hans Wennborg authored
This fixes Clang's newly enhanced -Wshadow warning which now covers enums (see bug), and also makes the code nicer. TBR=jochen Bug: 895475 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ia8c8fff99b93efcd2c8278cd0b2ac739c4e0c917 Reviewed-on: https://chromium-review.googlesource.com/c/1289471 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#601364}
-
Dan Harrington authored
PageAutoFetcher isn't yet used, but it is fully functional. It schedules requests and cancels scheduled requests, and uses a new client policy. Note PageAutoFetcher isn't yet called anywhere. Bug: 883486 Change-Id: If1f9ed401e30466d6c55f7598477150feb983f27 Reviewed-on: https://chromium-review.googlesource.com/c/1234358Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Cathy Li <chili@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Commit-Queue: Dan H <harringtond@google.com> Cr-Commit-Position: refs/heads/master@{#601363}
-
Ken Rockot authored
This was revealed by https://chromium-review.googlesource.com/c/chromium/src/+/1145692 which makes subtle changes to Mojo message dispatch timing and can thus expose incorrect assumptions in various bits of code. In this case, there is a race between AbandonAudioFocus and receiving a reply from a previous call to RequestAudioFocus on the audio_focus_ptr_. The callback which handles the latter reply DCHECKs that request_client_ptr_ is bound, but it's possible for AbandonAudioFocus to have been called before that reply is dispatched. The above Mojo CL in question causes some unit tests to flake by hitting this DCHECK occasionally. This CL corrects the issue by also resetting audio_focus_ptr_ in AbandonAudioFocus, which ensures that any pending replies on that interface will *not* be dispatched. This also fixes a bug in AudioFocusManagerMetricsHelper (also revealed by this CL) where it was retaining a *reference* to an unowned std::string that could be deleted before the helper. This is because the string was ultimately owned by a binding endpooint, but the helper is owned by a StackRow which can outlive any given binding endpoint. Because the name is effectively only useful at helper construction time, this simply changes the helper to retain a copy instead of a reference. TBR=mlamouri@chromium.org Bug: 895693 Change-Id: I958b783d005cb85dc9dc9f7371df100883d774cb Reviewed-on: https://chromium-review.googlesource.com/c/1286202 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#601362}
-
- 19 Oct, 2018 24 commits
-
-
Takuto Ikuta authored
This CL is part of https://chromium-review.googlesource.com/c/chromium/src/+/1286017 This CL was uploaded by git cl split. R=mef@chromium.org Bug: 681136 Change-Id: I55220b203c6798614bd7978710aa6fe3669c70dc Reviewed-on: https://chromium-review.googlesource.com/c/1288348Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#601361}
-
David Black authored
For Assistant, we use a horizontal BoxLayout which relies on GetHeightForWidth to determine chip size. By removing this method override we will no longer respect kPreferredHeightDip. Screenshot in the bug. Bug: b:117991892 Change-Id: Ic6b889a477b262290285ad5e61c3922ee43ceb6f Reviewed-on: https://chromium-review.googlesource.com/c/1292608 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#601360}
-
Khushal authored
This was initially added to ensure that the typefaces embedded in a blob were stored in a sidelist on the blob, in order to enable serialization of typefaces for OOP raster. This is no longer required and the wrapping is just unnecessary overhead. R=drott@chromium.org,enne@chromium.org Bug: 816445,894200 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I76f106d13ce1aa04a50aadb0d4faa98dafe7a688 Reviewed-on: https://chromium-review.googlesource.com/c/1289571 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#601359}
-
Xiaohui Chen authored
Bug: b/117937718 Test: locally build and see logs on device. Change-Id: Iea6b72b328c57d3c37e58692e2146f0b71c3218c Reviewed-on: https://chromium-review.googlesource.com/c/1292549Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#601358}
-
Xiyuan Xia authored
Fix CrossProcessMouseEnterAndLeaveTest by waiting for initial mouse event to be dispatched because the event is asynchronously dispatched in mash. Bug: 884360 Change-Id: I4f40accfb9077e6bb8ccab5128b42c66493e84ed Reviewed-on: https://chromium-review.googlesource.com/c/1292398Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#601357}
-
James Darpinian authored
When using EXT_multisampled_render_to_texture, glReadPixels fails in recent Qualcomm Adreno drivers. glCopyTexImage2D still works, so the workaround is to create a temporary texture, glCopyTexImage2D, and then glReadPixels from the temporary texture. WebGL conformance test updates for this bug are here: https://github.com/KhronosGroup/WebGL/pull/2729 This workaround will be revisited in the passthrough command decoder and ANGLE when the switch is made to use those for WebGL on Android. dEQP test is here: https://android-review.googlesource.com/c/platform/external/deqp/+/796566 Bug: 890002 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I6254242258411997fcfbb3f0145801b398073778 Reviewed-on: https://chromium-review.googlesource.com/c/1279354 Commit-Queue: James Darpinian <jdarpinian@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#601356}
-
Victor Costan authored
This CL disables window functions, which were introduced in SQLite 3.25 [1], and PostgreSQL-style UPSERT, which was introduced in SQLite 3.24 [2]. This reduces the binary size by 57,376 bytes on a Linux official build. The sqlite3.c diff was entirely generated by re-running the updated generated_amalgamation.sh script. [1] https://www.sqlite.org/windowfunctions.html#history [2] https://www.sqlite.org/lang_UPSERT.html Bug: 896685, 892852 Change-Id: Ia501d35993c382445e6a70348dd1643037969245 Reviewed-on: https://chromium-review.googlesource.com/c/1290510Reviewed-by:
Chris Mumford <cmumford@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#601355}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/3bcd7ab930ad..6c448e3f5b2f git log 3bcd7ab930ad..6c448e3f5b2f --date=short --no-merges --format='%ad %ae %s' 2018-10-19 oysteine@google.com Merge "Add an Message::AppendScatteredBytes function" Created with: gclient setdep -r src/third_party/perfetto@6c448e3f5b2f The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: If04c93bf1547f31c541024cf01e334b9c98a78f2 Reviewed-on: https://chromium-review.googlesource.com/c/1292283Reviewed-by:
-
Bo Liu authored
Bug: 895871 Change-Id: Idb6d382891affa99a4976e3e8b83efd1b437e5b6 Reviewed-on: https://chromium-review.googlesource.com/c/1292396Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#601353}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/42bb3604bce4..41ba826ad7b4 git log 42bb3604bce4..41ba826ad7b4 --date=short --no-merges --format='%ad %ae %s' 2018-10-19 brianosman@google.com (Almost) no one needs to know about SkPixelRef 2018-10-19 halcanary@google.com SkQP: rely on TestRunner for logging 2018-10-19 brianosman@google.com Play back picture shaders in 8888 or F16, depending on dst color type 2018-10-19 brianosman@google.com Ensure that we allocate 32-bit pixels in GM's generator Created with: gclient setdep -r src/third_party/skia@41ba826ad7b4 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=egdaniel@chromium.org Change-Id: Ibcb92a1ab32784f1643b4d507dbe505f883da48d Reviewed-on: https://chromium-review.googlesource.com/c/1292389Reviewed-by:
-
Zach Helfinstein authored
This fixes an issue with navigation where an invisible object was highlighted when navigating backwards. Bug: 864820 Change-Id: Id4e8971122f8335d1754ed197cf8a46fbbe1b79b Reviewed-on: https://chromium-review.googlesource.com/c/1281324Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Zach Helfinstein <zhelfins@chromium.org> Cr-Commit-Position: refs/heads/master@{#601351}
-
Joe Downing authored
TBR=aee@chromium.org BUG=877109 Change-Id: Ie95d35f83e8016ae9b0c4b60f67481217a2e3c6d Reviewed-on: https://chromium-review.googlesource.com/c/1292710Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#601350}
-
James Cook authored
This fixes a problem with restoring minimized windows. The client needs to know that the window is not visible to know that it is allowed to restore it. Fixes the following tests: -AppWindowApiTest.OnRestoredEvent -BrowserActionApiTest.BrowserActionPopupWithIframe -FirstRunUIBrowserTest.ModalWindowDoesNotBlock -LauncherPlatformAppBrowserTest.PackagedAppClickBehaviorInMinimizeMode -LoginWebDialogTest.CannotMinimize -LoginWebDialogTest.CloseDialogByAccelerator -ShelfAppBrowserTestNoDefaultBrowser.BrowserShortcutLauncherItemController Bug: 855767 Test: added to services_unittests Change-Id: Icb1a12e4dd18f68807bf0dc9140ce289e9ea913c Reviewed-on: https://chromium-review.googlesource.com/c/1292053Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#601349}
-
Antoine Labour authored
Remove use-after-moved-from on the SharedImageBacking. Bug: 891059 Change-Id: I663e019033145477fbe3719b7441da59e0fedd50 Reviewed-on: https://chromium-review.googlesource.com/c/1292550Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#601348}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/4ec1257ee988..bd5d55eea5c0 git log 4ec1257ee988..bd5d55eea5c0 --date=short --no-merges --format='%ad %ae %s' 2018-10-19 dgarrett@google.com config_builders: LuciSchedulerBuilder needs InitSDK. 2018-10-19 vapier@chromium.org cbuildbot: reject CLs using topics for now 2018-10-19 jclinton@chromium.org luci-scheduler: Update to allow others to trigger builds 2018-10-19 dgarrett@google.com waterfalls: Remove WATERFALL_EXTERNAL 2018-10-19 dgarrett@google.com waterfalls: Remove constants for dead waterfalls. Created with: gclient setdep -r src/third_party/chromite@bd5d55eea5c0 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ib66850412b4d5797cd7cc25a45661cec0e0c9081 Reviewed-on: https://chromium-review.googlesource.com/c/1292282Reviewed-by:
-
Xiaoqian Dai authored
... the selection widget is already active or the filter string is empty. Bug: 893384 Change-Id: I793e083991ef60361a4ca3056347a4023919b240 Reviewed-on: https://chromium-review.googlesource.com/c/1292713Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#601346}
-
chaopeng authored
This crash is because we have root layer is null and we don't handle it properly. Root layer is null can happen if a scroll occurs before the root layer is attached. In this patch, we return SCROLL_IGNORED with kNoScrollingLayer reason, same as what we did in ScrollBegin. Bug: 895817 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I9937ae2d494f4466018a3ee9a35e787e5e745bd6 Reviewed-on: https://chromium-review.googlesource.com/c/1289437Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
-
Xu Xing authored
When skia works in CPU mode, color should be 0x00000000, 0x00000000,0x2f0000ff, 0x2f00ff00, 0x3fff0000, 0x7fff0000. When it turns to GPU, the R and B should be swapped. Skia mainly works in GPU mode, so change this color to a GPU friendly color. However, the best solution is to support both CPU mode and GPU mode. Add TODO for this. Bug: 889122 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I71aa1d2ae34ab10a41ba5d58e1e2cbb6867bec6b Reviewed-on: https://chromium-review.googlesource.com/c/1253407Reviewed-by:
-
Kent Tamura authored
Currently make_names.py produces blink::FooBarNames::baz_hoge constant variables. They don't match to Google C++ style. This CL adds capability to produce code following Google C++ style. If 'namespace' field in foo_bar_names.json5 contains capital letters, the behavior isn't changed. Otherwise, - Don't append 'Names' to C++ namespace - Prepend 'k' to UpperCamelCase names So 'blink::foo_bar::kBazHoge' will be produced. Bug: 889726 Change-Id: Iac8ca8040782c440d755067bec7c738d92189878 Reviewed-on: https://chromium-review.googlesource.com/c/1288518Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#601343}
-
Kent Tamura authored
Currently make_qualifed_names.py produces blink::FooNames::baz_hogeTag constant variables. They don't match to Google C++ style. This CL adds capability to produce code following Google C++ style. If 'namespace' field in foo_tag_names.json5 or foo_attribute_names.json5 is in the following list, the behavior isn't changed. 'HTML', 'MathML', 'SVG', 'XLink', 'XML', 'XMLNS' Otherwise, - C++ namespace name is {{namespace|lower}}_names, not {{namespace}}Names - Prepend 'k' to UpperCamelCase tag/attribute names So 'blink::foo_names::kBazHogeTag' will be produced. Bug: 889726 Change-Id: I997ab91b79cc13baa46e8e519e3bccb9cecc72ce Reviewed-on: https://chromium-review.googlesource.com/c/1290052Reviewed-by: -
Yuri Wiitala authored
Refactors and cleans-up code, transforming GLHelperScaling's internal "ScalerImpl" class into a GLScaler::ScalerStage class. A ScalerStage chains together with other ScalerStages to perform each step from the source input to ultimate scaled output. (A future change will provide the logic for deciding how to create/configure ScalerStages and chain them together.) A major change other than the refactoring: The math that calculates each shader's "overscan" padding has been revisited and corrected. New math is included in this change, along with pixel tests that confirm it is correct (i.e., tests the math, but also runs the shader programs to prove the numbers jive). Bug: 870036 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I3dbbbb8f8cca45006895faed6d7501ceab5cc1cb Reviewed-on: https://chromium-review.googlesource.com/c/1285328Reviewed-by:
Xiangjun Zhang <xjz@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Commit-Queue: Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#601341}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 238d339e. With Chromium commits locally applied on WPT: f79c6fe7 "Reimplementing getDatabaseNames() as databases() for indexeddb." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/26402 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: binji@chromium.org: external/wpt/wasm foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org: external/wpt/infrastructure hbos@chromium.org, hta@chromium.org: external/wpt/webrtc meade@chromium.org: external/wpt/web-animations rouslan@chromium.org, mathp@chromium.org: external/wpt/payment-request skobes@chromium.org: external/wpt/css/css-scroll-anchoring yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch NOAUTOREVERT=true TBR=kyleju No-Export: true Change-Id: I8267c4c8b76799a27f64243ada1a8cca4e73e50d Reviewed-on: https://chromium-review.googlesource.com/c/1292517 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#601340}
-
danakj authored
This is called when there's no frame for the WebWidget, which is bad. Since this is a problem in M71, here's something small for an easy merge. I have a better fix for at least one case where this can happen in a follow-up, in which I'll revert this hack. R=enne@chromium.org Change-Id: Icbffcad6a0fe74bf1ae47e1d51c65aba844ccc5e Bug: 896836 Reviewed-on: https://chromium-review.googlesource.com/c/1292711Reviewed-by:
-
chrome://accessibilityJames Wallace-Lee authored
When the accessibility mode is toggled for individual pages, update the single row by calling showTree rather than refreshing the whole page. Bug: 877705 Change-Id: I5c7986fc970f9789bb421525ccea5f68f5fd57e9 Reviewed-on: https://chromium-review.googlesource.com/c/1269236 Commit-Queue: James Wallace-Lee <jamwalla@chromium.org> Reviewed-by:
-
