- 27 Apr, 2018 40 commits
-
-
Nektarios Paisios authored
In preparation for a big refactoring of our logic that computes character and object bounds. Important changes: 1. Wrote additional tests for scrollable editables and strengthened test for scrollable containers. 2. Tests that the height is the same across lines. More cosmetic changes: 3. Replaced all-caps constants with newer style guide constants that start with "k". 4. Used raw litteral strings (a C++ 11) feature that allows the use of quotes in HTML code without escaping or the need to remember to use single quotes. 5. Split SetUp methods into more helper functions. 6. Introduced SetUp method for creating scrollable input field and added a test for it. 7. Stopped using net::EscapeQueryParamString because it was not appropriate for escaping HTML code. R=aleventhal@chromium.org, dmazzoni@chromium.org Change-Id: I7d9387323ae35a353dc62096c151355897f925eb Reviewed-on: https://chromium-review.googlesource.com/1030842 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#554462}
-
Takashi Toyoshima authored
This patch changes DocumentThreadableLoader not to handle CORS-preflight, but to delegate it to CORSURLLoader. Originally preflight errors and usual CORS errors shared a common error code set, and append extra error strings for preflight errors, based on the context that DocumentThreadableLoader knows. After this change, we define different error code for each case so that DocumentThreadableLoader can create right error strings without error contexts that only CORSURLLoader knows. CORSURLLoader is also modified to set the HTTP Origin header when it is needed, and now use PreflightController to perform required preflight checks. PreflightController is modified to use WrappedLegacyURLLoaderFactory. This is unfortunate, but to make it work with legacy URLLoaderFactory that relies on ResourceDispatcherHost that needs the legacy request_id. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ibf82243ecf14be84bb11122f733c4cb9030d41b8 Bug: 803766 Tbr: kinuko@chromium.org Reviewed-on: https://chromium-review.googlesource.com/997914 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#554461}
-
Xiaohan Wang authored
- Add MockLibraryCdm, a mock implementation of library CDM interface so that we can have more control in the test cases. - Refactor CdmAdapter so that CreateCdmFunc is passed in constructor - Refactor CdmAdapterTest so that it can take different CreateCdmFuncs * CdmAdapterTestWithClearKeyCdm uses Clear Key CDM and uses the CreateCdmFunc provided by CdmModule. * CdmAdapterTestWithMockCdm uses CreateMockCdmInstance to use MockLibraryCdm for testing. - Add tests for ChallengePlatform, CreateFileIO and RequestStorageId using CdmAdapterTestWithMockCdm. Bug: 836046 Test: Test class refactoring; added more tests. Change-Id: If79922b26b57793f8e75f86e583109b0495fda58 Reviewed-on: https://chromium-review.googlesource.com/1027003 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#554460}
-
Kyle Horimoto authored
This is necessary because these flags need to be accessed from within //ash and //chromeos, which do not have access to chrome_features.h since it resides in //chrome. Bug: 824568, 752273 Change-Id: I2d20f244bc88758825dd37edf5b9956336017563 Reviewed-on: https://chromium-review.googlesource.com/1029228 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Stefan Kuhne <skuhne@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#554459}
-
Michael Lippautz authored
The visitor passed for tracing should not be const as tracing actually modifies visitor-internal state. The tracing methods themselves and their parameters should remain const. The CL changes virtual void TraceWrappers(const ScriptWrappableVisitor*) const; to virtual void TraceWrappers(ScriptWrappableVisitor*) const; Bug: v8:7570 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ib0132069baac8609a347ebb9c48aa6eda490ffa7 Reviewed-on: https://chromium-review.googlesource.com/1032558 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#554458}
-
John Budorick authored
TBR=danakj@chromium.org Bug: 837515 Change-Id: I315d5b9b2add8fd2c06a1c032bf20e4f3c950f85 Reviewed-on: https://chromium-review.googlesource.com/1032872Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#554457}
-
Xiaohan Wang authored
1. Change constant variable naming style, e.g. VP9 -> Vp9. According to the style guide [1]: "when abbreviations appear in such (Camel Case) names, prefer to capitalize the abbreviations as single words (i.e. StartRpc(), not StartRPC())". 2. Update TestMp4EncryptionPlayback() to take a |media_type|, in preparation for adding other MP4 tests, e.g. FLAC. 3. Some misc changes. [1] https://google.github.io/styleguide/cppguide.html#Variable_Names Bug: 327115 Test: No functionality change. Change-Id: Iab1243ad05f85d2aa845838cd1ab30606245cbf3 Reviewed-on: https://chromium-review.googlesource.com/1031557Reviewed-by:
-
Charlie Harrison authored
This CL also - Aggregates all subresource_filter tools into a single target - changes subresource_filter tools to use the same (but equiv) condition as some other tools - Adds that target to "all" Bug: 833419 Change-Id: I732ac0860f90e036281bdf899f8b5e6e92f3f3e5 Reviewed-on: https://chromium-review.googlesource.com/1031211Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#554455}
-
David Benjamin authored
https://boringssl.googlesource.com/boringssl/+log/9f0e7cb314ae64234b928fd379381ae9760a9a5f..cece32610b89549386b42b2032dd5d8a423af6c8 BUG=none Change-Id: I3e35ab9410002fd62c6b7d75ef1cf7edbda41b44 Reviewed-on: https://chromium-review.googlesource.com/1028870Reviewed-by:
Steven Valdez <svaldez@chromium.org> Commit-Queue: Steven Valdez <svaldez@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#554454}
-
Dan Zhang authored
Flip flags. https://chromium-review.googlesource.com/c/chromium/src/+/1028457 Use Google QUIC padding frame methods for both Google QUIC and IETF QUIC Removes a separate IETF Padding methods. The Google QUIC methods can be used for both QUICs. N/A no operational impact, no code added and removed code was not wired in. This work being done to develop support for IETF-format QUIC. Merge internal change: 193920140 https://chromium-review.googlesource.com/c/1027805/ Default enable QUIC ack decimation. Protected by FLAGS_quic_reloadable_flags_quic_default_enable_ack_decimation. Merge internal change: 193716416 https://chromium-review.googlesource.com/c/1027908/ Remove the IETF Quic BLOCKED frame, fold into Google QUIC BLOCKED N/A -- code is not live. This work done in support of extending QUIC to use IETF QUIC. Merge internal change: 193706746 https://chromium-review.googlesource.com/c/1028179/ In QUIC, enable fast path in QuicStreamSendBuffer::FreeMemSlice. Protected by FLAGS_quic_reloadable_flag_quic_fast_free_mem_slice. Merge internal change: 193700647 https://chromium-review.googlesource.com/c/1027802/ Rename objects for IETF Quic MAX_STREAM_ID and STREAM_ID_BLOCKED frames Objects were QuicIetf<mumble>, renamed to just <mumble>. This entails renaming files and changing object class names. No logic/etc changes. In addition, the Process... and Append... methods in QuicFramer were renamed from ProcessIetf.../AppendIetf... to Process.../Append... This code is not live, is done in support of developing IETF compatible QUIC. N/A All modified code is unreachable in prod. Merge internal change: 193684938 https://chromium-review.googlesource.com/c/1027898/ Add IETF NEW_CONNECTION_ID frame to quic/core/frames and associated changes. This in support of continuing effort to develop a QUIC version that is complient with IETF-QUIC. N/A, changes in this CL are not live. Code is unreachable Merge internal change: 193664616 https://chromium-review.googlesource.com/c/1027896/ Add IETF APPLICATION_CLOSE frame to quic/core/frames This adds appropriate files to the directory, extends quic/core/frames/quic_frame.[cc|h] to support addition of this frame, and so on. This is in support of the developing IETF QUIC. N/A No impact, none of this code is live. Merge internal change: 193659905 https://chromium-review.googlesource.com/c/1026424/ In QUIC, detect lost packets from last largest lost packet. Protected by FLAGS_quic_reloadable_flag_quic_incremental_loss_detection. Merge internal change: 193547935 https://chromium-review.googlesource.com/c/1026487/ (n/a) Deprecate FLAGS_quic_reloadable_flag_quic_fix_write_out_of_order_queued_packet_crash. Merge internal change: 193534820 https://chromium-review.googlesource.com/c/1026486/ Use CurrentSupportedVersions() instead of AllSupportedVersions() in Quartc. n/a (Quartc change) Merge internal change: 193442805 https://chromium-review.googlesource.com/c/1026484/ In QUIC, protect respecting IETF header with FLAGS_quic_reloadable_flag_quic_respect_ietf_header. Merge internal change: 193417278 https://chromium-review.googlesource.com/c/1026483/ Allow effective peer migration to start even if an active migration is ongoing. Protected by new flag FLAGS_quic_reloadable_flag_quic_enable_server_proxy2. Merge internal change: 193388751 https://chromium-review.googlesource.com/c/1026482/ Change uint128 to QuicUint128 Merge internal change: 193384460 https://chromium-review.googlesource.com/c/1026481/ Let quic_client default talk current supported version instead of all versions. n/a (tools only change) Merge internal change: 193349968 https://chromium-review.googlesource.com/c/1026478/ In QUIC, allow pacing in multi-packet bursts. Protected by existing FLAGS_quic_reloadable_flag_quic_simplify_pacing_sender. The burst size is controlled by FLAGS_quic_lumpy_pacing_size and FLAGS_quic_lumpy_pacing_cwnd_fraction. Merge internal change: 193255305 https://chromium-review.googlesource.com/c/1026416/ Deprecate FLAGS_quic_reloadable_flag_delay_quic_server_handshaker_construction and --gfe2_reloadable_flag_quic_store_version_before_signalling Merge internal change: 193242173 https://chromium-review.googlesource.com/c/1026414/ Tag certificate chains as const. n/a (if it compiles, it's a no-op) Merge internal change: 193238365 https://chromium-review.googlesource.com/c/1026473/ Add a QUIC_FLAG_COUNT for FLAGS_quic_reloadable_flag_quic_unified_send_alarm. n/a (Add FLAG_COUNT) Merge internal change: 193210262 https://chromium-review.googlesource.com/c/1026413/ (n/a) Allow QuicPacketWriterWrapper to take a non-owning underlying writer. Not protected. Merge internal change: 193203968 https://chromium-review.googlesource.com/c/1026472/ Allow QuicDispatcher(and subclasses) to save and restore arbitrary packet processing context. Only used in unit test, not protected. Merge internal change: 193069438 https://chromium-review.googlesource.com/c/1026412/ R=rch@chromium.org Change-Id: I3780420de6f9174a934cbcf2c6486716b6fb10e1 Reviewed-on: https://chromium-review.googlesource.com/1028459Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Dan Zhang <danzh@chromium.org> Cr-Commit-Position: refs/heads/master@{#554453}
-
danakj authored
Instead of duplicating this bit off the compositor ContextProvider, query it directy on the ContextProvider that will be held differently as a result of its value. R=piman@chromium.org, pdr Bug: 826886 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ia9a4f7ca4d9cbf10121f7d729d4068a6f9b93e90 Reviewed-on: https://chromium-review.googlesource.com/1026839 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#554452}
-
Lei Zhang authored
BUG=826700 Change-Id: I7cd5a32bb227d5ad07f8d0941aff922e10793790 Reviewed-on: https://chromium-review.googlesource.com/1025315Reviewed-by:
Georges Khalil <georgesak@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#554451}
-
erikchen authored
This CL is a refactor and has no intended behavior change. This CL updates AddWebContents to use explicit ownership semantics. This CL fixes some of the subclasses to have proper ownership semantics, and leaves behind some TODOs for other subclasses. Bug: 832879, 674318 Change-Id: I6294e591e9166dfb0c029eb78648c17216075dab TBR: skyostil@chromium.org, carlosk@chromium.org, torne@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1028631Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#554450}
-
Per Åhgren authored
This CL adds a command line switch based on base::Feature to allow the user to turn on the experimental WebRTC AEC feature for providing increased transparency to stationary render noise. Bug: chromium:836925 Change-Id: I941b3a26b5b4c657df37ceba69af6b548182713d Reviewed-on: https://chromium-review.googlesource.com/1027817Reviewed-by:
Nick Carter <nick@chromium.org> Commit-Queue: Per Åhgren <peah@chromium.org> Cr-Commit-Position: refs/heads/master@{#554449}
-
Kevin Marshall authored
* Delete runner V1 scripts. * Relocate runner V2 scripts to runner V1 location, and remove "runner_v2" directory. * Delete unused GN attributes and transitional GN groups(). * Remove override flags from Fuchsia FYI buildbots. Bug: 805057 Change-Id: I62e8fbfa200ebf31bd0a766bc276477ddca0b673 Reviewed-on: https://chromium-review.googlesource.com/1031564Reviewed-by:
Scott Graham <scottmg@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#554448}
-
Conley Owens authored
This change removes all Play Services Nearby-based scanning from chromium. BUG=826540 Change-Id: Id7b8a31724ac81709e056617bf003d7d43d5991c Reviewed-on: https://chromium-review.googlesource.com/1028512Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Conley Owens <cco3@chromium.org> Cr-Commit-Position: refs/heads/master@{#554447}
-
Parastoo Geranmayeh authored
Reflected synthetic fields: Reflected synthetic fields are synthetic fields for which if one changes the visibility of the corresponding hidden select field in the source code, and select an option on that, as a user would do, the change would be reflected on the synthetic field. Solution: we can fill a reflected multiple field, by making an exception for select fields. Previously, this exception was made for non-focusable ones, meaning that a non-focusable select field would get autofilled, even though it wasn’t visible. We need to broaden this exception to include the fields with ‘role=presentation’. This will fix the problem. Fixes: chapters.indigo.com www.newbalance.com See: go/synthetic-fields for more on this issue. Bug: 836949 Change-Id: Iefad5de1432e5c2a8a64c0ec9bf79a6db9f557b1 Reviewed-on: https://chromium-review.googlesource.com/1028721 Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#554446}
-
Abhishek Arya authored
Bug: 821574 Change-Id: Ibdc60dd4731c141ab59b3faba7fd2c0c3835d1cb Reviewed-on: https://chromium-review.googlesource.com/1031712 Commit-Queue: Abhishek Arya <inferno@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#554445}
-
John Budorick authored
Bug: 824594,824593,809571,790121,789564,731400 Change-Id: I7b1964b4c2c80f5b1b13329098a161e372f58202 Reviewed-on: https://chromium-review.googlesource.com/1032885 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Cr-Commit-Position: refs/heads/master@{#554444}
-
https://webrtc.googlesource.com/src.git/+log/95141d91d8ab..169c7fd521da $ git log 95141d91d..169c7fd52 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=chromium:837563 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Iaa07e0d7ffe3f545cd5d2200e45ad5e3de4b3f43 Reviewed-on: https://chromium-review.googlesource.com/1033178 Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#554443}
-
https://chromium.googlesource.com/catapult.git/+log/82069c8b6ea2..6761f26bd9da $ git log 82069c8b6..6761f26bd --date=short --no-merges --format='%ad %ae %s' 2018-04-26 szager Don't default to NoopArtifactResults 2018-04-27 perezju [devil] Add version_codes.OREO Created with: roll-dep src/third_party/catapult BUG=chromium:831199 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I67d58104c1c892da7a171cc7ae67455a8899b4bc Reviewed-on: https://chromium-review.googlesource.com/1033180 Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#554442}
-
Erik Luo authored
Currently, all DOM constructors are treated as side-effect-free. This CL introduces `[Affects=Everything]` to blacklist constructors. While Worker/SharedWorker constructors produce effects: - `new Worker` can asynchronously loads script (violates "fetch resources", "schedule execution") - `new SharedWorker`, by spec, may "queue a task" or "in parallel, run a worker" and update the global scope's worker set (violates "schedule execution", "cache objects") Bug: 829571 Change-Id: I931efb6212e2ac77be81d3dd721d6dba96a85097 Reviewed-on: https://chromium-review.googlesource.com/1027088Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#554441}
-
Mathieu Perreault authored
Was no longer being used. As well, rename StartUploadProcess to MaybeStartVoteUploadProcess. Tbr: vabr@chromium.org Bug: None Test: existing Change-Id: I7594bd79daa5f7878806de528c3e62ec0b70909b Reviewed-on: https://chromium-review.googlesource.com/1032752 Commit-Queue: Mathieu Perreault <mathp@chromium.org> Reviewed-by:
-
Greg Kraynov authored
Extracted from https://chromium-review.googlesource.com/1015743 Required in order to move Blink's scheduler/base to //base. Bug: 783309 Change-Id: Iff610ed6da964fb6c93de070ac81916bec5dceba Reviewed-on: https://chromium-review.googlesource.com/1032781Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Greg Kraynov <kraynov@chromium.org> Cr-Commit-Position: refs/heads/master@{#554439}
-
Weidong Guo authored
Background: The dcheck in AppListView::SetIsIgnoringScrollEvents fails when user scroll up and down quickly. (The pagination transition starts again before ends). Changes: Do not make decision based on |is_ignoring_scroll_events_| which is set by state change animation or pagination transition. Instead, check the animator and pagination model directly to decide whether to ignore scroll events. BUG=836088 Change-Id: Ic7aef13e53d299af3165082d7dfa2f89974e20c0 Reviewed-on: https://chromium-review.googlesource.com/1031207 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#554438}
-
Becky Zhou authored
Bug: 831782 Change-Id: I7558d68a41f30120b6c573b9752612215e35b115 Reviewed-on: https://chromium-review.googlesource.com/1031293Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#554437}
-
Nasko Oskov authored
When a remote frame is navigated to about:blank#foo in --site-per-process mode it is routed to the browser process through a RenderFrameProxyHost. It then considers the navigation to be cross-site due to check for explicit "about:blank" URL in DetermineSiteInstanceForURL. This causes a cross-process navigation and Blink considers the about:blank#foo URL to be same-document with the initial empty document. In turn, it sends a same document commit to the browser process, which considers it a mismatch and terminates the renderer. This CL fixes DetermineSiteInstanceForURL to use GURL::IsAboutBlank, which should cover various types of about:blank URLs. It also ensures that Blink does not consider the first navigation in a provisional LocalFrame to be eligible for same-document commit. Bug: 833005 Change-Id: Ia7d849effbc52efb242b65ca822512bd44b016ff Reviewed-on: https://chromium-review.googlesource.com/1031374Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#554436}
-
John Budorick authored
Change-Id: I86cd999b70f7bf5b7437aa15b9ac610e2f1b1c70 Reviewed-on: https://chromium-review.googlesource.com/1032852Reviewed-by:
Ryan Tseng <hinoka@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#554435}
-
Matthew Jones authored
This patch fixes a number of small issues: - The tab model observer for the controller is attached to the tab model when the browser starts instead of the first tab model change. - The 'suppressed' flag is reset if bottom sheet show requests are cleared. - The didSelectTab event is blocked if the selected tab is the same as the previously selected tab. Bug: 835875, 836403 Change-Id: Ic6688674d3af11e880da8666d5e85e736c6f37ec Reviewed-on: https://chromium-review.googlesource.com/1026151 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
-
Greg Kraynov authored
Inspired by https://chromium-review.googlesource.com/1015743 but not moving it yet, because move will happen in one go. Bug: 783309 Change-Id: I4ef38820accab561b73b28d9bfa9fcd2ee2f47a8 Reviewed-on: https://chromium-review.googlesource.com/1032773Reviewed-by:
-
Ehsan Karamad authored
The test does not require nor use "server-side substitution" and the flag ".sub" was left by mistake. Bug: 611982 Change-Id: I5674911c22d1fb55e7aa41125d343966f4b8a84f Reviewed-on: https://chromium-review.googlesource.com/1033352Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#554432}
-
Gabriel Charette authored
Wait until the physical threads are up and ready to service the task runners before starting the clock to avoid depending on the time it takes to bring up a physical thread (can be slow in simulation environments like Fuchsia+QEMU). R=fdoray@chromium.org, wez@chromium.org Bug: 837341 Change-Id: I7acbec7808c1aa4ad7fefdff6f80693fbfb8e74e Reviewed-on: https://chromium-review.googlesource.com/1030904 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#554431}
-
James Cook authored
It was originally disabled because it was broken in mus, but it works now. Also update the comments for related disabled WebView tests. Bug: 755328 Change-Id: I888957ed89a0a3fb101b965be1666e11d32ebdb9 Reviewed-on: https://chromium-review.googlesource.com/1029226Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#554430}
-
Xi Cheng authored
This test fails on OS_IOS as mentioned in the bug below. So disable it to unblock any related work. This is fine as PersistentHistogramStorage is used only on OS_WIN now. Bug: 836789 Change-Id: I4e86cf4053663d4736cb3242ffaf22c0a1030781 Reviewed-on: https://chromium-review.googlesource.com/1033016Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#554429}
-
Anita Woodruff authored
- Use the fallback Chrome logo instead of attempting to set a custom badge as the status bar icon for all web notifications on Marshmallow Coolpad devices, same as what we do on Samsung Marshmallow devices, to avoid a crash. - Tested with a Coolpad 3600i (the model experiencing most of the non-Samsung crashes) which reports its Build.MANUFACTURER to be 'YuLong'. R=nyquist@chromium.org Bug: 831220 Change-Id: Id475bbda198c7c61fbb4d114bb562826ffd351e5 Reviewed-on: https://chromium-review.googlesource.com/1028271Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Anita Woodruff <awdf@chromium.org> Cr-Commit-Position: refs/heads/master@{#554428}
-
Xing Liu authored
This CL hooks android download code to media gallery util service, which provides the functionality to safely parse media metadata in an utility process. Also includes necessary change to build media gallery util service on Android. Bug: 826021 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ie76992ed65b746b784374b5acefcdebe4e26fe50 Reviewed-on: https://chromium-review.googlesource.com/1028614Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#554427}
-
Tim Zheng authored
This CL adds multiple user support for Crostini apps. Crostini app window is registered to the user who launches it so when user switch happens, Crostini app window will not leak to other users in the session. When user switch occurs, Crostini app windows launched by previous user will be removed from the Shelf and Crostini app windows launched by the current user will be added to the Shelf. BUG=chromium:829159 TEST=Manually tested on an eve device. Change-Id: I2983d7087ffb87764954c2e8799b29a1ba46feec Reviewed-on: https://chromium-review.googlesource.com/1031746Reviewed-by:
David Reveman <reveman@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Tim Zheng <timzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#554426}
-
Hiroshige Hayashizaki authored
Layered API [1] is planning to insert a step that modifies |url| to #fetch-a-module-script-tree, and thus the URLs for #fetch-a-module-script-tree and #internal-module-script-graph-fetching-procedure can be different. However, ModuleScriptFetchRequest::Url() has been used for both of them and thus the same URL is used for both. This CL stops using ModuleScriptFetchRequest for #fetch-a-module-script-tree (i.e. ModuleTreeLinker::FetchRoot() and its callers) and instead pass URL and ScriptFetchOptions separately, in order to modify the URL inside ModuleTreeLinker::FetchRoot() in a following CL [2]. [1] https://github.com/drufball/layered-apis/blob/master/spec.md [2] https://chromium-review.googlesource.com/1013321 This CL also introduced ModuleScriptFetchRequest::CreateForTest(), and make non-test users call the full (previously private) constructor of ModuleScriptFetchRequest. Bug: 829084 Change-Id: I17d34475f0a85a5a1b7212d9bc8530d838e75f20 Reviewed-on: https://chromium-review.googlesource.com/1013317 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#554425}
-
Takuto Ikuta authored
This CL was uploaded by git cl split. R=dcheng@chromium.org Bug: 428099 Change-Id: I50af2e37e8f60b8ca3de001d19528db50ae983a8 Reviewed-on: https://chromium-review.googlesource.com/1032464Reviewed-by:
-
Zhiling Huang authored
Bug: 790520 Change-Id: I02235478ea226e87dd7630e4c579f11fc26c2beb Reviewed-on: https://chromium-review.googlesource.com/1031621 Commit-Queue: Zhiling Huang <hzl@chromium.org> Reviewed-by:
-
