- 28 May, 2020 40 commits
-
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/97a2e2dd..4feef9cc Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib54cc521c90367dfe3ab747642b900b5398a41ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218379Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#772569}
-
Mike Jackson (EDGE) authored
Converting this to a parameterized test, and enabling to run in BMO mode now that https://chromium-review.googlesource.com/c/chromium/src/+/2215078 has landed Bug: 1082854 Change-Id: Ifb8f22adef8b9878e81a80584e5dd61d71f6b5a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219587 Commit-Queue: Mike Jackson <mjackson@microsoft.com> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#772568}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/2b0eafb1de5b..e00d27c6d65b 2020-05-28 greg@lunarg.com Fix missing patch decoration for TessFactor PCF arg (#2249) 2020-05-28 greg@lunarg.com Update SPIRV-Tools to stable. Also SPIRV-Headers to TOT. (#2250) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,ynovikov@google.com Change-Id: I66b44bfee4e3b01d84f2686dd124e2edf4b0d743 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218583Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#772567}
-
Moe Ahmadi authored
zero-prefix suggestions disabled search suggest chips. In order to better understand the impact of search suggest chips on realbox performance SearchSuggestChips feature will be used in the latest realbox experiments in M83. This feature has been tested on Canary as part of NtpRealboxZeroPrefixSuggestionsDesktop study Change-Id: Id8f2f0e69da06af5203dc842c66dd01d6d5bfb7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218723Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#772566}
-
Sadrul Habib Chowdhury authored
In some web-tests, the compositor may not have a scheduler, and this can cause a crash. To fix this cash, update the code to not depend on the scheduler, and instead directly pass in the appropriate BeginFrameArgs instance through the SchedulerClient API. BUG=1086387 Change-Id: I160484f2be311f3ae3dffc983c4d0448ca3bae5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219163 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#772565}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/55c85f66d2fd..a3636ed8883d 2020-05-28 jiawei.shao@intel.com Support multiple array layers in one texture-to-texture copy command 2020-05-28 jiawei.shao@intel.com Disallow using cube or cube array texture views as storage textures If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I4bd0a8b174b49d17e95662f362efd5a52cbbba3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219433Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f5dace0f1e57..6a184fe947ed 2020-05-28 ynovikov@chromium.org Fix use_libfuzzer build 2020-05-27 cnorthrop@google.com docs: Update ANGLE for Android documentation 2020-05-27 kbr@chromium.org Emulate unsized depth/stencil textures on ES 3.0 without OES_depth_texture. 2020-05-27 tobine@google.com Vulkan:Initial worker thread disabled by default If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@google.com Change-Id: I1336abcced0aa13693dc53f46af1a0b04369a478 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218666Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1590623692-0f578bc687b2561083fd54c973f9fd861443060a.profdata to chrome-mac-master-1590637846-f24e6c1a243316554d5b0c2334884adcb37c67bd.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I94fce3cfbf9c53587744a0f9683f56c2769c3d62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219627Reviewed-by:
-
Sadrul Habib Chowdhury authored
The CL was reverted due to flake failures of the test enabled in this CL. The fix is to allow for some errors when comparing the scroll offsets, since it can be any fractional value. Original CL description: === Update API to set fractional wheel deltas on android, and remove the code that explicitly used to remove precision. TBR=yfriedman@ for content/public (already reviewed in original CL) BUG=1085890 Change-Id: Id59b1bd38c62a7724334eeb7b0e45c7ba2ecde40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217117 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#772561}
-
Chris Harrelson authored
As of this commit [1], it was previously limited to positioned elements. [1] https://chromium.googlesource.com/chromium/src/+/0a7940331530fc647dbd37e6bcce20540271234a Bug: 1087177 Change-Id: Ief3013338d63b59a88a788fced0e185e293de850 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219312Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#772560}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/d3a01e5713dc..192fcf03f956 2020-05-28 dberris@chromium.org pinpoint: Add the "pin" field in bisection form 2020-05-28 fancl@chromium.org auto-bisect: Implementing Auto-Bisection 2020-05-28 dberris@chromium.org pinpoint: Fix 'try a patch' dialog If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:10791706,chromium:1079183,chromium:1087144 Tbr: rmhasan@google.com Change-Id: Ie68629bba66f4f7e61fc2752c2ec2ce840e43ca5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219547Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f58d7039ba44..d4771af96b5e 2020-05-28 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ib8d740b1e599ed44ab85093bbde6c991221c9002 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219549Reviewed-by:
-
Jinsuk Kim authored
ContentView was not being removed together with WebContents wrapped in ThinWebView. This CL makes sure to remove it from the view hierarchy. Bug: 1080552 Change-Id: I54c81d8c0b67b35340af0a875c671d4bdd119599 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212240Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#772557}
-
Eric Willigers authored
Existing menu code such as RenderViewContextMenu assumes the icons are available synchronously. We cache the favicon for each web app. If no icon is cached, the menu item is shown with no visible icon. References to Bookmark Apps in RenderViewContextMenu are replaced with references to web apps. Bug: 1052707 Change-Id: Ib6dd23c448e01dfb36575008532fcce76b339ddd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216834 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Maggie Cai <mxcai@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
-
Joey Scarr authored
This is a reland of ac81b31b Original change's description: > Move linux-blink-cors-rel from fyi to chromium.linux. > > This is to enable the bot to be sheriffed. > > Bug: 1086320 > Change-Id: I0e379f7b168ce3d13874a399d953c251bede8a9c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215763 > Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> > Reviewed-by: Takuto Ikuta <tikuta@chromium.org> > Reviewed-by: Erik Staab <estaab@chromium.org> > Commit-Queue: Joey Scarr <jsca@chromium.org> > Cr-Commit-Position: refs/heads/master@{#772501} Bug: 1086320 Change-Id: Ia450854e7d76cf64f48178fc8054db4d02ef5b59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217755Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Joey Scarr <jsca@chromium.org> Cr-Commit-Position: refs/heads/master@{#772555}
-
Yoshifumi Inoue authored
This patch changes "doubleclick-beside-cr-span.html" to utilize |selection_test()| for ease of maintenance and help to implementing EditingNG. Bug: 707656, 679977 Change-Id: Ibee76fe9911b05e394e750e9d4effece1a9941d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215871 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#772554}
-
nancylingwang@google.com authored
When system startup, windows restored can’t get the visible and activated status from OnWindowVisibilityChanged and OnWindowActivated. Also web apps are ready at the very late phase which delays the shelf id setting for windows. So check the top window's visible and activated status when we have the shelf id. Fix the instance state issue when drag the browser tabs. The top window could be changed when drag a tab to switch between browsers, so update the relation for tab windows and browser windows. Bug: 1085284 Change-Id: I47ccf5e8c14d8ce6632bf469903709ddbadfbf8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2190075 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#772553}
-
Kent Tamura authored
Only ListBoxSelectType uses them. Bug: 1052232 Change-Id: I760693d453bb56e0461b81fc500ae3c47a09e12b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217757 Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#772552}
-
Wei Li authored
Instead of letting the desk mini view to directly own a preview view, the preview can be owned by the view hierarchy. This also makes the ownership on mini view's children consistent. BUG=1044687 Change-Id: Ibe7392daecd736d02a3d8d0be8c17e332fd46371 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218852 Commit-Queue: Wei Li <weili@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#772551}
-
Koji Ishii authored
This patch defers creating |NGFragmentItem| until |NGFragmentItemsBuilder::AddLine|. This patch also removes |NGLogicalLineItem::fragment_item|. It was needed because |NGInlineLayoutAlgorithm| must create |NGFragmentItem|, but with r771489 <crrev.com/c/2212187>, we can create |NGFragmentItem| even after |NGInlineItemResult| was destroyed. This is to reduce memory copy when changing the Vector of |scoped_refptr<NGFragmentItem>| to the Vector of |NGFragmentItem| (WIP <crrev.com/c/2208806>). Bug: 982194 Change-Id: I41a4e4339d09ef5020bc20abcfd3899ca30792e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216133Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#772550}
-
Scott Violet authored
The controls shouldn't scroll if a11y is enabled. I plan to merge this to 84, so that I'm forking AccessibilityUtil. The plan it to move AccessibilityUtil to ui so that it can be shared. BUG=1085210 TEST=BrowserControlsTest.testAccessibility Change-Id: Icc04354639d3ae1b4f64773752705b37117e9f71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219008 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#772549}
-
zhaoyangli authored
Previously this was only used for iOS 13+ device. This CL changes it for all on device GTests and remove the iOS version check method. This CL only prepares to run these in test runner scripts. Will send follow up CLs on GN configs to make device builders really build and run GTests with xctest. Bug: 1087078, 1001667 Change-Id: I03386ec0caa6f719640cb4d8140cb73ded0ef2c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219108 Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#772548}
-
Nidhi Jaju authored
service worker registration for better estimation of the size of ServiceWorkerRegistrationInfo for an OOM crash investigation. Bug: 848194 Change-Id: I3d5af5405d64ab9629989d6287f474f61ec16436 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217668Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Nidhi Jaju <nidhijaju@google.com> Cr-Commit-Position: refs/heads/master@{#772547}
-
Koji Ishii authored
This patch changes |ComputeAnnotationOverflow| to not to use |fragment_item| to compute the block height of ruby runs. This is needed for crrev.com/c/2216133 to remove |NGLogicalLineItem::fragment_item|. Its replacement should be |inline_item|, but this patch doesn't add it because all ruby runs should have |layout_result| and shouldn't need |inline_item|. Bug: 982194, 1069817 Change-Id: I40a0670121499bd212ca95ba3e2680a9b0f292de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217672Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/47bf5f46..97a2e2dd Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I553631475fcbb840b02f09e9ecabddb6984c4a5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217858Reviewed-by:
-
Asami Doi authored
This CL adds a feature flag for the offline capability check that checks if a website is installable. Browser tests relating to the check are updated to use parameterized tests depending on the feature flag. Bug: 965802 Change-Id: I3678383d62c3fad084d7c7a804755bc97de9b40d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203571 Auto-Submit: Asami Doi <asamidoi@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Asami Doi <asamidoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#772544}
-
Takashi Sakamoto authored
Bug: 1087208 Change-Id: Iadf7f79f37f27133c8fa1089a15c173142341500 Tbr: dbertoni@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217760Reviewed-by:
Takashi Sakamoto <tasak@google.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#772543}
-
Stephan Hartmann authored
Constructing base::flat_set of QuotaClientType with parenthesis constructor is ambiguous in GCC. Use brace-initializer to avoid that problem. Bug: 819294 Change-Id: Id33256a25d2af98d7be6ee570e2535a8b7bdf031 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217554Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#772542}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=kariah@chromium.org Change-Id: I68b71c8bbcdb63a99ae8c2395fc072dc37c284bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219390Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#772541}
-
Stimim Chen authored
Add UMA entries to report the validation result of hardware_verifier. BUG=b:147654337 TEST=None Cq-Depend: chromium:2156385, chromium:2193391, chromium:2156386 Change-Id: I32b9402167c91439a93b414986493ee1e13dea2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156329Reviewed-by:
-
Shakti Sahu authored
This is a reland of bee2010f The original CL had DCHECK which got bypassed in some bots. Removing those DCHECK fixes the test. Original change's description: > Reland "Query Tiles : Integration test" > > This is a reland of d95d2248 > > Original change's description: > > Query Tiles : Integration test > > > > This CL adds end-to-end Integration tests for query tiles. The network > > layer is substituted by a embedded test server that serves a fake > > server response. Added omnibox javatests that use this mechanism to > > test the full flow. > > > > Bug: 1083807 > > Change-Id: Ida65dd9e093ce2311def892158c6bbe4de1fe3c3 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206153 > > Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> > > Reviewed-by: David Trainor <dtrainor@chromium.org> > > Reviewed-by: Shakti Sahu <shaktisahu@chromium.org> > > Reviewed-by: Hesen Zhang <hesen@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#770512} > > Bug: 1083807 > Change-Id: I7f65bfb79006201bdaa545c0aba8dd7cf2b4a243 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210654 > Reviewed-by: Xing Liu <xingliu@chromium.org> > Reviewed-by: David Trainor <dtrainor@chromium.org> > Reviewed-by: Hesen Zhang <hesen@chromium.org> > Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#772139} TBR=dtrainor@chromium.org,xingliu@chromium.org Bug: 1083807 Change-Id: Id25221dccda9d2aba45961859bf39def2d9b3cce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218683 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
-
Yuichiro Hanada authored
The extension api test was removed in crrev.com/c/2198861. Bug: 1083803 Change-Id: Ic60ab57af96367bd4579b6f3b5d9dcdfc24686e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217908 Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Auto-Submit: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#772538}
-
Takashi Sakamoto authored
The test is failing on Win 7 Tests x64 (1) and Win7 Tests (1). Bug: 1087206 Change-Id: I9afbf027adbdbb53ba91bbf7c56b118a8e5f4855 Tbr: dmazzoni@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217520Reviewed-by:
-
Peter Kotwicz authored
This CL fixes NullPointerException in CustomTabNavigationDelegate#shouldDisableExternalIntentRequestsForUrl() BUG=1075543 Change-Id: Ifc6040880535cd3ba58a9495e1805ba00b07447c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2169478 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#772536}
-
David Tseng authored
Currently, ChromeVox only allows live regions on focused web content. within a WebView. Specifically, the hosting views::WebView needs to be focused. This change adds support for live regions to the virtual keyboard, which is hosted within an aura::Window. R=jopalmer@chromium.org AX-Relnotes: n/a Change-Id: Icfef3ee2c356ddf4ee59649b8edcde9b390795b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208821 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#772535}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/369a09ac8618..d3a01e5713dc 2020-05-28 bsheedy@chromium.org [Telemetry] LocalFirstBinaryManager improvements If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1054583 Tbr: rmhasan@google.com Change-Id: I4c0b9b545ae0d4101d05f56e424358bbe85f50df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218658Reviewed-by:
-
Eric Lawrence authored
The origin policy interstitial strings contained minor typos and grammar mistakes. This CL fixes them. Change-Id: I883189b2b32214787e29a13ba3323b15296f0145 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213456Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Commit-Queue: Eric Lawrence [MSFT] <ericlaw@microsoft.com> Cr-Commit-Position: refs/heads/master@{#772533}
-
Jiewei Qian authored
This CL extends the expiry time of the following to the end of 2020. - Webapp.InstallResult.System.Apps.* - Webapp.InstallResult.System.Profiles.* - Webapp.InstallResultExtensionDisabledReason.* - Webapp.InstallResultExtensionError - Webapp.InstallDuration.System Fixed: 1084058,1084059 Change-Id: I3aadbb7f9b3dfa6cdb117e04a9817343959935c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208573 Auto-Submit: Jiewei Qian <qjw@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Jiewei Qian <qjw@chromium.org> Cr-Commit-Position: refs/heads/master@{#772532}
-
Alan Cutter authored
This CL adds a null check for the return value of CreateWebApp(). It's valid for this function to return nullptr in the event of DB corruption so we must check for it. Bug: 1086775 Change-Id: Idd491a136537540f8a65cd466d65772fbdc66300 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217990 Commit-Queue: Alan Cutter <alancutter@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
-
Kazuki Takise authored
HandleBoundsEvents can be called multiple times during a commit process in exo, and we want to save PIP snap fraction once everything gets stable after PIP transition. Note Chrome PIP remembers its position by itself, so it's safe to move the code to exo. BUG=b:156888408 TEST=atest android.server.am.ActivityManagerPinnedStackTests #testEnterPictureInPictureSavePosition Change-Id: I655af04dfc9b4880411b6bb110fbb5781fe28c68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215655Reviewed-by:Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Kazuki Takise <takise@chromium.org> Auto-Submit: Kazuki Takise <takise@chromium.org> Cr-Commit-Position: refs/heads/master@{#772530}
-
