GitLab

Given an image whose shortest dimension is zero,
|GetImageAspectRatioScore| would run into a division by zero, which
leads to undefined behavior.

This CL prevents that by returning early. We return zero because such
an image is not desirable, and should rank lower than images with
non-zero heights and widths.

Change-Id: I80f3b9b3d832d8363994c11bdd073af011b963ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2185835Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Commit-Queue: Chege Gitau <dagitau@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#766475}

It turns out that it's not always true that the new controllee is not
already in the clients map. This CL removes the DCHECK introduced in
https://chromium-review.googlesource.com/c/chromium/src/+/2151246 and
restores the initial behavior. base::InsertOrAssign() is used instead
of the former usage of the square bracket operator so that a default
constructor for ServiceWorkerClientInfo is not needed.

Bug: 1077372
Change-Id: I4ae7270cc8e757cb0b7662d5d41a7ea0ce3d1f4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2176287Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#766474}

Change-Id: Ia7afc484470347d688c53083cb8118581bf7925c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186990Reviewed-by: Stefan Zager <szager@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#766473}

Fills out two request fields we were missing

Bug: 1044139
Change-Id: Ic0ef906d1681bbc426f9d2e9ed6a699f258594aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2169733
Commit-Queue: Dan H <harringtond@chromium.org>
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Reviewed-by: Ian Wells <iwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#766472}

This is because there is no spec text corresponding to this behavior,
and the test is failing on other browsers.

See also: https://github.com/web-platform-tests/wpt/pull/23453/

Change-Id: Ia2d4f0c75c3b295e19f1ffec3e2e0d0fb1882c00
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187174Reviewed-by: vmpstr <vmpstr@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#766471}

Bug: 973801
Change-Id: I61319729a0fd1938264370ee1359dff75cfcc225
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2171969Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Asanka Herath <asanka@chromium.org>
Commit-Queue: Dylan Cutler <dylancutler@google.com>
Cr-Commit-Position: refs/heads/master@{#766470}

Will be more relevant if we use more arsc filters.
Even so, speeds up command on my machine: 10.3s -> 7.7s

Bug: 636448
Change-Id: I9b3db23782282e3e13c613b0b64ff1375fb1422d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186756
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#766469}

Also fix flakiness in unit test by consuming all metrics before test.

Change-Id: Ic5911acc1b26e81dffb5a45a50c6a0ec3a8eed6c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2176288Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: John Wu <jzw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#766468}

StoragePartitionImpl::QuotaManagedDataDeletionHelper receives the set of
storage backends whose storage will be deleted using a
StoragePartitionImpl-specific remove_mask, which is a uint32_t. It is
responsible for converting this to a QuotaManager-specific
quota_client_mask, which is an int.

The conversion is done correctly when calling
QuotaManager::DeleteOriginData(), but is skipped when calling
QuotaManaegr::PerformStorageCleanup().

This CL ensures that the conversion is done consistently when
transitioning into QuotaManager. This problem was discovered while
moving the Quota subsystem to the Storage Service. The problem is fixed
in a small independent CL to take advantage of Canary's ability to catch
unexpected issues.

Bug: 1016065
Change-Id: I165e2033d73b5d3458c50ed5a58117130daf9db0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186178Reviewed-by: Jarryd Goodman <jarrydg@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#766467}

Windows currently has a bug where it does not migrate Ole Automation
Marshaler Interface/Typelib registrations that do not have a Version
field declared. This change therefore adds a Version field to the
registration as expected by the Windows OS Upgrade migration.

Bug: 1078628
Change-Id: I72e265561ac3aaa79077488c110b18c45fb1e9e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186462
Commit-Queue: S. Ganesh <ganesh@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#766466}

Metadata is applied on past samples for the stack sampling profiler
once a long input delay is detected.

As part of an investigation on jank (and more specifically long
input delay)
https://docs.google.com/document/d/1YTpnc7o8XH1KioJpPhWoZvi4Zkpo7cezDrGjQrKZmlQ/edit#heading=h.iohxee36df7p
we're looking into UMA stack sampling profiler data.
Currently, we can only detect jank caused by stalled stacks.
Annotating stack frames with (long) input event will allow us
to analyze "running" jank.

Change-Id: I7914aebf4e14504b400f241d827bda56b6f84db0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2172214Reviewed-by: Mike Wittman <wittman@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#766465}

* Qualify std::make_pair everywhere. This matches standard practice.
* Use standardized names for iterator variables.

Bug: 1016065
Change-Id: Id758ae1ac9e98c479f55fae89e5d12888533c630
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2188051
Commit-Queue: Jarryd Goodman <jarrydg@chromium.org>
Reviewed-by: Jarryd Goodman <jarrydg@chromium.org>
Auto-Submit: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#766464}

FileSystemApiOpenExistingFileWithWriteTest was disabled as flaky
long ago, but it passed on the bots with flying color on 3000
iterations.

Bug: 177163
Change-Id: Icfa48575d2c557afc9d4ce6ec8fb6a402a84ae82
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2173399Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: David Bertoni <dbertoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#766463}

No change to logic, only docs. This updates the commandline docs to
point to Developer UI in more spots and to remove a reference to the log
verbosifier app.

This removes a "new in M84" aside for a Dev UI feature which was
cherry-picked to M83.

This adds documentation for flag persistence and "check for WebView
updates," both of which were added in M84.

Fixed: 1058571
Test: tools/md_browser/md_browser.py
Test: Upload to gerrit > open file > click "gitiles"
Change-Id: Ia796cd84d3556fa15d6b251d18b55cde546d0609
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186750
Commit-Queue: Hazem Ashmawy <hazems@chromium.org>
Auto-Submit: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Hazem Ashmawy <hazems@chromium.org>
Cr-Commit-Position: refs/heads/master@{#766462}

With Scroll Unification, the compositor needs the complete scroll tree.
This patch ensures scroll nodes are created for noncomposited scrollers,
by introducing the concept of a NonCompositedScrollNode, which are the
scroll nodes that do not have an associated composited layer and require
repainting.

NonCompositedScrollNodes are distinguished from regular composited
scroll nodes by their main_thread_scrolling_reason property, which is
set to the corresponding noncomposited scroller's main thread scrolling
reason. The main_thread_scrolling_reason on a NonCompositedScrollNode
will be one of the kNonCompositedReasons[1] which could never happen
before this CL.

Scroll Unification design doc:
https://docs.google.com/document/d/1smLAXs-DSLLmkEt4FIPP7PVglJXOcwRc7A5G0SEwxaY/edit?usp=sharing

[1]
https://cs.chromium.org/chromium/src/cc/input/main_thread_scrolling_reason.h?l=72&rcl=a4c421329c6a8278a940b470c6b42720aa92759f

Bug: 1047178
Change-Id: I2f3c8686e002cf2cd9ca24d533ce25fe3fabfe16
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089973
Commit-Queue: Nick Burris <nburris@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#766461}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/d2e2faf18d06..561b606eae71

git log d2e2faf18d06..561b606eae71 --date=short --first-parent --format='%ad %ae %s'
2020-05-07 shaochuan@google.com cros_mark_android_as_stable: fix Android build link
2020-05-07 cjmcdonald@chromium.org service/packages: uprev_chrome integration tests
2020-05-07 chrome-bot@chromium.org Update config settings by config-updater.
2020-05-07 sque@google.com cros_chrome_sdk uses Goma client in $PATH
2020-05-07 morg@google.com Disable bvt-arc suite for VMRVC PFQ runs
2020-05-07 dburger@chromium.org Remove the config skew unittest.
2020-05-07 manojgupta@google.com config: add external chrome template to amd64-generic-asan
2020-05-06 achuith@chromium.org xbuddy: Minor changes.
2020-05-06 dhaddock@chromium.org auto_updater: Remove perf monitoring from au_e2e.
2020-05-06 henrysun@google.com octopus: add 11297.106.B firmware builder

Created with:
  gclient setdep -r src/third_party/chromite@561b606eae71

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel
Bug: None
Tbr: chrome-os-gardeners@google.com
Change-Id: If6d597d6aab67a71770ee84eb5b17b5d642b4258
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187896Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#766460}

Enable reducing Omnibox Clipboard suggestion age from 1 hour to 10
minutes by default.

This CL is a kind of prerequisite for cr/307908522

Bug: 948235
Change-Id: I15540a847bbe645843024dc3a691673c6372a89a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2181042Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Reviewed-by: Ender <ender@google.com>
Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Gang Wu <gangwu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#766459}

The Speech On-Device API (SODA) will not be available on Windows until
later in the year, so the Live Caption feature will initially launch
using the Cloud Speech-to-Text API. This CL updates the sandbox of the
speech recognition service to use the kUtility sandbox in the event
SODA is not available, as the Cloud Speech-to-Text implementation will
not require the permissions allowed by the kSpeechRecognition sandbox
type.

Bug: 1072846
Change-Id: I7b0ce61850115b476f1f38e81790a0b205ec56c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157997Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Evan Liu <evliu@google.com>
Cr-Commit-Position: refs/heads/master@{#766458}

This CL reorganizes the ozone/wayland input handling and focus
management code so that it becomes less coupled and more centralized
and easy to extend, making it possible some cleanups as well as
preparing to new use cases that will be supported soon, e.g: tab/window
dragging.

To accomplish it, this patch pushes the responsibility of processing
input data from input object wrappers (i.e: WaylandKeyboard,
WaylandPointer, etc) up to WaylandEventSource class, which, from now on,
implements Delegate interfaces (introduced by this change) exposed by
input objects.

Additionally, event polling code has been extracted from
WaylandEventSource into a separate reusable component called
WaylandEventWatcher, so it can benefit other use cases and even
downstream code.

Bug: 1072009
Test: ozone_unittests --ozone-platform=wayland
Change-Id: I02db254d6fcd3d189d8cb2aec8ed535f1b8da8e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164766
Commit-Queue: Nick Yamane <nickdiego@igalia.com>
Reviewed-by: Maksim Sisov <msisov@igalia.com>
Cr-Commit-Position: refs/heads/master@{#766457}

https://skia.googlesource.com/skia.git/+log/d7a27532bc38..edea19858ccc

git log d7a27532bc38..edea19858ccc --date=short --first-parent --format='%ad %ae %s'
2020-05-07 bungeman@google.com Fix loaders for DW variable fonts.
2020-05-07 bsalomon@google.com Add Dawn/Linux/Debug build bot

Created with:
  gclient setdep -r src/third_party/skia@edea19858ccc

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC bsalomon@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: bsalomon@google.com
Change-Id: I01a7d2fa9449ec1ea6fa16f0bd9c2f4576f0a1c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187895Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#766456}

Prior to this top/bottom views were parented to ContentView. ContentView
uses an accessibility implementation that doesn't work with views, meaning
any views added to ContentView are not accessible.

BUG=1075585
TEST=none

Change-Id: I010f72bc1f26cca8b88159609f1b17b275af0775
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186734Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#766455}

Somehow I missed this and added extra brackets. This fixes the syntax issue.

Change-Id: I364267b21fa01168cbeb0f63d4270a4b97794d0c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187173Reviewed-by: Stephen Nusko <nuskos@chromium.org>
Reviewed-by: Mikhail Khokhlov <khokhlov@google.com>
Commit-Queue: Stephen Nusko <nuskos@chromium.org>
Auto-Submit: Stephen Nusko <nuskos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#766454}

This drops the shell_$PLATFORM files, and introduces a singleton
ShellPlatformDelegate, owned by the ShellBrowserMainParts, which
provides platform-specific code. Shell calls out to this delegate
instead of providing platform-specific implementations itself.

Why are we doing this?

1) While working on https://chromium-review.googlesource.com/c/chromium/src/+/2180920
   I discovered that Mac is lying about the window screen rect in the
   renderer but actually never hears about about the window screen
   rect in RenderWidgetHost{View} in the browser, leaving it at 0x0. It
   does not hear about this in web tests headless mode because the
   view is detached from any platform window.
2) In order to make that CL in 1) work, we need to inform the
   RenderWidgetHostViewMac (or RenderWidgetHostImpl) directly about
   the window screen rect. Adding content public APIs to do this would
   not be ideal.
3) Since we don't want to add public APIs, we need code in
   Shell::SizeTo() for mac that informs the RenderWidgetHostViewMac
   but this code also needs to be in a web_test/ directory in order
   to access //content/browser and see the RenderWidgetHostViewMac
   type.
4) We could have Shell call out to web_test/ code directly when
   running in web test mode. However that would prevent us from our
   future goals of making content_shell not a test-only target, and
   not depending on web_test/ code from Shell.

Thus, we introduce the ShellPlatformDelegate which we will be able
to subclass in web_test/ in order to do the inform of the
RenderWidgetHostViewMac of the window screen rect when the Shell
is resized.

R=avi@chromium.org

Bug: 866140, 1069111
Change-Id: I09e566106caa11107c638d22a6a8427523630f20
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2185445Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#766453}

Previously we were saving a boolean value to the shared profile, so any
user who checked would read true.  The new implementation stores the
user_hash instead.  Also updated the unit tests to catch this situation.

Bug: 966270
Change-Id: If4d2601894ece4eff4180b83979097fb1d47eb05
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151701
Commit-Queue: Jon Mann <jonmann@chromium.org>
Reviewed-by: James Vecore <vecore@google.com>
Reviewed-by: Azeem Arshad <azeemarshad@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#766452}

Adds tests for scaling non-shared app list configs (which happens
when screen does not have enough space to display the apps grid).
Previously, this was tested for shared config only, but with the ability
to disable ScalableAppList feature, shared config is not used for apps
grid layout (the shared app list config type will be removed separately).

BUG=1077774

Change-Id: Iaebdf97d9090bf882fc1798e55f1c258222e7fd9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2183510
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#766451}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/ed8b50dd..a3433d82

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Id64696bf8a7ed0fabf66f6968ec0e6940c6df4f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187012Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#766450}

https://webrtc.googlesource.com/src.git/+log/b63331bb8f7f..3b6afeeed0a9

git log b63331bb8f7f..3b6afeeed0a9 --date=short --first-parent --format='%ad %ae %s'
2020-05-07 eshr@google.com Add comparison methods for VideoSourceRestrictions
2020-05-07 eshr@google.com [Adaptation] Adapt up requires previous underuse
2020-05-07 saza@webrtc.org Remove audio playout generator from APM API

Created with:
  gclient setdep -r src/third_party/webrtc@3b6afeeed0a9

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: I4d3cc2ee0bab8c34b29036dc839d7075f31dbc1d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187897Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#766449}

In order to generate internal testing JSON files, the configuration
files must be read from src-internal rather than src or all of the
builders will be flagged as unknown.

Bug: 1078933
Change-Id: Ic659675778256c7fb2e2df5409dbc35e72ff3b46
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186451
Commit-Queue: Garrett Beaty <gbeaty@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#766448}

This CL dedupes the //chrome and //weblayer implementations of
getSpecializedHandlersWithFilter() into a static function in
ExternalNavigationHandler.java. There is a slight difference between
the two impls: //chrome's does not consider the InstantApp launcher as
a specialized handler because it handles launching of Instant Apps
internally. WebLayer, however, does not handle launching of Instant Apps
itself and instead lets the system do so as appropriate. We handle this
by adding a parameter to the new //components-level version of the
function.

We also move the tests of this function to
ExternalNavigationHandlerTest.java, including testing the behavior in
response to the value of this new parameter.

A followup CL will dedupe and eliminate the ExternalNavigationDelegate
methods that can be implemented within ExternalNavigationHandler
following this change.

Bug: 1071390
Change-Id: I701c4aa8c46260de3357b3d52e536a237d8c7b60
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2184277Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#766447}

Removing build version checks that are no longer necessary.

Bug: 923477
Change-Id: Iea82d7868f1bfe7ab7094e7a7347a30ccf4949e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186124
Commit-Queue: Theresa  <twellington@chromium.org>
Auto-Submit: Natalie Chouinard <chouinard@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#766446}

This test has been failing consistently on MacOS builders, so disabling
as sheriff.

Bug: 1067492
Change-Id: I4db3ae403897b39a96a76b52aefa3b5a7d14fc53
TBR: sadrul@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187202Reviewed-by: Ian Clelland <iclelland@chromium.org>
Commit-Queue: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#766445}

The virtual authenticator issues self signed certificates for
attestation. Fix the valid from and expiry dates so they're valid for
about 20 years.

This also makes some attestation object functions be const so we can
call them from const references.

Fixed: 1077081
Change-Id: I75dbd4042eef4d2e120fa22a8b912906e14f6f82
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2183114
Commit-Queue: Nina Satragno <nsatragno@chromium.org>
Auto-Submit: Nina Satragno <nsatragno@chromium.org>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Cr-Commit-Position: refs/heads/master@{#766444}

There's some debate around where the text fragment feature detection API
should be (see bug 1057795 for details), and we're considering moving it
off of Location. This patch adds a use counter to the
location.fragmentDirective getter to confirm suspected low usage.

Bug: 1057795

Change-Id: I179e3b2355296ba3cc1ef0ec9fa6ad04375c0a33
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2176326
Commit-Queue: Nick Burris <nburris@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#766443}

Bug: 1049200
Change-Id: I0c133925b1ce5ca0fb735ad4572036dd2dcdc50e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187576Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#766442}

While debugging tablet mode issues, I find myself constantly
having to look up the values of LidState and TabletMode.

This CL adds two overloads to stringify those values to
human-readable strings to be added in the logs.

BUG=1070154

Change-Id: I83d91053819848651ddf2e7db0678dd10ac1ac40
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186752Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#766441}

Implement CPE quick type bar entry points:
-provideCredentialWithoutUserInteractionForIdentity:
-prepareInterfaceToProvideCredentialForIdentity:

Bug: 1077747
Change-Id: I84f7f67c2aaf1e2bae442b35d7db032d2ad65205
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187712
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#766440}

This used to post-process the output of wptrunner to support things like
flakes, but we now support that in WPTMetadataBuilder instead.

Change-Id: I967aff8ae3babbb620478cd32f486c5ac760c70f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187193
Commit-Queue: Robert Ma <robertma@chromium.org>
Auto-Submit: Luke Z <lpz@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#766439}

This fixes a broken DCHECK caused by storing a string which is not
UTF8 encoded in a base::Value.

Bug: 966270
Change-Id: I6e2084ffebe3bb8cefa1bd48f0f39e435c3442e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186747Reviewed-by: James Vecore <vecore@google.com>
Commit-Queue: Jon Mann <jonmann@chromium.org>
Cr-Commit-Position: refs/heads/master@{#766438}

Rather than hard-coding the set of supported languages for image
descriptions, fetch the list of supported languages from the server,
so that image descriptions can be requested in the most appropriate
language for each user.

Get Image Descriptions from Google feature dynamically.

Bug: 1070505
Tbr: nicolaso@chromium.org
Change-Id: Ia23b1b93b2c8744a3f9dd965c3bdc92ecfe2060f
Relnotes: Updates the set of languages supported by the
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2173540Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Andrew Moylan <amoylan@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#766437}

Change-Id: I2d02d67b20e1b32693dbae64d8223a0154e36a80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187207Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Commit-Queue: Mustaq Ahmed <mustaq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#766436}