GitLab

https://pdfium.googlesource.com/pdfium.git/+log/28b44b03c133..cbdf926884c4

$ git log 28b44b03c..cbdf92688 --date=short --no-merges --format='%ad %ae %s'
2017-05-03 tsepez Move O_BINARY and O_LARGEFILE defintions
2017-05-03 tsepez Remove FXSYS_wfopen(), it is totally unused.

Created with:
  roll-dep src/third_party/pdfium


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: I5bf662c7a67f9a67e36237024cc53a1274f1155e
Reviewed-on: https://chromium-review.googlesource.com/495432
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#469334}

https://drive.google.com/open?id=0ByXziH_JVCGJXzVLNmx6cTVtczA
https://drive.google.com/open?id=0ByXziH_JVCGJQ3BKS2JpOXA5a1k

BUG=661794

Review-Url: https://codereview.chromium.org/2844253003
Cr-Commit-Position: refs/heads/master@{#469333}

BUG=none

Review-Url: https://codereview.chromium.org/2860753004
Cr-Commit-Position: refs/heads/master@{#469332}

This also modifies the ownership of the subresource filter client, which now must
outlive the throttle manager / driver factory.

BUG=717590

Review-Url: https://codereview.chromium.org/2850373002
Cr-Commit-Position: refs/heads/master@{#469331}

Add a minimum test that only enables the login screen apps functionality
via the command line flag. The purpose of this test is to investigate
whether just specifying this command line flag may lead to tests being
timed out. The plan is to remove this test once this investigation
finishes, in favor of more complete end-to-end tests.

BUG=626343

Review-Url: https://codereview.chromium.org/2861723002
Cr-Commit-Position: refs/heads/master@{#469330}

This removes the overhead of emitting trace events from run time
measurement.
On tests like Layout/character_fallback_aat.html, this reduces the
test's duration 3x (0.015ms --> 0.005ms)

BUG=716394, 701059
TBR=wangxianzhu@chromium.org

Review-Url: https://codereview.chromium.org/2857403002
Cr-Commit-Position: refs/heads/master@{#469329}

BUG=718242

Review-Url: https://codereview.chromium.org/2858043005
Cr-Commit-Position: refs/heads/master@{#469328}

Previously, percent-height svg elements in a pure-svg doc would get
their size based on the LayoutView's logical height from the previous
layout pass.  In practice, this didn't show up much because FrameView
always does at least one extra initial layout pass to add and then
subtract scrollbars.  The extra layout pass would cause the percent
height descendants to get the right size.

Setting overlay scrollbars on the FrameView eliminates the extra
layout passes and allows the bug to manifest.

Review-Url: https://codereview.chromium.org/2835153002
Cr-Commit-Position: refs/heads/master@{#469327}

Network traffic annotation is added to network request of .
headless/public/util/http_url_fetcher.cc
headless/public/util/generic_url_request_job_test.cc

BUG=656607

Review-Url: https://codereview.chromium.org/2857623002
Cr-Commit-Position: refs/heads/master@{#469326}

ANGLE now exposes this extension to indicate that floating point textures
are renderable so it is the preferred way to determine if these extensions
should be exposed.

BUG=angleproject:1958
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2795123003
Cr-Commit-Position: refs/heads/master@{#469325}

Revert of Landing Recent QUIC changes until Sat Apr 29 00:22:04 2017 +0000 (patchset #1 id:1 of https://codereview.chromium.org/2862563003/ )

Reason for revert:
Caused net_unittests to consistently time out on https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29 because of a large number of QUIC tests crashing.

Original issue's description:
> Landing Recent QUIC changes until Sat Apr 29 00:22:04 2017 +0000
>
> There are no flags to be updated
>
> deprecate FLAGS_quic_reloadable_flag_quic_bbr_keep_sending_at_recent_rate in disabled state.
>
> It achieved results that were in general comparable to "measuring
> aggregation" approach, but it had worse rtx rate, and worse QoE, and did
> not actually seem to be better in other regards.
>
> Merge internal change: 154601526
>
> https://codereview.chromium.org/2859913003/
>
> fix packet conservation to remove packets from recovery window when they are lost.  Protected by FLAGS_quic_reloadable_flag_quic_bbr_fix_conservation2.
>
> This causes a dramatic reduction in losses compared to the previous patch.
>
> The transfer time is approximately the same.
>
> Merge internal change: 154590929
>
> https://codereview.chromium.org/2857243002/
>
> Fix typo in comments.
>
> Merge internal change: 154539040
>
> https://codereview.chromium.org/2854823004/
>
> QUIC - refactor stream creation. Guarded by --quic_reloadable_flag_quic_refactor_stream_creation.
>
> This CL is in preparation for HTTP stream pairs changes.  A prototype
> of the entire HTTP stream pairs work is in progress.  This CL is one
> subset of that (2nd in the series).
>
> [ HTTP stream pairs builds upon this, by having new QuicSpdySession
> overrides that implicitly create headers streams, and abstracting
> stream accounting as needed. ]
>
> Add a new factory like method QuicSession::CreateStream(), that
> unconditionally creates a new stream.  It's virtual so subclasses of
> QuicSession can create streams that are appropriately specialized from
> QuicStream.  There are new versions of Create*DynamicStream() called
> MaybeCreate*DynamicStream(), and ShouldCreate*DynamicStream() called
> ShouldCreate*DynamicStream2().
>
> Separating this out means that fewer overrides of Create*DynamicStream()
> and ShouldCreate*DynamicStream() will necessary, because many of those
> were actually only needed to specialize the steam types.  Those will go
> away when FLAGS_quic_reloadable_flag_quic_refactor_stream_creation is
> deprecated.
>
> Merge internal changes: 154351257, 154373998.
>
> https://codereview.chromium.org/2861673004/
>
> QUIC - stream id refactor for tests.
>
> // AKA - http stream pairs bikeshed #1.
>
> This CL is in preparation for HTTP stream pairs changes.  A prototype
> of the entire HTTP stream pairs work is in progress.  This CL is one
> subset of that.
>
> Rework QUIC tests so that they do not hard code the assumption that
> all headers are on stream 3.  Also, prepare to calculate stream ids
> according to whether stream pairs are enabled, i.e. whether they
> increment by 2 or 4.
>
> Merge internal change: 150949425
>
> https://codereview.chromium.org/2854833005/
>
>
> R=rch@chromium.org
> BUG=
>
> Review-Url: https://codereview.chromium.org/2862563003
> Cr-Commit-Position: refs/heads/master@{#469218}
> Committed: https://chromium.googlesource.com/chromium/src/+/d60018e0b72b5708797cebe57780ad559877164f

TBR=rch@chromium.org,ckrasic@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review-Url: https://codereview.chromium.org/2856243003
Cr-Commit-Position: refs/heads/master@{#469324}

https://skia.googlesource.com/skia.git/+log/64dbb89efc9d..b59a9da7eba4

$ git log 64dbb89ef..b59a9da7e --date=short --no-merges --format='%ad %ae %s'
2017-05-04 msarett Revert "Add SkImage::makeColorSpace() with correct transfer fn behavior"

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=scroggo@chromium.org

Change-Id: Iabccfd6819f93e0002473c67ae54d80122db3941
Reviewed-on: https://chromium-review.googlesource.com/495410Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#469323}

Flaky on Windows because file handles may be open during shutdown (which
causes TestingProfile to crash on shutdown).

BUG=717648

Review-Url: https://codereview.chromium.org/2860463003
Cr-Commit-Position: refs/heads/master@{#469322}

This Cl switches chrome/browser/resources/pdf OWNERS to list myself and
remove raymes@.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2857163002
Cr-Commit-Position: refs/heads/master@{#469321}

Network traffic annotation is added to network request of:
chrome/browser/safe_browsing/incident_reporting/incident_report_uploader_impl.cc

BUG=656607

Review-Url: https://codereview.chromium.org/2793193003
Cr-Commit-Position: refs/heads/master@{#469320}

we can avoid having to do expensive crc32_combine computation on
the I/O thread, and can also immediately verify the checksum
on the final block, improving read locality (and avoiding a
bit of thread ping-pong)

Using the very-synthetic benchmark from
https://codereview.chromium.org/2838403003/
on a Mac with SSD, I got -18% mean cold read time change,
-26% warm read time change.

Speadsheet:
https://docs.google.com/a/google.com/spreadsheets/d/1ri_AF3va-yZWIfo66-ZrQHiDpjOcziRdXoprzlqPeVU/edit?usp=sharing

I was unable to produce meaningful numbers on Windows, however.

BUG=

Review-Url: https://codereview.chromium.org/2821923002
Cr-Commit-Position: refs/heads/master@{#469319}

TBR=dpranke@chromium.org,mcgreevy@chromium.org
BUG=718379,717347
NOTRY=true

Review-Url: https://codereview.chromium.org/2857343003
Cr-Commit-Position: refs/heads/master@{#469318}

BUG=631966

Review-Url: https://codereview.chromium.org/2856893004
Cr-Commit-Position: refs/heads/master@{#469317}

By default use_ozone=false if target_os="chromeos". This causes
use_11=true and the X11 Chrome OS configuration to get built. Make
trybots that have implicit GN arg use_ozone=false specify it explicitly.

This will allow the default value for use_ozone to get changed without
changing the current trybot configurations.

BUG=671355

Review-Url: https://codereview.chromium.org/2854923002
Cr-Commit-Position: refs/heads/master@{#469316}

The tests in question need to be rebaselined after V8 has been rolled
with the new asm.js validator enabled. This feature is not yet enabled.

R=machenbach@chromium.org
BUG=chromium:718394
NOTRY=true

Review-Url: https://codereview.chromium.org/2860073002
Cr-Commit-Position: refs/heads/master@{#469315}

ImageSet context resources, namely <picture> and srcset based images,
are blockable mixed-content, yet we were sending out such requests, even
if not displaying them, due to the preloadScanner ignoring the difference
between them and `<img src>` based images

This CL fixes that, by blocking such images.

BUG=713440

Review-Url: https://codereview.chromium.org/2855163002
Cr-Commit-Position: refs/heads/master@{#469314}

With ARC, the order in which -dealloc is invoker is sometimes changed.
This means that some of CRWWebController delegates may end up calling
methods of CRWWebController between call to -close and -dealloc (until
the autorelease pool is cleared).

Since WebStateImpl calls CRWWebController -close just before releasing
its reference, and CRWWebController becomes unusable once -close has
been called (as -navigationManagerImpl will return nullptr), this does
not introduce an API change of CRWWebController while ensuring that
the delegate registration happens as part of WebStateImpl destruction.

Fixes the crash that caused the revert of http://crrev.com/2846233002/
with the following callstack (truncated):

  0   org.chromium.gtest.generic-unit-test  0x000000010169d83a -[CRWWebController setNavigationItemTitle:] + 266
  1   org.chromium.gtest.generic-unit-test  0x000000010169b2df -[CRWWebController nativeContent:titleDidChange:] + 47
  2   org.chromium.gtest.generic-unit-test  0x0000000101e545c3 -[StaticHtmlViewController observeValueForKeyPath:ofObject:change:context:] + 515
  3   com.apple.Foundation            0x000000010e3ee70c NSKeyValueNotifyObserver + 351
  4   com.apple.Foundation            0x000000010e3edfa7 NSKeyValueDidChange + 495
  5   com.apple.Foundation            0x000000010e3be00e -[NSObject(NSKeyValueObserverNotification) didChangeValueForKey:] + 118
  6   com.apple.WebKit                0x000000010fcb356a WebKit::PageLoadState::commitChanges() + 1538
  ...

BUG=None

Review-Url: https://codereview.chromium.org/2854943003
Cr-Commit-Position: refs/heads/master@{#469313}

Instead of //headless/public/domains, headers under
//headless/public/devtools should now be used.

BUG=718242

Review-Url: https://codereview.chromium.org/2854823006
Cr-Commit-Position: refs/heads/master@{#469312}

Sanitizer stacks are supposed to be run through
tools/valgrind/asan/asan_symbolize.py anyhow, which calls llvm-symbolizer.
llvm-symbolizer can do a better job at symbolizing than google::Symbolize
if google::Symbolize doesn't throw away the data llvm-symbolizer needs.

Stack before (both with and without filtering through asan_symbolize):

BrowserTestBase received signal: Segmentation fault. Backtrace:
#0 0x0000007ea911 __interceptor_backtrace
#1 0x0000082e2afc base::debug::StackTrace::StackTrace()
#2 0x00000979d5ce content::(anonymous namespace)::DumpStackTraceSignalHandler()
#3 0x7f04d9814cb0 <unknown>
#4 0x00000fbd5624 BrowserActionsContainer::Layout()
#5 0x00000fbd3c3e BrowserActionsContainer::Redraw()
#6 0x00000f91d38e ToolbarActionsBar::UndoPopOut()

Stack after, not filtered through asan_symbolize:

BrowserTestBase received signal: Segmentation fault. Backtrace:
#0 0x0000007ea911 (/usr/local/google/home/thakis/src/chrome/src/out/asan/browser_tests+0x7ea910)
#1 0x0000082e2afc (/usr/local/google/home/thakis/src/chrome/src/out/asan/browser_tests+0x82e2afb)
#2 0x00000979d5ce (/usr/local/google/home/thakis/src/chrome/src/out/asan/browser_tests+0x979d5cd)
#3 0x7fbcf8399cb0 (/lib/x86_64-linux-gnu/libc-2.19.so+0x36caf)
#4 0x00000fbc96b4 (/usr/local/google/home/thakis/src/chrome/src/out/asan/browser_tests+0xfbc96b3)
#5 0x00000fbc7cce (/usr/local/google/home/thakis/src/chrome/src/out/asan/browser_tests+0xfbc7ccd)
#6 0x00000f91141e (/usr/local/google/home/thakis/src/chrome/src/out/asan/browser_tests+0xf91141d)

Stack after, filtered through asan_symbolize:

BrowserTestBase received signal: Segmentation fault. Backtrace:
    #0 0x0000007ea911 in __interceptor_backtrace ??:0:0
    #1 0x0000082e2afc in base::debug::StackTrace::StackTrace(unsigned long) /usr/local/google/home/thakis/src/chrome/src/out/asan/../../base/debug/stack_trace_posix.cc:745:41
    #2 0x00000979d5ce in content::(anonymous namespace)::DumpStackTraceSignalHandler(int) /usr/local/google/home/thakis/src/chrome/src/out/asan/../../content/public/test/browser_test_base.cc:80:5
    #3 0x7fda947f5cb0 in killpg ??:?
    #4 0x7fda947f5cb0 in ?? ??:0
    #5 0x00000fbc96b4 in BrowserActionsContainer::Layout() /usr/local/google/home/thakis/src/chrome/src/out/asan/../../chrome/browser/ui/views/toolbar/browser_actions_container.cc:364:13
    #6 0x00000fbc7cce in BrowserActionsContainer::Redraw(bool) /usr/local/google/home/thakis/src/chrome/src/out/asan/../../chrome/browser/ui/views/toolbar/browser_actions_container.cc:214:3
    #7 0x00000f91141e in ToolbarActionsBar::UndoPopOut() /usr/local/google/home/thakis/src/chrome/src/out/asan/../../chrome/browser/ui/toolbar/toolbar_actions_bar.cc:534:16

BUG=none

Review-Url: https://codereview.chromium.org/2857643002
Cr-Commit-Position: refs/heads/master@{#469311}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/ff8039d7..342edbef

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2858183003
Cr-Commit-Position: refs/heads/master@{#469310}

While matching rules for elements, we mark elements as affected-by-* for
user action pseudo classes like hover. It means that when the element is
later hovered, we need to recalculate style to apply hover styles to
that element.

In general, we currently don't support pseudo classes after pseudo
elements, but for scrollbar pseudo elements we do:

  ::-webkit-scrollbar:hover {}

However, we do not want such rules to mark the element as affected-by-
hover. The hover style on scrollbar parts get their hover style updated
when hovered regardless of any flags, and making scrollbar pseudo
element rules affect hover updates on the actual elements causes
unnecessary style recalcs.

BUG=716006

Review-Url: https://codereview.chromium.org/2850743003
Cr-Commit-Position: refs/heads/master@{#469309}

The outcome is: if device authorization for a renderer is taking too long
it will be interupted. Page load will continue normally, some of the audio
playback on it may not work.

BUG=647498

Review-Url: https://codereview.chromium.org/2862823002
Cr-Commit-Position: refs/heads/master@{#469308}

Swarming has only a single Win10-10240 bot but about 30-40 Win10-10586
bots.

TBR=dpranke@chromium.org,mcgreevy@chromium.org
BUG=718379,717347
NOTRY=true

Review-Url: https://codereview.chromium.org/2857213004
Cr-Commit-Position: refs/heads/master@{#469307}

BUG=709042

Review-Url: https://codereview.chromium.org/2854143002
Cr-Commit-Position: refs/heads/master@{#469306}

Extracts a SuggestionsEventReporter out of SnippetsBridge, that is
responsible for recording backend metrics and sending events used by
the fetch scheduler.

BUG=710268

Review-Url: https://codereview.chromium.org/2844033002
Cr-Commit-Position: refs/heads/master@{#469305}

A test suite that depends on a test suite base that provides a
base::test::ScopedTaskEnvironment may need browser threads. Currently,
the test suite cannot use content::TestBrowserThreadBundle to get
these browser threads because base::test::ScopedTaskEnvironment and
content::TestBrowserThreadBundle both set the main MessageLoop and
the TaskScheduler. With this CL, content::TestBrowserThreadBundle
doesn't set the main MessageLoop and the TaskScheduler if they
already exist.

E.g.
Test suite: ToolbarActionViewUnitTest
            Needs BrowserThreads
Base test suite: views::ViewsTestBase
                 Provides a ScopedTaskEnvironment

BUG=

Review-Url: https://codereview.chromium.org/2860533002
Cr-Commit-Position: refs/heads/master@{#469304}

Parse Server-Timing response headers and make the metric name(s), value(s), and
description(s) available as PerformanceServerTiming entries on the global
performance timeline and to PerformanceObservers. This feature is behind the
"ServerTiming" experimental-features flag.

To test, turn the flag on
(chrome://flags/#enable-experimental-web-platform-features) and explore to
https://server-timing.now.sh/. Execute `performance.getEntriesByType('server')`
in DevTools to inspect the 4 entries for the base page, as per the response
header:
server-timing:db=100; "Database metric", api=200; "HTTP/API metric", cache=300; "cache metric", total=0.000297322; "Total Response Time"

To inspect the 4 entries for the favicon.ico, you will need to set up a
PerformanceObserver (I use TamperMonkey to inject a content script) like this:
new PerformanceObserver(function(list, observer) {
  console.info(list.getEntries())
  observer.disconnect()
}).observe({entryTypes: ['server']})

Spec: https://w3c.github.io/server-timing/
Intent to implement:
https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/y3qwr490Fc4/boGoo41-BwAJ

BUG=702760

Review-Url: https://codereview.chromium.org/2839683003
Cr-Commit-Position: refs/heads/master@{#469303}

A speculative change that might help mitigate problems with
WTF::Deque::expandCapacity which sometimes takes over a second
due to heavy load on PartitionAlloc.

I'm hoping in normal operation the default_tq doesn't get more
than a handful of tasks (a quick trace of handouts on a high end
pc suggests the queue depth is <= 3) which would let us avoid
dynamic allocations entirely.

BUG=710245

Review-Url: https://codereview.chromium.org/2860813004
Cr-Commit-Position: refs/heads/master@{#469302}

In this CL, support is added to all unit tests targets and the Showcase
Earl Grey tests.

BUG=676034
R=sdefresne@chromium.org,marq@chromium.org,lindsayw@chromium.org

Review-Url: https://codereview.chromium.org/2789433004
Cr-Commit-Position: refs/heads/master@{#469301}

The origin whitelist may well be empty, so check that first
before taking on the stringification of the security origin.

R=
BUG=

Review-Url: https://codereview.chromium.org/2855133005
Cr-Commit-Position: refs/heads/master@{#469300}

BUG=none

Review-Url: https://codereview.chromium.org/2854973005
Cr-Commit-Position: refs/heads/master@{#469299}

This makes the UI consistent with the settings UI.

Screenshots:
before: http://imgur.com/cze5exI
after: http://imgur.com/1Z43yGW

BUG=602666

Review-Url: https://codereview.chromium.org/2855183002
Cr-Commit-Position: refs/heads/master@{#469298}

 * Adding perl (needed for CGI scripts).
 * cygwin (possibly needed?)

BUG=717347
TBR=mcgreevy@chromium.org,dpranke@chromium.org

Review-Url: https://codereview.chromium.org/2856283003
Cr-Commit-Position: refs/heads/master@{#469297}

BUG=160920
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2860653003
Cr-Commit-Position: refs/heads/master@{#469296}

All calls to LayoutText::AbsoluteQuadsForRange don't use use_selection_height,
so use_selection_height is removed from LayoutText::AbsoluteQuadsForRange and
its callee functions.

BUG=691198

Review-Url: https://codereview.chromium.org/2853343003
Cr-Commit-Position: refs/heads/master@{#469295}