- 29 Sep, 2017 40 commits
-
-
Xianzhu Wang authored
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I95a121d90642a3abbe51407ba14a90313f90322f Reviewed-on: https://chromium-review.googlesource.com/691214Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#505407}
-
Iulia Harasim authored
This CL splits the xml file used to implement the promo view in 2 different files: one contains the header of the promo (the image and the dismiss button) and the other contains the description and the signin buttons. This change is necessary in order to provide custom paddings and margins for the header of the promo. Bug: 737743 Change-Id: I76532407444ca62d808dddbd874642fb1aa788e5 Reviewed-on: https://chromium-review.googlesource.com/691659Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Iulia Harasim <iuliah@google.com> Cr-Commit-Position: refs/heads/master@{#505406}
-
Andrew Grieve authored
Sometimes useful to have the unstripped library. E.g. when attempt to disassemble. Change-Id: Id06beb836525810f3508eed265c6018b06a18a5e Reviewed-on: https://chromium-review.googlesource.com/692815Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#505405}
-
Kyle Horimoto authored
Previously, it was possible specify an ARGB value via the PATH_COLOR_ARGB command, which takes an alpha as well as RGB properties as parameters. However, there was no command to specify a change in opacity without also specifying the color to use. This presented a problem for system notification. When displayed on a notification, these icons are drawn in blue or red, depending on the warning level of the notification, and when displayed in the black bar at the bottom of the UI, they are drawn in white. Thus, for notification icons which need to be displayed in a single color with different opacities, a new command was needed. This CL introduces the PATH_COLOR_ALPHA command, which takes a single parameter expressing the opacity of the path. It will be used immediately in a follow-up CL: https://chromium-review.googlesource.com/c/chromium/src/+/685304 Bug: 759257, 672263 Change-Id: I00a5dbb28a06de41239cda2fe1c608754f190bf6 Reviewed-on: https://chromium-review.googlesource.com/690706Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#505404}
-
chrome://flagsPhilippe Hamel authored
Bug: 646711 Change-Id: I82c20d2db71c9cec7363c395af4f348be3b6a6de Reviewed-on: https://chromium-review.googlesource.com/688220 Commit-Queue: Philippe Hamel <hamelphi@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#505403}
-
Mike Wasserman authored
Make the menu item handle click events on its icon view. (support clicking on a radio/check icon in a menu item) Bug: 768449 Test: See bug. Change-Id: I1da3ce9baad36b1e35278e3a7c466e96c4e00876 Reviewed-on: https://chromium-review.googlesource.com/691175Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#505402}
-
Vladislav Kaznacheev authored
Although metalayer selection is constructed from stylus input points, it can sometimes cross the screen bounds. For example, when a horizontal stroke is recognized, its bounding rectangle is inflated to guarantee minimal height and generally be closer to the visual image of the stroke. This patch introduces necessary clipping to make sure that clients do not have to do that. Bug: b:67021526 Test: ash_unittests HighlighterControllerTest.SelectionInsideScreen Change-Id: I09d67c8b9f1176ea083a40f581b8a46536152296 Reviewed-on: https://chromium-review.googlesource.com/691278 Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#505401}
-
Andrew Grieve authored
Without our new(ish) scheme of bytecode-rewriting asserts, the system property isn't used. NOTRY=true # Doesn't affect bots Change-Id: Ie0f9f2e9bb8674bba52380fc7983a13f54ae65f9 Reviewed-on: https://chromium-review.googlesource.com/692816Reviewed-by:
-
Lukasz Anforowicz authored
WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=ekaramad@chromium.org Bug: 666525 Change-Id: I8c9c9436301eabd31b5bfe1054956c63d5457dfc Reviewed-on: https://chromium-review.googlesource.com/689107Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#505399}
-
Devlin Cronin authored
Remove the std::unique_ptr<> members from ExternalInstallInfoFile and ExternalInstallInfoUpdateUrl. These were used to hold the version and url members, but each of these will never be null and are cheaply copyable (or, in the case of GURL, movable), so have no reason to be pointers. Bug: 770007 Change-Id: I4b9c3ef8c9888a2d460ab082a9fa3339423a5ee6 Reviewed-on: https://chromium-review.googlesource.com/691045 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#505398}
-
mark a. foltz authored
This reverts commit 6a8d2a72. Reason for revert: Bug 769979 Original change's description: > [Desktop Capture] Enable system audio capture without screen capture. > > This addresses a long standing issue where users are unable to cast system > audio to audio-only Cast devices by adding support for system audio capture > without screen capture. > > Bug: 662499 > Change-Id: I0c612861e36644298f161de47810c6d37ffbf501 > Reviewed-on: https://chromium-review.googlesource.com/656597 > Commit-Queue: mark a. foltz <mfoltz@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Cr-Commit-Position: refs/heads/master@{#503491} TBR=mfoltz@chromium.org,jam@chromium.org,sergeyu@chromium.org,guidou@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 662499 Change-Id: I0fa48ea0647a7c8d7186805aa097e20c505d1ba9 Reviewed-on: https://chromium-review.googlesource.com/691279 Commit-Queue: mark a. foltz <mfoltz@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#505397}
-
Lei Zhang authored
Also group various enable_foo and use_bar blocks alphabetically at the end, after the is_quxos and use_bazui sections. Also remove all -= operator usage and use += in the right sections instead. Add a few new sections so certain files no longer need to be included twice/thrice in separate places. Change-Id: I2f62dcd98ab09d824080c750b3c98d2f457881b9 Reviewed-on: https://chromium-review.googlesource.com/689454 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#505396}
-
Mihai Sardarescu authored
StartupTabProvider may be called when Chrome starts in an incognito profile, which leads to a crash at start-up. This CL addresses this and adds a unit test to make sure it does not regress in the future. Bug: 769241 Change-Id: Idea489bc05e31d7ac693cb935b1481979099bd09 Reviewed-on: https://chromium-review.googlesource.com/689535Reviewed-by:
-
Sami Kyostila authored
BUG=769809 Change-Id: Ie4f3f0a26c911948b7b8cda1fbe8e8fde2e3d8b0 Reviewed-on: https://chromium-review.googlesource.com/692774Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#505394}
-
Robert Flack authored
BUG=755307 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I494ab70535eb14de98f1eb78d6e74aebef565e52 Reviewed-on: https://chromium-review.googlesource.com/690857 Commit-Queue: Robert Flack <flackr@chromium.org> Reviewed-by:
-
Eugene Girard authored
Bug: 760012 Change-Id: I41397192fd7fc5ea585b4a4a11310fdef7b68fdc Reviewed-on: https://chromium-review.googlesource.com/690749 Commit-Queue: Eugene Girard <girard@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#505392}
-
Dmytro Golovchenko authored
Script is failing on goobuntu-trusty_desktop-stable-amd64 due to packages conflict: The following packages have unmet dependencies: libdconf-dev : Conflicts: libdconf-dev:i386 but 0.20.0-1 is to be installed libdconf-dev:i386 : Depends: libglib2.0-dev:i386 (>= 2.25.7) but it is not going to be installed Recommends: libdconf-doc:i386 but it is not installable Conflicts: libdconf-dev but 0.20.0-1 is to be installed This reverts commit 5b267c0c. Reason for revert: <INSERT REASONING HERE> Original change's description: > Add libdconf-dev to to install-build-deps.sh > > This is the first step in moving from using gconf to dconf. > > Bug: 768027 > Change-Id: Ifb05a6679c38e115b322e0a7caa6c3aad309389e > Reviewed-on: https://chromium-review.googlesource.com/691097 > Commit-Queue: Tim Brown <timbrown@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#505183} TBR=dpranke@chromium.org,thomasanderson@chromium.org,timbrown@chromium.org Change-Id: Icec37c78711a2016667ee7f134d5db49b918b7d2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 768027 Reviewed-on: https://chromium-review.googlesource.com/692974 Commit-Queue: Dirk Pranke <dpranke@chromium.org> Reviewed-by:Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#505391}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/776de290..b4df6351 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: I3b4e8b6a90f76f98c6307372df64cfcf1078a585 Reviewed-on: https://chromium-review.googlesource.com/692338Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#505390}
-
Lukasz Anforowicz authored
WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=timloh@chromium.org Bug: 666525 Change-Id: Ib68682643dcf49005f05fe8b23a33a078f6bcef9 Reviewed-on: https://chromium-review.googlesource.com/689029Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#505389}
-
Justin Novosad authored
When resource type is an AcceleratedStaticBitmapImage, the WaitSyncTokenCHROMIUM call in the release callback is skipped because the context_provider_wrapper_ is null. This change fixes the problem by setting the context_provider_wrapper_ field of the frame resource to the same context that own the image resource. BUG=769161 Change-Id: Ib05a0fa5a6a0d4dab676fcc27820d1171260a25d Reviewed-on: https://chromium-review.googlesource.com/685380Reviewed-by:
Olivia Lai <xlai@chromium.org> Commit-Queue: Justin Novosad <junov@chromium.org> Cr-Commit-Position: refs/heads/master@{#505388}
-
Andrew Grieve authored
NOTRY=true # Doesn't affect bots Change-Id: Ic3058e571cf4409a0af851e183eebbb22a62fea9 Reviewed-on: https://chromium-review.googlesource.com/692178Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#505387}
-
Aaron Leventhal authored
Bug: 770188 Change-Id: Iffe6636f58b8ad55b0c44ce90f9e93596e98e635 Reviewed-on: https://chromium-review.googlesource.com/692414 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#505386}
-
Sky Malice authored
Bug: Change-Id: Id0b90f07d3be8355a29063519a95c1f6ca5e710a Reviewed-on: https://chromium-review.googlesource.com/691152Reviewed-by:
Patrick Noland <pnoland@google.com> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#505385}
-
spqchan authored
Bug: 741138 Change-Id: I62e5475e3e4ec45797c4491e42d90ef0187491bf Reviewed-on: https://chromium-review.googlesource.com/691057Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Sarah Chan <spqchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#505384}
-
Lukasz Anforowicz authored
WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=lcwu@chromium.org Bug: 666525 Change-Id: I74bb2e240ca4a54ac280c8b8d770f88a34dd1f4f Reviewed-on: https://chromium-review.googlesource.com/689102Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#505383}
-
Eugene But authored
Bug: 585700 Change-Id: Ie237264dd235db8c499608fd0b53fb79d50c8859 Reviewed-on: https://chromium-review.googlesource.com/691100Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#505382}
-
Xiyuan Xia authored
- Make AuthSyncObserver observe SigninErrorController in addition to sync service so that auth errors caused by other services are caught as well. - Fix an edge case that OAuth2LoginManager marks valid oauth2 token when it thinks /MergeSession succeeds regardless of whether there is any auth error; Additional changes of reland: - Update FakeGaia to mint tokens for any scopes when there is an AccessTokenInfo with no |scopes| defined; - Update the failed tests to use that so that all auth requests succeed and AuthSyncObserver does not set invalid token status unexpectedly; Bug: 760610, 768949 Test: OAuth2Test.SetInvalidTokenStatus Change-Id: I8173ceec02ba036820439b7a66f09cac40f27d3d Reviewed-on: https://chromium-review.googlesource.com/685795Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#505381}
-
Alexis Hetu authored
A few transitions tests are flaky on Linux (dbg), so marking them as such. TBR=kbr@chromium.org Bug: 769879 Change-Id: Ia7231db555aa53e2627149d97b7f31c80039b13f Reviewed-on: https://chromium-review.googlesource.com/692614Reviewed-by:
Alexis Hétu <sugoi@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Alexis Hétu <sugoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#505380}
-
Lukasz Anforowicz authored
WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=tommycli@chromium.org Bug: 666525 Change-Id: Ia641a614a5129624424e1c81b0a945befddd8cd5 Reviewed-on: https://chromium-review.googlesource.com/688773 Commit-Queue: Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
-
David Roger authored
Bug: 767004 Change-Id: I23298bfcc294f2aeca35bba572246d0bdbf97b70 Reviewed-on: https://chromium-review.googlesource.com/684895Reviewed-by:
-
Brian White authored
This reverts commit c0cb3888. Reason for revert: The bug that this was intended to help find... has been fixed! Original change's description: > Do more validation around Renderer exit. > > This is an extension of cl/655922 that (temporarily) adds > instrumentation to Android builds to try to determine the source > of a core trampler. > > Bug: 744734 > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation > Change-Id: I745eb4dcc40d59dfbcdf0e492e9bbd4aa31cab40 > Reviewed-on: https://chromium-review.googlesource.com/657804 > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > Reviewed-by: Nick Carter <nick@chromium.org> > Commit-Queue: Brian White <bcwhite@chromium.org> > Cr-Commit-Position: refs/heads/master@{#501504} TBR=nick@chromium.org,asvitkine@chromium.org,bcwhite@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 744734 Change-Id: I742cad308f440ef4cb655dd6ae44545df9fd91a3 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Reviewed-on: https://chromium-review.googlesource.com/692314Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#505377}
-
Samuel Huang authored
Bug: 769737 Change-Id: Ib659c0ddc33d1ea5150d8dfe38d44a2f5f57f10c Reviewed-on: https://chromium-review.googlesource.com/689960 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#505376}
-
Matt Menke authored
This means that it only lives on on thread: The network thread, instead of jumping between the UI thread and the IO thread, since the network pref store lives on the IO thread, just like the network stack. A similar change was made to chrome/, as part of network servicification (Though in Chrome it's created by the NetworkService now). In a followup CL, I'll simplify HttpServerPropertiesManager to only support the case where the prefs thread is the network thread. Bug: 768884 Change-Id: I92c97e8e5fb3f5cab46f1c998b92eaec48a3db5f Reviewed-on: https://chromium-review.googlesource.com/687803 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#505375}
-
Chris Pickel authored
Split LogoService into LogoService interface and LogoServiceImpl to make it easier to provide fake data to the test. Bug: 768419 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I84639189d2db1b24a2e139936c99369352bab587 Reviewed-on: https://chromium-review.googlesource.com/690198Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Chris Pickel <sfiera@chromium.org> Cr-Commit-Position: refs/heads/master@{#505374}
-
Brian White authored
This reverts commit 4b9e9b62. Reason for revert: The bug that this was intended to help find... has been fixed! Original change's description: > Do histogram validation when processing Renderer death. > > There are hints that the corruption being observed happens around > the death of a renderer. Add (temporary) instrumentation inside the > processing of this event to see if this can be narrowed down further. > > Bug: 744734 > Change-Id: I63b2bfeaa96d2e8f8f299cd2c48cca130e72a8ec > Reviewed-on: https://chromium-review.googlesource.com/655922 > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > Commit-Queue: Brian White <bcwhite@chromium.org> > Cr-Commit-Position: refs/heads/master@{#500443} TBR=asvitkine@chromium.org,bcwhite@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 744734 Change-Id: I44a5f0ffbcfffdd7eebf7409108ca42646a62761 Reviewed-on: https://chromium-review.googlesource.com/692354Reviewed-by:
-
Alexander Timin authored
Record a number of WebFrameSchedulers per RendererScheduler once per navigation. R=rkaplow@chromium.org,skyostil@chromium.org Change-Id: I0608ebf3c5808516c3888febda32a90c9f756b7b Reviewed-on: https://chromium-review.googlesource.com/680797Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#505372}
-
Brian White authored
The root cause of the Android "core trampler" has been found. This reverts the tracker used to record what objects were previously allocated in the memory block used by the object being overwritten. While the general "freed_object_tracker" module is generic and could be re-used should similar tramplers appear, it is best not to leave code in the build that is not actually being used. Feel free to ressurect this code in the future if there is a need for it. TBR=asvitkine (on vacation) Bug: 744734 Change-Id: I4f8224253365ac6c5e08f12401104593bf090588 Reviewed-on: https://chromium-review.googlesource.com/688043 Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#505371}
-
Mike West authored
This reverts commit 05a16884. Reason for revert: renderer_side_navigation_browser_tests broke after this patch, starting in https://build.chromium.org/p/chromium.mac/builders/Mac10.11%20Tests/builds/18672. Original change's description: > Prerender: Add test confirming cookie behavior. > > The behavior of NoStatePrefetch and cookies can be confusing. This adds > NoStatePrefetchBrowserTest.PrefetchCookie which documents and validates > that cookies are set on all prefetches. > > Change-Id: I9c707989a07102286ae2d3e5cd19f2cbf7e29520 > Reviewed-on: https://chromium-review.googlesource.com/691663 > Commit-Queue: Matthew Cary <mattcary@chromium.org> > Reviewed-by: Alexandr Ilin <alexilin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#505359} TBR=mattcary@chromium.org,alexilin@chromium.org Change-Id: Ic5c9c203d0e1508d262ff420a2e27e2d73f831c8 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/691997Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#505370}
-
Bernhard Bauer authored
Screenshots: https://folio.googleplex.com/zine/chrome_home_promo Bug: 769003 Change-Id: I37e452762f6696f53bd7c21ee09a8af5edcf1f03 Reviewed-on: https://chromium-review.googlesource.com/690715Reviewed-by:
Nicolas Dossou-Gbété <dgn@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#505369}
-
Sigurður Ásgeirsson authored
This reverts commit a99f67ed. Reason for revert: https://crbug.com/770193 - IO assert on main thread in browser startup. Original change's description: > Move ComBase functions and HSTRING helpers to base/win. > > Bug: 734095 > Change-Id: Ib984cd7094cf4e075863d692acb59722114e3990 > Reviewed-on: https://chromium-review.googlesource.com/649528 > Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> > Reviewed-by: Greg Thompson <grt@chromium.org> > Reviewed-by: Peter Beverloo <peter@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Robert Liao <robliao@chromium.org> > Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> > Cr-Commit-Position: refs/heads/master@{#505163} TBR=dcheng@chromium.org,peter@chromium.org,toyoshim@chromium.org,finnur@chromium.org,robliao@chromium.org,grt@chromium.org Change-Id: I150e7825b141b21b37e14ee7ff7089150aa50abb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 734095 Reviewed-on: https://chromium-review.googlesource.com/692615Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#505368}
-
