- 14 Aug, 2020 40 commits
-
-
Lan Wei authored
This reverts commit fc9217ef. Reason for revert: chrome_all_tast_tests fails on chromeos-eve-arc-r-chrome, https://ci.chromium.org/p/chrome/builders/ci/chromeos-eve-arc-r-chrome/2498 Original change's description: > Add several basic gtest & integration tests to new eve-arc-r bot. > > Bug: 1092973 > Change-Id: I4df191266f28297cf8581f1687de87e336713363 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339580 > Reviewed-by: Garrett Beaty <gbeaty@chromium.org> > Reviewed-by: Stephen Martinis <martiniss@chromium.org> > Commit-Queue: Ben Pastene <bpastene@chromium.org> > Cr-Commit-Position: refs/heads/master@{#796071} TBR=martiniss@chromium.org,bpastene@chromium.org,gbeaty@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1092973 Change-Id: Ibaa98c41af45981b5d195ef41db31d541c4ed5dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355088Reviewed-by:
Lan Wei <lanwei@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#798055}
-
Friedrich Horschig authored
This CL cleans up the usage of a scene change observer that used to be necessary to reset the accessory before scene changes (to avoid layout height changes affecting the tab switcher). Screenshots verifying the correct behavior are in the linked first bug. Bug: 1115644, 876254 Change-Id: If522cfc5686028afadfbd03bf1c5b19c748b07d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352916Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Mei Liang <meiliang@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#798054}
-
Zufeng Wang authored
A previous CL added the `show-parental-controls` postMessage. This CL opens OS Settings when that message is received. No metric change here, but the code inside the iframe that triggers the postMessage does a UMA log. Bug: b/159964708 Change-Id: I4461d2effc574503a34ae578e20a10af8961f0cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354122Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Rachel Carpenter <carpenterr@chromium.org> Commit-Queue: Zufeng Wang <zufeng@google.com> Cr-Commit-Position: refs/heads/master@{#798053}
-
Lijin Shen authored
Bug: 1116309 Change-Id: I5e0a52c07a81336ef11329993676766613a7b06e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355573 Commit-Queue: Lijin Shen <lazzzis@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#798052}
-
mark a. foltz authored
Note this required converting chromecast::media::{AvPipelineClient, VideoPipelineClient,MediaPipelineClient} to be move-only, as they now own a base::OnceClosure. Bug: 1007649 Change-Id: I4ff9d43085cd919e939093854d1e749ce43f83e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340510 Commit-Queue: mark a. foltz <mfoltz@chromium.org> Reviewed-by:Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#798051}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/283c230fa18a..b6ce6baf7a7a 2020-08-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from cda86eff6461 to abe07b943855 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC fmalita@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: fmalita@google.com Change-Id: I1823f16c325b3c2993bb4a7f4d667f7723cef9dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355407Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#798050}
-
Hiroki Nakagawa authored
As a preparation for using optimization hints in Blink, this CL adds plumbing from WebContentsObserver impl in the browser process to LocalFrame in the renderer process. The design doc is available here (sorry, this is google internal): https://docs.google.com/document/d/1Moiz1mY18GJ8q94GvZYQaMLyrYihpFe_4Wutkhte-9M/edit?usp=sharing Implementation details described in the doc are slightly different from this CL, but it's still useful for grasping the overview of the changes. Rough processing flow is as follows: [In chrome/browser/] - BlinkOptimizationGuideWebContentsObserver - This observes navigation events, queries the optimization guide service about the hints for Blink, and sends the hints to the renderer. - The hints are served from the optimization guide service as proto files. The observer converts them to BlinkOptimizationGuideHints mojom struct. - This sents the mojo message immediately before navigation commit (on WebContentsObserver::ReadyToCommitNavigation()) so that the renderer can utilize the hints as early as possible. We cannot send the hints before ReadyToCommitNavigation because at that point the previous navigation can be being processed on the frame. [In Mojo] - The existing PreviewsResourceLoadingHintsReceiver mojom interface is responsible for mojo communication. This implementation is tentative, and will be replaced with BlinkOptimizationGuideHints's own interface in follow-up CLs. See TODO comments in the mojom files. [In chrome/renderer/] - ResourceLoadingHintsAgent - This is the implementation of PreviewsResourceLoadingHintsReceiver interface. The agent keeps the hints until a new document is created for the navigation. - When the new document is created, the agent passes the hints to (Web)LocalFrame(Impl). [In third_party/blink/renderer/core/] - LocalFrame - This retains the hints and provides them to features. Other notable changes in this CL are as follows: - This CL adds new directories: - components/optimization_guide/blink/ contains clients code of the optimization guide service. - third_party/blink/mojom/optimization_guide/ contains mojom files related to the Blink optimization guide. Bug: 1113980 Change-Id: Ifeb5d8797ec642de8ab592db0b1a8a3fb6725df3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337050 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#798049}
-
Jeremie Boulic authored
Define password prompt dialog, shown when trying to open one or multiple encrypted archives. The password prompt dialog is defined and added to the DOM tree the first time we ask for it. When trying to open multiple zip files at the same time, password prompts are serialised: the password dialog is shown with the name of the current archive to be decrypted, until all required passwords are provided. The "Cancel" button cancels the mounting process without creating any error from the user's point of view. BUG=chromium:912236 TEST=browser_tests --gtest_filter="FileManagerJsTest.FilesPasswordDialog" TEST=browser_tests --gtest_filter="*/FilesApp*" Change-Id: I29993444fc5a00e1fb87035770541648f0b27b37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327352 Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Reviewed-by:
François Degros <fdegros@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#798048}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6f04e4b8b57c..cfad71e98305 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC ksakamoto@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1110109,chromium:1110346,chromium:1116014,chromium:1116159,chromium:1116179,chromium:897470 Tbr: ksakamoto@google.com Change-Id: Iee430619086bf33d87fc4a5803a9635653c887e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355405Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#798047}
-
Julie Jeongeun Kim authored
This CL moves printing::MarginType to //printing/mojom/print.mojom to pass it to Mojo interfaces. Bug: 1008939 Change-Id: I21fdc0b328617cf94bd31858b10618b3d1d548a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341222Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#798046}
-
Khushal Sagar authored
Add the setup to control the availability of this feature using an origin trial and log it in use counters for tracking usage through the experiment. R=chrishtr@chromium.org Bug: 1114184 Change-Id: I372d298ff657dbf3f75440b8d0867a92a61226bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343767 Commit-Queue: Khushal <khushalsagar@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#798045}
-
Mike Wasserman authored
Measure coarse cross-screen window placement metrics: - IDL: window.isMultiScreen, getScreens, and screenschange use - measures use of [multi-]screen information api surfaces - kFullscreenCrossScreen (requestFullscreen w/screen option) - includes explicit same-screen requests and denied requests - kDOMWindowOpenPositioningFeaturesCrossScreen (window.open) - includes any *requests* not contained by the current screen - kDOMWindowSetWindowRectCrossScreen (window.move*/resize*) - includes any *requests* not contained by the current screen See the bug for tracking of followup work items: TODO: Measure requests or actual/allowed placements? TODO: Measure individual moveTo/moveBy/resizeTo/resizeBy? TODO: Measure kMovedOrResizedPopupCrossScreen? TODO: Measure kFullscreenAllowedByOnscreenschange w/impl? TODO: Measure kDOMWindowOpenAllowedByOnscreenschange w/impl? Bug: 1115703 Change-Id: I4a5f52c2346a5497b81798fdcb496b2993a8cbd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315198 Commit-Queue: Michael Wasserman <msw@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#798044}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/1d054a1f6d99..a5f2b95badf5 2020-08-14 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ib19fe8f72250c56fd0d5acbd6831f9b34f264656 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355400Reviewed-by:
-
Hirokazu Honda authored
Bug: 1115112, b:155054799 Test: video_decode_accelerator_tests test-25fps.vp9_2 --use_vd on rammus Change-Id: I82eeaad222eb1ea961faced6cf209641d4cabd05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350659 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#798042}
-
Peter Kasting authored
Bug: 1104532 Change-Id: I02849597d4aa12244cb4656231c7b8b448522939 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354991 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#798041}
-
Peter Kasting authored
Bug: none Change-Id: I7da24a70506ea2b029e34b3bbe4804aa4b5a6b78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248879 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#798040}
-
Koji Ishii authored
This patch has no behavior changes. Change-Id: I403a093fb6c2686058db6a447a3731072279bba9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355153 Auto-Submit: Koji Ishii <kojii@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#798039}
-
Jeevan Shikaram authored
Update WebPaymentIntentHelper to stay in sync with the copy in ARC++. This CL pulls out the extraction of payment intent details to a new method so that ARC++ can use it synchronously. Bug: 1109119 Change-Id: Ic0c784a3fc51ed853ef51e0535c51b6b3fb06b60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352259Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Cr-Commit-Position: refs/heads/master@{#798038}
-
Min Qin authored
adding the flag for us to test the feature later. Change-Id: Ie7d3eaa063b8dc189ab5e2e59ac47cd5dfe9506b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355004Reviewed-by:
Hesen Zhang <hesen@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#798037}
-
Theresa Wellington authored
BUG=1111594 Change-Id: Ie0b2388373022e220bb8d8381d8051b159b4a723 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355512 Commit-Queue: Ted Choc <tedchoc@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#798036}
-
JunHo Seo authored
This value is not copied during decryption, so it is missed. We may consider copying it at CdmAdapter, but it seems CdmAdapter ensures only fields in CdmInputBuffer. So this cl follows same way as is_key_frame in DecryptingDemuxerStream. Change-Id: I701aaa51d24792a3bdb41eaaf1cef12c751a58fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348243Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: JunHo Seo <junho0924.seo@lge.com> Cr-Commit-Position: refs/heads/master@{#798035}
-
James Cook authored
Verify that notifications are correctly serialized, that user actions in the remote message center are proxied back, and that notifications can be closed. Inject the mojo::Remote<crosapi::mojom::MessageCenter> into the constructor to make this possible. Bug: 1113889 Change-Id: I9962b05c7fe637c0235f51bdfa56e78f7fb5de51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350316 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#798034}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/5559351c907d..eb85c0213d43 2020-08-14 jmadill@chromium.org Vulkan: Refactor Context CommandBuffer query. 2020-08-13 jmadill@chromium.org Vulkan: Track used Images in RenderPass. 2020-08-13 m.maiya@samsung.com Vulkan: Query application name from the system If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@google.com Change-Id: I8d7c46ed698678ace7bc79a894d9181b185bff46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355395Reviewed-by:
-
James Cook authored
Exercise showing a notification, user actions on the notification, and closing the notification. I'm working on lacros-side tests separately. Bug: 1113889 Change-Id: I254ec7f50ca2bce851cb97f9cf23262902ae8c3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350305 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#798032}
-
Keith Lee authored
This is necessary for the autocorrect functionality described in b/149796494. Bug: 1108170 Change-Id: I7315ffeb84a31c85b55fbb78652d3a1af086b06b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327773 Commit-Queue: Keith Lee <keithlee@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
My Nguyen <myy@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#798031}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/4faa62a0e9f8..241a4a92fb96 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ib9c5d8ff663792b58fda5cbb02b80b751deaff24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355509Reviewed-by:
-
Ted Meyer authored
I suspect I pasted it and forgot to fix it originally. Change-Id: Id883d47d5a8768c88d19056c24e0ab968a9e2dd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355095Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#798029}
-
Hirokazu Honda authored
The test file input to video_encode_accelerator_tests can have a lot of video frames. Since the tests keeps all the frames in shared memory or with file descriptor, the test suffers from the many video frames. In fact, with tulip2 test file AlignedDataHelper fails on creating shared memory because the opened shared memory is more than threshold on some systems. This CL limits the maximum frames to be used in a test file to avoid this problem. Bug: 1045825 Test: video_encode_accelerator_tests in tulip2-320x180.vp9.webm Change-Id: I9862180be662ba463fc39a47a6c12d7f63d55718 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336318 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
-
Lan Wei authored
Remove 'virtual/web-components-v0-disabled/external/wpt/dom/events/ Event-dispatch-click.html' from third_party/blink/web_tests/TestExpectations, because TestExpectations:2694 Expectation 'virtual/web-components-v0-disabled/ external/wpt/dom/events/Event-dispatch-click.html' is redundant with 'external/wpt/dom/events/Event-dispatch-click.html' in line 2695 TBR=robertma@google.com Bug: 1116292 Change-Id: Ia8e44532efd53b0596052f228f4861d762911474 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355401Reviewed-by:
-
Himanshu Jaju authored
This is a reland of 34bca2e3 Original change's description: > Implement key verification for incoming connection. > > Implements the key verification module that to verify remote device > before requesting introduction and beginning the transfer flow. > > Bug: 1085068 > Change-Id: I4bb75dce474042ef43ca86199db3456d63406874 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346325 > Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> > Reviewed-by: Alex Chau <alexchau@chromium.org> > Cr-Commit-Position: refs/heads/master@{#797868} Bug: 1085068 Change-Id: I3ed848943fe99ebd7b41904b0b814f65d8eff567 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352821Reviewed-by:
Josh Nohle <nohle@chromium.org> Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Cr-Commit-Position: refs/heads/master@{#798026}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I9b857ab5a67ad39ace66a1d845569a403f000ae7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354499Reviewed-by:
-
Trent Apted authored
CIPD package: https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/tnUpbECn-eLbumpU1g06p173LxX2eM_OP4QF_-OtILgC Release notes: http://go/media_app-x20/relnotes/Stable/media_app_20200813_RC00.html Bug: b/163296306, b/159083441, b/159083441, b/164206096, b/157387116 Fixed: 1112044 Cq-Include-Trybots: chrome/try:linux-chromeos-chrome Change-Id: I04dbf75b137a2ffd1ab0067a9b1d80c249e175a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352299Reviewed-by:
Patti <patricialor@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#798024}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/4faa62a0e9f8..241a4a92fb96 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Idf2c93ae4a1ac82ff18596cb7d8352df8fc79214 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354888Reviewed-by:
-
Sven Zheng authored
Based on https://ci.chromium.org/p/chromium/builders/ci/linux-lacros-tester-rel/967? https://ci.chromium.org/p/chromium/builders/ci/linux-lacros-tester-rel/966? Bug: 1111979 Change-Id: I861a7cc11c2834cccaf275c90de0c3ba80c4f478 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354719 Auto-Submit: Sven Zheng <svenzheng@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#798022}
-
Lan Wei authored
org.chromium.weblayer.test.ErrorPageCallbackTest.testOverrideErrorPage is flaky on Android, https://analysis.chromium.org/p/chromium/flake-portal/flakes/ occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyfAsSBUZsYWtlInFjaHJvbWl1bUB3ZWJs YXllcl9pbnN0cnVtZW50YXRpb25fdGVzdF9hcGtAb3JnLmNocm9taXVtLndlYmxheWVyLnRl c3QuRXJyb3JQYWdlQ2FsbGJhY2tUZXN0I3Rlc3RPdmVycmlkZUVycm9yUGFnZQw, disable it for now until it is fixed. TBR=estade@chromium.org Bug: 1116277 Change-Id: Id9eaa577587cb64136cd36364dc7e882f1c34876 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355399Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a6dff6f4..6f6dc9f3 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ice797c49ec562bc6bcab6d178471d31738fd6949 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355214Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#798020}
-
Alexander Dunaev authored
This is a reland of 1523bb86 Original change's description: > [ozone] Improved clipboard tests and de-duplicated string constants. > > This CL pays a bit of technical debt in the clipboard implementation. > > First, it updates a test that verifies that putting text into clipboard > registers the proper set of MIME types, as had been suggested in [1]. > > Second, it enables for Ozone the test that verifies selection buffers. > > Third, it de-duplicates some string constants. > > [1] https://chromium-review.googlesource.com/c/chromium/src/+/2306252 > > Change-Id: I6beb6b5b3827f0ec09cf19bc1868e7955141f680 > Bug: 911992, 1105892 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346338 > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Alexander Dunaev <adunaev@igalia.com> > Cr-Commit-Position: refs/heads/master@{#797572} Bug: 911992 Bug: 1105892 Change-Id: I832d56641910a7014d7b53a8ce19fd3c71be2c4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352803Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Alexander Dunaev <adunaev@igalia.com> Cr-Commit-Position: refs/heads/master@{#798019}
-
Ken MacKay authored
Bug: internal b/163708246 Change-Id: I7868fe3e507af53fa82206652c5dec130efd468c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351390 Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#798018}
-
Andrew Grieve authored
Prevents gn gen failure for v8. Bug: 1114750, 1115981 Change-Id: I9cdd0ad4e7bc0ed511b3d99d1ec6d004e31e6ba9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355436 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#798017}
-
Sinan Sahin authored
This reverts commit 52b501ca. The reason for the revert has been fixed with crrev.com/c/2248931. This reland also includes changes in tools/perf/benchmarks. We basically add a command-line switch to force the offline indicator an online state. This is because these benchmarks are run on offline devices and this causes the offline indicator to show and affects the stories being run. Showing the offline indicator isn't realistic when the test is simulating navigating webpages that would normally require the device to be online. Also, showing the offline indicator might cause flakiness in the results or dilute real regressions. We've investigated the reported regressions and confirmed that they're WAI when the indicator is showing. Original change's description: > Revert "[Offline indicator v2] Add field trial testing entry" > > This reverts commit ceaac935. > > Reason for revert: continued assertion failures on some phones; see http://crbug.com/1084740#c17 . > > Original change's description: > > [Offline indicator v2] Add field trial testing entry > > > > Enabling the feature causes some test failures since the bots are > > offline and the offline indicator is always visible. For the short term, > > we are adding a command-line switch to disable the offline indicator. > > > > The longer-term plan is to enable the feature for most tests, and only > > disable where we have to. > > > > Bug: 989148, 1091491, 1093085 > > Change-Id: I89e7ef93233b4c4cc2bd395ce1309bc14d5dea09 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228367 > > Reviewed-by: Steven Holte <holte@chromium.org> > > Reviewed-by: Brian Sheedy <bsheedy@chromium.org> > > Reviewed-by: Avi Drissman <avi@chromium.org> > > Reviewed-by: Theresa <twellington@chromium.org> > > Commit-Queue: Sinan Sahin <sinansahin@google.com> > > Cr-Commit-Position: refs/heads/master@{#777216} > > TBR=avi@chromium.org,twellington@chromium.org,holte@chromium.org,bsheedy@chromium.org,sinansahin@google.com > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 989148, 1091491, 1093085 > Change-Id: I6c22120bbb27ff430f73a40ea28f1bf1a9a7da31 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2244195 > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Reviewed-by: Steven Holte <holte@chromium.org> > Commit-Queue: Kenneth Russell <kbr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#778024} Bug: 1091491 Change-Id: I3fd5e9d92f61c980a664ad6b5c311fe6b68cd57c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246834Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
-
