GitLab

* Fixes GetHomeDir() for multi-profiles case on Chrome OS.
* Once user signs in on Chrome OS base::DIR_HOME is overridden with primary user homedir.
* Added content switch --homedir to pass that information to ppapi plugins since they
run in a separate process and previous base::DIR_HOME override does not apply there.

This fix doesn't require checking for --multi-profiles switch
since user_id hash is known even without it.

Note:
download_prefs.cc still uses GetHomeDir() in its DownloadPathIsDangerous() check.
// Consider downloads 'dangerous' if they go to the home directory on Linux and
// to the desktop on any platform.
In this context correct behavior is to use "real" base::GetHomeDir() and not "virtual one" base::DIR_HOME.
Since latter is remapped to some test dir in tests, in some subfolders in Chrome OS etc.

BUG=331530
TBR=vitalybuka@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270872

Review URL: https://codereview.chromium.org/200473002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272898 0039d316-1c4b-4281-b951-d872f2087c98

BUG=377508
TEST=Manually verified this updated angle matches expectations.

Review URL: https://codereview.chromium.org/293383004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272897 0039d316-1c4b-4281-b951-d872f2087c98

This is an intermediary CL. The FaviconClient is moving towards being a KeyedService.

BUG=377505

Review URL: https://codereview.chromium.org/303453004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272896 0039d316-1c4b-4281-b951-d872f2087c98

We need to call ui::InitializeInputMethodForTesting. This is currently
protected by USE_X11 but should not be.

TBR=pfeldman
BUG=none
TEST=content_shell --ozone-platform=egltest

Review URL: https://codereview.chromium.org/301603002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272895 0039d316-1c4b-4281-b951-d872f2087c98

Fixed playout time calculations by relying on the sender reports in order
to compute reliable capture timestamps in terms of the local clock.  Added
a ClockDriftSmoother to smooth out jitter/skew in the "NTP to local clock
TimeTicks" conversions.  Used the same to provide a gradual timeline shift
in the case where a receiver had to "hack up" playout times before the
first sender report was processed.

As proof-of-concept, also added playout_time "smoothness" testing to the
End2EndTest's.  Both first and second order effects are tested.

Miscellaneous clean-ups and fixes in timing code throughout media/cast.

BUG=356942

Review URL: https://codereview.chromium.org/280993002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272893 0039d316-1c4b-4281-b951-d872f2087c98

In current code, EmbeddedWorkerDispatcher is deleted in the destructor of RenderThreadImpl.
If EmbeddedWorkerDispatcher contains any WorkerWrapper in workers_, WorkerWrapper and EmbeddedWorkerDevToolsAgent will be deleted at that time.
And the destructor of EmbeddedWorkerDevToolsAgent will call RemoveEmbeddedWorkerRoute of RenderThreadImpl which is being deleted.

To avoid this we should delete EmbeddedWorkerDispatcher in RenderThreadImpl::Shutdown().

BUG=377258,358657

Review URL: https://codereview.chromium.org/297343002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272892 0039d316-1c4b-4281-b951-d872f2087c98

BUG=364141, 330264
TBR=jam@chromium.org for code deletion in content/public/browser_plugin_guest_delegate.{cc|h}

Review URL: https://codereview.chromium.org/295083002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272889 0039d316-1c4b-4281-b951-d872f2087c98

Roll the script to 209116 to match a recent clang roll.

BUG=375245
R=glider@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/301583002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272888 0039d316-1c4b-4281-b951-d872f2087c98

This adds the image that Issue 294343004 is dependent on.

BUG=331453
R=bauerb@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/293363002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272887 0039d316-1c4b-4281-b951-d872f2087c98

Similarly to chrome://drive-internals, this patch introduce a webui page
showing what's going on in the system.

Currently, only mounted file systems, and number of active requests are shown,
however more is coming soon.

TEST=Tested manually by invoking chrome://fsp-internals with a running
     providing extension.
BUG=376095

Review URL: https://codereview.chromium.org/296003012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272886 0039d316-1c4b-4281-b951-d872f2087c98

We used to declare sanitizer interface functions explicitly because we didn't
have access to sanitizer interface headers. That has not been the case for a
while. Also, a recent clang roll changed the signature of
__sanitizer_sandbox_on_notify() causing conflicts with our own declaration.

BUG=none
TBR=jln@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/294093012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272885 0039d316-1c4b-4281-b951-d872f2087c98

Added automatic mode to FakeInputAudioStream to generate automatic beeps.

This patch is to allow writing audio only tests using the fake input stream, also it changes the name of the fake device from "Default" to "Fake Audio, which I hope it will make things less confusing.

Previously it broke the mac bots due to it somehow triggered crbug/288562, crbug/371271, which should have been fixed by https://codereview.chromium.org/274073002/

TBR=ananta@chromium.org, dalecurtis@chromium.org

NOTRY=true

BUG=358541
TEST=bots existing webrtc tests.

Review URL: https://codereview.chromium.org/279223002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272884 0039d316-1c4b-4281-b951-d872f2087c98

content Response::Parse doesn't match chrome Response::Serialize.

BUG=373325

Review URL: https://codereview.chromium.org/300703002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272883 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://codereview.chromium.org/291343004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272882 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/301533002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272881 0039d316-1c4b-4281-b951-d872f2087c98

profile pref store may observe the validation of tracked preferences.

BUG=

Review URL: https://codereview.chromium.org/266553002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272880 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272878 0039d316-1c4b-4281-b951-d872f2087c98

Please reply to the V8 sheriff verwaest@chromium.org in case of problems.

TBR=verwaest@chromium.org

Review URL: https://codereview.chromium.org/302533006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272877 0039d316-1c4b-4281-b951-d872f2087c98

- SyncWorker: Construct / Destruct
- SyncWorker::Observer: Destruct


BUG=347425
TEST=./unit_tests --gtest_filter="SyncEngineTest.*:DriveBackendSyncTest.*"

Review URL: https://codereview.chromium.org/288193002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272876 0039d316-1c4b-4281-b951-d872f2087c98

1) Fix a typo in ScoredHistoryMatch::GetFrequency name
2) Fix a cpplint warning

BUG=370850

Review URL: https://codereview.chromium.org/300433003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272875 0039d316-1c4b-4281-b951-d872f2087c98

This avoids a GL error from a buggy glGetIntegerv(GL_MAX_SAMPLES_ANGLE)
call. Based on patch by mkisilev@yandex-team.ru

BUG=362435
R=sievers@chromium.org

Review URL: https://codereview.chromium.org/296133007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272874 0039d316-1c4b-4281-b951-d872f2087c98

Introduced in https://codereview.chromium.org/294033002/

NOTRY=true
BUG=None
TBR=noms@chromium.org

Review URL: https://codereview.chromium.org/297393002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272873 0039d316-1c4b-4281-b951-d872f2087c98

BUG=375679

Review URL: https://codereview.chromium.org/298873007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272872 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds a unit test for the experimental app list that instantiates
the app list in experimental mode and performs a series of very basic
checks.

BUG=349727

Review URL: https://codereview.chromium.org/291653003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272871 0039d316-1c4b-4281-b951-d872f2087c98

Phase one : introduce future screen classes before moving code from handler.

BUG=373314

Review URL: https://codereview.chromium.org/293613003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272870 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272869 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272868 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272867 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Support "Pin to taskbar" for hosted app windows. (https://codereview.chromium.org/258243002/)

Reason for revert:
Suspect to cause failure on Vista machines: http://build.chromium.org/p/chromium.win/builders/Vista%20Tests%20%283%29/builds/40163

Original issue's description:
> Support "Pin to taskbar" for hosted app windows.
> 
> This CL allows hosted app windows to be pinned to the taskbar by
> right-clicking the taskbar icon and pressing the "Pin to taskbar" button.
> 
> This CL pulls out the code that sets the relaunch details of v2 app
> windows into web::UpdateRelaunchDetails.
> 
> BUG=368101
> TEST=Run a hosted app as a window. Pin it from the taskbar icon right click
> menu. Relaunch the app from the pinned icon.
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272851


NOTRY=true
NOTREECHECKS=true
TBR=calamity@chromium.org

Review URL: https://codereview.chromium.org/298003005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272866 0039d316-1c4b-4281-b951-d872f2087c98

Multi-sided patch:
1/3: chromium-side, THIS PATCH
2/3: blink-side, https://codereview.chromium.org/287363004/
3/3: chromium-side, cleanup & re-enable test (n/a yet)

BUG=376733
TEST=LayoutTests is to be added, content_browsertests is to be re-enabled
TBR=tsepez@chromium.org

Review URL: https://codereview.chromium.org/299003002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272865 0039d316-1c4b-4281-b951-d872f2087c98

- introduce a minimum number of frames for bitrate tests; if a stream is
  too short, loop it over as many times as needed to reach that minimum
- instead of using additional black frames to flush the encoder at the
  end of encode, just rewind and reuse frames from the beginning;
  this also eliminates the need for the CS_FINISHING state;
- switch to a more demanding/varied stream for bitrate tests (bear)

- also move the starting point of encoder FPS calculation from Initialize()
  to after setting up the buffers to slightly better estimate actual encoder
  performance
- minor additions to the documentation of and fixes for input buffer size
  calculation
- add ifdefs to only check alignment on ARM

BUG=366158
TEST=run test, ensure bitrates converge properly on relevant platforms

Review URL: https://codereview.chromium.org/290643003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272864 0039d316-1c4b-4281-b951-d872f2087c98

This CL removes old Gallery files and related codes.
Along the way, the CL also fixes the file handler specification so that the Gallery can handle multiple selected video files.

BUG=358698,376240
TEST=manually

Review URL: https://codereview.chromium.org/291893006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272863 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272862 0039d316-1c4b-4281-b951-d872f2087c98

and Use ExtensionRegistry functions instead of deprecated  ExtensionService functions.

R=xiyuan@chromium.org,rdevlin.cronin@chromium.org
BUG=354046, 354458

Review URL: https://codereview.chromium.org/275503003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272861 0039d316-1c4b-4281-b951-d872f2087c98

R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/299353002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272860 0039d316-1c4b-4281-b951-d872f2087c98

Revert of non-new-profile-management creates a "no-op" style account_reconcilor, (https://codereview.chromium.org/276463002/)

Reason for revert:
unit tests fail on mac

Original issue's description:
> non-new-profile-management creates a "no-op" style account_reconcilor,
> useful for tracking stats but won't have any real effects.
> 
> Modify the AccountReconcilor_unittest to execute with the new_profile_management flag on.
> 
> BUG=357693
> TEST=Account Reconciler should function normally when
> new_profile_management flag is on. Should not have effects when the
> flag is off, but UMA stats (histograms) and logging (for
> --vmodule=account_reconcilor=1) should still trace the execution path.
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272131
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272826

NOTRY=true
NOTREECHECKS=true
TBR=mlerman@chromium.org

Review URL: https://codereview.chromium.org/297303003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272859 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Reparent SWProcessManager onto SWContextWrapper. (https://codereview.chromium.org/292973003/)

Reason for revert:
I suspect this broke ServiceWorkerDispatcherHostTest.EarlyContextDeletion on linux

Original issue's description:
> Reparent SWProcessManager onto SWContextWrapper.
> 
> This will allow Wrapper::Shutdown to drop all process references synchronously
> in a future change, which will make it possible to shutdown Chrome with service
> workers running and without hitting the DCHECK in
> ProfileDestroyer::DestroyProfileWhenAppropriate().
> 
> BUG=368570
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272839

TBR=falken@chromium.org,kinuko@chromium.org,jyasskin@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=368570

Review URL: https://codereview.chromium.org/307443003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272858 0039d316-1c4b-4281-b951-d872f2087c98

 * Add TaskLogger class to log per-task status.
 * Wire up it SyncFileSystemService to SyncTaskManager.

BUG=344769

Review URL: https://codereview.chromium.org/291403004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272857 0039d316-1c4b-4281-b951-d872f2087c98

BUG=369249

Review URL: https://codereview.chromium.org/291303007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272856 0039d316-1c4b-4281-b951-d872f2087c98

r272157 introduced a regression where ephemeral apps would be synced
when Chrome restarts, causing them to be installed.

BUG=374018

Review URL: https://codereview.chromium.org/295203002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272855 0039d316-1c4b-4281-b951-d872f2087c98