- 25 Nov, 2018 22 commits
-
-
Ehsan Karamad authored
The API WebContentsImpl::GetInnerWebContents() returns two types of WebContentses: the first type which are attached using AttachToOuterContentsFrame, and legacy type which are based on BrowserPlugin. Similarly, WebContentsImpl::GetOuterWebContents() has a different behavior depending on the type of the GuestView. Specifcally, if the WebContents is for a BrowserPlugin-based GuestView, then GetOuterWebContents() will return nullptr until BrowserPluginGuest is attached. This means GetInnerWebContents() might return WebContentsImpls whose BrowserPluginGuest is not still attached which is incorrect. This issue seems to have caused a bug in find-in-page where there is a MimeHandlerViewGuest in the page. Bug: 897465 Change-Id: I1fc9b209cf5d1835e2aee311e36da15526c249c4 Reviewed-on: https://chromium-review.googlesource.com/c/1323904Reviewed-by:
Lucas Gadani <lfg@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#610735}
-
Dominik Röttsches authored
https://chromium.googlesource.com/external/github.com/harfbuzz/harfbuzz/+log/54d332dd9b0263..ae96c98dfaef3a7 Enables native AAT support in HarfBuzz without relying on CoreText. Performance improvements compared to Mac OS CoreText implementation ranging between 3.2x speedup for Hebrew using Lucida Grande up to 12.2x speedup for Latin with the San Francisco system font. This should unblock issue 862773 and other AAT performance issues we have seen. For performance data, see: https://goo.gl/tZJU2y The following HarfBuzz issues on AAT issues were reported to HarfBuzz and have been ironed out in the HarfBuzz commit that we're rolling to: https://github.com/harfbuzz/harfbuzz/issues?q=1263+1264+1278+1303+1305+1331+1342+1348+1343+1393+1405+1406 The rebaselines affect: * Kerning differences, especially improved kerning with punctuation on Windows, unrelated to AAT implementation * Slight difference in glyph coordinate rounding for AAT fonts due to internal computation with subpixel values, but screen placement at rounded pixels * Combining mark placement differences between HarfBuzz AAT and CoreText AAT, compare https://github.com/harfbuzz/harfbuzz/issues/1264 * Changes in vertical origin computation in HarfBuzz, unrelated to AAT IMPORTANT: If HarfBuzz AAT needs to be reverted, consider changing if (false) in BUILD.gn to if (is_mac) to re-enable the hb-coretext backend for processing AAT instead of reverting the whole CL. Big kudos and a big thank you to behdad@ for the excellent work on implementing AAT in HarfBuzz and this smooth collaboration in maturing the implementation. Binary-Size: Intended functionality add in HarfBuzz to support AAT fonts natively without using CoreText Bug: 894354 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Iab082fbd47cd1df9e1fd9558a12ddf597db77f7b Reviewed-on: https://chromium-review.googlesource.com/c/1275945 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#610734}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/b357e54dd5b2..f1c194decd51 git log b357e54dd5b2..f1c194decd51 --date=short --no-merges --format='%ad %ae %s' 2018-11-25 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision d298cced..7579fcbc (610627:610728) 2018-11-23 oprypin@webrtc.org Roll chromium_revision f9be7d3d..d298cced (610432:610627) 2018-11-23 aleloi@webrtc.org Revert "Replace the IceConnectionState implementation." 2018-11-23 sprang@webrtc.org Remove use of CodecSpecificInfo.codec_name 2018-11-23 jonasolsson@webrtc.org Replace the IceConnectionState implementation. 2018-11-23 srte@webrtc.org Adds stable bandwidth estimate to GoogCC. 2018-11-23 ssilkin@webrtc.org Don't buffer encoded frames. 2018-11-23 srte@webrtc.org Moves ProbeBitrateEstimator from DelayBasedBwe. 2018-11-23 mbonadei@webrtc.org Decouple //rtc_base:rtc_base_tests_utils from gunit. 2018-11-23 kuddai@google.com Expose jitter buffer flushes metric in new getStats api. Created with: gclient setdep -r src/third_party/webrtc@f1c194decd51 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:906803,chromium:None,chromium:907113 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Idf6801287f38d7f2ac2d87e8d3b387e98918b8a1 Reviewed-on: https://chromium-review.googlesource.com/c/1350353Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610733}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/66d186083876..348403b6295c Created with: gclient setdep -r src-internal@348403b6295c The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I2c101baf438a746f150c8fdc90ba2ac3440b5dcb Reviewed-on: https://chromium-review.googlesource.com/c/1350352Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610732}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/39cb969f1a09..66d186083876 Created with: gclient setdep -r src-internal@66d186083876 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: If76d06f7cdce94d442bd9bbc755a64a78dcc5f1b Reviewed-on: https://chromium-review.googlesource.com/c/1350351Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610731}
-
Harald Alvestrand authored
This provides the IDL surface only, there is no connection to the underlying objects. Bug: 907849 Change-Id: Ie11bac767c6a26628c1bc757d2529f1192a07e40 Reviewed-on: https://chromium-review.googlesource.com/c/1348064 Commit-Queue: Harald Alvestrand <hta@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#610730}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Id6b356bc7c9c616769bf2f930d438b1ee950f67d Reviewed-on: https://chromium-review.googlesource.com/c/1350219Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610729}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/500be6dd..84e2ca99 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I0c693cf0e781354a7508c62c3f6a9f2e672f06b4 Reviewed-on: https://chromium-review.googlesource.com/c/1350312Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610728}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7806890baf47..88deeb1d92d1 git log 7806890baf47..88deeb1d92d1 --date=short --no-merges --format='%ad %ae %s' 2018-11-25 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version Created with: gclient setdep -r src/third_party/skia@88deeb1d92d1 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=borenet@chromium.org Change-Id: Iab96429438d50fab9a6241480f2be31e0c071765 Reviewed-on: https://chromium-review.googlesource.com/c/1350218Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610727}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6215534b825e..39cb969f1a09 Created with: gclient setdep -r src-internal@39cb969f1a09 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I9106219b5689662f71bf1d6b3569e4251148248e Reviewed-on: https://chromium-review.googlesource.com/c/1350217Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610726}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c16abee8c533..7806890baf47 git log c16abee8c533..7806890baf47 --date=short --no-merges --format='%ad %ae %s' 2018-11-25 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset 2018-11-25 skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com Update markdown files 2018-11-25 caryclark@skia.org fix textblob doc examples Created with: gclient setdep -r src/third_party/skia@7806890baf47 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=borenet@chromium.org Change-Id: I72e58842ea0b7a1e0be0b8bd42eee5234df8dbc0 Reviewed-on: https://chromium-review.googlesource.com/c/1350216Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610725}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/659cabbadbb0..6215534b825e Created with: gclient setdep -r src-internal@6215534b825e The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I6a841829b4f60720f945284b4293a881ba5cba96 Reviewed-on: https://chromium-review.googlesource.com/c/1350215Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610724}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/035928454440..659cabbadbb0 Created with: gclient setdep -r src-internal@659cabbadbb0 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I31c851d952c46beb0fa2b481ff622bda9d7a3640 Reviewed-on: https://chromium-review.googlesource.com/c/1350212Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610723}
-
Pavel Feldman authored
Change-Id: I9dcdabed9e8e255bfb9911234b5c2c2a37d57fd1 Reviewed-on: https://chromium-review.googlesource.com/c/1349501Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#610722}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/424abc9e6740..035928454440 Created with: gclient setdep -r src-internal@035928454440 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I947f81d4e88f6a63956dcd498f40914762b8d2c9 Reviewed-on: https://chromium-review.googlesource.com/c/1350329Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610721}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f55b4065c7df..424abc9e6740 Created with: gclient setdep -r src-internal@424abc9e6740 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I170dd8e15c475d772b0a7d9f2898181b72ac0be8 Reviewed-on: https://chromium-review.googlesource.com/c/1350054Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610720}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=abdulsyed@chromiue.org Change-Id: Id5978ed07bc73572e869d60cb763866dcae94241 Reviewed-on: https://chromium-review.googlesource.com/c/1350197Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#610719}
-
Keishi Hattori authored
Convert D*, E* class allocations from new to MakeGarbageCollected Bug: 757708 Change-Id: I95df03a1b21a9be11d409845f1aacdf19289a617 Reviewed-on: https://chromium-review.googlesource.com/c/1349909 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#610718}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c357a1c45fbe..f55b4065c7df Created with: gclient setdep -r src-internal@f55b4065c7df The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I6ba2809f0bdbf9fe3206154a53026c87ed2cb9e8 Reviewed-on: https://chromium-review.googlesource.com/c/1350249Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610717}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4442933883f3..c357a1c45fbe Created with: gclient setdep -r src-internal@c357a1c45fbe The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ie210e949851e1ba91b81add578d21b82046fa6fb Reviewed-on: https://chromium-review.googlesource.com/c/1350052Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610716}
-
Victor Costan authored
Original change: https://www.sqlite.org/src/info/8576ccb479fc4b76 Original change description: Make the winTruncate() method of the windows VFS be a no-op if there are outstanding references to the memory-mapped pages. Otherwise, memory might be deleted out from under those references when the file is remapped during the truncate operation. TBR=cmumford Bug: 897576 Change-Id: I699a92f342b1fda39979f8a8922bce03160ac3da Reviewed-on: https://chromium-review.googlesource.com/c/1349462Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#610715}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4a0a7a674922..4442933883f3 Created with: gclient setdep -r src-internal@4442933883f3 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Idb97a20f1dbfa147f9c85a1a9eb3c6f7a7069ea6 Reviewed-on: https://chromium-review.googlesource.com/c/1350229Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610714}
-
- 24 Nov, 2018 18 commits
-
-
Steve Kobes authored
This potentially replaces JankTracker's current use of blink::Region, which is worst-case quadratic. Initial tests suggest the sweep line is slower than blink::Region for simple regions, but faster for complex ones (even with low rect counts). Landing behind a REF (JankTrackingSweepLine) pending further testing. Bug: 581518 Change-Id: I0b0ee613acb265576791661ac3af484287421111 Reviewed-on: https://chromium-review.googlesource.com/c/1348851 Commit-Queue: Steve Kobes <skobes@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#610713}
-
Nektarios Paisios authored
Also, fixed a few bugs in the Select() method, namely selection should not occur if it is unavailable in the current document and the cached range should be cleared and re-set. R=dmazzoni@chromium.org Change-Id: I214ff808af402f379c12ae533fea8e9c2a3888ec Bug: 639340 Reviewed-on: https://chromium-review.googlesource.com/c/1340639 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#610712}
-
Joey Arhar authored
Bug: 900298 Change-Id: I63f1d78010094e0bd1a9c05244a9e1c61cee3970 Reviewed-on: https://chromium-review.googlesource.com/c/1343512 Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#610711}
-
Joey Arhar authored
Bug: 800768 Change-Id: I74d13257cd37821f3d75c14a168ccc403e559a32 Reviewed-on: https://chromium-review.googlesource.com/c/1342765 Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#610710}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/28795bac45ff..c16abee8c533 git log 28795bac45ff..c16abee8c533 --date=short --no-merges --format='%ad %ae %s' 2018-11-24 reed@google.com impl gettextpath using SkFont 2018-11-24 reed@google.com add SK_SUPPORT_LEGACY_TEXTBLOBBUILD_WITH_PAINT for google3 Created with: gclient setdep -r src/third_party/skia@c16abee8c533 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=csmartdalton@chromium.org Change-Id: I9d6252cf00d7e9845d3d57c892c4dfd627feee7e Reviewed-on: https://chromium-review.googlesource.com/c/1350033Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610709}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8b8024c829af..4a0a7a674922 Created with: gclient setdep -r src-internal@4a0a7a674922 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I20cda44ad87401cd30d47e8c201e24c09cea450e Reviewed-on: https://chromium-review.googlesource.com/c/1350032Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610708}
-
Xiaocheng Hu authored
PreviousBoundary is the legacy utility function for word and sentence boundary algorithms. This patch removes it as it now doesn't have any usage. Bug: 778507 Change-Id: I3792d1786867b3e68549267bba36d4ad54263dc2 Reviewed-on: https://chromium-review.googlesource.com/c/1337284 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#610707}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e57041599639..8b8024c829af Created with: gclient setdep -r src-internal@8b8024c829af The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Id44c8d9128e30c026e1fc1827ad1e9bf855d784f Reviewed-on: https://chromium-review.googlesource.com/c/1350030Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610706}
-
Keishi Hattori authored
Convert I*, K*, L* class allocations from new to MakeGarbageCollected Bug: 757708 Change-Id: I6628cf0dcb290ae334cbaf880e1c1f8972d093a0 Reviewed-on: https://chromium-review.googlesource.com/c/1350009Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#610705}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c548a47794e9..e57041599639 Created with: gclient setdep -r src-internal@e57041599639 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I61313545da77151449d3f68fe58d9ea201787d01 Reviewed-on: https://chromium-review.googlesource.com/c/1350029Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610704}
-
Keishi Hattori authored
Convert F*, G*, H* class allocations from new to MakeGarbageCollected Bug: 757708 Change-Id: I112afaff0ac2297d67f68f13a551fda232523e47 Reviewed-on: https://chromium-review.googlesource.com/c/1349910Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#610703}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/de585c6fc389..c548a47794e9 Created with: gclient setdep -r src-internal@c548a47794e9 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I423b1e976456cbf0a8b1b4a379a9b1f8a483d544 Reviewed-on: https://chromium-review.googlesource.com/c/1349891Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610702}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e92ff4635e2c..de585c6fc389 Created with: gclient setdep -r src-internal@de585c6fc389 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I0addcbca30645884d57b52851d0e324887d84a3c Reviewed-on: https://chromium-review.googlesource.com/c/1349929Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610701}
-
Victor Costan authored
This reverts commit 7202f4dc. Reason for revert: CL is only needed in 72.0.3620.0 Windows Canary to diagnose SQLite crashes. Original change's description: > sqlite: Disable mmap usage on Windows. > > This is an experiment to see if the crashes in the referenced bug are > related to mmap changes on Windows. This CL will be reverted after it > goes live in 1-2 canaries. > > TBR=cmumford > > Bug: 897576 > Change-Id: Ic44836c4ed848f8713d16b553f038c63119f0aaf > Reviewed-on: https://chromium-review.googlesource.com/c/1348736 > Commit-Queue: Victor Costan <pwnall@chromium.org> > Reviewed-by: Victor Costan <pwnall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#610551} TBR=cmumford@chromium.org,pwnall@chromium.org Change-Id: I4d79a63c2a428e1e8ab04143a4d8280e274db1fd Bug: 897576 Reviewed-on: https://chromium-review.googlesource.com/c/1349789 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#610700}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4ff408590093..28795bac45ff git log 4ff408590093..28795bac45ff --date=short --no-merges --format='%ad %ae %s' 2018-11-24 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset Created with: gclient setdep -r src/third_party/skia@28795bac45ff The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=csmartdalton@chromium.org Change-Id: Idbc89c25c6836051173d6bff2628c87a6ab73445 Reviewed-on: https://chromium-review.googlesource.com/c/1349890Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610699}
-
Marc Treib authored
The corresponding feature was never launched, and its code was recently deleted (https://crrev.com/c/1348089). Bug: 898957 Change-Id: I12eb6de7531c6fa5ffff34cf86ff5f7c1752fef6 Reviewed-on: https://chromium-review.googlesource.com/c/1349223 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#610698}
-
Mohamed Amir Yosef authored
The test was flaky because it uses folder information to identify different entities. However, the code didn't properly populate the folder information for entities from the server. This CL fixes that and renables the test Bug: 823484 Change-Id: Ia6fcb82fe69ce5f6f79866929f98cba24d3eac3d Reviewed-on: https://chromium-review.googlesource.com/c/1349657 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#610697}
-
Eric Willigers authored
Promote our :first-child :last-child invalidation layout test to WPT. https://drafts.csswg.org/selectors-4/#the-first-child-pseudo Change-Id: I3c2e1af82ef2dac58ec5bfe642b156289457bb22 Reviewed-on: https://chromium-review.googlesource.com/c/1348873Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#610696}
-