GitLab

The HTTP request headers normally used by Chrome for Android are
generated in the native layer. We do not want to load native when the
Physical Web is resolving URLs in the background, so we cannot access
these values directly. Instead, they are reconstructed from values
accessible from the Java layer.

BUG=607660

Review-Url: https://codereview.chromium.org/1989963003
Cr-Commit-Position: refs/heads/master@{#398120}

Only the network prediction enabled preference should be used to
schedule or cancel periodic GCM task. The GCM task itself will run only
when suitable for precaching.

BUG=616956

Review-Url: https://codereview.chromium.org/2037913002
Cr-Commit-Position: refs/heads/master@{#398119}

BUG=584342

Review-Url: https://codereview.chromium.org/1966643002
Cr-Commit-Position: refs/heads/master@{#398118}

Reverted after its own LayoutTests timed out in WebKit Win7 bot.
This is due to media/mojo/interfaces not being in the generated
bindings path, and that's being addressed in
https://codereview.chromium.org/2045573002/.

Original landed as https://crrev.com/2027023002
Original description ---------------------------------------------------
ImageCapture: move mojom from WebKit/public to media/

This CL moves image_capture.mojom from
{third_party/WebKit/public/platform/modules => media/mojo/interfaces}
so the generated data types (e.g. PhotoCapabilities{Ptr})
can be used from both Blink and media/capture locations.

Also capture.gypi is trivially relocated to capture/ folder.

Note that gyp files are -yay!- close to being finally
removed.

BUG=518807
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel,mac_blink_rel,win_blink_rel

TBR=rockot@chromium.org, avi@chromium.org, dcheng@chromium.org, haraken@chromium.org, xhwang@chromium.org  (no code changes).

Review-Url: https://codereview.chromium.org/2040963004
Cr-Commit-Position: refs/heads/master@{#398117}

BUG=612828

Review-Url: https://codereview.chromium.org/2014463003
Cr-Commit-Position: refs/heads/master@{#398116}

BUG=617701

Review-Url: https://codereview.chromium.org/2011213002
Cr-Commit-Position: refs/heads/master@{#398115}

RenderFrame no longer knows about WebElement or WebNode, yay!

R=esprehn
BUG=

Review-Url: https://codereview.chromium.org/2002683002
Cr-Commit-Position: refs/heads/master@{#398114}

BUG=589168

Review-Url: https://codereview.chromium.org/2041973002
Cr-Commit-Position: refs/heads/master@{#398113}

A change to enable WPO for the x64 Win official builds caused
content_browserto expand beyond 2 GB which caused these errors:

  obj\content\content_browser.lib : fatal error LNK1107: invalid or
  corrupt file: cannot read at 0xEAE7739

msvs_shard is a way of breaking up a library to avoid this limitation.

This issue doesn't affect the GN builds (because they use a sourceset
concept instead of these huge static libraries).

TBR=creis@chromium.org
BUG=616946

Review-Url: https://codereview.chromium.org/2046573003
Cr-Commit-Position: refs/heads/master@{#398112}

MAC_OS_X_VERSION_MIN_REQUIRED corresponds to -mmacosx-version-min, which
we currently set to 10.7 (and plan to set to 10.9 eventually, after fixing
deprecation warnings).

MAC_OS_X_VERSION_MAX_ALLOWED corresponds to the SDK used to compile
chrome.  We currently require the 10.10 SDK.

Remove all code in sdk_forward_declarations that's no longer necessary.
No behavior change.

BUG=579255

Review-Url: https://codereview.chromium.org/2046693002
Cr-Commit-Position: refs/heads/master@{#398111}

Flipped writing modes cause an object's offset to be flipped relative
to its parent. This patch switches from using locationOffset to
topLeftLocation which includes writing mode handling. This matches
similar logic in PaintLayer::updateLayerPosition. A comment has been
added about removing unnecessary craws back up the tree for calculating
containing blocks.

With this patch, all fast/block/positioning tests pass, modulo our lack
of multicolumn fragment painting.

BUG=614257

Review-Url: https://codereview.chromium.org/2031873005
Cr-Commit-Position: refs/heads/master@{#398110}

Once the HostCache exposes stale results, plumb them through the
HostResolverImpl for callers who want them.

BUG=605138

Review-Url: https://codereview.chromium.org/1903263002
Cr-Commit-Position: refs/heads/master@{#398109}

MessageLoop::PostTask/PostDelayedTask/DeleteSoon/ReleaseSoon
are deprecated. This CL makes the following replacements to
remove some uses of these methods:

"MessageLoop(ForUI|ForIO)::current()->PostTask" ->
  "ThreadTaskRunnerHandle::Get()->PostTask"
"MessageLoop(ForUI|ForIO)::current()->PostDelayedTask" ->
  "ThreadTaskRunnerHandle::Get()->PostDelayedTask"
"MessageLoop(ForUI|ForIO)::current()->DeleteSoon" ->
  "ThreadTaskRunnerHandle::Get()->DeleteSoon"
"MessageLoop(ForUI|ForIO)::current()->ReleaseSoon" ->
  "ThreadTaskRunnerHandle::Get()->ReleaseSoon"

In files where these replacements are made, it adds these includes:
  #include "base/location.h"
  #include "base/single_thread_task_runner.h"
  #include "base/threading/thread_task_runner_handle.h"

And removes this include if it is no longer required:
  #include "base/message_loop/message_loop.h"

Why ThreadTaskRunnerHandle::Get() instead of
MessageLoop::current()->task_runner()?
 - The two are equivalent on threads that run a MessageLoop.
 - MessageLoop::current() doesn't work in base/task_scheduler
   because the scheduler's thread don't run MessageLoops.
   This CL will therefore facilitate the migration of browser
   threads to base/task_scheduler.

Steps to generate this patch:
1. Run message_loop_cleanup.py (see code on the bug).
2. Run tools/sort-headers.py on modified files.
3. Run git cl format.

BUG=616447
R=ben@chromium.org

Review-Url: https://codereview.chromium.org/2029413004
Cr-Commit-Position: refs/heads/master@{#398108}

This CL defines StructTraits<mus::mojom::Event, unique_ptr<ui::Event>>. With
this mojo automatically uses unique_ptr<ui::Event> instead of mus::mojom::Event
when generating C++ header files for mojom interfaces, and events are
automatically serializied/deserialized and validated when sending/receiving over
mojo IPC.

BUG=578206

Review-Url: https://codereview.chromium.org/1939133002
Cr-Commit-Position: refs/heads/master@{#398107}

BUG=617740
TBR=miu@chromium.org,mcasas@chromium.org

Review URL: https://codereview.chromium.org/2040963006 .

Cr-Commit-Position: refs/heads/master@{#398106}

This will allow it to be used in status tray initialization code. In particular:
* It can wrap actions handled by ShelfWidget and ShelfLayoutManager
(e.g. GetAutoHideState)
* It can have observers similar to ShelfLayoutManagerObserver
(OnAutoHideStateChanged)

It's also more similar to how ash::mus::RootWindowController owns WmShelfMus.

BUG=615155
TEST=ash_unittests

Review-Url: https://codereview.chromium.org/2041583004
Cr-Commit-Position: refs/heads/master@{#398105}

R=pfeldman@chromium.org

Review-Url: https://codereview.chromium.org/2044563002
Cr-Commit-Position: refs/heads/master@{#398104}

BUG=
TEST=gpu bots
TBR=kbr@chromium.org
NOTRY=true
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2044593002
Cr-Commit-Position: refs/heads/master@{#398103}

BUG=617055

https://codereview.chromium.org/1819753003/ accidentally removed
UNDERLINE style support on Linux. This CL fixes the issue.

Review-Url: https://codereview.chromium.org/2031223003
Cr-Commit-Position: refs/heads/master@{#398102}

VibrationTest.CancelVibrationFromMainFrameWhenMainFrameIsReloaded

BUG=617727
TBR=oshima@chromium.org

Review URL: https://codereview.chromium.org/2047503002 .

Cr-Commit-Position: refs/heads/master@{#398101}

Right now, we do a layer tree walk for iteration over all
layers on impl-side (LayerListIterator). Once we start
pushing layer list instead of layer tree during
commit/activation, we will use layer_list instead(layers
will be added to layer_list in stacking  order during
commit/activation). A lot of tests build layer
tree on the impl-side and don't go through
commit/activation. So, we need to explicitly build the
layer_list for these tests.

BUG=617366
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2032303004
Cr-Commit-Position: refs/heads/master@{#398100}

MessageLoop::PostTask/PostDelayedTask/DeleteSoon/ReleaseSoon
are deprecated. This CL makes the following replacements to
remove some uses of these methods:

"MessageLoop(ForUI|ForIO)::current()->PostTask" ->
  "ThreadTaskRunnerHandle::Get()->PostTask"
"MessageLoop(ForUI|ForIO)::current()->PostDelayedTask" ->
  "ThreadTaskRunnerHandle::Get()->PostDelayedTask"
"MessageLoop(ForUI|ForIO)::current()->DeleteSoon" ->
  "ThreadTaskRunnerHandle::Get()->DeleteSoon"
"MessageLoop(ForUI|ForIO)::current()->ReleaseSoon" ->
  "ThreadTaskRunnerHandle::Get()->ReleaseSoon"

In files where these replacements are made, it adds these includes:
  #include "base/location.h"
  #include "base/single_thread_task_runner.h"
  #include "base/threading/thread_task_runner_handle.h"

And removes this include if it is no longer required:
  #include "base/message_loop/message_loop.h"

Why ThreadTaskRunnerHandle::Get() instead of
MessageLoop::current()->task_runner()?
 - The two are equivalent on threads that run a MessageLoop.
 - MessageLoop::current() doesn't work in base/task_scheduler
   because the scheduler's thread don't run MessageLoops.
   This CL will therefore facilitate the migration of browser
   threads to base/task_scheduler.

Steps to generate this patch:
1. Run message_loop_cleanup.py (see code on the bug).
2. Run tools/sort-headers.py on modified files.
3. Run git cl format.

BUG=616447
R=piman@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2035943002
Cr-Commit-Position: refs/heads/master@{#398099}

Rename it to purgeActiveNetworkList which better reflects its actual
function.  It only purges the list of inactive networks, and does
not add to the list.

R=xunjieli

Review-Url: https://codereview.chromium.org/1967373003
Cr-Commit-Position: refs/heads/master@{#398098}

This CL is a strength of https://codereview.chromium.org/1952853005/.

BUG=607695

Review-Url: https://codereview.chromium.org/2032043002
Cr-Commit-Position: refs/heads/master@{#398097}

Revert of Re-enable WebGL Image Chromium. (patchset #3 id:40001 of https://codereview.chromium.org/2025973002/ )

Reason for revert:
I'm observing a behavior difference between the Image CHROMIUM and non-Image CHROMIUM path. Turning off Image CHROMIUM while I investigate.
https://bugs.chromium.org/p/chromium/issues/detail?id=617249#c5

Original issue's description:
> Re-enable WebGL Image Chromium.
>
> This CL makes DrawingBuffer use the newly added DescheduleUntilFinishedCHROMIUM,
> and turns on IOSurface backed WebGL by default.
>
> BUG=581777
>
> Committed: https://crrev.com/801f15833c140f120a2f5baed88645cb0619ab86
> Cr-Commit-Position: refs/heads/master@{#397603}

TBR=kbr@chromium.org,avi@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=581777

Review-Url: https://codereview.chromium.org/2041053002
Cr-Commit-Position: refs/heads/master@{#398096}

It's temporarily plumbed on PaintInvalidationState to let it work for spv2.
Will gradually switch to new code, using the paint property data collected
by PaintPropertyTreeBuilder.

Enable SlimmingPaintInvalidation by default when spv2 is enabled.

BUG=510908

Review-Url: https://codereview.chromium.org/2033183002
Cr-Commit-Position: refs/heads/master@{#398095}

This should be a behavior no-op. The nontrivial "is enabled" and "execute"
commands are now split into helper functions using a consistent style. This
helps make the multi-hundred-line-long switch statements more manageable.

Review-Url: https://codereview.chromium.org/2035033003
Cr-Commit-Position: refs/heads/master@{#398094}

It seems some implementations thow an undocumented exception
from MediaDrm.closeSession(). This CL catches and ignores all
of them.

BUG=611865

Review-Url: https://codereview.chromium.org/2038193003
Cr-Commit-Position: refs/heads/master@{#398093}

Aggressive inlining causes -Wstrict-overflow to be triggered.

BUG=616957
BUG=internal b/29059135

Review-Url: https://codereview.chromium.org/2036613002
Cr-Commit-Position: refs/heads/master@{#398092}

R=sky@chromium.org

Review-Url: https://codereview.chromium.org/2038143003
Cr-Commit-Position: refs/heads/master@{#398091}

Fix off-by-one error in https://crrev.com/385513

BUG=617553

Review-Url: https://codereview.chromium.org/2040963002
Cr-Commit-Position: refs/heads/master@{#398090}

This CL fixes an issue with the scroll to section not finding its host
element. A unit test has also been added to detect the issue.

BUG=616186
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2022893003
Cr-Commit-Position: refs/heads/master@{#398089}

MessageLoop::PostTask/PostDelayedTask/DeleteSoon/ReleaseSoon
are deprecated. This CL makes the following replacements to
remove some uses of these methods:

"MessageLoop(ForUI|ForIO)::current()->PostTask" ->
  "ThreadTaskRunnerHandle::Get()->PostTask"
"MessageLoop(ForUI|ForIO)::current()->PostDelayedTask" ->
  "ThreadTaskRunnerHandle::Get()->PostDelayedTask"
"MessageLoop(ForUI|ForIO)::current()->DeleteSoon" ->
  "ThreadTaskRunnerHandle::Get()->DeleteSoon"
"MessageLoop(ForUI|ForIO)::current()->ReleaseSoon" ->
  "ThreadTaskRunnerHandle::Get()->ReleaseSoon"

In files where these replacements are made, it adds these includes:
  #include "base/location.h"
  #include "base/single_thread_task_runner.h"
  #include "base/threading/thread_task_runner_handle.h"

And removes this include if it is no longer required:
  #include "base/message_loop/message_loop.h"

Why ThreadTaskRunnerHandle::Get() instead of
MessageLoop::current()->task_runner()?
 - The two are equivalent on threads that run a MessageLoop.
 - MessageLoop::current() doesn't work in base/task_scheduler
   because the scheduler's thread don't run MessageLoops.
   This CL will therefore facilitate the migration of browser
   threads to base/task_scheduler.

Steps to generate this patch:
1. Run message_loop_cleanup.py (see code on the bug).
2. Run tools/sort-headers.py on modified files.
3. Run git cl format.

BUG=616447
R=reillyg@chromium.org

Review-Url: https://codereview.chromium.org/2036863002
Cr-Commit-Position: refs/heads/master@{#398088}

Many executables are missing embedded manifest files when built with gn.
This causes OS compatibility information to be omitted which can lead
to strange behavior. This adds manifests to two executables.

TBR=reed@google.com
BUG=602505

Review-Url: https://codereview.chromium.org/2021113003
Cr-Commit-Position: refs/heads/master@{#398087}

TBR=dgozman

Review-Url: https://codereview.chromium.org/2038363003
Cr-Commit-Position: refs/heads/master@{#398086}

In some situations the same JniClient will be used for multiple connections
where ConnectToHost()->DisconnectFromHost()->ConnectToHost() will be called.

In ConnectToHost() we DCHECK !secret_fetcher_ but don't release it in
DisconnectFromHost(), which fails the DCHECK.

This CL solves this problem by resetting |secret_fetcher_| in
DisconnectFromHost(). However, we still need to investigate why JniClient
is being used for multiple connections.

BUG=617471

Review-Url: https://codereview.chromium.org/2046663002
Cr-Commit-Position: refs/heads/master@{#398085}

Revert of In official builds, let CHECK(false) crash instead of calling BreakDebugger. (patchset #2 id:20001 of https://codereview.chromium.org/1982123002/ )

Reason for revert:
Unfortunately crrev.com/1982123002 causes loss of
crash reports on Android arm64 (and supposedly also CrOS).
This is because __builtin_trap() raises a SIGILL on x86 and
arm but SIGTRAP on arm64. Breakpad does not handle SIGTRAP (yet).
Temporarily reverting this CL until SIGTRAP support for breakpad lands.

BUG=599867,614865

Original issue's description:
> In official builds, let CHECK(false) crash instead of calling BreakDebugger.
>
> This should save some binary size and make things a bit faster, without ill
> effects.
>
> See bug comment 15, and brettw's and my comments on
> "[blink-dev] Update of wtf/Assertions.h, and ASSERT macros deprecation"
>
> BUG=599867
>
> Committed: https://crrev.com/481a8ec8b24df24795c63fd4ec26f3670d516db8
> Cr-Commit-Position: refs/heads/master@{#394035}

TBR=danakj@chromium.org,thakis@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=599867

Review-Url: https://codereview.chromium.org/2046593002
Cr-Commit-Position: refs/heads/master@{#398084}

Since AudioCodecBridge::ConfigureAndStart creates AudioTrack
instance with config parameters, we need to initialize the
output parameters with the same values before we get
OnOutputFormatChanged().

Without this step the some changes between config and actual
parameters will be undetected, for instance before this change
(1) config_num_channels = 2, output_num_channels = 2
      old output value was 0, unnecessary AudioTrack recreation
(2) config_num_channels = 1, output_num_channels = 2
      old output value was 2, no change detected here but
      AudioTrack was created with num_channels = 1

BUG=none

Review-Url: https://codereview.chromium.org/2042563002
Cr-Commit-Position: refs/heads/master@{#398083}

MessageLoop::PostTask/PostDelayedTask/DeleteSoon/ReleaseSoon
are deprecated. This CL makes the following replacements to
remove some uses of these methods:

"MessageLoop(ForUI|ForIO)::current()->PostTask" ->
  "ThreadTaskRunnerHandle::Get()->PostTask"
"MessageLoop(ForUI|ForIO)::current()->PostDelayedTask" ->
  "ThreadTaskRunnerHandle::Get()->PostDelayedTask"
"MessageLoop(ForUI|ForIO)::current()->DeleteSoon" ->
  "ThreadTaskRunnerHandle::Get()->DeleteSoon"
"MessageLoop(ForUI|ForIO)::current()->ReleaseSoon" ->
  "ThreadTaskRunnerHandle::Get()->ReleaseSoon"

In files where these replacements are made, it adds these includes:
  #include "base/location.h"
  #include "base/single_thread_task_runner.h"
  #include "base/threading/thread_task_runner_handle.h"

And removes this include if it is no longer required:
  #include "base/message_loop/message_loop.h"

Why ThreadTaskRunnerHandle::Get() instead of
MessageLoop::current()->task_runner()?
 - The two are equivalent on threads that run a MessageLoop.
 - MessageLoop::current() doesn't work in base/task_scheduler
   because the scheduler's thread don't run MessageLoops.
   This CL will therefore facilitate the migration of browser
   threads to base/task_scheduler.

Steps to generate this patch:
1. Run message_loop_cleanup.py (see code on the bug).
2. Run tools/sort-headers.py on modified files.
3. Run git cl format.

BUG=616447
R=maxbogue@chromium.org

Review-Url: https://codereview.chromium.org/2033933002
Cr-Commit-Position: refs/heads/master@{#398082}

This was an error in the refactoring at https://codereview.chromium.org/1323313004.

BUG=615056

Review-Url: https://codereview.chromium.org/2042623002
Cr-Commit-Position: refs/heads/master@{#398081}