GitLab

BUG=

Review URL: https://codereview.chromium.org/872883002

Cr-Commit-Position: refs/heads/master@{#313106}

Make MenuButton track its desried state while it's pressed so that, upon
release, it returns to the proper state (instead of assuming STATE_NORMAL).

BUG=431481

Review URL: https://codereview.chromium.org/873513002

Cr-Commit-Position: refs/heads/master@{#313105}

BUG=none
R=dcheng@chromium.org

Review URL: https://codereview.chromium.org/875133002

Cr-Commit-Position: refs/heads/master@{#313104}

On some platforms, notably the iOS simulator, VideoToolbox compression
sessions vend 4:2:2 pixel buffers by default. This is not supported by
the VideoFrame-CVPixelBuffer integration code.

This patch forces VideoToolbox to vend I420 or NV12 buffers. For
encoders that natively support those formats, this effectively changes
nothing. For encoders that do not, VideoToolbox will convert submitted
frames to whatever format the encoder wants.

In practice, this is a defensive patch that also allows testing iOS cast
streaming on the iOS simulator.

BUG=450804
R=miu, hclam

Review URL: https://codereview.chromium.org/859303004

Cr-Commit-Position: refs/heads/master@{#313103}

Before this change, when there were a lot of font fallbacks happening on
the web site, the fallback font was mmaped multiple times, reaching up to
200 times in the TC url: http://jsfiddle.net/p5pe81vs/, leading to OOMs
and crashes for renderer process.

This happens after the change introduced in
https://codereview.chromium.org/307243002

This CL keeps track of the mmaps for each font ID to avoid any further
unnecessary IPC requests and mmaps for future requests of the same font
ID that would result in new FD.

BUG=430021

NOPRESUBMIT=true
brettw indicates this use of ScopedAllowIO is acceptable.
Previous code eluded IO checks, this change makes the IO use find-able.

Review URL: https://codereview.chromium.org/697383002

Cr-Commit-Position: refs/heads/master@{#313102}

This is dependent on Shill change:
https://chromium-review.googlesource.com/242491
(This change won't work without the Shill change, but it also won't make
anything any more broken than it already is).

BUG=449273

Review URL: https://codereview.chromium.org/867043002

Cr-Commit-Position: refs/heads/master@{#313101}

The target was renamed in GYP a while back
and in https://code.google.com/p/webrtc/source/detail?r=8117
for GN. This is the last reference left using the
'webrtc_base' target name.

TBR=tommi@chromium.org

Review URL: https://codereview.chromium.org/868573003

Cr-Commit-Position: refs/heads/master@{#313100}

This adds a new process mitigation policy to harden the current process
token's integrity level policy. What this actually means is the token's
IL policy in its SACL is modified to add no-read-up and no-execute-up
which is not the default. This prevents a lower privilege process from
opening the token object with rights such as duplicate and impersonation
which could be used to circumvent sandbox restrictions and elevate
privileges. While the policy is only enabled on the browser process by
making it a general mitigation policy it could be applied to all process
levels such as the GPU process to provide a similar effect.

BUG=440692

Review URL: https://codereview.chromium.org/810083002

Cr-Commit-Position: refs/heads/master@{#313099}

Fix timeout check: If _expect_timeout flag is set, and timeout does not occur, then raise an exception.

Add new test for safebrowsing for desktop: Confirm that safebrowsing is turned off on server when ChromeProxy header identifies request as originating from desktop platforms with c=<clienttype>.

Fix safebrowsing test for mobile: Remove checks for safebrowsing response headers since it is not visible to telemetry tests.

BUG=434769

Review URL: https://codereview.chromium.org/820093002

Cr-Commit-Position: refs/heads/master@{#313098}

BUG=417463
TBR=gwilson@chromium.org

Review URL: https://codereview.chromium.org/878573005

Cr-Commit-Position: refs/heads/master@{#313097}

Instead of going through the layer pointer again.

Review URL: https://codereview.chromium.org/872323003

Cr-Commit-Position: refs/heads/master@{#313096}

Also cleanup some unneeded setting of the kUseGpuInTests
command line flag.

TESTED=Successful run using:
out/Release/browser_tests --gtest_filter=WebRtcSimulcastBrowserTest.TestVgaReturnsTwoSimulcastStreams

BUG=

Review URL: https://codereview.chromium.org/874993002

Cr-Commit-Position: refs/heads/master@{#313095}

Temporary disable VP8 HW video decoding on Exynos and MediaTek devices while HW decoder video freezes and distortions are investigated.

BUG=446974, https://code.google.com/p/webrtc/issues/detail?id=4056

Review URL: https://codereview.chromium.org/866923003

Cr-Commit-Position: refs/heads/master@{#313094}

This patch adds frame timing request class, which contains a rect and
an id for that rect. Furthermore, it adds plumbing so that the requests
get propagated from the original Layer into both pending and active
LayerImpls. Verified using tracing that the requests appear correctly.

R=danakj, michaelblain@chromium.org
BUG=441555

Review URL: https://codereview.chromium.org/834343004

Cr-Commit-Position: refs/heads/master@{#313093}

Symbols used in the unittests need to be exported otherwise they
can't be referenced at link time.

BUG=none
TBR=kenrb@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/876753002

Cr-Commit-Position: refs/heads/master@{#313092}

This fixes warnings that appear when moving this code into
components/nacl/.  (The Chromium style checker is disabled for code
under ppapi/.)

Fix warnings about "override".

Fix warning about NaClSubprocess:
"[chromium-style] Complex constructor has an inlined body".

BUG=239656
TEST=none

Review URL: https://codereview.chromium.org/868273002

Cr-Commit-Position: refs/heads/master@{#313091}

BUG=452077, 452071
TBR=thestig@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/873343002

Cr-Commit-Position: refs/heads/master@{#313090}

Looks like this test has failed 41 of the last 200 runs.

BUG=451362
TBR=dtseng

Review URL: https://codereview.chromium.org/879623002

Cr-Commit-Position: refs/heads/master@{#313089}

Disabling FrameTreeBrowserTest.NavigateWithLeftoverFrames and
RenderFrameHostManagerTest.RestoreFileAccessForHistoryNavigation as
they've failed roughly 31 of the last 200 runs on Mac 10.9 bot.

BUG=452018
R=jam

Review URL: https://codereview.chromium.org/877693003

Cr-Commit-Position: refs/heads/master@{#313088}

BUG=391005

Review URL: https://codereview.chromium.org/854053003

Cr-Commit-Position: refs/heads/master@{#313087}

Previously only disabled on Win.

BUG=396393, 396386
TBR=jamesr@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/880593002

Cr-Commit-Position: refs/heads/master@{#313086}

A frame is considered focused if its associated RenderWidgetHost is
focused and it is the focused frame inside its frame tree.

BUG=450634

Review URL: https://codereview.chromium.org/860393004

Cr-Commit-Position: refs/heads/master@{#313085}

BUG=

Review URL: https://codereview.chromium.org/864943002

Cr-Commit-Position: refs/heads/master@{#313084}

Using this we will be able to write:

  with logging_utils.SuppressLogging():
    # all but CRITICAL logging messages are suppressed
    logging.info('just doing some thing') # not shown
    logging.critical('something really bad happened') # still shown

BUG=

Review URL: https://codereview.chromium.org/875083002

Cr-Commit-Position: refs/heads/master@{#313083}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/dc0f408..1d124c3

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=fmalita@google.com

Review URL: https://codereview.chromium.org/877763002

Cr-Commit-Position: refs/heads/master@{#313082}

Remove unused QuicDecrypter::Decrypt method and implementations.

Merge internal change: 84548556
https://codereview.chromium.org/868953002/

Changed verify_details_ check to verify_details_.get() to keep code in
sync with internal source.

Merge internal change: 84442484
https://codereview.chromium.org/872483002/

Removing an obselete TOOD. It is obselte becasue FrameOverlapsBufferedData
does this.

Merge internal change: 84372263
https://codereview.chromium.org/871733002/

Replace the map in QuicAckNotifier with a counter.
No functionality change.

This reduces memory and CPU usage of the ack notifier.

Merge internal change: 84345868
https://codereview.chromium.org/867033002/

Change some of QUIC's AckNotifier datastructures from maps to hashmaps
and sets to lists.  No behavior change.

This should reduce CPU consumption substantially, particularly on
internal servers.

Merge internal change: 84156430
https://codereview.chromium.org/870733002/

Add a new RTO connection option to QUIC.  Flag protected behind the
existing flag FLAGS_quic_use_new_rto.

This new RTO connection option uses loss detection to reduce the
congestion window after an RTO, instead of always reducing the
CWND to 2.

Merge internal change: 84036848
https://codereview.chromium.org/824693007/

QUIC - sync'ing with internal source tree changes.

Minor change to keep the code similar to chromium and internal tree.

Merge internal change: 83993217
https://codereview.chromium.org/870723002/

Fix a bug in QUIC's RTO.  Flag protected by FLAGS_quic_use_new_rto.

Ensures a beta based loss reduction is not triggered directly before
OnRetransmissionTimeout when recovering from RTO.

Merge internal change: 83986840
https://codereview.chromium.org/868813003/

R=rch@chromium.org

Review URL: https://codereview.chromium.org/868993002

Cr-Commit-Position: refs/heads/master@{#313081}

After discussion with Annie/Dave/Fadi/Kari and myself, seems like we settled on not exposing an arbitrary # of new command lines. Rather, there'd be an optional param to rerun with extra tracing categories enabled. The benchmark would specify that there's a debug option available, and has a way of customizing the exact categories it needs.

Example of v8 benchmark modified:

class V8GarbageCollectionCases(benchmark.Benchmark):
  """Measure V8 metrics on the garbage collection cases."""
  def CreateTimelineBasedMeasurementOptions(self):
    # TODO(ernstm): Remove v8-overhead when benchmark relevant v8 events become
    # available in the 'benchmark' category.
    # This can theoretically be handled now by the "default" override
    return timeline_based_measurement.Options()

  @classmethod
  def HasBenchmarkTraceRerunDebugOption(cls):
    return True

  def SetupBenchmarkDefaultTraceRerunOptions(self, tbm_options):
    tbm_options.ExtendTraceCategoryFilters(['v8'])

  def SetupBenchmarkDebugTraceRerunOptions(self, tbm_options):
    tbm_options.ExtendTraceCategoryFilters(['*'])

BUG=

Review URL: https://codereview.chromium.org/840043004

Cr-Commit-Position: refs/heads/master@{#313080}

The Finch experiments ReplaceAECMWithAEC and UseDelayAgnosticAEC make appropriate changes to webrtc::AudioProcessing at create time. If any of these experiments are enabled by default using a different experiment name (which it should have) the desired config change is not made.

BUG=368175,450193

Review URL: https://codereview.chromium.org/879523003

Cr-Commit-Position: refs/heads/master@{#313079}

Change OK to NO_ERROR in enum ParserError for convergence with server code.

BUG=345769

Review URL: https://codereview.chromium.org/867273002

Cr-Commit-Position: refs/heads/master@{#313078}

BUG=None
TEST=components_unittests
R=blundell@chromium.org

Review URL: https://codereview.chromium.org/873083002

Cr-Commit-Position: refs/heads/master@{#313077}

Revert of Revert of Add support for deleting non preceeding surrounding text in chrome.input.ime.deleteSurroundingText (patchset #1 id:1 of https://codereview.chromium.org/821233003/)

Reason for revert:
The regression is fixed in the extension code. It should be safe to land this again.

Original issue's description:
> Revert of Add support for deleting non preceeding surrounding text in chrome.input.ime.deleteSurroundingText (patchset #1 id:1 of https://codereview.chromium.org/851333002/)
>
> Reason for revert:
> This cl caused regression that the backspace-to-decommit feature for both VK and physical keyboard autocorrect.
>
> Original issue's description:
> > Add support for deleting non preceeding surrounding text in chrome.input.ime.deleteSurroundingText
> >
> > Previously, only text before cursor will be removed regardless the value of
> > offset. This CL adds support for deleting text after cursor. We want to this
> > feature in order to implement "set existing word to composition mode" feature
> > when cursor is moved inside an existing word. We want to be able to remove the
> > parts of the existing word before cursor and after cursor first and then call
> > setComposition to set the word to composition mode.
> >
> > Note: this API tries to comform the API spec of ibus delete_surrounding_text
> > here: ibus.googlecode.com/svn/docs/ibus-1.5/IBusInputContext.html#IBusInputContext-delete-surrounding-text
> > A noticible difference is a positive offset value in this API does not take effect.
> >
> > BUG=446249
> >
> > Committed: https://crrev.com/756820cb2c42a7b302a16d24909d820ee18dad0e
> > Cr-Commit-Position: refs/heads/master@{#312113}
>
> TBR=nona@chromium.org,bshe@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=446249
>
> Committed: https://crrev.com/7f17a7758881aa33e8790494b170962bc37e05d8
> Cr-Commit-Position: refs/heads/master@{#312304}

TBR=nona@chromium.org,shuchen@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=446249

Review URL: https://codereview.chromium.org/868663005

Cr-Commit-Position: refs/heads/master@{#313076}

Cr-Commit-Position: refs/heads/master@{#313075}

This fixes the GN build on Android after https://codereview.chromium.org/846063002.

(The GYP build didn't break because content/browser/compositor/ is completely excluded there; see https://code.google.com/p/chromium/codesearch#chromium/src/content/content_tests.gypi&sq=package:chromium&&type=cs&l=1099)

TBR=bauerb@chromium.org

Review URL: https://codereview.chromium.org/879543002

Cr-Commit-Position: refs/heads/master@{#313074}

BUG=450828

Review URL: https://codereview.chromium.org/866763002

Cr-Commit-Position: refs/heads/master@{#313073}

BUG=450589
R=mkwst@chromium.org,jkarlin@chromium.org

Review URL: https://codereview.chromium.org/862053002

Cr-Commit-Position: refs/heads/master@{#313072}

This CL updates content_shell to a recent move to the RenderTreeAsText
to be LayoutTreeAsText.

BUG=450612

Review URL: https://codereview.chromium.org/872173002

Cr-Commit-Position: refs/heads/master@{#313071}

BUG=452002, 451999
TBR=thestig@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/878603002

Cr-Commit-Position: refs/heads/master@{#313070}

This patch adds two variants for postTask and postDelayedTask which
take the original posting location as a parameter. This mirrors the
similar task posting interface of base::TaskRunner and makes it
possible to trace where tasks are being posted from.

BUG=450977

Review URL: https://codereview.chromium.org/869573005

Cr-Commit-Position: refs/heads/master@{#313069}

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/872263003

Cr-Commit-Position: refs/heads/master@{#313068}

Revert of Send Windows accessibility events based on tree updates. (patchset #9 id:160001 of https://codereview.chromium.org/848653002/)

Reason for revert:
DumpAccessibilityEventsTest.AccessibilityEventsTextChanged failing frequently on Windows bots.  Fails most of the time on Win8 Aura.

Original issue's description:
> Send Windows accessibility events based on tree updates.
>
> The idea of this change is to fire Win AX events
> based on the AX tree changing, rather than based
> on Blink firing the right event and mapping it to a
> Win event.
>
> Store the Win-specific AX attributes (ia role,
> ia state, name, value, etc.) in a struct, and when a
> node is updated, compare the old value of each attribute
> to the new value and fire an appropriate event for each
> one (name changed, state changed, etc.).
>
> Handle hypertext_ similarly, and properly diff the old and new hypertext in get_oldText and get_newText.
>
> This enables all of the "event" tests that were
> previously added to pass now, and it makes live regions
> work correctly in NVDA and JAWS.
>
> BUG=447962
>
> Committed: https://crrev.com/eb691a960bef3c2aefa38627baa7cbdde480b81e
> Cr-Commit-Position: refs/heads/master@{#313052}

TBR=dtseng@chromium.org,aboxhall@chromium.org,dmazzoni@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=447962

Review URL: https://codereview.chromium.org/880523002

Cr-Commit-Position: refs/heads/master@{#313067}