- 17 Apr, 2018 40 commits
-
-
Henrik Boström authored
WebRtcMediaStreamTrackAdapterMapStressTest added due to https://crbug.com/813574. This continuously creates and destroys local and remote track adapters concurrently in an attempt to cause a deadlock if possible (hopefully not). This also removes some invalid thread checks at the destructor of ~WebRtcMediaStreamTrackAdapter and ~WebRtcMediaStreamAdapterMap. The first of which made the stress test flaky (https://crbug.com/826365). The adapter's DCHECK was invalid because the remote audio track's Dispose (which properly DCHECKs that it is invoked on the main thread) can jump to the signaling thread and back with a reference to the adapter. It is possible for the signaling thread's task to be the last reference to the adapter. Similarly, WebRtcMediaStreamAdapterMap is reference counted and tasks referencing on different threads could make which thread references it last racy. We don't care which thread was the last reference as long as it is empty (which it is if and only if all adapters have been destroyed on the appropriate threads). Bug: 827450 Change-Id: I5f819948fc2148e810f343e027fa8011b03d2335 Reviewed-on: https://chromium-review.googlesource.com/983553Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#551413}
-
Elly Fong-Jones authored
HungRendererController autoreleases itself, which doesn't work well when it doesn't actually hold a reference to the containing window (which it doesn't in MacViews builds). This fixes the HungRendererController interactive UI test. Bug: 823517 Change-Id: I5fc14faa8eeaba7b20f5e922a43d4817ca2c810a Reviewed-on: https://chromium-review.googlesource.com/1015261Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#551412}
-
Qiang Xu authored
changes: To serve decoding icon for app shortcut plumbed from android, this class shouldn't be scoped to app_list namespace. Bug: 803291 Test: compiles & covered by tests Change-Id: Ia7c8e69a69a610769ae3e049921205200d2c577e Reviewed-on: https://chromium-review.googlesource.com/1014567Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Qiang Xu <warx@google.com> Cr-Commit-Position: refs/heads/master@{#551411}
-
Elly Fong-Jones authored
Accept() can be called more than once on the same MenuController, via context menus; in this situation, it's important to clear the animation so that input events get handled after the animation completes. Bug: 833048 Change-Id: Id3ac92ce91e78b57f2120d4527e35e597ea03067 Reviewed-on: https://chromium-review.googlesource.com/1012876Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#551410}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 0cd1c432. With Chromium commits locally applied on WPT: 303956b6 "Enable WPT tests for the Generic Sensor classes" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/15712 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: I2f718a4bdc8986b13086c22436ff18a6f374fa15 Reviewed-on: https://chromium-review.googlesource.com/1015320 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#551409}
-
Xiaocheng Hu authored
As a half-baked utility function, ComputeInlineBoxPosition() used to return null for positions after linebreak. Some callers have ad hoc hacks to fix up such null returns. r547639 added such a fixup in LocalCaretRectOfPosition(). This patch merges the fixup into ComputeInlineBoxPosition(), since LocalCaretRectOfPosition() is supposed to be a wrapper of CIBP(). For changes in SelectionModifierCharacter: the class has code handling positions after linebreaks, but misses the case of '\n' in 'white-space: pre' style, and handles the case by other fixup path. With the merge, we no longer hit the fixup path, and have to fix the linebreak handling in it. Bug: 812535 Change-Id: I9308dcd2bd911b63b0d2268a2db7a0cb94e63d4c Reviewed-on: https://chromium-review.googlesource.com/1014606 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#551408}
-
Mostyn Bramley-Moore authored
CL https://chromium-review.googlesource.com/c/chromium/src/+/1013118 added a HoldRefCallback function to print_job_worker.cc which conflicts with an identically named function in print_job.cc in jumbo builds. Let's rename this one. Change-Id: I41d6c064c968bd72c736d648439a372cc4ca64a1 Reviewed-on: https://chromium-review.googlesource.com/1013495Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com> Cr-Commit-Position: refs/heads/master@{#551407}
-
Miguel Casas authored
This reverts commit 51b5b7bc. Reason for revert: This CL landed on master so that it could be cherry-picked on M66 branch, which it did on crrev.com/c/1013755, so it can be reverted now. Original change's description: > kUseMonitorColorSpace: mark DISABLED_BY_DEFAULT > > Mark kUseMonitorColorSpace disabled by default to avoid > the blue-color-looks-purple problems detailed in the bug. > This is just a temporary CL to allow cherry-picking it > into the beta branch. > > TBR=dcastagna@chromium.org > > Bug: 809909 > Change-Id: I35bb8cc48c26091cb1752d3d7709a48d23fb4c6e > Reviewed-on: https://chromium-review.googlesource.com/1012305 > Reviewed-by: Miguel Casas <mcasas@chromium.org> > Commit-Queue: Miguel Casas <mcasas@chromium.org> > Cr-Commit-Position: refs/heads/master@{#551152} TBR=mcasas@chromium.org Change-Id: Ie1f6d2eae27e1332374f696a5d17a8dacebac3e6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 809909 Reviewed-on: https://chromium-review.googlesource.com/1015142Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#551406}
-
Vasilii Sukhanov authored
The default search engine is stored in both prefs and TemplateURLService memory. An extension can override the DSE and hide the user prefs. Currently if this is the case, the user prefs are not updated while the user defined search engine can change in TemplateURLService memory. When the DSE extension is disabled the following happens: - Pref value change. - TemplateURLService gets an update with potentially obsolete used-defined DSE values. - kSyncedDefaultSearchProviderGUID is overriden. - As a result of the callback the DSE pref is overwritten too. - TemplateURLService gets an update again and some objects from the first update do not exist anymore. - Crash when the first update is handled. With this CL the user defined DSE prefs are kept up to date with TemplateURLService model in memory. Thus, when TemplateURLService gets an update, all the preferences are correct and the second update won't happen. Bug: 711508 Change-Id: I7e62a95c481e08853b438ccc276db5a61e520811 Reviewed-on: https://chromium-review.googlesource.com/1012116 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#551405}
-
Robert Liao authored
kWebEffectiveConnectionTypeMappingCount is size_t while EFFECTIVE_CONNECTION_TYPE_LAST is from an enum BUG= Change-Id: Ifba51d317a5557a5c83139d4ab0d54065c262d11 Reviewed-on: https://chromium-review.googlesource.com/1013149Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#551404}
-
Miguel Casas-Sanchez authored
This CL s/const/constexpr/ in a few locations in vaapi/ folder. No new code intended, just that substitution. TBR=dcastagna@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I4ec733806feff58a70e8e9ab1c0d7f4565f1733c Reviewed-on: https://chromium-review.googlesource.com/1012949 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#551403}
-
Nick Harper authored
TBR=elawrence@chromium.org Change-Id: I737f0e0d058452bbfef3955e31637bb261bedab4 Reviewed-on: https://chromium-review.googlesource.com/1013685Reviewed-by:
Nick Harper <nharper@chromium.org> Reviewed-by:
Eric Lawrence <elawrence@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#551402}
-
Kai Ninomiya authored
Rebaseline needed for Nexus 9 and NVIDIA Shield bots after https://chromium-review.googlesource.com/c/chromium/src/+/1013279 NOTRY=true TBR=kbr@chromium.org Bug: 833463 Change-Id: I700c61696bf656f12f05f095b78b33131c0ce46f Reviewed-on: https://chromium-review.googlesource.com/1014352 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#551401}
-
Ted Meyer authored
The MP4 spec specifies a matrix stored in both the movie header as well as individual track headers. A final matrix is created by composing and transforming a track header with the movie header. A rotation value can be extracted from this final matrix. This is defined in ISO-14496-12. Bug: 830575 Change-Id: If788e4492a082096b36796a3cbf22105a4d57d3f Reviewed-on: https://chromium-review.googlesource.com/1006177 Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Reviewed-by:
Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#551400}
-
Sergey Ulanov authored
Now MessagePumpFuchsia runs AsyncDispatcher to handle IO events. This will allow to use async lib and libraries that depend on it (such as FIDL) on UI and IO threads. Bug: 831384 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I981d18f9e07d25a5cd4f6006714af91557c0c795 Reviewed-on: https://chromium-review.googlesource.com/985648 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#551399}
-
Qiang Xu authored
changes: Follow up with crrev.com/c/1007891, |braille_display_connected_| is no longer needed by TrayAccessibility. We don't need it for tray visibility either, since when connected it always guaranteed that spoken feedback is enabled, so that spoken feedback enabled state could reflect on behalf of braille display connected state. Bug: 800270 Test: covered by tests Change-Id: I33f0d7b9d53a41e7ff1ed5160207b9d5fb603188 Reviewed-on: https://chromium-review.googlesource.com/1014746 Commit-Queue: Qiang Xu <warx@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#551398}
-
David Reveman authored
We need call wl_client_flush in order to ensure that these events are transmitted to the client. Bug: 824449 Test: gtk-demo --gdk-debug=misc show that output event is received Change-Id: I18e74339b306ed56c85563628fc8b6af7886fd82 Reviewed-on: https://chromium-review.googlesource.com/1014908Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#551397}
-
Penny MacNeil authored
Only mark PEImageSafe instance as NTLoader memory mapped via the new HMODULE constructor. R=grt@chromium.org Bug=769590 Test=chrome_elf_unittests.exe, ThirdParty* Change-Id: I6615a00a04ad667cb4676f21769598aca1f659b5 Reviewed-on: https://chromium-review.googlesource.com/1003143 Commit-Queue: Penny MacNeil <pennymac@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#551396}
-
John Z Wu authored
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I33931655a1e138c1caa96016ca1639f17a0355ad Reviewed-on: https://chromium-review.googlesource.com/1014657 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#551395}
-
Jay Civelli authored
Adding information about redirects when notifying a resource was loaded. Bug: 816684 Change-Id: Ice12ad0bad3e38fae0af60cd932e76a26d827ed4 Reviewed-on: https://chromium-review.googlesource.com/1014664Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Jay Civelli <jcivelli@chromium.org> Cr-Commit-Position: refs/heads/master@{#551394}
-
https://pdfium.googlesource.com/pdfium.git/+log/3900ddb64f30..8cfcb7da3735 $ git log 3900ddb64..8cfcb7da3 --date=short --no-merges --format='%ad %ae %s' 2018-04-17 thestig Fix nits in CPDF_Function and derived classes. 2018-04-17 thestig Implement FORM_GetFocusedText() API. Created with: roll-dep src/third_party/pdfium BUG=chromium:753216 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ia31b03d7e641f3fd8613f5f95370d380cdb8d532 Reviewed-on: https://chromium-review.googlesource.com/1015083 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#551393}
-
Mohamed Amir Yosef authored
This CL adds a simple integration test for downloading a bookmark. It's a simpler version of the existing DownloadDeletedBookmark test. Bug: 516866 Change-Id: I29f54aa2647b6b89e821b7e84faf84292d6f8707 Reviewed-on: https://chromium-review.googlesource.com/1014045 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#551392}
-
Nate Chapin authored
Bug: 829119 Change-Id: Ie393ac9e18bdfcded983d98a16c00254b0954547 Reviewed-on: https://chromium-review.googlesource.com/1000519 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#551391}
-
Joone Hur authored
This CL moves all files in ui/display/manager/chromeos to ui/display/manager and adds build_display_configuration GN arg so that the display configurator could be used in Linux desktop. BUG=733450 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Idd790cfe6f9e5daf6ccad23353573028ebe5d7ee Reviewed-on: https://chromium-review.googlesource.com/969416Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Malay Keshav <malaykeshav@chromium.org> Commit-Queue: Joone Hur <joone.hur@intel.com> Cr-Commit-Position: refs/heads/master@{#551390}
-
Nate Chapin authored
This is necessary to support nested workers. Bug: 829119 Change-Id: Ib48d10fc724477f720e77a15237ab106d8ed86f9 Reviewed-on: https://chromium-review.googlesource.com/1012794Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#551389}
-
kristipark authored
The URL is incorrect due to the welcome page migration (it currently redirects to chrome.com). Also, users have already been through the first run UX, so the welcome page is not really needed. Bug: 824038 Change-Id: I739e920e2fd4f4498226a04e162b29f2ed1011c7 Reviewed-on: https://chromium-review.googlesource.com/1006186 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#551388}
-
Stephen Lanham authored
crrev.com/c/1005506 changed the name of PartitionAllocReturnNullTest. BUG= internal b/78119983 Test: manual Change-Id: I85e8457eeddf563e56a10c02d808ddd336e5a010 Reviewed-on: https://chromium-review.googlesource.com/1015405Reviewed-by:
Stephen Lanham <slan@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Stephen Lanham <slan@chromium.org> Cr-Commit-Position: refs/heads/master@{#551387}
-
Justin Cohen authored
Bug: 819460, 832593 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I6ba2bfc9e22758203b5dc44698e40db5295c79ce Reviewed-on: https://chromium-review.googlesource.com/1005912Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#551386}
-
Shimi Zhang authored
Run testUseWideViewportLayoutWidthNoQuirks() on N 600 times and on O 100 times, then run both tests for another 500 times, didn't see any failure, enable to see how will the flakiness dashboard say. Bug: 797009 Change-Id: If970a068fe6bccc5a9b1d7960fa69ff678260112 Reviewed-on: https://chromium-review.googlesource.com/1014475Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#551385}
-
Nico Weber authored
This reverts commit be8138a4. Reason for revert: broke checkbins on 32-bit, https://crbug.com/833951 Original change's description: > win: Link with lld instead of MSVC's link.exe by default > > lld is LLVM's linker. It produces PE/COFF and PDB files just like > link.exe, but it's significantly faster and it can also handle LLVM's > internal representation, which will enable us to do link-time > optimization and control-flow integraty checks with Clang. > > While lld is much faster at linking, it doesn't support incremental > links, meaning builds that only touch a few files and re-link a large > executable may become slower. > > This is the first attempt at switching everything over, with the > purpose of gathering data and finding unknown unknowns. It's likely > temporary until something breaks. > > is_win_fastlink is implicitly ignored when using lld, as lld without > fastlink is faster than link.exe with it. > > Also switch the CrWinClangLLD bots on chromium.clang to use MSVC's > link.exe to make sure that configuration keeps working. > > Bug: 792131 > Change-Id: I0f115a78c33d69eadbd480f75c2a5d636e86483d > Reviewed-on: https://chromium-review.googlesource.com/983632 > Commit-Queue: Nico Weber <thakis@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#551367} TBR=thakis@chromium.org,hans@chromium.org Change-Id: Ia6060fe909656ce5903cf6906beb8b5e4ef538c7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 792131 Reviewed-on: https://chromium-review.googlesource.com/1015141Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#551384}
-
Jeffrey Kardatzke authored
This adds a small D-Bus service framework to ash and then adds an initial service that has one call "OpenUrl" which will then open a new tab in Chrome with that URL. This is intended to be used by Chrome OS clients that want to open a URL with Chrome; initial usage will be from VMs. Relanding crrev.com/c/998081, fixed missing D-Bus .conf file TBR=stevenjb@chromium.org,dominickn@chromium.org,hashimoto@chromium.org,mkwst@chromium.org Bug: 822496 Bug: 831333 Test: Verified with dbus-send that links open properly Change-Id: I5e6d9c716ef6da88b184e8e05582825d9547946e Reviewed-on: https://chromium-review.googlesource.com/1014424 Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#551383}
-
Alexey Kozyatinskiy authored
This roll includes: - [inspector_protocol] first class citizien .pdl support + migrated cros_protocol.json to .pdl TBR=dgozman@chromium.org,dpranke@chromium.org,pfeldman@chromium.org NOPRESUBMIT=true Bug:none Change-Id: I0fff1582bd41115e2aa348008c7a5d48f5c59a7e Reviewed-on: https://chromium-review.googlesource.com/1014468 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#551382}
-
Malay Keshav authored
std::string is not used correctly with ioctl() and hence fails to get the field info. Replace it with C string. Bug: 827452 Change-Id: Iace6ce24a6405c40a68eeff71c090883b847a46f Component: Event Device Info, phys Reviewed-on: https://chromium-review.googlesource.com/1014409Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/heads/master@{#551381}
-
Tetsui Ohkubo authored
According to UX spec, if a feature pod button is togglable and has a detailed view, the icon click should toggle the feature and the label click should show the detailed view. This CL changes the behavior of Bluetooth feature pod button to follow this rule. UX spec: http://shortn/_U7QSE9nhSk TEST=manual BUG=821671 Change-Id: Ia4158975c6a0d7c409c1bacd58786223eea4567e Reviewed-on: https://chromium-review.googlesource.com/1013130Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#551380}
-
Yuichiro Hanada authored
This CL adds the new mojo API and a method of KeyboardController to request hiding the virtual keyboard if it's shown. The difference between HideKeyboard() and RequestHideKeyboard() is that the request made by RequestHideKeyboard() can be canceled by focusing another text input field. Bug: b:72456023 Change-Id: Ief7e48da3a249825fdddd48bdcb3aa20d379eec6 Reviewed-on: https://chromium-review.googlesource.com/1004881 Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Blake O'Hare <blakeo@chromium.org> Cr-Commit-Position: refs/heads/master@{#551379}
-
Becca Hughes authored
Roll preloaded data to 1.0.3.0 BUG=833861 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I32aff80f3637e7ff2608f155d0e3ebf3182489b9 Reviewed-on: https://chromium-review.googlesource.com/1014719Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#551378}
-
wutao authored
Currently for fullscreen window, Ash lets the browser or apps to process the accelerator first. However, focus_manager handles "alt-tab" as a "Tab" traversal key event. This cl fixes this bug. Bug: 832739 Test: New test FocusManagerTest.IsTabTraversalKeyEvent Change-Id: I6252a5614390223c581d032d39dbad1c84de6b48 Reviewed-on: https://chromium-review.googlesource.com/1014651 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#551377}
-
Lei Zhang authored
Valgrind bots are gone. BUG=605605 Change-Id: Ie722b831d0a6fca8b48620e5a9d993896346cbef Reviewed-on: https://chromium-review.googlesource.com/1014956Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#551376}
-
Yash Malik authored
Injecting HOVER_EXIT is done by the platform if the coordinates for the HOVER_MOVE are out of bounds, so we don't need to inject it ourself. Bug: 819348 Change-Id: I4486f9970fac031373215bdcb7021de6a422da02 Reviewed-on: https://chromium-review.googlesource.com/1014715Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Yash Malik <ymalik@chromium.org> Cr-Commit-Position: refs/heads/master@{#551375}
-
bsheedy authored
Adds an option to the VR bisect script to run in manual mode. This removes the automatic "gclient sync" and waits for user input before building and running the test. This is meant to be used in the rare case that some change in the bisect range breaks gclient sync and requires some DEPS change to fix. This allows the user to manually add in the fix and sync while still allowing the script to handle the building, running, and result retrieval. Change-Id: I7bfd5b7b059dec84b3feefbbc6ada3e01659d30d Reviewed-on: https://chromium-review.googlesource.com/1014460Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#551374}
-