- 22 Jan, 2021 40 commits
-
-
Gustaf Ullberg authored
This change makes sure that the number of output channels of the media stream audio processor is set correctly when using a discrete channel layout as input. This fixes a crash when making calls with audio processing enabled while using a discrete channel layout for input. Bug: 1169678 Change-Id: I68e37e1ecff74e86ec0248838e4c9d3c740547a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643280Reviewed-by:
Henrik Andreasson <henrika@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Gustaf Ullberg <gustaf@chromium.org> Cr-Commit-Position: refs/heads/master@{#846125}
-
Fredrik Söderqvist authored
Said method is only an open-coded version AffineTransform::MapPoint(). Since it only has a single user, fold it into that. Change-Id: I1bac1d612bfbf2910b574735af5e3cebe51466b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643329 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#846124}
-
Wan-Teh Chang authored
This check was added to ImageLoader::ImageNotifyFinished() in https://codereview.chromium.org/2888953004. Add the same check to StyleFetchedImage::ImageNotifyFinished(). Change-Id: Ia9c201c456cdb2e27d8a9abcc9b2dcded0ac8597 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644114Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Wan-Teh Chang <wtc@google.com> Cr-Commit-Position: refs/heads/master@{#846123}
-
Ben Wagner authored
Bug: 1168814, 1169126, 1168720, 688613, 1142877 Change-Id: Ic62edd69cc3c2dc8468dcd9bcbed99a9109daab6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642444 Auto-Submit: Ben Wagner aka dogben <benjaminwagner@google.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Ben Wagner aka dogben <benjaminwagner@google.com> Cr-Commit-Position: refs/heads/master@{#846122}
-
chromium-autoroll authored
Roll ChromeOS Bigcore AFDO profile from 89-4384.0-1610966529-benchmark-89.0.4389.11-r1 to 90-4384.0-1610966178-benchmark-90.0.4393.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-bigcore-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Idd86dd31d1b15bdf0d20f06fe39cc1a54ce1d38b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643788Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#846121}
-
chromium-autoroll authored
Roll ChromeOS Atom AFDO profile from 89-4384.0-1610969724-benchmark-89.0.4389.11-r1 to 90-4384.0-1610968059-benchmark-90.0.4393.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-atom-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ia6a721d21ea3966430b13e3e370a86e1a0248b6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643787Reviewed-by:
-
Sreeja Kamishetty authored
This CL adds a WebContentsObserver consistency check inside WebContentsObserverConsistencyChecker::RenderFrameHostChanged to make sure that for every subframe, WebContentsObserver::RenderFrameCreated is dispatched before WebContentsObserver::RenderFrameHostChanged. Previous CL (https://crrev.com/c/2614467) modified the way the RenderFrameCreated and RenderFrameHostChanged WebContentObserver callbacks were dispatched in the case of sub-frames, ensuring this consistency check. BUG=1097143 Change-Id: I2564fffad342d0ebf4945166b829b1b6e1f57b3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628968 Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#846119}
-
Jiewei Qian authored
This is a reland of be5c5c0f The 2nd reland contains a bad merge, which incorrectly calls profile() method on the destroyed Browser object. This trips ASAN failure. The correct method for AppBrowserControllerBrowserTest.Shutdown is to call on a previously stored / cached profile*. Original change's description: > Reland "Reland "system-web-apps: implements a new LaunchSystemWebAppAsync API"" > > This is a reland of 38aeef20 > > The first reland adds a test for behaviors during browser shutdown, and > doesn't yield consistent result. The second reland removes that test. > > The shutdown test was intended to fix https://crbug.com/1121894, where > we hit CHECK in Browser constructor. The bug was fixed by checking > browser isn't shutting down in LaunchSWAImpl.] > > It's okay to not test shutdown in LaunchSWAAsync (the added test in > first reland), because LaunchSWAAsync doesn't attempt to create browser > windows, and calls methods on objects (Profile, AppService) that are > still valid during Browser shutdown sequence. So the LaunchSWAAsync API > shuoldn't experience similar crashes observed in > https://crbug.com/1121894. > > Original change's description: > > Reland "system-web-apps: implements a new LaunchSystemWebAppAsync API" > > > > This is a reland of 62cb2352 > > > > The original CL fails when AppBrowserControllerBrowserTest.Shutdown > > passed a destroyed to LaunchSWAImpl. The reland removes this DCHECK > > because the use of GetCreationStatusForProfile already makes sure the > > DCHECK is always successful. > > > > Original change's description: > > > system-web-apps: implements a new LaunchSystemWebAppAsync API > > > > > > This CL implements a new LaunchSystemWebAppAsync API, which is for other > > > chrome components to launch a SWA safely. This new API should be used > > > for SWA launches. > > > > > > The new API uses AppService to record metrics, handle disabled apps, > > > etc. > > > > > > The old LaunchSWA is deprecated (its logic now becomes LaunchSWAImpl). > > > > > > LaunchSWAImpl is publicly declared because certain browser tests need to > > > know the browser that hosts the SWA. It shouldn't be used to launch the > > > App (other than LaunchSWA and Web app implementations). Subsequent CLs > > > will attempt to migrate these browsertests to work with the new API. > > > > > > Bug: 1154540 > > > Change-Id: I648a3b0404067ba460f0174e975fae44b3a0001a > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592270 > > > Reviewed-by: James Cook <jamescook@chromium.org> > > > Reviewed-by: Nancy Wang <nancylingwang@chromium.org> > > > Reviewed-by: Scott Violet <sky@chromium.org> > > > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > > > Commit-Queue: Jiewei Qian <qjw@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#843939} > > > > Bug: 1154540 > > Change-Id: Ice207ac03834452223c5bb2ef880c6667e6cb25b > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633485 > > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > > Reviewed-by: Scott Violet <sky@chromium.org> > > Auto-Submit: Jiewei Qian <qjw@chromium.org> > > Commit-Queue: Jiewei Qian <qjw@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#845049} > > Bug: 1154540 > Change-Id: I823b43be08c4fb6aefd53a92442359eee296bab3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641605 > Commit-Queue: Scott Violet <sky@chromium.org> > Auto-Submit: Jiewei Qian <qjw@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#845723} Bug: 1154540 Change-Id: Ia60a84b0c0b96d179854143b2cdacaa98a2bea66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642840 Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Jiewei Qian <qjw@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#846118}
-
Ali Juma authored
CWTChromeDriver contains a partial implementation of the WebDriver protocol for browser automation, used for Web Platform Tests. This CL adds support for a new "chrome_crashtest" command, that can be used for fuzzing. This new command is similar to the existing "url" command, that loads a URL and waits for it to finish loading. However, the new command waits for an additional amount of time (specified as an argument) after page load to catch cases where a test page crashes just after page load is complete rather than during load. This new command also extracts the stderr output of the app process and returns it to the caller. This is needed for fuzzing because ASan crash stacks will be sent to the app process' stderr before the app process is terminated due to a bug found by ASan. Finally, this new command supports "file:///" URLs by serving the given file using an EmbeddedTestServer, since Chrome on iOS does not support directly loading such URLs. This is useful for fuzzing since fuzzing test cases are typically provided as a local HTML file. CWTChromeDriver is not shipped to end users (unlike ChromeDriver on non-iOS platforms), so supporting a non-standard command for test purposes does not create any compatibility issues. Change-Id: I84ad0100e40c12065a18325501d997a5b34220dd Bug: 1158540 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600023Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#846117}
-
Nektarios Paisios authored
TBR=dmazzoni@chromium.org, aleventhal@chromium.org Change-Id: I0bac0ec2870816c0f92aa68e6d10b56a5df748f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643392Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#846116}
-
Matt Jones authored
This patch aligns the directory structure of the bottom sheet widget with others in the browser_ui component. Specificialy, instead of the "android/name" pattern, the sheet now uses "name/android". Bug: 1169164 Change-Id: I74cf28bd59022624610758c41342f217dbac8ec7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643023Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Auto-Submit: Matthew Jones <mdjones@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#846115}
-
Adithya Srinivasan authored
Fixes a couple of instances where portals could get page focus: 1) Committing a pending navigation in an iframe inside a portal could cause the portal's frame tree to receive page focus 2) A predecessor page after activation would still have page focus when orphaned (not inserted into DOM) Bug: 1030838 Change-Id: I671d35fbb9b0041adb2d91082e1e6b1ac7a47a0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563870Reviewed-by:
-
arthursonzogni authored
[previous patch]: https://chromium-review.googlesource.com/c/chromium/src/+/2635142/4 Remove blink's computation of sandbox flags. Instead, let the browser process being in charge of providing this value. The exhaustive list of Frame.CommitNavigation users: 1. The initial empty document. 2. The synchronous navigation to about:blank that happens immediately after creating an initial empty document in <iframe> with no explicit src. 3. Navigations (regular and error documents) 4. Pseudo new document with same properties (XSLT, javascript). 5. WebViewPlugin (placeholder data URL) 6. Printing > (CopySelection) 7. Test. The browser process computes sandbox flags only for (3). The main work for this patch was to provide something for the 6 other cases. Especially tests running without a browser process. Bug:1041376 Change-Id: Ibbf40afe345d67b45615be4efc942069548d96ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450093 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#846113}
-
Eric Seckler authored
crrev.com/c/2633994 introduced a bug which caused some events to be emitted on an incorrect track. It's caused by the incorrect assumption that a constexpr symbol (kDefaultTrack) only receives a single address within a translation unit, even across different inlined functions. This patch fixes this by making kDefaultTrack a const symbol instead. Change-Id: I3f8a1d569d50839bb2188a037f88b9d6d3d7253b Bug: 1168791 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644798 Commit-Queue: Eric Seckler <eseckler@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Auto-Submit: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#846112}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1611294737-a15fe97a1063cd1d1146cd301b05a844b1e4cfe8.profdata to chrome-mac-master-1611316382-256aee3c7474e8e8ef074b7619cf9a4131f41980.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I8f67fb7eac646d8eb5c42715ded45a6d1d19f985 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644841Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0e20ed5f01b3..a3545e46d238 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC snijhara@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: snijhara@google.com Change-Id: Ib8c0b95260774d71f5627753e9ab09cee94fb6bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644839Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#846110}
-
Alex Ilin authored
When a new profile is created through the local profile creation, GenerateNewProfileColorWithGenerator() will try to choose a color with lightness close to the current color mode (either light or dark). Currently, the second and third line in the color picker will be considered in light mode, and only the last line will be considered in dark mode. Bug: 1169223 Change-Id: If3c55831a8d4e69a51353b4e52f931dab9fdc287 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642455Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#846109}
-
Nektarios Paisios authored
TBR=dmazzoni@chromium.org, aleventhal@chromium.org Change-Id: Ief1fff9084e42b284ec733ac344119d326fbe38b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642633Reviewed-by:
-
Pâris MEULEMAN authored
Add test verifying behavior when trying to execute javascript in a paused navigation from an early committed post-crash RFH. bug: 1072817 Change-Id: Ibd6b9c5b6e6484f278dcdc6ecc1ed0cf88780fd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627393 Auto-Submit: Pâris Meuleman <pmeuleman@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Pâris Meuleman <pmeuleman@chromium.org> Cr-Commit-Position: refs/heads/master@{#846107}
-
Ossama Mahmoud authored
Bug: none Change-Id: Ic2e1a8e0eee10c5c4f7f33200247019d427764cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643719 Commit-Queue: Ossama Mahmoud <osamafathy@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#846106}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1611284384-cbab22d10b31440218b066d1280e2c1fdae62cdc.profdata to chrome-win32-master-1611304267-88ef864b2fcc457a2d5ceb59f34a94c5685188fd.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ie280be289a4fecbf27d4c8d152020ea901c382a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643535Reviewed-by:
-
Fredrik Söderqvist authored
SkipOptionalSVGSpaces() returns true if this condition (ptr < end) is true, so we don't need to check it again. Change-Id: I9bfe1b34758419aba95875430bb1cc6099a21320 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642784 Commit-Queue: Stephen Chenney <schenney@chromium.org> Auto-Submit: Fredrik Söderquist <fs@opera.com> Reviewed-by:
-
Fredrik Söderqvist authored
It's never called (there are no attributes of this type). When point syntax is used in attributes (for example for point lists or <animateMotion>) they open-code the parsing. Change-Id: I9c28a3c6a7c5d3b51d2d2df87d6de86b33e63bbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643285 Auto-Submit: Fredrik Söderquist <fs@opera.com> Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1611294737-27b810d0fa6cfabfc1ee245c9b50455ece63f3ea.profdata to chrome-linux-master-1611316382-94c9fd181d84cd42486f5188444029563baefc6b.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ia10c6243dbaf85b2b11e29804fc7ad0894d0b7c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644840Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I2c2459593789e9256025a8183553ba3a86a86b77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644737Reviewed-by:
-
Clemens Arbesser authored
Bug: b/178098376 Change-Id: I2ae2d04a8f5af9d1676b29944b2644d21d127878 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642335Reviewed-by:
Marian Fechete <marianfe@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#846100}
-
Alex Ilin authored
This CL renames "Default" to "Default color" for the default color item in the profile picker. This is more consistent with other color labels as "Custom color", "Warm gray", etc. Updated screenshot: https://storage.cloud.google.com/chromium-translation-screenshots/de2db892dd4af40ffa7a6efe510149423e449f57 Change-Id: Ie509c13bcc4e94b0981e6ee5f258c493ef5480d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643320 Auto-Submit: Alex Ilin <alexilin@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#846099}
-
Rushan Suleymanov authored
This CL implements actual move of parent_id field. This is important for bookmarks data type during the initial merge when it is extensively used. This CL doesn't change the existing behaviour, it just optimizes bookmarks initial merge. Bug: 1168132 Change-Id: I65ebaba306057c608aa2401c112b1f1b22a4c6ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640374Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Rushan Suleymanov <rushans@google.com> Cr-Commit-Position: refs/heads/master@{#846098}
-
Benoit Lize authored
PartitionAlloc's thread cache improves performance (up to ~3% on speedometer 2.0 vs jemalloc) on Android Go, but at a memory cost. Since periodic purge is still disabled, this commit disables the thread cache on these configurations to recover. This CL introduces extended_api.h for PartitionAlloc, which is intended to become the central place to provide finer-grained control when PA-E is enabled, such as adjusting thread cache behavior (size, reclaiming behavior, or disabling it), and other allocator tuning parameters. As such, even if complete thread cache disabling is intended to be temporary, having an extended API is not. Bug: 1167218, 998048 Change-Id: I9c9801e41f1a0ed4dab6b3d96647540356428a50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637640 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#846097}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/e4fd1ba31989..11215febb950 2021-01-22 danilchap@webrtc.org Require scalability mode to initialize av1 encoder. 2021-01-22 webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com Update WebRTC code version (2021-01-22T04:03:26). 2021-01-21 titovartem@webrtc.org Introduce network emulated endpoint optional name for better logging If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I7c70dcb7fa26669d42cd593e8aa88b196c243ec1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643133Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/db383498c5c6..72cd1a5e8953 2021-01-22 cwallez@chromium.org dawn_native: Move beginRenderPass texture usage validation into the encoder 2021-01-22 cwallez@chromium.org Remove QueueWriteBufferTests.ManyWriteBuffer on Intel Vulkan 2021-01-22 cwallez@chromium.org dawn_native: Move pass validation of buffer usages into the encoder. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC sarahmashay@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: chromium:980737 Tbr: sarahmashay@google.com Change-Id: Iac146e6b83e9960fa54c5c1d1c6688a334e1d1c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643128Reviewed-by:
-
Fergus Dall authored
This reverts commit 2d1e6ddf. Reason for revert: Broke tast tests by crashing chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome Original change's description: > Clear the cache in AutomationManagerAura when disabled. > > On the Tast tests which use the Automation features, I'm seeing > sometimes the automation node tree gets empty. During the debugging, > I've noticed that sometimes the automation tree fails to build > the tree updates (happens OnSerializeFailure). > > This can be resolved by clearing the cache when it is disabled > (which happens regularly on tests). > > Bug: 1165292 > Test: on kevin64, run informational Tast tests > AX-Relnotes: n/a > Change-Id: I835e06ca2118ae6c36d6fb8b877fad074bd41fcf > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627715 > Commit-Queue: Jun Mukai <mukai@chromium.org> > Reviewed-by: David Tseng <dtseng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#845868} TBR=mukai@chromium.org,dtseng@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I43a2458db101f777ea81537127db2de2a85ca757 AX-Relnotes: n/a Bug: 1165292, 1169573 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642843 Commit-Queue: Fergus Dall <sidereal@google.com> Reviewed-by:
Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#846094}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/dbb39ce0d2ed..7d6a6f33a540 2021-01-22 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2021-01-22 petermarshall@chromium.org [surveys] Make the survey prompt text injectable by the caller 2021-01-22 sigurds@chromium.org Add presubmit check requiring an associated bug 2021-01-22 jacktfranklin@chromium.org Fix border-top regression on blocked URLs pane If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1112738 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I6a3bb92fa6a5dd875ee5693187a1d955e7bc7ea5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643068Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1611294737-17c8474f67761118ef8f2490ffa8a435d02d7f3f.profdata to chrome-win64-master-1611304267-90669dcf550835de268a2353a6cf5648f5d0af68.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I1192655830492fffd6f8105675ad95b5f7818771 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643131Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/49fd77f3..fbab010f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic89f7c3bb413d25c2a72a2fcdf978be3e394da9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644560Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#846091}
-
Christian Dullweber authored
This reverts commit 8e10fb2a. Reason for revert: Reenable the test to check if failure still exists Original change's description: > [sheriff] Disable SiteDataCountingHelperTest.SameHostDifferentScheme > > TBR=eirage@chromium.org > NOTRY=true > > Bug: 1168198 > Change-Id: I3196ad66bace95157d110f840babd269d394df32 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637963 > Reviewed-by: Xida Chen <xidachen@chromium.org> > Reviewed-by: Ella Ge <eirage@chromium.org> > Commit-Queue: Xida Chen <xidachen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#844891} TBR=xidachen@chromium.org,eirage@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1168198 Change-Id: I67f5a97d8e82513e13025c37639ea3fdeede022b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642630Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#846090}
-
Yunke Zhou authored
Bug: 1157195 Change-Id: Ic4daf299819b3854a7aef924268c8e698271de69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643380 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
-
Omer Katz authored
Initializing a bucket is non-atomic because the hash table is not yet visible to the GC during initialization. When trying to recycle a deleted bucket, the bucket is reinitialized. This introduces data races with concurrent marking. To resolve the data races, we should initialize atomically. For hash table where the empty value is zero, we can atomically memset the bucket to zero. For other cases, atomically initializing is more complicated. Instead, in such cases, we prohibit reusing deleted bucket while marking is in progress. Bug: 1166985 Change-Id: I42d03371388e7cd702d2aec6c5bdfd02e2a38d4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643716 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Aaron Leventhal authored
When an AXInlineTextBox::NextOnLine()/PrevOnLine() is used, the parent of any newly created AXInlineTextBox is not necessarily going to be the same one. Compute the correct parent in all cases. Addresses DCHECKs that are triggered in text-overflow:ellipsis cases. Bug: 1168643 Change-Id: Ib41bc4617bee4761ccad35ad94ab33fb8be4ab43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639167Reviewed-by:
-
Jérôme Lebel authored
Adds signout confirmation dialog for Mice based on this design: https://docs.google.com/presentation/d/1mfVdeJXk2hLXjyzOp9TBIx0E7-7jmuoN1-4oB6dYd5I/edit#slide=id.gaea85d524f_2_0 iPad: https://drive.google.com/file/d/1UAS0L-ANTaIDEN2FFh2mgAiwKe-ksQ5U https://drive.google.com/file/d/1kQJoi6Vqe-xEsbLokmePAlAWU5kNl99T https://drive.google.com/file/d/1DUou8tJ1UR54lQtI2Zzi5smJ3aoUbyXX iPhone: https://drive.google.com/file/d/13TPquf7Z8HbdkCDmQhXnyqwP0VQGxwTp https://drive.google.com/file/d/1UjLwwkEk4RKnkDfX-7BSLmfqo6Lj1Ewd https://drive.google.com/file/d/1aykwVlgT3npD3DQkMCPWJm3hYiMeJfLx Bug: 1166148 Change-Id: Ica58a513ee216d79f4994d155a4941ea5fdbe3d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627401 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#846086}
-
