- 12 Mar, 2018 40 commits
-
-
https://pdfium.googlesource.com/pdfium.git/+log/83a01491dbd9..0c6b98182403 $ git log 83a01491d..0c6b98182 --date=short --no-merges --format='%ad %ae %s' 2018-03-12 rharrison Remove all usages of FXSYS_iswASCIIspace Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I3b6e323d2b7618b9138e4b2eebba39e762aedea9 Reviewed-on: https://chromium-review.googlesource.com/959386 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#542591}
-
Devlin Cronin authored
In manifest v1, page actions had support for different keys, including a list of icons (instead of a single icon), "popup" (vs "default_popup"), "name" (vs "default_title"), "type" (deprecated), and "id" (deprecated). Remove parsing support for the deprecated keys. Update unit tests to manifest v2 where applicable, and remove manifest v1-specific tests. Bug: 816677, 816679 Change-Id: Id4db2558e0f5b9006c89a0f3ef89aed230a7b359 Reviewed-on: https://chromium-review.googlesource.com/953179Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#542590}
-
https://skia.googlesource.com/skia.git/+log/cf81fa995f38..24f25dc8bca7 $ git log cf81fa995..24f25dc8b --date=short --no-merges --format='%ad %ae %s' 2018-03-12 herb Move ComputeAxisAlignmentForHText to Rec. 2018-03-12 reed move blur impl into core 2018-03-12 kjlubick Add oss-fuzz endpoint for PathMeasure 2018-03-12 robertphillips Temporary patch for Mus/Viz 2018-03-12 herb Expose SkGlyphCache's alloc 2018-03-12 angle-skia-autoroll Roll skia/third_party/externals/angle2/ 391bda23b..e98b1b5d4 (4 commits) 2018-03-12 reed fix writeImage when encode step fails, since data is null 2018-03-12 herb Make SubpixelAlignment public 2018-03-12 herb Remove unused SkAutoGlyphCache constructor 2018-03-12 skcms-skia-autoroll Roll skia/third_party/externals/skcms/ e5ac7a7c8..3ca91a31d (1 commit) 2018-03-12 bungeman SkReadBuffer.h shouldn't include itself. 2018-03-12 brianosman Remove SK_SUPPORT_LEGACY_ADOBE_XYZ Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=stephana@chromium.org Change-Id: Ie3388d65099b65f1974c44dbba639992df3977da Reviewed-on: https://chromium-review.googlesource.com/959356Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#542589}
-
Michael Spang authored
Change-Id: Id0c1bf82488905578d0ed1cac0fd498ff118b2c4 Reviewed-on: https://chromium-review.googlesource.com/958230Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#542588}
-
Evan Stade authored
Bug: none Change-Id: Id4c4d26cd02c673b820a4b2cfcdcb226ac1f2759 Reviewed-on: https://chromium-review.googlesource.com/958092Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#542587}
-
Michael Thiessen authored
This reverts commit 2702f2e5. Reason for revert: Making fixing DLAs on P too difficult. Will reland once P issues are fixed. Original change's description: > Reland "VR: Use isInVrSession API to keep Chrome in VR until user has left VR" > > This reverts commit 0e39bd62. > > Original change's description: > > Revert "VR: Use isInVrSession API to keep Chrome in VR until user has left VR" > > > > This reverts commit dc55fd14. > > > > Reason for revert: Suspected to have broken chrome_public_test_vr_apk on main waterfall > > https://ci.chromium.org/buildbot/chromium.android/Marshmallow%20Phone%20Tester%20%28rel%29/?limit=200 > > first failing build contains this cl: > > https://ci.chromium.org/buildbot/chromium.android/Marshmallow%20Phone%20Tester%20%28rel%29/3088 > > > > Original change's description: > > > VR: Use isInVrSession API to keep Chrome in VR until user has left VR > > > > > > This fixes the Daydream Dashboard issues so that if Chrome is simply > > > stopped/started in VR without any intents, Chrome stays in VR. > > > > > > Also makes resuming Chrome from DD home way faster if Chrome was > > > already in VR. > > > > > > Bug: 780887 > > > Change-Id: Iab7f713bfc5b85972f908ea141e3b495297d7286 > > > Reviewed-on: https://chromium-review.googlesource.com/944547 > > > Reviewed-by: Yash Malik <ymalik@chromium.org> > > > Commit-Queue: Michael Thiessen <mthiesse@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#540403} > > > > TBR=mthiesse@chromium.org,ymalik@chromium.org > > > > Change-Id: I7ae67f5d23d816796cc7f567792e181900b3012a > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 780887 > > Reviewed-on: https://chromium-review.googlesource.com/946709 > > Reviewed-by: Benjamin Pastene <bpastene@chromium.org> > > Commit-Queue: Benjamin Pastene <bpastene@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#540588} > > TBR=mthiesse@chromium.org,ymalik@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 780887 > Change-Id: I690474b0dd7b8dff7e7a5b2dbd036b0f97eacb52 > Reviewed-on: https://chromium-review.googlesource.com/949083 > Reviewed-by: Michael Thiessen <mthiesse@chromium.org> > Commit-Queue: Michael Thiessen <mthiesse@chromium.org> > Cr-Commit-Position: refs/heads/master@{#540950} TBR=mthiesse@chromium.org,ymalik@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 780887 Change-Id: If259e45f972b4ccc24e39304ca2e1a683f295059 Reviewed-on: https://chromium-review.googlesource.com/958020 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#542586}
-
Chromium WPT Sync authored
Using wpt-import in Chromium fe2035ca. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/13765 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=foolip No-Export: true Change-Id: I20a325811671c02273b763cc36fa7ae31b49379e Reviewed-on: https://chromium-review.googlesource.com/959146 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#542585}
-
Christopher Cameron authored
Do not set the ui::Compositor's LocalSurfaceId until after it allocated, which is done by resizing its aura::Window. Just changing the order of the calls breaks the behavior of UpdateRootWindowSizeInPixels. This is a function that specifies pixels and commits the sin of not specifying a device scale factor. It needs a DSF, so it grabs one from the ui::Compositor (which now is out of date). To fix this, snapshot the device scale factor from the display::Display in OnHostResizedInPixels, where it should have been specified to begin with. This opens up the question of why the value of OnHostResizedInPixels is not snapshotted itself, so add comments indicating this potential source of inconsistency. While exploring that rabbit hole, some surface invariant violations in DesktopWindowTreeHost were also discovered, so add comments to remember them. Bug: 818085 Change-Id: I88d5b59e031ef6c57b5a7ef778540ae4a8b95bc8 Reviewed-on: https://chromium-review.googlesource.com/958329Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#542584}
-
Adam Langley authored
The replacement attestation certificates didn't provide a self-signature because nobody can validate our certificates. However, fastmail.com expects to be able to parse an ECDSA signature even if they don't check it. Therefore this change provides a syntactically valid signature in the certificate and fixes enrollment on fastmail.com Bug: 821099 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I332e078227eb36ba81e4cb089bd1f63ceb0bcbea Reviewed-on: https://chromium-review.googlesource.com/959304Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#542583}
-
Steven Bennetts authored
In preparation for supporting OpenVPN.ExtraHosts, we need to support string arrays in network-property-list. Some issues with policy indicators were discovered as well. This CL: * Adds support for an editable StringArray type. * Only shows policy indicators for fields that may be user editable. (Other indicators just provide noise). * Treats properties with no entry in policy controlled configurations as not user editable. Bug: 742666,819837 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I601e4cc0839bd1560bd1dc5af099aba3b19623dc Reviewed-on: https://chromium-review.googlesource.com/955934 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#542582}
-
Steven Bennetts authored
This adds some additional network configuration logging: * Logs an error when fields are stripped from an ONC configuration since this indicates an incorrect policy or UI configuration. * Adds additional logging during configuation (an uncommon event) to help track down the source of configuration failures. Bug: 742666 Change-Id: I9db246c953e2e0f47c82f1069b226f91434c1f90 Reviewed-on: https://chromium-review.googlesource.com/955928Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#542581}
-
Patrick Monette authored
It was possible to have repeated call to OnFocusChangedEvent() between the time the name was written in the search box, and the actual destruction of the automation controller, which unregisters the event handlers. Bug: 819792 Change-Id: Ied95051f7ebb07e954b8c5d7d3cff0d3e7574daa Reviewed-on: https://chromium-review.googlesource.com/955744 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#542580}
-
Robert Iannucci authored
R=nodir@chromium.org Bug: 811974 Change-Id: I5959edc280c02937b66417ea035f8012feb5bb33 Reviewed-on: https://chromium-review.googlesource.com/958038 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Cr-Commit-Position: refs/heads/master@{#542579}
-
Benjamin Pastene authored
Bug: 817779 Change-Id: If4599943937ea5c628bfc3cc96f5df9b9b4065f1 Reviewed-on: https://chromium-review.googlesource.com/959345Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Benjamin Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#542578}
-
Dale Curtis authored
Clients don't care about these copies once they destroyed the pool; we also don't want to waste resources copying these unused frames after Reset(). BUG=801245, 820685, 820944 TEST=updated tests Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I15ccf0c5a00b14e87522f923c4ec9c93416d9342 Reviewed-on: https://chromium-review.googlesource.com/958042 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#542577}
-
liberato@chromium.org authored
Some devices seem to be sending multiple EOS output buffers to MCAD, which doesn't handle them well. This CL makes it possible for a MediaCodecLoop client to signal an error when an EOS buffer arrives, to transition MCL into the error state safely. Bug: 818866 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ic40b2a10ee4d983be28211b18ee9268a379f13d5 Reviewed-on: https://chromium-review.googlesource.com/957642Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#542576}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/fbbe951b..fc5740ae Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I4ed1484c2f676f72325c39e74702f4a01d93afa1 Reviewed-on: https://chromium-review.googlesource.com/957920Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#542575}
-
Robert Liao authored
Browser unhandled keyboard event forwarding was added for 130131, but is incompatible with the way Mac dispatches events. Views unhandled keyboard event forwarding was added for 145184 and should be the main way to cover this scenario for all platforms. BUG=130131,145184,820208 Change-Id: Ia6fd96b6059a5b5932e186299a0769b6a931c356 Reviewed-on: https://chromium-review.googlesource.com/957975Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#542574}
-
Daniel Cheng authored
This method doesn't really make sense on Frame, as it is a property of a LocalFrame. Putting it on Frame implies that there are situations where it would return true for RemoteFrame, but that acn never happen. There are a few places that walk all frames in the frame tree looking for local roots and thus need to do an extra IsLocalFrame() check now: - PropagateZoomFactorToLocalFrameRoots: visits all the local roots in a frame tree to update the zoom factor. - DidExitFullscreen: this one is slightly unusual in that it only notifies the *topmost* local root. - FocusedOrMainFrame: arguably wrong and should be removed. If there are a more instances in the future of needing to walk the frame tree for all local roots, it might be worth adding a helper. Change-Id: Ie4f9a5ffc4b9b50331a7139b2c4935de53875659 Tbr: haraken@chromium.org Reviewed-on: https://chromium-review.googlesource.com/959230Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#542573}
-
Michael Thiessen authored
This reverts commit 848f0ea0. Reason for revert: Reland after reverting enums.xml change Original change's description: > Revert "VR: Remove VR Launch Intents flag" > > This reverts commit c83231b7. > > Reason for revert: Should not have removed flags from enums.xml > > Original change's description: > > VR: Remove VR Launch Intents flag > > > > This flag was really only for development while we weren't sure how to > > handle VR Intents. With Chrome VR browsing already shipped, there's no > > reason not to allow Intents to launch it. > > > > Change-Id: Ibbc7e5ea41668c073a4a04340ec45bfe40025b0f > > Reviewed-on: https://chromium-review.googlesource.com/959051 > > Commit-Queue: Michael Thiessen <mthiesse@chromium.org> > > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#542508} > > TBR=yfriedman@chromium.org,mthiesse@chromium.org > > Change-Id: I6b92369c483f7f0d8a11290bb9a50f6cfd1ea766 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/958021 > Reviewed-by: Michael Thiessen <mthiesse@chromium.org> > Commit-Queue: Michael Thiessen <mthiesse@chromium.org> > Cr-Commit-Position: refs/heads/master@{#542550} TBR=yfriedman@chromium.org,mthiesse@chromium.org Change-Id: Iadb349fe60ea6a3a843228f3a4dcf24c6b9f9589 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/958103 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#542572}
-
Adrienne Walker authored
Bug: 820399 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I6911388373a2e12397db9ae2d995c9769cd10033 Reviewed-on: https://chromium-review.googlesource.com/958335Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#542571}
-
Khushal authored
For PaintRecord backed shaders, skia performs the rasterization of the shader's record at the required scale before tiling. In order to decode images in these records using cc's decode cache, we create a temporary SkPicture with images replaced with decodes from cc's cache and use that in a new SkPictureShader each time the PaintShader is rasterized. Skia internally maintains a cache of rasterized pictures used in these shaders, keyed on the SkPictureShader's uniqueID. Since a new SkPictureShader is created for each raster call, we don't get a cache hit in skia and end up re-rasterizing the shader's record. The ideal solution for this would be to maintain a PaintShaderCache which caches rasterized records. But given the rarity of these cases, its not worth duplicating skia's picture cache. However, if any of the images in these records are animated, they must go through cc's decode stack to update them and use cached animation frames. The change ensures that we only decode shaders in cc if they have animated images. Note that the performance hit of re-rasterization of records in these cases will still exist. R=chrishtr@chromium.org, enne@chromium.org, ericrk@chromium.org Bug: 817640 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ibd1f3db9902f21fca20c99be1cf9e36b54cd7085 Reviewed-on: https://chromium-review.googlesource.com/952529 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#542570}
-
https://pdfium.googlesource.com/pdfium.git/+log/735eda96cf24..83a01491dbd9 $ git log 735eda96c..83a01491d --date=short --no-merges --format='%ad %ae %s' 2018-03-12 hnakashima Fix crash when creating a CFX_DIBitmap with FXDIB_Invalid. 2018-03-12 rharrison Add test that non-ASCII characters to not foul hyphen processing Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I8ba1dafad38e6148569cad231238be54fa3796bf Reviewed-on: https://chromium-review.googlesource.com/958332 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#542569}
-
Farah Charab authored
Change-Id: I78a42bdb82f83b0d64386def369253ef4087bbe5 Reviewed-on: https://chromium-review.googlesource.com/955857Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Farah Charab <farahcharab@chromium.org> Cr-Commit-Position: refs/heads/master@{#542568}
-
Sonny Sasaka authored
This adds sender='<name>' filter as the match rule for subscribing to signal in ObjectProxy. This is needed to reduce the unnecessary polluted log of rejecting some signals. The manual sender verification is still needed because as mentioned in https://bugs.chromium.org/p/chromium/issues/detail?id=507206#c14 service_name_ might be empty and sender='' means to not filter by sender at all. BUG=chromium:812468 TEST=Tested on device and checked that communications to D-Bus services (e.g. power, bluetooth) don't break Change-Id: I0ef4e03b5d9d8aa4412ef97286b971c30f458e99 Reviewed-on: https://chromium-review.googlesource.com/958324Reviewed-by:
Satoru Takabayashi <satorux@chromium.org> Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org> Cr-Commit-Position: refs/heads/master@{#542567}
-
Gustav Sennton authored
Split/publish ServiceWorker related functionality in the android.webkit glue layer to allow the support library glue to use that functionality. Bug: 819595 Change-Id: Ia705f3c867400f4ab30c0cc14083e7a0abc0a269 Reviewed-on: https://chromium-review.googlesource.com/958867Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Gustav Sennton <gsennton@chromium.org> Cr-Commit-Position: refs/heads/master@{#542566}
-
Wenzhao Zang authored
This is a follow-up to CL 945075. It uses the same logic to support preview for online wallpapers. Bug: 818075 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I17eaf9c554bacfee0b3075213e0936aa0f20c189 Reviewed-on: https://chromium-review.googlesource.com/949884Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Reviewed-by:
Xiaoqian Dai (OOO 3-12) <xdai@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#542565}
-
Tommy Steimel authored
This CL fixes a couple of visibility issues for the modern media controls. First, it only toggles the controls visibility on touch events instead of all click events. Second, it changes the ShouldHideMediaControls hover check to only use the hover state of the button panel and timeline instead of the panel itself, which in modern media controls covers the entire video element. This fixes an issue on desktop where the controls wouldn't hide during fullscreen since the controls were always hovered. Bug: 812890 Change-Id: I8cb30841020e7f3ffdadc53131a4fa374b4254c2 Reviewed-on: https://chromium-review.googlesource.com/938841 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#542564}
-
Shimi Zhang authored
There is no usage of this version anywhere, so removing it. Bug: 805531 Change-Id: I11d1fe29268ae17255d05d79283dca9d7a83bcc2 Reviewed-on: https://chromium-review.googlesource.com/959302Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#542563}
-
Moe Ahmadi authored
Replaces an unused boolean argument with an optional callback that indicates whether the input element's value was changed. This callback is used to mark elements as autofilled only when the value has actually changed. This fixes cases where a <select> element is marked as autofilled while its value hasn't actually changed from its default value. e.g., www.crutchfield.com Bug: 803670 Change-Id: Iced545fb0f43fa351342b6b51dbacf789f150f8a Reviewed-on: https://chromium-review.googlesource.com/959052 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#542562}
-
Luna Lu authored
Mark http/tests/media/autoplay/document-user-activation-cross-origin-feature-policy-gesture.html flaky on Mac Bug: 788390 Change-Id: I2216e1c17ef9b4431d361180fe7a0d998dd807aa Reviewed-on: https://chromium-review.googlesource.com/959385 Commit-Queue: Luna Lu <loonybear@chromium.org> Reviewed-by:
Luna Lu <loonybear@chromium.org> Cr-Commit-Position: refs/heads/master@{#542561}
-
David Benjamin authored
Bug: 820198 Change-Id: If15c9ae81c1d43f7c45d5fcf28ecbad0a8ba8635 Reviewed-on: https://chromium-review.googlesource.com/956030 Commit-Queue: David Benjamin <davidben@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#542560}
-
Linkun Chen authored
Bug: 70225530 Test: build and push OTA to device. Change-Id: I3e77b8e0ea55084c499de36169d80a195c0de74a Reviewed-on: https://chromium-review.googlesource.com/958225Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Linkun Chen <lkchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#542559}
-
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e0f4e29651e2..c5edef2fbc54 $ git log e0f4e2965..c5edef2fb --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src-internal The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: If5511d6dc54fa7178ead91b99e8a2c2d9c60a440 Reviewed-on: https://chromium-review.googlesource.com/958334 Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#542558}
-
Derek Cheng authored
This is a workaround for enterprise setups (such as universities) where the network topology assigns public IP addresses to their Cast devices (presumably these devices are protected behind a firewall). Public IP addresses were disallowed in crrev.com/519857 which causes such setup to be broken, as users can no longer connect to those devices. To our knowledge there are at least 2 EDU setups (and a handful of individual users) that were affected by this. The workaround is implemented as a feature that is disabled by default. The intended target is affected users for whom the option of changing the Cast devices is infeasible (mostly EDU organizations). It can be enabled by passing in --enable-features=CastAllowAllIPs in the command line, or by turning it on in chrome://flags. Bug: 813974 Change-Id: Ia02702315f02544245862561dc6925f0e15725db Reviewed-on: https://chromium-review.googlesource.com/954345Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Commit-Queue: Derek Cheng <imcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#542557}
-
sangwoo.ko authored
Bug: 651022 Change-Id: I95d405ca9be1747abfe24f68f0837ed5981571ed Reviewed-on: https://chromium-review.googlesource.com/958783Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#542556}
-
edchin authored
The layout needs updating whenever a new image is set. Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: If7e9d731f31bec7d28198a6f06275abd36071185 Reviewed-on: https://chromium-review.googlesource.com/954502Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#542555}
-
Yury Khmel authored
It is possible to drop using wallpaper test client for the set of unit tests where wallpaper test client is used to prevent crash from the fake user manager. Test: git cl try Bug: N/A Change-Id: I7a788656fe0558841523744dc5ada3a1d5ffde9b Reviewed-on: https://chromium-review.googlesource.com/957788 Commit-Queue: Yury Khmel <khmel@google.com> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#542554}
-
Sammie Quon authored
This is a reland of b513507c Original change's description: > tablet: Remove minimum time between taps for quick switch. > > Previously relied on using tap_count in GestureEvent which has a minimum > time between taps of 40ms for consecutive taps to have tap_count of 2. > Remove that and track double taps in overview button tray.cc. Allows > double tap from mice now. > > Test: ash_unittests OverviewButtonTrayTest.* > Bug: 817883 > Change-Id: Icce2e668223f938a7f8194c5f0a03279abff9907 > Reviewed-on: https://chromium-review.googlesource.com/956769 > Commit-Queue: Sammie Quon <sammiequon@chromium.org> > Reviewed-by: James Cook <jamescook@chromium.org> > Cr-Commit-Position: refs/heads/master@{#542315} Bug: 817883 Change-Id: Ifd6ecabf3f1702d8aeffa29a48a6475f0e6b5422 Reviewed-on: https://chromium-review.googlesource.com/958014Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#542553}
-
Fredrik Söderquist authored
The initial value used here shouldn't make a difference, so use the initial value of 'fill' since that looks less confusing. It will also simplify conversion to a different computed <paint> representation. Bug: 769774 Change-Id: I5a08f73d4affc28f5804f3c3164051197721b2a4 Reviewed-on: https://chromium-review.googlesource.com/959009Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#542552}
-