- 07 Jul, 2020 40 commits
-
-
Lahiru Ginnaliya Gamathige authored
Bug: 1102606 Change-Id: I1f26284306d832fa2fe1ad6578bca6c6eb193843 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284005Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Lahiru Ginnaliya Gamathige <glahiru@google.com> Cr-Commit-Position: refs/heads/master@{#785854}
-
Fredrik Söderqvist authored
These have not been SVG-specific for quite some time, so keeping them separate from the "basic" (HTML) named colors does not offer any advantage. Bug: 1102816 Change-Id: Ia2fd62e150aa99054cc8110f2e4ede0706a238d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283354 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#785853}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/fb40750b..22f9d885 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic1278eec37b8d86f460c5440af40e8b5daf45ac6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283509Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#785852}
-
Daniel Rubery authored
This CL adds metrics to monitor the performance of the CSD visual model. We measure the amount of time it takes to extract visual features, and how long is spent on the comparison of those features with the model. Bug: 1068613 Change-Id: I294b6cb2b217470c422f82ce388ec448f11e6375 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276335 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#785851}
-
Doug Arnett authored
This is an attempt to avoid a race condition crash with the infobar going away while the page translated callback occurs. Bug: 1093320 Change-Id: I47025de0d8c23045e1a964d4cef0c732e903b8b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283657Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Commit-Queue: Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#785850}
-
Henrique Nakashima authored
It is enough to pass in a WebContents. Bug: 1090048 Change-Id: Ib32c8fb80c58777409e3c7bba415013ce6351ca0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2281306Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#785849}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/ba17d8bcf0dc..e8c9fd602f11 2020-07-07 johnkslang@users.noreply.github.com Merge pull request #2326 from ben-clayton/always_pic If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,syoussefi@google.com Change-Id: Iabe6540a7b0657101dda67261b6d50a1db6df6e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284948Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#785848}
-
Toni Barzic authored
Notify shelf config observers that the shelf config has changed when tablet mode changes - some shelf dimensions depend on tablet mode state, so shelf may need relayout when tablet mode changes. This is generally done when hiding shelf buttons in tablet mode is enabled, but depending on user settings, that may not be the case. Also, stop observing tablet mode state in ShelfLayoutManager, as it's already observing both ShelfConfig, so now that shelf config is updated when tablet mode changes, it should be enough to observe shelf config only. BUG=None Change-Id: I3c9f84ec9fa4d03bcd2838ea43cd7ae5869f26a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283580Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#785847}
-
Antonio Gomes authored
... instead of WebMediaStreamSource. BUG=704136 R=guidou@chromium.org Change-Id: Ib14470ab7e8acbd911e059c12c8ddc0f983b3d14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283392 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#785846}
-
ckitagawa authored
Capturing OOPIFs separately allows them to scroll for the purposes of paint previews. However, on pages where iframes may not be out-of-process it would be ideal if we recorded them as separate SkPictures if they are scrollable to allow them to scroll and not become clipped. This is especially important in cases like AMP on mobile where, without strict site-isolation, a same-process iframe is the majority of the content view. However this iframe is clipped and cannot scroll due to how printing works normally. This can be fixed by capturing these iframes using the same mechanism as OOPIFs when capturing a Paint Preview. Bug: 1098300 Change-Id: Ic57c59bd2d358d96334ad892387e7e785f3c9df7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2194381Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#785845}
-
danakj authored
Put the code there directly into content/shell/browser/web_test. R=avi@chromium.org Bug: 866140 Change-Id: I28024f4fbe56a6086819a15b874130a53bb25425 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2280387 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#785844}
-
sauski authored
To support recording access for non-persistent cookies, the Access Context Audit service and databases are extended to store non- persistent cookies alongside persistent cookies. These records are cleared on startup unless restoring the previous session. Bug: 1101675 Change-Id: I7ee7a47530f8f0d6b05fc8890b94c605f839c2ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273057Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Cr-Commit-Position: refs/heads/master@{#785843}
-
David Tseng authored
R=akihiroota@chromium.org Test: browser_tests --gtest_filter=ChromeVox*.*Unknown Change-Id: I918f738fc0e9fdee1db2bec579e43a8f3a0984e6 Fixed: 934968 AX-Relnotes: when a permission dialog pops up, ChromeVox places focus correctly. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283928 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#785842}
-
Colin Blundell authored
This CL follows up the componentization of infobar_android.* and confirm_infobar.* by putting these classes in the infobars namespace. Bug: 1099169 Change-Id: I6344cd990975f720f60be6eab05f97debb75892a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282806Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#785841}
-
Alexander Cooper authored
Fixed: 1099834 Change-Id: Ib434e634528e1ac56efecb3e8c97201558eafd3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278307 Auto-Submit: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#785840}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I084e2f36ecd874fd893bfd14cbcd0fe133d16602 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284632Reviewed-by:
-
Nate Chapin authored
Bug: 1101402 Change-Id: I8b1aee063f1f19c850346912b1d15c69dc70631f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278234 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#785838}
-
Henrique Ferreiro authored
Change-Id: I6ee7fac30161ca131765d36d4283e202fad99ae1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283346Reviewed-by:
-
harrisonsean authored
The custom cell for password check is similar to the one needed for safety check. It is being renamed to settings_check_cell for more general use. The main difference is the whether or not an image is used on the leading side of the cell. This CL adds an optional image to the leading side of the cell for compatibility with both checks. Bug: 1078782 Change-Id: I825bdcb53f624ce2e567a68dc900bddc310dc270 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273162 Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#785836}
-
Shengfa Lin authored
Once/Repeating Change Bind and Callback to BindRepeating and RepeatingCallback for nacl broker listener and nacl debug exception handler win. Bug: 1007703 Change-Id: I1f9aac13d3478d2a121faedb47476d6455a427f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278855Reviewed-by:
Brad Nelson <bradnelson@chromium.org> Commit-Queue: Shengfa Lin <shengfa@google.com> Cr-Commit-Position: refs/heads/master@{#785835}
-
Daniele Castagna authored
This patch renames/removes the GL reference since the flag is now used by SkiaRenderer too. Change-Id: I0ca3dd171b379af6a926e5622b9f9230f09f8d28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276807Reviewed-by:
weiliangc <weiliangc@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
-
dpapad authored
The change at r782918, which modified RunNode() to use shell=False, broke this script, and started returning incorrect output (JS comments were not stripped) Bug: 1096473 Change-Id: I9d767d0ec2d92612ddf73c37e8ab70c4aedc6573 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284015 Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#785833}
-
Mitsuru Oshima authored
so that CL like this (crrev.com/c/2214761) can use it. Bug: None Change-Id: I685819c89b87603a542324431ba0a6d9a80eb1e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283504 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#785832}
-
Shengfa Lin authored
Once/Repeating Modified coded_frame_provider and its subclass buffering_frame_provider and demuxer_stream_adapter to use OnceClosure and BindOnce. Modified mock_frame_consumer/provider to use OnceClosure and BindOnce. Bug: 1007649 Change-Id: I9f464c65065c8676be8ee793a9ba6d099eff9863 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278583Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Shengfa Lin <shengfa@google.com> Cr-Commit-Position: refs/heads/master@{#785831}
-
Ilia Samsonov authored
Bug: 1068400 Change-Id: I802b82616789443420957e28d87a64bfdb1c93c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283738Reviewed-by:
-
Meredith Lane authored
https://crrev.com/c/2203775 introduced storing of theme and font family selections in a user preference. On page load, this was not taken into account with the radio buttons for the theme selector or the select drop down for the font family. This change ensures these UI elements are updated correctly on page load to display the currently active theme and font family to avoid confusion for users. This patch also introduces some front end testing for the settings dialog. Bug: 1016615, 1070724 Change-Id: I2e45334d012b6d88e813c4bfd4f395adfa309413 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208871 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#785829}
-
Steven Bennetts authored
When the event listener was added for shill::kProhibitedTechnologies, it treated the property as a list (like other properties) however the property is actually stored as a string in Shill: https://chromium-review.googlesource.com/c/chromium/src/+/2197136 This was causing error spam when running on linux and in tests. This fixes that and adds a test. Bug: 1081488 TBR=tbegin@chromium.org Change-Id: I502bfe3369d31514b0f6f8e338408d3433ad5cef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283934Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#785828}
-
Xianzhu Wang authored
This is useful for debugging flaky tests with --iterations=n (or repeat-each=n) and --exit-after-n-failures=1. Previously the first stderr was kept which might be for a pass which was confusing in results.html where the failure results and the passing stderr were displayed. This doesn't affect normal runs (e.g. on bots) where tests are not repeated in one run (not including retries). Also output stderr for timeout tests, which is also useful for debugging. Change-Id: I25c1296e14b22763f36eb96d4028896f28a11c36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284215Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#785827}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/bee7cd569a4f..c5e8e8bf91ef 2020-07-07 chrome-bot@chromium.org Update config settings by config-updater. 2020-07-06 chrome-bot@chromium.org Update config settings by config-updater. 2020-07-06 smcallis@google.com Disable drallion hw tests due to rework on drallion360 DUTS. 2020-07-06 mmortensen@google.com BuildApi: Add sdk.Delete controller unit tests. 2020-07-06 saklein@chromium.org portage_util: Fix HasPrebuilt check. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I0a196d42ad944c8aba07f69631b574246a7a7d92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284946Reviewed-by:
-
Jose Dapena Paz authored
Bug: 819294 Change-Id: I04fb2cb5d939b9181ec8e42b0d0a9595b43c365a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283315Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: José Dapena Paz <jdapena@igalia.com> Cr-Commit-Position: refs/heads/master@{#785825}
-
Mirko Bonadei authored
The idea behind this test suite is to ensure that Chromium always compiles Abseil in hardened mode (see [1]) and that std types that will replace Abseil types in C++17 will also support this feature (this allows Chromium to detect if a lost of safety happens for example when absl::optional will expand to std::optional). [1] - https://cs.chromium.org/chromium/src/third_party/abseil-cpp/absl/base/options.h?l=211-236&rcl=39c12e538d4170e9061ac9661a156870b3389c17 Bug: 1096623 Change-Id: I2e35139cc15ce4fc4d1ff3b9743bb75ef72be888 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256209 Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#785824}
-
Tibor Goldschwendt authored
See crbub/1094088 for the details. Briefly, when opening the first WebUI NTP the navigation machinery tries to use the spare renderer at first but discards the spare since it doesn't have WebUI bindings (yet). The fix is to allow keeping the spare if no navigation has been committed to it yet with the assumption that WebUI bindings will be granted later in the navigation flow. Credit goes to alexmos@ who came up with the fix and landed the prerequisite CLs crrev/c/2275146 and crrev/c/2272029. Using the spare renderer improves NewTabPage.LoadTime.WebUINTP from ~278ms to ~208ms on my linux machine. Fixed: 1094088 Change-Id: I140d2d19b95f4d2dfd4f87a9278c18bc81e51bf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250945 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
-
danakj authored
Pull most of TestInterfaces out into TestRunner so that we don't need to keep around both classes which overlap in responsibilities. Stop plumbing through TestInterfaces to get to TestRunner, expose it from the same places that currently expose TestInterfaces. Add a list of main frames to TestRunner, and use that for windowCount() which changes a couple of test expectations, as they were counting the proxied RenderViewHost of a cross-site window. The problem is they would also count same-site fragments of windows opened by other renderer processes. R=avi@chromium.org Bug: 866140 Change-Id: I065916b4e5184a0fbb95981a2a69b6b5a90b0023 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2281067 Commit-Queue: danakj <danakj@chromium.org> Auto-Submit: danakj <danakj@chromium.org> Reviewed-by:
-
Denis Kuznetsov authored
This CL moves responsibility of detecting idleness for starting demo mode from CoreOobeHandler to two relevant screens. Bug: 1100909, 1100910 Change-Id: Icd4142fdb75f3f7376b01d50b808078b42fb6872 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277722 Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Aleksandrov <raleksandrov@google.com> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#785821}
-
David Tseng authored
R=anastasi@chromium.org AX-Relnotes: n/a Bug: 1100666 Change-Id: Id7020d13b9a7aa7cec33782d1513aa2bef8cae28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277870Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#785820}
-
Oleh Lamzin authored
Add cached VPD info to the probe service. Bug: b:158658869 Change-Id: I41854f62e19139e6fab9d15bda67460f2f55d2a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270144 Commit-Queue: Oleh Lamzin <lamzin@google.com> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Roland Bock <rbock@google.com> Reviewed-by:
Mahmoud Gawad <mgawad@google.com> Cr-Commit-Position: refs/heads/master@{#785819}
-
Roman Sorokin authored
Removed unused bits, inlined some of the code. Bug: 1067260 Change-Id: I1e5be13ba9bc89f5ec1fa24e90652e4992c462f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279804 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
-
Xiaohan Wang authored
In normal cases the session ID returned by the MediaFoundation CDM (IMFContentDecryptionModule) should never be the same. In the rare case duplicate session IDs are returned, the current implementation will crash. This CL fixes the implementation and adds a unit test. NOPRESUBMIT=true Bug: 999747 Change-Id: I319c33517dd6452cb45ee30d3c1c02a41b0c6ccf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278416Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#785817}
-
K. Moon authored
Switches chrome_pdf::URLLoaderWrapper's API from pp::CompletionCallback to base::OnceCallback. pp::CompletionCallback is still used internally when calling Pepper APIs., but clients of URLLoaderWrapper no longer need to deal with pp::CompletionCallback. Using base::OnceCallback also simplifies resource management, eliminating the need to manage references to pp::CompletionCallback. With respect to thread safety, most Pepper APIs invoke asynchronous callbacks on the original caller's thread, so there should be no new thread safety issues. The base:: APIs also do sequence checking in DCHECK mode, which should catch any unanticipated issues. Bug: 1099022, 1101169 Change-Id: Ia355588b25b54a776ac972a7b5b2104b1a3b18c8 Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278169 Commit-Queue: K. Moon <kmoon@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#785816}
-
Regan Hsu authored
Fixed: 1096770 Change-Id: I60f55f43534f3388801c1a5aca29f936861d7398 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253128Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#785815}
-
