GitLab

Followup to https://codereview.chromium.org/483703002/

Turns out you can have a profile image, but no profile URL. Handle this case by resolving the image URL against a dummy https URL.

BUG=404671

Review URL: https://codereview.chromium.org/495003003

Cr-Commit-Position: refs/heads/master@{#291153}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291153 0039d316-1c4b-4281-b951-d872f2087c98

casting/sharing is turned on upon user switch

Purpose of this change:

Asks the user with a system modal dialog box if he wants to
turn off screen sharing/screen casting and then switch users
or abort switching users.

BUG=353170
TEST=TrySwitchingUserTest.*

Review URL: https://codereview.chromium.org/496563002

Cr-Commit-Position: refs/heads/master@{#291152}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291152 0039d316-1c4b-4281-b951-d872f2087c98

BUG=405486
R=dbeam@chromium.org

Review URL: https://codereview.chromium.org/489983003

Cr-Commit-Position: refs/heads/master@{#291151}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291151 0039d316-1c4b-4281-b951-d872f2087c98

Remove duplicate reference of content_switches which causes link errors.

Add dependency on theme_resources from apps (it includes the generated file).

R=miket@chromium.org

Review URL: https://codereview.chromium.org/496763002

Cr-Commit-Position: refs/heads/master@{#291150}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291150 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/491103004

Cr-Commit-Position: refs/heads/master@{#291149}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291149 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#291148}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291148 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=180694:180708&mode=html
TBR=dglazkov@chromium.org,wibling@chromium.org
BUG=

Review URL: https://codereview.chromium.org/495013002

Cr-Commit-Position: refs/heads/master@{#291147}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291147 0039d316-1c4b-4281-b951-d872f2087c98

These are regularly flaking on the build bots.  See bug for details.

NOTRY=true
TBR=miu@chromium.org
BUG=406018

Review URL: https://codereview.chromium.org/496053002

Cr-Commit-Position: refs/heads/master@{#291146}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291146 0039d316-1c4b-4281-b951-d872f2087c98

The skia bug suspected to cause this has been fixed.

R=tonyg@chromium.org
BUG=399125

Review URL: https://codereview.chromium.org/491583003

Cr-Commit-Position: refs/heads/master@{#291145}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291145 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
NOTRY=True

Review URL: https://codereview.chromium.org/498473002

Cr-Commit-Position: refs/heads/master@{#291142}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291142 0039d316-1c4b-4281-b951-d872f2087c98

This replaces the whitelisting of all Qualcomm GPUs on
Android 4.4 with whitelisting all Android 4.4 devices
with GL ES version >= 3.0.

BUG=405646

Review URL: https://codereview.chromium.org/468103003

Cr-Commit-Position: refs/heads/master@{#291141}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291141 0039d316-1c4b-4281-b951-d872f2087c98

See
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/5481
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/5503
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/5542

BUG=291249
TBR=jdduke@chromium.org

Review URL: https://codereview.chromium.org/492303005

Cr-Commit-Position: refs/heads/master@{#291139}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291139 0039d316-1c4b-4281-b951-d872f2087c98

Bug=352290

Review URL: https://codereview.chromium.org/486903002

Cr-Commit-Position: refs/heads/master@{#291138}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291138 0039d316-1c4b-4281-b951-d872f2087c98

Cross-origin HTTP auth dialogs are shown over a blank interstitial.
This didn't work nicely with other interstitials, e.g. an HTTPS resource
that triggered a basic HTTP auth dialog would show the SSL warning, and when
the user clicked through the warning, the login interstitial would show
on top of the SSL interstitial, rather than a blank page.
crrev.com/410373003 accidentally fixed that issue. This CL adds tests
for the scenario described above.

BUG=393597
TEST=LoginPromptBrowserTest.LoginInterstitialShouldReplaceExistingInterstitial

Review URL: https://codereview.chromium.org/397453002

Cr-Commit-Position: refs/heads/master@{#291137}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291137 0039d316-1c4b-4281-b951-d872f2087c98

TBR=ckocagil@chromium.org
BUG=406012

Review URL: https://codereview.chromium.org/482493003

Cr-Commit-Position: refs/heads/master@{#291136}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291136 0039d316-1c4b-4281-b951-d872f2087c98

Disable AppWindowInteractiveTest.ESCLeavesFullscreenDOM and AppWindowInteractiveTest.ESCDoesNotLeaveFullscreenWindow as they are flaky on Mac.

TBR=mlamouri@chromium.org
BUG=406009

Review URL: https://codereview.chromium.org/490293002

Cr-Commit-Position: refs/heads/master@{#291135}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291135 0039d316-1c4b-4281-b951-d872f2087c98

profile editor even when raw full name is missing.

BUG=403021

Review URL: https://codereview.chromium.org/450403004

Cr-Commit-Position: refs/heads/master@{#291134}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291134 0039d316-1c4b-4281-b951-d872f2087c98

BUG=352290

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291002

Review URL: https://codereview.chromium.org/481003002

Cr-Commit-Position: refs/heads/master@{#291133}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291133 0039d316-1c4b-4281-b951-d872f2087c98

This function is long and sophisticated. Factor out the code creating
and setting |stream_| and reorganize if-clauses.

Then, this CL adds for_websockets_ checks where it's missing.

R=jgraettinger,rch
BUG=394434

Review URL: https://codereview.chromium.org/443383002

Cr-Commit-Position: refs/heads/master@{#291131}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291131 0039d316-1c4b-4281-b951-d872f2087c98

Shell operations may cause 3rd-party shell extensions to be loaded into the calling process. Isolating them in a utility process protects the browser process from potential instability.

BUG=73098

Review URL: https://codereview.chromium.org/431343002

Cr-Commit-Position: refs/heads/master@{#291128}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291128 0039d316-1c4b-4281-b951-d872f2087c98

BUG=387613
R=nkostylev@chromium.org
TBR=stevenjb@chromium.org

Review URL: https://codereview.chromium.org/495563003

Cr-Commit-Position: refs/heads/master@{#291125}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291125 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#291123}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291123 0039d316-1c4b-4281-b951-d872f2087c98

https://skia.googlesource.com/skia/+log/4082d290eea2f70caa82120ff3bc4fbdccbf206c..1f31e7671721a9f2c204a0e1842961f43e7b53ca

CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_layout_rel
TBR=caryclark@google.com
BUG=

Review URL: https://codereview.chromium.org/488383003

Cr-Commit-Position: refs/heads/master@{#291122}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291122 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/477193003

Cr-Commit-Position: refs/heads/master@{#291119}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291119 0039d316-1c4b-4281-b951-d872f2087c98

BUG=386454
R=manzagop@chromium.org, newt@chromium.org
TBR=erikwright
TEST=SuggestionsServiceTest

Review URL: https://codereview.chromium.org/473123002

Cr-Commit-Position: refs/heads/master@{#291116}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291116 0039d316-1c4b-4281-b951-d872f2087c98

This channel needs to be made synchronous to safely support sending a
synchronous message from the plugin to the renderer for reporting exit status.
The overall change for that support is available for review at:
  https://codereview.chromium.org/484783002/

This change splits out the channel refactoring to make this easier to review.

BUG=397161
R=dmichael@chromium.org

Review URL: https://codereview.chromium.org/486383002

Cr-Commit-Position: refs/heads/master@{#291113}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291113 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Only build various flash/pnacl/ppapi code when they are enabled. (patchset #7 of https://codereview.chromium.org/471263003/)

Reason for revert:
Suspected of breaking the disable_nacl build.

Original issue's description:
> Only build various flash/pnacl/ppapi code when they are enabled.
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291069

TBR=dyen@chromium.org,viettrungluu@chromium.org,thestig@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/492323002

Cr-Commit-Position: refs/heads/master@{#291112}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291112 0039d316-1c4b-4281-b951-d872f2087c98

The current random base address generation in the Android chromium linker is prone
to error.  It selects an address at random between 0x20000000 and 0x40000000 and
expects that this will be clear.  This is occasionally untrue for ARM, but very
often untrue for MIPS.  As a consequence, RELRO sharing is being turned off more
frequently than it could be.

This change removes the local random address generation code and instead replaces
it with code that speculatively maps a large region, captures the address returned
by mmap, then unmaps and returns the address.  The expectation is that this region
will remain free for use when the time comes for the crazy linker to map the browser
into it.  This generally holds because the time between these two actions is short
and little, if anything, loads or mmaps between them.  Worst case is that RELRO
sharing turns off as at present, but the probability of this happening should now
be much lower.

Note that capturing the address from mmap relies on Android ASLR being active for
mmap.  This is the default device state since ICS.  The revised random browser
load address is only as entropic as Android's ASLR.

BUG=397634

Review URL: https://codereview.chromium.org/470053003

Cr-Commit-Position: refs/heads/master@{#291111}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291111 0039d316-1c4b-4281-b951-d872f2087c98

..as their ASCII codes are used in various layout tests. Mapped to
VKEY_ESCAPE and VKEY_BACK, respectively.

R=tkent@chromium.org
BUG=392517

Review URL: https://codereview.chromium.org/488053002

Cr-Commit-Position: refs/heads/master@{#291110}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291110 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#291108}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291108 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
Caused regression in static initializer count:

 # webrtcvideoengine2.cc _GLOBAL__sub_I_webrtcvideoengine2.cc+0x53                                                                                            
  # webrtcvideoengine2.cc _GLOBAL__sub_I_webrtcvideoengine2.cc+0x5a                                                                                            
  # webrtcvideoengine2.cc _GLOBAL__sub_I_webrtcvideoengine2.cc+0x9                                                                                             
  # webrtcvideoengine2.cc __divdi3@plt     

http://build.chromium.org/p/chromium/builders/Linux/builds/52540

Original issue's description:
> Roll webrtc 6905:6948.
> 
> TBR=hclam@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291082

TBR=hclam@chromium.org,grunell@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/495103003

Cr-Commit-Position: refs/heads/master@{#291106}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291106 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
NOTRY=True

Review URL: https://codereview.chromium.org/493143002

Cr-Commit-Position: refs/heads/master@{#291105}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291105 0039d316-1c4b-4281-b951-d872f2087c98

BUG=405816

Review URL: https://codereview.chromium.org/494023002

Cr-Commit-Position: refs/heads/master@{#291104}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291104 0039d316-1c4b-4281-b951-d872f2087c98

BUG=109173
TEST=none
R=jam@chromium.org
TBR=jam@chromium.org

Review URL: https://codereview.chromium.org/492293002

Cr-Commit-Position: refs/heads/master@{#291103}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291103 0039d316-1c4b-4281-b951-d872f2087c98

This moves the management of the global NexeLoadManager map inside the
NexeLoadManager class. This makes it so that a NexeLoadManager can be looked up
from a PP_Instance from the TrustedPluginChannel class, which is needed as part
of reporting exit status over Chromium IPC.

The change for moving exit status reporting to Chromium IPC  is
available for review at:
  https://codereview.chromium.org/484783002/

BUG=397161
R=dmichael@chromium.org

Review URL: https://codereview.chromium.org/484303002

Cr-Commit-Position: refs/heads/master@{#291102}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291102 0039d316-1c4b-4281-b951-d872f2087c98

When on demand raster is not allowed, when tiles are OOM, checkerboard
or solid color quad should be produced rather than nothing.

Add a unittest for this exact same scenario.

BUG=402321

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289480

Review URL: https://codereview.chromium.org/468983002

Cr-Commit-Position: refs/heads/master@{#291101}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291101 0039d316-1c4b-4281-b951-d872f2087c98

Bisecting Official Google Chrome builds was broken due to change of
base URL from http://master.chrome.corp.google.com/official_builds/
to https://console.developers.google.com/storage/chrome-unsigned/desktop-W15K3Y/.

BUG=384336
NOTRY=True

Review URL: https://codereview.chromium.org/492853002

Cr-Commit-Position: refs/heads/master@{#291099}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291099 0039d316-1c4b-4281-b951-d872f2087c98

They were mostly unused. Move remaining uses to calls to GetChildID,
though we'll possibly need to adjust them later.

BUG=376003

Review URL: https://codereview.chromium.org/481593002

Cr-Commit-Position: refs/heads/master@{#291098}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291098 0039d316-1c4b-4281-b951-d872f2087c98

Remove the unneeded PAGE_ACTION_COUNT_CHANGED notification.
Replace the PAGE_ACTION_VISIBILITY_CHANGED notification with a
PAGE_ACTIONS_UPDATED notification, which is sent once per
update (instead of once per page action).
Added bonuses:
- consistent notification behavior across cocoa/views
- less cruft in ui code

BUG=405356

Review URL: https://codereview.chromium.org/475813004

Cr-Commit-Position: refs/heads/master@{#291097}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291097 0039d316-1c4b-4281-b951-d872f2087c98

(specifically, everything except the omnibox's search engine)

Remove the settings search box.
Remove the enableResetProfileSettings JS variable, in place of "isGuest".

BUG=402153

Review URL: https://codereview.chromium.org/467363003

Cr-Commit-Position: refs/heads/master@{#291096}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291096 0039d316-1c4b-4281-b951-d872f2087c98