- 26 Jul, 2019 40 commits
-
-
Sadrul Habib Chowdhury authored
Report the sequence-length UMA separately for different types, e.g. for scrolling, pinch, animation etc. BUG=790761 Change-Id: Ib1365f443b1d9d4248f1376bc3e25139ac512819 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717501Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#681339}
-
Colin Blundell authored
This CL augments //components/signin with README.md files for various directories. Bug: 970295 Change-Id: If4a550cb5f572b01d740107d276563566ed52c9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715697 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Lowell Manners <lowell@chromium.org> Cr-Commit-Position: refs/heads/master@{#681338}
-
Vasiliy Telezhnikov authored
This CL makes LayerWithRealCompositorTest and SnapshotAuraTest parameterized to run using GLRenderer and SkiaRenderer. It adds new constructor to TestContextFactories with parameter to specify which renderer to use. Old constructor selects renderer based on feature state. Bug: 956144 Change-Id: I153c15359f213f25142b4ae705b78b2bb4d6db7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716924Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#681337}
-
Mei Liang authored
This CL enables "Group tab" menu option only when there are more than one un-grouped tabs in the current TabModel. Change-Id: Ia7a7bde1a32fe5d8411b3a6dfd95cb232df3fa76 Bug: 970266, 987146 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717603Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Mei Liang <meiliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#681336}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/d7e4835d4345..094fa97a20d7 git log d7e4835d4345..094fa97a20d7 --date=short --no-merges --format='%ad %ae %s' 2019-07-26 treehugger-gerrit@google.com Merge "Perfetto | Userspace slice selection" 2019-07-26 primiano@google.com Merge "Amalgamated SDK: add track event" Created with: gclient setdep -r src/third_party/perfetto@094fa97a20d7 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Bug: None Change-Id: Ia627e4f929eb1f6c026f85ca6dc65223cbcb61de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721031Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#681335}
-
John Budorick authored
This reverts commit 2d82c3a3. Reason for revert: revert applied cleanly but didn't compile cleanly :( Original change's description: > Revert "[PasswordManager] Stop Using Native Backends on Linux systems" > > This reverts commit 6811de35. > > Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=988010 > > Original change's description: > > [PasswordManager] Stop Using Native Backends on Linux systems > > > > Recent migrations moved all users who have been using the keying to the > > LoginDatabase. This CL forces all users to using LoginDatabase > > instead of native backends on Linux. > > > > TBR=pcc@chromium.org > > > > Change-Id: Ibac11e68d8f354ecf7f3c9828d95777ea5b3df60 > > Bug: 950269, 950267 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713560 > > Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org> > > Reviewed-by: Peter Collingbourne <pcc@chromium.org> > > Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> > > Reviewed-by: Christos Froussios <cfroussios@chromium.org> > > Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#681042} > > TBR=vasilii@chromium.org,pcc@chromium.org,cfroussios@chromium.org,mamir@chromium.org > > Change-Id: I2a42c76df8380cdaafb3485576e1efb9735f9d8d > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 950269, 950267 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721073 > Reviewed-by: John Budorick <jbudorick@chromium.org> > Commit-Queue: John Budorick <jbudorick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#681328} TBR=vasilii@chromium.org,pcc@chromium.org,cfroussios@chromium.org,jbudorick@chromium.org,mamir@chromium.org Change-Id: I4df7c871947ae69a91be947a4665220df7dc1154 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 950269, 950267 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720737Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#681334}
-
Jose Dapena Paz authored
The method UploadForDeepScanning gets a Request as parameter. But Request is an abstract class, so GCC will not allow that declaration (polimorphycs should be passed by reference). Use std::unique_ptr so BinaryUploadService can assume ownership. Bug: 819294 Change-Id: I9e8c75cc92b01abd704d9049b0421555377da5ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713550Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: José Dapena Paz <jose.dapena@lge.com> Cr-Commit-Position: refs/heads/master@{#681333}
-
Rijubrata Bhaumik authored
Pan and Tilt Constraints are part of the UVC spec. For Linux/CrOS, we can use V4L2 controls like (V4L2_CID_PAN_ABSOLUTE and V4L2_CID_TILT_ABSOLUTE). Spec: https://github.com/w3c/mediacapture-image/pull/182 Test Page: https://riju.github.io/WebCamera/samples/panTilt/ Putting Pan/Tilt feature behind a flag: chrome --enable-blink-features=MediaCapturePanTilt Intent to Implement and Ship discussions: https://groups.google.com/a/chromium.org/d/msg/blink-dev/j-Q08QgBipM/F3a5sau1BwAJ Bug: 934063 Change-Id: I552c4c8be717c3b67c4d91f826a1f16850430fa4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508519Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Cr-Commit-Position: refs/heads/master@{#681332}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/ec3039253ab8..3575550a711b git log ec3039253ab8..3575550a711b --date=short --no-merges --format='%ad %ae %s' 2019-07-26 sugoi@google.com Faster image sampler fetch from key Created with: gclient setdep -r src/third_party/swiftshader@3575550a711b The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: None Change-Id: I2a263bd4b33e9a02513b3bec31807ef612b61b0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721029Reviewed-by:
-
Yue Zhang authored
When user clicks on top tool bar toggle to switch between incognito/ normal mode right after the dialog animation starts, the animation continues and the dialog shows up while the tab model has already changed which causes dialog malfunction. This CL fixes this issue. Bug: 987227 Change-Id: I0e47119ed19627f4227e183454276dbdc5c2db06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717325Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
-
ssid authored
Creating Profile will create storage partition, which will need mojo initialized. So, move the init to test constructor. Network context also requires local state, so move the local state scope over profile creation. ChromeDataUseMeasurement is never destroyed. So, make the observer leaky. BUG=943354 Change-Id: I6ad76d421bdd2c376117b92abf965857f6f3a2c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720124Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#681329}
-
John Budorick authored
This reverts commit 6811de35. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=988010 Original change's description: > [PasswordManager] Stop Using Native Backends on Linux systems > > Recent migrations moved all users who have been using the keying to the > LoginDatabase. This CL forces all users to using LoginDatabase > instead of native backends on Linux. > > TBR=pcc@chromium.org > > Change-Id: Ibac11e68d8f354ecf7f3c9828d95777ea5b3df60 > Bug: 950269, 950267 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713560 > Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org> > Reviewed-by: Peter Collingbourne <pcc@chromium.org> > Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> > Reviewed-by: Christos Froussios <cfroussios@chromium.org> > Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> > Cr-Commit-Position: refs/heads/master@{#681042} TBR=vasilii@chromium.org,pcc@chromium.org,cfroussios@chromium.org,mamir@chromium.org Change-Id: I2a42c76df8380cdaafb3485576e1efb9735f9d8d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 950269, 950267 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721073Reviewed-by:
-
John Budorick authored
This reverts commit 806315e6. Reason for revert: Reverting dependent CL due to https://bugs.chromium.org/p/chromium/issues/detail?id=988010 Original change's description: > [Sync::USS] Allow Sync USS Passwords for Linux > > Sync USS Password on Linux has been unblocked by recent migrations > in the PasswordManager team that are concluded in the parent CL. > This CL is enabling the about flags for Linux and it enables it by > default for all linux bots. > > Change-Id: Ic94267ab0e9e4cce2ac2b02f1dfa9a0a9046e902 > Bug: 902349 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718332 > Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> > Reviewed-by: Brian White <bcwhite@chromium.org> > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > Reviewed-by: Marc Treib <treib@chromium.org> > Cr-Commit-Position: refs/heads/master@{#681044} TBR=treib@chromium.org,bcwhite@chromium.org,mastiz@chromium.org,mamir@chromium.org Change-Id: I4e21e1a8652cfc3bdf9f661a2180d42d3372fe5d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 902349 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721231Reviewed-by:
-
Ted Choc authored
The previous implementation would wait on async task and on certain device that could result in a deadlock. This converts to the new task queuing system, which avoids the need for waiting. BUG=949053 Change-Id: I795df73741e5d8e14255255a81aad6fd7eda6cf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715568Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#681326}
-
Mustaq Ahmed authored
Bug: 985914 Change-Id: I8ce9a771eb591cd7eadb93d94af2caa5f6af0e66 TBR: dcheng@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719444 Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#681325}
-
Aga Wronska authored
Parent access dialog should show correct title after the error is cleared. The title should be the same as before showing the error and it should match the reason that access code is requested for. Bug: 987792 Test: manually Change-Id: I4ec9a36ee22cfebae85875bbc3f2fb27d601c16d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719810Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Henrique Grandinetti <hgrandinetti@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#681324}
-
Peter Kotwicz authored
This CL: - Avoids finishing the WebAPK on Android O+ (the behaviour on pre-O is different) when: 1) The user selects the WebAPK from Android Recents 2) The WebAPK was killed by the Android OS OOM killer - Avoids finishing the WebAPK if the WebAPK was selected from Android recents and the host browser was uninstalled BUG=978716 TEST=SplashActivityTest.* Change-Id: I55927310afc99fa8565ea02533321d6bdcab536f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677687Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Pavel Shmakov <pshmakov@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#681323}
-
Jeremy Chinsen authored
In draw_utils/coordinates_unittest.cc, pp::Rect and pp::Size objects are compared to expected values frequently. This CL adds helper functions CompareRect() and CompareSize() to compare pp::Rect and pp::Size objects, respectively, simplifying the file. Change-Id: I3ff8235a90860a3c8343b18730e5ad1e69b0ba1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719329Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Jeremy Chinsen <chinsenj@google.com> Cr-Commit-Position: refs/heads/master@{#681322}
-
Jose Dapena Paz authored
Bug: 819294 Change-Id: Ie1530f7046b0c8eb76e26adca530fa57c67ed876 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720637Reviewed-by:
Ella Ge <eirage@chromium.org> Commit-Queue: José Dapena Paz <jose.dapena@lge.com> Cr-Commit-Position: refs/heads/master@{#681321}
-
Takuto Ikuta authored
In addition to remove linux-xenial, I did followings in this CL * change "linux" -> "linux-trusty" * have "linux-xenial" instead of "linux" in some mixins * use "linux-trusty" for * linux-trusty-rel CQ/CI builder * linux_upload_clang CQ builder * WebRTC Chromium Linux Tester CI builder I confirmed that w/ and w/o this CL generates the same flattened config with flatten_buildbucket_cfg. Bug: 954450 Change-Id: I65b5513254b634502aa1a8c4e939717843762886 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720359 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#681320}
-
Sinan Sahin authored
Bug: 971514 Change-Id: I48f5e7945690876b5d997f9f40ede57bc9f0637d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716933Reviewed-by:
-
Alex Newcomer authored
Revert "CrOS: Adding new SearchResult flags to dinner for one to allow for future-proof placement of it and other future policy tile apps." This reverts commit 1c673235. Reason for revert: Causes issue 987723 Original change's description: > CrOS: Adding new SearchResult flags to dinner for one to allow for future-proof placement of it and other future policy tile apps. > > Bug: 981023 > Change-Id: I06933a73ffafa91c8388d0325c008d2bd8e436e3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1687296 > Commit-Queue: Cameron Womack <camw@google.com> > Reviewed-by: Yury Khmel <khmel@chromium.org> > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Reviewed-by: Alex Newcomer <newcomer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#677966} TBR=oshima@chromium.org,khmel@chromium.org,newcomer@chromium.org,camw@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 981023 Change-Id: Ia3e2a571df3050ead665e7184fb128508f244b67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721013Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#681318}
-
Adam Raine authored
To composite color values cross thread, we must have a specific CrossThreadColorValue, and the only way to know if a CSSStyleValue holds a color value is to create a new color specific style value. This patch adds a new class CSSColorStyleValue for this purpose. Bug: 883721 Change-Id: I83472ffd26bf2eba3312b8578e81222f61bd17c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717189 Commit-Queue: Adam Raine <asraine@google.com> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#681317}
-
Matthew Cary authored
This change adapts media::VideoFrame to the new shared memory API [1]. media::VideoFrame::WrapExternalSharedMemory wraps shared memory in several contexts: sometimes from a shared memory object directly, and sometimes indirected through a VideoCaptureDevice::HandleProvider. The VideoFrame is also created with a pointers to mapped memory, and treats the shared memory handle mostly as an opaque blob, sometimes duplicating for passing across processes, or passing it to wrap it in another VideoFrame. This latter wrapping also complicates ownership, as it implies that the shared memory must be owned externally. Because of this, the ownership of this kind of handle is external to the VideoFrame. The shared memory backing this use of VideoFrame is sometimes claimed to be read-only, and sometimes writable ("unsafe" in the jargon of the current shared memory API). This has lead to bugs (crbug.com/797470 and crbug.com/888153). While there may be a way to refactor so that read-only shared memory can be used where appropriate, that is beyond the scope of this CL. Here we just make the unsafe shared memory usage explicit, and clean up the API in a way that will hopefully make it easier to extend in the future. The core goal of this CL is to refactor VideoFrame to remove use of the legacy shared memory API, which forces permissions and ownership to be explicit. This CL does not change use of the mojo SharedBufferHandle API, which is strongly owned but hides region permissions (although they are strongly checked). A summary of the change is as follows. (1) VideoFrames are explicit about being backed by unsafe shared memory, and VideoFrame creation is cleaned up. Previously, data backed by shared memory was created with a WrapExternalSharedMemory factory, except in some cases where the frame was created with a different kind of external memory (eg, WrapExternalYuvData) and then a shared memory handle was shoved in with AddSharedMemoryHandle. After this CL, a VideoFrame backed by shared memory is first created with the appropriate WrapExternal* call, and then explicitly backed with unsafe shared memory. This makes current usage clear and will allow for different kinds of shared memory (read-only, writable) to be used in the future expressed without causing a combinatorial explosion of factory methods or parameters. (2) Changing the VideoFrame creation API implies changing consumers to use the new shared memory API and to be explicit about shared memory permissions. (3) Remove media::SharedMemoryHandleProvider (an implementation of VideoCaptureDevice::Buffer::HandleProvider). This class effectively confused uses of read-only and writable regions, and practically was used mostly as a utility routine for converting different types of buffer handles. (4) Additional cleanup in code that managed shared memory regions, particularly those that duplicate regions, which now the new permissions used by VideoFrame. TODOs which noted that regions were being duplicated read-write when they should be duplicated read-only are addressed: in some cases, the regions can now be duplicated read-only; in other cases the comment was incorrect and the region in question must be duplicated writable. In these cases an attempt has been made to document the use cases that demand a writable handle. Affected classes that manage shared memory regions are: * VideoCaptureBufferPool * VideoCaptureBufferTracker / SharedMemoryBufferTracker Unfortunately, the nature of these changes makes it impossible to break this change into small pieces. In particular, the shared memory permissions are all inter-dependent, and the strong checking done by the new shared API as well as mojo::ScopedSharedBufferHandle make it impossible to update usage piecemeal. A future change could add read-only shared memory to a video frame, and use that for the encoder input buffer, which in theory only needs read-only access. However, in current practice that is not the case: (a) crbug.com/888153 shows that some hardware encoders require writable shared memory regions. (b) ExternalVideoEncoder passes unsafe regions as the input frame, taken via a CreateVideoEncodeMemoryCallback from a legacy SharedMemoryHandle. The callback is also used to create output regions (which must be writable). Fixing this inconsistency requires a larger refactoring, also because CreateVideoEncodeMemoryCallbacks are passed around in other cases. (c) GpuArcVideoEncodeAccelerator takes a raw handle to create an input frame for VEA::Encode. This is not a read-only region. ArcVideoEncoder is in Android branches for ChromeOS (called pi-arc-dev and arc-nyc-mr1). The file descriptor today is writable because we copy plane data to the fd on the Android side for various reasons (conversion, etc). [1] https://docs.google.com/document/d/1lk2-7W7Cy7FDqG-6lgS8LRkzXABYTOytf6VUsWNf8-0/edit#heading=h.7nki9mck5t64 Bug: 888829, 849207, 843117, 795291, 803136, 793446 Change-Id: I776902f1b82c0b96e9916bcd59afdf4b3df89a91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680188Reviewed-by:Bill Budge <bbudge@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Reviewed-by:
Christian Fremerey <chfremer@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Matthew Cary (CET) <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#681316}
-
Stephane Zermatten authored
This change marks the following RPCs with enough information to figure out whether they've been triggered by direct actions: When SupportsSite is called from a Chrome CCT created for AA, this change sets ClientContext.is_cct. When a script is run by using a direct action, instead of the UI, this change sets ClientContext.direct_action The two are necessary, as it is possible to use direct actions on a AA started by CCT. It is possible to use the UI to answer prompts triggered by a script run by a direct action. Additionally, when a prompt choice is made by using a direct action, instead of the UI, this change sets ProcessedActionResut.direct_action Bug: b/138292695 Change-Id: I196d9d7492cc27fce164e9a671cf794732bf1d21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715379 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#681315}
-
Carlos Caballero authored
MessageLoop will go away, eventually. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you belive your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=wychen@chromium.org Change-Id: Iec9eda1a1ec8fa5412704dc41be9f486a1f68f05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649581 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
-
Pavel Shmakov authored
It was kept to keep downstream intact, now can be deleted Bug: 916542 Change-Id: I400c2dec8f4d9eba053e85701f4eb726c97107e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718964 Auto-Submit: Pavel Shmakov <pshmakov@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#681313}
-
Rune Lillesveen authored
An element is added to the set if a child is removed in order to force an update of whitespace siblings. Removing a child doesn't cause a style recalc or layout tree rebuild, but removing an inline element between say two whitespace nodes makes one of the whitespace LayoutTexts unnecessary. We keep this set until the next lifecycle update and marks the elements in the set for layout tree rebuild to reach the whitespace children. We skip these nodes if the layout object had been detached in the meantime. What happens here, however is that we didn't remove the elements from the set when the elements were removed from the document. In this case it is even adopted into a different document and gets a new layout object in that document's layout tree. When the original document gets its lifecycle update, we try to rebuild the layout tree of the element which is now in a different document and DCHECKs fail for style dirtiness. Bug: 981384 Change-Id: I26fe3a8ac2c6b8994e6d4ad9593a8476422a0535 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719345Reviewed-by:
-
Sam Maier authored
Bug: 910319 Change-Id: Ic9a9fa2be934d95aee31a7f1440890d6a9fa2697 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717694 Commit-Queue: Sam Maier <smaier@chromium.org> Auto-Submit: Sam Maier <smaier@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#681311}
-
Colin Blundell authored
Bug: 987965 Change-Id: I29b50b988983b2ec8ef976370a576af426dedbbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720833Reviewed-by:
-
David Bokan authored
These metrics have been useful from time-to-time over the years to answer questions about how users zoom; most recently in the last 2 weeks. Bug: 975221 Change-Id: If9e251c0e4396b5914e2e9a3d322f1fc6cfe0476 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678380Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Auto-Submit: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#681309}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/424fc331f3be..9a69857888af Created with: gclient setdep -r src-internal@9a69857888af The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I7d18872ae2b2f88f4c9c5e1c3b8d45c97029ecbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720989Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#681308}
-
chrome://policyYann Dago authored
Bug: 986380 Change-Id: Ib4ed402900f28036d94bb36d8660f895f44fcc6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715666Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#681307}
-
Ayu Ishii authored
This change adds UMA tracking for SMSReceiver API to give us data on friction and performance of UI decisions made for this feature. Because there was some disagreement between adding the user interaction after a successful call, this will give us a better idea of what kind of impact the UI has or doesn't have. Specifically it will track the following. 1. Duration between the time a SMS is successfully received and when the user selects Continue. 2. Duration between the time a SMS is successfully received and when the user selects Cancel. More details on metrics and its motivation here in the API Design Doc [1]. [1] https://docs.google.com/document/d/1dB5UM9x8Ap2-bs6Xn0KnbC_B1KNLIUv4W05MunuXYh0/edit#heading=h.bbporvvwzoo7 Bug: 976332 Change-Id: Id689c9937c17a9dc930cce89ba0965e8f20a96d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716961Reviewed-by:
Jun Cai <juncai@chromium.org> Commit-Queue: Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#681306}
-
Gauthier Ambard authored
Sometimes the doodle height on the NTP is changing. If this is occurring while the omnibox is focused, the stored offset of the collection view is too big and upon unfocusing the omnibox the NTP is too much scrolled. Bug: 986763 Change-Id: Ia2c641f547f6bb8780143f4edf5a94f09b9bc5bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720814 Auto-Submit: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by:
Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#681305}
-
Noel Gordon authored
Two WPT autorolls and no joy on their expectations. Mark these tests a Pass Failure on all bots to green the chromium tree webkit tests. No-try: true No-presubmit: true Bug: 987915 Change-Id: If7c28237cdd7a10d48d058da864279332308edeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720840Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#681304}
-
Liquan(Max) Gu authored
Current, we assume that |ShouldWalkCheck| wouldn't change during the lifetime of |ScopedPaintTimingDetectorBlockPaintHook|. It turns out that it can, for unknown reason. A temporary fix is to redo |ShouldWalkCheck| at the close of the scoped hook. Bug: 983860 Change-Id: I524a1a6281107ac87fc5a517009cd93be7426574 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719448Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#681303}
-
Stepan Khapugin authored
* Ensures omnibox popup shortcuts egtests compat with EG2 * Adds a new EG2 target and adds shortcuts tests to ios_chrome_eg2tests * Cleans up shortcut egtest deps Bug: 866147 Change-Id: I3c004889b230e7590a62d5f4ab062cb6103456f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698420 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#681302}
-
Daniel Bratell authored
We see autofill tests take between 30 and 30000 milliseconds and that is probably disk I/O. Switching to a memory database makes the tests much faster, though it's unclear what the cause of the 30 second tests is. Change-Id: Ie4a7d331f6b2dead3649e406a039ea68ce188990 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718325Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Auto-Submit: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#681301}
-
Kurt Horimoto authored
Snapshots are normally captures in MainController's |-prepareTabSwitcher|. When links are opened via the context menu in a different ApplicationMode, it is opened without entering the tab switcher and the snapshot for the previous WebState might be stale. Bug: 978400 Change-Id: Ifaf1b5dec80e2a139cdbe3a0f34ae51f3fae54c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716039 Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#681300}
-
