- 18 Feb, 2020 40 commits
-
-
Gauthier Ambard authored
The launch mask was used to prevent the user from seeing the TabGrid when a tab should have been presented as it is not possible to directly show the BVC when it is presented. Having it contained allow to remove this workaround. Bug: 1038034 Change-Id: I2cc74afe5d00406d1be4de20ed7e96f50cd839a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061759 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#742141}
-
Fredrik Söderquist authored
Split said method into two - one that does a cache lookup and one that builds the GradientData. Reorder the code a bit to eliminate the redundant check for an empty object bounding box. Bug: 109212 Change-Id: If9bdf1d771478d208debbdddf33188b5db28cf62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060956Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#742140}
-
Omer Katz authored
The static_cast from WeakMember to Member actually constructs a Member. If this happens on a concurrent thread, it will fail during Member creation in SaveCreationThreadState (creation_thread_state_ is nullptr). Bug: 986235 Change-Id: I5d2edf3b714313a9d23663fb805f3bf8486e8f4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061248 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#742139}
-
Finnur Thorarinsson authored
As per documentation, it should be released as soon as we're done with it. Bug: 895776, 656015 Change-Id: Icbdcdb0fb515070d00cde1f7fac52ce1ab594993 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056811Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Auto-Submit: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#742138}
-
anina koehler authored
The contrast ratio should be at least 4.5 on all text. On the initialization screen of the Kiosk app it was too low on one of the strings. The color of one string was changed from gray to #666 (same as the other strings on that screen) which increases the ratio from 3.94 to 5.74. Bug: 1015832 Change-Id: I53f14c5f7831b9a7c54d817e2b28d1a277c59954 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036054 Commit-Queue: Anina Koehler <aninak@google.com> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#742137}
-
Gauthier Ambard authored
This CL adds the animations for entering/leaving the TabGrid when the motion is reduced. It also adds a parameter to be able to present it with no animations. Bug: 1038034 Change-Id: Idf7d4f48049137007ed9f76bae2828eb90322c22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061156 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
-
Keishi Hattori authored
Convert IDBTransaction back to ExecutionContextLifecycleObserver after crrev.com/c/2060361 IDBTransaction uses ExecutionContextLifecycleObserver to avoid accessing ExecutionContext from the destructor. TBR=haraken@chromium.org No-Tree-Checks: true No-Try: true Bug: 1052319 Change-Id: I055550fb310e59ac99438faa7dff268d4efc6003 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060447Reviewed-by:
Keishi Hattori <keishi@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#742135}
-
Philipp Hancke authored
adds a test case for https://github.com/w3c/webrtc-pc/pull/2155 BUG=944821 Change-Id: Idee2e83cd6dbd217802698db46fe94b6ca0f0791 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059972Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com> Cr-Commit-Position: refs/heads/master@{#742134}
-
Hiroki Nakagawa authored
This CL adds NOLINT(build/header_guard) in header files used for generating enum values to suppress Tricium warning. The comments and guard code are copied from net/base/net_error_list.h Bug: n/a Change-Id: I88df01fe3427a8b2702813457e391a18185adfaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061929Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#742133}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e22500101fbd..f0e349172618 git log e22500101fbd..f0e349172618 --date=short --first-parent --format='%ad %ae %s' 2020-02-18 tvanderlippe@chromium.org Revert "Extract `toBase64` into `StringUtilities`" 2020-02-18 wolfi@chromium.org Revert "Reland "Use 1000 not 1024 for kB and MB calculations"" 2020-02-18 jacktfranklin@chromium.org Fix TS build checking for bridge files 2020-02-18 jacktfranklin@chromium.org Extract `toBase64` into `StringUtilities` 2020-02-18 tvanderlippe@chromium.org Fix TS + Ninja integration 2020-02-18 wolfi@chromium.org Fix layout issue in add-location-table 2020-02-18 kimanh@chromium.org [devtools] Make wasm source url clickable 2020-02-18 wolfi@chromium.org Reland "Use 1000 not 1024 for kB and MB calculations" Created with: gclient setdep -r src/third_party/devtools-frontend/src@f0e349172618 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1011811,chromium:1035309,chromium:1050549 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I9a08956696b386273e0abe9566e7734cffb7ba8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061202Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#742132}
-
henrika authored
It is now more clear that this method can in fact return 0 for some unique input parameters. Tbr: olka Bug: 1052825 Change-Id: Ib7aaa66ea2f37b45fffdde89a1835ccc511d5edb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060294Reviewed-by:
Henrik Andreasson <henrika@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Henrik Andreasson <henrika@chromium.org> Cr-Commit-Position: refs/heads/master@{#742131}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c61c289c9c70..5efe7f09dc4d Created with: gclient setdep -r src-internal@5efe7f09dc4d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I7d4bc181d6ef55449a64e3108f74305393b0128b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061201Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#742130}
-
Marc Treib authored
Bug: 1052983 Change-Id: I9c40475de027c1d7e734d142d5bbbbdaaf5e700f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061753 Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#742129}
-
Wez authored
Fuchsia's GN SDK provides the "compiler" configuration, but Chromium needs to override some stack properties, so retain the Chromium custom "compiler" config and have it depend upon the SDK-provided one. Bug: 1050703 Change-Id: Ia520eca69585e1ed1ed3e21bd4f62a005fbc5acd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060372Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Wez <wez@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#742128}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4af17e434cdc..78b471760dd9 git log 4af17e434cdc..78b471760dd9 --date=short --first-parent --format='%ad %ae %s' 2020-02-18 benjaminwagner@google.com [infra] fix recipe bug Created with: gclient setdep -r src/third_party/skia@78b471760dd9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: lovisolo@google.com Change-Id: Id512f7d6311195e3834cb4c3291f72318adaa0e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062148Reviewed-by:
-
Eliot Courtney authored
This CL makes sure presentation callbacks are sent for destroyed buffers in WaylandBufferManagerHost. If a buffer is destroyed, we may not receive a presentation callback. Instead, send gfx::PresentationFeedback::Failure for destroyed buffers. This CL makes the following changes: a. Move feedback from WaylandBuffer to the presentation queue. Feedback is a property of presentation, not of the buffer. If it's possible for presentation feedback to be delayed then this fixes a potential bug where feedback can get lost. b. Send gfx::PresentationFeedback::Failure for destroyed buffers. c. Adds a test for this behaviour. Bug: 1051420 Test: resizing chrome does not cause a DCHECK in OnPresentation. Change-Id: I596f0deceadfffe74d35845046b956869908780f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056169 Commit-Queue: Eliot Courtney <edcourtney@chromium.org> Reviewed-by:
Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#742126}
-
Koji Ishii authored
Following bot results are included. 1434 1437 1439 1441 1444 1445 1446 1447 1448 1449 1450 1451 1452 1456 1457 1458 1459 1460 1461 1462 1463 1464 1465 1466 1467 1468 1469 1470 1471 1472 1473 1474 1475 1476 1477 33 lines were removed and 23 lines were deflaked by consecutive results since 1462. TBR=yosin@chromium.org NOTRY=true Bug: 982194 Change-Id: I4d58447c49239a39493f21dd6f7a2cb7bfb764ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056006Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#742125}
-
Christian Dullweber authored
Create PageInfo in a new tab to avoid flakiness due to navigation events. Bug: 1052395 Change-Id: I13d03a8696fcb39ce951052d6015b9880871cf9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060958Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 130dc38a. With Chromium commits locally applied on WPT: acd8a467 "SharedWorker: Use CSP headers to outside settings" ec83d167 "Update performance.measureMemory to the latest proposal" d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I355e31c0f4836114d3f686e04cee953fc7b0b3c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062089Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#742123}
-
Gauthier Ambard authored
This CL fixes the TabGrid animation by animating the toolbar disappearance. Fixed: 1042200 Change-Id: I21ee9f900986cbe421a1a39afb0fc24eb20ee38e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061149Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/961ac1ae..7f0638a9 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I71175fdeadd6ccb897b886a2a0fa4a0f701df468 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062088Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#742121}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/7efa03ac94b5..e96da533c5df git log 7efa03ac94b5..e96da533c5df --date=short --first-parent --format='%ad %ae %s' 2020-02-18 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-validation-layers/src 211ee9c4eec1..873e416c2d07 (3 commits) 2020-02-18 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-loader/src c731adec183b..0bd30e43c007 (1 commits) Created with: gclient setdep -r src/third_party/angle@e96da533c5df If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cwallez@google.com Change-Id: If78eeac28a2416c4b5ba68b70ef03a33413187ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061199Reviewed-by:
-
Andrew Solovey authored
Add a new Chrome OS policy that allows admins to prevent access to Google web properties in an unauthenticated state. This policy will force logout users with invalid Gaia LSTs. Bug: b/146461662 Change-Id: I064aae7fadf62f9239600fd45af45062f413f562 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016628 Commit-Queue: Andrei Salavei <solovey@google.com> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#742119}
-
Mikel Astiz authored
This reverts commit b6a3c9f3. Reason for revert: bookmarks created around 2016, between [M44..M51] use an uppercase GUID as originator client item ID. Original change's description: > Enforce lower-case use of GUIDs for sync > > base::GenerateGUID() produces lower-case GUIDs and they should get > exposed to the sync protocol exclusively in this canonical form to avoid > running into issues. > > This patch replaces all occurrences in sync codebase with: > git grep -l 'IsValidGUID' -- components/sync* | \ > xargs sed -i 's/IsValidGUID/IsValidGUIDOutputString/g' > > In addition, the implicit GUIDs used for bookmark sync, in particular > for permanent nodes, are updated to adopt lower-case GUIDs. These are > never committed to the server so there are no backward-compatibility > considerations. > > Change-Id: I0d0468f3475e1a27a161e2af15853c757f53e201 > Bug: 978430 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054154 > Reviewed-by: Marc Treib <treib@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Mikel Astiz <mastiz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#741381} TBR=sky@chromium.org,treib@chromium.org,mastiz@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 978430 Change-Id: If3a135e24cb61d15cfc7616dd1160e76ce9dd3e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061749Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#742118}
-
Jan Wilken Dörrie authored
This change adds the DatabaseCompromisedCredentialsObserver and CompromisedCredentialsConsumer interfaces to CompromisedCredentialsProvider, allowing it to monitor changes to the compromised credentials table in the database. Bug: 1047726 Change-Id: Ia3a9b5216fb25e563e96c6f8b1cf6e7f8a028d01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060670 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#742117}
-
Marian Fechete authored
This CL introduces a new AutofillAssistantState called BROWSE, which allows users to browse around on a website while the AutofillAssistant waits in a prompt-like state. Currently, this in implemented as a browse mode (bool) on PromptAction, but it could be refactored to its own action in the future. Gestures such as GoBack do not terminate the BROWSE state like they do for PROMPT. However, navigating to a different domain will terminate the AutofillAssistant. Preconditions are still checked, but there is no overlay or touchable areas in browse mode. Also, navigation and user gesture filtering as applied when in PROMPT is not applied for BROWSE so that autofill assistant does not terminate in those cases. Also adding unit tests for both PROMPT state and BROWSE state for the controller, script executor, and prompt action. This is based on a prototype by Mathias Carlen <mcarlen@>. Bug: b/147412447 Change-Id: Ieeee6207ab72bec38363ddc9dee031602ea78e6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056726Reviewed-by:
Clemens Arbesser <arbesser@google.com> Commit-Queue: Marian Fechete <marianfe@google.com> Cr-Commit-Position: refs/heads/master@{#742116}
-
Anders Hartvoll Ruud authored
There is currently a bug where selectors such as 'div | .c' matches a .c-descendant of div. This is because of a bug in the parser, where the '|' is consumed as part of the failing branch of CSSSelectorParser:: ConsumeName. This CL changes the behavior to look ahead at the token after the pipe delimiter: if it's not an <ident> or '*', we consume nothing and leave the '|' unconsumed. This causes subsequent parsing attempts on the CSSParserTokenRange to fail. We had one test (non-WPT) that tried to use selectors such as tns|#testInsertRule, but this is actually not valid. (Sidenote: the test failed in Firefox). Added '*' to make it valid. Bug: 1052847 Change-Id: I51e6a67a5e44cf3c0fe9d9fc7abea3772d0f4d9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058814Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#742115}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a8bd7a17cf77..c61c289c9c70 Created with: gclient setdep -r src-internal@c61c289c9c70 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I308992c18478384a9d886f8fce135f1e3f7aa2c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061804Reviewed-by:
-
Olivier Robin authored
Only the current NTP should receive the keyboard events. Replace the broadcast of notification by a direct call. Bug: 1032999, 778008 Change-Id: I8d42fac5fe81cd08fc56742ebe01abe0989ff5c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039412Reviewed-by:
-
Keishi Hattori authored
Rename ContextClient to ExecutionContextClient to match ExecutionContextLifecycleObserver Bug: 1052738 Change-Id: I87d3aea8cc0b940633f1ffe27bd484c0d7d9fa7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062008Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#742112}
-
Christos Froussios authored
The icon will be reused for payment methods other than credit cards. Bug: 986289 Change-Id: Ied7c8486a265d5e63f793343e267793e3280780f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060668Reviewed-by:
-
Jack Franklin authored
`escapeCharacters` used to be a function we put on `String.prototype` but as of a recent CL [1] it is now not. To avoid confusion, I've renamed the test function that this test uses to be obviously a dummy function for testing purposes. [1]: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2056475 Change-Id: I065b61d45bf77124b9db84920fcf662019d0398b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057069Reviewed-by:
Mathias Bynens <mathias@chromium.org> Commit-Queue: Jack Franklin <jacktfranklin@chromium.org> Cr-Commit-Position: refs/heads/master@{#742110}
-
Maksim Moskvitin authored
DeprecatedInvalidatorRegistrar is a part of the legacy implementation of invalidations. This CL removes it and replaces remaining usages with InvalidatorRegistrarWithMemory. Bug: 1029481 Change-Id: Ic0e8733c096ee327c82a5aeaeea7cbf8be3bcb2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056727Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Stuart Langley <slangley@chromium.org> Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#742109}
-
Vasilii Sukhanov authored
This reverts commit 0de7bdfe. Reason for revert: UMA may want to use HTTP Original change's description: > Enforce https for all googleapis.com endpoints. > > That question came up during security review. We should enforce HSTS at least > for the password leak check API. However, it's benificial to enforce it for all > possible APIs. > > Bug: 1049177 > Change-Id: Ieacb6675c195c89606cc3a8d956bdfa855b8b64f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057125 > Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> > Commit-Queue: Nick Harper <nharper@chromium.org> > Reviewed-by: Nick Harper <nharper@chromium.org> > Cr-Commit-Position: refs/heads/master@{#741576} TBR=vasilii@chromium.org,nharper@chromium.org,cthomp@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1049177 Change-Id: I34828caed420ef7705b733d5a608ca0deb94f3bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060955Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2988bc84. With Chromium commits locally applied on WPT: acd8a467 "SharedWorker: Use CSP headers to outside settings" ec83d167 "Update performance.measureMemory to the latest proposal" d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching" 145f7594 "[NativeFS] Enable storing handles in IndexedDB." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I80281408befed99192211cfabacdc092bb1e692d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061869Reviewed-by:
-
Simon Zünd authored
Asynchronous source mapping requires asynchronous live location. Links to CSS files use live locations. Therefore, dumping styles that contain links need to properly await pending UI updates. This CL prepares all web tests in http/tests/devtools/elements/* for this upcoming asyncification by awaiting * ElementsTestRunner.dumpSelectedElementStyles * ElementsTestRunner.dumpComputedStyles Note that we can not use {then} syntax as these methods do not yet return actual promises. This CL is a straight up mechanical change that adds adding async/await to all call-sites. Bug: chromium:1032016 Change-Id: I1285bae6125e1c3b3f3857eb32368ef96653c212 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061748 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by: -
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/d353ca088149..e51f8dd09af0 git log d353ca088149..e51f8dd09af0 --date=short --first-parent --format='%ad %ae %s' 2020-02-18 cwallez@chromium.org Fix compilation with stdlibc++ (instead of libc++) Created with: gclient setdep -r src/third_party/dawn@e51f8dd09af0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Ifd6219f1b6c06ab2126876f80b71d27a5db581a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061801Reviewed-by:
-
Nazerke authored
Tab Page Coordinator. This CL modernizes the ContentSuggestionsCoordinator and NewTabPageCoordinator - use the superclass -initWithBaseViewController:browser: initializer, instead of -initWithBaseViewController:. - remove the public property for dispatcher, browserstate. - use self.browser to get dispatcher, browserstate values. Bug: 1029346, 1048398, 1048421 Change-Id: I63833d751d9ed6031a9b7d502a7fbfe2fdc203b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035991Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Cr-Commit-Position: refs/heads/master@{#742104}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f78c3a6a..961ac1ae Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ide4ace361118d243bc94957e11df0155ab3b1b5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061868Reviewed-by:
-
Alice Wang authored
This CL fixes the bug that ConfirmManagedSyncDataDialog throws NPE when it is recreated. Bug: 1033911 Change-Id: Iecc87fdb04026e0e86c7c964ef16132a870c885c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057066Reviewed-by:
-
