- 13 Nov, 2019 40 commits
-
-
nancy authored
Add PauseApp and UnpauseApp interfaces to AppService mojo, and publishers. For extension apps and ARC apps, set the icon effects for the paused apps. The icon effect is set based on the paused field of App structure, so pass the AppRegistryCache to ExtensionApps, to check the App's paused status. For ARC apps, the AppRegistryCache can get from AppServiceProxy. BUG=1011235 Change-Id: Iced5e0f36ba5b1d036fd2431e5810832c59d423a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906851Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#714782}
-
Jeevan Shikaram authored
This CL apps the app IDs of Android default apps and their default app order. Bug: 1013730 Change-Id: I37ce1aa1633e6a1f4be27a4de2514d2c64a8a0e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909667Reviewed-by:
Yury Khmel <khmel@chromium.org> Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Cr-Commit-Position: refs/heads/master@{#714781}
-
Xiaoqian Dai authored
Bug: 1024031, 997885 Change-Id: Ic12b34115036de7a22fd29d8fe207f16bc07a15d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912690Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#714780}
-
Tommy Nyquist authored
Up until now, LevelDB Proto DB has shared the bug component with the rest of Internals. This CL changes it to use the newly created Internals>Storage>LevelDBProto bug component. Bug: 1023496 Change-Id: Ief55a3616d90e6a6790ad21fc7935a5a2753eb38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907078 Auto-Submit: Tommy Nyquist <nyquist@chromium.org> Commit-Queue: ssid <ssid@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#714779}
-
Wez authored
Change-Id: I835c23132ddf9eaec25c6e8e49c3a14096340b34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906883 Auto-Submit: Wez <wez@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#714778}
-
Nate Fischer authored
TV/car devices (any device which uses standalone WebView instead of monochrome) have a bug on N-P where we preinstall the release-keys signed WebView instead of the "developer test keys" signed WebView on dev-keys signed builds. This is a surprising gotcha when folks need to work on TV (especially since there's only one valid WebView package name, so developers are guaranteed to hit this). This documents this edge case and provides guidance for how to work around this. Bug: 918221 Test: tools/md_browser/md_browser.py android_webview/docs/build-instructions.md Test: Upload to gerrit > open file > click "gitiles" Change-Id: If19a6cea88177cee831ec0aaaeda79169ee4177a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912787 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#714777}
-
Christian Dullweber authored
Bug: 1022562 Change-Id: Ib3863135ea0b4cbb105b24ad89b9c7049b7f6e75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911199 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Huanzhong Huang <huanzhong@chromium.org> Cr-Commit-Position: refs/heads/master@{#714776}
-
Bailey Berro authored
Mark the tooltip as aria-hidden since it is read as the description for the dropdown. Bug: 1024004 Change-Id: I23ee342ce23275a805d7ab46c40a5ae3fc5b867a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913082 Auto-Submit: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#714775}
-
Trent Apted authored
This is a reland of f8dd1ecf Reverted inadvertently in r714447. Different root cause (https://crbug.com/1023525). Original change's description: > Capture test_api.js javascript dependencies in 2 places (rather than ~13). > > test_api.js depends on a bunch of JS libraries that appear in many lists. > > This CL consolidates those dependencies to two places: > - js2gtest.gni, and > - A JsTestApiConfig class declared in chrome/test/base/js_test_api.h > > Note not all lists captured the axs_testing.js dependency, but this change > uses the same dependency list in all locations for consistency. > > TBR=aboxhall@chromium.org (mechanical change) > > Bug: 1000989 > Change-Id: If6e0716c03e42783a2d3529baa70475a9d305045 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900512 > Commit-Queue: Trent Apted <tapted@chromium.org> > Reviewed-by: Dan Beam <dbeam@chromium.org> > Reviewed-by: Colin Blundell <blundell@chromium.org> > Cr-Commit-Position: refs/heads/master@{#714421} TBR=tapted@chromium.org,dbeam@chromium.org,aboxhall@chromium.org,blundell@chromium.org,nuskos@chromium.org Bug: 1000989, 1023795 Change-Id: I8488e9668614bae07b40d65ab2d80f6b01b85ef4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913221Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#714774}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/1afa8b609752..96befae82483 git log 1afa8b609752..96befae82483 --date=short --no-merges --format='%ad %ae %s' 2019-11-12 thestig@chromium.org Switch to C++14 by default. 2019-11-12 thestig@chromium.org Roll v8/ 9ddd0c4c1..a423bb8be (1234 commits) 2019-11-12 thestig@chromium.org Fix crash in FPDFPageObj_GetFillColor(). 2019-11-12 thestig@chromium.org Add another test for FPDFText_GetFontWeight(). Created with: gclient setdep -r src/third_party/pdfium@96befae82483 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=pdfium-deps-rolls@chromium.org Bug: None Change-Id: Iac0e17c837d59966510891e712d0f50a46b29fe8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913546Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714773}
-
Lambros Lambrou authored
The Me2Me native-messaging host has a command-line option: --check-permission to check for host permissions. This CL updates this to run the permission-wizard. Bug: 1015201 Change-Id: Ie936de8fae413567b5260cde5fb62b0a5803712e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913473 Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Cr-Commit-Position: refs/heads/master@{#714772}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/edafde28..29e7d3ba Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie3b844da6c01b8fd3e438353015ded972b5cbc5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913105Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714771}
-
rbpotter authored
Split KeyboardShortcut and KeyboardShortcutList out of command.js, and update them to use es6 class syntax. These classes do not contain any ui and do not depend on cr.ui.define() so should be straightforward to migrate to Polymer 3, unlike cr.ui.Command itself. Moving them to a separate file allows the FindShortcutBehavior and the bookmarks CommandManager to depend on only keyboard_shortcut_list.js and not on command.js. Bug: 1022213 Change-Id: I5478f7ac5820f5316ff8a07d047bdf20f76210cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907773 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#714770}
-
Brian Sheedy authored
Restricts manage_render_test_goldens.py to only uploading images that are expected to be golden images. This is achieved by looking for device/SDK pairs in the filename. This is to prevent random images that happen to be in the directory from being uploaded when they shouldn't be. Bug: 1022632 Change-Id: Iead7b574f38b73a88994d2a6e9f61fdcd72b4ea5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913571 Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#714769}
-
Jeevan Shikaram authored
Add missing polymer binding. Bug: 1008121 Change-Id: I881dbec7fa9571c70eb571db9b19b2c46f5c7a02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911069Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Cr-Commit-Position: refs/heads/master@{#714768}
-
Jack Lynch authored
This CL fixes and re-enables tests that will be broken by https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1884528 Bug: 963183 Change-Id: Ia783efb3b292a143108cf92def3821c6f22893fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811866Reviewed-by:
Lorne Mitchell <lomitch@microsoft.com> Commit-Queue: Jack Lynch <jalyn@microsoft.com> Cr-Commit-Position: refs/heads/master@{#714767}
-
Mia Glaese authored
Setting IS_SHOWING_OVERVIEW to false triggers the TasksSurfaceViewBinder to set visibility to GONE. Setting the TasksSurface visibility to GONE shifts focus to its parent view. This implicitly unfocuses the LocationBar, which triggers the UrlFocusChangeListeners. The StartSurface UrlFocusChangeListener calls StartSurface.notifyStateChange(). Here we crash on "assert mPropertyModel.get(IS_SHOWING_OVERVIEW)", since it's already set to false. Swapping the two lines resolves the issue. Bug: 982018 Change-Id: I84f8634871c6990ec6440684a7fe53498c38fe14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911102 Commit-Queue: Mia Glaese <glamia@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#714766}
-
Keishi Hattori authored
TBR=dbessonov@yandex-team.ru,wangxianzhu@chromium.org Bug: 1023683 Change-Id: I5be711b3823230e1887a154b38577c9f46f64d59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911341Reviewed-by:
Keishi Hattori <keishi@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#714765}
-
Adam Rice authored
Add the use counter FetchBodyStreamInServiceWorker which is triggered when the body getter is accessed in the Response class. The purpose of the use counter is to evaluate the potential benefit of Response body stream optimisations. Change-Id: I625bb08712f6fc1996def8bdab52a449fc725f07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909675Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#714764}
-
Dale Curtis authored
BUG=954850,1023844 R=mcasas, tmathmeyer Change-Id: I0f224070ccc179a2219690f063301359ef0197ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913575 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Ted Meyer <tmathmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#714763}
-
Dale Curtis authored
Similar to 90a508cd, these values may occur in the wild and should be avoided. R=tguilbert Change-Id: Id30a7175649c399ddb3f6c78e29c9beac55c00ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913600 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#714762}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/3992f656421f..0bbd6ee7bb63 git log 3992f656421f..0bbd6ee7bb63 --date=short --no-merges --format='%ad %ae %s' 2019-11-12 bsheedy@chromium.org Add global artifact logger Created with: gclient setdep -r src/third_party/catapult@0bbd6ee7bb63 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=nuskos@google.com Bug: chromium:1008075 Change-Id: I8fda2952513b11c18c4af30e9b33feb53ef1f3d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913541Reviewed-by:
-
rbpotter authored
Remove unnecessary extraLibraries from ModelSettingsAvailabilityTest. These were accidentally left in when Print Preview was migrated to Polymer 3, and cause the test to throw JS exceptions. Bug: 1012574 Change-Id: Ifa3a3492231f14acd8d1b6b70fc26334d3dfbb9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912827Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/59fa599a2a59..88632cac30e1 git log 59fa599a2a59..88632cac30e1 --date=short --no-merges --format='%ad %ae %s' 2019-11-12 bclayton@google.com Regres: Don't treat non-zero error codes as crashes. Created with: gclient setdep -r src/third_party/swiftshader@88632cac30e1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: None Change-Id: I30ce69833da59e782b8c1feb991fb875bda3ef2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913545Reviewed-by:
-
arthursonzogni authored
Replace: FrameHostMsg_DidAddContentSecurityPolicies (IPC) By: FrameHost.DidAddContentSecurityPolicies (mojo) This corresponds to step 1.e from the "Unify CSP" document: https://docs.google.com/document/d/1v5mJnXJ5dSVXE_rgvJnNM9bzH0ni0YzdhPQ7GLqyhao The native struct are going to be converted in a series of follow-up. Bug: 1021462 Change-Id: Ie77c21206c5a40535383c5c318458545930d3465 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905689 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#714758}
-
Xiaoqian Dai authored
Bug: 997885 Change-Id: I1683b06cc4fd46cdfa46c681cf725157c0fb07f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912884 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8c1e0effbbe1..9501212cd058 git log 8c1e0effbbe1..9501212cd058 --date=short --no-merges --format='%ad %ae %s' 2019-11-12 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-11-12 herb@google.com Force single glyph calls through bulk interface 2019-11-12 rosasco@google.com Reland fully delineate GL usage w/ skia_use_gl. 2019-11-12 csmartdalton@google.com Fix detection of when we will have mixed sampled coverage Created with: gclient setdep -r src/third_party/skia@9501212cd058 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC halcanary@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=halcanary@google.com Bug: None Change-Id: I8f8ad7b3714fc3e0009b0a9a27800e508cbc179d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913540Reviewed-by:
-
Yi Xu authored
TBR=danakj@chromium.org Change-Id: I1b99bd50cc3d78ede44f5b46ff2ffe10c7dfdadb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907075 Commit-Queue: Yi Xu <yiyix@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#714755}
-
Doug Arnett authored
Currently the blocklist checks hide other interesting EligibilityReasons from being logged to UKM (such as hint match and triggering ECT) that could prove helpful in knowing more about hint availability and also more clearly that when a preview would have been triggered except for the local blocklist. This refactor pushes the blocklist checks to after these other triggering checks (but still before the coinflip check). Bug: 1023611 Change-Id: Ica2e75f8099674a2767141e5234747fd10a7d4bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912143Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#714754}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/dcc910a2095d..f47c2ab889d9 git log dcc910a2095d..f47c2ab889d9 --date=short --no-merges --format='%ad %ae %s' 2019-11-12 mbonadei@webrtc.org RTC_EXPORT webrtc::RTCNonStandardStatsMember<T>. 2019-11-12 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 3b0967fe..0717a4dc (714463:714607) 2019-11-12 thaloun@chromium.org Don't ask for the friendly name of a default device if we failed to enumerate it. Created with: gclient setdep -r src/third_party/webrtc@f47c2ab889d9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None,chromium:b/144233691 Change-Id: I59f911eecf553a37ac77ab448c49fd62475ef7d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913542Reviewed-by:
-
Daniel Hosseinian authored
The user manager already has access to the cloud print interface, which contains information about whether cookie based printers are disabled due to app kiosk mode. Instead of passing the app kiosk information from the sidebar to the destination settings, allow the user manager to access the desired information through a getter added to the interface. Change-Id: I7669d99fcfa2c8228de6dff42fff0e11ce1fb0c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904946 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#714752}
-
David Benjamin authored
This CL is part of a larger project to remove the LOAD_DO_NOT_* privacy load flags and replace them with the allow_credentials setting. See https://crbug.com/799935 and https://docs.google.com/document/d/1ntn9N7Ce2jozvvpWI0XbzJ7lJdwUjJXK07wp7rxrIN4 for the motivation for this change. network::mojom::CredentialMode::kOmit is equivalent to LOAD_DO_NOT_{SEND_COOKIES,SAVE_COOKIES,AUTH_DATA}. For features which did not include LOAD_DO_NOT_SEND_AUTH_DATA, this change has two implications: - The request will no longer participate in HTTP auth if the server requests it. HTTP auth credentials identify the user, so private requests should not send them. Note this only affects server auth, not proxy auth. Requests through the network service already deny HTTP auth challenges if not attached to a WebContents, so this should be a no-op for these features. - The request will be pooled with sockets used for uncredentialed requests, rather than credentialed requests. This is not expected to meaningfully change behavior. TBR=mdjones@chromium.org, wutao@chromium.org Bug: 799935 Change-Id: I6036193c0be4fa8a177a9cb79b84ca963fe435b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893957 Commit-Queue: David Benjamin <davidben@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Rachel Blum <groby@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
-
Joe DeBlasio authored
This CL updates the minimum length of a domain that is considered for an edit distance match. Edit distance is used in some cases to trigger a Safety Tip warning. Bug: 1023820 Change-Id: Ie4a18369874dbb947a5e1b41f2bf8b189b60403b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913468 Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#714750}
-
Patrick Monette authored
This avoids having tests defining their own delegate implementation when they need one. Bug: 1021600 Change-Id: I12d84c647e17c3c476ce2dc19f5298a524cf98dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900346 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
-
Aga Wronska authored
ChildUserService is a new KeyedService that will be a central point for child user related functionality. Existing KeyedServices will become members of ChildUserService. AppTimeController coordinates per-app time limits for child users similarly to ScreenTimeController. This class was added together with ChildUserService to demonstrate how other child features will be migrated. Bug: 1022231, 1015658 Test: AppTimeControllerTest Change-Id: Ica55931876f172df60b9af8a7b2887fb794f5845 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910764 Commit-Queue: Aga Wronska <agawronska@chromium.org> Reviewed-by:
-
Lily Chen authored
SameSiteByDefaultCookies and CookiesWithoutSameSiteMustBeSecure were added to the set of features enabled with --enable-experimental-web-platform-features in https://crrev.com/c/1691522. This CL removes those features from the experimental web platform features but retains test coverage for them. Bug: 953306, 954551, 961439 Change-Id: Ia13753f8f89ff5e93371c3ec9932c9d0499cd9fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904870Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#714747}
-
Aaron Colwell authored
Cleanup change to make the method parameter names match the names in the caller. The intent here is to make the code easier to understand. Bug: 1015882 Change-Id: I6dfe0ccf790a78abb6467c8fdbf13460a5aa8fc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904686 Commit-Queue: Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Auto-Submit: Aaron Colwell <acolwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#714746}
-
Min Qin authored
BUG=971366 Change-Id: Ic4f8880eec0a793c2e8a8585f3bf4d3bfda907a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912631Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#714745}
-
Giovanni Ortuño Urquidi authored
The Closure version used in Chromium now supports bounded generic types. Bug: 1015726 Change-Id: I14c080b6e3cd67cbdf564312fc1c1686f3adb1e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906691 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#714744}
-
Kyle Horimoto authored
This CL also removes maybelle@, who has left Chrome. Change-Id: I39c3c9fea40eb3608ac29b74bfd6599a71bfc355 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913560 Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
-
