- 11 May, 2018 40 commits
-
-
Mathieu Perreault authored
Change from checking the group name, to base::Feature Bug: 841772 Test: AutofillExperimentsTest Change-Id: I576c309e82f5275ec4367116612fb8c8d5ebf06b Reviewed-on: https://chromium-review.googlesource.com/1053756Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#557938}
-
Sergey Ulanov authored
Previously PathProviderFuchsia() was calling MakeAbsoluteFilePath(), which requires blocking IO, so it was DCHECKing on threads where blocking IO is not allowed. This issue was breaking debug builds of content_shell. Since we package all binaries produced in chromium, argv[0] is expected to contain full path to the binary, so it's not necessary to call MakeAbsoluteFilePath(). Bug: 787020 Change-Id: I45637ac6402ff6da1993ec571ad719a28210e721 Reviewed-on: https://chromium-review.googlesource.com/1055681Reviewed-by:
Scott Graham <scottmg@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#557937}
-
Devlin Cronin authored
The ExtensionFunction::GetAssociatedWebContentsDeprecated() method is unpredictable and can return surprising values in certain circumstances. It is deprecated and should be removed to ensure that callers are using the WebContents they expect. Update the fileManagerPrivate API to use GetSenderWebContents() instead. The fileManager API was using GetAssociatedWebContents() to find a WebContents to use for an opaque ID for the SelectFileDialogExtension dialog. However, the WebContents that is used for the dialog is determined by FindRuntimeContext() is SelectFileDialogExtension, which uses the window from the dialog to determine which WebContents to use. In practice, GetAssociatedWebContents() only worked because both GetAssociatedWebContents() and FindRuntimeContext() fell back to using the active tab if all else failed. Instead, make the opaque ID for a WebContents be based on the WebContents that would actually be used by the SelectFileDialogExtension. Bug: 461394 Change-Id: Id8607fd60a2cc6a6fb1cd14b3174c33bda79c8b4 Reviewed-on: https://chromium-review.googlesource.com/1021680Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#557936}
-
Sergey Ulanov authored
1. Moved fdio to deps instead of public_deps in //base 2. Added direct deps on FDIO in targets that need it, particularly in mojo. 3. Also replaces some deps with public_deps in //mojo/edk/test:test_support to reflect set of header deps in the headers exported by that target. 4. Small cleanups in mojo/edk/BUILD.gn to make it more readable. 5. Updated build/config/fuchsia/BUILD.gn to avoid dependency on internals of third_party/fuchsia-sdk/BUILD.gn. Bug: 707030 Change-Id: I402d3cd0d1d709aa381fa10e6fc6dfdb8e7e060c Reviewed-on: https://chromium-review.googlesource.com/1052608 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
-
Zach Helfinstein authored
Change-Id: Ib49704e55955ab08a7c6afaa9818d34068dd0831 Reviewed-on: https://chromium-review.googlesource.com/1052492Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Zach Helfinstein <zhelfins@chromium.org> Cr-Commit-Position: refs/heads/master@{#557934}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2bda0ab6..43ae3f6d Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ic52a4786b99ee93c4e9dd5849f761fe7b26cc4d1 Reviewed-on: https://chromium-review.googlesource.com/1054483Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#557933}
-
Emily Hanley authored
Bug: 804982 Change-Id: I35b6ab2f44a47db084400451dbf360197d54e442 Reviewed-on: https://chromium-review.googlesource.com/1053758 Commit-Queue: Emily Hanley <eyaich@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#557932}
-
Sahel Sharify authored
InputHandlerProxy::HandleGestureScrollUpdate returns DROP_EVENT for the common scrolling path when the scroller is at its extent and the event hasn't caused any scroll. This cl makes sure that the function also returns DROP_EVENT for the smooth (animated) scroll path when the scroller is at its extent. This change is necessary for excluding the GSU events that arrive when the scroller is at its extent from scrolling performance metrics. Bug: 773740 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I6bfa93da23728888c16e673e21b881ab5f6baac4 Reviewed-on: https://chromium-review.googlesource.com/1054529Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#557931}
-
Andrew Grieve authored
Bug: 636474 Change-Id: I303c9f2f2bd65bf3ba8e7041c72d6ddb75529adf Reviewed-on: https://chromium-review.googlesource.com/1055609Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#557930}
-
Victor Costan authored
TBR: jam Change-Id: I205f31a13db8b5bb990627c190a9c4d8c2cb156f Reviewed-on: https://chromium-review.googlesource.com/1055204 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#557929}
-
Amirhossein Simjour authored
When the size of the autofill changes, the container should update its size accordingly. Bug: 834096 Change-Id: I9fdf7cc04b4572d51ffd2e1ab9f6e7fcc596ae8c Reviewed-on: https://chromium-review.googlesource.com/1055617Reviewed-by:
Biao She <bshe@chromium.org> Commit-Queue: Amirhossein Simjour <asimjour@chromium.org> Cr-Commit-Position: refs/heads/master@{#557928}
-
Andrew Grieve authored
Bug: 834191 Change-Id: I3a0d79f4d281e426d41951080eb4551b646aab92 Reviewed-on: https://chromium-review.googlesource.com/1054731 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#557927}
-
Charlie Andrews authored
R=nednguyen@chromium.org Bug: 842232 Change-Id: Iacafeec6abed7d36ef2a2cb06c0bd7919f9eab94 Reviewed-on: https://chromium-review.googlesource.com/1055730Reviewed-by:
-
Max Morin authored
This is a reland of 539d243b Tests are updated to wait for a signal from the specific even they're waiting for, rather than just running a run loop. Ran a few hundred iterations each on debug, release, tsan, and asan to verify that the test is working as expected now. Original change's description: > Add a new RenderFrameAudioInputStreamFactory > > It checks that the stream is allowed and forwards the request to the > relevant ForwardingAudioStreamFactory if so. This will cause > the stream to be served by the audio service. > The old RenderFrameAudioInputStreamFactory which creates streams > living in content/ is renamed to > OldRenderFrameAudioInputStreamFactory. Since the class was renamed, > the files were moved (by adding "old_" to the beginning). No need to > review those files. Also note that replacement is diffed against > the previous implementation. It's probably best to just ignore the diff > and review render_frame_audio_input_stream_factory{.cc,.h,_unittest.cc} > as new files. > > The same flag as for output is used to switch between the old factory > and the new one. > > Approximate diagram of stuff: > https://docs.google.com/drawings/d/1_ZIKj6lihGKRjq4Mflduitmkn_REqpHFeqVNelBGHHk/edit > > Bug: 830493, 836226 > Change-Id: Ib0f58a52d849a48ba79405f0d499444c66029b58 > Reviewed-on: https://chromium-review.googlesource.com/1050245 > Commit-Queue: Max Morin <maxmorin@chromium.org> > Reviewed-by: Nasko Oskov <nasko@chromium.org> > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Cr-Commit-Position: refs/heads/master@{#557832} // Tbr since only tests were changed. Tbr: Bug: 830493, 836226 Change-Id: Ib0dbb37f7e4b170d0bf6defef081b867214a6740 Reviewed-on: https://chromium-review.googlesource.com/1054237 Commit-Queue: Max Morin <maxmorin@chromium.org> Reviewed-by:
Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#557925}
-
Carlos IL authored
Added 'BundledConnectionHelp' and 'SupervisedUserCommittedInterstitials' to Variations testing config. Bug: 755632, 803178 Change-Id: I83a544c91570f715c56848578859d858e2e9b42b Reviewed-on: https://chromium-review.googlesource.com/1055647Reviewed-by:
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/ec4bbb378159..746c45d5d8b1 $ git log ec4bbb378..746c45d5d --date=short --no-merges --format='%ad %ae %s' 2018-05-09 rrangel cros_gdb: Make remote debugging more reliable Created with: roll-dep src/third_party/chromite The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ibdc3aed3c94c877a680ec1a801dcc6c6a5461b43 Reviewed-on: https://chromium-review.googlesource.com/1055604Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#557923}
-
Joshua Peraza authored
a7c30f05016b Fix a few small issues found by GCC 439ba730c5ae Implementation in C++ of HTTPTransport test server 0e144fb9aeff Add missing http_transport_test_server to gyp build 7274c9823f9b fuchsia: Various build fixes for building in Fuchsia tree d051e00cd85a android: name crashpad_handler like a loadable module 78689cc81021 fuchsia: Depend on fdio_config when in-tree 2ddfb4cd3c79 fuchsia: CaptureContext for arm64 60ae9eeadb4a Implementation of HTTPTransport via raw socket d4533dc92bff Add override for overridden function 63d331e57aac fuchsia: Fix child process reader test to do what it should be doing 5636102fb418 Implement unlengthed response read in HTTPTransport a107b8b95d04 fuchsia: Identify and include stack mapping in dump bce68d7975ba fuchsia: Miscellaneous fixes to get symbol resolution working d766e659bb3e Roll mini_chromium to 40cb6722 240e28df2b88 Make run_with_crashpad buildable on Fuchsia too a279673974e0 fuchsia: Implement execvp() equivalent for run_with_crashpad 847d06db2946 fuchsia: Add header with shared exception port key e78789b9e0c2 fuchsia: Add implementation of ExceptionSnapshot c82309f0e599 fuchsia: Implement StartHandler() and ExceptionHandlerServer 02adab2e80c7 fuchsia: InitializeException, and write dump in exception handler 31703a585fb3 fuchsia: When in Fuchsia tree, disable tests requiring external files f115659a6723 fuchsia: Include crashpad_database_util in package f55a8d4ff3f2 fuchsia: Work around lack of packaging in Fuchsia tree build e2b934cc404a fuchsia: Don't depend explicitly on the x64 toolchain 19e6087bb208 Don't restrict ImageAnnotationReader to a module's address range 95a052dc0d0d fuchsia: When in Fuchsia, move helper binaries to subdir cc1573cd52f1 fuchsia: Fix compile error after 19e6087bb ef6d91b16616 Update cpp-httplib to 37130cd NOPRESUBMIT=true Change-Id: I0529f598023f06153d521c2f2b5f62fdd66c3bc8 Reviewed-on: https://chromium-review.googlesource.com/1052489 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by: -
Frank Barchard authored
Roll libyuv from r1708 to r1710 for fix to odd width extract alpha. Log of all changes in this roll a7fb978 ARGBExtractAlphaRow_Any_AVX2 fix pixel count mask by Frank Barchard · 49 minutes ago master a8aa921 Allow negative height when ConvertToI420/ARGB is called with NV12/NV21 by Robert Bares · 3 weeks ago 5669005 Skip cipd dependencies when autorolling. by Patrik Höglund · 3 weeks ago b8696fd add const to casts by Johann · 4 weeks ago 7e5e127 use attribute to alias for punning float to int by Frank Barchard · 4 weeks ago 2edf674 update linux makefile with mips/msa files by Johann · 4 weeks ago 190fb79 row_common.cc: add const to cast by Johann · 4 weeks ago 6e49847 Really fix building with clang targeting x86_32 mingw, remove duplication by Martin Storsjö · 4 weeks ago ebbe88a remove LICENSE_THIRD_PARTY by Johann · 4 weeks ago 8b8f872 Migrate autoroller from roll-dep-svn to gclient setdep by Oleh Prypin · 4 weeks ago BUG=libyuv:798 TESTED=try bots tested Change-Id: Id8228e402e30972c826361c5823c5e0f1d919192 Reviewed-on: https://chromium-review.googlesource.com/1055197Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Frank Barchard <fbarchard@chromium.org> Cr-Commit-Position: refs/heads/master@{#557921}
-
Eric Karl authored
Unlike AndroidOutputSurface and GLOutputSurface, GpuBrowserCompositorOutputSurface did not use a weak pointer for callbacks, instead de-registering them in its destructor. This de-registration was missed in my recent callback refactoring. Rather than give a way to de-register the new style of swap callbacks it seems easier to bring GpuBrowserCompositorOutputSurface in line with the other output surfaces and have it handle this via a weak pointer. Bug: 840788 Change-Id: I50e38e0b065b857e575aba6a07ca7e3ed716be46 Reviewed-on: https://chromium-review.googlesource.com/1053108 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#557920}
-
Fady Samuel authored
This CL generalizes RenderWidgetHostViewBase::ResizeDueToAutoResize to RenderWidgetHostViewBase::DidUpdateVisualProperties Instead of just passing the new viz::LocalSurfaceId and viewport size, we pass in the RenderFrameMetadata up the hierarchy. This is useful for synchronizing text selection handles across OOPIFs (since we need to transform text selection handles up the hierarchy) and top bar controls in the general case: https://docs.google.com/document/d/1CJf8_EQON3DY58JoHi6oTPV7iIIMBbNqB8CN6DPJd8s/edit#heading=h.mz47wray3bxa This doc discusses how a new rootScroller feature may be added to the web platform and this additional plumbing allows us to address this use case. Change-Id: Iafd74ce470f563efa83fb17178676478b33cdea7 Reviewed-on: https://chromium-review.googlesource.com/1054610Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
-
Tibor Goldschwendt authored
This darkens the normal gradient. Bug: 842199 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ic22ecf9262fc9641ca766ab14802c90804d5474d Reviewed-on: https://chromium-review.googlesource.com/1055651Reviewed-by:
-
Maksim Sisov authored
Make sure that software compositing is forced only when params.force_software_compositing is used. Change-Id: I468c04421c9d9a79db79d13f2e08405ccc4e51e3 Reviewed-on: https://chromium-review.googlesource.com/1051828Reviewed-by:
-
Kyle Horimoto authored
Now, PendingConnectionRequestBase handles notifying the ConnectionDelegate of connection failures itself. This moves the responsibility for mapping an arbitrary FailureDetailType to PendingConnectionRequestBase itself; this is the more appropriate place to handle this since this class it the one responsible for determining if connection requests should fail without a successful connection. Bug: 824568, 752273 Change-Id: I022f7030325314157fceeaf41338877b0ec967fc Reviewed-on: https://chromium-review.googlesource.com/1054207Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#557916}
-
Sergey Ulanov authored
test fonts are now packages as part of app package on fuchsia, so they can be loaded from /pkg/test_fonts. Bug: 787020 Change-Id: Ie8507d42cb92b518b83193a448643145c3539fe1 Reviewed-on: https://chromium-review.googlesource.com/1054573Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#557915}
-
Bence Béky authored
This is a follow-up CL to https://crrev.com/c/1028984. Change-Id: I16edc81639f67b115761f1f6c5d5351dca2f2f11 Reviewed-on: https://chromium-review.googlesource.com/1054514Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#557914}
-
Yuke Liao authored
This CL implements a switch to turn off the file view in the coverage report. Change-Id: Ia4209e572a18914f9bdb5754ef13cd3c19046950 Reviewed-on: https://chromium-review.googlesource.com/1055599 Commit-Queue: Abhishek Arya <inferno@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Abhishek Arya <inferno@chromium.org> Cr-Commit-Position: refs/heads/master@{#557913}
-
Sahel Sharify authored
On ChromeOS there are two different ui events for wheel scrolling: ui:ET_SCROLL is the event type when the user scrolls with the touchpad and ui::ET_MOUSEWHEEL is the event type when the user scrolls using an external mouse wheel device. Wheel scroll latching works differently for these two types of wheel scrolling: For touchpad scrolling the sequence starts when the user touches the touchpad (on a GFC) and ends when the user lifts their fingers (on a GFS); While for wheel scrolling the sequence starts with the first wheel event and ends when no wheel event has arrived for the past 500ms. We always receive a GFC when the user puts their finger down on the touchpad, but we receive a GFS only at the end of a scroll. So without this cl if the user lifts their fingers from touchpad without scrolling, scrolling with mouse wheel will get stuck to the same scrolling sequence till the next time that the user touches the touchpad again. This cl makes sure that these two logic for latching don't interfere with each other: On arrival of a ui::ET_MOUSEWHEEL we reset the touchpad scrolling state and when the user puts their finger on the touchpad we end the timer-based latching sequence before setting the touchpad_scroll_phase_state_. Bug: 838457 Test: *.ScrollingWithExternalMouseBreaksTouchpadScrollLatching Change-Id: Id5466e5645f08e6bf44c00f4471dbb3bbf9afc89 Reviewed-on: https://chromium-review.googlesource.com/1052853 Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
-
Tao Bai authored
Bug: 831829 Change-Id: I328377efd74d64820a66ec4469b688847de43e50 Reviewed-on: https://chromium-review.googlesource.com/1045489Reviewed-by:
Tao Bai <michaelbai@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#557911}
-
kylechar authored
This CL moves the responsibility for acknowledging that swap has occurred from SoftwareOutputSurface to SoftwareOutputDevice. This is to allow handling asynchronous swap better. This CL should have no change in behaviour but a follow up CL will add an overridden implementation of SoftwareOutputDevice::OnSwapBuffers(). The main change is that instead of SoftwareOutputSurface holding a TaskRunner the SoftwareOutputDevice does. Only the macOS SoftwareOutputDevice needs a specific TaskRunner provided. All other SoftwareOutputDevice implementations just grab the current one on construction. Bug: 826633 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I97f487db90fe18f4182d2210539f61f2cb694c6a Reviewed-on: https://chromium-review.googlesource.com/1055476Reviewed-by:
-
kylechar authored
The |dep_libevent| and |use_libevent| vars are for readability not for compile time configuration, so they don't need to be in a declare_args block. Bug: none Change-Id: I97cc31248b3a5f4bd6e9e0c72b5b7f4cc5533000 Reviewed-on: https://chromium-review.googlesource.com/1055608 Commit-Queue: kylechar <kylechar@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#557909}
-
Donn Denman authored
Reenables a test that was slightly flaky and disabled earlier today. This test seems to be pretty solid on older builds of Android, so enabling conditionally. BUG=841017,837996 Change-Id: I172a2c859d2a85d922319003a525d65fd44d01a5 Reviewed-on: https://chromium-review.googlesource.com/1053101Reviewed-by:
vitaliii <vitaliii@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#557908}
-
Ella Ge authored
Removes document.createTouch and related tests createTouchList has relatively high UseCount(around 0.015%), see https://www.chromestatus.com/metrics/feature/timeline/popularity/2368 We need to address these use cases before remove it. Postpone createTouchList removal to M69 intent to deprecate and Remove: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/GLbUpUUnQzc PR to touch-events spec: https://github.com/w3c/touch-events/pull/96 Bug: 518868 Change-Id: If086b51b775e4be59320c4a1329988787ff6f870 Reviewed-on: https://chromium-review.googlesource.com/1041128 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Rick Byers <rbyers@chromium.org> Cr-Commit-Position: refs/heads/master@{#557907}
-
erikchen authored
This CL updates TabStripModel's internal implementation to: * Use strong ownership semantics for WebContents. * Batch tab-removal notifications. This cannot be broken into two CLs because non-batched removal notifications required unclear ownership of WebContents. More details to follow. Previously, closing tabs was not safe for two reasons: * TabStripModelObserver callbacks were sending a half-destroyed WebContents instance to obsevers, which would then query internal state of the WebContents instance. * TabStripModelObserver callbacks could cause re-entrancy, which in turn led to internal state changes during observer list iteration! Previous implementation details: * TabStripModel would potentially try to close many tabs at once. * In a loop [whose iterator would be dynamically modified via WebContents observers] * TabStripModel would delete the WebContents instance. * This triggered TabStripModel's own WebContents destruction observer. * Which in turn called TabStripModel::DetachWebContentsAt() * Which then sent callbacks to TabStripModel observers using a half-destroyed WebContents instance. * Some of these observers would then access state on the half-destroyed WebContents instance. * Other observers would call back into TabStripModel and perform state modifications [e.g. remove another tab]. By observing its own WebContents during callbacks to observers, TabStripModel was able to react to some types of re-entrant behaviors during tab closure [e.g. closing a tab]. However, it was not able to correctly react to other types of re-entrant behaviors [e.g. adding a tab]. Furthermore, observers of TabStripModel needed to query internal state of TabStripModel during observer callbacks. This meant that behavior was dependent on observer ordering. e.g. If there are two observers A and B, and A removes tabs on its observer callback, and B checks for the currently selected index, then the ordering between A and B will cause behavior differences for B. This CL fixes both of these issues. Closing tabs now looks like this: * TabStripModel will potentially try to close many tabs at once. * TabStripModel updates its internal state to reflect this change. It is now in an internally consistent state [in case of re-entrancy from observers]. * For each tab that was removed: * TabStripModel dispatches observer callbacks. * TabStripModel deletes the WebContents. WebContents deletion now happens after observer callbacks, so there are no issues with half-destroyed WebContents instances. Tab closure is now re-entrant safe, since internal state is consistent before sending any observer callbacks, and observer callbacks are not affected by changing internal state. This CL discovered several issues: * Several tests suites were failing to set an active tab before running test logic. This meant that they weren't testing real behavior of the TabStripModel. * Several observers of TabStripModel were relying on assumptions about the internal state of the TabStripModel at the time of the observer callback [e.g. if a selected tab was detached, then the index of the detached tab in TabDetachedAt() is *still* the currently active index of the TabStripModel.] This was not robust against earlier observers performing re-entrancy into the TabStripModel]. * Several test suites were deleting WebContents owned by the TabStripModel. * Two tests in DetachToBrowserTabDragControllerTest were testing a condition that could never occur in the wild. They were testing that the TabStripModel behaves correctly if, halfway through a drag when a tab has been detached but not attached, the tab is deleted. With strong ownership semantics, the only way for a tab to be deleted is through TabStripModel APIs. Which means that in the brief period of time when a tab is not attached to any TabStripModel, it is not possible for the tab to be deleted. This behavior was previously true as well, it's just that it wasn't obvious that this condition couldn't occur. * Browser::TabClosingAt was unnecessarily calling SetDelegate(). That is also called by TabDetachedAtImpl(). * There are several places in the code that relied on the assumption that the TabStripModel WebContentsDestroyed() callbacks would occur before their own WebContentsDestroyed() callbacks. Bug: 826287 Change-Id: Ia44ad3a405844174407ffddb66e3728bbba44515 Reviewed-on: https://chromium-review.googlesource.com/1045790Reviewed-by:Charlie Harrison <csharrison@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#557906}
-
Tommy Martino authored
Full test name: SafeBrowsingDatabaseManagerCookieTest.TestSBUpdateCookies Link to failure: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-xenial-rel/54 Bug: 842195 Change-Id: I807a6815fc65e75b3023095d8abd875ad2cf3e14 TBR=jialiul@chromium.org Change-Id: I807a6815fc65e75b3023095d8abd875ad2cf3e14 Reviewed-on: https://chromium-review.googlesource.com/1055618Reviewed-by:
Tommy Martino <tmartino@chromium.org> Commit-Queue: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#557905}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/6ccd021839d2..c458fd6963db $ git log 6ccd02183..c458fd696 --date=short --no-merges --format='%ad %ae %s' 2018-05-11 chiniforooshan Telemetry: benchmark duration timestamp is wrong Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I9acd154cf46116ba6731201fd1936144fee40048 Reviewed-on: https://chromium-review.googlesource.com/1055596Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#557904}
-
Xing Liu authored
When we write to a file, currently we assume the whole chunk is written. However when users pull out the SD card or disk, base::File::Write will return a size less than the chunk size, and the next call to base::File::Write will return an error. This CL fixed this issue so FILE_FAILED error can be correctly reported when the SD card is unmounted. This CL basically makes the core write function back to this revision: https://chromium.googlesource.com/chromium/src/+/29db19d0c973a8990283ec4b81111db5bdb8d2de/content/browser/download/base_file.cc#101 Bug: 841559,792775 Change-Id: Icfba65833bf3aec07d30d8d3bed57a9abba7f8d1 Reviewed-on: https://chromium-review.googlesource.com/1053233 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#557903}
-
Robert Liao authored
Adds support to get the views find bar text to the global pasteboard. Also fixes a Cocoa bug introduced in the previous pasteboard change where the selection is always reset to the beginning at every keystroke. BUG=826478,827189,842131 Change-Id: If1a639f1997e3fea7fee2c66959e7dcdb2fd3bc7 Reviewed-on: https://chromium-review.googlesource.com/1055195 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
-
Kush Sinha authored
Add UI for listing accounts. Follow-up patches will add UI for Account addition, removal and re-authentication. A screenshot is linked in the bug id. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Bug: 833797 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I9fdeec3d67894096ae5212eea6e4771caee1d177 Reviewed-on: https://chromium-review.googlesource.com/1049690Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#557901}
-
crystallambert@chromium.org authored
This doc is an attempt to consolidate spread out information on permissions. It asks developers to make features that rely on permissions with warnings optional, therefore making those permissions optional. Includes tables of different types of permissions. Bug: None Change-Id: I1f0cc3934d676f16854c2725a33738916879efa2 Reviewed-on: https://chromium-review.googlesource.com/914866 Commit-Queue: Crystal Lambert <crystallambert@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#557900}
-
Florian Uunk authored
Create WithAccount and WithoutAccount versions of NotOptedInToSync and OptedInToSync. This will help us learn what percentage of users have an LST for DICe, and will tell us how much time users spend in permanent auth error states for sync. BUG=839048 Change-Id: I64b5e6b1466d3b6723f2fc2491f6254f6e14e067 Reviewed-on: https://chromium-review.googlesource.com/1051808 Commit-Queue: Florian Uunk <feuunk@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#557899}
-
