GitLab

Revert of Intorduce PowerButtonObserver API (patchset #3 id:80001 of https://codereview.chromium.org/654343002/)

Reason for revert:
This is breaking the main waterfall : http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20(1)

It appears that athena_unittests got added to the waterfall and not trybots. Please fix that before relanding this.

Original issue's description:
> Intorduce PowerButtonObserver API
>
> renamed existing PowerButtonController to ShutdownDialog
>
> BUG=None
> TEST=covered by unit tests
>
> Committed: https://crrev.com/0d921cdf45872ebff6c22da6a21c12d44054a860
> Cr-Commit-Position: refs/heads/master@{#299821}

TBR=mukai@chromium.org,oshima@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=None

Review URL: https://codereview.chromium.org/659923002

Cr-Commit-Position: refs/heads/master@{#299846}

A better fix will be needed for cross-process iframes support, but for now
this is safe and solves the bug.

BUG=423846

Review URL: https://codereview.chromium.org/643893003

Cr-Commit-Position: refs/heads/master@{#299845}

See
http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/31795
http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/31798
http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/31799
http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/31800
http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/31801

BUG=85276
TBR=estade@chromium.org

Review URL: https://codereview.chromium.org/660713002

Cr-Commit-Position: refs/heads/master@{#299844}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/498bc5f..de258cd

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=rmistry@google.com

Review URL: https://codereview.chromium.org/659913002

Cr-Commit-Position: refs/heads/master@{#299843}

Now Service Worker registrations and data get deleted as per
SpecialStoragePolicy.

BUG=419280

Review URL: https://codereview.chromium.org/633873002

Cr-Commit-Position: refs/heads/master@{#299842}

As a result, stop using the private class BluetoothDeviceChromeOS from outside
of the //device/bluetooth component.

BUG=423114
TEST=compiles
R=armansito@chromium.org

Review URL: https://codereview.chromium.org/652403002

Cr-Commit-Position: refs/heads/master@{#299841}

In "Import bookmarks and settings" overlay, 'Import' button is disabled when
no checkboxes are checked. But for 'Safari' only 2 checkboxes are shown;
when other checkboxes are checked in background(not shown), it causes the button
to always be enabled regardless of visible checkboxes checked or unchecked.
This CL checks if a checkbox is both shown and checked, to enable the button.

BUG=275265
R=dbeam@chromium.org

TEST=
1.Launch chrome ,go to settings and click on 'Import bookmarks and settings' button under 'Users' section.
2.Select 'Safari' and Uncheck 'Browsing history' and 'Favorites/Bookmarks' option .
3.Observe the 'Import' button. The 'Import' button should be disabled.

Review URL: https://codereview.chromium.org/636933002

Cr-Commit-Position: refs/heads/master@{#299840}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/af11f94..c8ee2ce

TBR=cbiesinger@chromium.org,dstockwell@chromium.org

Review URL: https://codereview.chromium.org/657283002

Cr-Commit-Position: refs/heads/master@{#299839}

Prior to my major fullscreen refactor, Presentation Mode and Canonical
Fullscreen had significant implementation differences. As a result,
fullscreen_controller treated the two modes very differently. If a user tried
to enter tab fullscreen after entering browser fullscreen (Presentation Mode),
enterImmersiveFullscreen: would not be invoked. If a user tried to do the same
after Canonical Fullscreen, enterImmersiveFullscreen: would be invoked.

After my major fullscreen refactor, Presentation Mode and Canonical Fullscreen
are almost identical. However, I failed to update the logic in
fullscreen_controller, which still treated the two modes differently.

This CL updates the logic in fullscreen_controller to treat both modes like
Presentation Mode. If a user tries to enter tab fullscreen after entering
browser fullscreen, enterImmersiveFullscreen: is not invoked.

BUG=422191

Review URL: https://codereview.chromium.org/652983005

Cr-Commit-Position: refs/heads/master@{#299838}

R=thestig@chromium.org
BUG=423134

Review URL: https://codereview.chromium.org/655413002

Cr-Commit-Position: refs/heads/master@{#299837}

BUG=265619

Review URL: https://codereview.chromium.org/658713003

Cr-Commit-Position: refs/heads/master@{#299836}

R=thestig@chromium.org
BUG=423134

Review URL: https://codereview.chromium.org/656033009

Cr-Commit-Position: refs/heads/master@{#299835}

R=brettw@chromium.org
BUG=423134

Review URL: https://codereview.chromium.org/654303003

Cr-Commit-Position: refs/heads/master@{#299834}

BUG=424027
TBR=dtu@chromium.org

Review URL: https://codereview.chromium.org/643763005

Cr-Commit-Position: refs/heads/master@{#299833}

Using WS_EX_NOPARENTNOTIFY seems to resolve the deadlock and allows WGL to work.

BUG=273220

Review URL: https://codereview.chromium.org/653883004

Cr-Commit-Position: refs/heads/master@{#299832}

The browser compositor in content/ currently expects to be able to do copy output requests of arbitrary layers. The surface aggregator should allow ever render pass to contain copy requests, and move them to the aggregated frame.

BUG=397730

Review URL: https://codereview.chromium.org/614073005

Cr-Commit-Position: refs/heads/master@{#299831}

BUG=None

Review URL: https://codereview.chromium.org/651853002

Cr-Commit-Position: refs/heads/master@{#299830}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/ae6d622..498bc5f

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=rmistry@google.com

Review URL: https://codereview.chromium.org/661593003

Cr-Commit-Position: refs/heads/master@{#299829}

Revert of Remove raw handles from base::win::RegKey (patchset #6 id:330001 of https://codereview.chromium.org/632833002/)

Reason for revert:
Causing base_unittests failures on XP Tests (1)

Original issue's description:
> Remove raw handles from base::win::RegKey
>
> BUG=419210, 423634
> R=cpu@chromium.org, eroman@chromium.org, sky@chromium.org
>
> Committed: https://crrev.com/1aa0fa75b65f403e08ae0f3f2fcb053c02cd9ef2
> Cr-Commit-Position: refs/heads/master@{#299737}

TBR=cpu@chromium.org,eroman@chromium.org,jam@chromium.org,rvargas@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=419210, 423634

Review URL: https://codereview.chromium.org/652903005

Cr-Commit-Position: refs/heads/master@{#299828}

s/getActionBar/getSupportActionBar in Desktop.java which uses
ActionBarActivity from the support library.

BUG=423875

Review URL: https://codereview.chromium.org/655243004

Cr-Commit-Position: refs/heads/master@{#299827}

BUG=423990
R=kalman@chromium.org

Review URL: https://codereview.chromium.org/661663002

Cr-Commit-Position: refs/heads/master@{#299826}

The ScaleImageSkiaRep function which attempts to scale the image to the desired scale should not do anything if the image is already scaled to the required scale.

The FindRepresentation function in ImageSkiaStorage has support for returning images scaled to the desired scale.

This fixes an annoying DCHECK firing on Windows boxes with display scales like 125%, 150%, etc.

BUG=NONE

Review URL: https://codereview.chromium.org/657203002

Cr-Commit-Position: refs/heads/master@{#299825}

If BrowserViewRenderer already has hardware acceleration
enabled, then fallback tick can produce a real instead of a
wasted 1x1 software frame. And to avoid the bug, we can force
this frame through the pipeline ignoring stalls.

BUG=424002

Review URL: https://codereview.chromium.org/659743002

Cr-Commit-Position: refs/heads/master@{#299824}

Fix indentation issue to allow enabling Checkstyle indentation rule.

BUG=318404

Review URL: https://codereview.chromium.org/654293002

Cr-Commit-Position: refs/heads/master@{#299823}

This might-maybe-hope-not crash, and so has debugging statements.

BUG=407376
TEST=no crashing, we hope

Review URL: https://codereview.chromium.org/657233002

Cr-Commit-Position: refs/heads/master@{#299822}

renamed existing PowerButtonController to ShutdownDialog

BUG=None
TEST=covered by unit tests

Review URL: https://codereview.chromium.org/654343002

Cr-Commit-Position: refs/heads/master@{#299821}

R=tonyg@chromium.org,dtu@chromium.org,nduca@chromium.org,nednguyen@google.com
BUG=423563

Review URL: https://codereview.chromium.org/661653003

Cr-Commit-Position: refs/heads/master@{#299820}

For MSE/EME, we never listen to the audio focus change.
That will cause the video to continue playing when another app plays sound.
Attach MediaPlayerListener to the MediaSourcePlayer should fix the issue.

BUG=421861

Review URL: https://codereview.chromium.org/643353002

Cr-Commit-Position: refs/heads/master@{#299819}

This pulls in the following Native Client changes:

r13908: (mseaborn) Scons: Stop scanning for multiple versions of ARM GCC
r13909: (mseaborn) ARM: Remove Scons support for using ARM soft-float toolchains
r13910: (bradnelson) Adding a prefix to distinct perf results so they are graphed separately.
r13913: (mazda) Make PNaCl translator use hard-float ABI for ARM nonsfi target.
r13914: (teravest) Add NaClDescCreateWithFilePathMetadata fallback.
r13915: (mseaborn) Clean up sysconf() test to address a TODO that depended on a toolchain roll

BUG=none
TEST=browser_tests and nacl_integration
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_rel_precise32,linux_nacl_sdk,linux_chromium_dbg

Review URL: https://codereview.chromium.org/644493004

Cr-Commit-Position: refs/heads/master@{#299818}

Currently, the data reduction proxy telemetry tests expect that the dev
proxy string will include the scheme of the URL, but it actually
doesn't. This CL changes the tests to not expect the scheme in the dev
proxy URL.

BUG=423916

Review URL: https://codereview.chromium.org/661613003

Cr-Commit-Position: refs/heads/master@{#299817}

BUG=chromedriver:916

Review URL: https://codereview.chromium.org/655373002

Cr-Commit-Position: refs/heads/master@{#299816}

The function RmTreeAndMkDir did two different things depending on a boolean flag that was passed to it.

This CL splits it into two functions so that each function only takes one argument and does one thing.

BUG=

Review URL: https://codereview.chromium.org/645383002

Cr-Commit-Position: refs/heads/master@{#299815}

R=estade@chromium.org
BUG=422851

Review URL: https://codereview.chromium.org/658523007

Cr-Commit-Position: refs/heads/master@{#299814}

BUG=411056

Review URL: https://codereview.chromium.org/638133003

Cr-Commit-Position: refs/heads/master@{#299813}

Fix an issue where the last-requested display power state
was bound to a delayed task on resume. If a new state was
requested while the task was waiting to run (e.g. due to
exiting docked mode), the task would later restore the old
state.

Instead, add a thunk for the task that always uses the
currently-requested state.

BUG=chrome-os-partner:32393

Review URL: https://codereview.chromium.org/652073002

Cr-Commit-Position: refs/heads/master@{#299812}

The test LastBookmarkResizeBehavior implicitly relied on the default system
font. The system font changed from 10.9 to 10.10, breaking the test. I updated
the test to use a different set of parameters on OSX 10.10+.

BUG=390276

Review URL: https://codereview.chromium.org/659693002

Cr-Commit-Position: refs/heads/master@{#299811}

I expected the mojo_native_viewport_service to use -- as a prefix for its
arguments:

mojo_shell --args-for="mojo://mojo_native_viewport_service/ --use-headless-config"

but prior to this CL, it was expect its arguments without the leading "--".
After this CL, it expects the leading "--".

R=davemoore@chromium.org,hansmuller@chromium.org

Review URL: https://codereview.chromium.org/661513002

Cr-Commit-Position: refs/heads/master@{#299810}

R=enne

Review URL: https://codereview.chromium.org/662473003

Cr-Commit-Position: refs/heads/master@{#299809}

NaCl does not support glibc on ARM so all glibc-related
tests should be disabled on ARM.

BUG=422592
TEST=linux_arm trybot

Review URL: https://codereview.chromium.org/652873002

Cr-Commit-Position: refs/heads/master@{#299808}

Two sets of changes:
. fix gn dependencies
. make views_init work in the static library

The latter means wm_flow_init and demo_launcher only work with gn (not gyp).

BUG=none
TEST=none
R=ben@chromium.org

Review URL: https://codereview.chromium.org/658753004

Cr-Commit-Position: refs/heads/master@{#299807}