GitLab

Cr-Commit-Position: refs/heads/master@{#438050}

HttpResponseHeaders::Get{MimeType,Charset} calls GetMimeTypeAndCharset internally
and discards the other.
As we are going to use both in parseMultipartHeadersFromBody, we should call it directly.

BUG=None

Review-Url: https://codereview.chromium.org/2568343002
Cr-Commit-Position: refs/heads/master@{#438049}

BUG=none
R=tapted@chromium.org

Review-Url: https://codereview.chromium.org/2566513003
Cr-Commit-Position: refs/heads/master@{#438048}

This reverts commit 140c9756.

Reason for revert:
Breaks EarlGrey tests in Release configuration for iOS downstream.

BUG=673495
NOTRY=true

Review-Url: https://codereview.chromium.org/2564403003
Cr-Commit-Position: refs/heads/master@{#438047}

Instead of a MediaDelegate returned by the ShellDelegate, we now have a
MediaController on the ash side, which receives a MediaClient from the
chrome side at startup.

This also makes minor changes to the interface to send information with
a notification instead of having ash try to read the information back
after notification.

BUG=647409

Review-Url: https://codereview.chromium.org/2563643003
Cr-Commit-Position: refs/heads/master@{#438046}

We can keep this logic entirely in AwContents, it doesn't need to be in
ContentViewCore. I'm using the existing GestureStateListener interface to signal
AwZoomControls of the relevant events, but I did have to add a few more events
to that interface. Hopefully they're OK and will work with our future plans to
refactor more input-handling stuff out of ContentViewCore.

Note on testing this: the Android WebView shell works for testing but I had to
knock out the "&& mAwContents.getSettings().shouldDisplayZoomControls()" check
in getZoomController() to enable the zoom controls. Once you do this they appear
when scrolling.

BUG=664339

Review-Url: https://codereview.chromium.org/2561463004
Cr-Commit-Position: refs/heads/master@{#438045}

Do not let ash connect to chrome to get the presenter.

Expose mojom::AppList interface in ash to set the presenter.
Chrome's AppListPresenterService connects to register.
Move instance from Chrome's FactoryImpl to AppListServiceAsh.

Implement app_list::AppList; owned by ash::WmShell.

Add export info to app_list's 'presenter' component.
(lets it add the mojom as a public DEPS; thanks Yuzhu!)

Remove connection and interface pointer from AppListPresenterMus.

TODO: What's not TODO here? It's a mess!

BUG=670775
TEST=No regressions in chrome --mash app list behavior
R=jamescook@chromium.org,tsepez@chromium.org,xiyuan@chromium.org,rockot@chromium.org

Review-Url: https://codereview.chromium.org/2567523002
Cr-Commit-Position: refs/heads/master@{#438044}

Rather than running callbacks immediately, post a task to run the
callbacks, to avoid conflicts while undeferring a page.

R=dcheng@chromium.org
BUG=670092

Review-Url: https://codereview.chromium.org/2565863002
Cr-Commit-Position: refs/heads/master@{#438043}

Revert of android: Randomize initial child service bind order (patchset #3 id:40001 of https://codereview.chromium.org/2557273004/ )

Reason for revert:
Android keeps the intent for a long time, so
randomize doesn't help at all. More details:
crbug.com/664341#c91

Original issue's description:
> android: Randomize initial child service bind order
>
> Android restarts crashed services with the previous intent.
> If browser crashes and is restarted at the same time, then
> it's possible to bind to the restarted service with stale
> intent and bundle data. See crbug.com/664341#c83 for an
> example. Randomizing the start up order is a pure
> workaround to make this case less likely.
>
> BUG=664341
>
> Committed: https://crrev.com/bb725fed9bd8c672178c8a815f4b1a2500eef444
> Cr-Commit-Position: refs/heads/master@{#437367}

TBR=agrieve@chromium.org,jcivelli@chromium.org,mariakhomenko@chromium.org,hanxi@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=664341

Review-Url: https://codereview.chromium.org/2571723002
Cr-Commit-Position: refs/heads/master@{#438042}

Running this command will throw an error:
  gn gen out/Release --check --args="is_debug=false enable_webrtc=false"

Fix this error by adding a nogncheck comment by the errant include.

BUG=

Review-Url: https://codereview.chromium.org/2563773003
Cr-Commit-Position: refs/heads/master@{#438041}

Its not being used, except from unit tests.

BUG=644430

Review-Url: https://codereview.chromium.org/2559283003
Cr-Commit-Position: refs/heads/master@{#438040}

After gamepad mojoification, In renderer side, GamepadSharedMemoryReader has to
"unwrap" the received mojo::ScopedSharedBufferHandle into a
base::SharedMemoryHandle. It is not good.

In this patch we let GamepadSharedMemoryReader completely use mojo::SharedBuffer
to avoid the "unwrap" operation.

BUG = 670655

Review-Url: https://codereview.chromium.org/2567713003
Cr-Commit-Position: refs/heads/master@{#438039}

BUG=666876
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2563143002
Cr-Commit-Position: refs/heads/master@{#438038}

Mojo JS bindings: code generator maps interface ptr and request to InterfacePtr and InterfaceRequest.

BUG=579646
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2556353004
Cr-Commit-Position: refs/heads/master@{#438037}

It will be used in multiple places to unit tests metrics recording,
so a separate file has been created rather than having every test
define its own.

BUG=internal b/33482814

Review-Url: https://codereview.chromium.org/2563073002
Cr-Commit-Position: refs/heads/master@{#438036}

Wasn't nulling out a couple of fields.

BUG=672932
TEST=none
R=fsamuel@chromium.org, jbauman@chromium.org

Review-Url: https://codereview.chromium.org/2570603002
Cr-Commit-Position: refs/heads/master@{#438035}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/7f7160ed..642e2c87

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2573513002
Cr-Commit-Position: refs/heads/master@{#438034}

https://pdfium.googlesource.com/pdfium.git/+log/9468639bc3c4..8df02348924f

$ git log 9468639bc..8df023489 --date=short --no-merges --format='%ad %ae %s'
2016-12-12 caryclark fix linux build
2016-12-12 weili Fix JBig2 decoding logic
2016-12-12 reed add flag for future Skia CL
2016-12-12 caryclark sync with latest skia api
2016-12-12 weili Fix dotted line drawing for GDI device driver
2016-12-12 reed add flag for SkClipOps

BUG=625848,539533

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2566283004
Cr-Commit-Position: refs/heads/master@{#438033}

Fixed the test failure due to not setting default batch size in script.

BUG=673519

Review-Url: https://codereview.chromium.org/2567983005
Cr-Commit-Position: refs/heads/master@{#438032}

BUG=673022

Review-Url: https://codereview.chromium.org/2569503002
Cr-Commit-Position: refs/heads/master@{#438031}

https://skia.googlesource.com/skia.git/+log/c30833327f0d..b399e38518c7

$ git log c30833327..b399e3851 --date=short --no-merges --format='%ad %ae %s'
2016-12-12 msarett Add Gray test color images to bots
2016-12-12 stani Add a method in SkCanvas to set "hard" clip bounds.
2016-12-12 msarett Decode to sRGB on Android
2016-12-12 liyuqian Add GMs and benchs for concave Analytic AA
2016-12-12 fmalita Use unsigned arithmetic for SkBitmapProcStateAutoMapper bias
2016-12-12 reed Hide exotic clipops, with a private rename for internal use
2016-12-12 halcanary SkBitmap::setPixelRef():  less reference churn
2016-12-12 borenet gen_tasks.go: Assert that all compile tasks are in the JOBS list
2016-12-12 caryclark fix fuzz
2016-12-12 mtklein Just make Android.bp bpfmt compliant to begin with.
2016-12-09 scroggo Fix SkGifCodec bugs around truncated data
2016-12-12 egdaniel Revert "added sk_FragCoord support to skslc"
2016-12-08 raftias Updated the get_images_from_skps tool to check for ICC profile support
2016-12-12 borenet Disable flaky GSStoreTest
2016-12-09 ethannicholas added sk_FragCoord support to skslc
2016-12-12 mtklein Remove dependency on NDK cpufeatures.
2016-12-11 mtklein funnel f16 through standard load/store/gather
2016-12-12 reed change SkClipOp to a class enum

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=msarett@google.com

Review-Url: https://codereview.chromium.org/2567283002
Cr-Commit-Position: refs/heads/master@{#438030}

Previously enabled for chromium_code, can now be turned on everywhere.

BUG=454858,637203, 671021

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel
Committed: https://crrev.com/a53f3c3734ad9ee4322f6a9a60eede7f6b04530f
Cr-Commit-Position: refs/heads/master@{#436189}

Review-Url: https://codereview.chromium.org/2543743002
Cr-Commit-Position: refs/heads/master@{#438029}

This change removes HpackEncoder::EncodeHeaderSetWithoutCompression() and the corresponding progressive encoding method parameter. This change only affects code paths exercised in tests.

This CL lands server change 141469300 by birenroy.

BUG=488484

Review-Url: https://codereview.chromium.org/2570513003
Cr-Commit-Position: refs/heads/master@{#438028}

This flag has been removed and is currently a no-op. No need
to pass it into the test.

Review-Url: https://codereview.chromium.org/2567243002
Cr-Commit-Position: refs/heads/master@{#438027}

Creates a new directory rlz/features for the gni file and the buildflag_header target.

Updates callers to depend on the new target and use the new flags.

Review-Url: https://codereview.chromium.org/2570573002
Cr-Commit-Position: refs/heads/master@{#438026}

Mojo JS codegen provides binary data in objects of type Array<number>,
not Uint8Array. This change fixes the assumption, and provides the
required Uint8Array to the provider handler function.

Review-Url: https://codereview.chromium.org/2568933003
Cr-Commit-Position: refs/heads/master@{#438025}

This roll includes:
- [inspector_protocol] Support redirects and types whitelisting.

TBR=kozyatinskiy@chromium.org
BUG=none

Review-Url: https://codereview.chromium.org/2572643002
Cr-Commit-Position: refs/heads/master@{#438024}

aura::Env::CreateInstance() takes a type. This patch plumbs the type
through to content::MainFunctionParams and Content::ConteintMainParams
so that consumers can specify how they want Env configured.

BUG=672932
TEST=none
R=jam@chromium.org

Review-Url: https://codereview.chromium.org/2567113002
Cr-Commit-Position: refs/heads/master@{#438023}

Renamed the Field attribute 'type' to 'storage_type' in
make_computed_style_base.py and the ComputedStyleBase template files.

This is pre-work for when Fields can have both an internal storage and
external type (new attribute 'external_type'), and these types need to
be distinguished without being confusing.

BUG=628043

Review-Url: https://codereview.chromium.org/2563853002
Cr-Commit-Position: refs/heads/master@{#438022}

BUG=490942
R=skobes@chromium.org

Review-Url: https://codereview.chromium.org/2571703002
Cr-Commit-Position: refs/heads/master@{#438021}

This reverts commit a12e7a00.

BUG=646464

TEST=Visit http://output.jsbin.com/vucefi, confirm that both boxes have
box shadows and the first box has sub-pixel AA text

Review-Url: https://codereview.chromium.org/2561183002
Cr-Commit-Position: refs/heads/master@{#438020}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/19565fdb148a..c69690acc34b

$ git log 19565fdb1..c69690acc --date=short --no-merges --format='%ad %ae %s'
2016-12-12 charliea Upload the serial log file when we fail to retrieve the BattOr git hash
2016-12-12 jessimb Fixed mapreduce.yaml to name: entity_kind
2016-12-12 dtu [firefighter] Replace builder name regexes with more fuzzy matching.
2016-12-12 jessimb A MapReduce job to add units into the anomaly entity.
2016-12-12 benjhayden Fix mismatched curly braces in sinebow_color_generator_test.
2016-12-12 eakuefner Revert of [Telemetry] Add temporary logging to desktop_browser_finder (patchset #1 id:1 of https://codereview.chromium.org/2567783002/ )
2016-12-12 eakuefner [Telemetry] Introduce LegacyHtmlOutputFormatter
2016-12-12 rnephew [BattOr] Detect malformed git hashes.
2016-12-12 eakuefner [Telemetry] Pass --disable-gpu in run_tests if starting Xvfb
2016-12-12 nednguyen Move browser_test_runner.LoadAllTestsInModule to serially_executed_browser_test_case
2016-12-12 nednguyen [Telemetry] Fix flaky browser test due to duplicated system stubbing
2016-12-12 benjhayden Make ChartJsonConverter support UMA Histograms and single-story results.

BUG=673411,636153

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2574623002
Cr-Commit-Position: refs/heads/master@{#438019}

The rename is needed to avoid a naming collision after changing from
Blink to Chromium naming style.  Right now we have a |ReadyState| type
and a |readyState| accessor method (differing by case of the first
character); after a naive rename by the rewrite_to_chrome_style tool we
would end up with |ReadyState| being the name of both the type and the
accessor method (with both living in the same namespace).

Prepending a "get" prefix to the name of the accessor method is the
workaround that fits into the guidance on the recommended
post-Blink-to-Chromium-rename style suggested by esprehn@ in
https://crbug.com/582312#c17:
- Getters favor not using "Get", ex. FirstChild()
- Unless the type name conflicts, in which case you can either rename
  the type if it's easy and makes sense, or add "Get", ex. GetContext().

FWIW, this rename brings the name of the enum closer to the name of the
enum in the WHATWG spec.

BUG=582312

Review-Url: https://codereview.chromium.org/2567943004
Cr-Commit-Position: refs/heads/master@{#438018}

This CL adds the actual CertificateReportingService code that's going to be
used to send reports. The service is still not wired to any other service, so is
off by default.

BUG=554323

Review-Url: https://codereview.chromium.org/2543523002
Cr-Commit-Position: refs/heads/master@{#438017}

Today, navigator renders green checkmarks as a part of the title element.
This results in the editing field spanning over the icon as well.

This patch starts using treeelement.setTrailingIcons() method to
avoid this problem.

BUG=673086
R=dgozman

Review-Url: https://codereview.chromium.org/2568623002
Cr-Commit-Position: refs/heads/master@{#438016}

This fixes a bug where the 2nd arg to std::string::substr() was not the
length, but the end position.

Review-Url: https://codereview.chromium.org/2567263002
Cr-Commit-Position: refs/heads/master@{#438015}

BUG=660445

Review-Url: https://codereview.chromium.org/2555623002
Cr-Commit-Position: refs/heads/master@{#438014}

This is to gather early feedback in canary, before we flip this to stable (for M57).

Link to Intent to ship.
https://groups.google.com/a/chromium.org/forum/#!topic/blink-
dev/AT7aqhPcNdw

BUG=672982

Review-Url: https://codereview.chromium.org/2560313002
Cr-Commit-Position: refs/heads/master@{#438013}

In some cases, an input event being targeted to the root RWHV was going
through coordinate transformation, while in other cases it was not.
This is normally fine because it is the identity transform anyway, but
it can result in rounding error when there is a non-integer device
scale factor. This was noted to cause a bug related to selections not
being cleared because of coordinates from a transformed (rounded)
event being compared against coordinates from a non-tranformed
(unrounded) input event.

This CL prevents transformation in all cases when the root is being
targeted and the event is already in the coordinate space of the root.

BUG=670253
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2567093003
Cr-Commit-Position: refs/heads/master@{#438012}

Record Data Reduction Proxy (DRP) histogram on how long back savings were
automatically cleared because the system clock moved back. If this happens
too frequently, then we will need to add a mechanism to get around this.
This would also help in debugging 0% savings feedback reports.

BUG=658354

Review-Url: https://codereview.chromium.org/2546273002
Cr-Commit-Position: refs/heads/master@{#438011}