- 19 Apr, 2018 40 commits
-
-
https://pdfium.googlesource.com/pdfium.git/+log/54e6da1ee793..9914d4dc1e7a $ git log 54e6da1ee..9914d4dc1 --date=short --no-merges --format='%ad %ae %s' 2018-04-19 thestig Make CPDF_StitchFunc use more vectors. 2018-04-19 thestig Do more validation in CPDF_StitchFunc::v_Init(). 2018-04-19 thestig Do a bit more validation in CPDF_ExpIntFunc::v_Init(). Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I2fd362f290bf89b3f70a0ecff9ec3a320e2ece2e Reviewed-on: https://chromium-review.googlesource.com/1020188Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#552184}
-
Ned Nguyen authored
This reverts commit 0ef4af14. Reason for revert: break Telemetry tests BUG:834833 Original change's description: > Update top offset of motion events on hover in CompositorViewHolder > > When entering VR we hide the browser controls. However, it can take some > time for this state update to reach the FullscreenManager. As a > consequence, hover move events may have a false offset depending on > whether the initial hover enter event was processed with the updated > browser controls state or not. To fix that, also update the top offset > for hover move events. > > Bug: 822384 > Change-Id: I196a38098f736d6a9c8066b0a48cafa774ea1864 > Reviewed-on: https://chromium-review.googlesource.com/1014708 > Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org> > Reviewed-by: Matthew Jones <mdjones@chromium.org> > Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#551502} TBR=mdjones@chromium.org,jinsukkim@chromium.org,tiborg@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 822384 Change-Id: Ibb0dd8b2fe110e9f7ecd7785604f956fede4bfd3 Reviewed-on: https://chromium-review.googlesource.com/1020240Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#552183}
-
danakj authored
After https://chromium-review.googlesource.com/c/chromium/src/+/1019614 the test is no longer failing flakily. R=piman@chromium.org Bug: 834613 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I9a26d5e4833e5566d5fd184894d2b6b951226fe1 Reviewed-on: https://chromium-review.googlesource.com/1020287Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#552182}
-
Miguel Casas authored
This CL is a refry of crrev.com/c/1018020, but including only the VP9.2 MD5SUM. "Original" CL description ---------------------------------------------- This CL corrects the MD5 values for two video_decode_accelerator_unittest cases: [ ... ] - VP9 Profile 2: the last round of MD5 updates missed this one (causing the autotest runs to be red; this was not obvious due to other test issues). This CL simply updates this value. Bug: 834156 TBR=hoegsberg@chromium.org, since it's a trivial part of an already landed CL. Bug: 834954 Change-Id: I19c7c59de437a99c6e29d42020bc0993619f804b Reviewed-on: https://chromium-review.googlesource.com/1020024Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#552181}
-
Matt Menke authored
This API has proven problematic in the past, and the NetworkService has better defined NetworkContext lifetime semantics, so it's not needed. Bug: 810776 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I6f49a7d7bab973e591e27bb55f17d3fe468d5f20 Reviewed-on: https://chromium-review.googlesource.com/1015823Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Stephen Lanham <slan@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#552180}
-
Gabriel Charette authored
This is another scripted pass done by a slightly modified version of https://bugs.chromium.org/p/chromium/issues/detail?id=781352#c1 which has a better notion of "scope". The script should have replaced a MessageLoop::ScopedNestableTaskAllower in the same scope as a RunLoop with a RunLoop of Type::kNestableTasksAllowed. Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. TBR=flackr@chromium.org Bug: 781352 Change-Id: Ica51fdb505201c8f1944b160ef6dba8553b0c338 Reviewed-on: https://chromium-review.googlesource.com/1013215Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#552179}
-
David Reveman authored
Use base::Optional for startup and application ID in order to handle null values properly. Setting one of these to null will now clear the window property. Bug: 834971 Test: exo_unittests --gtest_filter=ShellSurfaceTest.Set*Id Change-Id: I395fb02200f310b027060eb28e0132d8976532ab Reviewed-on: https://chromium-review.googlesource.com/1020042Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#552178}
-
https://chromium.googlesource.com/catapult.git/+log/4fe4dbb4de4b..28f445af33ee $ git log 4fe4dbb4d..28f445af3 --date=short --no-merges --format='%ad %ae %s' 2018-04-19 nednguyen Disable TracingControllerTest.testFlushTracing on Win Created with: roll-dep src/third_party/catapult BUG=chromium:829976 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: Ic9c8c155db319df4a98b55d8593c3089cae84549 Reviewed-on: https://chromium-review.googlesource.com/1020154 Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#552177}
-
https://chromium.googlesource.com/angle/angle.git/+log/1d97a4d0363d..025aafdfc4af $ git log 1d97a4d03..025aafdfc --date=short --no-merges --format='%ad %ae %s' 2017-10-30 geofflang Make EGL image extensions enableable. 2017-11-07 geofflang Make EXT_texture_storage enableable. 2018-03-28 geofflang The 'format' of unsized SRGB internal formats should be SRGB too. Created with: roll-dep src/third_party/angle BUG=chromium:693090 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: Id036eb947993a00093291ad5dfa30663529e3471 Reviewed-on: https://chromium-review.googlesource.com/1020149 Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#552176}
-
Wenzhao Zang authored
Bug: 832867 Change-Id: Ie93bb1a9aa2ed051c437a56fe9aec25b6b99c60c Reviewed-on: https://chromium-review.googlesource.com/1017540 Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#552175}
-
Jian Li authored
The content:// URL can contain SPACE and other characters that are not escaped. To deal with this, we base64 encode the value. Bug: 830983 Change-Id: I8737fb1f94f1a498429af42ef53d61adfe237cc2 Reviewed-on: https://chromium-review.googlesource.com/1013087Reviewed-by:
Dmitry Titov <dimich@chromium.org> Commit-Queue: Jian Li <jianli@chromium.org> Cr-Commit-Position: refs/heads/master@{#552174}
-
Siddhartha authored
The unwind file is included in some channels and not in other channels. It is only added to 32-bit apk since 64-bit ones have frame pointers. Add use-unwind-cfi argument to use the file when needed. BUG=819888 Change-Id: Ia4560815b2c7ef0e5ba852c8a31f7b132d86c11c Reviewed-on: https://chromium-review.googlesource.com/998309Reviewed-by:
Tao Bai <michaelbai@chromium.org> Commit-Queue: Siddhartha S <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#552173}
-
Erik Chen authored
This CL has no intended behavior change. It addresses some comments from gab@ on another CL that already landed: https://chromium-review.googlesource.com/c/chromium/src/+/978393. Bug: 825218 Change-Id: I78fee61253c6b885350774b774477060580984be Reviewed-on: https://chromium-review.googlesource.com/998313 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
-
https://webrtc.googlesource.com/src.git/+log/8d7393bb2893..06d094f3e621 $ git log 8d7393bb2..06d094f3e --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=chromium:b/73147161,chromium:834255,chromium:None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ied4fd21c1ec0052642513344fb45ebac61f2782e Reviewed-on: https://chromium-review.googlesource.com/1019868 Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#552171}
-
James Cook authored
Internals>MUS was renamed to Internals>Services>WindowService in the bug tracker. Rename the references in OWNERS files so that clusterfuzz auto-filed bugs apply the correct component. TBR=sky@chromium.org TBR=rjkroege@chromium.org Bug: none Change-Id: I4ab9d9862cd8d005c3a12ed97edae1dc5903d8df Reviewed-on: https://chromium-review.googlesource.com/1020364Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#552170}
-
Dominic Mazzoni authored
Revert "Android Accessibility: Set flag to enable jump to last element on ACTION_PREVIOUS_HTML_ELEMENT" This reverts commit 90d35140. Reason for revert: infinite loop (crbug.com/834866) Original change's description: > Android Accessibility: Set flag to enable jump to last element on ACTION_PREVIOUS_HTML_ELEMENT > > This CL is a followup on the following CL: > https://chromium-review.googlesource.com/736043 > > The above CL returns the deepest child of web view on ACTION_PREVIOUS_HTML_ELEMENT if > can_wrap_to_last_element flag in OneShotAccessibilityTreeSearch is set to true. > This CL sets that flag for Android. Assuming a web view is in between native elements, the > following order will be followed for a11y focus: > Native elements -> web view container -> inside web view container -> native elements. > So web view container will always be focused only in the above order. > > Bug: 661793 > Change-Id: I62dbcb143ed5a152172dc7cde9355f4b7eed79e1 > Reviewed-on: https://chromium-review.googlesource.com/884302 > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#536742} TBR=dmazzoni@chromium.org,ibobra@google.com NOTRY=true Bug: 661793, 834866 Change-Id: I3dc34c17908aa06c33a904415d10fc0d5a56fc2c Reviewed-on: https://chromium-review.googlesource.com/1019960 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#552169}
-
Fredrik Hubinette authored
Bug: 754986 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Icc92ef5e7f1c8fcd57dd9bdf252b8460871c6022 Reviewed-on: https://chromium-review.googlesource.com/1018240 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#552168}
-
Filip Gorski authored
Bug: 834914 Change-Id: I9909c1e6eb274a6e46963694fc8676e31aa66da7 Reviewed-on: https://chromium-review.googlesource.com/1020221Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#552167}
-
Miguel Casas authored
This reverts commit c813adf6. Reason for revert: Needed to revert other CLs that caused a regression in video_VideoSeek: https://crbug.com/834146 Bug: 834146 Original change's description: > vaapi: cleanup a few comments and var names > > This CL cleans up a few things that I realized while > debugging other CLs in the area: > - |available_va_surfaces_| is a std::list on ToT, but has > queue semantics, so it's changed int his CL. > - s/output_buffers_/available_va_surfaces_/ because that's > what they are. > - s/TryOutputSurface/TryOutputPicture/ because that's what > the method does. > - s/pictures_/picture_map_/ to better define what it is. After > dcastagna@ suggestion, it's made a base::small_map in PS7 > > Comments updated throughout these variables. > > No change in behaviour intended, but tested nonetheless with > vp8/9-h264 crosvideo playback. > > Bug: 822346 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel > Change-Id: I2117ceac29f7d6ed23d698c4abd5c72e0140ae47 > Reviewed-on: https://chromium-review.googlesource.com/988512 > Commit-Queue: Miguel Casas <mcasas@chromium.org> > Reviewed-by: Daniele Castagna <dcastagna@chromium.org> > Cr-Commit-Position: refs/heads/master@{#547552} TBR=mcasas@chromium.org,dcastagna@chromium.org,hoegsberg@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 822346 Change-Id: I7d242ad92a68596766f6cfe0ad2be37da3c4fb20 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1020005 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
-
Patrik Höglund authored
The tests went flaky when we replaced the bot and get VIDIOC_STREAMON errors about 25% of the builds. I have no idea to fix that; we tried replacing the webcam and moving it around in the USB ports and that didn't help. See http://crbug.com/828568 for discussion. Bug: chromium:831514 Change-Id: Ic55c09a16a22dd0402c3360b710e310c733ec5f9 Reviewed-on: https://chromium-review.googlesource.com/1016301Reviewed-by:
Christian Fremerey <chfremer@chromium.org> Commit-Queue: Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#552165}
-
Kurt Horimoto authored
Bug: 834131 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I7a3bb44da51bdd3aac19ff8da559d4178e0fe168 Reviewed-on: https://chromium-review.googlesource.com/1017231 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
-
Helen Li authored
This CL moves writing/reading logic out of tcp_connected_socket.cc into a separate class, socket_data_pump.h/cc. This separate class will be re-used by tls socket implementation. Bug: 721401 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I5d5b723d52c10a653f06b0f6e8eed9fb5b895899 Reviewed-on: https://chromium-review.googlesource.com/1005535 Commit-Queue: Helen Li <xunjieli@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#552163}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/1b573fbc..c7c22c11 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I217912a30f550bf256d2b5594216a01d69ba4f7d Reviewed-on: https://chromium-review.googlesource.com/1019845Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#552162}
-
Andrey Lushnikov authored
The previous attempt to fix the bug was in crrev.com/539166: the patch allowed adding rules to the inspector style sheets. However, it didn't take into account adding rules into the already-existing style sheets. This patch fixes CSS.addRule altogether, allowing CSSOM access if the operation is happenning from-inside InspectorMutationScope. Our tests didn't catch the regression since we run with --allow-file-access-from-files flag. BUG=818518 R=dgozman Change-Id: Ic6b198a5ef7abbabcef671edbefb5a9b14fde531 Reviewed-on: https://chromium-review.googlesource.com/1018526 Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#552161}
-
Gabriel Charette authored
Managing TaskTracker through TrackedRefs instead of raw pointers is the final bandaid for issues like crbug.com/827615. It will now be impossible for SchedulerWorkers to outlive their TaskTracker. A test may hang if its shutdown logic is flawed (out of order) but the blamed test will always be the one with the poor logic (instead of a random test in whose context an errand SchedulerWorker makes a use-after-free). In fact, a few tests had to be fixed to land this change (while they weren't necessarily flawed per se per being properly joined, the logic is easier to grasp with TrackedRefs). R=fdoray@chromium.org Bug: 827615 Change-Id: I5bff8c55b4edb9fef8c5232bddf36da2afd33078 Reviewed-on: https://chromium-review.googlesource.com/1013597 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#552160}
-
Xi Cheng authored
If the command line has both switches, the profile id in kNotificationLaunchId should be chosen over that in kProfileDirectory. Bug: 734095 Change-Id: Ifeb693414a50f7e865c808ba75ce99d3e7db4733 Reviewed-on: https://chromium-review.googlesource.com/1018100 Commit-Queue: Xi Cheng <chengx@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#552159}
-
Mikhail Atuchin authored
In case of disk/access error FileURLLoader called ContentVerifyJob::DoneReading twice: (the first time from FileURLLoaderObserver::OnOpenComplete and the second time from FileURLLoaderObserver::OnDoneReading). This CL: 1. Move calling OnBytesRead+OnDoneReading for bad files to file_url_loader_factory; 2. Remove FileURLLoaderObserver::OnOpenComplete method; 3. Add DCHECKs in ContentVerifyJob so that we make sure OnDoneReading isn't called more than once. This also makes existing tests (e.g. ExtensionProtocolsTest.VerificationSeenForFileAccessErrors) serve as regression tests. TEST=unit_tests.ExtensionProtocolsTest.VerificationSeenForFileAccessErrors Change-Id: Ib91ecb7eaa5dad760068201903758df3f651dc5b Reviewed-on: https://chromium-review.googlesource.com/999484Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Nick Carter <nick@chromium.org> Commit-Queue: Mikhail Atuchin <atuchin@yandex-team.ru> Cr-Commit-Position: refs/heads/master@{#552158}
-
Kevin Marshall authored
SSH multiplexing makes SSH-based forwarding much more performant and reliable versus using separately negotiated connection. Connection overhead for runner_v2 SSH operations is also reduced. * Fix deployment path used to push the test server configuration to the target device. * Documentation fixes. Bug: 798851 Change-Id: I4d97204b0e3420e0ae8ce0ca8bcf6ca137dce46f Reviewed-on: https://chromium-review.googlesource.com/1018364 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#552157}
-
Esmael El-Moslimany authored
Bug: 825705 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Id73672e7614fcca0388119fdf8068b4a884dac2d Reviewed-on: https://chromium-review.googlesource.com/1015899Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#552156}
-
Mustaq Ahmed authored
Also cleanup other tests' dependency on user activation. Bug: 831331 Change-Id: Ic2268318336d64e0031fe782ec4c48b9d91ae36b Reviewed-on: https://chromium-review.googlesource.com/1006047Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#552155}
-
Sergey Ulanov authored
1. Added GN template for Fuchsia SDK packages, 2. Added targets for packages that are currently included in the SDK Bug: 831384 Change-Id: I7fabeab0814a099006aaa16fd119b4cd15fe0633 Reviewed-on: https://chromium-review.googlesource.com/1013284 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
James Robinson <jamesr@chromium.org> Cr-Commit-Position: refs/heads/master@{#552154}
-
sebsg authored
Bug: 834921 Change-Id: I35b6f7f72fa1253adf41092eed47761bad31725a Reviewed-on: https://chromium-review.googlesource.com/1020075Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#552153}
-
Fabio Tirelo authored
This parameterizes AutofillPopupControllerBrowserTest to run with the feature either enabled or disabled. The goal is to help us ensure it's to enable the feature for Canary/Dev. Other tests will be parameterized in follow up CLs. This CL was initially landed as crrev.com/c/1004923 and reverted by crrev.com/c/1014141 due to flaky tests on ChromeOS. After investigation we found that the flakiness is caused by a behavior in the underlying framework that should not happen during tests, even though the behavior in the product is correct (crbug.com/834768, crbug.com/834369). Chrome OS tests have been temporarily disabled by crrev.com/c/1019840 while a proper fix is implemented, so this CL should not introduce new flakiness on the waterfall. Bug: 768881 Change-Id: Id285013e504ebf66cc58cc27b01adc20906f3c7a Reviewed-on: https://chromium-review.googlesource.com/1019861 Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#552152}
-
danakj authored
If the compositor thread has released the resource in a TextureLayer and posted that release to the main thread, but then the MessageLoop on which the posted task sits shuts down, the TextureLayer's TransferableResourceHolder will be destroyed. This is because the holder is at that time singly owned by callback, as the resource is being released due to being removed (and unowned) by the main thread side. In this case, there is a posted-but-not-run dereference sitting in the MessageLoop which we can track, and avoid DCHECK-failing in the TransferableResourceHolder destructor. However, there is also the ReleaseCallback for the main thread in the TransferableResourceHolder that will DCHECK if not run, so we can run that SingleReleaseCallback from the TransferableResourceHolder destructor. This is done on the assumption that the MessageLoop is destroyed from the main thread (we can DCHECK this instead), and that the only case we have a SingleReleaseCallback in the destructor still is when all missing derefs have been posted but not run (we can DCHECK this as well). This fixes the flaky SoftwareTextureLayerMultipleRegisterTest, which could be resolved by using DidReceiveCompositorFrameAck() instead of DidCommitAndDrawFrame(), as that waits for the release callback to be run. But also resolves production issues where DCHECKs are hit during shutdown due to the MessageLoop being destroyed in this scenario (809604). R=piman@chromium.org Bug: 834613, 809604 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I3faa1cdcc58f1be99cf5f80732c63e51e9aff3d9 Reviewed-on: https://chromium-review.googlesource.com/1019614 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
-
Erik Chen authored
The test started flaking recently due to some refactoring I landed, specifically: https://chromium-review.googlesource.com/c/chromium/src/+/1006096. The only theory I have for how this could happen is if there's a RenderProcessHostImpl that stays stalled in the uninitialized state. This CL updates the waiting logic in the test to match the logic being tested - to only look at initialized RenderProcessHostImpls. Bug: 833590 Change-Id: Ia0d49f5c569625b3ccfc01c9dd17c8e7659f105d Reviewed-on: https://chromium-review.googlesource.com/1020071Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#552150}
-
Scott Chen authored
Bug: 815009 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: If3c93fa90def4d7332d077d54efe9a8ca2c51ea3 Reviewed-on: https://chromium-review.googlesource.com/988247 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#552149}
-
Tommy C. Li authored
Previously, we only ran FormattedStringWithEquivalentMeaning on the full formatted URL, but not the display (elided) URL. This function re-appends the '/' slash character on intranet hosts so they are not mistaken for a search term. We want to re-append this slash character on elided URLs as well, and this CL effects this change -- as well as adds a test for this. Bug: 797354 Change-Id: I29a6e8a4ce2986ec3eb0c024496b00c4e1dd4b79 Reviewed-on: https://chromium-review.googlesource.com/1014482Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#552148}
-
Peter Wen authored
https://github.com/google/error-prone/releases/tag/v2.3.0 BUG=834756 Change-Id: I518ccff734904320cd8c9cb3c42b41bc2c160bf2 Reviewed-on: https://chromium-review.googlesource.com/1019343 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#552147}
-
Miguel Casas authored
This reverts commit b4990829. Reason for revert: Needed to revert other CLs that caused a regression in video_VideoSeek: https://crbug.com/834146 Bug: 834146 Original change's description: > vaapi: minor cleanups in VaVDA (OutputPicture, mostly) > > This CL is a few cleanups to ease review of crrev.com/c/986353: > > - PictureById() is moved to the end of the cc file, following the > order of its declaration. Code untouched (except s/NULL/nullptr/). > A call to PictureById is substituted with base::ContainsKey() > to better reflect intent. > > - OutputPicture() loses its last parameter, that is then calculated > on the spot (it's |available_picture_buffers_.front()|). This makes > OutputCB unnecessary, so it's made a Closure, and a OnceClosure at > that. > > Test: eve crosvideo vp9 cycling resolutions. > > Bug: 822346 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel > Change-Id: Ie17f23f2fb20752463e9ebeacd1bf7a9b6150437 > Reviewed-on: https://chromium-review.googlesource.com/1000297 > Reviewed-by: Kristian H. Kristensen <hoegsberg@chromium.org> > Commit-Queue: Miguel Casas <mcasas@chromium.org> > Cr-Commit-Position: refs/heads/master@{#549506} TBR=mcasas@chromium.org,hoegsberg@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 822346 Change-Id: If0d162b5373c33c266268d9cd82e3de5fd4e4a7e Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1020003 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
-
Devlin Cronin authored
The PageActionCrash25562 test has been updated to manifest v2. Remove the allowance for manifest v1 extensions. Bug: 816679 Change-Id: I56c954aebb48a469cd7a9ab5c9f916d73498d5d5 Reviewed-on: https://chromium-review.googlesource.com/1018408 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
-
