GitLab

so that it uses the correct direction depending on the content

R=sky@chromium.org

Review URL: https://codereview.chromium.org/950943002

Cr-Commit-Position: refs/heads/master@{#317643}

We want to determine Sync's contribution to Browser startup. As such,
we will add code allowing us to disable Sync (or a part thereof) via
Finch.

The SupervisedUserService was/is not robust to disabling Sync (it
crashes). Since disabling sync is a generally supported feature
(there's a command line flag), that is now fixed.

BUG=454788

Review URL: https://codereview.chromium.org/933293005

Cr-Commit-Position: refs/heads/master@{#317642}

This is a partial revert of https://codereview.chromium.org/923283002
for chromecast/, since we reference AddKeySystemWithCodecs from
internal code. The functional changes are kept but the API changes
are reverted.

R=lcwu@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/947233003

Cr-Commit-Position: refs/heads/master@{#317641}

The will_close_handler parameter of RegisterDomain is never used.

Review URL: https://codereview.chromium.org/945193002

Cr-Commit-Position: refs/heads/master@{#317640}

The first step in adding full Client-Hints support on the Blink side is to delete the partial implementation from the Chrome side. This CL does that.

BUG=458983

Review URL: https://codereview.chromium.org/948843003

Cr-Commit-Position: refs/heads/master@{#317639}

Will merge this to M42, then revert on trunk.

BUG=460900

Review URL: https://codereview.chromium.org/949753006

Cr-Commit-Position: refs/heads/master@{#317638}

When these APIs were moved into //extensions the OWNERS files were
accidentially placed into their own subdirectories.

BUG=

Review URL: https://codereview.chromium.org/954523003

Cr-Commit-Position: refs/heads/master@{#317637}

They only have 5.1 installed

BUG=460930

Review URL: https://codereview.chromium.org/947273002

Cr-Commit-Position: refs/heads/master@{#317636}

Log events and debugging information related to USB devices through
the device event log so that these errors are visible on Chrome OS
at chrome://device-log.

BUG=455336

Review URL: https://codereview.chromium.org/941063003

Cr-Commit-Position: refs/heads/master@{#317635}

BUG=421946,456601

Review URL: https://codereview.chromium.org/946813003

Cr-Commit-Position: refs/heads/master@{#317634}

Material Design tile titles are 15px high, but on some (if not all)
platforms the natural height of title content is 14px high. This creates
a click "dead zone" on the tile. This CL forces content height to be
100% to remove the dead zone.

BUG=459301

Review URL: https://codereview.chromium.org/938473002

Cr-Commit-Position: refs/heads/master@{#317633}

BUG=454531

Review URL: https://codereview.chromium.org/946473002

Cr-Commit-Position: refs/heads/master@{#317632}

Change the behavior of fast user switching on Mac from Command click to right
click to be consistent with Windows and Linux.

BUG=458755

TEST=
1. Disable #enable-fast-user-switcher and enable #new-avatar-menu flags in chrome://flags
2. Relaunch Chrome
3. Right click on the Avatar Button, the fast user switcher should be shown
4. Command+Click on the Avatar Button, nothing should happen

Review URL: https://codereview.chromium.org/916523003

Cr-Commit-Position: refs/heads/master@{#317631}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/e0110920..46c7d681

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/949623003

Cr-Commit-Position: refs/heads/master@{#317630}

Review URL: https://codereview.chromium.org/932543003

Cr-Commit-Position: refs/heads/master@{#317629}

It is a waste of storage to save images that are larger than device
display size. On tablet we should be even more aggressive about resizing
those images, because showing them won't take up the entire screen.

BUG=454623

Review URL: https://codereview.chromium.org/916783003

Cr-Commit-Position: refs/heads/master@{#317628}

Instead of checking which generator is used to decide whether to use
ToT clang or Xcode clang, make the decision based on the buildtype
instead.

Use the version of clang shipped with Xcode for official build, and
leave the default selected for developer builds (default to ToT clang).

BUG=459148

Review URL: https://codereview.chromium.org/936013002

Cr-Commit-Position: refs/heads/master@{#317627}

Summary of changes available at:
https://chromium.googlesource.com/external/google-breakpad/src/+log/d5d1eac..764522e

764522e Add option to Breakpad to consume INVALID_HANDLE_VALUE exceptions.
f6875ca Cleanup Linux debug link file handling code.
09460c7 Fix overflow error in breakpad for linux
9172781 Add unit tests for overlapping functions and externs.
81794ad Handle ARM THUMB functions when removing duplicate PUBLIC entries.
e3e6501 Follow debug link correctly
f8eed74 Demangle symbol name
72a1fcf Handle failures of copying process data from a core file.
7b44faa Replace uses of hash_map with unordered_map
dad63f9 Remove unneeded definitions of O_BINARY
eb04cd8 Remove unused variable 'kGUIDStringSize' in microdump_writer_unittest.

BUG=

Review URL: https://codereview.chromium.org/948743002

Cr-Commit-Position: refs/heads/master@{#317626}

Move implemention for getting the how-to-use description to
the platform-agnostic class.

BUG=458301
TBR=sky@chromium.org (OWNERS for ui/extensions; Finnur reviewed)

Review URL: https://codereview.chromium.org/922523005

Cr-Commit-Position: refs/heads/master@{#317625}

- The profile creator was using integer indexing into the tab list, which
non-deterministically fails. The new code uses dictionary lookup.
- The profile creator was not robust against several types of exceptions that
occur more frequently with developer builds of Chrome.

BUG=442546

Review URL: https://codereview.chromium.org/939143004

Cr-Commit-Position: refs/heads/master@{#317624}

This is a hot fix to stop the builder from failing the CQ while it is
being debugged.

NOTRY=true
TBR=smut@chromium.org
BUG=460930

Review URL: https://codereview.chromium.org/940473003

Cr-Commit-Position: refs/heads/master@{#317623}

Removes GetCompositorMessageLoop from the ContextFactory interface,
and drops the compositor_thread_ members from the ContextFactory
implementations.

There is no compositor thread in the ui compositor so these are now
excess complication.

R=sievers
BUG=329552

Review URL: https://codereview.chromium.org/943763004

Cr-Commit-Position: refs/heads/master@{#317622}

BUG=379378

Review URL: https://codereview.chromium.org/902763002

Cr-Commit-Position: refs/heads/master@{#317621}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/14df835..477bc41

TBR=kbr@chromium.org,hiroshige@chromium.org

Review URL: https://codereview.chromium.org/952613002

Cr-Commit-Position: refs/heads/master@{#317620}

These files declare/define mojo TypeConverters, so the file names
should reflect that.

R=jamesr@chromium.org,msw@chromium.org
BUG=457280

Review URL: https://codereview.chromium.org/950573002

Cr-Commit-Position: refs/heads/master@{#317619}

Add TRACE_EVENT_FLAG_EXPLICIT_TIMESTAMP which is set when an explicit
timestamp is specified for the trace event. Only re-read clock if the
flag is set.

BUG=457441

Review URL: https://codereview.chromium.org/928563003

Cr-Commit-Position: refs/heads/master@{#317618}

Fixes warnings in the msvs-gyp generator.

This is a followup to
https://codereview.chromium.org/615893003 (gesture_event_type_list.h,
    popup_item_type_list.h, result_codes_list.h and
    top_controls_state_list.h)
https://codereview.chromium.org/861373002 (navigator_connect_service.h and
    navigator_connect_servive_factory.h)
https://codereview.chromium.org/865413002 (layer_tree_build_helper.h)
https://codereview.chromium.org/774573003 (platform_notification_service.h)

R=jam@chromium.org,avi@chromium.org,mek@chromium.org,dtrainor@chromium.org,changwan@chromium.org,peter@chromium.org
BUG=459058,405532,351558,426458,451313,439950

Review URL: https://codereview.chromium.org/952443004

Cr-Commit-Position: refs/heads/master@{#317617}

The ICU 54.1 upgrade added a call to uloc_getDefault() to
base/test/test_suite.cc, but did not add a libicuuc dependency
to the corresponding gyp/gn targets.  This makes it possible to
mix system and bundled ICU headers (and will fail to build if
they differ in version).

BUG=428145

Review URL: https://codereview.chromium.org/943233002

Cr-Commit-Position: refs/heads/master@{#317616}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/953df44..6bc1b5f

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=reed@google.com

Review URL: https://codereview.chromium.org/942113003

Cr-Commit-Position: refs/heads/master@{#317615}

Increase max number of copy operations from 16 to 32. This
improves the throughput on systems where raster performance
is relatively high.

BUG=454898

Review URL: https://codereview.chromium.org/937843006

Cr-Commit-Position: refs/heads/master@{#317614}

This Android-specific file isn't used anywhere anymore. Came up while
reviewing Daniel's CL: https://codereview.chromium.org/952443004/

BUG=

Review URL: https://codereview.chromium.org/953543002

Cr-Commit-Position: refs/heads/master@{#317613}

PowerSaveBlocker objects are constructed in response to web
audio and video to keep the system from suspending or
turning its display off. Historically, this was not used on
Chrome OS, as Chrome OS has alternate mechanisms for
detecting audio and video activity and using
PowerSaveBlocker would interfere with enterprise
power-management-policy prefs to ignore audio and video
activity.

However, low-framerate video, such as that used by WebRTC
for Hangouts screen-sharing, can fail to trigger Chrome OS's
video detection code, resulting in the screen being turned
off while in use. This change renames PowerSaveBlocker's
human-readable "reason" field to "description" and adds a
new Reason enum that Chrome OS uses to identify and ignore
audio- or video-triggered PowerSaveBlockers if needed.

BUG=354723,176405
TEST=watch /var/log/power_manager/powerd.LATEST on chrome os
     while on the receiving end of a screen-sharing hangout
     and observe that a policy is sent forcing the screen on

Review URL: https://codereview.chromium.org/946643002

Cr-Commit-Position: refs/heads/master@{#317612}

Browser needs to allow nested tasks to update backgroud tabs.
If rendered requests new system dialog, asan build crashes in COMDLG32.dll

NOTRY=true
BUG=451753

Review URL: https://codereview.chromium.org/934393003

Cr-Commit-Position: refs/heads/master@{#317611}

This determines if sync is initialized and syncing URLs with the
appropriate keystore passphrase type to support contextual searches.

BUG=460786

Review URL: https://codereview.chromium.org/946273002

Cr-Commit-Position: refs/heads/master@{#317610}

This avoids a spurious log error.

BUG=460889

Review URL: https://codereview.chromium.org/952533002

Cr-Commit-Position: refs/heads/master@{#317609}

Catch the error raised by 'check_call' rather than the error emitted by
the called process.

BUG=chromium:460693,chromium:459681
TEST=local
  - Ran without fix, setting CHROME_HEADLESS=1. Script failed with the exception
    in the bug.
  - Ran with fix, 'gsutil' failed with AccessDeniedException output
    and the calling script successfully emitted a warning message.

R=hinoka@chromium.org, navabi@chromium.org

Review URL: https://codereview.chromium.org/949813002

Cr-Commit-Position: refs/heads/master@{#317608}

TBR=mtomasz
NOTRY=true

Review URL: https://codereview.chromium.org/949823005

Cr-Commit-Position: refs/heads/master@{#317607}

BUG=459646

Review URL: https://codereview.chromium.org/940283007

Cr-Commit-Position: refs/heads/master@{#317606}

This addresses two issues:

- NSS clamps client_version to the session version. This means that a
  successful fallback connection is effectively cached, despite our fallback
  being stateless. This causing our metrics to be under-reported and, more
  problematic, makes spurious fallbacks stick.

- BoringSSL does not clamp, but many versions of OpenSSL on the server will
  happily resume older sessions at newer protocol versions, rather than doing a
  full handshake at the newer protocol version. This means a successful
  spurious fallback causes us later resume with a weaker cipher than we should.
  Moreover, this mismatch is forbidden by every other client implementation.
  The metrics are reporting 0.06% of connections on beta channel hit this case.
  I expect it to go down after this change.

Note: this will also increase traffic to version-intolerant servers on NSS
ports. But that's only Linux/CrOS/iOS now and the BoringSSL switch did the same
thing by losing the version clamp.

BUG=459690,441456

Review URL: https://codereview.chromium.org/947603002

Cr-Commit-Position: refs/heads/master@{#317605}

BUG=webrtc:4241

Review URL: https://codereview.chromium.org/943033004

Cr-Commit-Position: refs/heads/master@{#317604}