- 13 Feb, 2020 40 commits
-
-
Jose Lopes authored
The callback (init_cb_) is effectively called only once. This is guaranteed by the std::move(): https://cs.chromium.org/chromium/src/media/blink/multibuffer_data_source.cc?rcl=8d2d53d6df3c7347f9d4c32074540b990a8f1736&l=631 This is part of the base::Callback migration. Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40 Change-Id: I1ba81f8b281339cf514baa7f6739425bb9b9988c Bug: 714018 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030962 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Auto-Submit: Jose Lopes <jabolopes@google.com> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#741166}
-
Alex Turner authored
Currently, the enabled flag is ignored for the AdTracker, which leads to some synchronous requests being erroneously reported as async. When the enabled flag is false, the task should not be reported to AdTracker. Bug: 1051519 Change-Id: Ia42ba7e6117ad2fc59cd95d41fcb8b1c5650a784 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045176 Commit-Queue: Alex Turner <alexmt@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#741165}
-
Piotr Bialecki authored
The approach to performing hit test has changed, the new API that replaces the legacy one is already enabled by default in M81. https://immersive-web.github.io/hit-test/ Change-Id: Ia89921505ae4ed537c28b117808182efbc79396c Fixed: 1051626 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050582Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#741164}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3a866d1f61a1..0715f3d5b5f1 Created with: gclient setdep -r src-internal@0715f3d5b5f1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1050954 Tbr: jbudorick@google.com Change-Id: I20e72ef4b6de9b6baebe76362957dd00ee3d54a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054984Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#741163}
-
Marc Grimme authored
This reverts commit 8bc1fa58 because once again the PolicyDeviceDisplayResolution tests are flaky. The root cause needs to be investiated a tracking bug is filed #1051982. R=marcgrimme Bug: 1050303 Change-Id: Icd1cdb3f29dbb2fb78cea769c7fa36906405f7d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054803Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Marc Grimme <marcgrimme@chromium.org> Cr-Commit-Position: refs/heads/master@{#741162}
-
Etienne Bergeron authored
Plumb the code to get an experiment for studying the best ShapeRuns cache size. The entries of these cache are part of the top allocations in chrome browser process (based on memlog reports). Bug: 1050793 Change-Id: I51ca6aebfe6c8ae3881eb3c03a56b4d472216ec7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051976 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#741161}
-
Sebastien authored
Bug: 1029328 Change-Id: I4edcabad6ee26e34d9039c35f8ee4a38720b0210 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942807 Auto-Submit: Sebastien Lalancette <seblalancette@chromium.org> Commit-Queue: Jesse Doherty <jwd@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#741160}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e82ab75a4ca8..b79b57e047bb git log e82ab75a4ca8..b79b57e047bb --date=short --first-parent --format='%ad %ae %s' 2020-02-13 lexa.knyazev@gmail.com Vulkan: expose ANGLE_compressed_texture_etc Created with: gclient setdep -r src/third_party/angle@b79b57e047bb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: courtneygo@google.com Change-Id: Ibd939ff1eeb295f7cc793fec86d58084a05839dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055046Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#741159}
-
Sonny Rao authored
The test assumes both Active and Inactive file and Anon fields will both be non-zero but this may not be the case. We see this especially when running kstaled on CrOS. Bug: 1048073 Change-Id: I7532d92f4cd69718aab01d263992b20054a621e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042544Reviewed-by:
Brian Geffon <bgeffon@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Auto-Submit: Sonny Rao <sonnyrao@chromium.org> Commit-Queue: Sonny Rao <sonnyrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#741158}
-
John Chen authored
Currently run_py_tests.py shows test descriptions as part of its output. These descriptions are not useful while reviewing test results, and clutter the output. Modify settings to not show these descriptions. TBR=crouleau@chromium.org Change-Id: Ibb0c621aa33d18dd02e565281094a02a5d6914ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053112Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#741157}
-
Dave Tapuska authored
Use gfx::RectF types natively and avoid using WebFloatRect. Change-Id: I750d75718465bcd44cfaee10cd5239cf38e9d0ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051582 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#741156}
-
Emircan Uysaler authored
This CL adds a new state to ScenicWindow that checks if the view is attached to a rendered scene graph. Bug: 1044802 Change-Id: Ieeb98a2bbe4d214fed302d60360dd77f0b702838 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015675 Commit-Queue: Emircan Uysaler <emircan@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#741155}
-
Victor Costan authored
This reverts commit 93682cb5. Reason for revert: The feature crashes on Windows -- https://crbug.com/1052041 Original change's description: > AppCache: Enable correct 304 handling by default. > > We'll monitor the fix as it goes through the Chrome release waterfall, > instead of doing a Finch-based trial. This frees us from having to > reason about enterprises that may disable Finch. > > Bug: 989611 > Change-Id: I50389c12d31f63fa6257d879f3d840ffde2cb27e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052245 > Commit-Queue: Victor Costan <pwnall@chromium.org> > Commit-Queue: Chase Phillips <cmp@chromium.org> > Auto-Submit: Victor Costan <pwnall@chromium.org> > Reviewed-by: Chase Phillips <cmp@chromium.org> > Cr-Commit-Position: refs/heads/master@{#740894} TBR=cmp@chromium.org,pwnall@chromium.org Change-Id: Ieeb9be42038ba56e176b0ba6a7ab0c84629fea1c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 989611 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055007Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#741154}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/0fd93555a59a..fbbf981a3401 git log 0fd93555a59a..fbbf981a3401 --date=short --first-parent --format='%ad %ae %s' 2020-02-13 tvanderlippe@chromium.org Migrate sources/ to import cross-module 2020-02-13 tvanderlippe@chromium.org Migrate main/ to import cross-module 2020-02-13 tvanderlippe@chromium.org Migrate css_overview/ to import cross-module 2020-02-13 khamu@microsoft.com Add high contrast styles for Memory tools panel. 2020-02-13 khamu@microsoft.com Add high contrast fix in Performance tools panel. Created with: gclient setdep -r src/third_party/devtools-frontend/src@fbbf981a3401 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1006759,chromium:1048378 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia6b38e27f8aded82a4509ab93a98054d866c2bec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055044Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#741153}
-
Maks Orlovich authored
This is basically Aaron Tagliaboschi's: https://chromium-review.googlesource.com/c/chromium/src/+/2012902 just with a bit of additional updated of tests. See https://github.com/WICG/ua-client-hints/issues/15 for rationale. Change-Id: I6562cf1a78ceb4eff18baf793cb89143782f9b7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047410 Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#741152}
-
Khushal authored
This reverts commit 16fc868a. Reason for revert: crbug.com/1051940 Original change's description: > canvas2d: Fix canvas resource thrashing with an intermediate canvas. > > If a canvas is used as an intermediate for drawing to the displayed > canvas multiple times in a frame, then a ref to its backing texture is > retained in the displayed canvas' paint recording. This triggers a > copy-on-write and a buffer allocation each time this intermediate canvas > is updated for a new draw. > > The above allocation can be avoided by ordering the GPU work > to write to and read from the intermediate canvas' buffer correctly and > reuse the buffer for each update to this intermediate canvas. > CanvasResourceProviderSharedImage did this optimization earlier by > flushing skia prior to triggering a copy-on-write. But after disabling > deferral for texture backed images, the draw for that texture is never > flushed to skia until the displayed canvas' paint recording is flushed. > > This change brings back the optimization by flushing a canvas' recording > each time a texture backed image is drawn to it. > > R=fserb@chromium.org, bsalomon@google.com > > Bug: 1030108 > Change-Id: Id46fa8399f64a4c724c9f51e5cb4927b7e97d747 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040028 > Reviewed-by: Fernando Serboncini <fserb@chromium.org> > Reviewed-by: Aaron Krajeski <aaronhk@chromium.org> > Commit-Queue: Fernando Serboncini <fserb@chromium.org> > Auto-Submit: Khushal <khushalsagar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#740005} TBR=bsalomon@google.com,fserb@chromium.org,khushalsagar@chromium.org,aaronhk@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1030108 Change-Id: I7931a623c4c16dada7dc56f1c78f88aee8da4d96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054271Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Aaron Krajeski <aaronhk@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#741151}
-
John Z Wu authored
Bug: 1048231 Change-Id: I34eaf7227400136fea1bfc70f7d5c48fa8498bf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048287 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#741150}
-
Mohamed Amir Yosef authored
Bug: 1044038 Change-Id: I4857b10121e2c8dba95f1d5b58f57a0874294c64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053884 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#741149}
-
Jeffrey Kardatzke authored
This fixes a DCHECK that would occur if Initialize failed because then in CreateWithOutputMode it would let the unique_ptr for the image_processor fall out of scope and become deallocated; and we have a sequence checker to ensure deallocation only happens on the task runner. I would have used DeleteSoon, but that didn't seem possible because the destructor was not public. BUG=1050852 TEST=image_processor_test no longer DCHECKs on elm w/ 4.19 kernel Change-Id: Ifae96c3a4206d8e94b7fdd6dd3e2ec571cc3465b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051162Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: J Kardatzke <jkardatzke@chromium.org> Cr-Commit-Position: refs/heads/master@{#741148}
-
David Schinazi authored
The following users no longer work on Chrome Networking: rch@ jri@ ckrasic@ bnc@. Change-Id: If828d3be1200ca6bba367f6a71871b71b7998213 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053143 Auto-Submit: David Schinazi <dschinazi@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#741147}
-
John Chen authored
While build for android, ChromeDriver can be built using host toolchain. Bug: 1050709 Change-Id: Ifc7b97f4474e73e3025ec33450bdfd29559ba087 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050872Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#741146}
-
Min Qin authored
Chrome cannot open zip files. As a result, directing users to the download Home won't help. This CL will check if Files app are present on the device, and then open the files app if no other apps register as the default handler for zip file. BUG=1050632 Change-Id: I052012113c2d38d52c37088839d75af5b206443d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052570Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#741145}
-
Manu Cornet authored
Change-Id: Idae5f3fec0e8fbcbf1dbff9a3982e0a90b64d900 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053249 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by:
Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#741144}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3bf3b92dfab0..55f040bcb943 git log 3bf3b92dfab0..55f040bcb943 --date=short --first-parent --format='%ad %ae %s' 2020-02-13 egdaniel@google.com Revert "Pass origins through the flushSurfaces calls." 2020-02-13 egdaniel@google.com Pass origins through the flushSurfaces calls. 2020-02-13 reed@google.com check for non-finite values in point3 case Created with: gclient setdep -r src/third_party/skia@55f040bcb943 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC stani@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1050296 Tbr: stani@google.com Change-Id: Id3408057ca486c9046a2d53507b7b247a5d221ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053300Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#741143}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/29cc24586074..503b21fd3203 git log 29cc24586074..503b21fd3203 --date=short --first-parent --format='%ad %ae %s' 2020-02-13 swiftshader.regress@gmail.com Regres: Update test lists @ ac4e1d23 Created with: gclient setdep -r src/third_party/swiftshader@503b21fd3203 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Ibb3d955986aad25c1fff1e3d66145f64fff643cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053297Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#741142}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f63b3f36..7db08fd9 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib4745ab6e198fcbe2675f9c77fdba66206593f19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054823Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#741141}
-
David Grogan authored
Now it won't fail when it expects LayoutFlexibleBox but sees LayoutNGFlexibleBox Fixes compositing/video/video-poster.html paint/invalidation/video-paint-invalidation.html paint/invalidation/image/canvas-composite-repaint-by-all-imagesource.html virtual/android/fullscreen/video-overlay-scroll.html Bug: 845235 Change-Id: I7cad9787294e8f0b9cf233c769028c1bc571c507 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053423Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#741140}
-
Tom Anderson authored
Fixes regression in git status after CL [1]: $ git status On branch master Your branch is up to date with 'origin/master'. Untracked files: (use "git add <file>..." to include in what will be committed) third_party/weston/src/ [1] https://chromium-review.googlesource.com/c/chromium/src/+/1962128 BUG=1029241 TBR=sky NOTRY=true Change-Id: I0ae0c757124edbc267a040935f85d203422fc57e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054273Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#741139}
-
Christian Biesinger authored
Make it a longhand and remove the -width/-height/-block-size/-inline-size longhands. Bug: 991096 Change-Id: Id5ef3e8a3d4af157eb4e4e9a702523bb73915397 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052330 Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#741138}
-
Stephen Chenney authored
TBR: noel@chromium.org Bug: 1034283 Change-Id: Icfc01be5a5c0e8c61dd8878065842fe2127a23b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053928Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#741137}
-
Etienne Bergeron authored
This CL is handling the \r character in RenderText. The sequence "\r\n" is a grapheme and is a processed as a newline by RenderText. Bug: 1050607, 1019061 Change-Id: I161d1e08fe65225f78556b861847dd1b1ee22230 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051972 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#741136}
-
Matt Jones authored
Bug: 1052024 TBR: rayankans@chromium.org Change-Id: I27da159c3e85b164997be5fa3e8752f96b5eadda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055004Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#741135}
-
Stephen McGruer authored
TBR=chrisha@chromium.org Bug: 1051006 Change-Id: I4a5b4e1ff1b5a837a75f0895022ed338ee070229 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054297Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#741134}
-
Daniel Rubery authored
While the comment says "Must shut down last", there's no clear reason why this would be needed. So move it first to see if there's a subtle reason it should be last. Change-Id: I8e778d100aeeba15d88c22e907cb369787e601e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050677 Commit-Queue: Daniel Rubery <drubery@chromium.org> Auto-Submit: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#741133}
-
Avery Musbach authored
When you long press the overview button tray in tablet overview, it shall trigger tablet split view without requiring two overview windows. All/SplitViewControllerTest.LongPressInOverviewMode/? Test: ash_unittests Bug: 1045990 Change-Id: I554ed3bf39387d6e42dbb27fe1bdf91c97da1b80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052566Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#741132}
-
Filip Gorski authored
This step follows comment #6 on the bug. It moves the library process type from the constructor and adds it to 2 startup methods. At the same time it renames get() to getInstance(). Bug: 841403 Change-Id: I64495840b917534bca623be70f6b8511ab45e90d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039141Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#741131}
-
Tricia Crichton authored
Enable the collection of minidumps on Windows and Mac instead of only on linux. Bug: 1045241 Change-Id: Ib81420783c02b27d1edef2e575bb1b2369da5846 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055003Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tricia Crichton <triciac@chromium.org> Cr-Commit-Position: refs/heads/master@{#741130}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2eb32c696cc8..3a866d1f61a1 Created with: gclient setdep -r src-internal@3a866d1f61a1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1045976 Tbr: jbudorick@google.com Change-Id: I114ffa4e90bd938b157ad05faf9bfdd928529d9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053298Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#741129}
-
John Z Wu authored
It will be easier to mock/fake the password controller in unit tests. Bug: 1048256 Change-Id: Icaee411736f3a58ca0978a50762a014775deb032 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047488Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Commit-Queue: John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#741128}
-
Mugdha Lakhani authored
Change-Id: Ic861b9f8cfaab2270f9e62404f9cf5a36dbf09ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050490 Auto-Submit: Mugdha Lakhani <nator@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#741127}
-