- 11 Feb, 2020 40 commits
-
-
Nikita Podguzov authored
This change includes special handlers for ArcPolicy, NativePrintersBulkConfiguration, DeviceNativePrinters, ExternalPrintServers policies and "Dictionary" data type policies for extensions. Now it's allowed to use commas after last objects in JSON lists and dictionaries. Bug: 843988 Change-Id: I3ced2d1cfb3e009287b95ee07ccc47595ae29edf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041618Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
Bartosz Fabianowski <bartfab@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Nikita Podguzov <nikitapodguzov@chromium.org> Cr-Commit-Position: refs/heads/master@{#740251}
-
Koji Ishii authored
TBR=ikilpatrick@chromium.org Bug: 1050315 Change-Id: I2ea0191336657a91472c3407f507a6a0c7eec5d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049012Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#740250}
-
Maksim Moskvitin authored
This CL changes behavior on failed requests: 1. When request fails with auth error, access token isn't invalidated if the request was sent with old access token. 2. When request fails with other errors, which allow retry, access token is refreshed right before retry. Bug: 1020117 Change-Id: Ie7123eab78ecf1a4dee2b8ae4efe8d931f2ea15a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047226Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#740249}
-
Huanzhong Huang authored
Bug: 1045348 Change-Id: I6bce0d04ace4fe3d6694ec5103d407f9be4cb604 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044097Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Huanzhong Huang <huanzhong@chromium.org> Cr-Commit-Position: refs/heads/master@{#740248}
-
Demetrios Papadopoulos authored
Bug: 1026426 Change-Id: Id6b62c39b9184532a8e3e3c34c2bdee98a37240e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045171 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#740247}
-
chromium-autoroll authored
Roll broadwell AFDO profile from 82-4028.0-1581331201-benchmark-81.0.4044.14-r1 to 82-4028.0-1581331201-benchmark-81.0.4044.15-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I96e4d4403104edc787c90d3c8d2cd1ea7e11ee36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050086Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#740246}
-
Chromium WPT Sync authored
Using wpt-import in Chromium db8ecb4a. With Chromium commits locally applied on WPT: 5579aad0 "SharedWorker: Name shared workers identically in credentials mode WPT" 822dbfeb "[LayoutNG] Clip when hit-testing floats inside clipped containers." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: bjonesbe@adobe.com: external/wpt/css/css-shapes domenic@chromium.org, ricea@chromium.org: external/wpt/streams foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools hongchan@chromium.org, rtoy@chromium.org: external/wpt/webaudio NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Id2c503814900ce3e117f6d86380a64806a70127b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050123Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#740245}
-
Ken Rockot authored
Prior to this CL, blink.mojom.SessionStorageNamespace had two methods: OpenArea() and Clone(). OpenArea() takes an Origin argument which must be validated by browser security policy, while Clone() should go directly to the Session Storage implementation (eventually in the Storage Service, which may run outside of the browser). This CL reduces SessionStorageNamespace to only the Clone() method, while moving Session Storage's StorageArea binding to a new message on StoragePartitionService. No functional changes, just implementation plumbing so that the same effective behavior is preserved over the new IPC layout. Bug: 1000959 Change-Id: I6dcb8d52e7b4c34d58590fb6fbafb3f263e70fbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045208Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#740244}
-
Morten Stenshorne authored
Change-Id: I1ee2e4c4f78a6471a4db50939076f13f9f978926 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048423Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#740243}
-
Peter Kasting authored
In refactoring I omitted a construction call, oops. Bug: 1050801 Change-Id: I2712a470b1f009bdf1b458b774811dd38320744e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048308 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#740242}
-
chromium-autoroll authored
Roll silvermont AFDO profile from 82-4037.0-1581330937-benchmark-81.0.4044.14-r1 to 82-4037.0-1581330937-benchmark-81.0.4044.15-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I0195760037959fe58627458aae212a09a97d3433 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050085Reviewed-by:
-
Darwin Huang authored
Remove extraneous namespacing in: - //third_party/blink/renderer/core/clipboard - //third_party/blink/renderer/modules/clipboard Refactoring change. No intended functional changes. Change-Id: I429ccb28faa94a0641d0e2e8a93564265c250023 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048031 Commit-Queue: Victor Costan <pwnall@chromium.org> Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
-
Jose Lopes authored
The origin filter callback is used as part of a for loop so it's repeating: * https://cs.chromium.org/chromium/src/components/domain_reliability/context_manager.cc?rcl=5d9822b10066adfbb4f5b1b0b677d2b04600ca4c&l=80 * https://cs.chromium.org/chromium/src/components/domain_reliability/context_manager.cc?rcl=5d9822b10066adfbb4f5b1b0b677d2b04600ca4c&l=105 This is part of the base::Callback migration. Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40 Change-Id: I9cc19b765c405ca218d2581a13a02c7a4daaac5b Bug: 714018 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030960 Auto-Submit: Jose Lopes <jabolopes@google.com> Reviewed-by:
Lily Chen <chlily@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Jose Lopes <jabolopes@google.com> Cr-Commit-Position: refs/heads/master@{#740239}
-
Isabella Scalzi authored
Bug: 803259 Change-Id: Ie56282ccf14edaa1cff0bb092c4be07b51d1691c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049006 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#740238}
-
Maksim Moskvitin authored
StartPendingSubscriptionRequest() might be called while there is no changes in corresponding request. Old behavior is to cancel the request and start the new one, new behavior is to do nothing. The purpose of this change is to avoid redundant traffic and make redundant StartPendingSubscriptionRequest() calls almost zero-cost to simplify further improvements. Bug: 1020117 Change-Id: I7458debc54505fd25bfe9f37c16a431ff0ce87cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047244 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
-
Eric Seckler authored
The deprecated TRACE_EVENT_ASYNC* macros have been superseded by TRACE_EVENT_NESTABLE_ASYNC*. Updating to the new macros is mostly straight-forward, except in cases where STEP_INTO/PAST macros were used extensively: In those cases, the steps have been converted into nested sub-events. Bug: 1038710 Change-Id: I43faf61f15544b4a097dc3cb00ce2773fed922db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041624Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#740236}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/549953bc1d82..fec8f201c2c6 Created with: gclient setdep -r src-internal@fec8f201c2c6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ibd7780ff4eb9bec76eced29bc162402bee1b6f50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049610Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#740235}
-
Zinovy Nis authored
Change-Id: Id26d5ecb09fc21301dde8eb0cf067fa4edc18d2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044217Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Commit-Queue: Zinovy Nis <zynis@yandex-team.ru> Cr-Commit-Position: refs/heads/master@{#740234}
-
Sylvain Defresne authored
Since the bug report UI uses a MDCAppBar, hide the navigation bar when displaying it to avoid having the tile displayed twice which breaks tests. Bug: 1042741 Change-Id: I8c491be4d8a05ffa71f780896c74cd23c7a988c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048912 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#740233}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/be1f489fde92..c7b6ede78ab7 git log be1f489fde92..c7b6ede78ab7 --date=short --first-parent --format='%ad %ae %s' 2020-02-11 eseckler@google.com processor: Fix chromium build 2020-02-10 treehugger-gerrit@google.com Merge "Reland "processor: Parse legacy json DebugAnnotations during import"" 2020-02-10 lalitm@google.com Merge "tp: add helper virtual table for computing duration from counter" Created with: gclient setdep -r src/third_party/perfetto@c7b6ede78ab7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I192b6d0c1c23ec7bd3fa5cb3f89656d03d50cc95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050025Reviewed-by:
-
Manuel Rego Casasnovas authored
r727590 introduced a regression regarding visual overflow of inline elements (inline legacy objects don't know how to recompute their visual overflow). An initial fix landed in r736422 but it was not good enough, we used IsInLayoutNGInlineFormattingContext() to check if it was a LayoutNG object, but that can be true even with legacy objects in some situations. The fix now is to use IsLayoutNGObject() instead. Apart from that we're moving from IsInline() to !IsLayoutBlock() (as it was on the old code) because we don't need to relayout things like "inline-block" as legacy blocks already know how to recompute the visual overflow. BUG=1048092,1043927 TEST=ParameterizedLayoutInlineTest.VisualOverflowRecalcLegacyLayoutPositionRelative Change-Id: I71d0fcc4b7827b94c7e14a8bc4aa5808741c644f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2046983Reviewed-by:
-
Eric Seckler authored
The deprecated TRACE_EVENT_ASYNC* macros have been superseded by TRACE_EVENT_NESTABLE_ASYNC*. Updating to the new macros is mostly straight-forward, except in cases where STEP_INTO/PAST macros were used extensively: In those cases, the steps have been converted into nested sub-events. Bug: 1038710 Change-Id: I033e75fbdb81988ec323f606f5b37ad35eda9052 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041757 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#740230}
-
Yuki Shiino authored
Bug: 839389 Change-Id: I012a928a85ae2368241f39608cfb6b7ff7c7b444 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047003Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#740229}
-
Dominik Röttsches authored
See discussion in https://groups.google.com/a/chromium.org/g/platform-architecture-dev/c/i7nB2Tzmnv8/m/CbBvs3TrCQAJ Add a WTF LRUCache to cover situations as for example in CSSSegmentedFontFace and CSSFontFaceSource to be able to use caching HashMaps but limit their growth. Bug: 1010925 Change-Id: Ia1e684d293bfcd165624c905fdc821ee529e8b54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837794Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#740228}
-
Peter Kasting authored
update_service.cc #includes headers from content/public/browser/ but does not have a .gn deps on the target that contains them. This resulted in the build failure in https://ci.chromium.org/p/chromium/builders/ci/win32-archive-rel/10065 . Bug: none Change-Id: I1fcf95cd729d197a0f036a8143fa18eec8f78b51 TBR: waffles Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049613Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#740227}
-
Jose Lopes authored
The callback is used to report progress and can be called multiple times from different entry points (e.g., ReadTask, SeekTask, StartCallback, and ProgressCallback): https://cs.chromium.org/chromium/src/media/blink/multibuffer_data_source.cc?rcl=8d2d53d6df3c7347f9d4c32074540b990a8f1736&l=686 This is part of the base::Callback migration. Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40 Change-Id: Ia3c14335588bc2111b43c30cc79fb4a798c822d1 Bug: 714018 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033147Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
-
anina koehler authored
Replace the SchemaOnErrorStrategy SCHEMA_ALLOW_INVALID with SCHEMA_ALLOW_UNKNOWN because it will be removed. Bug: 969706 Change-Id: I49ba60278acf70ccf22385b01a20ea3079dca52b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027331Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Commit-Queue: Anina Koehler <aninak@google.com> Cr-Commit-Position: refs/heads/master@{#740225}
-
Fergus Dall authored
Our current handling of this is wrong in multiple ways. First, we expect aura to report mouse wheel scrolls in discrete multiples of 53, where it actually seems to use a base unit of 16. Second, we expect our clients to receive values at a scale of 10 units per scroll click, where they actually seem to expect a scale of 5. Some apps (e.g. VS Code, Firefox) only process scroll events in discrete intervals. If the scroll amount is not a multiple of 5, they will "save up" the left over bit to apply to the next scroll event. The above issues combine with this to cause around half of all scroll wheel clicks to be apparently ignored by the application. This CL corrects the scaling ratios, and documents where the new values came from. It also adds support for the wl_pointer::axis_discrete event, which should be sent for mouse wheel scrolls. Bug: 1039157 Change-Id: Id7568bd418e94692538a1572959286cef86a84ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993062 Commit-Queue: Fergus Dall <sidereal@google.com> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Nic Hollingum <hollingum@google.com> Cr-Commit-Position: refs/heads/master@{#740224}
-
Jose Lopes authored
The callback can be invoked multiple times in the for loop: https://cs.chromium.org/chromium/src/net/dns/host_cache.cc?rcl=f1e0ecaf7d175cf0f4eb923daa10511be4b11931&l=697 This is part of the base::Callback migration. Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40 Change-Id: I5501e1b5041c1ab80f30a7c59c557f02d160eae8 Bug: 714018 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031037 Commit-Queue: Jose Lopes <jabolopes@google.com> Auto-Submit: Jose Lopes <jabolopes@google.com> Reviewed-by:
Eric Orth <ericorth@chromium.org> Reviewed-by:
-
Anders Hartvoll Ruud authored
This is no longer used. Bug: 947004 Change-Id: I6d93f2500ff4f7cef2d5bd00c19a5c4fa9b8100b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041617 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#740222}
-
Denis Kuznetsov authored
Bug: 955194, 1047807 Change-Id: Ie18e7618bb99d19e2d69e9b3a30803884ba20433 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047165 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Auto-Submit: Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#740221}
-
Mei Liang authored
Change-Id: I003fbc5ee9b28ca6dbb8207ef43e4e23615ff76e Bug: 1043500 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043099 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by:
David Maunder <davidjm@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#740220}
-
Jan Wilken Dörrie authored
This change makes sure that Touch To Fill does not show an empty sheet to the user if no credentials are present. This case is treated as if the user dismissed the sheet, so that the soft keyboard gets triggered automatically. Bug: 1050565 Change-Id: Ie6aabe78d5cab285c13766b5ed04e5bbe3ba0f1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047184 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
-
Luciano Pacheco authored
Change column header sorting icon to use 'no-overlap' CSS class to remove margin around the icon, instead of overwriting via CSS. Remove unnecessary background and fill colors from display:none sort icon. Change rounded icons to use border-radius: 50% instead of static pixels. Bug: 992821 Change-Id: Ia304ed3a89bdc58b32ab610a1880878d9d18cb0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049984 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
Raul Tambre authored
urllib.pathname2url() in Python 2. urllib.request.pathname2url() in Python 3. Use a custom module name and import depending on Python version. Traceback (most recent call last): File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 556, in <module> sys.exit(main()) File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 551, in main return args.func(args, remaining_args) File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 267, in _Generate processor._GenerateModule(args, remaining_args, generator_modules, File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 199, in _GenerateModule imports[parsed_imp.import_filename] = self._GenerateModule( File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 199, in _GenerateModule imports[parsed_imp.import_filename] = self._GenerateModule( File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 238, in _GenerateModule generator.GenerateFiles(filtered_args) File "C:\Google\chromium\src\mojo\public\tools\bindings\generators\mojom_js_generator.py", line 369, in GenerateFiles self.WriteWithComment(self._GenerateAMDModule(), "%s.js" % self.module.path) File "C:\Google\chromium\src\mojo\public\tools\bindings\pylib\mojom\generate\template_expander.py", line 37, in GeneratorInternal return ApplyTemplate(args[0], path_to_template, parameters, **kwargs) File "C:\Google\chromium\src\mojo\public\tools\bindings\pylib\mojom\generate\template_expander.py", line 30, in ApplyTemplate return template.render(params) File "C:\Google\chromium\src\mojo\public\tools\bindings\pylib\mojom\generate\..\..\..\..\..\..\..\third_party\jinja2\asyncsupport.py", line 76, in render return original_render(self, *args, **kwargs) File "C:\Google\chromium\src\mojo\public\tools\bindings\pylib\mojom\generate\..\..\..\..\..\..\..\third_party\jinja2\environment.py", line 1008, in render return self.environment.handle_exception(exc_info, True) File "C:\Google\chromium\src\mojo\public\tools\bindings\pylib\mojom\generate\..\..\..\..\..\..\..\third_party\jinja2\environment.py", line 780, in handle_exception reraise(exc_type, exc_value, tb) File "C:\Google\chromium\src\mojo\public\tools\bindings\pylib\mojom\generate\..\..\..\..\..\..\..\third_party\jinja2\_compat.py", line 37, in reraise raise value.with_traceback(tb) File "gen\mojo\public\tools\bindings\js_templates.zip\tmpl_3ded8450c36dc0f89ab9459f617a5a73f83f3d2a.py", line 29, in <module> File "C:\Google\chromium\src\mojo\public\tools\bindings\generators\mojom_js_generator.py", line 218, in GetRelativeUrl return urllib.pathname2url( AttributeError: module 'urllib' has no attribute 'pathname2url' Bug: 941669 Change-Id: Icc7b07a75ba172bef11a949e2e6f22f50a690ca6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2046170Reviewed-by:Ken Rockot <rockot@google.com> Commit-Queue: Raul Tambre <raul@tambre.ee> Cr-Commit-Position: refs/heads/master@{#740217}
-
Luciano Pacheco authored
Rename column dragger to small-dragger to differentiate from the other dragger. Add the small-dragger.svg is the same content as used in the icons.html. Bug: 992821 Change-Id: I252f5fc7a44c64353b98d3fa39cbf56268d79a9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050043 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
Isabella Scalzi authored
Bug: 803259 Change-Id: I56e270bce85c07dc2b6975ce95771916f25c8426 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049423 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
Alan Cutter authored
This CL renames GetAppScope() to GetAppScopeInternal() and adds a new GetAppScope() implementation that returns a default value if there's no scope. This is in preparation to migrate all existing uses of GetAppScopeInternal() over to the new GetAppScope() such that PWAs behave the same whether they passed install promotability checks or not. There are no behavioural changes in this CL. The follow up CLs will convert GetAppScopeInternal() calls back to GetAppScope() with slight behaviour changes. Bug: 910016 Change-Id: Ifd0f39beb74ff7e4de4a0f8a407c47e33cf41e1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049463 Commit-Queue: Alan Cutter <alancutter@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Cr-Commit-Position: refs/heads/master@{#740214}
-
Gauthier Ambard authored
This CL adds a way of creating JavaScript to replace the content of the page with some HTML in ErrorPageHelper. Bug: 991608 Change-Id: I31b703fee025387e20215dd6edfa6b8b2e4e8b83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027787 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#740213}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/72f2915aa3b4..4a0f1a01ac8a git log 72f2915aa3b4..4a0f1a01ac8a --date=short --first-parent --format='%ad %ae %s' 2020-02-11 maawas@microsoft.com Add a null check on return value of CPDF_StructTree::AddPageNode(). Created with: gclient setdep -r src/third_party/pdfium@4a0f1a01ac8a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I2bf9ea862c7e9109d1b99c6154d47b2f19a5174c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049666Reviewed-by:
-
