- 15 Feb, 2018 40 commits
-
-
wutao authored
This cl adds a horizontal line class to separate item views in Keyboard Shortcut Viewer (KSV). Bug: 768932 Test: Manually test that the separator line is correctly created. Change-Id: Ia09d52ad120bc4d2ba9d36eef4fce27225ecfedb Reviewed-on: https://chromium-review.googlesource.com/911980Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#536952}
-
Takayoshi Kochi authored
This is a reland of 391d909b. This was once reverted due to potential cause for Mac bot's flakiness: crbug.com/805383 Original change's description: > Remove dead code after multiple shadow removal [4/5] > > Remove ShadowRoot::{Younger,Older}ShadowRoot > > Bug: 795221 > Change-Id: Ib4754de2184d08db9bb5fc35379f27dea5ef2997 > Reviewed-on: https://chromium-review.googlesource.com/831810 > Commit-Queue: Takayoshi Kochi <kochi@chromium.org> > Reviewed-by: Hayato Ito <hayato@chromium.org> > Reviewed-by: Rune Lillesveen <futhark@chromium.org> > Cr-Commit-Position: refs/heads/master@{#531478} TBR=hayato@chromium.org, futhark@chromium.org Bug: 795221 Change-Id: I61a8c2d7b39398fc676515f67a7c0d0a9536da22 Reviewed-on: https://chromium-review.googlesource.com/920941Reviewed-by:
Takayoshi Kochi <kochi@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Takayoshi Kochi <kochi@chromium.org> Cr-Commit-Position: refs/heads/master@{#536951}
-
Wenzhao Zang authored
The old wallpaper picker must generate and save a thumbnail for each custom wallpaper, so that they can persist even after the original image file is deleted. This is not needed for the new picker: the thumbnails under 'My Photos' section are real-time representation of the files under Downloads. We do not want to cache or save them since the files may change all the time. Therefore, to simplify the logic, we only need to read the image data, and then use CSS to resize the image to display as the thumbnail (the same with backdrop wallpapers for consistency). The new wallpaper picker doesn't display the thumbnail of the history custom wallpaper like the old picker. So basically the 'generate and save thumbnail' code path can be deprecated in the future. Bug: 809793 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ibf00bec636a52081c77cd7cf1b94e934fd97b11c Reviewed-on: https://chromium-review.googlesource.com/912282Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#536950}
-
wutao authored
This cl adds a '+' icon between the bubble views of modifiers and key in the Keyboard Shortcut Viewer (KSV). Changes: 1. ui::VKEY_UNKNOWN is used as a separator indicator and will be shown as a highlighted "+" icon. 2. Insert the ui::VKEY_UNKNOWN into |shortcut_key_codes| as the separator. 3. Replace the separator with '+' icon when creating KeyboardShortcutItemView. Bug: 768932 Test: Manually test that the separator icon is correctly created. Change-Id: I2d01beb3f4c4b69a18cbb4820afc024f92679dc3 Reviewed-on: https://chromium-review.googlesource.com/912135Reviewed-by:
Mitsuru Oshima (In Tokyo) <oshima@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#536949}
-
https://webrtc.googlesource.com/src.git/+log/ea86bb74fc81..ae8a90a1d4db $ git log ea86bb74f..ae8a90a1d --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Id3ebac3930b5b1ee90734f2d5b973bfbd8febe24 Reviewed-on: https://chromium-review.googlesource.com/920744Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#536948}
-
Takeshi Yoshino authored
Change-Id: I6e59596d70954af52806f1cb5d5ea4867a53d420 Reviewed-on: https://chromium-review.googlesource.com/920562Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org> Cr-Commit-Position: refs/heads/master@{#536947}
-
Randy Smith authored
Bug: None Change-Id: I4098f2da62665acb63d868f3dc4a4001f44a9ae9 Reviewed-on: https://chromium-review.googlesource.com/920681Reviewed-by:
Nick Harper <nharper@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Randy Smith <rdsmith@chromium.org> Cr-Commit-Position: refs/heads/master@{#536946}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/62d82cfd..12457874 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: If3c89bc9d82728c4dc662e0784ac5b11c8cf3457 Reviewed-on: https://chromium-review.googlesource.com/920703Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#536945}
-
Victor Costan authored
This CL aligns CookieManager's interface for listening to cookie changes (observer pattern) with the proposed addition to RestrictedCookieManager, which will be used by the Async Cookies API. Bug: 729800 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I0464b0d1d0388279e549d19c5dbeea2d0342cc60 Reviewed-on: https://chromium-review.googlesource.com/913151Reviewed-by:
Randy Smith <rdsmith@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#536944}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=anantha@chromium.org Change-Id: I6d5289a138617312e09d7eded0d95c7266727045 Reviewed-on: https://chromium-review.googlesource.com/920827Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#536943}
-
sczs authored
-Creates ChromeTableViewController with basic unittests. -Implements basic UITableViewDataSource methods. Bug: 805136 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Idbc59f0c0b71c01b9c8513e8bd7907b0f9713971 Reviewed-on: https://chromium-review.googlesource.com/915261 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#536942}
-
Jaebaek Seo authored
This is a reland of 4c50e3e1. It is reverted as shown in crrev.com/c/920222, because of a compile error. blink::WebInputEvent::kTimeStampForTesting is moved to blink::WebInputEvent::GetStaticTimeStampForTests(). This CL fixes the compile error. TEST=content_browsertests RenderViewTapDisambiguationTest.CanvasSizeUseZoomForDSF on NEXUS 5X. Original change's description: > Adjust location and size of TapDisambiguator > > As shown in crbug.com/737777#c72, the location and size of Android tab > disambiguator is not correct when --use-zoom-for-dsf is enabled. It is because > RenderViewImpl::DidTapMultipleTargets() assumes |touch_rect| is in DIPs while it > is in physical pixels when --use-zoom-for-dsf is enabled. This CL solves this > problem. > > TEST=Android Chrome with production code on NEXUS 5X, > content_browsertests RenderViewTapDisambiguationTest.CanvasSizeUseZoomForDSF > on NEXUS 5X, NEXUS 4, NEXUS 9 (w/ and w/o this change). > > Bug: 737777 > Change-Id: I64ca0b9b76fcfc3798036a80c9213973de8f3f77 > Reviewed-on: https://chromium-review.googlesource.com/898824 > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Commit-Queue: Jaebaek Seo <jaebaek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#536868} Bug: 737777 Change-Id: Id21123049c71d49460f1f428f6baafb9807084a4 Reviewed-on: https://chromium-review.googlesource.com/920801Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Jaebaek Seo <jaebaek@chromium.org> Cr-Commit-Position: refs/heads/master@{#536941}
-
Ashley Enstad authored
Comment added to benchmark sharding map file causes a crash while loading the benchmark sharding map. This change allows the code to ignore the comment at the start of the map and continue running the script. Bug: 758630 Change-Id: Ia0617a53fb6f5b43c9f22288ca916218e8472d37 Reviewed-on: https://chromium-review.googlesource.com/916891Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#536940}
-
Aaron Leventhal authored
Accessibility checks require all views, even in content shell, to have a name. Bug: None Change-Id: I6a4d4c7ff826cbd48fc0b91f7173dd2e93862412 Reviewed-on: https://chromium-review.googlesource.com/919305Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#536939}
-
Christopher Thompson authored
This fixes an a11y regression in the page info button label under the experimental conditions of the HTTPS Indicator UI Study (https://crbug.com/803501), where only the green lock icon would be shown but no explanatory label would be included for screen readers. This modifies the accessibility label under these conditions for both views and cocoa UI to make sure that secure connections are always labeled as such. On Windows/Linux/ChromeOS (Views), this appends a new String Attribute to the description in the AXNodeData. On Mac (Cocoa), this prepends the "Secure" text to the beginning of the Accessibility Label. Bug: 812034 Change-Id: I1fe2e6d1afa7110d445154da682846fd82738939 Reviewed-on: https://chromium-review.googlesource.com/917282 Commit-Queue: Christopher Thompson <cthomp@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#536938}
-
Peter Collingbourne authored
Before duplicating this bot's configuration to create a new bot, let's see how many of these exceptions are legitimate. Bug: 810907 Change-Id: I87d0607394af6ce9dbdd1932a240bcea7cbc9e1b Reviewed-on: https://chromium-review.googlesource.com/920321Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#536937}
-
Jao-ke Chin-Lee authored
Bug: 731384 Change-Id: I1385fbece81e7e68f41c41b66aacfb3795c36af7 Reviewed-on: https://chromium-review.googlesource.com/920842Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Cr-Commit-Position: refs/heads/master@{#536936}
-
Sarah Chan authored
This reverts commit 01b39191. Reason for revert: Causes crash Original change's description: > [MacViews] Wire up AutofillPopupView > > Show toolkit-views AutofillPopupView with --secondary-ui-md. > > Removed AutofillPopupBaseView FocusManager accelerator code. > The code is no longer necessary since it was added for a now > obsolete rAc dialog. The autofill popup will get dismissed by > the web contents, which listens for the accelerators. > > Bug: 728182 > Change-Id: I9f7816fe41279a397f5066d28d88099d50ef033e > Reviewed-on: https://chromium-review.googlesource.com/889983 > Commit-Queue: Sarah Chan <spqchan@chromium.org> > Reviewed-by: Trent Apted <tapted@chromium.org> > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Cr-Commit-Position: refs/heads/master@{#534527} TBR=ellyjones@chromium.org,tapted@chromium.org,estade@chromium.org,spqchan@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 728182 Change-Id: Ibda0e0f4a15e54e2f2d4c19951719f7d604473ff Reviewed-on: https://chromium-review.googlesource.com/919972Reviewed-by:
Sarah Chan <spqchan@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Sarah Chan <spqchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#536935}
-
Majid Valipour authored
Adding measurements for few key AnimationWorklet feature in preparation of an upcoming Origin Trial. Bug: 811922 Change-Id: Icc69cfa1980a0b562cd3e64385103776059c9fc4 Reviewed-on: https://chromium-review.googlesource.com/916886 Commit-Queue: Majid Valipour <majidvp@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#536934}
-
Kent Tamura authored
There were only three callsites. - Two were for editing commands. They should not be performance- sensitive. So we may use the generic CreateElement(q_name, flags, is_value). - One was for Document::createElementNS(). It's performance-sensitive, and this CL folds the content of CreateElement(q_name, flags) into it. Bug: 806641 Change-Id: I3863687c4fdb5a126d60fae74f8690cb0ba8f918 Reviewed-on: https://chromium-review.googlesource.com/917846Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#536933}
-
Tatsuhisa Yamaguchi authored
Bug: 690217 Test: manually verified at chrome://histograms after opening a zip Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I5bb3dae99444973322704dc4248d9c6bb3e8a3f8 Reviewed-on: https://chromium-review.googlesource.com/915542Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Yuki Awano <yawano@chromium.org> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/heads/master@{#536932}
-
Luciano Pacheco authored
This is part of converting the follwoing IPC messages to Mojo: https://cs.chromium.org/chromium/src/content/common/cache_storage/cache_storage_messages.h This is a continuation of http://crrev.com/c/906046 . This has been split from http://crrev.com/c/875510 . In service_worker_types.h removed an include to avoid circular includes also added include <vector> to fix lint error. Bug: 612287 Change-Id: Ifdd96596c709abc9f5e91b900bf21ee72f4a2b27 Reviewed-on: https://chromium-review.googlesource.com/906164 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Sasha Morrissey <sashab@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#536931}
-
Peter Collingbourne authored
This bot is for testing that we can build with the libc++ standard library on Windows. Bug: 801780 Change-Id: Ifeb58bf7dfeec79afcdb30308b436d86d5769d36 Reviewed-on: https://chromium-review.googlesource.com/920741 Commit-Queue: Peter Collingbourne <pcc@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#536930}
-
Yuri Wiitala authored
Changes the location of the RGB→Grayscale conversion of the CopyFromSurface() result SkBitmap to be in NavigationEntryScreenshotManager, as it is the only use case. This unblocks a massive clean-up effort for bug 759310. For reference, the following was the code that was doing the conversion before (and is a part of a major chunk of code that we want to delete): https://cs.chromium.org/chromium/src/content/browser/compositor/surface_utils.cc?rcl=2fe7073e23caa42cbd01575ab206ba8928ccd645&l=146 Bug: 759310 Change-Id: I2687e69b284d5c24ead10b05b49f678cf8375651 Reviewed-on: https://chromium-review.googlesource.com/919603 Commit-Queue: Yuri Wiitala <miu@chromium.org> Reviewed-by:
Nick Carter <nick@chromium.org> Cr-Commit-Position: refs/heads/master@{#536929}
-
Wenzhao Zang authored
Since the Learn more link was within paper-checkbox, it will get triggered by the on-change event. Bug: 812183 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I29b23fcf6bdeb8e485c36d8e100b39288b3b236a Reviewed-on: https://chromium-review.googlesource.com/919429Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#536928}
-
Tom Anderson authored
There was a build step (site_per_process_webkit_layout_tests) on Linux Xenial that for some reason was requesting Trusty swarming bots. All of the other steps were using Xenial bots. This CL explicitly requests Xenial swarming bots to fix this step. BUG=789768 R=dpranke@chromium.org Change-Id: Id9b33f0fd189f2286cf6dbb03cfd1553bafdf354 Reviewed-on: https://chromium-review.googlesource.com/920764 Commit-Queue: Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#536927}
-
Shakti Sahu authored
Tapping on the notification for prefetched content should open downloads home and expand the prefetch content section. Bug: 810098 Change-Id: If2078ab2dfff2d187d8a4331c850a4266c037607 Reviewed-on: https://chromium-review.googlesource.com/907743 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#536926}
-
Zentaro Kavanagh authored
- Remove the text that indicated that the default was false. - The default was changed but the text was not updated. BUG=chromium:775518 Change-Id: I869b471a9b3772543c5e67824d41c9fcaa17eb8c Reviewed-on: https://chromium-review.googlesource.com/917655 Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#536925}
-
https://chromium.googlesource.com/angle/angle.git/+log/2f23f35afb94..f3803d4f74a5 $ git log 2f23f35af..f3803d4f7 --date=short --no-merges --format='%ad %ae %s' 2018-02-14 ynovikov Fix standalone Linux build 2017-11-07 geofflang StateManagerGL: Use dirty bits for framebuffer bindings. 2018-02-14 jmadill Vulkan: Cache clear color in ContextVk. 2018-02-14 jmadill Vulkan: Pass RendererVk to Allocate helpers. 2018-02-14 jmadill Vulkan: Implement basic Renderbuffer creation. 2018-02-14 lucferron AngleWrangle: Suppress newly introduced flakyness 2018-02-08 lucferron Vulkan: Autogen mandatory texture caps 2017-09-21 geofflang D3D: Implement robust resource init for Surfaces. 2018-02-14 jmadill Revert "Vulkan: Add glslang validator to build." 2018-02-13 yunchao.he Code refactoring for end2end tests. 2018-02-09 lucferron Vulkan: Add culling rasterization states tests and invert front face 2018-02-07 lucferron Vulkan: Texture caps map 2018-02-13 oetuaho Store invariant varying names as ImmutableString 2018-02-08 oetuaho Don't search for nonexistent brackets in InitializeVariables 2018-02-12 tobine Put Vulkan mock ICD json file in separate dir 2018-01-29 oetuaho Add a constexpr constructor for TVariable 2018-02-12 geofflang Remove usage of ANGLE_FALLTHROUGH in EmulatePrecision.cpp 2018-02-12 jmadill Add test for scissored clear. 2018-02-08 brandon1.jones Enable Multisample Sources in copyImageInternal For D3D11 2018-02-12 jmadill Vulkan: Add glslang validator to build. 2018-02-02 jiawei.shao ES31: Add link validation on geometry shader itself 2018-02-12 geofflang Revert "GLES1: Link against angle_util_static instead of angle_util." 2018-02-02 jie.a.chen Vulkan: Prepend layer path to VK_LAYER_PATH Created with: roll-dep src/third_party/angle BUG=810767 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=lucferron@chromium.org Change-Id: I7efd5cb74b02148bd9dd16e1e7d5be7274cf1819 Reviewed-on: https://chromium-review.googlesource.com/920642Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#536924}
-
Jian Li authored
The split is to separate codes that focus on different testing areas. This CL only did the split without any behavior or functionality changes. Bug: none Change-Id: Ie5fa011e92eb3905cb3bd9fdbd68966993af4bf9 Reviewed-on: https://chromium-review.googlesource.com/919199 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#536923}
-
David Bokan authored
Adding DCHECKs in LayerTreeHost::SetPageScaleFactorAndLimits shows that we sometimes set inconsistent limits and page scale factor. This shows up in Blink for two reasons, fixed in this patch: 1. When we finish running a layout test, we call Internals::ResetToConsistentState which calls SetPageScaleFactor(1). If the test modified the limits this may not be a valid scale factor. We now reset the limits in this method as well. 2. Some tests set the page scale factor without regard for the default limits. The default limits in layout tests are [1, 4] so many tests that tried setting scale factors < 1.0 would silently fail to do so. This CL fixes these tests by changing the limits appropriately. As a result of #2, behavior on some tests has changed as they now actually run using the scale factor they purported to set. This required rebaselining tests in compositing/layer-creation since the root layer size depends on the minimum-scale which is now changed. zoom-scroll-page-test.html also needed a small change to increase the amount of scrollable content. Without this change, zooming out makes some of the requested scroll positions outside the maximum scroll position. Finally, this CL actually ensures the Blink only clamps the page scale factor before setting it. This also revealed that all unit tests based on PageTestBase were running without scale factor limits set. Bug: 810573 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I4f662777da82c8f33263a0eb05f49958f3112e45 Reviewed-on: https://chromium-review.googlesource.com/913972Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#536922}
-
Tetsui Ohkubo authored
TrayPopupHeaderButton is a deprecated class that isn't used anymore. BUG=none Change-Id: I0065e012372f5a9ab3a2e97cc20add51afdf5b09 Reviewed-on: https://chromium-review.googlesource.com/918144 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#536921}
-
Sergey Ulanov authored
Currently the set of fonts used for layout tests on Android and Fuchsia doesn't include any Chinese, Japanese or Korean fonts, so they render tofu on the pixel tests that contain text in these languages. Adding NotoSansCJK so these tests can render properly. Bug: 778467, 787020 Change-Id: Id29b65525d5af0be96984db69e62d9d198b87fd4 Reviewed-on: https://chromium-review.googlesource.com/910122 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#536920}
-
dpapad authored
Bug: 738611 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I7f3649304443c82c7604d4ba4c9e2ef0b966c5f1 Reviewed-on: https://chromium-review.googlesource.com/919643Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#536919}
-
chcunningham authored
Full test name is SSLClientCertificateSelectorCocoaTest.WorkaroundCrashySierra Test only runs (and flakes) on mac. Bug: 810909 Change-Id: I2dc0c8d347a8292d89df3e5590cfff1db481829a TBR: sdy@chromium.org Reviewed-on: https://chromium-review.googlesource.com/920685Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#536918}
-
sczs authored
Bug: 805013 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I0b9ed58466af7b0c7ea092d8210683ba510502d4 Reviewed-on: https://chromium-review.googlesource.com/916808 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#536917}
-
Yoshifumi Inoue authored
This patch changes |TextIteratorTextNodeHandler::HandleTextBox()| to handle range ends at end of leading collapsed whitespace of first-letter part, e.g. "<p>^ |(1) foo</p>" where P has ::first-letter. Bug: 810623 Change-Id: I6888bf0cba305d33c193b6cd4c3f191c8dcf36bd Reviewed-on: https://chromium-review.googlesource.com/910543 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#536916}
-
Robert Liao authored
This reverts commit b36af4e1. Reason for revert: There seem to be some rounding issues during continuous repositioning of the parent window. Original change's description: > Add Child Move and Resize Support to the BubbleAnchorHelper > > The ExtensionPopup resizes its view dynamically after it can be > anchored and shown. > > This change adds child resize support to BubbleAnchorHelper to > accommodate that scenario. Move is brought along for free. > > BUG=728174 > > Change-Id: I7ca12b92da339263ca5558254d2bbb0595a57b4c > Reviewed-on: https://chromium-review.googlesource.com/915010 > Commit-Queue: Robert Liao <robliao@chromium.org> > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Cr-Commit-Position: refs/heads/master@{#536753} TBR=ellyjones@chromium.org,robliao@chromium.org Change-Id: Ic8c3c6766f10a779b467605f808c883869def07e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 728174 Reviewed-on: https://chromium-review.googlesource.com/920604Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#536915}
-
Elliot Glaysher authored
RefCountedMemory is an arbitrary wrapper around memory. It is used extensively in code which passes encoded PNG files around, such as the history system and the screenshotting code. Bug: 706246 Change-Id: I9788aaba9dcfe38bd05418c4cc3a9e2737a5985c Reviewed-on: https://chromium-review.googlesource.com/917198Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Elliot Glaysher <erg@chromium.org> Cr-Commit-Position: refs/heads/master@{#536914}
-
sczs authored
- Creates a RecentTabsTableViewController constants file. - Creates a file for RecentTabsTableViewControllerDelegate protocol. - Creates Protocol RecentTabsTableViewControllerInterface, this includes all the public RecentTabsTableViewController methods. - Renames RecentTabsTableViewController to LegacyRecentTabsTableViewController. - Small cleanup of unused imports. Bug: 805013 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ie682653c2154e22776b0e991db56d52f6d5aab20 Reviewed-on: https://chromium-review.googlesource.com/896923 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#536913}
-