GitLab

This CL makes sure that the correct trait collection is used when
checking if the NTP is displaying one or two toolbars.
With multiwindow, it is not possible to directly check the key window.

Fixed: 1128527
Change-Id: I79a441b1a186c755b7cc979f527e807f10aa3a29
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422955
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809718}

This reverts commit 821323c7.

Reason for revert: Breaks RenderProcessHostUnitTest.ReuseCommittedSite on linux-bfcache-rel builders.

Original change's description:
> Add Render Process for Site Instance Assignment to content API
> 
> This CL adds an enum, SiteInstanceProcessAssignment, which
> describes all the ways a SiteInstance may be assigned a render
> process. This is exposed in the content API to allow embedders to
> record this usage.
> 
> See design doc in bug and/or chained CL for more info.
> 
> Bug: 1129505
> Change-Id: I0654d52b4c0fef3830a877fb1c1476dea4ad9361
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417100
> Commit-Queue: Robert Ogden <robertogden@chromium.org>
> Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#809620}

TBR=alexmos@chromium.org,robertogden@chromium.org

Change-Id: I89a7d068b8897c520a3d02645222c9cd91220c19
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1129505,1131378
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424314Reviewed-by: Tim Schumann <tschumann@chromium.org>
Commit-Queue: Tim Schumann <tschumann@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809717}

DOMWrapperWorld is implemented with a few thread static variables
and its behaviors depend on other threads.  Makes the test
expectations independent from other threads.

Bug: 874484
Change-Id: I3c93ab89c2fd4db67d3380251b9da06cd96991c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2420171Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809716}

We used to assume 16bits is sufficient, but somehow it's not always the
case. In this cl, let handshake message and pcm audio message no longer
share the same packet header. I.e., let them have their own header
struct and read/make methods.

Besides, add more unittest to cover packet header poluate/parse.

Merge-With: eureka-internal/453374
Bug: internal: 168457620
Test: Unittest.
Change-Id: I6e10fe9d58974646029ba222229e2f6d4df8acd5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413110
Commit-Queue: Kehuang Li <kehuangli@chromium.org>
Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809715}

That is:
- Increase the number of spinning iterations
- Do a relaxed atomic check before the CAS in the spin loop.

Bug: 1125999, 1061437
Change-Id: I4f33376b55206dff9557a9ee59109aeaa06b5a56
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424310Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Benoit L <lizeb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809714}

Bug: 1099982
Change-Id: I0b8e35b04c9b995bac6c49e8c831520ab350c040
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416928
Commit-Queue: Ben Goldberger <benwgold@google.com>
Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Sinan Sahin <sinansahin@google.com>
Cr-Commit-Position: refs/heads/master@{#809713}

There are some cases missing in the switch, the IDE added them.

Bug: none
Change-Id: I77f16010fbb0ee2ee3be11402d26dd6ab35cf56e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424154
Auto-Submit: Sandro Maggi <sandromaggi@google.com>
Commit-Queue: Sandro Maggi <sandromaggi@google.com>
Commit-Queue: Clemens Arbesser <arbesser@google.com>
Reviewed-by: Clemens Arbesser <arbesser@google.com>
Cr-Commit-Position: refs/heads/master@{#809712}

This CL adds a few elements to the new menus in incognito and guest
modes:
 - Add a new background subclass that allows to draw themed images
   on a view's background.
 - Add incognito and guest mode art assets.

Design Deck: go/alignmenus

Screenshots:
https://screenshot.googleplex.com/9nCgPZMahh8eALD.png

Bug: 1105763
Change-Id: I2367514aa7285959409e68e3cfd618690beedff1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388442Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Reviewed-by: Jan Krcal <jkrcal@chromium.org>
Commit-Queue: Mariam Ali <alimariam@google.com>
Cr-Commit-Position: refs/heads/master@{#809711}

Renderer-side autofill sometimes sends the browser a notification that
a form was *likely* submitted. WebView/WebLayer autofill currently
handles this case as follows:
- It records the fact that the event was received.
- If a new form is seen by the renderer while the current form is still
  active in the browser, it considers the current form as having been
  submitted and informs the Android Autofill framework.

This CL modifies this flow in order to support followup work that will
reset the current form on navigation. The logic is now as follows:
- When a navigation occurs, WV/WL Autofill's browser-side code checks
  whether (a) it has previously received a "form likely submitted" event
  from the renderer and (b) the current form has not subsequently been
  reset. If so, it considers the current form as having been submitted
  and informs the Android Autofill framework.

Without this change, the followup work that resets the current form on
navigation would break this flow entirely, as (naturally) a new form is
seen by the renderer only *after* a navigation occurs.

The practical impact of this change is that commit of a successful
autofill session will occur sooner: on the navigation resulting from
the successful submission rather than the next time that a form is seen
(which can be arbitrarily later). This seems like a good thing.

Bug: 1117563
Change-Id: I33dfa27b4bbf7e246e62273d3598eb0f30f1f722
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424144
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Michael Bai <michaelbai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809710}

Post-CQ bots are failing in ways not reproducible locally or on the CQ.
To rule out if tests are interfering with each other (e.g. opening
camera in parallel or leaving the camera in a bad state) we disable all
tests exercising the new code path.

This should result in only old capturer code running, with only pixel
formats not natively supported by the camera (2vuy).

TBR=handellm@google.com, ccameron@chromium.org
NOTRY=True

Bug: chromium:1128470, chromium:1129807
Change-Id: I68d425807cee869bcc76dddcb0aa36ff4476e6ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424128
Commit-Queue: Henrik Boström <hbos@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809709}

Bug: 1125784
Change-Id: Id7dc06dc9b5b463aa62784f9927ce684f5b9c64e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423510Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Rushan Suleymanov <rushans@google.com>
Cr-Commit-Position: refs/heads/master@{#809708}

Follow-up of
https://chromium-review.googlesource.com/c/chromium/src/+/2220359. This
CL removes related XXXToString() methods.

Bug: None
Change-Id: I99fb653e0f5ed179bb21fa8e48b5c79aa98b6557
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425386Reviewed-by: Sergey Volk <servolk@chromium.org>
Commit-Queue: Linkun Chen <lkchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809707}

Includes 🙂 face character, samples from different languages, Dingbats
and Math characters, Greek letters, Runes, etc:

  Hello नोपहिनस्ति أن 害
  色は匂へど 散りぬるを
  κόσμε ᚹᛦᛗ コンニチハ
  волн ապակի Կրնամ
  їсти मुझे |∊☀✌✂♁ 🙂

Note the file is pure text with no UTF-8 BOM (Byte Order Marks) at the
start of the file.

Not used in anywhere in the code as yet.

Bug: 1064855
No-try: true
Change-Id: I34409215ec22aacea6a872cbc87241f27ab35e03
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425545
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: François Degros <fdegros@chromium.org>
Reviewed-by: Jeremie Boulic <jboulic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809706}

Duplicate the openQuickViewTabIndexText test but here use an HTML file
as the preview file. This to document a difference between the preview
HTML and TEXT content renderers. The HTML renderer content is not part
of the tabindex order, while the TEXT renderer content *is*. Add a new
test to document the HTML renderer tabindex behavior.

Test: browser_tests --gtest_filter="*openQuickViewTabIndexHtml"
No-try: true
Bug: 1064855
Change-Id: Ieae14b0468c1142feeb23a240fb8f73c119bef4a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425605
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Alex Danilo <adanilo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809705}

- Add query set with the types of occlusion query, pipeline statistic
  query and timestamp query.
- Add extension of timestamp query.
- Add query APIs:
  createQuerySet on device.
  writeTimestamp on command encoder, render encoder and compute encoder.
  resolveQuerySet on command encoder.
- Now timestamp query is available on D3D12 backend, other backends are
WIP.


Bug: dawn:434
Change-Id: Icfdb17da7f406bfd1d6e903503b103391d9c7d8c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415572
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809704}

Makes .gni files of file lists a little cleaner.

Change-Id: I10045a56809949cdd158de067439a27dfde0125d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424366Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809703}

This patch shows two related photos together when device is in landscape
orientation.

Major changes:
1. Only show paired photos in landscape mode.
2. Use flex layout to dynamically add and show the secondary image.
3. If the primary image is fetched, it will be shown in the UI.
4. If the primary image is not fetched, then will ignore the secondary
   image, i.e. read from cache.
5. If the second image is fetched, it will be added to the UI if the
   screen orientation is landscape.
6. There is a 8px wide separator between two photos.
7. Only update the cache with primary image.
8. Paired photos share the same attributes.

Screenshot: https://screenshot.googleplex.com/9UirWBGxheYVqV4

Bug: b/157080996
Test: added new tests.
Change-Id: I25fb18104f317ffad629bbf7d1fcc5302806cf20
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407176
Commit-Queue: Tao Wu <wutao@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809702}

Purely mechanical change to follow a PRESUBMIT recommendation.

Bug: 1111134
Change-Id: Ic1674e98d977326f3666469fe53145912e6d5ac5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419052Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809701}

Also fixes a few cpp lint errors. No functional changes.

Bug: 1010217
Change-Id: Ibdbac42980740d26392812b39f86859b238b7a64
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422964
Commit-Queue: David Bienvenu <davidbienvenu@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809700}

R=khorimoto@chromium.org

Bug: 1045266
Test: none
Change-Id: I82ca433269e300a2e7745b661be3f7a85f8117a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425325
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809699}

It seems c_icu symlink is also created along with /c symlink for
ChromeOS build (/c is for chromeos-chrome package, /c_icu is for
chrome-icu package).  It's better to ignore it for the same reason.

Bug: none
Test: build_packages with chromeos chroot environment
Change-Id: Iad0a4addac492580601a16faa26ec34ed2fe77e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425123Reviewed-by: Honglin Yu <honglinyu@chromium.org>
Commit-Queue: Jun Mukai <mukai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809698}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/df9a5f7482ce..aad83522fd17

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC horo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: horo@google.com
Change-Id: I798644c8da266945de1b361fbf17c4418f231062
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425515Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#809697}

The test does not actually display the text file in test. Document the
bug and error symptom (site not reached error shown in the preview).

Make the test return IGNORE_APP_ERRORS: fixing issue 1064855 causes it
to fail because the reason for the error is detected earlier, and will
log a console.error and hence FAIL this test.

Bug: 1131298, 1064855
Change-Id: I5351cf572bcf2ec3399ed7ad7130029f99209dc3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423756
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Alex Danilo <adanilo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809696}

https://chromium.googlesource.com/chromium/deps/icu.git/+log/79326efe26e5..aef20f06d47b

$ git log 79326efe2..aef20f06d --date=short --no-merges --format='%ad %ae %s'
2020-09-17 mukai Fix the build config regarding icu_disable_thin_archive
2020-09-22 zarvox [build] Clean up no_rtti config handling
2020-09-16 hidehiko icu: Expand is_linux to is_linux || is_chromeos.
2020-09-11 fdegans [fuchsia] Bring more changes from the Fuchsia copy
2020-09-01 fdegans Upstream Fuchsia changes in build file
2020-06-29 adetaylor Add CPEPrefix.

Created with:
  roll-dep src/third_party/icu

Bug: 1129473
Change-Id: I4a97eb577118be241dd9f8f1306439c6d1eaec29
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425287Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Commit-Queue: Jun Mukai <mukai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809695}

This reverts commit 22a5368c.

Reason for revert: This roll breaks ChromeOS build as discussed in crbug.com/1129473. The fix https://chromium.googlesource.com/chromium/deps/icu.git/+/aef20f06d47ba76fdf13abcdb033e2a408b5a94d should be included (see crrev.com/c/2425287)

Original change's description:
> Roll ICU 79326efe..83b2ac66
> 
> https://chromium.googlesource.com/chromium/deps/icu.git/+log/79326efe..83b2ac66
> 83b2ac66 [fuchsia] Bring more changes from the Fuchsia copy
> 368b1cb1 Upstream Fuchsia changes in build file
> fb520a53 Add CPEPrefix.
> 
> Bug: 1124037, fuchsia:56362
> Change-Id: Ia77c08b48668de4315b44d3b72a3a3e23d722494
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412548
> Auto-Submit: Fabrice de Gans-Riberi <fdegans@chromium.org>
> Commit-Queue: Frank Tang <ftang@chromium.org>
> Reviewed-by: Frank Tang <ftang@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#809634}

TBR=fdegans@chromium.org,jshin@chromium.org,ftang@chromium.org

Change-Id: I49d0e15b5089f840e2cd27ba024a22dfeb4bce8a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1124037
Bug: fuchsia:56362
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425390Reviewed-by: Jun Mukai <mukai@chromium.org>
Commit-Queue: Jun Mukai <mukai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809694}

The compositor viewport wasn't getting set correctly for platforms that
didn't use DSF and had a scale factor on the display. Ensure it is
correct.

This was caused by
https://chromium-review.googlesource.com/c/chromium/src/+/2402116
incorrectly using size_ assuming it was the same for the viewport pixel
rect, but that is not the case for platforms without Zoom for DSF
(such as Mac).

BUG=1131162

Change-Id: Ie07ad887cf8dd511689a91011c928997c3587b2c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425195Reviewed-by: Thomas Lukaszewicz <tluk@chromium.org>
Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809693}

This change removes the pp::Var dependency from core PDF code by
converting the incoming pp::Var data to base::Value and updating the
core PDF code to work with base::Value instead of pp::Var.

The pp::Var types of PP_VARTYPE_OBJECT and PP_VARTYPE_RESOURCE do not
have any valid conversion to base::Value and hence have added
NOTREACHED() in those cases.

Bug: 1094049
Change-Id: I3f6e54b04878e10d0d0ae860a6b1e8446e7e04e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413707
Commit-Queue: Gourab Kundu <gourabk@microsoft.com>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: K. Moon <kmoon@chromium.org>
Reviewed-by: Ankit Kumar 🌪️ <ankk@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#809692}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/goldctl-mac-chromium-autoroll
Please CC bsheedy@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: bsheedy@chromium.org
Change-Id: I0de1dce089f6f153d654eb7a6c81c41f4991f596
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425510Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#809691}

Bug: b/155490708
Change-Id: I6b866618dc8a3a5c484f299be71aa68103728a16
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422578Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Commit-Queue: Muyao Xu <muyaoxu@google.com>
Cr-Commit-Position: refs/heads/master@{#809690}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/d2ea1c89..e0d5b2a8

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Iad8fb1349908cbbbb6991a5ea39310bfd10d65a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424768Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#809689}

Extend this UMA expiry date until Chromium M94.

Bug: 1088965
Change-Id: Iab8091f5ecc562de6b75aeefeb5923bebc88d729
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418752Reviewed-by: Anand K Mistry <amistry@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Josh Simmons <simmonsjosh@google.com>
Cr-Commit-Position: refs/heads/master@{#809688}

CheckIsNotDestroyed() will be used to ensure LayoutObject is not used after the Destroy() call once LayoutObject is moved to GarbageCollected.
CheckIsNotDestroyed() should be the first statement for all methods on LayoutObject and its subclasses.

Bug: 1030176
Change-Id: I4862ad8d068311b8cccf3881b21f0d62f787c333
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409837
Commit-Queue: Keishi Hattori <keishi@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809687}

FuchsiaAudioRenderer::FlushInternal() is called when seeking media
stream. It's supposed to flush all pending buffers, so playback can
resume from the new position. Problem was that there may be a demuxer
read that's still pending when the function is called. Results of that
read were still used after flush, but they may correspond to the
previous position in the stream (before seek). As result the packet
returned by the pending seek was sitting in the head of the queue
blocking playback of all other packets for the new position after seek,
breaking audio playback. This change updates
FuchsiaAudioRenderer::OnDemuxerStreamReadDone() to drop results if
FlushInternal() was called while the demuxer read operation was pending.

Bug: b/167613125
Change-Id: I134eb54f5729194d419226bc2df53012a32c8d4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422886
Auto-Submit: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: David Dorwin <ddorwin@chromium.org>
Reviewed-by: David Dorwin <ddorwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809686}

Bug: 1131022
Change-Id: Ifb73b41adfee89dc72487dd5e34a061f188c93c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423358Reviewed-by: Tim Song <tengs@chromium.org>
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Commit-Queue: Jazz Xu <jazzhsu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809685}

This CL uses the proper result type for suggestions from QT.

BUG=1130176, 1128851

Change-Id: Ibb5748683a3e3d347c330a076d9e7fa2258a5f81
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425125Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809684}

Bug:  1045266
Test: OSSettingsInternetConfig*

Change-Id: Iea02f06dcf1f322b787d6bc0122e07a25b97f2cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425065
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809683}

- Add rule to check imageBitmap state and throw invalid state error
exception if imageBitmap has been closed.

- Add rule to check depth of copySize and throw range error exception
  if depth of copySize is larger than 1.

- Allow noop copy and modify validation rule to support on border
  source origin.

BUG=966582

Change-Id: I9ce4fa6ec152a538cf88c42bb0b9cee634f55b54
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402584Reviewed-by: Austin Eng <enga@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Shaobo Yan <shaobo.yan@intel.com>
Cr-Commit-Position: refs/heads/master@{#809682}

This will be convenient for various callers.

Bug: 772945
Change-Id: I044f791aafe079d0728aabea20e0e287bbf045ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425142
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809681}

Metrics changed:
 - Installer.Recovery.Reason
  - change owner + add chromeos-core-services
 - P2P.Server.ClientCount

BUG=chromium:1089203, chromium:1088866
TEST=none

Change-Id: Ie4330b8178a7a857b99616af763ffa09947a14fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422441
Auto-Submit: Jae Hoon Kim <kimjae@chromium.org>
Commit-Queue: Steven Holte <holte@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809680}

This method is not used anywhere, including SensorProviderProxy's
friends, so get rid of it for simplicity's sake.

Change-Id: Ibf9484f935372d733ab4d4dda991cb53c6cfeb4d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421368
Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809679}