- 24 Jan, 2019 40 commits
-
-
Thomas Tangl authored
This is a follow up to crrev.com/c/1425607. Missing includes and dependencies are added. TBR=dpapad@chromium.org Bug: 916191 Change-Id: If009035b2012648664a99b446be0e1be2212280c Reviewed-on: https://chromium-review.googlesource.com/c/1435434Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#625838}
-
Jay Harris authored
The previous fix caused problems (crbug.com/920556, crbug.com/919457). Note: This change should also be better for security UI, as now the page info dialog will be displayed over the top of the CCT instead of entirely inside the content area. Bug: 902615 Change-Id: Iada8224fff11ef5886106262298d723a3097a19e Reviewed-on: https://chromium-review.googlesource.com/c/1405119 Commit-Queue: Jay Harris <harrisjay@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#625837}
-
Ren-Pei Zeng authored
Change-Id: Ib155760013ebf4e693d351d0478bb11eb0076f49 Reviewed-on: https://chromium-review.googlesource.com/c/1433659Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#625836}
-
Ben Pastene authored
Looks like they're the only remaining tast test that fails: https://chromium-swarm.appspot.com/task?id=429a15ecadd81410 Bug: 916367, 866062 Change-Id: If1368f981f788f99def300c50e2539fffc783e48 Reviewed-on: https://chromium-review.googlesource.com/c/1434795Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#625835}
-
Donn Denman authored
This reverts commit 48cb4faa. Reason for revert: Includes a fix for a failing test in the original. Original change's description: > Revert "[TTS] Persist and resend event IDs for sawmill." > > This reverts commit c845b226. > > Reason for revert: strong suspect for crbug.com/923404 > > Original change's description: > > [TTS] Persist and resend event IDs for sawmill. > > > > Adds support for persisting and later reporting user interaction > > to the server in support of the offline sanitized click-log. > > > > BACKGROUND: > > This change allows the server to log outcomes from interactions and associate > > them with the privacy-safe documents in the Search Index. See go/cs-sanitized > > for more details on this design. > > > > DESIGN OVERVIEW: > > When the server recognizes a document it generates a random EventID and logs > > it to sawmill and returns it to the client in the response to the Resolve > > request. The client passes the EventID up to Java and persists it in local > > device storage along with the user-interaction outcomes. The next time > > the user makes a Resolve request the client checks for previous data, and if > > present it sends it as part of the Context to the server (and erases it > > from storage). > > > > DETAILS: > > This CL introduces a new interface ContextualSearchInteractionPersister to > > persist user interactions, and an implementation that uses local storage. > > > > The manager detects a new parameter for the EventID returned in the > > Resolve request. It stores this and an encoded set of bits that describe > > the user-interaction for that event in local storage. > > Any subsequent Resolve request checks for a previous EventID and when > > non-zero sends it along with the user-interaction results in CGI params > > to the server. Support for these params on the client and server have > > already landed. > > > > If the server never sends an Event ID to log, then the client won't > > change it's behavior. The server does not yet send these Event IDs. > > > > BUG=872902 > > > > Change-Id: Ief9a95625b16a4b0a3be5325ed1adadff9c791b9 > > Reviewed-on: https://chromium-review.googlesource.com/c/1170352 > > Commit-Queue: Donn Denman <donnd@chromium.org> > > Reviewed-by: Brian White <bcwhite@chromium.org> > > Reviewed-by: Theresa <twellington@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#622993} > > TBR=donnd@chromium.org,bcwhite@chromium.org,twellington@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 872902, 923404 > Change-Id: I72d1d582bf1ab834c51af046204132d9c450e5ef > Reviewed-on: https://chromium-review.googlesource.com/c/1422897 > Commit-Queue: Gabriel Charette <gab@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Cr-Commit-Position: refs/heads/master@{#624264} TBR=gab@chromium.org,donnd@chromium.org,bcwhite@chromium.org,twellington@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 872902, 923404 Change-Id: I539b372f961686ae4b226af424555114148c4c36 Reviewed-on: https://chromium-review.googlesource.com/c/1435037Reviewed-by:
Donn Denman <donnd@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Auto-Submit: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#625834}
-
chrome://naclJohn Lee authored
Bug: None Change-Id: I86da18034e0664780e24559868357c0d0df0ef4c Reviewed-on: https://chromium-review.googlesource.com/c/1423698Reviewed-by:
-
rajendrant authored
This CL moves some common functions to core/common so that some bypass stats is recorded for DRP servicification. No functional changes in this CL other than that more metrics are recorded for DRP servicification. Change-Id: If11df4bf59e0ebb2048c6c2f426cbe7c2ab7afc0 Bug: 900717 Change-Id: If11df4bf59e0ebb2048c6c2f426cbe7c2ab7afc0 Reviewed-on: https://chromium-review.googlesource.com/c/1433143 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#625832}
-
Anatoliy Potapchuk authored
Change-Id: I59f620892eb2c224b1d7c27608877715c69be0d3 Reviewed-on: https://chromium-review.googlesource.com/c/1430481 Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#625831}
-
chrome://x-callback-urlEugene But authored
kExternalFilesLoadedInWebState flag forced to load all external URL in WebState which broke the support for chrome://x-callback-url URLs. This CL enables kExternalFilesLoadedInWebState codepath only for file:// URLs, because WebState can only load file URLs. With this change ExternalFileController is still not used when kExternalFilesLoadedInWebState is enabled. Bug: 923869 Change-Id: Iff438df5f8abb14dc85338acf18a3403fe3acd68 Reviewed-on: https://chromium-review.googlesource.com/c/1432593 Commit-Queue: Peter Lee <pkl@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#625830}
-
Mitsuru Oshima authored
Bug: 923141 Test: manually tested on nocturne and desktotp. I'll add more tests in separate CL (which requires some changes to compositor side). Change-Id: Ica7cb2a7431939ef978c77f289cfa6acf80e697a Reviewed-on: https://chromium-review.googlesource.com/c/1434516Reviewed-by:
Malay Keshav <malaykeshav@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#625829}
-
Kurt Horimoto authored
The referenced bug occurs due to ordering issues of our viewport inset updates relative to PageDisplayState application. When reloading the page using overscroll, the PageDisplayState is stored. Since the page is scrolled to the top, the contentOffset is -contentInset.top (-92 in portrait on iPhone X). Upon rotating the device, the following events occur: 1) CRWWebController's |-orientationDidChange| kicks off the scroll restoration process for the y offset of -92. This is asynchronous because it first executes JavaScript in order to extract the viewport tag. 2) BVC's |-traitCollectionDidChange:| updates the toolbar heights for the new horizontal size class, which in turn updates the scroll view's contentInset. For landscape iPhone X, this produces a top contentInset of 50 (i.e. the "scrolled to top" y content offset is -50). 3) The asynchronous viewport meta tag data extraction finishes and CRWWebController restores the -92 contentOffset, pushing the page below the toolbar. This CL updates PageScrollState semantics such that it stores the offset from the scrolled-to-top-left position, which allows the application of PageScrollStates contentInset-agnostic. Bug: 923856 Change-Id: I468970abbdbd200e4ac836d5664a985f0c8e3e71 Reviewed-on: https://chromium-review.googlesource.com/c/1432377Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#625828}
-
dpapad authored
Convert {detail: SomeTypeHere} parameter to CustomEvent<SomeTypeHere>. Bug: 924733 Change-Id: I46cc0b2c3df6c2f424d8b3c1d527c80b73f76a29 Reviewed-on: https://chromium-review.googlesource.com/c/1435134 Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:Noel Gordon <noel@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#625827}
-
Vlad Tsyrklevich authored
Switch to using new stack trace collection API: base::debug::CollectStackTrace() collects stack traces directly, allowing us to remove cumbersome logic handling StackTrace construction/destruction and also move the stack traces into the SlotMetadata simplifying the crash handler logic. Bug: 896019 Change-Id: I36f525c242c5a6d24d9ded9d1bfa7949c7cab30c Reviewed-on: https://chromium-review.googlesource.com/c/1429624 Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by:
Vitaly Buka <vitalybuka@chromium.org> Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Cr-Commit-Position: refs/heads/master@{#625826}
-
Sam McNally authored
Bug: 923206 Change-Id: I2f8c5d5cdf73387972270cb9e9cdf8518cc986e6 Reviewed-on: https://chromium-review.googlesource.com/c/1433349 Auto-Submit: Sam McNally <sammc@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/c0f31e73e481..fe92685bfc93 git log c0f31e73e481..fe92685bfc93 --date=short --no-merges --format='%ad %ae %s' 2019-01-24 cwallez@chromium.org Roll third_party/shaderc/ 909f0d3d3..ce7d92182 (28 commits) Created with: gclient setdep -r src/third_party/dawn@fe92685bfc93 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I8af68412469080011803ccb8e651b5869882656b Reviewed-on: https://chromium-review.googlesource.com/c/1435374Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#625824}
-
Travis Skare authored
Bug: 923611 Change-Id: Ia99b06a381c955ebad0cb7b9fd5b104549c61fc2 Reviewed-on: https://chromium-review.googlesource.com/c/1423740 Commit-Queue: Travis Skare <skare@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#625823}
-
Lei Zhang authored
BUG=890417 Change-Id: I06ace304b02803f49a0eda89a4ff711f564d78fb Reviewed-on: https://chromium-review.googlesource.com/c/1435538Reviewed-by:
Wei Li <weili@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#625822}
-
kylechar authored
There is more investigation necessary here so extend the histogram expiry to M75. Bug: 874797, 915884 Change-Id: I6ed365ab33e0335aa45e29466f61c4970d21afe4 Reviewed-on: https://chromium-review.googlesource.com/c/1431476Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#625821}
-
Sam Maier authored
Binary-Size: no longer class merging, this is expected Bug: 908988 Change-Id: I4fd1c9ffde68a06cc0b38de613d53e554ea3cfea Reviewed-on: https://chromium-review.googlesource.com/c/1409603 Commit-Queue: Sam Maier <smaier@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#625820}
-
Elly Fong-Jones authored
This flag just serves to prevent access to chrome://sys-internals, which is otherwise complete. This change deletes the flag and renders chrome://sys-internals always accessible. Bug: 752002 Change-Id: Idab39d63a48e11df7e31187263ceb6435f1f5008 Reviewed-on: https://chromium-review.googlesource.com/c/1434799 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
-
David Trainor authored
Add the new update states for inline updates and add the menu UI based on those states. This also adds the ability to use chrome://flags to force the UI to show those particular new states as well. BUG=922711 Change-Id: Ie7303fe2244f62d067e3412f049d2b2bb10db3a8 Reviewed-on: https://chromium-review.googlesource.com/c/1417350 Commit-Queue: David Trainor <dtrainor@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#625818}
-
Vikas Soni authored
Refactor ScopedHardwareBuffer to move it to base::android. Add a function to take ownership of underlying buffer handle. Bug: 900963 Change-Id: I765fa9cf893aee281a98638f1dc55deca1361118 Reviewed-on: https://chromium-review.googlesource.com/c/1415295Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
-
Juan Antonio Navarro Perez authored
These are no longer used, and depend on legacy Telemetry features due to be deprecated. Bug: 642742 Bug: 921000 Change-Id: I1478e212de510516f01066d0898ccb7397c15031 Reviewed-on: https://chromium-review.googlesource.com/c/1434317Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#625816}
-
Matthew Jones authored
This patch adds user actions for the icons in the edit-url suggestion (copy, edit, and share) as well as actions for the omnibox long-press menu. Bug: 881292 Change-Id: I24db676134df34bb7cdf197bb2fc93c84dc86dcd Reviewed-on: https://chromium-review.googlesource.com/c/1419339Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
-
John Lee authored
Bug: 887150 Change-Id: I2124e395ed163cf46bca498743634d85c02e5866 Reviewed-on: https://chromium-review.googlesource.com/c/1418397 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Dan Beam (slow until 1/29) <dbeam@chromium.org> Reviewed-by:
-
Jeffrey Cohen authored
Bug: 921125 Change-Id: Ibfb27630267389cfdd1d135417fb9633ad9d0445 Reviewed-on: https://chromium-review.googlesource.com/c/1422664 Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
-
Mohammad Refaat authored
- Create a public headers directory for the framework style include and only add files that are needed by Chromium code. Bug: 924071 Change-Id: Ia70a1f1a2eff2888c8cbf9c8a2c3ed2fff85e71b Reviewed-on: https://chromium-review.googlesource.com/c/1432153 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#625812}
-
Jon Kunkee authored
ChromeOS used to be the only ARM target to get a high-bit-depth-capable VP9 codec. With the introduction of ARM64 Windows, there is a second such target. This change renames the config files and source lists for their contents rather than their purpose so they can be easily reused. This change also includes a mkdir invocation that makes adding configurations easier. Bug: 893460 Change-Id: I0cc7faa0c9330046e63ea7dc412c9c6e6a8a2ff5 Reviewed-on: https://chromium-review.googlesource.com/c/1429520 Commit-Queue: Johann Koenig <johannkoenig@google.com> Reviewed-by:
Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#625811}
-
Nicolas Ouellet-payeur authored
Bug: 924832 Change-Id: I6e06e81aea864594caf4ae359064032ad8d22f42 Reviewed-on: https://chromium-review.googlesource.com/c/1434075Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#625810}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bb3f9060c4ea..406f8a00f9f0 Created with: gclient setdep -r src-internal@406f8a00f9f0 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I4e864218575a76c93cbe2cd1eeadde686eca12d9 Reviewed-on: https://chromium-review.googlesource.com/c/1435234Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#625809}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/13a5f9e46a5d..c30b0a434de9 git log 13a5f9e46a5d..c30b0a434de9 --date=short --no-merges --format='%ad %ae %s' 2019-01-24 tsepez@chromium.org Release before reallocation in cfx_memorystream.cpp Created with: gclient setdep -r src/third_party/pdfium@c30b0a434de9 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:924928 TBR=dsinclair@chromium.org Change-Id: I7e08bb3fe79200b3d1e12bf0680beffaf25b52cc Reviewed-on: https://chromium-review.googlesource.com/c/1435354Reviewed-by:
-
Xiaohan Wang authored
- Remove the origin trial - Mark the status as "stable" Blink intent-to-ship approval at https://groups.google.com/a/chromium.org/d/msg/blink-dev/w0jNaAhyTV0/3oDkR_ASAQAJ TBR=timvolodine Bug: 709348 Test: Manually tested to make sure the API is available by default. Change-Id: I84306dc0e17f104043fa2205529e650e255e7175 Reviewed-on: https://chromium-review.googlesource.com/c/1423090 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#625807}
-
John Rummell authored
When debugging it is nice to knwo the reason that requestMediaKeySystemAccess() failed. BUG=924991 Change-Id: I352beb27f9a0c2fb82444ae92a4d740a886fa8e0 Reviewed-on: https://chromium-review.googlesource.com/c/1435219Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#625806}
-
Nate Fischer authored
No change to production logic, only to an FYI bot's filter. Although WebView does not intend to support OOP NetworkService, we do intend to support in-process NetworkService even when WebView runs an OOP renderer (on Android O & above). The test filter currently filters out OOP-renderer tests, but cites OOP NetworkService as the reason, so this is probably a mistake. R=jam@chromium.org Bug: 841556 Test: see bot Change-Id: Id81637c879d205e65595d0a9999c1ea5b809865e Cq-Include-Trybots: master.tryserver.chromium.android:android_mojo Reviewed-on: https://chromium-review.googlesource.com/c/1423115 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#625805}
-
Wei Li authored
Some accessibility unit tests were accidently removed from BUILD file on r5da1d21f, so they can not be tested. This CL adds them back so we can still check on the results from these tests. BUG=none Change-Id: I1b495cc614b4402c4a360cd1c29dd3b174db61d8 Reviewed-on: https://chromium-review.googlesource.com/c/1432833Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#625804}
-
Min Qin authored
on M and L, detaching a notification from foreground service is not supported. As a result, the current implementation just put the notification in a sharedPreference and persist it across service restarts. However, the recent introduction of stopSelf() will remove the notification, and service will not restart. The logic for M and L really complicates the implementation, and the only side effect it tries to save is the notification flicker when pausing a download. This CL removes the notification persisting logic for L and M. When stopping the foreground service, we simply kill the existing notification, and launch a new one. BUG=919026 Change-Id: Ie9df5d17714d7ff9c54eed8f9b3ca1ddfaaf3199 Reviewed-on: https://chromium-review.googlesource.com/c/1432875Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#625803}
-
Tim Volodine authored
Match the threading of AndroidStreamReaderURLLoader (NS code path) to that of AndroidStreamReaderURLRequestJob (current code path). In particular make sure to open the input stream on a background worker thread. The input stream can be provided by the embedding app, so it's important to respect the original thread model. The AndroidStreamReaderURLLoader is also used for loading android assets, android resources and content scheme urls. Add ThreadChecker same thread DCHECKs in AndroidStreamReaderURLLoader. Add OnInputStreamOpenFailed delegate method to be called on the IO thread with the necessary restart logic. Add threading checks for OpenInputStream and OnInputStreamOpenFailed in the unittest. BUG=913524,841556 Cq-Include-Trybots: master.tryserver.chromium.android:android_mojo Change-Id: I23da72265ab0db8f0236bc1760d09826102317ef Reviewed-on: https://chromium-review.googlesource.com/c/1422698 Commit-Queue: Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
-
Becca Hughes authored
We should use url formatter for source title now the overshadowing issue has been fixed as this is the recommended way for displaying origins in the UI. BUG=923078 Change-Id: I36d57e38a82295ffd0308a7e8d15260305e10f60 Reviewed-on: https://chromium-review.googlesource.com/c/1432712Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#625801}
-
Weiyong Yao authored
When to change source during a tab sharing session, the new picker will only be available on the tab which starts the session. If that tab is not on the front, user may probably miss the picker. This cl is to bring the tab up to front before showing the picker for easy notice. If use selects to cancel the source changing, this cl will activate the previous shared tab to continue the sharing session. Bug: 892201 Change-Id: I51c6436095df37f3afb3d28aebbfb9e4bb03f3a5 Reviewed-on: https://chromium-review.googlesource.com/c/1423700Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Commit-Queue: Weiyong Yao <braveyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#625800}
-
siyua authored
Server side config https://critique.corp.google.com/#review/230617773 Bug: 897998 Change-Id: I1cd43e99351cae54e63dea14280bd973e3caf2fd Reviewed-on: https://chromium-review.googlesource.com/c/1434176Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#625799}
-
