- 23 Jan, 2019 40 commits
-
-
wutao authored
This patch builds util as its own target, which helps to separate the views and controllers in the deps. Bug: 924624 Change-Id: Id3238d91b77a35b0c8251e8bc4c52c55f6c37035 Test: manual Reviewed-on: https://chromium-review.googlesource.com/c/1392508 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#625312}
-
Allen Robinson authored
This will allow web tests to verify that OT-controlled features with status set to test are disabled and enabled as appropriate based on the presence of tokens in the page. Bug: 831869 Change-Id: I4ed1a16c5fd21740a310230e053132abdd3f7851 Reviewed-on: https://chromium-review.googlesource.com/c/1426483 Auto-Submit: Allen Robinson <arobins@google.com> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Jason Chase <chasej@chromium.org> Cr-Commit-Position: refs/heads/master@{#625311}
-
Boris Sazonov authored
This CL moves the sync data types management out of SyncAndSevicesPreferences settings page into a new ManageSyncPreferences page. This CL also changes the approach used by these fragments to save/update preference values. Instead of saving the state of data types in onStop, it is now saved on every change. This simplifies the logic around updating the state of the preference rows that represent these data types. This CL also removes "Use sync and all services" toggle from SyncAndServicesPreferences. Bug: 914056 Change-Id: I5ac5f40588b4924c4571025006d7de70d3e3d2bd Reviewed-on: https://chromium-review.googlesource.com/c/1425497 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#625310}
-
Oleh Prypin authored
This reverts commit e2d6a4e8. Reason for revert: Fails on Windows: "MBErr: did not generate any of browser_tests_apprtc.exe.runtime_deps" Original change's description: > Port AppRTC browsertests to isolate/Swarming > > Bug: 888429 > Change-Id: I6b71736b7455ed2c4ca2a235c34df024c013ffa5 > Reviewed-on: https://chromium-review.googlesource.com/c/1254202 > Reviewed-by: Stephen Martinis <martiniss@chromium.org> > Reviewed-by: Patrik Höglund <phoglund@chromium.org> > Commit-Queue: Oleh Prypin <oprypin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#625251} TBR=phoglund@chromium.org,martiniss@chromium.org,oprypin@chromium.org Change-Id: Iea2311bd5ee048973f82547c98a44c863ed42296 No-Tree-Checks: true No-Try: true Bug: 888429 Reviewed-on: https://chromium-review.googlesource.com/c/1430702 Auto-Submit: Oleh Prypin <oprypin@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#625309}
-
Anna Malova authored
Dynamic module: If the module loader setup is changed, create a module loader with a new settings instead of crashing. Destroy an old dynamic module and load a new one. Bug: 924118 Change-Id: Iea1af7ced5f379ff9eb7e6bca2b737d8a12a05fa Reviewed-on: https://chromium-review.googlesource.com/c/1429962 Commit-Queue: Anna Malova <amalova@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#625308}
-
Tim Zheng authored
This CL prevents the popup menu item to switch between low and high display density when the scale factor of the display is 1.0. BUG=chromium:839242 TESTManually verified on an eve and a kefka device. Change-Id: Ifeef6bcc98d38b44ffac68b5ceac72a03b34f1b6 Reviewed-on: https://chromium-review.googlesource.com/c/1428219 Commit-Queue: Tim Zheng <timzheng@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#625307}
-
Jamie Madill authored
This reverts commit f51a1863. Reason for revert: Failing on GPU.FYI waterfall with infra failures. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20FYI%20Experimental%20Release%20%28NVIDIA%29/7534 Error message: 2019-01-23 04:09:32,328 - root: [DEBUG] Using task_output_dir: '/b/swarming/w/ir/tmp/t/tmpApTs02' 2019-01-23 04:09:32,328 - root: [WARNING] task_output_dir '/b/swarming/w/ir/tmp/t/tmpApTs02' already exists! 2019-01-23 04:09:32,328 - root: [WARNING] task_output_dir existing content: [] 2019-01-23 04:09:32,329 - root: [INFO] collect_cmd: swarming collect -server https://chromium-swarm.appspot.com -worker 50 -task-summary-python -task-output-stdout json -verbose -requests-json /b/swarming/w/ir/tmp/t/tmpA0HKG5.json -output-dir /b/swarming/w/ir/tmp/t/tmpApTs02 -task-summary-json /b/swarming/w/ir/tmp/t/tmp6gdVt2.json [D2019-01-23T04:09:33.514560-08:00 26582 0 collect.go:343] Waiting task_id: 42936f11c945ba10 [D2019-01-23T04:09:33.579577-08:00 26582 0 collect.go:343] Waiting task_id: 42936f106e880410 Original change's description: > Add mixin to optionally use upgraded Linux NVIDIA drivers. > > This mixin will allow a fallback to the older stable driver version after > ten minutes of failing to find the new driver version. > > Bug: 887241 > Change-Id: Ieb279babadb6f57441b3c72172f70d4014b2bf8a > Reviewed-on: https://chromium-review.googlesource.com/c/1422838 > Commit-Queue: Jamie Madill <jmadill@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#625116} TBR=jmadill@chromium.org,kbr@chromium.org Change-Id: I0cac90dc56e383255ea66c0e066e43ded4ca0083 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 887241 Reviewed-on: https://chromium-review.googlesource.com/c/1431473Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#625306}
-
manuk authored
Currently, answer images are displayed as image elements whose src attribute is set to a data url; the user has no way of obtaining the original image url. This CL adds an anchor element displaying the image src to the 'Contents & Description & Answer' column. Bug: 891303 Change-Id: I3ba68f58a95557554bee67d5088b10eec8b3bb29 Reviewed-on: https://chromium-review.googlesource.com/c/1430682Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#625305}
-
Wenzhao Zang authored
This flag was added for the convenience of debugging crbug.com/776613. It's no longer used after the bug is fixed. Bug: None Change-Id: Iacf9846f4c1a74cc34748e878af25d287c0990e1 Reviewed-on: https://chromium-review.googlesource.com/c/1427680Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#625304}
-
Ryan Sleevi authored
For features that were potentially blocked by Feature Policy, a codepath existed to record usage that would be deprecated. That usage was deprecated in M64, and retired in https://crrev.com/581528, so there's no need to keep the dead code path around. Bug: 689802 Change-Id: I235d37446f0d3065acadff0a8af7887fc13bc276 Reviewed-on: https://chromium-review.googlesource.com/c/1427455Reviewed-by:
-
Eric Karl authored
This is a reland of e4f50713 There was a conflict between this CL and the one which landed at the same time: https://chromium-review.googlesource.com/c/chromium/src/+/1415306 Re-landing this first. Original change's description: > Add SharedImage identifying bit to gpu::Mailbox > > As we transition to SharedImage, certain places in code need to know > whether a mailbox they receive should be used with the SharedImage > system or legacy mailbox system. > > This CL adds a flag to Mailbox to identify SharedImage usage, and > converts existing clients to check this flag. > > Bug: 922834 > Change-Id: I20900e302e2620d216377edc5d6f0017270c23d6 > Reviewed-on: https://chromium-review.googlesource.com/c/1416836 > Commit-Queue: Eric Karl <ericrk@chromium.org> > Reviewed-by: Antoine Labour <piman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#624883} Bug: 922834 Change-Id: Iaf0aaddfbf8d69eebe9d9c325826dc5c1879cb9c Reviewed-on: https://chromium-review.googlesource.com/c/1430992Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#625302}
-
siyua authored
Fetch user email from LocalCardMigrationManager and pass it along ChromeAutofillClient, ManageMigrationUiController, LocalCardMigrationDialogController and LocalCardMigrationDialogView. Added implementation screenshots in comment#42 in the bug. Bug: 897998 Change-Id: I0d0f4116052196c33440256ba1a4420be146fe60 Reviewed-on: https://chromium-review.googlesource.com/c/1413134Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Tao Bai <michaelbai@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#625301}
-
Jacob Dufault authored
Bug: 908498 Change-Id: I2d70ad8c05955c2271fe99e7941dcd451f72928f Reviewed-on: https://chromium-review.googlesource.com/c/1351558 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#625300}
-
Eric Foo authored
Bug: 868213 Change-Id: Ibc9e5934ba9834833a5909a2ce7f41619c3962f7 Reviewed-on: https://chromium-review.googlesource.com/c/1429519 Auto-Submit: Eric Foo <efoo@chromium.org> Commit-Queue: Ryan Tseng <hinoka@chromium.org> Reviewed-by:
Ryan Tseng <hinoka@chromium.org> Cr-Commit-Position: refs/heads/master@{#625299}
-
Jeffrey Cohen authored
Bug: 910390 Change-Id: I9f4155a4d914759251fafaa804c9f799a618a9ba Reviewed-on: https://chromium-review.googlesource.com/c/1422819 Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Auto-Submit: Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#625298}
-
Matthew Jones authored
Bug: 901952 Change-Id: Ib18f0b09c72640475101f24b36189b5edd25936b Reviewed-on: https://chromium-review.googlesource.com/c/1430585 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
-
Alex Clarke authored
base::unique_any needs base::in_place_type_t and it makes sense for these to be defined in the same place. Bug: 906125 Change-Id: I1d206c5456e172ed8020a0e96d5c2afa7f01c637 Reviewed-on: https://chromium-review.googlesource.com/c/1429979 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#625296}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/4a405eda53be..3d7102424810 git log 4a405eda53be..3d7102424810 --date=short --no-merges --format='%ad %ae %s' 2019-01-23 afdx@google.com Added some documentation about the reducer. (#2318) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@3d7102424810 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I355eb3a257c08635452868f7b30c419a2abd9feb Reviewed-on: https://chromium-review.googlesource.com/c/1430912Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#625295}
-
Kristi Park authored
Support dark mode colors for the gear dialog and the custom background dialog. Screenshots: https://screenshot.googleplex.com/ragisEWgh7Y.png https://screenshot.googleplex.com/Xg85JK8n9PK.png https://screenshot.googleplex.com/bTTH2f44Q6t.png Bug: 919961 Change-Id: I789bf56506ef8aee9225f27b8990244c7898c0ea Reviewed-on: https://chromium-review.googlesource.com/c/1427621Reviewed-by:
Kyle Milka <kmilka@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#625294}
-
Jordan Demeulenaere authored
[Autofill Assistant] Header, Details, Carousel, PR coordinators are now instantiated by BottomBarCoordinator. Change-Id: Ia609f0ee4807c2fb9f58cba48e7c638f0ae094af Reviewed-on: https://chromium-review.googlesource.com/c/1430087 Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#625293}
-
Yusuke Sato authored
BUG=None TEST=None Change-Id: I9af69df7832958ca6f1b8c7a65f8ae018d7ad32a Reviewed-on: https://chromium-review.googlesource.com/c/1427879 Commit-Queue: Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Long Cheng <lgcheng@google.com> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#625292}
-
Robert Ogden authored
When navigations are cancelled by a preview, the cancelled reload type is lost. This CL adds ReloadType to the various parameters and layers in browser-initiated navigations so that it can be preserved. Bug: 914547 Change-Id: Ibd5c272252ec06fff8ac6300287c70a5074a6193 Reviewed-on: https://chromium-review.googlesource.com/c/1426519Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#625291}
-
Kristi Park authored
Screenshots: https://screenshot.googleplex.com/xdxsFVdfMT3.png https://screenshot.googleplex.com/60nh9bRXjLu.png Bug: 919961 Change-Id: I620997bc3b76eff3c0126c69af122b0875b4f56a Reviewed-on: https://chromium-review.googlesource.com/c/1428539Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/21b1ee52..9df9418e Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ifb370322e6d064014657d697106bfd3331c7119b Reviewed-on: https://chromium-review.googlesource.com/c/1430661Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#625289}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9eb5076ed0c1..d1737fb0576a Created with: gclient setdep -r src-internal@d1737fb0576a The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:891734,chromium:891313,chromium:891734 TBR=mmoss@chromium.org Change-Id: I6bab4fe920a70b802ac5e66dbd41f525da225075 Reviewed-on: https://chromium-review.googlesource.com/c/1430894Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#625288}
-
Vladimir Levin authored
This patch ensures that the elements in a locked subtree with searchable: false are not focusable by either mouse or keyboard. In effect this prevents tab order navigation to elements in locked subtrees. R=chrishtr@chromium.org Bug: 882663 Change-Id: I0fbde6ba811be21021e450b38b584aa24ad7e52a Reviewed-on: https://chromium-review.googlesource.com/c/1417715Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#625287}
-
James Darpinian authored
https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/f22b9ad..db52df1 TBR: kbr@chromium.org Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_angle_rel_ng;luci.chromium.try:win-angle-rel Change-Id: Ia39997032b4ac59d5da49051396e1b8e931101b1 Reviewed-on: https://chromium-review.googlesource.com/c/1427576Reviewed-by:
James Darpinian <jdarpinian@chromium.org> Commit-Queue: James Darpinian <jdarpinian@chromium.org> Cr-Commit-Position: refs/heads/master@{#625286}
-
Peng Huang authored
Bug: 919865 Change-Id: Ia24d527ef1ac7af7c58fda5bf232c429d0ebc453 Reviewed-on: https://chromium-review.googlesource.com/c/1427610Reviewed-by:
Jonathan Backer <backer@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#625285}
-
Esmael El-Moslimany authored
Bug: 923274 Change-Id: I98b7a42fd02ec0a950074265f4bf0c992ecc9b08 Reviewed-on: https://chromium-review.googlesource.com/c/1427739 Auto-Submit: Esmael El-Moslimany <aee@chromium.org> Reviewed-by:
Dan Beam (slow until 1/29) <dbeam@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#625284}
-
Moe Ahmadi authored
This reverts commit 9df0aa65. Reason for revert: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/fuchsia-x64-cast/11742 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/fuchsia-arm64-cast/11675 Original change's description: > Enable connectivity checker for fuchsia > > We are using the default connectivity checker, and adding the switch > |--require-wlan| to allow developers to force connections to only WLAN > network interfaces. > > Fuchsia devices typically have an ethernet cable connected for > development, which causes the connectivity checker to always return connected. > For some tests and development, we need to force the usage of WLAN > interfaces, thus this switch was needed. > > Run cast with --require-wlan, observe disconnected > > Bug: 777973 > Test: net_unittests && Run cast with no flags, observe connected && > Change-Id: I359c57a83ce42eb81e5795c0c2c7b711b907471e > Reviewed-on: https://chromium-review.googlesource.com/c/1419903 > Reviewed-by: Paul Jensen <pauljensen@chromium.org> > Reviewed-by: Luke Halliwell <halliwell@chromium.org> > Reviewed-by: Wez <wez@chromium.org> > Commit-Queue: Aidan Wolter <awolter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#625258} TBR=wez@chromium.org,pauljensen@chromium.org,halliwell@chromium.org,awolter@chromium.org Change-Id: I5ea25b3824c74669aa4180706da8d9ada7d244a6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 777973 Reviewed-on: https://chromium-review.googlesource.com/c/1431015Reviewed-by:
-
Jun Mukai authored
Right now maximum/minimum sizes are computed from views, it's hard to detect when it exactly changes. Because of that, individual client sets those properties for now to configure those metrics propertly. Bug: 921272 Test: manually Change-Id: I062da6e771f7f1c02d3ab07bebd98ceff410b3c8 Reviewed-on: https://chromium-review.googlesource.com/c/1422704Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
-
Jon Kunkee authored
https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/42bb040dde0a..4b75b8bab993 $ git log 42bb040dd..4b75b8bab --date=short --no-merges --format='%ad %ae %s' 2019-01-10 chcunningham Add ARM64 Windows support to the Chromium FFMPEG repo 2019-01-10 liberato Handle autorename files automatically. Bug: 893460 Change-Id: Iccb2d42f701e5a45e04d1cd47b15f4fb4e00682c Reviewed-on: https://chromium-review.googlesource.com/c/1429385Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#625281}
-
Lei Zhang authored
Instead, print more like as other platforms. On the renderer side, remove most Android-specific code, so it behaves like Linux. As a result, the printed document data is transferred via PrintHostMsg_DidPrintDocument, instead of the Android-specific IPC messages. To handle this in WebView, add AwPrintManager::OnDidPrintDocument() to receive the printed data, and write it out to its file descriptor. To handle this in Chromium, reuse the existing printing architecture and add the missing Android-specific bits. Hold the file descriptor used for printing in PrintingContextAndroid, and implement PrintingContextAndroid::PrintDocument() to write to the file descriptor. BUG=922657 Change-Id: I1c0123cade448de5a3ace00d671ecae61a04ffd3 Reviewed-on: https://chromium-review.googlesource.com/c/1420297 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#625280}
-
Leonardo Padilha authored
Add return from suspend mode as trigger to status report. Bug: 919132 Change-Id: I9a3533de21bc8d83761889d26e81066c14e03428 Reviewed-on: https://chromium-review.googlesource.com/c/1427839Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Leonardo Padilha <ldaguilar@chromium.org> Cr-Commit-Position: refs/heads/master@{#625279}
-
Stepan Khapugin authored
This reverts commit 2cd80cbb. Reason for revert: DCHECK fires on real users' devices. Unclear why. Original change's description: > Add a DCHECK in omnibox_view_ios. > > I suspect that processing_user_event is always true. > If this is the case, the textfield delegate can be simplified. In > order to verify this, add a DCHECK and see if it fires on the bots. > > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet > Change-Id: Ic45526950bf1f4b05a4c11a9cde551d0eef6dc0e > Reviewed-on: https://chromium-review.googlesource.com/1120816 > Reviewed-by: Rohit Rao <rohitrao@chromium.org> > Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#573710} TBR=rohitrao@chromium.org,justincohen@chromium.org,stkhapugin@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I2729f16524f3523098c09543705f007fb5e14515 Reviewed-on: https://chromium-review.googlesource.com/c/1430088 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#625278}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/71b5a7df7794..b0397d69a93a git log 71b5a7df7794..b0397d69a93a --date=short --no-merges --format='%ad %ae %s' 2019-01-23 hofbauer@webrtc.org Always send abs-send-time when negotiated and do not filter it out. 2019-01-23 yvesg@webrtc.org [CodeHealth] Fix use after std::move instances. 2019-01-23 oprypin@webrtc.org Correctly specify Mac version as 10.13 for iOS simulator tests 2019-01-23 jonasolsson@webrtc.org Don't pretend we've received an end-of-candidates indication. 2019-01-23 kwiberg@webrtc.org Rename new build targets to follow the recent large file rename 2019-01-23 srte@webrtc.org Enables feature to account for unacknowledged data. 2019-01-23 srte@webrtc.org Reland "Reland "Adds richer packet and ice processing to ParsedRtcEventLog."" 2019-01-22 mbonadei@webrtc.org Fix typo in rtc_base/thread_checker.h. 2019-01-22 eladalon@webrtc.org Make SetFirstSubFrameInFrame and SetLastSubFrameInFrame protected 2019-01-22 eladalon@webrtc.org PSFB without REMB magic word is not an error 2019-01-22 ilnik@webrtc.org Always use real VideoStreamsFactory in full stack tests 2019-01-22 ilnik@webrtc.org Report rendered pixels statistic in full stack tests 2019-01-22 ilnik@webrtc.org Reduce webrtc_perf_tests duration on buildbots 2019-01-22 nisse@webrtc.org Refactor FileRotatingStream to use FileWrapper rather than FileStream 2019-01-22 nisse@webrtc.org Include video_bitrate_allocator.h, now that's in api/ 2019-01-22 sprang@webrtc.org Parsing of pacing factor and alr probing in RateControlSettings 2019-01-22 mbonadei@webrtc.org Remove NetworkManager::{set_ipv6_enabled,ipv6_enabled}. Created with: gclient setdep -r src/third_party/webrtc@b0397d69a93a The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:922588,chromium:None,chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ib82b38129a76de737f00c2d0edd23c83d9e9b551 Reviewed-on: https://chromium-review.googlesource.com/c/1430219Reviewed-by:
-
Wei Lee authored
This CL adds OWNERS file into camera folder to clarify the ownership which it should belongs to the same owners of Chrome Camera App. Bug: 918091 Test: None Change-Id: I447ce86bea6eb420ec98c9b6a387cb69a7368a4d Reviewed-on: https://chromium-review.googlesource.com/c/1429301Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Wei Lee <wtlee@chromium.org> Auto-Submit: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#625276}
-
Manuel Rego Casasnovas authored
This optimization was introduced in r578233 but it's causing a crash when you use "text-overflow: ellipsis". We need to check if we need or not an ellipsis in the new text, and compute the position of the ellipsis if it's required. For that reason we cannot apply the optimization and we need to do a proper layout. The patch adds a new condition in LayoutText::CanOptimizeSetText() to avoid applying the optimization in that case. BUG=805785 TEST=fast/css/containment/change-text-node-data-ellipsis-crash.html Change-Id: I18c2ff04af9df64930510a6bda1071322cf07664 Reviewed-on: https://chromium-review.googlesource.com/c/1430082 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#625275}
-
Lutz Justen authored
Group device policies loosely based on the Help Center: https://support.google.com/chrome/a/answer/1375678?hl=en This grouping is used in user-facing policy docs and ADMX templates. Having the groups match the Help Center structure lets administrators find what they are looking for more easily. In particular, this is true for administrator of Active Directory managed devices, who use ADMX templates to edit GPO. This is a best effort. Things don't always work out nicely. For instance, accessibility settings have their own group and contains user and device policies, but they are under SignIn in the Help Center. Also groups some user policies (for Arc, Crostini, printing) as it fit in. Bug: 746981 Change-Id: Iba7e02cb758c7ba1004737a05c3af2ac13d909c9 Reviewed-on: https://chromium-review.googlesource.com/c/1407005Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#625274}
-
Andrew Xu authored
partial screenshot In previous code, when the partial screenshot is triggered, all of key events are stopped from propagation. As result, the release of the partial screenshot accelerator is unknown to AcceleratorHistory. It would lead to malfunction of the accelerators which rely on AcceleratorHistory, such as toggle CapsLock shortcut. This CL fixes the bug by updating AcceleratorHistory in the code block which processes the partial screenshot accelerator. Test: ash_unittests Bug: 920032 Change-Id: Ie4f553a841869db82f2710329e7968aa058713f4 Reviewed-on: https://chromium-review.googlesource.com/c/1408221Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
-
