GitLab

BUG=268457
TEST=ImmersiveModeControllerAshTest.Bubbles

Review URL: https://chromiumcodereview.appspot.com/22238003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216877 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216876 0039d316-1c4b-4281-b951-d872f2087c98

R=mallinath@chromium.org

Review URL: https://codereview.chromium.org/22471004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216875 0039d316-1c4b-4281-b951-d872f2087c98

BUG=263481,264289
TEST=WindowSelectorTest.BasicCycle
TEST=Enable --ash-enable-overview-mode and use alt-tab to cycle through MRU windows. Cycling is done in overview mode on active display.

Review URL: https://chromiumcodereview.appspot.com/22715005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216874 0039d316-1c4b-4281-b951-d872f2087c98

BUG=248357

Review URL: https://chromiumcodereview.appspot.com/22695004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216873 0039d316-1c4b-4281-b951-d872f2087c98

This fixes a crash in Chromoting Android app when it hadn't been granted permission to access OAuth tokens for an account.

Review URL: https://chromiumcodereview.appspot.com/22657003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216872 0039d316-1c4b-4281-b951-d872f2087c98

Added in a fix for the memory leak.

Move ExtensionError class to extensions/browser/, since it doesn't need to be in chrome/.
Limit the number of errors stored per extension to 100.
Store errors in a map, keyed by Extension ID, since that is how we will likely be accessing them.

BUG=21734

Review URL: https://chromiumcodereview.appspot.com/22647007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216871 0039d316-1c4b-4281-b951-d872f2087c98

BUG=157660

Review URL: https://chromiumcodereview.appspot.com/22626003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216870 0039d316-1c4b-4281-b951-d872f2087c98

Talkgadget can redirect the user to other subdomains, and our content script won't run over the intermediate 302 pages, only the final URL - so we can't assume that the actual redirect URI we'll receive will match the one we asked for. Note that there is still an implicit restriction that this must be a talkgadget subdomain (since that's our content script's url glob).

BUG=

Review URL: https://chromiumcodereview.appspot.com/22611008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216869 0039d316-1c4b-4281-b951-d872f2087c98

This merges and reimplements what was the GlobalHistoryMenu class from
the GTK+ port into linux_aura's GlobalMenuBarX11 class.

BUG=265560

Review URL: https://chromiumcodereview.appspot.com/22562005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216868 0039d316-1c4b-4281-b951-d872f2087c98

BUG=271056

Review URL: https://chromiumcodereview.appspot.com/22763003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216867 0039d316-1c4b-4281-b951-d872f2087c98

BUG=235217
TEST=visual

Review URL: https://chromiumcodereview.appspot.com/22715006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216866 0039d316-1c4b-4281-b951-d872f2087c98

Overflow Button updated to use Rotated image on side shelf.
Overflow Button background changed to match app list background in alternate shelf layout.

BUG=265661, 265662, 163000

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216531

Review URL: https://chromiumcodereview.appspot.com/22527003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216865 0039d316-1c4b-4281-b951-d872f2087c98

Make StreamTextureFactory and StreamTextureProxy abstract
base classes, and create a stub StreamTextureFactory for
Android Webview using synchronous compositor.

This provides enough plumbing to make full screen video
work in Android WebView. In-page video still requires
the in-process context to support streaming texture
manager.

BUG=239760

Review URL: https://chromiumcodereview.appspot.com/22766004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216864 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None

Review URL: https://chromiumcodereview.appspot.com/22763002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216863 0039d316-1c4b-4281-b951-d872f2087c98

BUG=270342
TEST=On ChromeOS and Android, PDF downloads should not trigger the "is
dangerous" warning.

Review URL: https://chromiumcodereview.appspot.com/22761003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216862 0039d316-1c4b-4281-b951-d872f2087c98

This patch fixes naming of member variables (s/mVariable/sVariable) and lowers
visibility of some members in ChildProcessLauncher.

BUG=None

Review URL: https://chromiumcodereview.appspot.com/22735002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216861 0039d316-1c4b-4281-b951-d872f2087c98

To test this new feature one can do the following:

On chrome, open the "Import Bookmarks and Settings..." dialog, you can do this
by three ways, one is to navigate to chrome://settings/importData, another is
to open chrome://settings (either through wrench menu or navigating to it through
omnibox) and then under the Users category click on "Import Bookmarks..." button
to open the dialog. The third way to open this dialog
is Wrench->Bookmarks->Import Bookmarks and Settings...".

Once the dialog is opened, open the "From" combobox and select "Bookmarks HTML File" item.
That should uncheck and disable all the checkboxes but "Favorites/Bookmarks" and present a
"Choose file" button in the place where "Import" button was. Click on that new button and select
your bookmarks html file, once you do that the import process should start, and if you file is
ok, chrome should import and present you with a success message.

BUG=80685
R=dbeam@chromium.org, isherman@chromium.org

Review URL: https://codereview.chromium.org/22332003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216860 0039d316-1c4b-4281-b951-d872f2087c98

When the user wanted to "Choose what to sync" in an explicit sign in,
the sync setup page was displayed in the active tab at the end of the
sign in process (except for "Sign in" initiated from the Settings page).
However, the user can change the active tab before that happens.

With this fix, the sync setup page is loaded in the same tab as the
sign in flow. If the sign in tab has been closed, a new tab is created.
The sync setup tab is also activated if it's not already.

TEST=
1. Open Chrome with a clean profile.
2. Sign in from the NTP, hot-dog menu or startup promo. Check "Choose what to sync".
3. After clicking on 'Submit', immediately navigate to some other tab.
Expected result: The sync setup page is loaded in the sign in tab and this tab is activated.
BUG=242428

Review URL: https://chromiumcodereview.appspot.com/22510004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216859 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TBR=jamescook@chromium.org

Review URL: https://chromiumcodereview.appspot.com/22493014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216858 0039d316-1c4b-4281-b951-d872f2087c98

This updates the testTargetDensityDpi test expectations as a result
of http://crrev.com/22574004 being rolled in.

BUG=None
TEST=AndroidWebViewTest

Review URL: https://chromiumcodereview.appspot.com/22493011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216857 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://chromiumcodereview.appspot.com/22492004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216856 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216855 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=155840:155898&mode=html
TBR=
BUG=

Review URL: https://chromiumcodereview.appspot.com/22418004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216854 0039d316-1c4b-4281-b951-d872f2087c98

Sending the ACK for for editor-related changes not originating from
browser uses a ScopedClosureRunner. However, since this was defined
within an if-block, the scope ended immediately.

This changes it to have a scope of the whole method, and instead
releasing it early if we are not supposed to send the ACK.

BUG=145521, 230848, 172845, 248544, 235704

Review URL: https://chromiumcodereview.appspot.com/22411008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216853 0039d316-1c4b-4281-b951-d872f2087c98

BUG=259097

Review URL: https://chromiumcodereview.appspot.com/22731002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216852 0039d316-1c4b-4281-b951-d872f2087c98

owners reviews requested,
ui/webui/ - xiyuan@
chromeos/ - stevenjb@
chrome/browser/extensions/ - asargent@

R=asargent@chromium.org, stevenjb@chromium.org, xiyuan@chromium.org
BUG=270291
TEST=Test that the system_info page and feedback reports show different logs where scrubbing is concerned (tested with the stub lib).

Review URL: https://chromiumcodereview.appspot.com/22532012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216851 0039d316-1c4b-4281-b951-d872f2087c98

Now it's owned by message_center, so it's more natural to call in
MessageCenterImpl.

BUG=270305
R=dewittj@chromium.org

Review URL: https://chromiumcodereview.appspot.com/22724002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216850 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/22488007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216849 0039d316-1c4b-4281-b951-d872f2087c98

Make the experiments in the bundled omnibox field trial be able to 
specify whether they should on for instant-extended-enabled users, off 
for those users but on for everyone else, or on for everyone.

I tested this interactively using a local variations server.  Plus
there's improved unit tests.

BUG=267584

Review URL: https://chromiumcodereview.appspot.com/22698002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216848 0039d316-1c4b-4281-b951-d872f2087c98

Added a private API for this.

BUG=164227
TEST=No

Review URL: https://chromiumcodereview.appspot.com/22382006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216847 0039d316-1c4b-4281-b951-d872f2087c98

(identity is out of experimental)

BUG=

Review URL: https://chromiumcodereview.appspot.com/22339015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216846 0039d316-1c4b-4281-b951-d872f2087c98

BUG=269809

Review URL: https://chromiumcodereview.appspot.com/22336007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216845 0039d316-1c4b-4281-b951-d872f2087c98

R=robertshield@chromium.org
BUG=None

Review URL: https://chromiumcodereview.appspot.com/22743003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216844 0039d316-1c4b-4281-b951-d872f2087c98

This client app should not be used by all clients of content/. Moving to chrome so it can be managed there and re-used if needed.

Review URL: https://chromiumcodereview.appspot.com/21355004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216843 0039d316-1c4b-4281-b951-d872f2087c98

Pasting into fakebox via context-menu didn't work before.
This change adds a paste function to the searchbox api, that gets the text
from the clipboard into the omnibox using SetUserText ( opening the
suggestions panel.)

BUG=164784
TEST=Right click on fakebox and paste. The pasted value should appear on the omnibox and the suggestions panel should be open.

Review URL: https://chromiumcodereview.appspot.com/20501002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216842 0039d316-1c4b-4281-b951-d872f2087c98

Previously the config and clip_region field formats depended on skia
internal implementation details. This patch decouples the interface
from the specific skia version in use.


BUG=

Review URL: https://chromiumcodereview.appspot.com/20234002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216841 0039d316-1c4b-4281-b951-d872f2087c98

The window's KEEP_SCREEN_ON flag is more like controlling the screen from an Activity level, and we shouldn't use it instead, view's KEEP_SCREEN_ON flag should be used.

This patch attaches a zero size view to ContentViewCore's mContainerView instead of view tree, so once the ContainerView is invisible, the screen can turned off even PowerSaveBlocker not removed.


BUG=270903

Review URL: https://chromiumcodereview.appspot.com/20125004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216840 0039d316-1c4b-4281-b951-d872f2087c98

This adds a set of experimental strings to the malware download warning for a finch experiment.

BUG=267335

Review URL: https://chromiumcodereview.appspot.com/22640018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216839 0039d316-1c4b-4281-b951-d872f2087c98

Use the plugin-side file descriptor for asynchronous
callbacks too.

TBR=dmichael@chromium.org
CL only removes messages that had a LGTM in a prior CL.
https://codereview.chromium.org/18063005/

BUG=194304

Review URL: https://codereview.chromium.org/22646005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216838 0039d316-1c4b-4281-b951-d872f2087c98