GitLab

These bots weren't building with these codecs and should have been. In
at least one case (Win Builder), the fact that the waterfall bot wasn't
building with the codecs represented a mismatch in configuration between
the waterfall bot and trybot.

This CL affects the configurations of the following machines:

  chromium.linux:Linux Builder (dbg)
  chromium.linux:Linux Builder (dbg)(32)
  chromium.linux:Linux Builder
  chromium.mac:Mac Builder (dbg)
  chromium.win:Win Builder
  chromium.win:Win Builder (dbg)
  chromium.win:Win x64 Builder
  chromium.win:Win x64 Builder (dbg)
  tryserver.chromium.linux:linux_chromium_dbg_32_ng
  tryserver.chromium.linux:linux_chromium_dbg_ng
  tryserver.chromium.mac:mac_chromium_compile_dbg_ng
  tryserver.chromium.mac:mac_chromium_dbg_ng
  tryserver.chromium.win:win10_chromium_x64_dbg_ng
  tryserver.chromium.win:win10_chromium_x64_rel_ng
  tryserver.chromium.win:win_chromium_compile_dbg_ng
  tryserver.chromium.win:win_chromium_dbg_ng
  tryserver.chromium.win:win_chromium_x64_rel_ng

Bug: 867536
Change-Id: I04584548cb903df49ab1071535612ea151310c88
Reviewed-on: https://chromium-review.googlesource.com/1150450Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578766}

https://chromium.googlesource.com/angle/angle.git/+log/021bad40ff8b..9bf86f07acd5


git log 021bad40ff8b..9bf86f07acd5 --date=short --no-merges --format='%ad %ae %s'
2018-07-27 geofflang@chromium.org Don't sync the read framebuffer on draw calls.
2018-07-27 lrn1986@gmail.com Support EGL_(WIDTH|HEIGHT) in eglSurfaceAttrib(), fixed resize
2018-07-27 jmadill@chromium.org D3D: Return error from getVertexSpaceRequired.
2018-07-27 jmadill@chromium.org D3D: Pass gl::Context to many more functions.


Created with:
  gclient setdep -r src/third_party/angle@9bf86f07acd5

The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=geofflang@chromium.org

Change-Id: I1ef966bf7450d269cf65820f935cb9ca81e37c81
Reviewed-on: https://chromium-review.googlesource.com/1153508Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#578765}

This reverts commit 1fa4591e.

Reason for revert: In hopes of greening tree. Sample failure from https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win/71221 : (see the compile no-op stage)

ninja explain: output obj/content/test/nested_message_pump_android.lib doesn't exist
ninja explain: obj/content/test/nested_message_pump_android.lib is dirty

Original change's description:
> Merge all content_shell renderer layout_test code.
> 
> R=​dcheng@chromium.org
> TBR=jochen@chromium.org
> 
> Currently layout test code is split over:
> 
> - content/shell/test_runner/ (separate component)
> Has renderer-side code, is allowed to use content/renderer/, does not
> use content/shell/renderer/.
> 
> - content/shell/renderer/layout_test/ (part of content_shell_lib)
> Has renderer-side code, makes light use of content/shell/renderer/, but is
> not able to use content/renderer/.
> 
> - content/shell/browser/layout_test/ (part of content_shell_lib)
> Has browser-side code, makes heavy use of content/shell/browser/, but is
> not able to use content/browser/.
> 
> - content/public/test/layouttest_support.h
> Header for access to content/renderer/ things and content/browser/
> things. Used by content/shell/renderer/layout_test/ and
> content/shell/browser/layout_test/.
> 
> - content/test/layouttest_support.cc
> Impls for access to content/renderer/ and content/browser/ things.
> 
> 
> This patch aims to
> 1. Combine the test_runner/ and shell/renderer/layout_test/ pieces of
> code so they don't need to use indirections to interact. Their
> separation is a legacy of test_runner/ being implemented inside blink
> (WebKit) in the past.
> 2. Move layouttest_support.h out of content/public/ and the .cc out of
> content/test/ to a layout_test-specific code location.
> 
> To do (1), test_runner/* moves to shell/renderer/layout_test/*. This
> is fairly straight forward. We remove the TEST_RUNNER_EXPORT macro
> as they are now part of a static library. They are left in the
> test_runner namespace at the moment.
> 
> To do (2), we move layouttest_support.(cc|h) to
> shell/renderer/layout_test/. There are 3 methods in the file that
> are called from shell/browser/layout_test/ and use content/browser
> so we split those out to shell/browser/layout_test/.
> 
> However this causes a problem that content_shell_lib will depend
> on content/{browser,child,renderer}/ via the layouttest_support.cc
> file. To avoid this, we
> - Move content/shell/renderer/layout_test/* into a separate build
> target called //content/shell:layout_test_renderer_lib and we
> give it visibility to content/renderer/ and content/child/.
> - Move content/shell/browser/layout_test/layouttest_support.* into
> a separate build target called
> //content/shell:browser_layout_test_support_lib. We don't move all
> of content/shell/browser/layout_test/* because of heavy interaction
> between it and its parent directory at this time.
> - For a few files used by the shell/renderer/ (and shell/) and
> shell/renderer/layout_test/ directories, we move them out to a
> shared library as well, called
> //content/shell:content_shell_renderer_common_lib.
> - And for the common/layout_test/layout_test_switches.cc files,
> which are used in both, but we'd like to not leak out of
> content_shell_lib since they are part of .../layout_test/, we
> make a non-public dep on //content/shell:content_shell_common_test_lib
> 
> Ideally, I think we have a separate library for
> //content/shell/browser/layout_test
> //content/shell/common/layout_test
> //content/shell/renderer/layout_test
> 
> But we need better indirection between the content_shell_lib and
> the .../layout_test/ code in order to do that. Once it was so, we
> would be closer to making it possible to have a content_shell build
> target that does not include any test code (and thus truly only uses
> the public APIs), and a separate content_shell-like build target
> that includes the layout test code.
> 
> Bug: 866140
> Change-Id: Ia39f7385711bdb610948a07fd473ad9b346b82ae
> Reviewed-on: https://chromium-review.googlesource.com/1145644
> Reviewed-by: danakj <danakj@chromium.org>
> Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#578734}

TBR=dgozman@chromium.org,danakj@chromium.org,dcheng@chromium.org,jochen@chromium.org

Change-Id: Ie61b12dcfc00e5c59cf0c5e3137b305d957cb261
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 866140
Reviewed-on: https://chromium-review.googlesource.com/1153611Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578764}

R=tomfinegan@chromium.org

Change-Id: I926b4d76701861c4351baf6e4982ce0beb962e49
Reviewed-on: https://chromium-review.googlesource.com/1153584Reviewed-by: James Zern <jzern@chromium.org>
Commit-Queue: Johann Koenig <johannkoenig@google.com>
Cr-Commit-Position: refs/heads/master@{#578763}

This reverts commit 9442f946.

Reason for revert: didn't budge the graph (https://chromeperf.appspot.com/report?sid=d99ad2294f639cf4e0d0bbfa0e9aee1cac5a0352ef9f35d266f375f52466a608&start_rev=1526716391&end_rev=1532706078)

Original change's description:
> [TaskScheduler] Require constant initialization for g_heartbeat_for_testing
> 
> Somehow r562248 caused a regression whereby it should have been strictly
> more performant, the only difference is the potential static
> initializer (which if incorrectly initialized could result in it being
> non-zero? and somehow cause the timer to be fast?).
> Let's try to suppress it.
> 
> R=​fdoray@chromium.org
> 
> Bug: 848255
> Change-Id: I21111ddd4c069b9171badc58fc4a1914bb068641
> Reviewed-on: https://chromium-review.googlesource.com/1090794
> Reviewed-by: François Doray <fdoray@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#578420}

TBR=gab@chromium.org,fdoray@chromium.org

Change-Id: I457751dc2d9d410e049685e22cf3f79cf39d3c11
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 848255
Reviewed-on: https://chromium-review.googlesource.com/1153230Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578762}

The kMaxArea downsizing logic in WebGLRenderingContextBase::Reshape
causes the drawing buffer size to be smaller than the canvas size
if the size would exceed 16 MiPixels. See https://crbug.com/445542
for additional background.

The GetStaticBitmapImage has two separate implementations that
are selected based on the preserve_drawing_buffer attribute. The
non-preserving mode returns an image sized to match the drawing buffer,
while the preserving snapshot used the canvas size.

Change GetImage to use the drawing buffer size also for consistency.

BUG=845742

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I8cb00444e18f075abde881c5bb155ef039f7a68e
Reviewed-on: https://chromium-review.googlesource.com/1153483Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Klaus Weidner <klausw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578761}

Bug: 861564, 782981, 850662
Change-Id: Ib5c1dc874972aadd3223bd4851f0b5aeb695a727
Reviewed-on: https://chromium-review.googlesource.com/1128540
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578760}

This CL flips `use_once_callback` flag on the Mojo code generator for
//services/ui/public, and fixes all compile errors after that. After
this CL, Mojo interfaces there service starts using base::OnceCallback
instead of base::Callback on its return value handling.

Bug: 714018
Change-Id: I9a0923249f3bb2b37319a118f742f384c90cf31f
Reviewed-on: https://chromium-review.googlesource.com/1151185Reviewed-by: kylechar <kylechar@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578759}

https://aomedia.googlesource.com/aom.git/+log/ef95278f79fa..4f1fd9640433

$ git log ef95278f7..4f1fd9640 --date=short --no-merges --format='%ad %ae %s'
2018-07-25 thomasanderson Fix build with CFLAGS="-std=c11 -D_GNU_SOURCE"
2018-07-26 yunqingwang Free frame header buffer
2018-07-17 sachin.kumargarg Add ARM Neon optimization of txfm 8x8
2018-07-25 ddvfinite Add compute_stats SSE4_1 and AVX2 code
2018-07-26 jonathan.matthews [normative]Reset quantization params when not set
2018-07-26 deepa.kg Enable sse2 intrinsics for highbd variance calculation
2018-07-25 binpengsmail Refine pingpong buffer in handle_inter_mode
2018-07-25 ranjit.tulabandu Fix issues in interpolation filter selection
2018-07-22 birkbeck Add ifdef in SSE2/AVX2 fft tests
2018-07-25 binpengsmail Speedup motion_mode_rd
2018-07-25 angiebird Fix bug of DO_RANGE_CHECK_CLAMP

Created with:
  roll-dep src/third_party/libaom/source/libaom

BUG=427584

Change-Id: I96aac1e87e921bdc4c019c97d06d1884e66b6165
Reviewed-on: https://chromium-review.googlesource.com/1152365Reviewed-by: James Zern <jzern@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578758}

Up until now, all actions related to in-product help have been
considered directly triggered by the user, which is not necessarily
the case, as some of them are more a by-product of other actions.

This leads to in-product help being very prominent in some of
helpful dashboards we have for these types of metrics, and it
is swamping other entries.

For now, the following in-product help actions are kept:
*   InProductHelp.Dismissed:
    *   This is kept because it is in fact a user action to dismiss
        the in-product help.
*   InProductHelp.ShouldTriggerHelpUIResult.Triggered.IPH*
    *   This is kept because it might very well impact what the user
        does next, since the UI will look different than for when it
        is not triggered. In addition, this happens very seldom, so
        the chances of this swamping the dashboards should be small.

The following are marked as not_user_triggered:
*   InProductHelp.NotifyEvent.IPH*
    *   This might be a user action, but if a feature cares about that,
        they should add their own specific action.
*   InProductHelp.ShouldTriggerHelpUI.IPH*
    *   This is very often invoked, but is often a by-product of other
        actions.
*   InProductHelp.ShouldTriggerHelpUIResult.NotTriggered.IPH*
    *   This is recorded around the same time as the
        ShouldTriggerHelpUI, and is also typically a by-product.
*   InProductHelp.ShouldTriggerHelpUIResult.WouldHaveTriggered.IPH*
    *   This is recorded around the same time as the
        ShouldTriggerHelpUI, and is also typically a by-product. It is
        similar to the .Triggered version, but it does not have any
        effect on what the user sees.

BUG=786102

Change-Id: I067d507470c79870e8627ecb1168584b862cf28b
Reviewed-on: https://chromium-review.googlesource.com/1137026Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578757}

This patch introduces "EditingNG" runtime enabled feature which implies
"LayoutNG" for adapting editing to LayoutNG incremental. Once editing
functionalities adapted to LayoutNG, this runtime enabled feature will be
removed.

Bug: 707656
Change-Id: I3e9edcf9a207e284740d082feb8ef08dbec090a9
Reviewed-on: https://chromium-review.googlesource.com/1152715Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578756}

It's platform convention to show popups as new tabs while in
non-HTML5 fullscreen. (Popups cause tabs to lose HTML5 fullscreen.)

This was implemented for Cocoa in a BrowserWindow override, but
it makes sense to just stick it into Browser and remove a ton
of override code put in just to support this.

BUG=858929, 868416
TEST=as in bugs

Change-Id: I43471f242813ec1159d9c690bab73dab3e610b7d
Reviewed-on: https://chromium-review.googlesource.com/1153455Reviewed-by: Sidney San Martín <sdy@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578755}

Previously, an opaque origin is passed to
MainThreadDebugger::ContextCreated() for Paint/Layout worklets,
and caused the origins in the context selector shown as "IFrame".

This CL passes DocumentSecurityOrigin() instead, which is the
origin of the Document that creates the worklets, and thus
shows the correct origin.

Bug: 866666, 861564
Change-Id: Ic038b3901ed0e301e4d2d9afdf632f7caf6add77
Reviewed-on: https://chromium-review.googlesource.com/1141290Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578754}

Currently |paint_image_entries_| which keeps track of the content ids
being cached for a PaintImage can grow unbounded. Ensure that we keep
purging it as the cached entries are removed from the
|persistent_cache_|.

R=ericrk@chromium.org

Bug: 867939
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ic43eee96eec42073a3d14512e62d39946585bba4
Reviewed-on: https://chromium-review.googlesource.com/1152492Reviewed-by: Eric Karl <ericrk@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578753}

Updates the XR instrumentation Markdown documentation to be consistent
with the recent refactor.

Bug: 863256
Change-Id: I21e2a492ab8e0a776010af9d624e04ef5631314a
Reviewed-on: https://chromium-review.googlesource.com/1152515Reviewed-by: Amirhossein Simjour <asimjour@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578752}

A SharedBitmapId must be unique and should only be registered with
the display compositor once (and is implicitly unregistered if the
CompositorFrameSink is lost that it was registered to). Crash the
renderer if it violates this principle on a single CompositorFrameSink
so we can help track down why this is happening.

R=kylechar@chromium.org

Bug: 862584
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I37f36d0e4be20c5313c92e9e3a319803c0a58aaf
Reviewed-on: https://chromium-review.googlesource.com/1153467Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578751}

When a node is reparented we currently destroy it rather than actually
reusing it, causing it to look like a new node. New nodes do not fire
change events for name, state, value or live regions.

Impact:
- We need to reuse nodes if we want them to be able to fire change
events when they are reparented at the same time.
- Accessibility nodes can be unexpectedly reparented by the layout
engine, as shown in the included test.

Bug: 469254
Change-Id: I7aec0d7852c712724b97be4a723df3c928720d62
Reviewed-on: https://chromium-review.googlesource.com/1152477
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578750}

Change log:
https://github.com/google/closure-compiler/compare/5cae9b78a16a2655627733b66d1c686d5f547925...137c2475944651f45433965afa9f1cddf7d1966b
chrome_extensions.js: 03c824e85e7b77bde4e7449ed3727608b05b2acc -> 86f260c5faab5511c3a7111f93d99f6421e1f430
polymer-1.0.js: 8f3b8c9354813ae0e2f186bf2f504cf3f3182a66 -> 2efd918e5c4042f956fd76dae0d2714af9dc89ef

Bug: None
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Id4f025206a59b5ddcc4797b6b3673ad8db805663
Reviewed-on: https://chromium-review.googlesource.com/1150831Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578749}

Bug: 856172
Change-Id: I19d5e6052fb394aba40bde96bfa40762cc7e4e44
Reviewed-on: https://chromium-review.googlesource.com/1152100
Commit-Queue: Cathy Li <chili@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578748}

Right now none of SVG related painters call RecordHitTestData, that's
why the "svgline" test case in the compositor-touch-hit-rects.html is
failing.

This CL adds a RecordHitTestData API in SVGShapePainter. It will fix
the failing test. However, any SVG related painters should have such an
API. It will be addressed in follow-up CLs together with new test cases.

Bug: 853912
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I7b8aa3869d8703a38a4f3265e4f1fc2744b6bd6a
Reviewed-on: https://chromium-review.googlesource.com/1151616
Commit-Queue: Xida Chen <xidachen@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578747}

R=csharp

Bug: 830892
Change-Id: I8e4af3d60d35a4b4af24267bb9967bca4ac5b5cc
Reviewed-on: https://chromium-review.googlesource.com/1150808
Commit-Queue: Joe Mason <joenotcharles@chromium.org>
Reviewed-by: Chris Sharp <csharp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578746}

Changelist:
https://chromium.googlesource.com/external/fontconfig/+log/d1f48f11d5dffa1d954a1b0abe44ce9e4bfc3709..1451f829e750926cec27855eded71c24ac7ac7c6

BUG=427584
TBR=dnicoara

Change-Id: Ic23281b056fa08e8d4a75613fdf4a36aae5838e8
Reviewed-on: https://chromium-review.googlesource.com/1153436Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578745}

This CL makes MD select's dropdown arrow more similarly sized with other
icons. It also makes the dropdown arrow not scale with font-size, since
other icons don't do that either.

Bug: 867185
Change-Id: Iedcce94c126fecd0284c1dc3d2485d3048039992
Reviewed-on: https://chromium-review.googlesource.com/1150564Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578744}

Metrics of anchor elements that have the same href (target link)
are merged to a sigle one.

Bug: 850624
Change-Id: Iafdc8025960528bc57d641dfe470f167bf201d0f
Reviewed-on: https://chromium-review.googlesource.com/1152089
Commit-Queue: Lu Chen <chelu@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578743}

This changes the rtl flip calculation. Before it was using the wrong
line_offset, and the static position of abs-pos were getting shifted
with the text-alignment (which shouldn't be occuring).

This using the appropriate line-offset, and corrects the rtl flip
calculation.

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I93a45e196682ee1a940fe81b4c43f67e19fe6bb3
Bug: 636993
Reviewed-on: https://chromium-review.googlesource.com/1153219Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578742}

Enables monochrome_public_test_ar_apk on Oreo Phone Tester and adds in
the necessary changes to download ArCore and include it in the isolate.

Bug: 851020
Change-Id: Id98519c43acc3ec4ee203c78e04457d8cd6f92ad
Reviewed-on: https://chromium-review.googlesource.com/1136028Reviewed-by: Ian Vollick <vollick@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578741}

This CL makes NetworkContexts create CookieStores and ChannelIDStores in
the hybrid URLRequestContext creation path, where the embedder starts
configuring a URLRequestContextBuilder, and the NetworkContext finishes
configuring it.

The reduces redundant code, lets us test the new path in production
before we ship the network service, and will allow Isolated App
URLRequestContexts to need less code when they're updated to use the
hybrid configuration path (Which I plan to do in a followup CL).

The NetworkContext constructor that takes an already-initialized
URLRequestContext is not modified in this CL.

Bug: 789644
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Ibf40ae6497e7be06b0a666bc664ea943e145cae9
Reviewed-on: https://chromium-review.googlesource.com/1152083Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Reviewed-by: Clark DuVall <cduvall@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578740}

Based on a try job in the linked bug, it looks like this story
is now passing.

TBR=sullivan@chromium.org

Bug: 736147
Change-Id: Icb61a9302213f1351f5bcf86ca2e1d50ab2713e5
Reviewed-on: https://chromium-review.googlesource.com/1143452
Commit-Queue: Charlie Andrews <charliea@chromium.org>
Reviewed-by: Charlie Andrews <charliea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578739}

Remove unused chrome_cleaner::RegistryOverrideManager. All tests now use
registry_util::RegistryOverrideManager.

R=csharp

Bug: 830892
Change-Id: Ife5ed1075176436e470bac0aeb02ac271409aea5
Reviewed-on: https://chromium-review.googlesource.com/1150681Reviewed-by: Chris Sharp <csharp@chromium.org>
Commit-Queue: Joe Mason <joenotcharles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578738}

Change-Id: I1e772fc31ede9a85d6cea1726c3c7fa9d3cd34ca
Reviewed-on: https://chromium-review.googlesource.com/1147741Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Peter Kvitek <kvitekp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578737}

Make sure that the magic value can be cast to a char properly.

BUG=724399,b:70905156

Review URL: https://chromiumcodereview.appspot.com/10541122

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141814 0039d316-1c4b-4281-b951-d872f2087c98
(cherry picked from commit b9ccf65a)
Signed-off-by: Gabriel Marin <gmx@chromium.org>

Change-Id: I31162aefe53624f4bc61a6b2bc6fe83f9df5ff68
Reviewed-on: https://chromium-review.googlesource.com/1130779Reviewed-by: Will Harris <wfh@chromium.org>
Commit-Queue: Gabriel Marin <gmx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578736}

Since zdnet_patholocial is failing on Nexus6 Webview and it has recently
been refreshed, remove it. The rest of the old pages in
pathological_mobile_sites will be removed next week (following protocol
of removing old pages a week after new ones are added).

Bug:868295
Change-Id: I875e54a498ff23a29569ec878a74f63a0ed44f75

NOTRY=true  # CQ flake

Change-Id: I875e54a498ff23a29569ec878a74f63a0ed44f75
Reviewed-on: https://chromium-review.googlesource.com/1153087
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#578735}

R=dcheng@chromium.org
TBR=jochen@chromium.org

Currently layout test code is split over:

- content/shell/test_runner/ (separate component)
Has renderer-side code, is allowed to use content/renderer/, does not
use content/shell/renderer/.

- content/shell/renderer/layout_test/ (part of content_shell_lib)
Has renderer-side code, makes light use of content/shell/renderer/, but is
not able to use content/renderer/.

- content/shell/browser/layout_test/ (part of content_shell_lib)
Has browser-side code, makes heavy use of content/shell/browser/, but is
not able to use content/browser/.

- content/public/test/layouttest_support.h
Header for access to content/renderer/ things and content/browser/
things. Used by content/shell/renderer/layout_test/ and
content/shell/browser/layout_test/.

- content/test/layouttest_support.cc
Impls for access to content/renderer/ and content/browser/ things.


This patch aims to
1. Combine the test_runner/ and shell/renderer/layout_test/ pieces of
code so they don't need to use indirections to interact. Their
separation is a legacy of test_runner/ being implemented inside blink
(WebKit) in the past.
2. Move layouttest_support.h out of content/public/ and the .cc out of
content/test/ to a layout_test-specific code location.

To do (1), test_runner/* moves to shell/renderer/layout_test/*. This
is fairly straight forward. We remove the TEST_RUNNER_EXPORT macro
as they are now part of a static library. They are left in the
test_runner namespace at the moment.

To do (2), we move layouttest_support.(cc|h) to
shell/renderer/layout_test/. There are 3 methods in the file that
are called from shell/browser/layout_test/ and use content/browser
so we split those out to shell/browser/layout_test/.

However this causes a problem that content_shell_lib will depend
on content/{browser,child,renderer}/ via the layouttest_support.cc
file. To avoid this, we
- Move content/shell/renderer/layout_test/* into a separate build
target called //content/shell:layout_test_renderer_lib and we
give it visibility to content/renderer/ and content/child/.
- Move content/shell/browser/layout_test/layouttest_support.* into
a separate build target called
//content/shell:browser_layout_test_support_lib. We don't move all
of content/shell/browser/layout_test/* because of heavy interaction
between it and its parent directory at this time.
- For a few files used by the shell/renderer/ (and shell/) and
shell/renderer/layout_test/ directories, we move them out to a
shared library as well, called
//content/shell:content_shell_renderer_common_lib.
- And for the common/layout_test/layout_test_switches.cc files,
which are used in both, but we'd like to not leak out of
content_shell_lib since they are part of .../layout_test/, we
make a non-public dep on //content/shell:content_shell_common_test_lib

Ideally, I think we have a separate library for
//content/shell/browser/layout_test
//content/shell/common/layout_test
//content/shell/renderer/layout_test

But we need better indirection between the content_shell_lib and
the .../layout_test/ code in order to do that. Once it was so, we
would be closer to making it possible to have a content_shell build
target that does not include any test code (and thus truly only uses
the public APIs), and a separate content_shell-like build target
that includes the layout test code.

Bug: 866140
Change-Id: Ia39f7385711bdb610948a07fd473ad9b346b82ae
Reviewed-on: https://chromium-review.googlesource.com/1145644Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578734}

The tests check that cookies are persisted (Or not) for each of the
NetworkContexts in Chrome.

Also, fix comments in NetworkContextConfigurationBrowserTests. In
particular, the System and SafeBrowsing NetworkContexts do support
cookies, they just don't support some configuration options being
tested.

Bug: 868414
Change-Id: I8542a1ff7685efcf6588b29dcb5058dd06f1ceeb
Reviewed-on: https://chromium-review.googlesource.com/1153141Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578733}

This change makes the share entry field in the Add SmbShare dialog
a cr-searchable-drop-down that is populated with shares discovered
on the network as they are found.

Test=verified locally

Bug: chromium:757625
Change-Id: I6fdd74bc2c6f1efaea190bfc3d93eef046de7334
Reviewed-on: https://chromium-review.googlesource.com/1152211
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578732}

Improve the semantic intersection logic in URLPatternSet to utilize
URLPattern::CreateIntersection(). This allows callers to create an
intersection between two sets that will include patterns that were
not explicitly in either set, such as constructing the pattern
`http://chromium.org/*` from `http://*/*` and `*://chromium.org/*`.

Since not all callers may want this behavior, and in order to
introduce three separately named Create*Intersection methods in
URLPatternSet, add an enum, IntersectionBehavior, for callers to
specify the type of intersection behavior to use. This includes
string comparison (STL-set-style intersection), patterns explicitly
contained by both sets (the old semantic intersection), and detailed
(the new and improved semantic intersection).

Add unit tests for the same.

Bug: 867549

Change-Id: Ic80bec8c8c8bbac188efcf2862d92582379c5a7c
Reviewed-on: https://chromium-review.googlesource.com/1150919
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578731}

The GrShaderCache currently assumes that it can't be populated with an
entry having the same key twice. This is incorrect in 2 scenarios.

1) If skia fails to link the cached binary, it will re-generate and
store a new copy.
2) If skia uses a shader before it is loaded off the disk cache, we will
find an existing entry in the memory cache when the disk cache entry is
being populated.

The above scenarios can result in errors in the internal accounting for
memory used. Fix them.

R=ericrk@chromium.org

Bug: 868121
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ifd4c1e872379b54d7c659d62ff6af09eeaad2b46
Reviewed-on: https://chromium-review.googlesource.com/1152552
Commit-Queue: Khushal <khushalsagar@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578730}

This CL adds some includes in download_db.h.

TBR=drtrainor@chromium.org,qinmin@chromium.org

Bug: 842245
Change-Id: I34fcfcf24e933d0be14f76705a65108c975e47e0
Reviewed-on: https://chromium-review.googlesource.com/1153402Reviewed-by: Xing Liu <xingliu@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578729}

This CL introduces the onActionIgnored event on the web request API which is
fired when an extension's proposed modification to a network request is ignored.
This happens in case of conflicts with other extensions. This should allow the
extensions to address conflicts as they like.

Also, we no longer notify the user in case of conflicts between extensions.

BUG=111700

Change-Id: I3e96740aee6b79b0823545bf17b4a50bbc8758aa
Reviewed-on: https://chromium-review.googlesource.com/1150009
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578728}

The crash keys are named "unsigned-modules-*" where * is a number from
0 to 9.

This will allow us to assess which accessibility software doesn't sign
all of their modules.

Bug: 846953
Change-Id: Iea0aabc1694972120c7ef48327c0b982092ed179
Reviewed-on: https://chromium-review.googlesource.com/1148990
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578727}