GitLab

On Linux, we have keys with keycode=VKEY_UNKNOWN, for example, ISO_LEVEL3_LATCH key.  We have to emit keydown/up events appropriately even if keycode=VKEY_UNKNOWN.

Just FYI: Firefox also fires keyevents with keycode=0, so the behavior will be compatible.  Compared to IE and Chrome on Windows, it's still compatible because there is no such key as ISO_LEVEL3_LATCH, etc. on Windows.

BUG=402320
TEST=Done manually.

Review URL: https://codereview.chromium.org/665863002

Cr-Commit-Position: refs/heads/master@{#300438}

BUG=425034

Review URL: https://codereview.chromium.org/669593002

Cr-Commit-Position: refs/heads/master@{#300437}

Depends on https://codereview.chromium.org/474013004.

BUG=415074

Review URL: https://codereview.chromium.org/577943002

Cr-Commit-Position: refs/heads/master@{#300436}

Currently when pdf is scaled to fit to page mode, both page down and
page up keys do not move pdf by page size. This is because both
the keys are not handled in HandleInputEvent().

This patch updates HandleInputEvent() to factor in key codes for
page up and page down to move pdf by page size in fit to page mode.
Similar to left and right arrow keys.

BUG=390599

Review URL: https://codereview.chromium.org/573523002

Cr-Commit-Position: refs/heads/master@{#300435}

Oooh. I am stupid, and I have no idea how this compiled. :)

BUG=420994
TBR=marja@chromium.org

Review URL: https://codereview.chromium.org/660473003

Cr-Commit-Position: refs/heads/master@{#300434}

BUG=339101

Review URL: https://codereview.chromium.org/637243004

Cr-Commit-Position: refs/heads/master@{#300433}

This is mostly to fix MSVC warnings about possible value truncation.

BUG=81439
TEST=none

Review URL: https://codereview.chromium.org/659943004

Cr-Commit-Position: refs/heads/master@{#300432}

BUG=397019

Review URL: https://codereview.chromium.org/658393003

Cr-Commit-Position: refs/heads/master@{#300431}

This bug is introduced by https://codereview.chromium.org/647953003.
The error status must be passed to script_cache_map.
It will be checked in ServiceWorkerRegisterJob::OnStartWorkerFinished() and use to handle the error in JS.

BUG=425430
TBR=dmurph

Review URL: https://codereview.chromium.org/663293004

Cr-Commit-Position: refs/heads/master@{#300430}

BUG=397019

Review URL: https://codereview.chromium.org/647083003

Cr-Commit-Position: refs/heads/master@{#300429}

BUG=404355

Review URL: https://codereview.chromium.org/661423002

Cr-Commit-Position: refs/heads/master@{#300428}

This feature is in active development.

BUG=224781

Review URL: https://codereview.chromium.org/671533003

Cr-Commit-Position: refs/heads/master@{#300427}

In continuation of the CL https://codereview.chromium.org/589113002/
this CL removes deprecated class WebContentsObserverAndroid and
cleans up existing usage of this class where ever it is occured.

This patch will be landed when external repositories has renamed
WebContentsObserverAndroid to WebContentsObserver

BUG=396118

Review URL: https://codereview.chromium.org/650333003

Cr-Commit-Position: refs/heads/master@{#300426}

BUG=chromedriver:946
TBR=stgao@chromium.org

Review URL: https://codereview.chromium.org/667823003

Cr-Commit-Position: refs/heads/master@{#300425}

In the current implementation, the helper function DoMakePathAbsolute
may rewrite the input even in the case of failure,
which makes the warning log less readable.

BUG=none
TEST=./chrome --app --app-id=someapp --enable-logging=stderr non/existing/path

Review URL: https://codereview.chromium.org/665053002

Cr-Commit-Position: refs/heads/master@{#300424}

The CL does the following things:

1. Add GesturePropertyProvider which parses xorg-conf files under
/etc/gesture/ upon chrome starts and sets the property values according
to the device touchpad/mouse type and the file content.

2. Provides GesturesPropProvider APIs so that libgesture can expose
its property values and allow Chrome to access it.

Contributed by sheckylin@chromium.org

BUG=400022
TEST=link_freon ChromeOS build
put appropriate xorg-conf files under /etc/gesture
restart chrome and check that:
1. the property values get loaded by manually logging.
2. the touchpad gesture is now smoother than before.

Review URL: https://codereview.chromium.org/545063006

Cr-Commit-Position: refs/heads/master@{#300423}

Previously, the Service class was responsible for saving and restoring state,
as well as managing file systems. Testing it became problematic.

This patch separates it into two classes Service and Registry, which can
be both tested separately.

TBR=pam@chromium.org
TEST=unit_tests: *FileSystemProvider*Registry*
BUG=248427

Review URL: https://codereview.chromium.org/661393002

Cr-Commit-Position: refs/heads/master@{#300422}

* We've moved application_runner_chromium.
* None of the header files should include .../cpp/utility (in
  particular, use RunLoop), since the implementations are meant to be
  replaceable (e.g., by a "Chromium" implementation).
* Allow the implementation of ApplicationRunner to use RunLoop. (We
  could allow it for everything in .../cpp/application/lib, but none of
  the other things need RunLoop, hence don't need to be replaced.)

R=jamesr@chromium.org

Review URL: https://codereview.chromium.org/665223002

Cr-Commit-Position: refs/heads/master@{#300421}

Using the tile-size for the tile-grid-size isn't effective, since
these have different scales etc.

This patch adds a new setting such that we can start to tune this
independantly of other settings.

BUG=365877

Review URL: https://codereview.chromium.org/666573002

Cr-Commit-Position: refs/heads/master@{#300420}

BUG=406995
TBR=benwells@chromium.org
TEST=run browser_test --gtest_filter=*FileManager*

Review URL: https://codereview.chromium.org/657253004

Cr-Commit-Position: refs/heads/master@{#300419}

BUG=172188

Review URL: https://codereview.chromium.org/662493002

Cr-Commit-Position: refs/heads/master@{#300418}

R=thestig@chromium.org
BUG=423134

Review URL: https://codereview.chromium.org/664743003

Cr-Commit-Position: refs/heads/master@{#300417}

Cr-Commit-Position: refs/heads/master@{#300416}

Tests currently do not pass because the 'resources_total_size_bytes' is not populated in the database tests, as I moved this population to the service_worker_storage class. Waiting for guidance on the best place to populate this before modifying too many tests.

BUG=

Review URL: https://codereview.chromium.org/647953003

Cr-Commit-Position: refs/heads/master@{#300415}

We need this value to decide whether the image should be tainted or not.

1 blink: https://codereview.chromium.org/653373002
2 chromium: https://codereview.chromium.org/659573006

BUG=424473

Review URL: https://codereview.chromium.org/659573006

Cr-Commit-Position: refs/heads/master@{#300414}

Minor style nit, but base_bubble_controller.h exposes ObjC APIs and
should be included via #import, not #include.

BUG=none

Review URL: https://codereview.chromium.org/665063003

Cr-Commit-Position: refs/heads/master@{#300413}

This is mostly to fix MSVC warnings about possible value truncation.

BUG=81439
TEST=none

Review URL: https://codereview.chromium.org/660173002

Cr-Commit-Position: refs/heads/master@{#300412}

According to latest editor's draft http://rawgit.com/w3c/html-api-map/master/index.html
and http://www.w3.org/WAI/PF/aria-implementation/

It should be exposed as below when header is not contained by article or section elements

MSAA+IA2
Role: IA2_ROLE_HEADER
Object attributes: xml-roles:banner

AX
AXRole: AXGroup
AXSubrole: AXLandmarkBanner
AXRoleDescription: "banner"

BUG=282262

Review URL: https://codereview.chromium.org/656293002

Cr-Commit-Position: refs/heads/master@{#300411}

BUG=424254

Review URL: https://codereview.chromium.org/665133004

Cr-Commit-Position: refs/heads/master@{#300410}

This turns Chrome Shell's AndroidManifest.xml into a template which gets
processed at build time to produce the final AndroidManifest.xml that's
used to build the APK.

BUG=163751
NOTRY=true

Review URL: https://codereview.chromium.org/657443002

Cr-Commit-Position: refs/heads/master@{#300409}

R=jamesr@chromium.org

Review URL: https://codereview.chromium.org/663023006

Cr-Commit-Position: refs/heads/master@{#300408}

Fix some lint errors along the way.

Review URL: https://codereview.chromium.org/632103004

Cr-Commit-Position: refs/heads/master@{#300407}

Pages controlled by ServiceWorkers should not participate in AppCaching. The manifest attribute of pages in the scope of a ServiceWorker are ignored, and existing AppCaches are ignored for navigations into a ServiceWorker's scope.

BUG=410665

Review URL: https://codereview.chromium.org/625433002

Cr-Commit-Position: refs/heads/master@{#300406}

BUG=419287

Committed: https://crrev.com/f6916df879bf23bacf994880359c980f4249e324
Cr-Commit-Position: refs/heads/master@{#299918}

Review URL: https://codereview.chromium.org/633273002

Cr-Commit-Position: refs/heads/master@{#300405}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/660cc59..c7a9281

TBR=dstockwell@chromium.org,aboxhall@chromium.org

Review URL: https://codereview.chromium.org/665163004

Cr-Commit-Position: refs/heads/master@{#300404}

Speculatively re-enabling ServiceWorkerBrowserTest.Reload and ServiceWorkerBlackBoxBrowserTest.Registration

This doesn't reproduce neither locally nor on trybots after
running all night, and old test logs are inaccessible.
I'm going to re-enable these and see if they're still flaking.

BUG=387045,393486

Review URL: https://codereview.chromium.org/652743012

Cr-Commit-Position: refs/heads/master@{#300403}

Demoting a warning message to DLOG(INFO) due to high frequency.  Will
follow-up with a different CL to log the actual "unusual, we don't think
this should really happen" case at the WARNING level.

Changed the level of a warning message to dlog(info)

Merge internal change: 78113178
https://codereview.chromium.org/665883003/

Fixes two div by zero bugs in QUIC's BBR pacing code that caused server
crashes.

Fixes are in the internal source code.

Merge internal change: 78017204
https://codereview.chromium.org/670533004/

Simplify QuicUnackedPacketMap to expose AddSentPacket, instead of
AddPacket, OnRetransmittedPacket, and SetSent.

Merge internal change: 77986449
https://codereview.chromium.org/640853005/

Making a whole host of QUIC framing errors pre-decryption non-fatal.  If
someone is sending random junk prefixed with a real user's CID it should
not disrupt the connection.

making the QUIC connection resilliant to injected traffic

Merge internal change: 77961885
https://codereview.chromium.org/667573006/

Added helper methods to get/set previous_cached_network_params_.

Merging the following internal change:

Add varz to track accuracy of QUIC bandwidth predictions.

Plan is to use this data to calculate possible impact of using bandwidth
predictions, get an idea of how accurate our predictions are. Intended
varz output is something like:

.../spdy4_over_quic/stk_predicted_bw_accuracy_within_5_mins
.../spdy4_over_quic/stk_predicted_bw_accuracy_within_50_mins
.../spdy4_over_quic/stk_predicted_bw_accuracy_within_500_mins
.../spdy4_over_quic/stk_predicted_bw_accuracy_any_time
.../spdy4_over_quic/max_stk_predicted_bw_accuracy_within_5_mins
.../spdy4_over_quic/max_stk_predicted_bw_accuracy_within_50_mins
.../spdy4_over_quic/max_stk_predicted_bw_accuracy_within_500_mins
.../spdy4_over_quic/max_stk_predicted_bw_accuracy_any_time

Each of these is a map of 20 buckets, covering 10% chunks of the
[0%, 200%] range. For example, a bandwidth estimate from 25 minutes ago,
that turns out to be 125% of the observed bandwidth, will result in the
stk_predicted_bw_accuracy_within_50_mins_histogram{13} bucket being
incremented.

Merge internal change: 77877600
https://codereview.chromium.org/666003002/

Fix test which times out when FLAGS_quic_allow_more_open_streams is
true. Needed to update test to open additional streams to trigger server
close. Internal version of the test does something similar already.

Merge internal change: 77868811
https://codereview.chromium.org/661423005/

Restoring tests incorrectly removed in cr/77591875

Merge internal change: 77791119

Commented out headers_stream->HasBufferedData() call to fix flaky
HandshakeUnblocksFlowControlBlockedHeadersStream unit test.

BUG=423586
https://codereview.chromium.org/662233003/

Replace calls to set.count() with ContainsKey in QUIC.

Merge internal change: 77762867
https://codereview.chromium.org/665823004/

Allow QUIC's BBR TCP sender to pace based on min rtt and add an explicit
PacingRate() method to SendAlgorithmInterface for BBR.

Merge internal change: 77668996
https://codereview.chromium.org/664923003/

Removing QUIC_VERSION_18.
This also lets us remove the code for
 -hard-coded session limits, since those apply to v19 or greater
 -stats tracking % sessions with no flow control
 -the bulk of AdjustErrorForVersion since there's no outstanding
  versions with new errors

 Removing QUIC_VERSION_18.  Not flag protected.

Merge internal change: 77603158
https://codereview.chromium.org/663013003/

Change QUIC's pacing granularity from 5ms to 1ms to match the kernel's
default granularity.

Merge internal change: 77587738
https://codereview.chromium.org/665083004/

R=rch@chromium.org

Review URL: https://codereview.chromium.org/667763003

Cr-Commit-Position: refs/heads/master@{#300402}

BUG=422730

Review URL: https://codereview.chromium.org/665563002

Cr-Commit-Position: refs/heads/master@{#300401}

BUG=423645

Review URL: https://codereview.chromium.org/659883004

Cr-Commit-Position: refs/heads/master@{#300400}

In chrome OS, the file chooser dialog box may return paths that does not point to a native file. The CL lets FileSelectorHelper handle for the non-native paths and generate FileChooserFileInfo that refers non-native files.

BUG=126902
TEST=manually test to upload drive/local files

Review URL: https://codereview.chromium.org/663473002

Cr-Commit-Position: refs/heads/master@{#300399}