- 20 Feb, 2019 40 commits
-
-
Kent Tamura authored
crrev.com/569501 removed NEVER_INLINE macro from Blink. crrev.com/585239 added it again as WTF_NOINLINE. This CL has no behavior changes. Change-Id: I31226e874101f7f51b66a85a4e9651ecc984ed6c Reviewed-on: https://chromium-review.googlesource.com/c/1478326 Auto-Submit: Kent Tamura <tkent@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#633703}
-
Elly Fong-Jones authored
This change removes: disable-new-korean-ime enable-emoji-handwriting-voice-on-ime-menu opt-in-ime-menu and removes their backing features. It adds some TODOs for shuchen@ for places where the exact cleanup to be done was not clear to me. Bug: None Change-Id: I915d4b220a5e2a34d0bd61fc0c26d6623166c16f Reviewed-on: https://chromium-review.googlesource.com/c/1476985 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Shu Chen <shuchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#633702}
-
Nico Weber authored
- Require semicolon after DECLARE_WEAK_IDENTIFIER_MAP - Remove semicolons after DEFINE_WEAK_IDENTIFIER_MAP - Remove semicolons after DEFINE_WEB_NODE_TYPE_CASTS - Remove semicolon after 1 of 105 instances of DEFINE_NODE_FACTORY - Remove semicolon after 1 of 10 instances of DEFINE_ELEMENT_FACTORY_WITH_TAGNAME - Rename DECLARE_EAGER_FINALIZATION_OPERATOR_NEW to DEFINE_INLINE_EAGER_FINALIZATION_OPERATOR_NEW and remove semicolons after it (renaming because DECLARE_ macros for functions usually require a semicolon and DEFINE_ macros for functions are not followed by semicolons, so this makes things a bit more consistent with other macros). Bug: 926235 Change-Id: I8afeec02aa604d1315e740de161845850950c776 Reviewed-on: https://chromium-review.googlesource.com/c/1478495 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
-
Tim Volodine authored
Rebaseline some interfaces and properties that are exposed in Chrome and are also expected/OK to be exposed in Android WebView. In particular the following interfaces/properties: BaseAudioContext - removed methods CSSStyleSheet - methods CanvasRenderingContext2D.getContextAttributes Clipboard DOMMatrixReadOnly.scaleNonUniform Document - getters/setters Element - getters/setters GamepadButton.touched HTMLElement - getters/setters HTMLIFrameElement - getters/setters HTMLLinkElement - getters/setters HTMLMediaElement - getters/setters IDBFactory.databases InputEvent IntersectionObserver IntersectionObserverEntry Lock LockManager MediaStreamTrack - getter/setter NavigationPreloadManager Navigator - getters OffscreenCanvas OffscreenCanvasRenderingContext2D PannerNode PerformanceObserver.supportedEntryTypes PointerEvent RTCDTMFSender RTCDTMFToneChangeEvent RTCDataChannel RTCDataChannelEvent RTCError RTCErrorEvent RTCIceCandidate - getters RTCPeerConnection RTCPeerConnectionIceEvent RTCRtpReceiver RTCRtpSender RTCRtpTransceiver RTCStatsReport RTCTrackEvent ReadableStream.toStringTag ReportingObserver ResizeObserver ResizeObserverEntry SVGElement - getters/setters SVGFEBlendElement - attributes ServiceWorkerContainer.startMessages ShadowRoot - getters/setters SourceBuffer.changeType StaticRange StereoPannerNode StylePropertyMap StylePropertyMapReadOnly TextDecoderStream TextEncoder.encodeInto TextEncoderStream URL.toJSON VisualViewport WebGL2RenderingContext WebGLQuery WebGLSampler WebGLSync WebGLTransformFeedback WebGLVertexArrayObject webkitRTCPeerConnection - getters/setters webkitSpeechGrammar webkitSpeechGrammarList webkitSpeechRecognition webkitSpeechRecognitionError webkitSpeechRecognitionEvent webkitURL.toJSON window.onselectionchange window.onselectionstart window.visualViewport BUG=867450 Change-Id: I953bcaa298b529f6320a010576eb8f24ff960d6a Reviewed-on: https://chromium-review.googlesource.com/c/1475446Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#633700}
-
Wez authored
Persistent storage is now isolated between components, with a deprecated option for global persistent storage which we'll continue to use for the test sandbox in the short-term. Bug: 931860 Change-Id: I584c00b7273b863fad071692a9963f39c1ac70db Reviewed-on: https://chromium-review.googlesource.com/c/1471354Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#633699}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 99ac5ffb. With Chromium commits locally applied on WPT: 14c11107 "Implement `Sec-CH-Lang`" af3b056c "[WPT] [wasm] Add JS-API tests for wasm threads" df760ab0 "Don't skip past auto-height flexboxes in quirks mode." cd40220a "Fix as=fetch preload where preload is used before response arrives" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I13245c2586352e3d85dce8b975f2dc15fb410950 Reviewed-on: https://chromium-review.googlesource.com/c/1477395Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#633698}
-
Nico Weber authored
Bug: 926235 Change-Id: I63f4c71b020e9e1dea0cab3dd5d7a21b8db872a1 Reviewed-on: https://chromium-review.googlesource.com/c/1475198 Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#633697}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0e7d41f09a48..5305896e52a1 git log 0e7d41f09a48..5305896e52a1 --date=short --no-merges --format='%ad %ae %s' 2019-02-20 treehugger-gerrit@google.com Merge "Protect SharedRingbuffer against concurrent manipulation." Created with: gclient setdep -r src/third_party/perfetto@5305896e52a1 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I36ca9996b6048348be90f4c4f20b8eeb20426f01 Reviewed-on: https://chromium-review.googlesource.com/c/1478467Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#633696}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/3499d3ee975e..f20f5b94939e git log 3499d3ee975e..f20f5b94939e --date=short --no-merges --format='%ad %ae %s' 2019-02-20 cwallez@chromium.org WebGPU error handling 5: Move CmdBufBuilder logic to CmdEncoder Created with: gclient setdep -r src/third_party/dawn@f20f5b94939e The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I3e67a731df13b67f16c4988e097f201224382402 Reviewed-on: https://chromium-review.googlesource.com/c/1478466Reviewed-by:
-
Rayan Kanso authored
This will delete all the logged events for the background service. The upstream CL this is based on adds the ability to clear user data across all registrations. This CL also exposes a `ShouldLogEvent` function for clients to know whether they should create an event proto or not. Bug: 927726 Change-Id: I68f5419251ee29ecc130d0df712da556109e2860 Reviewed-on: https://chromium-review.googlesource.com/c/1470703 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#633694}
-
Andreea Costinas authored
This CL enables sharing EAP TLS networks with device-wide server CA and client certificates. This means EAP TLS will be available at the sign-in screen. Bug: 904362 Test: browser_tests Change-Id: I549b94bfd95067891cdee85e649110e98c7fe0c9 Reviewed-on: https://chromium-review.googlesource.com/c/1461037 Commit-Queue: Andreea-Elena Costinas <acostinas@google.com> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
-
Stepan Khapugin authored
Shortcuts need to be centered. This is achieved by insetting the cells with a computed amount. This computation used to happen in -viewWillAppear:, but in some cases the containing table view cell is not yet properly sized. So postpone this insetting to -viewDidAppear: Bug: 931210 Change-Id: Ic66a273d5337a442ccb57fda30cf0d8c370052c3 Reviewed-on: https://chromium-review.googlesource.com/c/1475751 Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#633692}
-
Felipe Cerqueira authored
When trying to access a blocked webpage, the child user can press Ctrl+S and save the error page (the one with the "Ask your Parent" message). If the child chooses to save the page as HTML-only (.html), the downloaded source code is the one from the blocked page. The child can then open the page locally and see the blocked content. As a workaround, we are temporarily disabling the HTML-only download of the blocked page for supervised users. They can still save the page as MHTML, which works as expected. AFTER THIS CL Normal user (unaffected): https://screenshot.googleplex.com/kipKMUOKA6r Supervised user (normal page): https://screenshot.googleplex.com/r3hQ6E1edx3 Supervised user (blocked page): https://screenshot.googleplex.com/Jqba7rhiOf2 Bug: 928323 Change-Id: I7a82cfb9194a14070910716848228ddb1faeedff Reviewed-on: https://chromium-review.googlesource.com/c/1460876 Commit-Queue: Felipe Cerqueira <cerqueira@google.com> Reviewed-by:Carlos IL <carlosil@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#633691}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/0d4869c2b9c2..e82643fb9c64 git log 0d4869c2b9c2..e82643fb9c64 --date=short --no-merges --format='%ad %ae %s' 2019-02-20 alessiob@webrtc.org Fix FFT output size to avoid incorrect band energy computation 2019-02-20 nisse@webrtc.org Use a CopyOnWriteBuffer to back EncodedImage data Created with: gclient setdep -r src/third_party/webrtc@e82643fb9c64 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:931692 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Iecebc50291dafd11070dcfab85ad32098ddb65fc Reviewed-on: https://chromium-review.googlesource.com/c/1478464Reviewed-by:
-
Roger Tawa authored
Bug: 932569 Change-Id: Icbb227d1bc58bf2f0ef6e65398b46457e104d884 Reviewed-on: https://chromium-review.googlesource.com/c/1474829Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#633689}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I082f98ca59abd974b7224d7183db93c63e1ed4a7 Reviewed-on: https://chromium-review.googlesource.com/c/1478469Reviewed-by:
-
Andrew Moylan authored
Bug: none Test: none Change-Id: I49ff01795b47fe18acc9dd83721833802477f217 Reviewed-on: https://chromium-review.googlesource.com/c/1477555 Auto-Submit: Andrew Moylan <amoylan@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#633687}
-
Jérôme Lebel authored
Deselect cell after being tapped in GoogleServicesSettingsViewController. Bug: 914059 Change-Id: I75e7a5e3656a22110cd58b3afae2fdecfb93e0dc Reviewed-on: https://chromium-review.googlesource.com/c/1477900 Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1a4372f7e0e6..274ad0c9456b Created with: gclient setdep -r src-internal@274ad0c9456b The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I4c3fd64860280794161ece1ad4c833b82a0b0151 Reviewed-on: https://chromium-review.googlesource.com/c/1478465Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#633685}
-
Christian Dullweber authored
This reverts commit c0ddff72. Reason for revert: Findit identified this as introducing flakiness (crbug.com/933694) Original change's description: > [IntersectionObserver] Run algorithm in a post-lifecycle step > > This is the first of two patches to change the timing of the > IntersectionObserver algorithm. Currently, the algorithm is run > during lifecycle updates, after paint. All notifications are queued > up to be delivered later; PostTask is used to schedule the delivery. > > The main problem with this is that blink-internal consumers of > IntersectionObserver probably don't want their notifications to be > delayed, with the timing of delivery dependent on what's in the > task queue. It makes more sense for blink-internal consumers to get > their notifications synchronously; if they want to postpone some > until later, they can always PostTask from the notification handler. > Javascript IntersectionObservers will continue to schedule delivery > of notifications via PostTask. > > This CL moves the IntersectionObserver algorithm to run outside of > the lifecycle proper. Instead, it runs in a post-lifecycle step. > This is necessary because when blink-internal IntersectionObserver > customers begin receiving synchronous notifications, they may mutate > document state in a way that shouldn't happen in the middle of a > lifecycle update. > > Change-Id: I3fbcb97831776eee11564b36f1cfa933f5dfc712 > Reviewed-on: https://chromium-review.googlesource.com/c/1468807 > Reviewed-by: Stephen Chenney <schenney@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: enne <enne@chromium.org> > Reviewed-by: Stefan Zager <szager@chromium.org> > Reviewed-by: Aleks Totic <atotic@chromium.org> > Commit-Queue: Stefan Zager <szager@chromium.org> > Cr-Commit-Position: refs/heads/master@{#633462} TBR=kinuko@chromium.org,szager@chromium.org,chrishtr@chromium.org,enne@chromium.org,atotic@chromium.org,schenney@chromium.org Bug: 933694 Change-Id: I53a93958b3a3ad7ae8b24b8fb7b1a63f22283c3d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1475488Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#633684}
-
Marc Treib authored
instead of using the primary account from IdentityManager. For full-Sync users, this makes no difference. But for transport-only users, GetAccountInfoForPaymentsServer is the correct thing to do, since it also handles non-primary accounts. Bug: 864519 Change-Id: If61840fdf22a2e1d288e0dbf403d5fa2e5077651 Reviewed-on: https://chromium-review.googlesource.com/c/1477128Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#633683}
-
Marc Treib authored
Most places only need to include sync_service.h. This also resolves a bunch of IWYU issues (things that used to be transitively included via profile_sync_service.h). Bug: 924508 Change-Id: Ic3786f485b5530dcbacdb02a8c4cc8938291c971 Reviewed-on: https://chromium-review.googlesource.com/c/1477604Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#633682}
-
Maciej Pawlowski authored
PositionCache should be persistent and outlive NetworkLocationProvider, similarly to how LastPositionCache behaved. This lets us limit the number of API requests, since WifiData -> Geoposition mappings are stored longer. Also, LastPositionCache can now be merged with PositionCache. Bug: 672760 Change-Id: Ibd4c30c9a58dd26deb5f67448b5e2bac48d634fc Reviewed-on: https://chromium-review.googlesource.com/c/1273055 Commit-Queue: Maciej Pawlowski <mpawlowski@opera.com> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Auto-Submit: Maciej Pawlowski <mpawlowski@opera.com> Cr-Commit-Position: refs/heads/master@{#633681}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Id64b06dbf9bd21a2b2f29e1e1cddab9a47e53a37 Reviewed-on: https://chromium-review.googlesource.com/c/1478463Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 0a54725c. With Chromium commits locally applied on WPT: 14c11107 "Implement `Sec-CH-Lang`" af3b056c "[WPT] [wasm] Add JS-API tests for wasm threads" df760ab0 "Don't skip past auto-height flexboxes in quirks mode." cd40220a "Fix as=fetch preload where preload is used before response arrives" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: If47ccdde25e14bc70330b5fedffa0dc98f44ae47 Reviewed-on: https://chromium-review.googlesource.com/c/1478462Reviewed-by:
-
Corentin Wallez authored
This function call is currently a dummy for a 3-way patch between Chromium and Dawn but will soon contain code initializing a gtest environment to contain Dawn's end2end test global data. BUG=dawn:109 Change-Id: I0bc1608e5a2f62965ab4c82ee854317030f2bd18 Reviewed-on: https://chromium-review.googlesource.com/c/1474769Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#633678}
-
Ioana Pandele authored
Bug: 835234 Change-Id: I0e57b966c85a96df27ab1e0d69512b4b5c40515b Reviewed-on: https://chromium-review.googlesource.com/c/1474756 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#633677}
-
Michael Lippautz authored
Handlers on audio threads did hold alive their AudioBuffer via CrossThreadPersistent roots. Since the handlers are themselves refcounted and depend on liveness of an actual node this could create cycles when the garbage collectors also considered references through JavaScript. Instead of rooting the AudioBuffer object the handlers only need the data used for processing which can be copied (e.g. sampleRate) or held alive via SAB semantics. The approach around SABs and shared state avoids roots and potential reference cycles as well as the overhead that is involved when taking locks for those roots. Bug: 928781,843903 Change-Id: I108c154267080ce6b3e230a8804dd527a8b4d750 Reviewed-on: https://chromium-review.googlesource.com/c/1477233 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Reviewed-by:
Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#633676}
-
Marc Treib authored
...instead of in the local DB. For full-Sync users, the two DBs are identical anyway, so this is a no-op. But for Sync-transport-only users, using the server DB is the correct thing to do. Also note that another UpdateServerAddressMetadata call (from ConvertWalletAddressesToLocalProfiles) already uses the server DB. Bug: 864519 Change-Id: I67d8248fa59453b4bbbe63fb90d2ab46adc745ce Reviewed-on: https://chromium-review.googlesource.com/c/1474665Reviewed-by:
-
Mikel Astiz authored
The last remaining user of StopSyncResponse::kModelNoLongerReadyToSync, which was sessions sync, was recently migrated away in https://chromium-review.googlesource.com/c/1456087, leaving this codepath effecetively unused. In this patch, we remove support for it and in fact delete enum StopSyncResponse altogether. Bug: 863870 Change-Id: Id688367e14a174fd93119a29e41c71a5be7224b3 Reviewed-on: https://chromium-review.googlesource.com/c/1477896 Auto-Submit: Mikel Astiz <mastiz@chromium.org> Commit-Queue: Martin Šrámek <msramek@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#633674}
-
Alex Ilin authored
ReachedCodeProfiler exports only small amount of functions that aren't testable. This CL extracts the logic for recording reached addresses in a bitset in a separate, testable ReachedAddressesBitset class. Bug: 916263 Change-Id: Ie5111c1e2855a4e1a5277dbbf256e71a8ad76067 Reviewed-on: https://chromium-review.googlesource.com/c/1475443Reviewed-by:
Egor Pasko <pasko@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Auto-Submit: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#633673}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/079bdfcee2d4..1a4372f7e0e6 Created with: gclient setdep -r src-internal@1a4372f7e0e6 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I80c823e91145ba60ccda8a5e8623debdaa47de17 Reviewed-on: https://chromium-review.googlesource.com/c/1478687Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/599d59237abf..0d4869c2b9c2 git log 599d59237abf..0d4869c2b9c2 --date=short --no-merges --format='%ad %ae %s' 2019-02-20 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision d7238823..4b3282a5 (633435:633587) 2019-02-20 amithi@webrtc.org Refactoring RtpSenderInternal to share implementation for Audio & Video. 2019-02-20 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 086bdb74..d7238823 (633288:633435) 2019-02-19 amithi@webrtc.org Rejected simulcast layers will no longer appear in GetParameters(). 2019-02-19 braveyao@webrtc.org desktopCaptuer: exempt to overlapping between hidden taskbar and maximized target 2019-02-19 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 55c117dd..086bdb74 (633171:633288) 2019-02-19 eladalon@webrtc.org Improve CPU utilization when encoding VP8 with two temporal layers Created with: gclient setdep -r src/third_party/webrtc@0d4869c2b9c2 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:None,chromium:None,chromium:838062,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ib70992d1f8304c0aca61f48e2b30b146650be17e Reviewed-on: https://chromium-review.googlesource.com/c/1478119Reviewed-by:
-
Lowell Manners authored
When using GetSafeWeakWrapper, Detach() is called automatically, so tests don't need to call it themselves. Bug: 924960 Change-Id: I67a454c5908c11c1674f001fef994fe3bbe2dd7a Reviewed-on: https://chromium-review.googlesource.com/c/1475755Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Lowell Manners <lowell@chromium.org> Cr-Commit-Position: refs/heads/master@{#633670}
-
Yi Su authored
This CL removes the "save password" section(header and switch item) in PasswordsTableViewController before the search bar is presented and adds them back before the search bar is dismissed. Bug: 894791 Change-Id: I1acb84de590157a57a8d0a95b6ac43b1641a16b1 Reviewed-on: https://chromium-review.googlesource.com/c/1425612Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
-
Marc Treib authored
This CL introduces common constants for the email address of the primary (aka Sync feature) / non-primary (aka Sync transport) account in use. Previously, many tests contained their own constants, and they were sometimes inconsistent (e.g. between IdentityManager and SyncService). Bug: 864519 Change-Id: I36f2ad9598c905cb7ab8d248d39365746d97fcac Reviewed-on: https://chromium-review.googlesource.com/c/1477258Reviewed-by:
-
Jordan Demeulenaere authored
This CL sets the header minimum height to 56dp instead of fixing its height. This ensures that the status message is correctly shown for users that have selected a large font size in the Accessibility settings. - before: https://screenshot.googleplex.com/uYUfxY0w3GU.png - after: https://screenshot.googleplex.com/45gvqr8XTUY.png Screenshots: Change-Id: Icedc497dd619d2268b9ee38b5dc5354f9f89a9eb Reviewed-on: https://chromium-review.googlesource.com/c/1477702Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Cr-Commit-Position: refs/heads/master@{#633667}
-
Rakina Zata Amni authored
When we attach shadow trees with non-empty |adoptedStyleSheets|, we should update the active style sheet collection for that tree scope. Otherwise, if there are no other stylesheets for that tree scope, we will never mark the tree scope as dirty and thus have incorrect style calculation for that tree scope. Bug: 933578 Change-Id: Id7229b05440a51ac8e5d55570ed030b8cfb707d2 Reviewed-on: https://chromium-review.googlesource.com/c/1477623Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#633666}
-
Gyuyoung Kim authored
As a step to apply the OnionSoup project, this CL starts to remove all uses of Blink's WaitableEvent in renderer/platform. All uses of them are replaced with base::WaitableEvent. Bug: 919388 Change-Id: I9e7119fa31e9bb88b79b2f1f49633d142a1ce2f6 Reviewed-on: https://chromium-review.googlesource.com/c/1478327Reviewed-by:
-
Gyuyoung Kim authored
The OnionSoup effort has a goal of allocating all garbage-collectable Blink objects with Oilpan or PartitionAlloc. However, the 2 classes of //blink/renderer/core/script has not yet been allocated with them so far. So their uses of non-garbage-collected objects should be restricted to cases where the garbage collector can discover their references. The macros of Allocator will be useful for the non-garbage-collected objects to avoid unintended allocations. After some analyzes, it was concluded that for the case of ModuleImportMeta and ParsedSpecifier, they make sense to use STACK_ALLOCATED because they have been used in function without new allocation or smart pointers. In PaintInvalidator class case, it makes sense to use DISALLOW_NEW because it's used by PrePaintTreeWalk class as a member variable. Bug: 919389 Change-Id: I0e039994b0f7db1900a9963da32c375c9283cfd3 Reviewed-on: https://chromium-review.googlesource.com/c/1478654Reviewed-by:
-
