- 27 Feb, 2020 40 commits
-
-
Elly Fong-Jones authored
This knocks ~5% off the total runtime of unit_tests on my workstation, since most tests in this suite otherwise take multiple seconds to run. Bug: 1055824 Change-Id: Id911e97ce55efed11f6ee5fb34eaf5409426f19d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072660Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#745047}
-
Antonio Gomes authored
The former wraps the later with two additional bits: - request_id - is_processing_user_gesture This CL adds accessor methods to both bits in UserMediaRequest, and uses it directly instead of the UserMediaRequestInfo. BUG=704136 R=guidou@chromium.org Change-Id: Iee9cef6b20293a71fb8b35ba655642355b1841fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075639Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#745046}
-
Jérôme Lebel authored
The sign-in interaction coordinator is active when it is used with the sign-in coordinator. Bug: 971989 Change-Id: Ic199eb9e7628d6f4195f7bbc5637827eccc38cfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2077933 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#745045}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/1468dd8d57f8..091710f87c8c git log 1468dd8d57f8..091710f87c8c --date=short --first-parent --format='%ad %ae %s' 2020-02-27 almuthanna@chromium.org Refactor Console E2E test to use helpers 2020-02-27 jacktfranklin@chromium.org Typecheck Common/JavaScriptMetaData.js 2020-02-27 changhaohan@chromium.org migrate debugger/script-formatter-breakpoints-4.js to e2e test 2020-02-27 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-02-27 jacktfranklin@chromium.org Reland "Extract `toBase64` into `StringUtilities`" 2020-02-27 tvanderlippe@chromium.org Typecheck common/Worker.js Created with: gclient setdep -r src/third_party/devtools-frontend/src@091710f87c8c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1011811,chromium:1044632,chromium:1050549 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I1be8db4bad2275ba8486db55ae41601bac4c993c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078291Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#745044}
-
Rune Lillesveen authored
We used to skip the whole base computed style optimization and just compare the new style with the old stored base, but used the newly computed style always when DCHECK was enabled. This CL always computes the computed style without the base, but then, after verifying it matches the base, use the base computed style. Bug: 669790 Change-Id: Ifc82de4644fae104d69d8abf91261ba1cfe52f73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074399Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#745043}
-
Bang-Cheng Wang authored
It was removed in: https://webrtc-review.googlesource.com/c/src/+/154344 Bug: internal b/144781004 Test: CQ Change-Id: I5b4ab99107f1fc3db72fb0ec279f3e9bb3c92445 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076742 Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Auto-Submit: Bang-Cheng Wang <bcwang@google.com> Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#745042}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1412b3e47c6f..66adad7d3726 git log 1412b3e47c6f..66adad7d3726 --date=short --first-parent --format='%ad %ae %s' 2020-02-27 mtklein@google.com turn on mem2reg, set mcpu 2020-02-27 mtklein@google.com basic JIT support? 2020-02-27 mtklein@google.com little steps forward Created with: gclient setdep -r src/third_party/skia@66adad7d3726 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jlavrova@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jlavrova@google.com Change-Id: I8b1913b23d5adb0cc1d11751251e7d644dbfa088 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078076Reviewed-by:
-
Omer Katz authored
These flags are used when creating NodeRareData. Making them const serves to indicate that they are never changed and clarifies the process of choosing which NodeRareData type to create. (this was suggested by mlippautz@ on issue 1055194) This also requires refactoring the initialization a bit. Change-Id: Ie17684e3050e59c1f6bf16c1e37832e1064be5b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074881Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#745040}
-
Rainhard Findling authored
* Adds the safety check extensions child element * On an update state change, adapts the child icon, icon color, secondary label, and user action UI components accordingly Bug: 1015841 Change-Id: I9f24f7211c3aea7036ca46fe4fa3387321b3dbc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072241 Commit-Queue: Rainhard Findling <rainhard@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#745039}
-
Anatoliy Potapchuk authored
Sometimes network timer was timing out and we were going into network configure screen. This screen is orthogonal to the purpose of this test. Let's disable network handling in this test. Bug: 964333 Change-Id: Ic93568970b7af07f4703c9474868aaefabccf1cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075457 Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#745038}
-
Fabian Sommer authored
The CL introduces a new security token request controller similar to the parent access controller, which was the only user of the PIN UI until now. This CL also adds small bits of functionality to the UI that is required for the new use-case: Disabling input and clearing the input field. The new UI applies to login and lock screen, but not in-session or for OOBE, which use different UIs. Bug: 1001288 Change-Id: I8c69064a0d944bb6b5a7dac13a2ec2bd968deece Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020968 Commit-Queue: Fabian Sommer <fabiansommer@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#745037}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/61b1c84d5157..e9fa76827a5a Created with: gclient setdep -r src-internal@e9fa76827a5a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I9f5e8cdbe4b4173866033e4f864780e3644af236 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078073Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#745036}
-
Robbie Gibson authored
As described in the linked bug, on iOS 13, in Settings.app, after the keyboard is opened, the scroll view doesn't adjust and the bottom rows are hidden beneath the keyboard. This workaround adds a bunch of blank lines to the end of the settings so the actual content can still be seen above the keyboard. Bug: 1056606 Change-Id: If34ae9356a42898f5616fde8cafdd6ea00ccb2e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2077932Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#745035}
-
Maksim Moskvitin authored
This CL enables SyncUSSNigori by default, because it should be launched soon and removes one Directory-specific test, which is not relevant once USS implementation is enabled for all datatypes. Bug: 922900 Change-Id: I0f6c71a4a1a6a06a3fed510e11d28b770972c6c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074700 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#745034}
-
Denis Kuznetsov authored
Fixed: 1045321 Change-Id: Ic50d44b76861b691100cd207edcf24b3d591150d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076597 Auto-Submit: Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium b09f7d51. With Chromium commits locally applied on WPT: d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I7983b35bd4630f6ad6560566d50d150d7ee9c96d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2077399Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#745032}
-
Colin Blundell authored
This CL componentizes //chrome's UrlConstants.java for reuse by WebLayer. Specifically, this file is used by //chrome's external navigation launching code, which we are in the process of componentizing for reuse by WebLayer. As this file references concepts that are conceptually above the //content level (e.g., browser-level features), it makes sense for it to live in //components. Rather than create a small component just for this we placed it in //components/embedder_support. It will shortly be joined by UrlUtilities.java. Bug: 1031465 Change-Id: I2f24f625d9dc1b5e977ecb5dcbe3dc98a26e67ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073938 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#745031}
-
Sigurd Schneider authored
This reverts commit ea358e18. Reason for revert: Suspect for causing rare crashes. Original change's description: > Reland "[devtools] Don't continue execution after reload on breakpoint" > > This is a clean reland of 4276111d > > The original patch was reverted due to an unrelated timeout, see > https://bugs.chromium.org/p/chromium/issues/detail?id=1049444 > > Original change's description: > > [devtools] Don't continue execution after reload on breakpoint > > > > This CL fixes an issue where JavaScript execution would continue > > after reloading on a breakpoint. See design doc: > > https://docs.google.com/document/d/1aO9v0YhoKNqKleqfACGUpwrBUayLFGqktz9ltdgKHMk > > > > The CL depens on V8 change in crrev.com/c/1924366 and tests should fail until > > that change is landed+rolled to chromium. > > > > Fixed: 1004038 > > Fixed: 1014415 > > Change-Id: I182393ebd4c68588163dda7c607be8bb09a3eda3 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926502 > > Reviewed-by: Yang Guo <yangguo@chromium.org> > > Commit-Queue: Sigurd Schneider <sigurds@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#738522} > > Change-Id: Id6ada47ff10df164ca7ead387907a0a2fff03e4c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041623 > Reviewed-by: Yang Guo <yangguo@chromium.org> > Commit-Queue: Sigurd Schneider <sigurds@chromium.org> > Cr-Commit-Position: refs/heads/master@{#739296} TBR=dgozman@chromium.org,yangguo@chromium.org,sigurds@chromium.org Change-Id: Iecc1a863b0aad16157c272dae9c8b3a3167ade9c Bug: chromium:1056246 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075337Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#745030}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5ba8c6c1..bc110cba Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I924a6d29de6a2a087f744c1e249240190073a56c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2077400Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#745029}
-
Peter Conn authored
This reverts commit 2d6ff560. Reason for revert: https://crbug.com/1056619 Original change's description: > Roll R8 2.0.2 -> 2.1.8 > > I checked to ensure crbug.com/1050440 was fixed. > https://issuetracker.google.com/149831282 > > Bug: 1040534 > Change-Id: I3894f4316f2dde2527a35ad6e919ee8cdc86c2b9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075039 > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Auto-Submit: Sam Maier <smaier@chromium.org> > Cr-Commit-Position: refs/heads/master@{#744708} TBR=agrieve@chromium.org,smaier@chromium.org Change-Id: I82171bb599afbf59e5c683f873621b702fe9eb99 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1040534 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078431Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#745028}
-
Antonio Gomes authored
This is a follow up of [1]. [1] https://crrev.com/c/2064748/1/third_party/blink/renderer/modules/mediastream/user_media_processor.h#43 BUG=704136 R=guidou@chromium.org, haraken@chromium.org Change-Id: If4f55ea4d7417c98b091e3b3a0480e38a39e9e7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074746Reviewed-by:
-
Alice Wang authored
Change-Id: Ibfe843de433b14191429389ecd601805f9d644cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069543Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#745026}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/951d1b78a6e5..1468dd8d57f8 git log 951d1b78a6e5..1468dd8d57f8 --date=short --first-parent --format='%ad %ae %s' 2020-02-27 szuend@chromium.org Typecheck Throttler.js using TypeScript 2020-02-27 szuend@chromium.org Revert "migrate debugger/script-formatter-breakpoints-4.js to e2e test" 2020-02-27 changhaohan@chromium.org migrate debugger/script-formatter-breakpoints-4.js to e2e test Created with: gclient setdep -r src/third_party/devtools-frontend/src@1468dd8d57f8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1011811,chromium:1044632 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I39d9903a9715e5377d5429403100d142b33bc43e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2077427Reviewed-by:
-
Clemens Backes authored
WebAssembly code garbage collection shipped in M-77. The feature flag is not needed any more. R=haraken@chromium.org Bug: v8:8217 Change-Id: Idf62791293abe5b1e835e0e070369ddddf5fb0fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2077738Reviewed-by:
-
Peter Kasting authored
We only need to see the output from the alternate version generator if something went wrong. This stops a step from dumping a bunch of output in the middle of `ninja -C out/Debug all`. Bug: 918220 Change-Id: Iea15f70b354197d072a8b1ccee011b0ee40a01e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2077283 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#745023}
-
Mansi Awasthi authored
This CL introduces a method PDFiumPage::PopulateTextFields() which reads text form fields from the PDF document and stores relevant information in a vector within PDFiumPage. The CL also includes a new test file with sample text fields and a unit test to validate the new method. Bug: 1030242 Change-Id: I98a13e237e443f1703ac7b699cc4952cf21c5e10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024637 Commit-Queue: Mansi Awasthi <maawas@microsoft.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#745022}
-
Mohammad Refaat authored
For now TabModel still has a member tabUsageRecorder which is used only internally in the class. Other than that change the usage of tabUsageRecorder in BVC and EG-tests to directly use the browser agent Also fixed a minor bug in tab_test_util where saving session was done on the main browser instead of the current active browser. Bug: 10501078, 1050109, 1050138 Change-Id: I7b25ab58285b3d656cb04b24f40ffc2403ecc008 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064944Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Auto-Submit: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#745021}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/37a2a3416ade..56731e642bb7 git log 37a2a3416ade..56731e642bb7 --date=short --first-parent --format='%ad %ae %s' 2020-02-27 skyostil@google.com Merge "trace_processor_shell: Also export views to SQLite db" Created with: gclient setdep -r src/third_party/perfetto@56731e642bb7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I7c95233125a902b286c02e80b2495fc26452d64e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2077425Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I61aed6f7e8b3eae473073cd405994006e1721590 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2077424Reviewed-by:
-
Jose Lopes authored
This callback is used to signal completion of the read operation, therefore, it's a once callback: * https://cs.chromium.org/chromium/src/media/base/data_source.h?rcl=6e8610f8f31aa3bb8266660380a66c6c25b2e64a&l=27 This is part of the base::Callback migration. Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40 Bug: 714018 Change-Id: Ie43febda1247be065f9f22cc4aec0d8412873491 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056729Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Jose Lopes <jabolopes@google.com> Cr-Commit-Position: refs/heads/master@{#745018}
-
Roman Aleksandrov authored
Bug: 1043722 Change-Id: I5ced280ff5b2438dd6634e16bf9222ddeefce6c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074397 Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Reviewed-by:
Greg Levin <glevin@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#745017}
-
David Roger authored
This test is flaky: [FATAL:web_contents_observer_sanity_checker.cc(318)] Check failed: !is_loading_. Full log: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8887315141255408336/+/steps/browser_tests/0/logs/Deterministic_failure:_NewTabPageAppTest.All__status_CRASH_/0 TBR=aee Bug: 1056063 Change-Id: Idb859bf6deae3505631ef0d472ade98635b3d2e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2077479Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#745016}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/206d46750780..40b764a6ba45 git log 206d46750780..40b764a6ba45 --date=short --first-parent --format='%ad %ae %s' 2020-02-27 asapersson@webrtc.org VideoSendStreamTest: remove unused array and member. 2020-02-27 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 95bde2f2..7c2b6c4e (744714:744850) 2020-02-26 trevor.axiom@gmail.com Reland "Reland "Reland "Reland "Reland "Implemented screen enumeration and selection for desktop capture under X11 using the X Resize and Rotate extension version 1.5.""""" Created with: gclient setdep -r src/third_party/webrtc@40b764a6ba45 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:396091 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Iff8245234b29ba53d9aac093b00952408dbcba05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078071Reviewed-by:
-
Colin Blundell authored
This file is used from //chrome's ExternalNavigationHandler.java, which we are componentizing for sharing with WebLayer. This CL moves IntentUtils.java into //base/android, as it is conceptually //base-level functionality. This CL also removes this file from being listed in chrome/android/java/static_library_dex_reference_workarounds.flags, which prevents //chrome files from being used in Trichrome. That restriction is no longer relevant now that this file is in //base (especially since the goal of this work is *precisely* to end up sharing this file with WebLayer ;). Bug: 1031465 Change-Id: I7e4fd1ac42ba1083afbe0fc55582ee20b42d6596 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071257 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#745014}
-
Francois Beaufort authored
This CL fixes a crash on some samsung android devices where the link between ACTION_NFC_SETTINGS and the NFC settings-menu is broken. NFC settings intent is only returned from now on only if we're confident activity can be opened, to prevent an android java exception "android.content.ActivityNotFoundException". See https://developer.android.com/guide/components/intents-common Bug: 1035048, 1055216 Change-Id: Ibedd48cf9aded28def53753275747c4addaa220a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072158Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#745013}
-
Oriol Brufau authored
This is a reland of 7b29a982 The initial patch was reverted due to a leak caused by a condition in LayoutObjectChildList::DestroyLeftoverChildren, which was preventing markers from getting destroyed. Original change's description: > [css-pseudo] Implement legacy markers as real pseudo-elements > > Before this patch, list markers were anonymous boxes in legacy layout. > This patch makes them be pseudo-elements instead. This is a follow-up of > r731964, which did the same for LayoutNG. > > Just like r731964, this patch improves the flexbox_with_list_item.html > performance test by a 30-40% (this time for legacy). > > BUG=457718 > > TEST=editing/execCommand/create-list-1.html-disabled > TEST=editing/pasteboard/drag-selected-image-to-contenteditable.html > TEST=editing/pasteboard/input-field-1.html > TEST=editing/selection/drag-to-contenteditable-iframe.html > TEST=editing/selection/move-by-line-002.html > TEST=editing/selection/selectNode.html > TEST=editing/selection/selectNodeContents.html > TEST=editing/unsupported-content/list-delete-001.html > TEST=editing/unsupported-content/list-type-after.html > TEST=editing/unsupported-content/list-type-before.html > TEST=external/wpt/css/css-pseudo/marker-content-014.html > TEST=external/wpt/css/css-pseudo/marker-content-019.html > TEST=external/wpt/css/css-pseudo/marker-content-020.html > TEST=inspector-protocol/resources/dom-snapshot-pseudo-element.html > TEST=paint/invalidation/list-marker-2.html > TEST=paint/invalidation/offset-change-wrong-invalidation-with-float.html > > Change-Id: I58c8d49e1f2168add3c78a024a2b9371b34262d7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007733 > Commit-Queue: Oriol Brufau <obrufau@igalia.com> > Reviewed-by: Koji Ishii <kojii@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Reviewed-by: Rune Lillesveen <futhark@chromium.org> > Cr-Commit-Position: refs/heads/master@{#743220} Bug: 457718 Change-Id: Ia20878e1aed120f7822ec009ed4a1c96928b46dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066747 Commit-Queue: Oriol Brufau <obrufau@igalia.com> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#745012}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/5b1a37af5633..141da028168e git log 5b1a37af5633..141da028168e --date=short --first-parent --format='%ad %ae %s' 2020-02-27 wl@gnu.org Make `FT_HAS_*' and `FT_IS_*' really return true (#57906). Created with: gclient setdep -r src/third_party/freetype/src@141da028168e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:mac10.13_retina-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel Bug: None Tbr: bungeman@google.com,drott@google.com,thestig@google.com Change-Id: I4d313bef0385e948fb9fed3b652b6c9ceac9ab01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2077819Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#745011}
-
Rouslan Solomakhin authored
Patch #2: Parsing and validating the parameters of CanMakePaymentEvent.respondWithMinimalUI() in Blink. The respondWithMinimalUI() method is disabled by default and can be enabled via chrome://flags/#enable-experimental-web-platform-features. Explainer: https://gist.github.com/rsolomakhin/eba91c185028899883d2c7f37f357d7c Demo: https://rsolomakhin.github.io/pr/apps/micro/ Test: wpt/payment-handler/respond-with-minimal-ui.https.html Chrome feature status: https://chromestatus.com/feature/5661524146257920 Blink-dev intent to prototype: https://groups.google.com/a/chromium.org/d/msg/blink-dev/kTLpgFJz6Ck/IQeiGDtOAwAJ Bug: 1005076 Change-Id: I1573cef83d357046144d198e870c7f3fd54fd976 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072582Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#745010}
-
Omar Morsi authored
Extend the enterprise.deviceAttributes API to provide the device hostname. Device hostname can be set by administrators via DeviceHostnameTemplate policy. Bug: 1043612 Test: browser_tests --gtest_filter=*EnterpriseDeviceAttributes* Change-Id: Ib9c40e1fcd5c95e6a76d8fb5501e4f8d8b559f61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003855 Commit-Queue: Omar Morsi <omorsi@google.com> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#745009}
-
Joey Scarr authored
Fixed: 1007682 Change-Id: I09db1f19fd0b0e11f435055632f939fadf1601a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059613 Auto-Submit: Joey Scarr <jsca@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#745008}
-
