- 08 Jul, 2020 40 commits
-
-
Leszek Swirski authored
The ResponseBodyLoaderClient is held weakly by the script streaming SourceStream class, which means we have to manually check for a null client when notifying it that we've received data. Bug: 1098874 Change-Id: I9e2b307a5fcc5fe13f489773a3657f55ba0c1180 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287310Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#786205}
-
Koji Ishii authored
r782445 crrev.com/c/2266052 changed to use copy instead of move when reusing previous layout results because we can't break them. There is another case we copy |NGFragmentItem|, when |NGFragmentItemsBuilder| creates a new |NGFragmentItems|. In this case, it is safe to break |NGFragmentItem| in |NGFragmentItems|. This patch adds move constructors to support moving in this case. The caller, |NGFragmentItems::NGFragmentItems| already use |std::move|. https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/renderer/core/layout/ng/inline/ng_fragment_items.cc;l=23?q=NGFragmentItems::NGFragmentItems Bug: 982194 Change-Id: Iee89fb228459ab37144824f2809f33726a4a2543 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2286249 Commit-Queue: Koji Ishii <kojii@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#786204}
-
Oleh Lamzin authored
Introduce ConvertPtr template that checks whether input is null. Since ConvertPtr is a template we can test it with any valid type. Bug: b:158658869 Change-Id: I78d5f7c984303cbd9e34b187c07e1f08a0a891eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273065 Commit-Queue: Oleh Lamzin <lamzin@google.com> Reviewed-by:
Mahmoud Gawad <mgawad@google.com> Reviewed-by:
Roland Bock <rbock@google.com> Cr-Commit-Position: refs/heads/master@{#786203}
-
Rune Lillesveen authored
This CL is a revert of [1] and an alternative fix for 1093747. The original change caused increased memory use for some reason. It's confirmed with a pinpoint job that this CL fixes that regression. [1] https://crrev.com/c4a447a85cdb4de7740476a74c9d258feb0a976d Bug: 1100637, 1093747 Change-Id: If13212db30f818e68649f56a5c68ca5221a73dc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278052Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#786202}
-
Tal Pressman authored
Prior to crrev.com/c/2227049, there was a check to see if the frame had a document before reading its agent cluster ID. Removing that check causes crashes when GetAgentClusterId() is called from AgentSchedulingStrategy. Bug: 1103105 Change-Id: Ia0f75d1e66aaffa24ddf88269eacf2303d85c677 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287191Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Tal Pressman <talp@chromium.org> Cr-Commit-Position: refs/heads/master@{#786201}
-
Oleh Lamzin authored
Use which() method and switch to convert Mojo unions. Ther benefit is that if union will be extended on cros_healthd side, there will be compilation error. Bug: b:158658869 Change-Id: If86b6c9a1e8eebe7b28ba8597234d6f742638e03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273064 Commit-Queue: Oleh Lamzin <lamzin@google.com> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
-
Christian Dullweber authored
OnStatusChanged was wired up to the wrong number for allowed_cookies. Fix call and add test. Bug: 1077766 Change-Id: I196a92022deeb2e79a2449bfd48c00a743791a41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283587 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Auto-Submit: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#786199}
-
Benoit Lize authored
Adds basic uncontended Acquire()/Release() and contended Acquire()/Release() tests. There are two goals: 1. Assess base::Lock improvements / regressions 2. Compare to the similar base::subtle::SpinLock perf tests The first one was used to evaluate the impact of the recent patch to always Try() in base::Lock (https://chromium-review.googlesource.com/c/chromium/src/+/2270203). Using the following code on Linux x86_64, release build: $ for i in `seq 1 10`; do out/Release/base_perftests \ --gtest_filter='Lock*' | grep baseline | grep 'runs/s' \ | sed -e 's/.*= //;s/ runs.*//' >> /tmp/results-after; done shows that the throughput of uncontended Acquire()/Release() pairs improves by 29% on this machine (Xeon "Haswell" running Debian testing). Throughput of contended Acquire()/Release() pairs increases by 1-2%, though this is likely a wash there. Sample test output: Before the Try() patch: [ RUN ] LockPerfTest.Simple *RESULT Lock.lock_unlock_throughput: baseline_story= 36441076 runs/s After: [ RUN ] LockPerfTest.Simple *RESULT Lock.lock_unlock_throughput: baseline_story= 43857328 runs/s The second one is related to moving away from base::subtle::SpinLock in PartitionAlloc, which currently causes performance regressions. See linked bug for details. Bug: 1061437 Change-Id: I9d2047bcc74d4d7d20ca6c44683d537508d92264 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283203Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
-
Morten Stenshorne authored
Keeping empty anonymous blocks around is bad. The only known actual problem is in multicol (but it may cause other issues too). Based on the layout object tree, multicol creates anonymous LayoutMultiColumnSet and LayoutMultiColumnSpannerPlaceholder objects, to keep track of what is regular column content and what are spanners. Leaving a LayoutMultiColumnSet around just for the sake of an empty anonymous block (which may get cleaned up without notifying the multicol code) will confuse multicol layout. Bug: 1102137 Change-Id: Ibfb46d0dc173ecfdb2e7903efee5a49de3da3ff3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283355 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#786197}
-
Oleh Lamzin authored
Use New() for health types: - BatteryInfo - NonRemovableBlockDeviceInfo - CachedVpdInfo Pro: - We'll have a compilation error if we forgot some field Con: - Compiler may compile code if we swap some fields in the mojo type. But we have unit tests that should cover it. Bug: b:158658869 Change-Id: I3b8edfc393f85b8441d1af2d97302d2ff8553266 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273063 Commit-Queue: Oleh Lamzin <lamzin@google.com> Reviewed-by: -
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/a0b4571546bb..7622be0544b0 2020-07-07 bryan.bernhart@intel.com D3D12: Avoid re-binding sampler tables. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Ia3115b527cafd0c6e5fafb40936e4748f02f54d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2286773Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#786195}
-
Gang Wu authored
In this CL, we update two parts. 1. If native is initialized, autocomplete mediator call ZeroSuggestion instead of CachedZeroSuggestion. 2. When SearchActivity lost focus, mUrlBar should lost focus as well. Bug: 1101696 Change-Id: I7ce3638a8f9572ce89fa8e9627d1060fecb0226a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2281155Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Ender <ender@google.com> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#786194}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1594166201-979527694a92667bf62297ee8ba7cd564f63c679.profdata to chrome-mac-master-1594187879-ea779e343e40d01b4c7f0171da17c012b1babef3.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC liaoyuke@google.com,jeffyoon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: liaoyuke@google.com,jeffyoon@google.com Change-Id: I77ce147f9e4f5c70ed83454f9760c6349331b1e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2286775Reviewed-by:
-
Hirokazu Honda authored
Originally AlignedDataHelper produces UNOWNED_MEMORY VideoFrame from aligned data. This CL improves the AlignedDataHelper code in order to return MojoSharedMemory VideoFrames. AlignedDataHelper saves aligned data to mojo::ScopedSharedBufferHandle, and creates a new MojoSharedMemoryHandle by duplicating the handle. Bug: 1045825 Test: video_encode_accelerator_tests on eve Change-Id: I2914891c4e37f76f35c4a32685f935b6d76b7c66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250144Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#786192}
-
Lei Zhang authored
The 2-parameter version is deprecated. Switch to its replacements. Bug: 1009837 Change-Id: I9e6c767c6765b954ef01fc7f5d48bc95d6db28e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2286269Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#786191}
-
Yuki Shiino authored
Make the custom callback functions of V8Window adaptable to the new binding generator of IDL interfaces. Bug: 839389 Change-Id: I063bf203fa023941d8e9636464b90d6f3f684a88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282554 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#786190}
-
Yuki Shiino authored
Implements the V8 context initialization with using the new binding generator of IDL interfaces. Bug: 839389 Change-Id: Ic8972b7f654ea80a328db3c4be40b2b7780bafc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282838 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
David Jean authored
These metrics should not expire since they are tracked for regression. Bug: 1100372 Change-Id: I7dacfc3cedd3966f8610209d84014abd6a86d973 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283348Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#786188}
-
Kyle Horimoto authored
Before this CL, WiFi configurations would sync even if a policy explicitly prohibited them from being synced. This was due to a naming issue: "osWifiConfigurations" vs. "wifiConfigurations". The bug was due to the migration of this type from normal browser sync to OS sync. Bug: 1101036 Change-Id: I5604526b85a41d24013eee5765bfbf46ee65ba83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285927 Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#786187}
-
sandromaggi authored
Before this change we lost autofill error details when the Autofill action itself succeeded but the RequiredFieldsFallbackHandler did not. Bug: b/160651587 Change-Id: I6a72e36e01117ae428a7add4cc6bdfe6af2ad6d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283593 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#786186}
-
Ted Choc authored
BUG=1044616 Change-Id: I4d47b2430379626beab226c7c7d0f2e68cf53033 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284388Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#786185}
-
Gyuyoung Kim authored
This CL cleans up unnecessary uses of below header files, - interface_ptr.h - interface_request.h - threadsafe_interface_ptr.h - associated_interface_ptr.h Bug: 955171, 1035484 Change-Id: I8a157f618b6bb100f212fe35cf437f3864aa6dda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2280870Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1594004320-2e826e0a02d03f5d95b06057ee6fb0c871fea712.profdata to chrome-win32-master-1594169954-cd07ad6b204758d03bed8bf845cd0c0bb5f93bcd.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC liaoyuke@google.com,jeffyoon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: liaoyuke@google.com,jeffyoon@google.com Change-Id: I565fee1197d6522a90fc00932d56c6d1ccfed833 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2286462Reviewed-by:
-
Daniel Hosseinian authored
Capitalize Epson CUPS color values to potentially fix a problem where the Epson filter is not detecting the color mode and prints data intended for color in monochrome. Bug: 1081705 Change-Id: Ic192d9809dca2101988fe00da7decc5b1002de1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285180 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
-
Hesen Zhang authored
Bug: 1066556 Change-Id: Iaee901e0071dc39144e369dca07409bbfd6f8421 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283325 Commit-Queue: Hesen Zhang <hesen@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#786181}
-
Ken Rockot authored
This fixes some edge cases which can cause SharedRemote to either block unnecessarily on its bound sequence or fail to block as intended on its bound sequence, depending on how it's constructed and called into. We want to repurpose the underlying Remote's sync waiting behavior when the SharedRemote makes a sync call from the bound sequence, but when a call is made from any other sequence, the SharedRemote must implement its own waiting mechanism. This change ensures that SharedRemote configures its underlying Remote to disable sync waiting by default, and it's selectively re-enabled only around any (potentially nested) sync calls made from the bound sequence. Fixed: 1102921 Change-Id: I603e48e38d859c43d7b732a91445314714ea0591 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2286051 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#786180}
-
Rune Lillesveen authored
All tests fail because we don't implement Media Queries level 4. Bug: 962417 Change-Id: I37b1fe0de77af96573e4124e6cce2778e3dd39b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283220 Auto-Submit: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
-
Lei Zhang authored
The 1-parameter version is simpler, and the 2-parameter version is deprecated. Fix a few lint errors along the way. Bug: 1009837 Change-Id: I01943e6090fa4103f7464f5d01f4003af9f5948e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285918Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#786178}
-
Alex Danilo authored
CL:2201336 swaps a native <select> control for a <div> that emulates select behavior and allows it to be styled with CSS. Add support for using the left and right arrow keys which behave the same as up and down in a real <select> control. Bug: 1097454, 1002410 Change-Id: I854b794e8bb34200a83cf3a3f11ff4ed007808bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282831 Commit-Queue: Alex Danilo <adanilo@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#786177}
-
Bruce Dawson authored
JSONPerfTest.StressTest was crashing on x86 builds. Debugging showed that it was hitting an OOM failure and analysis showed that this was because some iterations of the test required more than 4 GB of memory. No memory leaks were seen. This lowers the maximum depth from 12 to 10 which drops the memory required from ~6 GB to ~250 MB, and the time from 58 seconds to 4. This should be enough to avoid Android timeouts so this change also re-enables the test for Android. Bug: 906686 Change-Id: I1114159da9ffb1a0694810d5686bba42ca671327 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283966 Commit-Queue: Albert J. Wong <ajwong@chromium.org> Auto-Submit: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#786176}
-
Alan Cutter authored
This CL changes installReplacementWebApp() to no longer require the installed site to have a service worker or be display standalone. The previous restrictions were from a time when "web apps" and "PWAs" had a stronger distinction that needed to be upheld. Now they are blocking efforts to migrate hosted apps over to web apps. This CL plums the bypass_service_worker_check option through the web app install flow so the Extension API can bypass that check. All other callsites are left untouched. To reflect this change LoadWebAppAndCheckInstallability() has been renamed as LoadWebAppAndCheckManifest(). Bug: 1096868 Change-Id: Iff5d5584fa247d465aa367f6e426402969064747 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275993Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#786175}
-
Brandon Jones authored
This change shares a single XrInstance between the XRRuntimeProvider, OpenXrStatics, OpenXrDevice, OpenXrRenderLoop, and OpenXrApiWrapper. The instance is actually owned by the OpenXrStatics, which is in turn owned by the OpenXrDevice when one exists, and the XRRuntimeProvider otherwise. In terms of thead safety, the XrInstance will only be destroyed by the OpenXrDevice destructor, which also owns the OpenXrRenderLoop and explicitly shuts it down. Most methods which take an instance don't have any threading concerns, but even so once we have a render loop we don't make any calls against the instance from the OpenXrDevice thread until the render loop is shut down. Bug: 1100577 Change-Id: I2fc326e17c1faf3915e8eafddf23055ccd9a5639 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278534 Commit-Queue: Brandon Jones <bajones@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
Patrick To <patrto@microsoft.com> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#786174}
-
Tsuyoshi Horo authored
Bug: 970083, 1103107 TBR=agrieve@chromium.org,aluo@chromium.org,tiborg@chromium.org Change-Id: Ic4abb6624fa8ea12d430ecadf9716c63d5ac6874 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2286073Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#786173}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I6152ea9adc21d92502d8fcb42e5343ce196288d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2286152Reviewed-by:
-
Yuki Shiino authored
There is no need to have a dedicated map from WrapperTypeInfo* to v8::FunctionTemplate just only for V8 context snapshot. Removes the special casing only for V8 context snapshot. Bug: 839389 Change-Id: Idacbf5290498098b13f63d6ea0e7f4203664adc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284517Reviewed-by:
-
Bartek Nowierski authored
This is a continuation of crrev.com/c/2275886. If PA-Everywhere and tagging for CheckedPtr were to be enabled, this test would've failed. By switching to aligned root, we're making it pass in all situations. Bug: 1092288, 998048 Change-Id: Ib638818cc1e433c937c3c6fd375a492f5b3b22ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282837 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
-
Nektarios Paisios authored
Added tests for at start/end of paragraph before a list marker and rich comments to other paragraph tests A test is being added for testing whether a list marker (both Legacy Layout and NG Layout) is correctly recognized as a paragraph boundary. Also took the opportunity to add several comments to other paragraph tests that might have been unclear or complicated. AX-Relnotes: n/a. R=dmazzoni@chromium.org, aleventhal@chromium.org Bug: 1090454 Change-Id: I69d49cb7acd6a4e55bad56914072c6e2b95dd2f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283590Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#786169}
-
Yoshifumi Inoue authored
This patch changes |LinkHighlightImpl::Paint()| to use |NGInlineCursor| only for LayoutNG tree to avoid hitting |DCHECK()| when runtime enabled feature LayoutNG disabled but LayoutNGFragmentItem enabled, e.g. linux_layout_tests_layout_ng_disabled bot. This is follow-up of the CL[1] which makes |LinkHighlightImpl::Paint()| to use |NGInlineCursor|. [1] http://crrev.com/c/2097777 [NGFragmentItem] Stop using rounded rect for link highlight when <a> has nested inline Bug: 707656 Change-Id: If1b4c052510a76f58bb8016cb9110479709bd82e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2286090 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
Alex Danilo authored
CL:2201336 swaps out the native <select> control for a <div> that implements the same functionality so that it can be styled for files-ng. Add keyboard navigation when the control is collapsed to allow changing the filtered options without expanding the control. Fires a change event if the selection is changed with the control closed so that the filtered name gets updated correctly. Bug: 1097454, 1002410 Change-Id: Ic2e8c06ef309e4cd1090dc9a48622bf92c7e3666 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282829 Commit-Queue: Alex Danilo <adanilo@chromium.org> Reviewed-by:
-
Ken Rockot authored
This adds a new ConnectivityMonitor object to NetworkQualityEstimator. ConnectivityMonitor tracks all pending network requests throughout their lifetime while the host device is connected to a Wi-Fi network. If a long period of inactivity (configurable, default 2500 ms) is detected across all requests, ConnectivityMonitor takes note of this as a potential connectivity issue. If the new ReportPoorConnectivity feature is enabled, this issue is reported immediately to the OS (Android only, for now) as a network failure. ConnectivityMonitor also watches for network changes. If it suspects a connectivity issue and the network switches, we record a new NQE.ConnectivityMonitor.TimeToSwitchNetworks metric as the time delta between the original failure detection (regardless of whether it was reported to the OS) and the actual network change. This CL serves as the basis for an experiment to understand how OS connectivity reporting in Chrome may impact network failure recovery. Bug: 1079380 Change-Id: Ieecb2bf1be1cc9cb17496b5493204e4f0e3c0ee6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275340 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#786166}
-
