- 31 Jan, 2018 40 commits
-
-
Kent Tamura authored
Add custom built-in element support to <embed>, <object>, and <form>. Bug: 805281, 806184, 806185, 806187 Change-Id: I920ea11ed0b5884c69d3c1aee04e18f7fa62e9f2 Reviewed-on: https://chromium-review.googlesource.com/895234Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#533234}
-
arthursonzogni authored
This fixes https://crbug.com/796561 and adds a regression test. The issue was a race between the browser and renderer processes while updating the renderer's history. The renderer's history is updated in * RenderFrameImpl::CommitNavigation and in * RenderFrameImpl::DidCommitProvisionalLoad. ┌────────┐ ┌───────┐ │Renderer│ │Browser│ └───┬────┘ └───┬───┘ │ BeginNavigation │ │ - url=iframe.html │ │ - history_offset = 0 │ │ - history_length = 1 │ 1) │ ──────────────────────────> ┐ │ │ │ │ DidCommitProvisionalLoad │ │ │ - "pushState" │ │ │ - history_offset = 1 │ │ │ - history_length = 2 │ │ 2) │ ──────────────────────────> │ │ │ │ │ CommitNavigation │ │ │ - url=iframe.html │ │ │ - history_offset = 0 │ │ │ - history_length = 1 │ │ ┌─│ <───────────────────────────┘ │ │ │ │ │ DidCommitProvisionalLoad │ │ │ - url=iframe.hmtl │ │ │ - history_offset = 0 │ │ │ - history_length = 1 │ └>│ ──────────────────────────> ┌───┴────┐ ┌───┴───┐ │Renderer│ │Browser│ └────────┘ └───────┘ What happens in the bug. 1) An iframe is created: [history.offset = 0, history.size = 1]. 2) history.pushState: history is updated [offset = 1, size = 2]. 3) CommitNavigation is received, history is updated using the old values transmitted in 1) with BeginNavigation. This CL update the values sent in CommitNavigation. This reduce considerably the duration when the race can happen. Before this CL, the race could happen if a history.pushState is sent in between BeginNavigation and CommitNavigation (~300ms <-> severals seconds). After this CL, the race happens if the history.pushState is sent between when the CommitNavigation message is sent and when it is received by the renderer process. Bug: 796561 Change-Id: I7bf72fadbf9f4946da28126a394adddf051f49a8 Reviewed-on: https://chromium-review.googlesource.com/881171Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#533233}
-
Donna Wu authored
This will eliminate the observer needing to make an immediate async call back to the MediaTransferProtocolManager to obtain the MtpStorageInfo object from its identifier. This is a preparation work for MTP servicification. BUG=769630 Change-Id: I239ed96d42c4e496f97d311a689704e34c55edda Reviewed-on: https://chromium-review.googlesource.com/882494 Commit-Queue: Donna Wu <donna.wu@intel.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#533232}
-
Lutz Justen authored
ADMX files were not loaded into the GPO editor properly for most languages because the directory names were bad, e.g. should be 'it-IT' instead of 'it'. This CL fixes the directory names according to the doc mentioned in the bug below. For a few languages the mapping was not clear: 'am', 'fil', 'ml' - Not in doc; kept the old directory names 'ar' -> 'ar-EG' - Picked EG as the biggest of the ~15 Arabic countries 'bn' -> 'ms-BN' - Is this correct? There's no bn-XX in the doc. 'sr' -> 'Cy-sr-SP' - Is this correct? Translations look cyrillic. BUG=chromium:806577 TEST=Changed components/policy/BUILD.gn to build for all platforms, ran ninja -C out/Release -j 2000 policy_templates Loaded de-DE into GPO editor on Windows Change-Id: I574f6241b152c64943ec39442e2e23f7cae636cf Reviewed-on: https://chromium-review.googlesource.com/893567Reviewed-by:Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#533231}
-
Kenneth Russell authored
Try to get to the bottom of situations where jobs seem to be going to an oversubscribed configuration. TBR=jmadill@chromium.org, jbudorick@chromium.org Bug: 807340 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I2161d42d980c9b5bc8a9acfbe74e11ad7fa037b0 Reviewed-on: https://chromium-review.googlesource.com/894450 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#533230}
-
Koji Ishii authored
Following bot results are included. 3397 3408 3410 3411 3417 TBR=eae@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I009607c87ea2be1e3518e9a0d50aef4db2afd3e4 Reviewed-on: https://chromium-review.googlesource.com/892758 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#533229}
-
Darren Shen authored
We change CSSVariableReferenceValue to reject invalid custom property names as per spec. We also remove .tentative extension from related tests. We also remove some unit tests that are replaced by WPTs. Spec: https://drafts.css-houdini.org/css-typed-om-1/#cssvariablereferencevalue Bug: 545318 Change-Id: I95cfe1c167a60c94083a1474b384fd584d05cca9 Reviewed-on: https://chromium-review.googlesource.com/895124 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
nainar <nainar@chromium.org> Cr-Commit-Position: refs/heads/master@{#533228}
-
Gabriel Charette authored
This reverts commit 0aa36d96. Reason for revert: landed prior to receiving LGTM, CL is NOT LGTM to gab@ https://chromium-review.googlesource.com/c/chromium/src/+/892582#message-1f3ca486683a18c2df48642825a99cee199034bc Original change's description: > Simple code cleanup. > > Passed PrefRegistry and PrefRegistrySyncable by raw pointer instead of reference > to scoped_ptr. PrefRegistry and PrefRegistrySyncable have an internal reference > count. There is no need to use a double indirection when passing them around. > > Used base::MakeRefCounted instead of naked 'new' operator. > > Change-Id: I53a0fdfc99b7ef3dd32b191664520659c2585fa5 > Reviewed-on: https://chromium-review.googlesource.com/892582 > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: François Degros <fdegros@chromium.org> > Cr-Commit-Position: refs/heads/master@{#533087} TBR=sky@chromium.org,gab@chromium.org,erg@chromium.org,fdegros@chromium.org Change-Id: I082b80ef79afd99f093ac8327381ee1293351cfd No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/895362Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#533227}
-
Kenneth Russell authored
From talking with iannucci@, this is the easiest way to use vpython with these tests on the bots. Once the LUCI conversion is done, this will be a no-op, and can be removed. Incorporate the newly deployed pyobjc wheels into Chromium's root .vpython; they are needed by helper scripts in the GPU directory. Bug: 776804, 804174 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I1c720a9f7992e411aa85bcc7959de95ecc03c1f5 Reviewed-on: https://chromium-review.googlesource.com/869512Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#533226}
-
Jaebaek Seo authored
Enabling --use-zoom-for-dsf causes MainThreadEventQueueBrowserTest.TouchMove failure because of a precision issue. We expect that window.lastTouchMoveEvent.touches[0].pageX has 35, but it is 34.6666 when the device scale factor (DSF) is 2.625. It is because LocalFrameView::ConvertFromRootFrame() called by TouchEventManager::CreateDomTouch() (that sets pageX|Y) floors the pageX|Y (i.e., point_in_root_frame). This CL removes the flooring on pageX|Y by adding FloatPoint variants of all co-ordinate space conversion APIs and updating FloatPoint LocalFrameView::ConvertFromRootFrame(const FloatPoint&). TEST=content_browsertests MainThreadEventQueueBrowserTest.TouchMove on NEXUS 5X Bug: 737777 Change-Id: I6c8fb12e4f2fb4c38328ef9f18529e6559f91d43 Reviewed-on: https://chromium-review.googlesource.com/885321 Commit-Queue: Jaebaek Seo <jaebaek@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#533225}
-
Bill Orr authored
The issue here was that glBlitFramebufferANGLE fails when the color formats of the source and destination image aren't compatible. The color format for pBufferSurfaces wrapping dxgi textures has changed to report the underlying dxgi format instead of the egl config used to create the surface, so we were sometimes failing to copy the WebGL contents onto our cross-process-sharing texture. The fix is to use CopySubTextureCHROMIUM instead of blitting framebuffers. This API won't create new destination textures, and will convert formats for us. It also has the benefit of handling flipping y-direction for us, so we could avoid a copy. BUG=804628 Change-Id: Ibc55dd092bacbdd1f751adb0b6a854f58e64e22b Reviewed-on: https://chromium-review.googlesource.com/892091Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
-
Christopher Lam authored
Bug: 807216 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I2b2d3a0b9c8b3b1f74fae4c38bded90022485f33 Reviewed-on: https://chromium-review.googlesource.com/895223Reviewed-by:
Patti <patricialor@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#533223}
-
tanvir.rizvi authored
InsertNodeBefore crashes if the passed ref_child is disconnected. Bug: 755808 Change-Id: I4c07836b6d0f055f2cdfd8f94c326fcaaf03d6ca Reviewed-on: https://chromium-review.googlesource.com/893243Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Tanvir Rizvi <tanvir.rizvi@samsung.com> Cr-Commit-Position: refs/heads/master@{#533222}
-
Kent Tamura authored
createElement() should assume the namespace is XHTML only if the document is HTML-like. New behavior matches to the standard and Firefox. Bug: 807514 Change-Id: I1164612b6512c94de96bdefbf053e8f132f8b9f7 Reviewed-on: https://chromium-review.googlesource.com/894749 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Dominic Cooney <dominicc@chromium.org> Cr-Commit-Position: refs/heads/master@{#533221}
-
Zhuoyu Qian authored
This is part of the gradual process of putting all types that derive from CSSValue into blink::cssvalue:: namespace. Bug: 667961 Signed-off-by:
Zhuoyu Qian <zhuoyu.qian@samsung.com> Change-Id: Iefb3980ce006b1f69c326c639134fe2b7bf6426e Reviewed-on: https://chromium-review.googlesource.com/895023Reviewed-by:
Stuart Langley <slangley@chromium.org> Reviewed-by:
-
Jinsuk Kim authored
PopupZoomerTest doesn't need a test ImeAdapter and InputMethodManagerWrapper instance in CVC for its tests to pass. Previously the tests needed a mock instance to avoid NPE, but CVC was refactored not to require it. This CL deletes the code setting the test instance to CVC. Change-Id: I602f475e2b0e5e76883f980564e7e137b185c823 Reviewed-on: https://chromium-review.googlesource.com/894964Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#533219}
-
Ramin Halavati authored
After fixing the following two files, the trybot test on Linux are reactivated: 'tools/clang/pylib/clang/compile_db.py' 'tools/traffic_annotation/scripts/check_annotations.py' Bug: 690323 Bug: 807146 Change-Id: Id769e4bb4e5d416eb04e2436d38cec5af04606ec Reviewed-on: https://chromium-review.googlesource.com/891960 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#533218}
-
Tatsuhisa Yamaguchi authored
While 1+ incognito browser windows are opened, it'll have separate Files app extension background and foreground scripts running. The ones in the incognito context should only be visible by the file picker window invoked by the browser, but should not show fullscreen app windows or notifications. This fix prevents opening a new Files app. window in incognito context in these cases: - When mounting a new zip file as a volume - When reopening a zip file already mounted (which navigates the current window to it) Bug: 800543 Test: manually Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ib3deccef39a9db61e6ff4d035a6de19c7309d113 Reviewed-on: https://chromium-review.googlesource.com/888192Reviewed-by:
Daichi Hirono <hirono@chromium.org> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/heads/master@{#533217}
-
Tarun Bansal authored
Bug: 704339 Change-Id: Idce639d844d07252c2618ceb34a589964723ccc4 Reviewed-on: https://chromium-review.googlesource.com/891806Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#533216}
-
David Vallet authored
Bug: 805445 Change-Id: I7051f519205e178db57e23320ab979f8fa9ce38b Reviewed-on: https://chromium-review.googlesource.com/894782 Commit-Queue: David Vallet <dvallet@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#533215}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/27e3a1f6..842d424d Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I64c8d498b616f10713d94f18381595001960092d Reviewed-on: https://chromium-review.googlesource.com/894225Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#533214}
-
Yixin Wang authored
net_unittest failure on android_cronet due to missing test app dependency should no longer occur after this CL: https://chromium-review.googlesource.com/c/chromium/src/+/893681 First reland: https://chromium-review.googlesource.com/c/chromium/src/+/891302 Original CL: https://chromium-review.googlesource.com/c/chromium/src/+/887970 Bug:807283 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I622f074ad3d3ec89b78d754367285da52850e527 Reviewed-on: https://chromium-review.googlesource.com/893625Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Yixin Wang <wangyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#533213}
-
Erik Luo authored
Some default experiments were removed - Accessibility inspection - Log management - Performance monitor Bug: none Change-Id: I97bc4ac1883cdb0001fb807f56009c54ca7773b3 Reviewed-on: https://chromium-review.googlesource.com/882312 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by:
-
Ehsan Karamad authored
This method is declared and never implemented. It was to be removed in: https://codereview.chromium.org/197873002. TBR=alexmos@chromium.org Bug: None Change-Id: I887a300e1689c28e74699749be5769a38c3ef4bf Reviewed-on: https://chromium-review.googlesource.com/890029Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#533211}
-
Kentaro Hara authored
This is a follow-up CL for https://chromium-review.googlesource.com/892557. GeoNotifiers are in one_shots_ and watchers_. I forgot to support watchers_ in that CL. Bug: 792604 Change-Id: I1421e14311de6c965cffc038892cfabdb63a4dbb Reviewed-on: https://chromium-review.googlesource.com/894924Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#533210}
-
Istiaque Ahmed authored
This reverts commit 2181b01c. Reason for revert: The offending test (ContentVerifierTest.FailOnRead) has been taken care of in CL: https://chromium-review.googlesource.com/c/chromium/src/+/888327 Original change's description: > Revert "Fix extraneous call to ContentVerifyJob::DispatchFailureCallback." > > This reverts commit 6e548ee1. > > Reason for revert: DCHECK at content_verify_job.cc:192 occasionally fails (see crbug.com/806586). > > Original change's description: > > Fix extraneous call to ContentVerifyJob::DispatchFailureCallback. > > > > If ContentVerifyJob receives hashes (ContentVerifyJob::OnHashesReady) > > after the content is read (ContentVerifyJob::DoneReading), then it > > was possible for DispatchFailureCallback to be called more than once. > > This causes a DCHECK failure in DispatchFailureCallback > > (DCHECK(!failed_)). > > > > Bail out early in OnHashesReady if call to ContentVerifyJob::BytesRead > > leads to a ContentVerifyJob failure. > > > > Note that this isn't harmful in Release builds as > > DispatchFailureCallback tests ContentVerifyJob::failure_callback_ > > before calling the callback, which is reset once it is called. > > Nevertheless, this is incorrect behavior and this CL fixes that. > > > > > > Bug: 804630 > > Test: See bug description for repro steps. > > Change-Id: Icf3a5c8b4c0d01cb20e02de14b11aca4aeff03e5 > > Reviewed-on: https://chromium-review.googlesource.com/879961 > > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > > Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#531755} > > TBR=lazyboy@chromium.org,rdevlin.cronin@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 804630,806586 > Change-Id: Ia5c67f60e95ddb607cb364c745f31dde465d3c4f > Reviewed-on: https://chromium-review.googlesource.com/893258 > Reviewed-by: vitaliii <vitaliii@chromium.org> > Commit-Queue: vitaliii <vitaliii@chromium.org> > Cr-Commit-Position: refs/heads/master@{#532854} TBR=lazyboy@chromium.org,rdevlin.cronin@chromium.org,vitaliii@chromium.org Change-Id: I82988d836f49033e1d618125e06f0d45d1124071 Bug: 804630, 806586 Reviewed-on: https://chromium-review.googlesource.com/894824 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#533209}
-
junweifu authored
Split the provider in order to support Vision Framework [1] which is more accurate and can detect more landmarks with computer vision techniques. This proposal has been merged in Shape Detection specification [2]. Link Mac 10.13 build bots [3] and Face Detection demo[4] here. Split original large CL[5] up in smaller subpatches including this CL. [1] https://developer.apple.com/documentation/vision [2] https://github.com/WICG/shape-detection-api/pull/38 [3] https://codepen.io/miguelao/pen/PmJWro [4] https://ci.chromium.org/buildbot/chromium.fyi/Chromium%20Mac%2010.13/ [5] https://chromium-review.googlesource.com/c/chromium/src/+/867651/10 BUG=799319 Cq-Include-Trybots: master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng Change-Id: I1910f572f83ae4def3d1f669af3fcd91d53b6305 Reviewed-on: https://chromium-review.googlesource.com/888478 Commit-Queue: Junwei Fu <junwei.fu@intel.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#533208}
-
https://skia.googlesource.com/skia.git/+log/ac568a934f8f..70204ab029b5 $ git log ac568a934..70204ab02 --date=short --no-merges --format='%ad %ae %s' 2018-01-30 angle-skia-autoroll Roll skia/third_party/externals/angle2/ bd6ae4aa1..199f42941 (1 commit) Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=bungeman@chromium.org Change-Id: I089ca6bb1249eec1bbca72f34591d3564ab11cfd Reviewed-on: https://chromium-review.googlesource.com/895185Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#533207}
-
Wei-Yin Chen (陳威尹) authored
This fixes https://crrev.com/c/886829. Bug: 777962 Change-Id: Ie8df07034375e8f1e5d5dfb8b821f178bb479b5f Reviewed-on: https://chromium-review.googlesource.com/892490Reviewed-by:
-
Joel Einbinder authored
Bug: 805837 Change-Id: Ib24d46b9ed98b1264c0ff009ac40846ce254c44f Reviewed-on: https://chromium-review.googlesource.com/887640Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#533205}
-
Darren Shen authored
We untentative CSSPositionValue tests. We also split happy and sad tests Spec: https://drafts.css-houdini.org/css-typed-om-1/#positionvalue-objects TBR=nainar@chromium.org Bug: 774887 Change-Id: I33052e0dc6400f5de693da9449d769012919dee3 Reviewed-on: https://chromium-review.googlesource.com/894748Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#533204}
-
Kunihiko Sakamoto authored
This adds MerkleIntegritySourceStream class which decodes and validates the "mi-sha256" content encoding [1]. This class will be used by WebPackageLoader to verify integrity of message body. [1] https://tools.ietf.org/html/draft-thomson-http-mice-02 Bug: 803774 Change-Id: I62353f594e30e90fa982a68374389267b39c21fe Reviewed-on: https://chromium-review.googlesource.com/892844 Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#533203}
-
Aaron Leventhal authored
When screen readers traverse a <table role="presentation">, they need generic container objects in place of the cells, to help them understand and present formatted content. Specifically, this helps present the text without jamming it together, as well as providing line breaks. Bug: 787664 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I53b691f0ccae3f4090ca0f8ecfcbeb622bd3dfeb Reviewed-on: https://chromium-review.googlesource.com/887599 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#533202}
-
Patti authored
Since r522281, the Flash permission is always shown in the Page Info bubble. This was a temporary measure to increase its discoverability after all non-factory-default permissions were removed in r503089, but it isn't an ideal solution - for example, it might imply that the site is using Flash when it isn't. Replace this with a more permanent solution - if the user has changed Flash before on a particular site, always show Flash in that site's Page Info bubble. Bug: 791142 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I5bd7ee74cffeee8fe87743b9c0d7336021c52da0 Reviewed-on: https://chromium-review.googlesource.com/858245 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Cr-Commit-Position: refs/heads/master@{#533201}
-
Kevin Marshall authored
Generates an alternative runner script for each test target, with a "_v2" suffix, e.g. run_base_unittests_v2. The old-style generated runner scripts will still be without the "_v2" suffix, but they will be deprecated and removed soon as part of a followup CL. The new scripts will bring up a new QEMU VM, a Zedboot physical device, or continue to use an existing device that is currently accepting SSH connections. Once connected, the scripts push the package bits onto the device, execute the package using SSH, extract the build logs and other artifacts from the device, and finally clean up the state. Other changes: * Add DeviceTarget impl for deployment. * Use relative paths in package archive manifests, for symbolization. * Add logging statements everywhere, and a -v switch to turn them on. * Add package cleanup teardown step, to avoid cluttering up long-running devices. * Refactor symbolization as a stream filter object. Bug: 799309 Change-Id: Iffaefd1d3a5ce919ba2dea4e29033987454c2eed Reviewed-on: https://chromium-review.googlesource.com/882441 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#533200}
-
Ilya Sherman authored
R=asvitkine@chromium.org Bug: 727984 Change-Id: I1ac800cce5cbfc7de67885ac6f9c3c6a715f25cb Reviewed-on: https://chromium-review.googlesource.com/892323 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#533199}
-
Kurt Horimoto authored
This CL adds a new animator, FullscreenForegroundAnimator that is sent to FullscreenControllerObservers upon receipt of an application foreground notification. This CL also updates FullscreenUIElements to show the toolbar using this animator. Bug: 806694 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I9470602d5535964ea0a054c949ccaba0225e5ed3 Reviewed-on: https://chromium-review.googlesource.com/894355 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#533198}
-
Blake O'Hare authored
Currently, there is a field on KeyboardController for enqueuing a container type change. Eventually we want to support invoking a JS callback to notify the extension when a keyboard mode changes. This is the first step in that direction. Instead of persisting a single enum value for the enqueued container behavior, it tracks both the type and a callback handle. This QueuedContainerBehavior object will invoke the callback once it goes out of scope. Change-Id: Iea4e96259314a34d31661342024a23617a9f4b74 Bug: 806189 Reviewed-on: https://chromium-review.googlesource.com/888119 Commit-Queue: Blake O'Hare <blakeo@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#533197}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I6da287c075108f37858f4d7d5d0e2f79dfcb111d Reviewed-on: https://chromium-review.googlesource.com/894583Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#533196}
-
Peter Kasting authored
BUG=none TEST=none Change-Id: I310a3b6ba78a2eebdc87ffe9a35df05f707b1277 Reviewed-on: https://chromium-review.googlesource.com/894299Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#533195}
-
