- 02 Nov, 2019 40 commits
-
-
Chen-Yu Tsai authored
Chromium coding style dictates that one should not use auto to deduce a raw pointer. ChromeOS builds are unaffected, but attempts to build media/gpu/v4l2 for desktop Linux will result in an error from the style check plugin: ../../media/gpu/v4l2/v4l2_device.cc:377:3: error: [chromium-style] auto variable type must not deduce to a raw pointer type. const auto& planes = v4l2_buffer_.m.planes; ^~~~~~~~~~~ auto* const This is part of ongoing work to make V4L2 usable on desktop Linux. It is currently untestable without a lot of other changes. The type of `plane` before and after the change are the same, found using the non-implemented template method [1] which shows the actual type in the compile error. In the meantime it doesn't break ChromeOS builds either. [1] https://stackoverflow.com/a/38820784 Test: build media_unittests simplechrome (chromeos-amd64-generic-rel) Change-Id: I5d760babc92ff101d8b75aa208cd875259b6e556 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895311Reviewed-by:
Kuang-che Wu <kcwu@chromium.org> Commit-Queue: Kuang-che Wu <kcwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#711989}
-
Ian Kilpatrick authored
This fixes the painting of table-cell backgrounds to paint in the appropriate rect. As the position of the table cells aren't sub-pixel aware (yet) we were painting the background with the incorrect size, resulting in a the table background bleeding through. I suspect TablesNG won't have this issue (and won't need to use this alternate constructor) as their position should be sub-pixel aware. Bug: 988015 Change-Id: I4135070608f958a71aa7a843c4e11904323125bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896049 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#711988}
-
Miyoung Shin authored
This CL converts MediaDrmStorage{Ptr, Request} in android_webview, chrome, chromecast components and media to the new Mojo type. Bug: 955171 Change-Id: I3a8eb5bd33128659fd09804368e96afb08ce03c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871695 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#711987}
-
Leon Han authored
This CL updates the definition of the union type NDEFMessageSource: (DOMString or ArrayBuffer or NDEFMessageInit) ==> (DOMString or BufferSource or NDEFMessageInit) BUG=520391 Change-Id: I603616047814c56744eed94efd7f3579079b0875 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886351Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Leon Han <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#711986}
-
Justin Cohen authored
Due to some security workarounds inside ios/web, sometimes a restored webState may mark new navigations as renderer initiated instead of browser initiated. This is somewhat an edge case, but it will manifest as the omnibox not updated until the new webState commits. As these navigations are uncommitted, and make the omnibox (or NTP) look strange, simply drop them. See crbug.com/1010765 for the relevant security bug. Bug: 1020497 Change-Id: I3fbc80bf1671654989f38b92a874e20631ff6ae6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894470 Commit-Queue: Justin Cohen <justincohen@chromium.org> Auto-Submit: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#711985}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ib8f9ec8fdb18120376d9b1ae257f4707d328329a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896536Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#711984}
-
Nektarios Paisios authored
This patch changes the way that CreateNext/PreviousCharacterPosition work so that they don't move by a single UTF16 code point but, similar to how the left / right cursor keys work, by a grapheme cluster. A grapheme cluster is what a person familiar with a particular language would call a single character. For example, it could include a UTF16 code point for a letter and more UTF16 code points for diacritics, or it could include a surrogate pair for characters outside the basic multilingual plain. This patch also disallows creating text positions that are not at a grapheme cluster boundary, so that text positions can never point in the middle of a character such as at a low surrogate pair. To avoid introducing performance regressions, this patch caches the inner text of the position's anchor node, after it has been retrieved for the first time. The break iterator is also cached. An upcoming patch will ensure that AXPositions are invalidated when the AXTree changes. This has always been the case, but the upcoming patch will ensure that this is captured and enforced in code too, especially now that AXPosition includes a handful of cached members. Furthermore, I took the opportunity to correct the copy constructors which cannot be defaulted since AXTreeID is non-copiable and improve the assignment operator using the copy and swap idiom. R=dmazzoni@chromium.org, kbabbitt@microsoft.com Change-Id: Iba12e0d214cd0d4a604597f9bb17a1a78992584f Bug: 720370 Change-Id: Iba12e0d214cd0d4a604597f9bb17a1a78992584f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796047Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#711983}
-
Dan Beam authored
Bug: 1020450 Change-Id: I8216b7dc529d40a9766b2007cc3609f9dfb2c1c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896306Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#711982}
-
Emily Stark authored
LoginTabHelper::DidFinishNavigation is responsible for observing when a navigation that challenges for HTTP auth commits, and showing the login prompt on top of it. This navigation failed to exclude subframe or same-document navigations, meaning that after an HTTP auth prompt triggered by a subframe was cancelled, we'd re-show another auth prompt on top of it. Bug: 1019969 Change-Id: Icef1544b8656d885eae593339fe50107e8e6f585 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890733 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#711981}
-
chromium-autoroll authored
Roll airmont AFDO profile from 80-3940.0-1572260209-benchmark-80.0.3951.3-r1 to 80-3940.0-1572260209-benchmark-80.0.3954.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_EXTRA_TRYBOTS= TBR=c-compiler-chrome@google.com Change-Id: Iacfd7a9f6ba88e58177f8edf2d3e2dc59ba03ad1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896194Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#711980}
-
Matt Reynolds authored
IsConnectedToHidDevice returns true if any frame in the WebContents is connected to a HID device. This will enable a tab indicator icon to be displayed when a tab has an open HID connection. HidService monitors the number of open HID connections for a frame and notifies WebContentsImpl when the count transitions between zero and one. BUG=1007539 Change-Id: I4b7020af97bcb50e2b26e5865519bcd5f77c63a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823727Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#711979}
-
Rakib M. Hasan authored
This CL will remove the TEXT, IMAGE, IMAGE+TEXT, AUDIO, LEAK, WONTFIX, MISSING results from the JSON results and test expectations of web tests. The above results except for WONTFIX will be replaced by FAIL, and WONTFIX will be replaced by SKIP. This CL will also update the results viewer so that it looks at the per test field's artifacts dictionary in the JSON results to decide which web tests specific failure a test has. It will also update the rebaseline tool to look at the artifacts dictionary to find out if a test has a mismatch failure or is missing a baseline. Bug: chromium:1014196 Change-Id: Id7ec570fa4ad86b510aa333da853b81687267b82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879970 Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#711978}
-
chromium-autoroll authored
Roll silvermont AFDO profile from 80-3940.0-1572255699-benchmark-80.0.3951.3-r1 to 80-3940.0-1572255699-benchmark-80.0.3954.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_EXTRA_TRYBOTS= TBR=c-compiler-chrome@google.com Change-Id: I7669ff2ea3404399a671f282f2faea13d38bcb84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895089Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#711977}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=benmason@chromium.org Change-Id: Ib3dd093c1d8851adc6fcbe4c969be3cc2ab50acf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895902Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#711976}
-
Sven Zheng authored
Do not allow retry or it will break the bulk approval process. Bug: 958242 Change-Id: Ief5ab98d1ca398ce5a56d0d4532813e815724bae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895880 Commit-Queue: Sven Zheng <svenzheng@chromium.org> Auto-Submit: Sven Zheng <svenzheng@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#711975}
-
Takumi Fujimoto authored
Rename MediaNotificationItem to MediaSessionNotificationItem, and create a MediaNotificationItem interface, which will be implemented by CastMediaNotificationItem in a later patch to show Cast sessions in the Global Media Controls. TBR=beccahughes@chromium.org Bug: 987479 Change-Id: Ibeffa9d0f641850207dd0402337654381d859c4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894414Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#711974}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/4d17287a4eae..8580510f117a git log 4d17287a4eae..8580510f117a --date=short --no-merges --format='%ad %ae %s' 2019-11-01 bpastene@chromium.org vm: Enable nested VMX in VMs if the host supports it. Created with: gclient setdep -r src/third_party/chromite@8580510f117a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Iab48ec709dd74c42eea6f833931658d0ecced114 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895950Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#711973}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 71fd9c32. With Chromium commits locally applied on WPT: 1d5b803f "Add WebVTT support for inline styling - Web Platform Tests" 9be931cb "[WPT/common/security-features] Refactor navigable tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: eroman@chromium.org, rsleevi@chromium.org: external/wpt/WebCryptoAPI NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I3e0e7ee02bd17567e9f2516bedd8dc34ad33fc8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895402Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#711972}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: If313dcd6de1474e5dcfa6b62009b8c5e00eb6a2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895921Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#711971}
-
Donn Denman authored
This default-enables usage of the Chrome Language Model experiment for Contextual Search. BUG=644909 Change-Id: I454840899229dd5b9ee113c53d1b3736a7662c17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890962 Commit-Queue: Donn Denman <donnd@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Auto-Submit: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#711970}
-
Bo Liu authored
Wait for first contentful paint will ensure the page is ready to accept touch events. This deflates fullscreen tests which relies on this. Double the timeout allowed for loading, which is approaching the limit on slow devices like nexus 5. Change fullscreen polling to be on the UI thread. Bug: 1019948 Change-Id: Ie04408d15904054f4a462a0a11c6a126fcb11a9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895757 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#711969}
-
dpapad authored
- Remove what seems to be unnecessary hardcoded paths from settings-animated-pages. - Fix usage of |focusConfig| mechanism from os-settings-languages-page. Before this CL, os-settings-languages-page was not using the correct |focusConfig| instance. Bug: 1003992 Change-Id: I17dc56115f166b4e862d8a2ec7e0d41388902dfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894748Reviewed-by:
Jordy Greenblatt <jordynass@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#711968}
-
Evan Stade authored
The profile can be null in the case of "system" notifications. Bug: 1020555 Change-Id: I80d65c74d4534ed15ffec43c582584fb54559d4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895378Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#711967}
-
Dana Fried authored
Exactly what it says on the tin. This is a fix for legacy layouts (fill, box, grid) which aren't derived from LayoutManagerBase and which do not benefit from the logic in that class which handles the invalidation. LayoutManagerBase still overrides this logic with something more sophisticated. If in the future a legacy layout overrides ViewVisibilitySet(), it should either call the base implementation or handle the invalidation on its own. Bug: 1003500 Change-Id: I9eccef21784175820816852e1b9c05d0713ef2eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894260 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#711966}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/aadf1619..b3cc49df Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Icb00fdd967ed46148a5c624f18d1e6de513acf34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895400Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#711965}
-
Dale Curtis authored
Skia added support for these recently, so lets expose them in gfx::ColorSpace. This will allow us to correct our YUV conversions for BT.2020 content in GpuMemoryBuffer upload and PaintCanvasVideoRenderer. BUG=960620 TEST=unittests pass R=ccameron Change-Id: I6a659de0da7f21070857b855796d65bdce227a2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894770 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#711964}
-
Brian Geffon authored
On ChromeOS we have a kernel memory change which allows us to fix the amount of page cache is available. This is primarily used to try to keep the browser process resident while under memory pressure to avoid user jank. This feature/experiment will compare the performance of locking the browser text directly while also lowering the min_filelist_kb kernel tunable from https://crrev.com/c/1880966 For more context see go/min_filelist_kb BUG=chromium:1014871 TESTED=On a betty image Change-Id: I8fe9b3fd71b26c95097c71f42d6b2200ececbecc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885298Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Reviewed-by:
George Burgess <gbiv@chromium.org> Commit-Queue: Brian Geffon <bgeffon@chromium.org> Cr-Commit-Position: refs/heads/master@{#711963}
-
Bettina authored
Adding field trial entry for sending sampled pings for allowlist domains to Safe Browsing. Bug: 953106 Change-Id: Ifdcbf0d80a026667f7f78a39e7123fdc39d76ba8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894247 Commit-Queue: Bettina Dea <bdea@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#711962}
-
Miyoung Shin authored
This CL converts CastApplicationMediaInfoManager{Ptr, Request} in chromecast to the new Mojo type Bug: 955171 Change-Id: I3b60c6e76e166ede239df86359959a4523f60d75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871879 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#711961}
-
Wez authored
Memory is implicitly allocated/deallocated in response to mmap() and munmap() calls when working with MAP_ANONYMOUS mmaps. Fuchsia's Zircon kernel separates reservation of address space through Virtual Memory Address Ranges (VMARs) from allocation of pages through Virtual Memory Objects (VMOs). This implementation creates and maps a new VMO for each call to SystemAllocPagesInternal(). Each of these VMOs has is named based on the PageTag of the subsystem (e.g. V8, Blink) making the allocation, making it easier to identify which subsystems are consuming memory. DecommitSystemPagesInternal() will be implemented once Fuchsia provides the vmar_op_range(DECOMMIT) API. Bug: 927411 Change-Id: Ie7966f9dcf487e308326e940ca3941c0f87487f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859677Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#711960}
-
Dan Beam authored
Keep it white in light mode. Fixed: 1019120 Change-Id: I232652f3784ed4151eff4f1a8a69f5799dc5010b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895944 Commit-Queue: Dan Beam <dbeam@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#711959}
-
Gary Kacmarcik authored
CL landed before I uploaded the changes from the review comments. This cl contains those mods. Change-Id: Iab52d890798053fde11f63f1c08aa7ed8709f85c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895920 Auto-Submit: Gary Kacmarcik <garykac@chromium.org> Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#711958}
-
Toni Barzic authored
Inset app list main view bounds horixontally by shelf size when displaying app list with side shelf (to ensure app list content does not overlap with shelf). BUG=1020534 Change-Id: I2cbec885ad2c7c0095f77d1909f9f219020ac63f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895782 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#711957}
-
Julie Jeongeun Kim authored
This CL converts VideoEncodeAccelerator to new Mojo types using PendingReceiver, PendingRemote, Remote and SelfOwnedReceiver. Bug: 955171 Change-Id: I2b8acd2c1e9e2f033679d5574a183a3067e0ae8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886281Reviewed-by:
Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#711956}
-
Ken Rockot authored
This converts remaining users to the new DataDecoder API which does not depend on Service Manager. Bug: 977637 Change-Id: Iaaa102f28ff63256a4c2090b6d6837085bb56103 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892125 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#711955}
-
Yun Liu authored
Bug: 985581 Change-Id: I51700b131ff79f33dfc8ba5b19abe798d7bd6139 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895884Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Yun Liu <yliuyliu@google.com> Cr-Commit-Position: refs/heads/master@{#711954}
-
Gyuyoung Kim authored
This CL converts remained old Mojo types of InterfaceFactory interface to new Mojo types. Major changes are as below, - Convert mojom::InterfaceFactoryPtr to mojo::PendingRemote|Remote<mojom::InterfaceFactory> - Convert mojo::InterfaceFactoryRequest to mojo::PendingReceiver<mojom::InterfaceFactory> - Convert mojo::Binding to mojo::Receiver Bug: 955171 Change-Id: I76bc67227ce76897ae321e23dd58932f0e2f88c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893600 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#711953}
-
Peter Boström authored
These strings aren't necessarily final but are probably closer to what we want. Putting these in so that we can get a better feel for them. Bug: chromium:943702 Change-Id: I2a003a8f85c87d3e3c3a15e1283be7cc9ea5ad7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894769 Commit-Queue: Peter Boström <pbos@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Auto-Submit: Peter Boström <pbos@chromium.org> Reviewed-by:
Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#711952}
-
Sinan Sahin authored
On Android L, the tint we set to the EditText's background (line under the text field) wouldn't get cleared after leaving the activity. Turns out this is a known issue. So, we used a workaround found in Android TextInputLayout code. The workaround above also fixes an issue on KitKat where tinting the background wouldn't work at all. Bug: 1020077 Change-Id: I6fe5886ff5959a983dae43851ffcdca29b0d50a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895073 Commit-Queue: Sinan Sahin <sinansahin@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#711951}
-
Daniel Hosseinian authored
The tests that validate the 'getPrinters' and 'getPrinterCapabilities' Web UI calls contain lines of code that can be used again once more tests are added. Remove some deprecated base::ListValue from tests. Bug: 487875 Change-Id: Ic49fc6b62ba44b3a548f026d68162446a852998e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893974 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#711950}
-