- 28 Jan, 2020 40 commits
-
-
Martin Šrámek authored
This enum must be kept in sync with the histogram of the same name in resources/settings/metrics_browser_proxy.js, but it's currently not. This causes a DCHECK when settings attempt to record this value. Bug: None Change-Id: If04dc1d3852854a02659d9bd056f10eafe80b8ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025668Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Commit-Queue: Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#736099}
-
Bailey Berro authored
This change extendes the life of the ShowTaskManager histogram through M85 and updates the owner to zentaro@. Bug: 1036944 Change-Id: If6d48d26771a003a3c8a9cca9a68b46b4fc58c25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992203 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Auto-Submit: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#736098}
-
kylechar authored
SkiaOutputSurfaceImplOnGpu needs to make the GL context current before asking skia to check readback completion. Also avoid checking for completion if there are no readback requests pending and immediately after issuing the async request. Bug: 1040643 Change-Id: Ia78363c476dc697ce35dce24fab881e2a60c264e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025644Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#736097}
-
Greg Kerr authored
This adds a new command line value (to the --scheduler-configuration flag) so that Chrome can be configured to allow SMT by default on certain chipsets. The new command line flag value is added so that session_manager, which knows the board and chipset, can configure Chrome to allow SMT by default on certain hardware. Users and admins can still override this with their own policy. BUG=b:147685035 Change-Id: I75f034e6c0a47f7e1ce71d5f7514f7945b71ceac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008609Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Commit-Queue: Greg Kerr <kerrnel@chromium.org> Auto-Submit: Greg Kerr <kerrnel@chromium.org> Cr-Commit-Position: refs/heads/master@{#736096}
-
Wez authored
Bug: 829551 Change-Id: I0461ced34730e216a0d4a64383448c0008f36ad5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020772 Commit-Queue: Wez <wez@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org> Auto-Submit: Wez <wez@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#736095}
-
chromium-autoroll authored
Roll broadwell AFDO profile from 81-3987.39-1579516543-benchmark-81.0.4019.0-r1 to 81-4025.0-1580122052-benchmark-81.0.4019.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I908bfa68eb8cdecf3561cde0199bee99c0b21ffe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026018Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736094}
-
David Benjamin authored
If DoLoop() returned synchronously in ReadBufferingStreamSocket::ReadIfReady(), the data was never copied to the user buffer and we return zero. Instead, pull copying out of DoLoop(), which is now only responsible for filling the internal read_buffer_. The caller then handles the output portions. This bug has been there since we introduced ReadIfReady, but probably SpawnedTestServer was too slow to ever trigger this race condition. Now it uses EmbeddedTestServer which is faster. Bug: 1021109 Change-Id: I829d22e96de356679501dd175b5549296503b5de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023478 Auto-Submit: David Benjamin <davidben@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#736093}
-
Luum Habtemariam authored
Per bug below, this change adds the Printing.CUPS.InvalidPpdResolved metric to follow this issue as its resolved. Bug: chromium:1046125 Test: updated sync test passes Change-Id: Idc4c633d2859096e80de8c7648a34112fc96d87f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015832 Commit-Queue: Luum Habtemariam <luum@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#736092}
-
Chan Li authored
This reverts commit 43fcd55d. Reason for revert: Suspecting this change caused the compile failure at https://cr-buildbucket.appspot.com/build/8889983375245058816. Original change's description: > [Android] don't map zh-hk to zh-tw in bundle builds. > > To give Clank language parity with Android 27 new locales are being > added. 26 of those locales have been added in two previous CLs: > > - https://crrev.com/c/1941058 > - https://crrev.com/c/1952288 > > zh-hk was skipped because currently resources for it are mapped to > zh-tw. This CL skips that mapping for bundle builds where zh-hk is > now included. zh-hk is still mapped to zh-tw in apk builds. > > There is an increase in size even when language splits are used in > bundles. A bug has been created to look into this: > - APK Bundles wastes a lot of space in resources.arsc (400kb) > - https://crbug.com/1031645 > > Bug: 1034774 > Binary-Size: Size increase is unavoidable (see above). > Change-Id: I4edb9d5213e8dd3443522deee5395e500af34371 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970258 > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Reviewed-by: (gone) Eric Stevenson <estevenson@chromium.org> > Commit-Queue: Trevor Perrier <perrier@chromium.org> > Cr-Commit-Position: refs/heads/master@{#736071} TBR=yfriedman@chromium.org,tedchoc@chromium.org,agrieve@chromium.org,estevenson@chromium.org,perrier@chromium.org Change-Id: I6748ad1e997bb5e2e05d6a99a52fd3e3595253fd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1034774 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026151Reviewed-by:
Chan Li <chanli@chromium.org> Commit-Queue: Chan Li <chanli@chromium.org> Cr-Commit-Position: refs/heads/master@{#736091}
-
kylechar authored
This reverts commit 61bb69af. Reason for revert: Removing debug instrumentation before branch. Original change's description: > Add debug BeginFrame tracking > > Add some temporary member variables to BeginFrameTracker that stores the > total sent/received and the last 10 sent/received BeginFrameIds. Despite > adding logic to stop sending OnBeginFrame() to unresponsive clients it > didn't help with the large number of unread messages in mojo message > queue. This information will do a better job of verifying if client is > in fact reading (and responding to) the OnBeginFrame() messages. > > The |begin_frame_tracker_| is included in a few minidumps I looked at > it, so this information should be available in crash reports. Otherwise > we'll have to copy the information into the stack in OnBeginFrame(). > > Bug: 1011441 > Change-Id: I44112d933fb4470fb037e7bfd2d9dc05dd826a94 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994093 > Reviewed-by: Saman Sami <samans@chromium.org> > Commit-Queue: kylechar <kylechar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#730310} TBR=kylechar@chromium.org,samans@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1011441 Change-Id: I3c7d5572c19ede7d653d24175d7023e7a7e282c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025768Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#736090}
-
Alex Turner authored
Adds the --record-histogram benchmark command line argument to the ad_tagging.cluster_telemetry benchmark. This allows for specifying additional UMA histograms to record without generating a patch. Bug: 1046108 Change-Id: I95a4d1bc2e5bda91e5147a0cfd65999baca5bf43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025530Reviewed-by:
John Delaney <johnidel@chromium.org> Commit-Queue: Alex Turner <alexmt@chromium.org> Cr-Commit-Position: refs/heads/master@{#736089}
-
Alex Turner authored
The current PercentAds/PercentAds2 metrics only consider resources in ad frames and are not recorded for pages with no ad frames. These are renamed to PercentAdFrames to make their definition clearer. We add the PageLoad.Clients.Ads.AllPages.PercentNetworkBytes and PageLoad.Clients.Ads.AllPages.PercentTotalBytes histograms, which are logged for all page loads with non-zero bytes and which includes all ad resources in its calculation. They will be used as overall metrics for tracking filter list accuracy. Currently, the metric used is a percentage of aggregate bytes across various page loads. The new metrics will be less affected by outliers as each page's influence on the average percentage will be the same, rather than weighted by number of bytes. Bug: 1045120 Change-Id: I59beccbcf96394d584ddc6293e7d0c7f379892bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018162Reviewed-by:
-
Daniel Rubery authored
To accommodate a possible need to separate these handlers on the backend, Chrome will send APP deep scans to a different URL than WebProtect deep scans. Bug: 1020418 Change-Id: Icf859f1d746118a16de1677e74e27bf50593a37d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024697Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#736087}
-
Thomas Lukaszewicz authored
Fixed a bug where boundary calculations used to determine whether a tab belongs to a given tab strip were not taking into account RTL mode. TabDragContext now specifies both a begin and end x coordinate to use for bounds checking. Bug: 1044868 Change-Id: I6f73f681605f202e189356a6cb917f2522cecbdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024492 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#736086}
-
David Bokan authored
Change-Id: I3d894ec6faeef8b1d7243bb2721fe66b58c4ace8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023522 Commit-Queue: David Bokan <bokan@chromium.org> Auto-Submit: David Bokan <bokan@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#736085}
-
Reilly Grant authored
These metrics are being used to track the results of an experiment to use the new ISensor API on Windows 10 clients. This should launch to 100% in M-81 or M-82. Bug: 1036868 Change-Id: If5842f698e812b345065aa711ccd09483b4b616b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024544 Auto-Submit: Reilly Grant <reillyg@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
-
Findit authored
This reverts commit d5274dbb. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 735947 as the culprit for flakes in the build cycles as shown on: https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vZDUyNzRkYmI0OGZlMDU2ZGRmNmFlMWNmZjQ2YjQ3OTVkNTU1NDFmOQw Sample Failed Build: https://ci.chromium.org/b/8889996165162517568 Sample Failed Step: browser_tests Sample Flaky Test: SecurityTokenSamlTest.Basic Original change's description: > Reland Add browser tests for smart card SAML login > > This relands the commit 8fd76b23 that > got reverted in commit 319c9b41 due to > failing on official trybots. > > The fix in the reland is to suppress the sync consent screen that is > normally enabled on the "branded" builds and that was breaking test > expectations (the test expected the user session to start straight away > after the successful authentication without any extra screens). > > Original change's description: > > Add browser tests for smart card SAML login > > > > Provide test coverage for the scenario where a new user authenticates > > via SAML using a smart card (or, generally speaking, using a security > > token via an extension using the chrome.certificateProvider API). > > > > This also provides some test coverage for the <security-token-pin> > > Polymer element used on the Login Screen. > > > > Bug: 1033936 > > Change-Id: I5ded32e0570eb7227c77b954c33d12c1a8a62914 > > Reviewed-on: > https://chromium-review.googlesource.com/c/chromium/src/+/1968989 > > Reviewed-by: Alexander Alekseev <alemate@chromium.org> > > Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org> > > Reviewed-by: Alexander Hendrich <hendrich@chromium.org> > > Commit-Queue: Maksim Ivanov <emaxx@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#734510} > > Bug: 1033936 > Tbr: alemate@chromium.org, hendrich@chromium.org > Test: run the test locally with is_chrome_branded=true > Change-Id: I0e8394bb78030137c7570d58c2462a773c13ce06 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017430 > Commit-Queue: Maksim Ivanov <emaxx@chromium.org> > Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org> > Cr-Commit-Position: refs/heads/master@{#735947} Change-Id: Ifc621efff2f069cd90b25f9fff6d778a6732c2c3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1033936 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025885 Cr-Commit-Position: refs/heads/master@{#736083}
-
Ian Kilpatrick authored
Previously if a fragment didn't provide a baseline, and had baseline alignment we wouldn't consider it as having the default baseline. This was incorrect. Causing fast/css-grid-layout/grid-baseline.html to fail when FlexNG was turned on: https://test-results.appspot.com/data/layout_results/linux-rel/294412/webkit_layout_tests%20%28with%20patch%29/layout-test-results/results.html Instead this patch changes the flex baseline propagation logic to prefer any flex-item with baseline alignment, even if we have to synthesize the baseline. Bug: 845235 Change-Id: I4cc40da42a8d6be41b028f1170246b8004f0654d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024546Reviewed-by:
David Grogan <dgrogan@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#736082}
-
yjliu authored
Bug: N/A Change-Id: Ia15dc301bbf8b91383b50528b006495a56b8236a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024069 Auto-Submit: Jun Liu <yjliu@chromium.org> Commit-Queue: weiliangc <weiliangc@chromium.org> Reviewed-by:
weiliangc <weiliangc@chromium.org> Cr-Commit-Position: refs/heads/master@{#736081}
-
Olivier Li authored
This class is a successor to ThreadWatcher which aims to be more versatile and provide a larger coverage for hang watching. Bug: 1034046 Change-Id: I365fe8824eb34c37c75e6ddf6874ff26ecd494c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008189 Commit-Queue: Oliver Li <olivierli@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#736080}
-
nancy authored
Check whether extensions::ContextMenuMatcher commands are enabled in AppServiceContextMenu, which is the current implementation: https://cs.chromium.org/chromium/src/chrome/browser/ui/app_list/extension_app_context_menu.cc?l=167 Also update set LaunchType command to add SetAppUserDisplayMode function for Web apps when kDesktopPWAsWithoutExtensions is enabled: https://cs.chromium.org/chromium/src/chrome/browser/ui/app_list/web_app_context_menu.cc?l=131 BUG=1038487 Change-Id: Ib8e6582313938dca6291aabbc872a094e4a994bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025010Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#736079}
-
Kyle Milka authored
Apply the standard mode tint to first party sharing features in the sharing hub. This ensures they display correctly in dark mode. Bug: 1009124 Change-Id: I9e3fd8f8fc59853ce0d46ebc512d85d5cfdf6f64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020404 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#736078}
-
Robert Ogden authored
Checks in two separate places, the TabHelper and the URLLoaderInterceptor. Bug: 1023486 Change-Id: I93e5775f700e6da0852c4a956f0893b40b5808d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024494Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#736077}
-
Manu Cornet authored
Change-Id: I42931af323cbfbd4da06eeb11c93cc06258ba74d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025467 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#736076}
-
Andrew Xu authored
Now the calculation on the area of the gradient zone relies on the location of arrow buttons. Actually the area can also be computed with the visible space, which is more concise and readable. This CL should not bring any noticeable difference to UI. It helps the landing of the following CLs on fading in arrow buttons. Bug: 1026957 Change-Id: I9ab34c56a0a0e233a9d633e2aee873b7e070985d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021322 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
-
nancy authored
This is the preparing for CL:2022585. The function GetCommandIdVectorIcon will be used by AppServiceShelfContextMenu. BUG=1038487 Change-Id: Ib1d67bbbf5482c752a82f3d85659246515e7b24b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025009Reviewed-by:
-
Hiroshige Hayashizaki authored
This CL also removes unnecessary testlib/testlib.js. Bug: 1045479, https://github.com/whatwg/html/issues/3890 Change-Id: I59709cdfd33ba1be18d2aab3393daffb83ce8f22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663585 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Reviewed-by:
Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/master@{#736073}
-
Lijin Shen authored
Disable share button when tab is null. Otherwise, clicking on share button may cause crash. Bug: 1028893 Change-Id: I59ef6cef96cb2e12175cd673993603a496837a3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023403Reviewed-by:
-
Trevor Perrier authored
To give Clank language parity with Android 27 new locales are being added. 26 of those locales have been added in two previous CLs: - https://crrev.com/c/1941058 - https://crrev.com/c/1952288 zh-hk was skipped because currently resources for it are mapped to zh-tw. This CL skips that mapping for bundle builds where zh-hk is now included. zh-hk is still mapped to zh-tw in apk builds. There is an increase in size even when language splits are used in bundles. A bug has been created to look into this: - APK Bundles wastes a lot of space in resources.arsc (400kb) - https://crbug.com/1031645 Bug: 1034774 Binary-Size: Size increase is unavoidable (see above). Change-Id: I4edb9d5213e8dd3443522deee5395e500af34371 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970258Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
(gone) Eric Stevenson <estevenson@chromium.org> Commit-Queue: Trevor Perrier <perrier@chromium.org> Cr-Commit-Position: refs/heads/master@{#736071}
-
Jonah Ryan-Davis authored
Based on glXGetMscRateOML from GLX_OML_sync_control. Bug: chromium:1042393 Change-Id: I1cf2fd43aad041b157dc2f26104ff80b10056ca2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015684 Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#736070}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b52c8dc280ff..e6148d3266a2 Created with: gclient setdep -r src-internal@e6148d3266a2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:927262 Tbr: jbudorick@google.com Change-Id: I38815d1884bf6fdceecad0302605bde6c493ba05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025637Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736069}
-
Jonah Chin authored
This CL encompasses 3 changes that are in preparation of the OOP-R Canvas change: 1. With OOP-R Canvas we need the ability to validate clip stack on canvas' other than the drawing canvas. This change updates ValidateStateStack to accept the canvas that needs to be validated. 2. RestoreBackBuffer() added to CanvasResourceProvider(). In the future, Canvas2DLayerBridge won't have access to the backing Skia canvas in the resource provider. This change pulls functionality that relies on the Skia canvas out of the Canvas2DLayerBridge and puts it in the CanvasResourceProvider. 3. Removed initial save on Skia canvas. With Deferral Always On, the Skia canvas is only used to rasterize RecordPaintCanvas' and RecordPaintCanvas tracks the current clip stack. With this change, during Canvas2DLayerBridge::WritePixels() (or equivalent), ValidateStateStackWithCanvas() inside RestoreMatrixClipStack validates the clip stack on the Skia canvas. The initial save was resulting in a mismatch with the count of saves from the BaseRenderingContext2D. This came from PaintCanvasAutoRestore() inside Canvas2DLayerBridge::WritePixels() pushing an additional save. Bug: 1019288 Change-Id: Ib134f600721a3d0acc2f7123a1ee1c798f6b9e81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006648Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Jonah Chin <jochin@microsoft.com> Cr-Commit-Position: refs/heads/master@{#736068}
-
ssid authored
The tracing metrics provider now directly calls the field trials provider to get the field trial data. This doesn't scale well for additional system profile providers, but as we don't want to automatically include the full system profile in all independent metrics and we don't currently have a way of selectively including this, for now we manually populate the field trials data Change-Id: I6397f6500470d719987e54f9c038f50daad58556 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024162 Commit-Queue: ssid <ssid@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#736067}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/89e678dea268..f03c11602172 git log 89e678dea268..f03c11602172 --date=short --first-parent --format='%ad %ae %s' 2020-01-28 senorblanco@chromium.org Roll dawn and adjust for new SwapChain API. 2020-01-28 bsalomon@google.com Add fallback for asyncRescaleAndReadPixelsYUV420 without PBOs. 2020-01-28 reed@google.com Experimental coretext backend for SkShaper Created with: gclient setdep -r src/third_party/skia@f03c11602172 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: reed@google.com Change-Id: I701a9d603fb8f894a20c8e56d8076ad8cf91cbf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025630Reviewed-by:
-
Saman Sami authored
Plumb mailbox for the primary plane to OverlayProcessorOzone and use SharedImageInterface to obtain the corresponding NativePixmap. Bug: 756454 Change-Id: Ic537d05253bc68c27a8fed961de8547ace359e82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016327Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#736065}
-
Erik Staab authored
Bug: 1042819 Change-Id: If9dc84c5a7c5da5e1597b8ae030cab43ea269cdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006139Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#736064}
-
Aga Wronska authored
This code is used since 2014 and it should not be considered experimental. Bug: b/145953755 Change-Id: If378a9c93edbc33d50d93b0ae9bb86ad19db1057 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003573Reviewed-by:
Yilkal Abe <yilkal@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#736063}
-
Luke Zielinski authored
TBR=robertma Change-Id: Ib95daef5df9daed0114e72b41c36a84586c5e7c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025867Reviewed-by:
Luke Z <lpz@chromium.org> Commit-Queue: Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#736062}
-
Wez authored
This test was disabled on Fuchsia due to flakiness, but is also extremely flaky on Linux, suggesting a more general cross-platform raciness or timing issue. TBR=falken Bug: 1029434 Change-Id: I02969efdb4e318a46c47fe292e63c5a7129946cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025707Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#736061}
-
John Lee authored
This CL sets up the ability to drag a tab from one WebUI tab strip and drop it into another WebUI tab strip. The CL currently only places the dropped tab to the end of the tab strip, and does not set the index or the pinned state of the tab. Future CLs will handle the UI for dropping a tab specifically into place, and visually differentiating the drops that are allowed and disallowed. This implementation currently still uses the Extensions API for moving tabs between windows, and the Extensions API already checks to make sure the tab can be legally moved, taking into account multiple profiles and incognito windows. Bug: 1005560 Change-Id: I7da09a561144d911660f068f76919efe72f3638a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020609 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#736060}
-
