- 15 Apr, 2020 40 commits
-
-
Alexander Cooper authored
Describes the source of the two static_initializers so that anyone who adds a new one can more easily diagnose which is theirs. This is especially useful when the new static initializer may come from a lib or other such code being linked in that the developer may not be familiar with. Change-Id: Ibaecb74f66f87d83bc5140ba7ed281399e56e95b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150057 Auto-Submit: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#759358}
-
Sinan Sahin authored
After switching themes (dark/light), the ConnectivityDetector instance would not be destroyed since it's added as an observer to the NetworkChangeNotifier singleton. This was keeping a lot of objects around and causing invalid status indicator instances to access a null activity reference through a lambda created in TabbedRootUiCoordinator. This CL adds a #destroy method to ConnectivityDetector and a call to it from OfflineIndicatorControllerV2#destroy(). Bug: 1070386 Change-Id: Iee7a9cb913fa8aa62960f602e6f45242e0cc60e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150026Reviewed-by:
Jian Li <jianli@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#759357}
-
David Tseng authored
This change fixes a case where Googletts, running in split mode, would not have both extensions kept alive. In particular, when running in the login session, Googletts would be loaded into both the off the record and non-otr profiles. The otr profile gets all tts extension api calls, but the extension system calls OnExtensionLoaded with the non-otr BrowserContext. Fix this by explicitly looking for an associated otr profile and modifying the keep alive count for Googletts there accordingly. Test: manually test on: - login session - guest session - normal session R=dmazzoni@chromium.org - flip on ChromeVox; wait for > 20 seconds. Trigger speech. Verify that speech comes immediately (aka tts kept alive) - flip off ChromeVox; wait > 20 seconds. Verify that flipping back on ChromeVox incurs a delay in speech response. Also, inspecting Chrome, verify tts is actually not loaded. Do: Change-Id: I93bc68d058017e3722c486dbb1848fac94ddca3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147014Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#759356}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/60af4efbe0e2..9ac89e3e1842 git log 60af4efbe0e2..9ac89e3e1842 --date=short --first-parent --format='%ad %ae %s' 2020-04-15 skyostil@google.com TrackEvent: Detect incorrect use of dynamic event names Created with: gclient setdep -r src/third_party/perfetto@9ac89e3e1842 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:148779455 Tbr: perfetto-bugs@google.com Change-Id: I8f059848d3e0688017ca0cf629d25c5f83d15900 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149944Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759355}
-
Mark Schillaci authored
This CL relands AccessibilityEvent throttling on Android. Original CL: http://crrev.com/c/2067443 Revert: http://crrev.com/c/2132927 This change was reverted to prevent regression before M83 was cut, but with this CL it will be relanded along with the improvements added here. This CL improves the throttling logic by separating it from the WebContentsAccessibilityImpl into it's own class, which we have called AccessibilityEventDispatcher. Whenever the WCAI wishes to send an event, it sends it to the dispatcher. The dispatcher can then act as a pass-through, throttle the event, discard the event, etc. as determined by preset rules that are opaque to the WebContentsAccessibilityImpl. This will make unit testing easier and allows us to make wholesale changes to our throttling without affecting implementations. This CL also adds an improvement by taking into account the |virtualViewId| of whatever node is trying to send an event. Until now we have relied solely on the eventType and ensured that no two events of the same type are sent in quick succession (if the eventType is one we are throttling). This creates an issue where two separate nodes with different |virtualViewId|'s can each request an event of some type to be sent, but only one will get through. We fix this problem by making our throttling check not just the eventType but also |virtualViewId|. This requires some sort of 2D structure, or a key of Pair or some wrapper object that will hold the two ints (|virtualViewId| and eventType). Here we use a long in place of a Pair, by bitshifting |virtualViewId| left 32 bits and doing a bitwise OR with eventType. This gives us a 64bit long that is essentially two int's concatenated in memory, which will be a unique id for a |virtualViewId|-eventType pairing. This CL also adds an improvement by allowing us to specify a delay time on a per eventType basis. Before this change we had a simple Set that contains a list of eventTypes to delay. We have now made this a map from eventType to delay time in ms, so that we can potentially delay different events by different amounts. Change-Id: I7431253a715cc712a81b1f6ac2b39d19e91daa8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139905Reviewed-by:
Mark Schillaci <mschillaci@google.com> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
-
Tina Wang authored
Ensure that the password saving behaves correct when the pref is unset, enabled and disabled. Bug: 1065143 Change-Id: I7e112f167008b01c903cea53f06958f6e0c10e1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136863 Commit-Queue: Tina Wang <tinazwang@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Guillaume Jenkins <gujen@google.com> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#759353}
-
Mugdha Lakhani authored
Previews/Lite Mode is a series of optimizations that Chrome may use to optimize webpages that load slowly. It is only enabled for Lite Mode users (see Settings > Lite Mode) which is only supported on Chrome Android. This is a Chrome-specific feature which WebLayer doesn't intend to support for now. The overlap with Page Info UI is that in lite mode/Previews, we change the security strings in the Page Info Dialog to convey that the page is a Google-served preview/lite version of the actual page. Moving this change to a Chrome-specific delegate implementation allows PageInfoController to not depend on this, and eventually be componentized for reuse by WebLayer. Bug: 1052375 Change-Id: Ice09ed10af2358c5a943fe6e05e15caa0533b185 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144015 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#759352}
-
Jeff Yoon authored
waterfall renamed to chrome.pgo Bug: 1059277 Change-Id: I3be24ce4c9d19132f6117a3a931bf9917bc3b64b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149951 Auto-Submit: Jeff Yoon <jeffyoon@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#759351}
-
Nikita Podguzov authored
This allows to reuse this function for all platforms. We'll need it in the follow-up CL with PrintingPaperSizeDefault policy. Bug: 1015690 Change-Id: Ibb5daa2958e88b376556f3374b88ab8457d08402 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144030Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Nikita Podguzov <nikitapodguzov@chromium.org> Cr-Commit-Position: refs/heads/master@{#759350}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/b2bcf0eb3a4d..f4308e08dc82 git log b2bcf0eb3a4d..f4308e08dc82 --date=short --first-parent --format='%ad %ae %s' 2020-04-15 rwkeane@google.com Discovery: Update contract between discovery layers Created with: gclient setdep -r src/third_party/openscreen/src@f4308e08dc82 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: Ia53f5ef5edcfe5de8b25b0c4f7645b4e67c2a660 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150845Reviewed-by:
-
Michael Thiessen authored
See additional context on the bugs. Before Q (or maybe earlier), window focus told you when your Activity was visible. With at least Q, onStart is now the correct indicator of visibility. Bug: 1053375, 1062286 Change-Id: Ie8c86b22e69e4625d27830daba7b899996df0364 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146286 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#759348}
-
Wan-Teh Chang authored
This requires the new libavif function avifDecoderNthImageTiming, which provides each frame's duration before the frames are decoded. Bug: 960620 Change-Id: Id00c760e094b8663b1a8781201fdd4a6c88beddd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149915 Commit-Queue: Wan-Teh Chang <wtc@google.com> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#759347}
-
Nikita Podguzov authored
Bug: 1061077 Change-Id: I7f455fd05962a41928f9a462fb97dbf6b692ec92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102328Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Nikita Podguzov <nikitapodguzov@chromium.org> Cr-Commit-Position: refs/heads/master@{#759346}
-
danakj authored
Convert pointers to WebTestDelegate into pointers to BlinkTestRunner. Change a few places that hold a pointer to TestInterfaces in order to get a (potentially changing over time...?) BlinkTestRunner to point to a BlinkTestRunner directly instead. We still grab the BlinkTestRunner off TestInterfaces for now though. R=avi@chromium.org TBR= Bug: 866140 Change-Id: Id1f336a7a178a8ec0b0f8a0b792ef9040c788d5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149506 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#759345}
-
Kyle Horimoto authored
This CL migrates multi-device UI strings to a per-page provider and adds TODOs for adding relevant search tags. Bug: 1069849 Change-Id: I7623883c0d44fcde2008d8ff3c9ca4640d37935b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150185Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#759344}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/094974dab674..2430d665d3f2 git log 094974dab674..2430d665d3f2 --date=short --first-parent --format='%ad %ae %s' 2020-04-15 amaiorano@google.com CMake: split out turbo-cov target 2020-04-15 amaiorano@google.com CMake: split out test and benchmark targets Created with: gclient setdep -r src/third_party/swiftshader@2430d665d3f2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Ic6fec60e2441df10adcfd6a8045a606d60135d8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150620Reviewed-by:
-
David Bertoni authored
Bug: 366181 Change-Id: Ie21ae708883e32745350d2227086acc31ff890bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149496Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#759342}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/68626439f360..9ff1d841f6cc git log 68626439f360..9ff1d841f6cc --date=short --first-parent --format='%ad %ae %s' 2020-04-15 robertphillips@google.com Revert "Update DDL test harness to use backendTextures to back tiles" 2020-04-15 robertphillips@google.com Update DDL test harness to use backendTextures to back tiles 2020-04-15 bsalomon@google.com Reland "GaussianConvolutionFragmentProcessor uses GrTextureEffect." 2020-04-15 brianosman@google.com Support markers (custom matrices) in SkVertices Attributes 2020-04-15 reed@google.com SkMatrix44 is deprecated: use SkM44 instead Created with: gclient setdep -r src/third_party/skia@9ff1d841f6cc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: kjlubick@google.com Change-Id: I2e3341d749e9817e9e5ea971d1aa342d24000882 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150726Reviewed-by:
-
Ravi Chandra Sadineni authored
Recently an additional dropdown has been added to allow setting battery idle behavior differently from AC idle behavior. This setting is visible only when battery is present and is hidden behind a dom-if template. Since nodes under dom-if are dynamically created, they are not added to the this.$ hash. As a result battery idle setting dropdown is not working. Instead use this.$$ for accessing the dynamically created #batteryIdleSelect node. This change also adds a test to catch the same. Bug: b:148105990, 1065050, b:154051991 Test: Run browser_tests and manual tests. Change-Id: I5970d6b362fc4c4c9685ddfe7d388e0a197007b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147015 Commit-Queue: Ravi Chandra Sadineni <ravisadineni@chromium.org> Auto-Submit: Ravi Chandra Sadineni <ravisadineni@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#759340}
-
Doug Turner authored
The initial IOS cronet prevented per request User-Agent header. This CL reverts that restriction and allows one to specify a UA per request. if a User-Agent is not specified, the default User-Agent will be used. Bug: 968358 Change-Id: Idaffeaab2d128f6b64963f38e0f68f10c6d47aea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141140 Commit-Queue: Doug Turner <dougt@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#759339}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/e3f44e3cd6a1..0ff7ed41ecc5 git log e3f44e3cd6a1..0ff7ed41ecc5 --date=short --first-parent --format='%ad %ae %s' 2020-04-15 cwallez@chromium.org Remove CreateBufferMappedAsync Created with: gclient setdep -r src/third_party/dawn@0ff7ed41ecc5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I190bb73cc4efbd8e8e3b1a2ee2aada6b9c4b603c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149940Reviewed-by:
-
Tom Anderson authored
Requested by agable@ after investigating Linux.Distro for [1]. Rather than adding new enum values, this CL records the distro version in an UMA sparse histogram so we don't need to update chrome_browser_main_extra_parts_metrics.cc in the future if all we want to do is add new versions. [1] https://bugs.chromium.org/p/chromium/issues/detail?id=1064354#c13 R=thestig,agable Bug: None Change-Id: I20042e2a12d62f919c2aa77f6a049e321d2cd146 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140719Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Reviewed-by:
-
Jeff Yoon authored
Missed one roll for a sim, causing some failures on the bot. Bug: 1065456 Change-Id: Ice7343ec54c7f398de294072479a9abea7c3332e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147018Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#759336}
-
Travis Skare authored
Fixes dialog spacing, click, icon, and icon show/hide. Adds an icon to the page context menu item. Launches from context menu use committed URL, rather than potentially empty link_url. (generate code for image URL outstanding) BUG=1014547 Change-Id: I8cd1651feb108ba5013a793169ecdeb71e55bd19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091722 Commit-Queue: Travis Skare <skare@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#759335}
-
Antonio Gomes authored
BUG=767015, 1063749 R=rego@igalia.com Change-Id: I0ce4554655b2a7faec34be0c8634d68568d8dae6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150669 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#759334}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e6e3bfad73cf..97d22cb8bd41 git log e6e3bfad73cf..97d22cb8bd41 --date=short --first-parent --format='%ad %ae %s' 2020-04-15 wolfi@chromium.org Remove explicit width for device dropdown in device emulation 2020-04-15 aerotwist@chromium.org Prevent 'Experience' from showing in Event log 2020-04-15 aerotwist@chromium.org Provide a message when contrast info is unavailable 2020-04-15 leese@chromium.org Add worker spawn test and clean up pages folder 2020-04-15 tvanderlippe@chromium.org Fix eslint import rules to warn on test import extensions Created with: gclient setdep -r src/third_party/devtools-frontend/src@97d22cb8bd41 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1033515,chromium:1062308,chromium:1070955,chromium:956711 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia1733d777188c9243ec54ad61c70d98774f40f77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150649Reviewed-by:
-
David Bokan authored
This reverts commit 888e67db. Reason for revert: Got enough crashes for analysis, no longer needed Original change's description: > Add DumpWithoutCrash for slow Mac KeyPress events > > Add a DumpWithoutCrash to KeyPress events where the timestamp of the OS > differs from the current time by more than 5 seconds. We see in UMA that > we often see events in the 95% percentile reaching many seconds of > difference. Hopefully the crash stacks will reveal something about > what's causing this. > > A previous iteration of this investigation in > https://crrev.com/c/2111782 showed that we sometimes redispatch events > that have been reinjected back from the renderer. This should never > happen. This CL adds crash keys to dump some of the related app state > to help explain how this happens. > > However, not all such stack traces showed reinjection so that can't be > the cause of all these bad timestamps. This CL also adds some timing > information to the existing crash key in NSApp:sendEvent which might > reveal something. > > Bug: 1039833 > Change-Id: I90a8bb210debc8e9f0fcfba23a566200de72e9c2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144627 > Reviewed-by: Avi Drissman <avi@chromium.org> > Commit-Queue: David Bokan <bokan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#758871} TBR=avi@chromium.org,bokan@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1039833,1070998 Change-Id: Ib4effbf0a6efa80570cf1297c05c8eff876fa245 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150366 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#759332}
-
Abhijeet Singh authored
Added a null-check to prevent crashing. Bug: chromium:1054962 Change-Id: Ib2dd04c4555585f3fd620000736d38646dae951a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149953 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
-
Elly Fong-Jones authored
Right now, the count of extant bubbles is used to keep track of how many bubbles exist. This leads to flaky tests though: the bubble's view is only deallocated after closing the bubble finishes, and since closing the bubble is async, whether the view has been deallocated or not at the end of the test is variable. This change has the tests instead ensure that the close process has *started* at the end of the test, which is always true. Bug: 1069695 Change-Id: I29535149fd3f318c22b44d8f93d22c5b248816da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149685Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#759330}
-
Alice Wang authored
This CL moves the method AccountManagerFacade.getGoogleAccountNames to AccountUtils. Bug: 1057040 Change-Id: Ic5c9e02a8ad85b735df183fe2450be46c6e4f6c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149319 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#759329}
-
Antonio Gomes authored
CL also adds external/wpt/css/support/height-keyword-classes.css, sibling to the existing width-keyword-classes.css File. Note that WPT's height-keyword-classes.css is not a copy of its base file fast/css-intrinsic-dimensions/resources/height-keyword-classes.css. It simplifies some CSS classes declarations in the case the standard form is supported by the major vendors. Addition, the original flex-and-intrinsic-sizes.html is also kept, in a simpler form, only with the non-standard behavior. BUG=767015, 1063749 R=rego@igalia.com Change-Id: I751dcbde25a8c1ff3c1403be8d4a8eff21a65036 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143836Reviewed-by:
-
Koji Ishii authored
This patch changes |NGFragmentItemsBuilder| to expand the capacity more aggressively. The new logic is the same as |wtf::Vector|, at least double the old capacity. The old logic was to expand by each line, which consumed a lot of time in |Vector::ReallocateBuffer| when an inline formatting context is huge. e.g., perf_test/layout/fit-content-change-available-size-text Bug: 982194 Change-Id: I6ead4d8c4d83af93b221c89b7040dbeaaf936b57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150327Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#759327}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0e4f9cf5..c6ff53c7 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I8c088358d10ea8b0cd4d47b218959a3c1ead1103 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143840Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759326}
-
Alexander Surkov authored
DumpAccessibilityTree Android formatter should walk native android accessibility trees, not blink internal trees. As the first step on this way let's disconnect Android formatter class from AccessibilityTreeFormatterBrowser, which is a native accessibility tree formatter. Bug: 1070290 Change-Id: I327e0e61162dbb563a07f89a94da82cf55db1a24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149504Reviewed-by:
-
Lily Chen authored
Instead of only passing the scheme of the cookie's source, this now passes the whole URL. Most of the call sites already have the URL (e.g. they used it to create the cookie object in the first place). These callers were previously passing url.scheme() and were converted to just pass the url. Some callers did not have the source URL. These were converted to use a fake URL cobbled together from the original scheme, the cookie's domain attribute, and the cookie's path attribute. Most of these call sites were in tests, but a handful were in production code. As of now, the use of a simulated source URL doesn't matter (since the CookieStore implementation only uses its scheme anyway). Bug: 1069642 Change-Id: If239280a3d43b7c0e2ff9af9daa9989350957b3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145152 Commit-Queue: Lily Chen <chlily@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Wei Li <weili@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#759324}
-
Xida Chen authored
These layout tests time out some times. I believe the reason is that these tests have a for loop that loops roughly 200 times, so the tests themselves takes a long time. This CL breaks each test into two tests, and hopefully that will fix the timeout problem Bug: 1050936, 1069476, 1049899 Change-Id: Iedb61faa9cd2727a863069934c371acca5b27ef2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146796Reviewed-by:
Kevin Ellis <kevers@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#759323}
-
Shik Chen authored
passed CCAUIRecordVideo. Bug: 1058325 Test: Manually verified the animation, checked a11y with ChromeVox and Change-Id: I1f10a6af80eea4eea5c0e3596d43a1a27c0c6463 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126966Reviewed-by:
Kuo Jen Wei <inker@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#759322}
-
Hailey Wang authored
Add listener to react to memory pressure and stop loading tabs. Bug: 1059341 Change-Id: Ic7fbd645f211182944878ddcff01ca3248d18dc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144268 Commit-Queue: Hailey Wang <haileywang@google.com> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#759321}
-
bttk authored
RecordHistogram now works without native Bug: 1069507 Change-Id: I4d4e96424a01ba115df11c1fa1315c7fda7d0ae9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147913 Commit-Queue: bttk <bttk@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#759320}
-
Ian Swett authored
Roll src/net/third_party/quiche/src/ 5abb89b35..897e7631c (5 commits) https://quiche.googlesource.com/quiche.git/+log/5abb89b35e3c..897e7631c5c8 $ git log 5abb89b35..897e7631c --date=short --no-merges --format='%ad %ae %s' 2020-04-14 renjietang Explicitly construct StringPiece from grease data to avoid msan failure. 2020-04-14 quiche-dev LSC: Mark static const class/struct members as constexpr. This change fixes declarations that have initial values but are technically not definitions by marking them constexpr (which counts as a definition). This enables, among other things, the modified constants to be passed into functions and function templates that accept arguments by reference. Without this change, such functions would cause linker errors. 2020-04-14 bnc gfe-relnote: Close connection if incoming MAX_PUSH_ID frame tries to reduce maximum push ID. Behavior change in IETF QUIC only, protected by gfe2_reloadable_flag_quic_enable_version_draft_25_v3 and gfe2_reloadable_flag_quic_enable_version_draft_27. 2020-04-13 quiche-dev Internal QUICHE change 2020-04-13 renjietang Add code path to store application states in TlsClientHandshaker. Roll src/third_party/quic_trace/src/ 35d364f77..a3f901c6a (2 commits) https://chromium.googlesource.com/external/github.com/google/quic-trace.git/+log/35d364f77a02..a3f901c6a99e $ git log 35d364f77..a3f901c6a --date=short --no-merges --format='%ad %ae %s' 2020-04-14 goro amend b6ba289bf6925fe2a3c667b5f927622737e70e01; switch is better 2020-04-10 goro feat: make render_trace(1) to accept JSON as well as QTR Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src R=bnc@chromium.org Bug: 1070970 Change-Id: I0f700dda814a3d75915febc602d415fc3f4fc5c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150229Reviewed-by:
Renjie Tang <renjietang@chromium.org> Reviewed-by:
-
