GitLab

Hash: d1cae24fda4182406e02d3f4df6309d48878fc50

Bug: 772558
Change-Id: Ia7db6d3088e573562aa72172f52fda7be58cc17d
Reviewed-on: https://chromium-review.googlesource.com/1141325Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Paul Irish <paulirish@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576087}

Correct reload to correctly reload header and footer, and then
reload section instead of entire collection view.

Bug: 854173
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I36931ebd69525b85936713de0b48bf647a647c45
Reviewed-on: https://chromium-review.googlesource.com/1141279Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576086}

This reverts commit c355e2e1.

Reason for revert: The tests are still flaky
http://build.chromium.org/p/chromium.memory/builders/Linux%20ChromiumOS%20MSan%20Tests/builds/7968


Original change's description:
> Fix an element value check in PasswordManager interactive tests.
>
> Bug: 849582
> Change-Id: I6e75d9a62b4b58569c2c29b913c0a6a0cab0bf83
> Reviewed-on: https://chromium-review.googlesource.com/1139057
> Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
> Commit-Queue: Alexey Khoroshilov <sense@yandex-team.ru>
> Cr-Commit-Position: refs/heads/master@{#575584}

TBR=vasilii@chromium.org,dvadym@chromium.org,sense@yandex-team.ru

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 849582
Change-Id: I4d363b0dfefa99256d50cae5fd51102204f7610a
Reviewed-on: https://chromium-review.googlesource.com/1142084
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576085}

BUG: 843236
Change-Id: I210265af65409181b095bbd6a00da530759fead4
Reviewed-on: https://chromium-review.googlesource.com/1140922Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576084}

This also moves the official build logic to the base class.

Change-Id: I8369bf832e5f9223a610cb04e18965ed9ca599a1
Bug: 812641
Reviewed-on: https://chromium-review.googlesource.com/1140372
Commit-Queue: Georges Khalil <georgesak@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576083}

The new FormData->PasswordForm parser did not check fields for being
CVC fields (except for autocomplete attributes). Ideally, it would not
need to, because it could rely on server hints, but the hints are not
ready yet, so this CL introduces a short-term ability for the new
parser to understand when a field name sounds like that of a CVC
field.

While in the particular case of the linked bug (on
http://www.shoedazzle.com/), this will break the previously correct
behaviour of the parser, the goal is to minimize the difference in
behaviour against the old parser, so as not to introduce an unknown
amount of new breakages.

Bug: 860700
Change-Id: I4595dbf01142e9f26f7264a1d62cde4cf5e4c0c0
Reviewed-on: https://chromium-review.googlesource.com/1141958Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576082}

Bug:863767
Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
Change-Id: Id2786b7907c9fd88141391a81c544747843bc017

NOTRY=true  # test by PRESUBMIT

Change-Id: Id2786b7907c9fd88141391a81c544747843bc017
Reviewed-on: https://chromium-review.googlesource.com/1141928Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#576081}

For the following 2 tests, their test blocks render
correctly, but fail because its LayoutNG uses different
font for spaces in the ref block. LayoutNG segments whole
paragraph, and that fonts for the space characters may be
affected by surrounding characters.

  css2.1/t1202-counter-04-b.html
  css2.1/t1202-counters-04-b.html

TBR=eae@chromium.org
NOTRY=true

Bug: 591099
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I8f2bdc838bf00355cbed18786080f727c41eea66
Reviewed-on: https://chromium-review.googlesource.com/1142046
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576080}

This patch adjusts the logic for UI thread priority:

1) The priority is only increased to DISPLAY unless it was lower to
   begin with. Recent versions of Android (O+) automatically set the top
   activity's UI thread's niceness to TOP_APP_PRIORITY_BOOST (-10), so
   by setting the priority to DISPLAY (-4) we were in fact lowering the
   priority.

2) The priority is increased earlier in the start-up flow to minimize
   the chances of descheduling.

We also add a field trial for the first change to evaluate its impact.

BUG=841804
TEST=Manual inspection

Change-Id: I3ec70042be86f2b88bb1ae3a2dd8cba7d87eb807
Reviewed-on: https://chromium-review.googlesource.com/1136648
Commit-Queue: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576079}

* This also fixes the IsSelecting so that it returns false
during shutdown.

BUG=834400
TEST=Covered by unit test

Change-Id: Iac0cb8a3bdf03609727c31c51000c52ececfc66a
Reviewed-on: https://chromium-review.googlesource.com/1140749
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576078}

Change-Id: I43482a641c1b59ab2b88f3bce271ba09aa75b8c4
Reviewed-on: https://chromium-review.googlesource.com/1141738Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576077}

The pref kUrlKeyedAnonymizedDataCollectionEnabled can now be
controlled by enterprise policy.

Bug: 841832
Change-Id: I24dd2558e7c4762a314f0c390b0cb2e331cf03b7
Reviewed-on: https://chromium-review.googlesource.com/1140716
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576076}

This fixes a fuzzer OOM. 256 characters ought to be enough for anyone.

Bug: 863775
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I0103a2ab95aa6d87375dbc055d6a0f517c726799
Reviewed-on: https://chromium-review.googlesource.com/1140774Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Jonathan Backer <backer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576075}

Following bot results are included.
8062 8064 8068 8070

TBR=eae@chromium.org, mstensho@chromium.org
NOTRY=true

Bug: 591099
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I3220b03ef8d221246112a1c395ea179156bd27bb
Reviewed-on: https://chromium-review.googlesource.com/1141558
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576074}

Bug: 831648
Change-Id: I37ce716d7529a9330ff8fa566c1b5ab686bc78d4
Reviewed-on: https://chromium-review.googlesource.com/1128382Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Reviewed-by: Patrick Noland <pnoland@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576073}

This reverts commit 8b20bfaf.

Reason for revert: This should only apply on Chrome OS, see follow-up CL:1141742 .

Original change's description:
> Introduce command-line switch to force-enable developer tools
> 
> Since CL:1125855, the new default is that policy-installed extensions
> can not be inspected by developer tools.
> However, some autotests rely on inspecting policy-installed extensions
> and it is infeasible to change the policy the device sees there.
> Introduce the "--force-devtools-available" command-line switch which
> enforces developer tools availability.
> 
> Bug: 838146
> Test: browser_tests --gtest_filter=*DevTools*
> Change-Id: I666d9785195eff53f1a1346d95177985d1573d72
> Reviewed-on: https://chromium-review.googlesource.com/1140308
> Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
> Commit-Queue: Pavol Marko <pmarko@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#575994}

TBR=dgozman@chromium.org,atwilson@chromium.org,pmarko@chromium.org,jochen@chromium.org

Change-Id: I8ca2b4920ebec5dbc811bdf05fbbf39afc94dc08
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 838146
Reviewed-on: https://chromium-review.googlesource.com/1142104Reviewed-by: Pavol Marko <pmarko@chromium.org>
Commit-Queue: Pavol Marko <pmarko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576072}

Currently there's an inversion where active tabs in minimized windows don't get
loaded as they are created. This is an optimization in the occlusion tracking code
that doesn't calls ReloadIfNecessary unless the window hosting the active tab
actually becomes visible. Due to this inversion the TabLoader can start loading
background tabs in the minimized window before the active tab in the minimized
window is ever loaded.

Giving TabLoader responsibility to load all tabs fixes this. In the case of
active and visible tabs whose loads are initiated by the browser this is fine
because calling ReloadIfNecessary twice is effectively a nop, and the TabLoader
is already smart enough to track tabs that have started loading for external
reasons.

BUG=864725

Change-Id: I4b86a71470b2cb1a1a9106c4d4d92ee6b18c7284
Reviewed-on: https://chromium-review.googlesource.com/1141071Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576071}

Cold mode spellchecker sometimes creates shadow-crossing checking
ranges (due to EndOfSentence() crossing shadow boundary).
SpellCheckRequest converts the checking range into a |Range|, which
may have a different or even null root editable element, and crashes
when it's null.

This patch stops the crash in such case.

Note: So far we haven't found stable and meaningful test cases with
shadow-crossing checking ranges, so we only stop the crash right
now without further fixes.

Bug: 863784
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I27e61f8bb2921559799a986b6d99c8c3d2fb114f
Reviewed-on: https://chromium-review.googlesource.com/1141426Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576070}

Accessibility event notification requires the popup's widget to
exist. Widgets destruction order by the OS is not guaranteed, so this
CL adds an observer to hide the popup if the widget is destroyed.

Bug: 842183
Change-Id: Ibd7a70168af46e2ae20fd68addb0ad4d030de873
Reviewed-on: https://chromium-review.googlesource.com/1140194
Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576069}

Used to include padding scrollbars border

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I69a56029aded1f33bf232444de79026335a3bfa5
Bug: 845235
Reviewed-on: https://chromium-review.googlesource.com/1136058
Commit-Queue: David Grogan <dgrogan@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576068}

split_static_library is mainly a fix to avoid hitting internal
size limits in the Windows toolchain and it's not needed when
using lld because its thin archives are orders of magnitude smaller.

Bug: 857060
Change-Id: Idf101fc57d5fed8ee8644715fdebb879f7974da6
Reviewed-on: https://chromium-review.googlesource.com/1138330
Commit-Queue: Daniel Bratell <bratell@opera.com>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576067}

This reverts commit 82c224b0.

Reason for revert: The linked build (7968) wasn't the first broken build. The first broken build was 7959 where https://crrev.com/c/1139057 reenabled this known-to-be-flaky test (see issue 849582). dullweber@ takes care of the new revert.

Original change's description:
> Revert "[Android] Change suggestions based on frame of focused field"
> 
> This reverts commit 4c9cbfb5.
> 
> Sorry for the revert -- this is failing on one of the ChromeOS builders:
> https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20ChromiumOS%20MSan%20Tests/7968
> 
> You can see several failed tests in this log output:
> https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8940668796232357776/+/steps/interactive_ui_tests/0/logs/All__x2f_PasswordManagerBrowserTestWithConditionalPopupViews.AutofillLoginSignupForm__x2f_1/0
> 
> 
> Original change's description:
> > [Android] Change suggestions based on frame of focused field
> > 
> > With this CL, the renderer notifies the password accessory controller
> > when the focus moves to or away from valid input fields.
> > 
> > Bug: 854152, 854150, 854149, 853742
> > Change-Id: I63f075ce238db8b77c784e945eea8ec83d8d4344
> > Reviewed-on: https://chromium-review.googlesource.com/1124466
> > Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
> > Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
> > Reviewed-by: Antoine Labour <piman@chromium.org>
> > Reviewed-by: Mike West <mkwst@chromium.org>
> > Commit-Queue: Friedrich Horschig <fhorschig@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#575977}
> 
> TBR=vasilii@chromium.org,dvadym@chromium.org,piman@chromium.org,fhorschig@chromium.org,mkwst@chromium.org
> 
> Change-Id: I01cc79e8dc98e29cbdb1a61c6da5a4cf021fcbfb
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 854152, 854150, 854149, 853742
> Reviewed-on: https://chromium-review.googlesource.com/1141825
> Reviewed-by: Ian Clelland <iclelland@chromium.org>
> Commit-Queue: Ian Clelland <iclelland@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#576042}

TBR=vasilii@chromium.org,dvadym@chromium.org,iclelland@chromium.org,piman@chromium.org,fhorschig@chromium.org,mkwst@chromium.org

Change-Id: Idaadebd9b00179935c3f6347cc669c0811a912e4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 854152, 854150, 854149, 853742
Reviewed-on: https://chromium-review.googlesource.com/1141885Reviewed-by: Friedrich Horschig <fhorschig@chromium.org>
Commit-Queue: Friedrich Horschig <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576066}

The existing documentation mentioned "narrow scope" and that could be
read to infer as-close-as-possible to the AssertBlockingAllowed call.
However, the allowance should specifically not be in
low-level/intermediary code but rather in the client code which can then
make an informed decision on whether blocking is allowed.

R=fdoray@chromium.org

NOTRY=True

Bug: Docs
Change-Id: I71db615900933768b5b0ea89f548cf030d9b96c9
Reviewed-on: https://chromium-review.googlesource.com/1127346
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576065}

Bug: 861939
Change-Id: Ia86ab5aaa039dd4df38ca722d853907262c16930
Reviewed-on: https://chromium-review.googlesource.com/1140197Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576064}

When the new FormData->PasswordForm parser looks for the username with
its basic heuristics, it only considers the most likely fields the
user would interact with (visible > with some value > the rest).

This filter is on purpose not applied to server hints and autocomplete
attribute analysis.

But it should be applied to the local HTML classifier.

This CL makes that happen by reordering the analysis steps to do basic
heuristics before the HTML classifier, because the heuristics need to
compute the bar for interactability. With that bar computed, the
parser additionally runs the HTML classifier on fields meeting that
bar.

Bug: 851808
Change-Id: I0e54b6c1c6387b6130d297131b0dcb83fe52e265
Reviewed-on: https://chromium-review.googlesource.com/1141873
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576063}

Add control to WebRtcSet[Local/Remote]DescriptionObserverHandler whether
to only surface receievers (current/Plan B behavior) or transceivers
(Unified Plan behavior).

This will be needed in a follow-up CL.

// Already passed all the bots except an unrelated random flake on one
// bot, no need to wait for it to re-run.
NOTRY=True

Bug: 777617
Change-Id: I9cd311f9ef6e44028cb3e35457280f70a0695992
Reviewed-on: https://chromium-review.googlesource.com/1141876
Commit-Queue: Henrik Boström <hbos@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576062}

external/wpt/encoding/legacy-mb-korean/euc-kr/euckr-decode-ksc_5601.html
started failing recently on some Mac bots. Marking as flaky per WPT
import instructions.

Bug: 865004
Change-Id: I7f0fd0e3af4fbd5fce041456c906facf279a8c0b
Tbr: jsbell@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1141926Reviewed-by: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576061}

attribute src of HTMLEmbedElement changed from DOMString to ScriptURLString
Tests added

Bug: 739170
Change-Id: I6ded15b826d1da0d95f31885577db61f5adc7375
Reviewed-on: https://chromium-review.googlesource.com/1140305
Commit-Queue: Orsolya Bernadett Batiz <orsibatiz@google.com>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576060}

Bug: 851433
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I3f9d06fcab5d9a48febc72a5de2554b7bf526dfa
Reviewed-on: https://chromium-review.googlesource.com/1131183Reviewed-by: Markus Heintz <markusheintz@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: vitaliii <vitaliii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576059}

* Adds meaning to "Paused" and "Error" short strings.
* Takes context screenshots for both.
* Moves screenshot folder to profile_strings_grdp so it gets detected
  by the upload script.

Bug: chromium:863978
Change-Id: Ie62f52bbb67c33188658d170b9a12cb6d565d1aa
Reviewed-on: https://chromium-review.googlesource.com/1141355Reviewed-by: Greg Thompson <grt@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576058}

This was recently added to webrtc::RtpTransceiverInterface.
It is added to WebRTCRtpTransceiver and the content implementations are
updated.

Also removes unimplemented WebRTCRtpTransceiver::Stop() and does some
minor refactoring.

// Already passed all the bots except an unrelated random flake on one
// bot, no need to wait for it to re-run.
NOTRY=True

Bug: 777617
Change-Id: I845e0d369a6af5ee162ba14f78f27047f499a046
Reviewed-on: https://chromium-review.googlesource.com/1141871
Commit-Queue: Henrik Boström <hbos@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576057}

ozone/drm/mojo did not support GPU process restart. Add the necessary
handler to clear the cursor bindings and mark the connection as
unavailable.

BUG=620927
TEST=Run chrome --enable-drm-mojo on device, use chrome://gpucrash

Change-Id: I6a552a93bc923d7633e5c60890c53197accb48f8
Reviewed-on: https://chromium-review.googlesource.com/1139017Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: Robert Kroeger <rjkroege@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576056}

* Makes the PageActionIconView use a RoundRect.
* Uses a mirrored rect for the security chip to fix placement in RTL.

Bug: chromium:864594
Change-Id: I726c79752bf8c8601dac994f0386567ac03c840d
Reviewed-on: https://chromium-review.googlesource.com/1141347Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576055}

Makes use of RoundRects similar to ToolbarButton and friends to match
the inkdrop look.

Bug: chromium:864594
Change-Id: I91a8edff35624561b1a299ce3fd838493088f578
Reviewed-on: https://chromium-review.googlesource.com/1141296Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576054}

When a video capture device is stopped, the video capture service is supposed
to send callbacks to OnBufferRetired() to the receiver. A subtle message
order issue caused these events to not actually make it through to the receiver.

This CL fixes the ordering issue and adds a test case to ensure that the events
arrive.

This issue has surfaced on Android Canary, see crbug. The reason this has not
caused any issue on other platforms is probably that in most use cases, when the
device is stopped, the receiver is torn down as well.

Bug: 862055
Change-Id: I6a2d895bbcbe8d0236d1a5041ee58c6f2e8cf926
Reviewed-on: https://chromium-review.googlesource.com/1140527Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Christian Fremerey <chfremer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576053}

Stop monitoring bubbles and autofill for rouslan@ because no longer an
owner or developer there.

Bug: NONE
Change-Id: I7fa00806450e505155aa1a28ecd6c9a6657a407b
Reviewed-on: https://chromium-review.googlesource.com/1141281Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576052}

The feed bug the old TODO mentions is now fixed, and this
triggerRefresh() call is both not needed and actually cause a problem.
It seems that existing content is being cleared on cold starts due to
this. By removing it the feed behaves as it should.

Change-Id: I1886962876696b06e93348d97aa88cbc80fae4fb
Reviewed-on: https://chromium-review.googlesource.com/1140526Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576051}

Just template the constructor with the arguments and forward them along
with "perfect forwarding".

R=dgozman@chromium.org

Bug: 419087
Change-Id: I7f7b6ac11e5cbaeb1596db2b105ffe2b8e40d84f
Reviewed-on: https://chromium-review.googlesource.com/1140897
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576050}

In a previous change the failing CompositorImplLowEndBrowserTest.CompositorImplDropsResourcesOnBackground was set to exit early for surface sync: https://chromium-review.googlesource.com/c/chromium/src/+/1141110

This is because the test is not valid in the surface sync world.

It was removed from filtering in Viz configs, but not Surface Sync. This updates that filter too.

TEST=P/CompositorImplLowEndBrowserTest.CompositorImplDropsResourcesOnBackground/0
TBR=fsamuel@chromium.org

Bug: 855533
Change-Id: I318fb474fd838418b21a38ca421e7fa7cbc326d7
Reviewed-on: https://chromium-review.googlesource.com/1141905
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576049}

A little noise was left behind inadvertently following a tweak late in
the review process for the initial commit.

BUG=none
R=georgesak@chromium.org

Change-Id: I0df23bc4366eef91249e8cbf86d19e6c5d0d537e
Reviewed-on: https://chromium-review.googlesource.com/1141575Reviewed-by: Georges Khalil <georgesak@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576048}