- 14 Aug, 2020 40 commits
-
-
Austin Tankiang authored
Bug: 1115028 Change-Id: I56e07ed021b97ab36a93ffb1e8724c2c49a7a2ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355709Reviewed-by:
Sergei Datsenko <dats@chromium.org> Commit-Queue: Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#798077}
-
Viviane Yang authored
This CL implements the capability to fire a`pushsubscriptionchange` event when a permission is revoked for the associated origin. The runtime enabled flag PushMessagingSubscriptionChange defined in third_party/blink/renderer/platform/runtime_enabled_features.json5 is hooked up with the content feature flag kPushSubscriptionChangeEvent in content/public/common/content_features.h To enable the flag, you can run chrome with `chrome --enable-features=PushSubscriptionChangeEvent` after this CL. BUG: 646721 TEST: browser_tests --gtest_filter=PushSubscriptionChangeEventTest* Change-Id: I78249de1aa524735f733bcf174ceb2c5ed4d19bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341636 Commit-Queue: Viviane Yang <viviy@google.com> Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#798076}
-
Jan Wilken Dörrie authored
This change adds the PasswordCheckReauthenticationHelper class which handles reauthentication requests in the password check prior to editing or viewing a compromised password. Translation Screenshots: IDS_PASSWORD_CHECK_LOCKSCREEN_DESCRIPTION_EDIT: https://storage.cloud.google.com/chromium-translation-screenshots/318cdb4018154327b82c482e6efc3b7e75aaeca7 IDS_PASSWORD_CHECK_LOCKSCREEN_DESCRIPTION_VIEW: https: //storage.cloud.google.com/chromium-translation-screenshots/202b0c83bad016e36816426996b4ecefce4d2657 Bug: 1114720 Change-Id: I72b197783db6686efd7a1c0bf119c190a0e7ef85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352801 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#798075}
-
Morten Stenshorne authored
Although the rendered legend always is a child of the anonymous fieldset content wrapper (the only child of the fieldset) in the layout tree, the NG fragment for the legend is a direct child of the fragment for the fieldset itself. Match this better on the layout object side, by skipping over the anonymous content wrapper (and also the flow thread, if present) when looking for the containing block. The fieldset will now act as the containing block of a rendered legend, even if there's no direct parent-child relationship on the layout side. This is kind of similar to how it works for out-of-flow positioned objects. Also add special code in pre paint for this. This is only needed when traversing the layout object tree; when we switch over to walking the NG fragment tree (LayoutNGFragmentTraversal feature), this special code won't be needed. A more elegant solution might be to add another ContainingBlockContext member for this to ContainingBlockContext in PaintPropertyTreeBuilderFragmentContext (so that we'd reset the state to the one we had at the fieldset, when entering the rendered legend), but it doesn't seem worth it, given that layout object tree walking will be replaced by NG fragment walking at some point. No intended behavior changes currently, but this code change is required in order to handle scrollable fieldsets correctly (which will be added shortly). When a fieldset is scrollable, the legend shouldn't scroll along with the contents (since a legend is part of the border, essentially). We'll therefore establish a scrollable layer on the anonymous wrapper, NOT on the legend. Bug: 875235, 786475 Change-Id: Id31ed3391dcfdbd8ed15b927de69a963368fef13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351973Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#798074}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/eb85c0213d43..6a652f1ab5d7 2020-08-14 ynovikov@chromium.org Create dummy DEPS entry for Chromium. 2020-08-14 ynovikov@chromium.org Reenable AttributeLayout end2end tests on Linux SwANGLE If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@google.com Change-Id: Id14a1c0bacdf3ca3211992288ab30454534cb137 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355584Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#798073}
-
Mugdha Lakhani authored
If the page is being invisible, we now defer media playback in the background. I've moved this logic to a shared location so Chrome and WebLayer can reuse it and stay in sync. Bug: 1096088 Change-Id: I61465da4717d28ff8e9f6f83fd2a75fe79fc44ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352819 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#798072}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/a5f2b95badf5..765a9826cde1 2020-08-14 tmathmeyer@chromium.org Media Tab: Remove unused sections 2020-08-14 changhaohan@chromium.org Fix adorner dark mode styles 2020-08-14 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1116310 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I0091a3e4599fd47f1dd5fcbed75a4ead40142605 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355582Reviewed-by:
-
Christos Froussios authored
This reverts commit 67a4df6f. Reason for revert: Speculative revert Suspected of breaking session.RetrieveActiveSessions on chrome_all_tast_tests on chromeos-betty-pi-arc-cfi-thin-lto-chrome https://ci.chromium.org/p/chrome/builders/ci/chromeos-betty-pi-arc-cfi-thin-lto-chrome/7903 bug: 1116379 Original change's description: > LoginScreen: Show TPM lock status. > > If TPM is locked show banner with steps on how to fix this issue. > > Bug: 1114656 > Change-Id: I85dab0f4ce003ac3dad61c318efb3333457993ac > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346266 > Reviewed-by: Toni Baržić <tbarzic@chromium.org> > Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> > Cr-Commit-Position: refs/heads/master@{#797992} TBR=tbarzic@chromium.org,antrim@chromium.org,raleksandrov@google.com Change-Id: Ia81ff22352481c3699928f235a2471a5f47cbff0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1114656 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352741Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#798070}
-
Glen Robertson authored
No new icon_effects applied as a result of is_maskable parameter. Leaving further updates to app_icon_factory to Nancy. Bug: 1102701 Change-Id: I09b2c3de4da958d22153b187531f1e3c51a25e3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351263Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Glen Robertson <glenrob@chromium.org> Cr-Commit-Position: refs/heads/master@{#798069}
-
Rainhard Findling authored
* Only fetch the CCL status when a safety check is run to mitigate crbug.com/1115650. * I'll re-add the observer in a follow-up CL. Bug: 1087263, 1115650 Change-Id: Ib13de19d244328e267100ff83ed12fc41646cc2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353337Reviewed-by:
Andrey Zaytsev <andzaytsev@google.com> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Commit-Queue: Rainhard Findling <rainhard@chromium.org> Cr-Commit-Position: refs/heads/master@{#798068}
-
Matt Falkenhagen authored
This reverts commit da054331. The code review was https://chromium-review.googlesource.com/c/chromium/src/+/2227103 Super speculative revert since we have no other clues about the perf regression which started in a range the CL landed in. Bug: 1096423, 1059157 Tbr: dcheng Change-Id: Ia291b0c16c0cacfcdd40387a6b8badd135fcf7b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355630 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#798067}
-
Josh Nohle authored
Bug: 1113850 Change-Id: I9d82f7a8074b0a0d2fe918bff8125f046e120ad8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353876 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
Himanshu Jaju <himanshujaju@chromium.org> Cr-Commit-Position: refs/heads/master@{#798066}
-
Luca Hunkeler authored
Change-Id: Id59efac059eea817650c5c9c3163ac372d1df875 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352919Reviewed-by:
Clemens Arbesser <arbesser@google.com> Commit-Queue: Luca Hunkeler <hluca@google.com> Cr-Commit-Position: refs/heads/master@{#798065}
-
Jan Wilken Dörrie authored
This change uses base::flat_map instead of std::unordered_map in zxcvbn's RankedDicts in order to reduce memory usage. Since a base::flat_map requires its elements to be move assignable, the mapped_type is changed from a reference to a pointer. Bug: 1115878 Change-Id: I97eada4b85bfbbf0b47a9a73c6c9219f112380c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352735 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#798064}
-
Hesen Zhang authored
Bug: 1115755 Change-Id: Ic53116492448896364118e7840d4192ecab9cacb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353691 Commit-Queue: Hesen Zhang <hesen@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#798063}
-
jchen10 authored
Switching quickly through Instagram videos may hit an Intel driver bug on some Gen9 platforms with DecodeSwapChain turned on. This also cleans up 'supports_nv12_decode_swap_chain' in CopyTextureSelector. Bug: 1107403 Change-Id: I5deb4414295eecad8ae74bd25f8c6d3fb50a5009 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332048Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Jie A Chen <jie.a.chen@intel.com> Cr-Commit-Position: refs/heads/master@{#798062}
-
Mugdha Lakhani authored
Bug: 1096088 Change-Id: Ieb7b416fd4920639ae92547e928c2eceeefdad99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352669 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
-
Tamir Duberstein authored
This is reworking changes made in b115d096. Bug: 1099393 Change-Id: Id5d092887298a70ad4cc4dc9aaf97390a403933c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354883Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Tamir Duberstein <tamird@google.com> Cr-Commit-Position: refs/heads/master@{#798060}
-
Xianzhu Wang authored
Transformed rasterization is a method to achieve clear text under fractional transform. When applicable, it applies the fraction part of the draw trantransform during rasterization, and the rastered texels are aligned with the physical pixels, to avoid blurriness of text during compositing. Previously when it was enabled, because it would cause the texels at the top and left edges of the rastered result non-opaque, we forced the PictureLayerImpl to be non-opaque, which disables the occlusion optimization and LCD text. This CL extends the original clearing for opaque logic (extracted from raster_source.cc and paint_op_buffer_serializer.cc into clear_for_opaque_raster.cc) to all raster transforms (previously it was for scale only). When there is raster translation and the layer has content_opaque(), fill the top and left edges of the rastered result with the background color to ensure the layer is still fully opaque. This doesn't fix crbug.com/1111195, but prepares for the fix which will apply transformed rasterization in more cases. Bug: 1111195 Change-Id: I2ba4a091cf47e795154a41a2ccbd762f12523bd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344006 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#798059}
-
Zain Afzal authored
Since the media_app in the guest frame can't use any file system api functions we need some IPC so the guest frame can ask the parent frame to show the open file picker. This cl adds a delegate function which allows for this functionality, the parent frame will show the picker and insert the picked file into the navigation order after the current file. Note that since we navigate to the new file via a normal call to "advance" the media app will show a dialog asking users if they are sure they want to navigate if they have unsaved changes. If they click cancel the get into a weird state where clicking "next" will make them jump forward a file. Finding a way to deal with this is tracked in b/163662946. Additionally this updates the externs for "showOpenFilePicker" so it now returns a FileSystemFileHandle, not a fileSystemHandle. This is consistent with both the spec: https://wicg.github.io/native-file-system/#dom-window-showopenfilepicker and the implementation: https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/renderer/modules/native_file_system/window_native_file_system.idl;l=17;drc=0c6b1827bb42907302eac1e1a24f93768fc89985 Bug: b/147395281 Change-Id: I199bc787b2f69e6cd5f6785fb4f94556cd1438cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352954 Commit-Queue: Zain Afzal <zafzal@google.com> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#798058}
-
Karel Král authored
Stop hiding the mojo auto-generated method AsValueInto behind the build flag MOJO_TRACE_ENABLED to allow emitting traces from non-generated code. Thus there would be no need to write custom trace methods by hand and to keep them up-to-date. Bug: 1103623 Change-Id: Ibdc45d15e21c9edc9324fe1f9614f4435d00e2d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351999Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Karel Král <karelkral@google.com> Cr-Commit-Position: refs/heads/master@{#798057}
-
Ulan Degenbaev authored
V8WorkerMemoryReporter posts a memory measurement task on each worker thread and then collects the results. A memory measurement is performed using V8's MeasureMemory API. The new class will be used by V8PerContextMemoryReporter to serve requests from PerformanceManager. Design doc: https://bit.ly/30Y8Js6 Bug: 1085129 Change-Id: Ic02c9e41f74fb5f4a890d19c59cf222d1aa7ca82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332275Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#798056}
-
Lan Wei authored
This reverts commit fc9217ef. Reason for revert: chrome_all_tast_tests fails on chromeos-eve-arc-r-chrome, https://ci.chromium.org/p/chrome/builders/ci/chromeos-eve-arc-r-chrome/2498 Original change's description: > Add several basic gtest & integration tests to new eve-arc-r bot. > > Bug: 1092973 > Change-Id: I4df191266f28297cf8581f1687de87e336713363 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339580 > Reviewed-by: Garrett Beaty <gbeaty@chromium.org> > Reviewed-by: Stephen Martinis <martiniss@chromium.org> > Commit-Queue: Ben Pastene <bpastene@chromium.org> > Cr-Commit-Position: refs/heads/master@{#796071} TBR=martiniss@chromium.org,bpastene@chromium.org,gbeaty@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1092973 Change-Id: Ibaa98c41af45981b5d195ef41db31d541c4ed5dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355088Reviewed-by:
Lan Wei <lanwei@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#798055}
-
Friedrich Horschig authored
This CL cleans up the usage of a scene change observer that used to be necessary to reset the accessory before scene changes (to avoid layout height changes affecting the tab switcher). Screenshots verifying the correct behavior are in the linked first bug. Bug: 1115644, 876254 Change-Id: If522cfc5686028afadfbd03bf1c5b19c748b07d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352916Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Mei Liang <meiliang@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#798054}
-
Zufeng Wang authored
A previous CL added the `show-parental-controls` postMessage. This CL opens OS Settings when that message is received. No metric change here, but the code inside the iframe that triggers the postMessage does a UMA log. Bug: b/159964708 Change-Id: I4461d2effc574503a34ae578e20a10af8961f0cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354122Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Rachel Carpenter <carpenterr@chromium.org> Commit-Queue: Zufeng Wang <zufeng@google.com> Cr-Commit-Position: refs/heads/master@{#798053}
-
Lijin Shen authored
Bug: 1116309 Change-Id: I5e0a52c07a81336ef11329993676766613a7b06e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355573 Commit-Queue: Lijin Shen <lazzzis@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#798052}
-
mark a. foltz authored
Note this required converting chromecast::media::{AvPipelineClient, VideoPipelineClient,MediaPipelineClient} to be move-only, as they now own a base::OnceClosure. Bug: 1007649 Change-Id: I4ff9d43085cd919e939093854d1e749ce43f83e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340510 Commit-Queue: mark a. foltz <mfoltz@chromium.org> Reviewed-by:Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#798051}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/283c230fa18a..b6ce6baf7a7a 2020-08-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from cda86eff6461 to abe07b943855 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC fmalita@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: fmalita@google.com Change-Id: I1823f16c325b3c2993bb4a7f4d667f7723cef9dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355407Reviewed-by:
-
Hiroki Nakagawa authored
As a preparation for using optimization hints in Blink, this CL adds plumbing from WebContentsObserver impl in the browser process to LocalFrame in the renderer process. The design doc is available here (sorry, this is google internal): https://docs.google.com/document/d/1Moiz1mY18GJ8q94GvZYQaMLyrYihpFe_4Wutkhte-9M/edit?usp=sharing Implementation details described in the doc are slightly different from this CL, but it's still useful for grasping the overview of the changes. Rough processing flow is as follows: [In chrome/browser/] - BlinkOptimizationGuideWebContentsObserver - This observes navigation events, queries the optimization guide service about the hints for Blink, and sends the hints to the renderer. - The hints are served from the optimization guide service as proto files. The observer converts them to BlinkOptimizationGuideHints mojom struct. - This sents the mojo message immediately before navigation commit (on WebContentsObserver::ReadyToCommitNavigation()) so that the renderer can utilize the hints as early as possible. We cannot send the hints before ReadyToCommitNavigation because at that point the previous navigation can be being processed on the frame. [In Mojo] - The existing PreviewsResourceLoadingHintsReceiver mojom interface is responsible for mojo communication. This implementation is tentative, and will be replaced with BlinkOptimizationGuideHints's own interface in follow-up CLs. See TODO comments in the mojom files. [In chrome/renderer/] - ResourceLoadingHintsAgent - This is the implementation of PreviewsResourceLoadingHintsReceiver interface. The agent keeps the hints until a new document is created for the navigation. - When the new document is created, the agent passes the hints to (Web)LocalFrame(Impl). [In third_party/blink/renderer/core/] - LocalFrame - This retains the hints and provides them to features. Other notable changes in this CL are as follows: - This CL adds new directories: - components/optimization_guide/blink/ contains clients code of the optimization guide service. - third_party/blink/mojom/optimization_guide/ contains mojom files related to the Blink optimization guide. Bug: 1113980 Change-Id: Ifeb5d8797ec642de8ab592db0b1a8a3fb6725df3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337050 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#798049}
-
Jeremie Boulic authored
Define password prompt dialog, shown when trying to open one or multiple encrypted archives. The password prompt dialog is defined and added to the DOM tree the first time we ask for it. When trying to open multiple zip files at the same time, password prompts are serialised: the password dialog is shown with the name of the current archive to be decrypted, until all required passwords are provided. The "Cancel" button cancels the mounting process without creating any error from the user's point of view. BUG=chromium:912236 TEST=browser_tests --gtest_filter="FileManagerJsTest.FilesPasswordDialog" TEST=browser_tests --gtest_filter="*/FilesApp*" Change-Id: I29993444fc5a00e1fb87035770541648f0b27b37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327352 Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Reviewed-by:
François Degros <fdegros@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#798048}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6f04e4b8b57c..cfad71e98305 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC ksakamoto@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1110109,chromium:1110346,chromium:1116014,chromium:1116159,chromium:1116179,chromium:897470 Tbr: ksakamoto@google.com Change-Id: Iee430619086bf33d87fc4a5803a9635653c887e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355405Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#798047}
-
Julie Jeongeun Kim authored
This CL moves printing::MarginType to //printing/mojom/print.mojom to pass it to Mojo interfaces. Bug: 1008939 Change-Id: I21fdc0b328617cf94bd31858b10618b3d1d548a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341222Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#798046}
-
Khushal Sagar authored
Add the setup to control the availability of this feature using an origin trial and log it in use counters for tracking usage through the experiment. R=chrishtr@chromium.org Bug: 1114184 Change-Id: I372d298ff657dbf3f75440b8d0867a92a61226bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343767 Commit-Queue: Khushal <khushalsagar@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#798045}
-
Mike Wasserman authored
Measure coarse cross-screen window placement metrics: - IDL: window.isMultiScreen, getScreens, and screenschange use - measures use of [multi-]screen information api surfaces - kFullscreenCrossScreen (requestFullscreen w/screen option) - includes explicit same-screen requests and denied requests - kDOMWindowOpenPositioningFeaturesCrossScreen (window.open) - includes any *requests* not contained by the current screen - kDOMWindowSetWindowRectCrossScreen (window.move*/resize*) - includes any *requests* not contained by the current screen See the bug for tracking of followup work items: TODO: Measure requests or actual/allowed placements? TODO: Measure individual moveTo/moveBy/resizeTo/resizeBy? TODO: Measure kMovedOrResizedPopupCrossScreen? TODO: Measure kFullscreenAllowedByOnscreenschange w/impl? TODO: Measure kDOMWindowOpenAllowedByOnscreenschange w/impl? Bug: 1115703 Change-Id: I4a5f52c2346a5497b81798fdcb496b2993a8cbd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315198 Commit-Queue: Michael Wasserman <msw@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#798044}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/1d054a1f6d99..a5f2b95badf5 2020-08-14 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ib19fe8f72250c56fd0d5acbd6831f9b34f264656 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355400Reviewed-by:
-
Hirokazu Honda authored
Bug: 1115112, b:155054799 Test: video_decode_accelerator_tests test-25fps.vp9_2 --use_vd on rammus Change-Id: I82eeaad222eb1ea961faced6cf209641d4cabd05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350659 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#798042}
-
Peter Kasting authored
Bug: 1104532 Change-Id: I02849597d4aa12244cb4656231c7b8b448522939 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354991 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#798041}
-
Peter Kasting authored
Bug: none Change-Id: I7da24a70506ea2b029e34b3bbe4804aa4b5a6b78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248879 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#798040}
-
Koji Ishii authored
This patch has no behavior changes. Change-Id: I403a093fb6c2686058db6a447a3731072279bba9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355153 Auto-Submit: Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#798039}
-
Jeevan Shikaram authored
Update WebPaymentIntentHelper to stay in sync with the copy in ARC++. This CL pulls out the extraction of payment intent details to a new method so that ARC++ can use it synchronously. Bug: 1109119 Change-Id: Ic0c784a3fc51ed853ef51e0535c51b6b3fb06b60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352259Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Cr-Commit-Position: refs/heads/master@{#798038}
-
