GitLab

AssistantBubbleController is a sub-controller of AssistantController. A
follow up CL will pull interaction logic out of AssistantController
into another sub-controller called AssistantInteractionController.

This is part of an effort to clean up and simplify AssistantController.

Bug: b:80542452
Change-Id: I57dca92433d37140f5138923e1d35df7fa79d785
Reviewed-on: https://chromium-review.googlesource.com/1086362
Commit-Queue: David Black <dmblack@google.com>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564740}

When a rotation is set, a very tiny error is introduced in the root
window transform due to use of trig functions in computing the transform.

This small error is later turned into a full pixel error when the root
window updates its transform.

Avoid trig functions in the display rotation transform. Use of a scale
factor can still cause similar problems, but this should fix most
problems at 1x scale.

Bug: b/78781894
Test: cast_graphics_unittests with new test in next patch

Change-Id: I1ac5d50ef56a1627f2698a47f5d4a2692446332f
Reviewed-on: https://chromium-review.googlesource.com/1087805Reviewed-by: Alex Sakhartchouk <alexst@chromium.org>
Commit-Queue: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564739}

A mask layer should always have the same bounds as its parent's.
TrayBubbleView sets a mask layer to layer()->parent(), but used
the bounds of layer() for its mask layer. It caused DCHECK.

Previously, https://crrev.com/c/663422 tried to fix this by using
GetBubbleBounds(), but it still doesn't return the correct bounds in
some cases e.g. |corner_radius| and |has_shadow| = false are set.

TEST=TrayEventFilterTest
BUG=847104,764428

Change-Id: I677a0df7fc5342e7f722c97c30fc0b87f25b23f4
Reviewed-on: https://chromium-review.googlesource.com/1084530Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564738}

The lack of swarming was the most likely cause of mysterious test
failures that weren't affecting any other builder.

Bug: 849868
Change-Id: I6ee8b78886dce01a319062b3d6526381bb25ecf3
Reviewed-on: https://chromium-review.googlesource.com/1087818Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564737}

Due to the possible absence of frame or document loader from the
performance object, it's not guaranteed that processing start would be
always earlier than onload.

Reuse existing code to refactor the buffering-before-onload logic.

Bug: 847496
Change-Id: If3fae54e90747572956610bedadd7963463a5dcc
Reviewed-on: https://chromium-review.googlesource.com/1080131
Commit-Queue: Liquan (Max) Gǔ <maxlg@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564736}

Re-enable the tab-switching benchmark on linux after the tabs-metric fix
in crrev.com/c/1083790.

BUG=842732

Change-Id: Iac9ae2f83ccf6082bb3cf1e7223ccb89bf517f85
Reviewed-on: https://chromium-review.googlesource.com/1084056Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564735}

This CL removes kChromeUITermsOemURL (chrome://chrome://terms/oem)
which is unused in the MD UI and non functional.

This CL also disables:
WebviewClientCertsLoginTest.ClientCertRequestedInOtherWebView
(See comment for details).

Bug: 647411
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I4bae3abfadd6261fd37a449dcda4a1f37ba4850a
Reviewed-on: https://chromium-review.googlesource.com/1080174
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564734}

It makes it clear that including users' emails in activity report is a diffrent thing
than reporting list of device users.

Follow up for: https://chromium-review.googlesource.com/c/chromium/src/+/1034120

Test: Run DeviceStatusCollectorTest and ConsumerDeviceCollectorTest
Change-Id: I7b749c5abefb3a892aeb21113647a75feeae1255
Reviewed-on: https://chromium-review.googlesource.com/1080171Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Commit-Queue: Aga Wronska <agawronska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564733}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d566165..6563513


Created with:
  gclient setdep -r src-internal@6563513

The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I0b87ffe84cd06dd03945e155af1af16f44be4144
Reviewed-on: https://chromium-review.googlesource.com/1087638Reviewed-by: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#564732}

LaunchProcess was previously implemented using "launchpad", which is
being replaced for SDK users by the fdio_spawn*() APIs.

- Migrate call-sites off the old |options.clone_flags|.
- Add the fdio_spawn*() header file to our GN package rule for "fdio".
- Add TODO to "launchpad" package definition for it to be removed once
  all dependency repos have been updated (e.g. gtest, crashpad).

Bug: 848028
Change-Id: I2d871a0f77bd9cba0d16217371069989fdef17f3
Reviewed-on: https://chromium-review.googlesource.com/1081078Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564731}

Now, this class takes a DeviceIdPair rather than a single device ID.
This is in preparation for integrating this class with SecureChannel.

Bug: 824568, 752273
Change-Id: I21f355967590bbcda699e3f155ab93cd47959af4
Reviewed-on: https://chromium-review.googlesource.com/1086512Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564730}

It's also failing on ASAN which I guess isn't part of [ Debug ].

Bug: 849670, 789111
Change-Id: I93ceceb4c4c84390dc2253132a29c1cccde722fc
NOTRY: true
TBR: horo
Reviewed-on: https://chromium-review.googlesource.com/1087195Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564729}

Change-Id: I2168bf5f55cb30f4cb7098a6a98fe3b9176682e6
Reviewed-on: https://chromium-review.googlesource.com/1087404
Commit-Queue: Xi Cheng <chengx@chromium.org>
Reviewed-by: Mike Wittman <wittman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564728}

When the v-keyboard is being shown and the body of the
applist is tapped or clicked, dismiss the keyboard with no
side effects.

Bug: 844773
Change-Id: Iab0325e5cb5e77678df5c33a8e7f8e589e926825
Reviewed-on: https://chromium-review.googlesource.com/1077497Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564727}

This reverts commit 6b9a52cb.

Reason for revert: Compile failure on Fuchsia Cast Audio

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Fuchsia%20x64%20Cast%20Audio/17815

FAILED: cast_shell exe.unstripped/cast_shell 
python "../../build/toolchain/gcc_link_wrapper.py" --output="./cast_shell" --strip="../../third_party/eu-strip/bin/eu-strip" --unstripped-file="./exe.unstripped/cast_shell" -- ../../third_party/llvm-build/Release+Asserts/bin/clang++ -Wl,--fatal-warnings -fPIC -Wl,-z,noexecstack -Wl,-z,now -Wl,-z,relro -Wl,-z,defs -Wl,--as-needed -fuse-ld=lld -Wl,--icf=all -Wl,--color-diagnostics --target=x86_64-fuchsia -resource-dir ../../third_party/fuchsia-sdk/sdk/toolchain_libs/clang/7.0.0 -Wl,-z,stack-size=0x800000 -Wl,--no-as-needed -lfdio -Wl,--as-needed -m64 -Werror -Wl,-O2 -Wl,--gc-sections -nostdlib++ --sysroot=../../third_party/fuchsia-sdk/sdk/sysroot/x86_64-fuchsia -L../../third_party/fuchsia-sdk/sdk/arch/x64/lib -o "./exe.unstripped/cast_shell" -Wl,--start-group @"./cast_shell.rsp" ./libcast_graphics_1.0.so ./libcast_external_audio_pipeline_1.0.so -Wl,--end-group   -lzircon -llaunchpad -lasync-default -lfdio -lsvc -lmedia_client 
/b/swarming/w/ir/cache/builder/src/out/Release/../../third_party/llvm-build/Release+Asserts/bin/ld.lld: error: undefined symbol: chromecast::shell::AccessibilityManager::~AccessibilityManager()
>>> referenced by cast_browser_process.cc
>>>               obj/chromecast/browser/browser/cast_browser_process.o:(chromecast::shell::CastBrowserProcess::~CastBrowserProcess())


Original change's description:
> Move chromecast accessibility manager.
> 
>   * Move the cast AccessibilityManager into
>     chromecast/browser/accessibility.
>   * Only compile and create AccessibilityManager if extensions
>     enabled.
> 
> Bug: none
> Test: manual
> Change-Id: I83c30b8259caa97093cdd48baafd26b2750d1da7
> Reviewed-on: https://chromium-review.googlesource.com/1081234
> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
> Reviewed-by: Kevin Schoedel <kpschoedel@chromium.org>
> Reviewed-by: Alex Sakhartchouk <alexst@chromium.org>
> Commit-Queue: Ryan Daum <rdaum@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#564692}

TBR=sadrul@chromium.org,alexst@chromium.org,kpschoedel@chromium.org,rdaum@chromium.org,rmrossi@chromium.org

Change-Id: I5f49e4b0bd32517e7fc592d3f5d89160a19e9e78
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: none
Reviewed-on: https://chromium-review.googlesource.com/1087371Reviewed-by: Lambros Lambrou <lambroslambrou@chromium.org>
Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564726}

Refresh adds a new avatar button in the toolbar. The profile menu suite
needs to click on that new button when Refresh is enabled, as a
prerequisite for its tests.

Bug: 846410
Change-Id: I9a9cda0443f972a4246ff309fc163976e1bde05f
Reviewed-on: https://chromium-review.googlesource.com/1087836
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564725}

testserver.py didn't report useful diagnostics on connection failure in proxy
mode. For the CONNECT method it would report an UnboundLocalError and for the
GET method it would log nothing at all.

Log connection failures (and other network errors) in proxy mode.

Behaviour in other modes is unchanged.

BUG=849128

Change-Id: Idbc8f0254438098461b6db2bb68c5268c48e1956
Reviewed-on: https://chromium-review.googlesource.com/1084422Reviewed-by: Eric Roman <eroman@chromium.org>
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Commit-Queue: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564724}

And enable it for the sanity test.

This won't work when the test times out and swarming kills it (ie:
we won't pull the logs from the VM before we die.) The fix for that will
come in a follow-up CL.

Bug: 848402
Change-Id: Ie2396adb7e284d5069162a0c8aea145c12d85be1
Reviewed-on: https://chromium-review.googlesource.com/1086416Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564723}

BUG=849850
TBR=scottmg@chromium.org

Change-Id: Ida2589c0e3e24a6202c1df322c15d134bc2a8eaa
Reviewed-on: https://chromium-review.googlesource.com/1087752Reviewed-by: Muyuan Li <muyuanli@chromium.org>
Commit-Queue: Muyuan Li <muyuanli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564722}

This class is responsible to keep the module blacklist cache
updated when the ThirdPartyModulesBlocking feature is enabled.

Bug: 846953
Change-Id: Ib8a99ac0352702daec6b79d15324c2e7787d4d1a
Reviewed-on: https://chromium-review.googlesource.com/1055893
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564721}

It disables document.cookie APIs.

Bug: none
Change-Id: I76d4240fbd5f5cfdd2f2fa7d147eafbf939e2982
Reviewed-on: https://chromium-review.googlesource.com/1080984Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564720}

Change-Id: I77d67bdaa80773adabb129307f9a95f88fe92dcb
Reviewed-on: https://chromium-review.googlesource.com/1087831Reviewed-by: Mike Wittman <wittman@chromium.org>
Commit-Queue: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564719}

This CL fixes browser tests when UnifiedSystemTray is enabled.
These tests already works on Mash, so they are easier to port to
UnifiedSystemTray by introducing UnifiedSystemTrayTestApi
https://crrev.com/c/1086674 .
Remaining SystemTray browser tests do not work with Mash, so
we first have to make them work with Mash (in upcoming CLs).

TEST=browser_tests --enable-features=SystemTrayUnified
BUG=847104

Change-Id: Ic6ce4ce547913240b68a32959dc86242276807e9
Reviewed-on: https://chromium-review.googlesource.com/1086683Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564718}

In Pre-LayoutNG, selections are painted by LayoutText and LayoutReplaced.
We record SelectionVisualRect in LayoutObject::FragmentData, and check
for change of selection (in style and geometry) in
ObjectPaintInvalidator::InvalidateSelection, update SelectionVisualRect
and add needed invalidation rects into PartialInvalidationVisualRect.

In LayoutNG, selections are mainly painted by NGPaintFragment. Now we
keep track of NGPaintFragment's selection using
NGPaintFragment::SelectionVisualRect, and invlaidate the NGPaintFragment
if SelectionVisualRect changes.

PaintInvalidationReason::kSelection is treated as a full invalidation
reason for LayoutNG to simplify the logic (otherwise we need to support
partial raster invalidation in NGPaintFragment which seems not worth it,
with increased memory usage). This can be adjusted by the fact that we
now have finer grain selection invalidation in LayoutNG
(per NGPaintFragment) than Pre-LayoutNG (per LayoutObject).

For selection style changes (::selection pseudo style), we simply
invalidate the whole containing LayoutObject as the case is rare.

Bug: 849112
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I7a04a12e8007fb4c2841e5db9b17f37b6d9e2580
Reviewed-on: https://chromium-review.googlesource.com/1084314
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564717}

This CL disables unit tests that are testing the features that are just
removed in UnifiedSystemTray. These tests crashed/failed when
UnifiedSystemTray was enabled.

TEST=ash_unittests --enable-features=SystemTrayUnified
BUG=847104

Change-Id: I7a8b9b0723737fc03a048d41be2f23b1e73dd8a7
Reviewed-on: https://chromium-review.googlesource.com/1086813Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564716}

https://skia.googlesource.com/skia.git/+log/5e6853d..3857fbf


git log 5e6853d..3857fbf --date=short --no-merges --format='%ad %ae %s'
2018-06-05 swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/swiftshader 57776df..f398044 (1 commits)
2018-06-05 kjlubick@google.com Add Gr enums and version parsing for SwiftShader
2018-06-05 herb@google.com Have draw(Text|PosText|PosTextH) use a single entry on the device
2018-06-05 mtklein@chromium.org restore headers lost from skia.h
2018-06-05 jvanverth@google.com Consolidate ambient and spot code setup.


Created with:
  gclient setdep -r src/third_party/skia@3857fbf

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=halcanary@chromium.org

Change-Id: I0b7c4269ed5b0b130d22ebc8c50e136a183cab82
Reviewed-on: https://chromium-review.googlesource.com/1087632Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#564715}

This CL fixes TrayEventFilterTest crash when SystemTrayUnified is
enabled.

This CL makes following changes:
* Fix TrayEventFilterTest to use UnifiedSystemTray instance when the
  flag is true.
* Fix vpn/network feature pod buttons not to observe NetworkHandler
  when it doesn't exist. It's cumbersome to mock NetworkHandler for all
  unit tests, and old SystemTray did the same. Also NetworkHandler will
  be refactored soon.

TEST=TrayEventFilterTest (--enable-features=SystemTrayUnified)
BUG=847104

Change-Id: I2b9b281d182d9fbbbf159e9374c53adb29a1c756
Reviewed-on: https://chromium-review.googlesource.com/1082140
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564714}

This adds the enum and histogram for the result of mounting an SMB share. The metric is recorded when SmbService returns from calling Mount

Bug: 757625
Change-Id: I670ce6343131719850a1368154eec6e123354fca
Reviewed-on: https://chromium-review.googlesource.com/1077605
Commit-Queue: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564713}

Bug: 849851
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I84564b4c1dce0729ccdcb00b346196c6b3111401
Reviewed-on: https://chromium-review.googlesource.com/1087810
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564712}

When Chrome OS is shutdown while UnifiedSystemTray is opened, it
crashes, because UnifiedSystemTray bubble did not close immediately and
kept reference to UnifiedSystemTrayModel during close animation. It can
be problematic in some unit tests including TrayEventFilterTest.

TEST=TrayEventFilterTest
BUG=847104

Change-Id: Ia6175b8663acd19d8e5e0b2f31e38e1d3ba565c6
Reviewed-on: https://chromium-review.googlesource.com/1084367Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564711}

Changed the safe browsing notifications to report all of the results,
not just the final one obtained.  This is done by passing the
check_results_ vector directly to the consumers.  The only non-test
consumer currently is the pop-up blocker, which now scans for any
matching condition and reports it rather than just looking at the
final result and determining if it was a match.

Bug: 823414
Change-Id: I9c820e6d1ca2b640339cc31a17c42d3fb8486f2b
Reviewed-on: https://chromium-review.googlesource.com/1081048
Commit-Queue: Eric Robinson <ericrobinson@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564710}

This CL removed OfflinePageDownloadBridge and related code, integrated
them into DownloadUIAdapter/OfflinePageDownloadBridge, in order to unify
the notification/UI pipeline.

This CL removed the cache and its loading state in DownloadUIAdapter,
replacing the APIs with asynchronous calls down to lower level instead
of querying preloaded cache.

With the CL, DownloadUIAdapter will be registered as observer to both
OfflinePageModel and RequestCoordinator when OCANBUi is created. And
sending notification of page/request added/deleted whenever it receives
the event. Since successful request completion turns into successful
page save, OfflinePageAdded and OnAdded (with successful status) will
be merged if necessary, then notify OfflineContentProvider.

Minor details:
- Removed OfflinePageNotificationBridge.
- Removed OfflinePageDownloadNotifier and DownloadNotifyingObserver.
- Integrated some of the functions into DownloadUIAdapter and
  OfflinePageDownloadBridge.
- Changed some UI treatment based on newly used OfflineItem attributes.
- Changed related tests.

Bug: 839175
Change-Id: Icbe763bf70b3f49d1db6717a3b7c4ba57c25fb71
Reviewed-on: https://chromium-review.googlesource.com/1068063Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: Dmitry Titov <dimich@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Yafei Duan <romax@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564709}

This reverts commit c2ec5265.

Reason for revert: Broke compile on https://ci.chromium.org/buildbot/chromium/Win%20x64/23318

../../chrome/browser/autofill/autofill_captured_sites_interactive_uitest.cc(404,45): error: no viable conversion from 'const wchar_t [12]' to 'base::StringPiece' (aka 'BasicStringPiece<basic_string<char, char_traits<char>, allocator<char> > >') .AppendASCII(FILE_PATH_LITERAL("wpr_key.pem"))


Original change's description:
> Add browser tests for Chrome autofill on captured sites. (Bug 847905)
> 
> These tests are the first step in building a test framework for testing
> chrome autofill on complex, real-world sites pages. Since interacting
> with live sites are flaky and vulnerable to updates to the sites'
> features, this framework interacts with captured sites.
> 
> Sites are captured with the Web Page Replay (WPR) tool. Prior to
> running the test, the browser test will start WPR locally on the
> machine using a capture file. The test then navigates to the test
> site, interact with the site's checkout workflow, and verifies that
> autofill correctly completes the address and payment information.
> 
> Tests for 5 sites are included in this code change: Amazon, Zappos,
> Apple, Ebay and Walmart.
> 
> This change fixes the build breaks caused by the earlier change,
> 963800, and it also changes the tests from being driven by test code
> to being driven by test recipe files. The test recipe files will be
> generated by a chrome automation extension recording user actions.
> 
> Bug: 847905
> Change-Id: I0ef7b2b04be2a6caf3742c520f25ab1de80f9711
> Reviewed-on: https://chromium-review.googlesource.com/1086088
> Commit-Queue: Yiming Zhou <uwyiming@google.com>
> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#564693}

TBR=anthonyvd@chromium.org,sebsg@chromium.org,mahmadi@chromium.org,uwyiming@google.com

Change-Id: I2e6625dd64bfa91e15c4c048d0cd3174be960fee
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 847905
Reviewed-on: https://chromium-review.googlesource.com/1088129Reviewed-by: Lambros Lambrou <lambroslambrou@chromium.org>
Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564708}

This reverts commit 924c8465.

Reason for revert: This appears to break the Android WebView bots.

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20WebView%20N%20%28dbg%29
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20WebView%20O%20(dbg)

Traceback (most recent call last):
  File "/b/s/w/ir/cache/builder/src/components/crash/content/tools/generate_breakpad_symbols.py", line 327, in <module>
    sys.exit(main())
  File "/b/s/w/ir/cache/builder/src/components/crash/content/tools/generate_breakpad_symbols.py", line 316, in main
    deps = GetSharedLibraryDependencies(options, queue.pop(0), loader_path)
  File "/b/s/w/ir/cache/builder/src/components/crash/content/tools/generate_breakpad_symbols.py", line 151, in GetSharedLibraryDependencies
    deps = GetSharedLibraryDependenciesLinux(binary)
  File "/b/s/w/ir/cache/builder/src/components/crash/content/tools/generate_breakpad_symbols.py", line 67, in GetSharedLibraryDependenciesLinux
    ldd = subprocess.check_output(['ldd', binary])
  File "/b/s/w/ir/cipd_bin_packages/lib/python2.7/subprocess.py", line 219, in check_output
    raise CalledProcessError(retcode, cmd, output=output)

Original change's description:
> Make generate_breakpad_symbols.py not silently ignore subprocess errors.
> 
> GetCommandOuput() used to pipe stderr to /dev/null, and it ignored
> the command's return code. Use check_output() to check the return
> code, and keep stderr attached to parent's stderr.
> 
> Also make breakpad_integration_test.py a bit simpler (this part is
> supposed to be behavior-preserving.)
> 
> Bug: 813163
> Change-Id: I8c55d3da9fff3b944111c3e868121ac34bf65c17
> Reviewed-on: https://chromium-review.googlesource.com/1086981
> Reviewed-by: Jochen Eisinger <jochen@chromium.org>
> Commit-Queue: Nico Weber <thakis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#564531}

TBR=thakis@chromium.org,jochen@chromium.org

Change-Id: Iee5a81e9b7e9db21f1dda9bdc272d3392438f481
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 813163
Reviewed-on: https://chromium-review.googlesource.com/1087871Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564707}

This adds the utility class WebViewCompatUtilsForOMR1. It moves references to
SafeBrowsingResponseAdapter, which was added in OMR1, into a separate class.
On pre-OMR1 devices, this reduces log spam caused by a NoClassDefFoundError.
It also improves startup time.

Bug: 791099, 838702
Test: adb logcat | grep 'Failed resolution of'
Test: run cts -m CtsWebkitTestCases -t android.webkit.cts.WebViewClientTest#testOnSafeBrowsingHit
Change-Id: Icf52a70925be506f9b7c46ed592f5b64f43ab14c
Reviewed-on: https://chromium-review.googlesource.com/1081081Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: James Wallace-Lee <jamwalla@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564706}

This causes the bot to receive the correct sharding settings
for Android bots.

Bug: 849825
Change-Id: I14b45cc214ce5eb13000460911780bf1c256a4dc
Reviewed-on: https://chromium-review.googlesource.com/1087780Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564705}

In order to allow for layout inflation on a background thread
(https://crbug.com/849378), constructors of custom views cannot create
handlers. This CL changes the constructor used for GestureDetector to pass
along the precreated handler for the UI thread (from
ThreadUtils.getUiThreadHandler).

Also removes @VisibleForTesting from setUiThread since it is used in
webview in production

Bug: 849378
Change-Id: I4c786859d7db96f03e2647b5abb3bc27d12afb80
Reviewed-on: https://chromium-review.googlesource.com/1085990
Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564704}

https://chromium.googlesource.com/catapult.git/+log/591c140..99a065d


git log 591c140..99a065d --date=short --no-merges --format='%ad %ae %s'
2018-06-05 dtu@chromium.org [pinpoint] Use a Repository ndb model instead of namespaced_stored_object.
2018-06-05 dtu@chromium.org [pinpoint] Global TestCase class containing standard mocks.


Created with:
  gclient setdep -r src/third_party/catapult@99a065d

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: Id0537d816e59376be7c86b12066e96ab41e019e0
Reviewed-on: https://chromium-review.googlesource.com/1087629Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#564703}

Need to override |_forwardHostPropV2| method for Polymer 2. |_forwardParentProp|
and |_forwardParentPath| can be removed after Polymer 2 migration is done.

Bug: 849788
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I20faa0465f648f6da2b1158baea306df480959a7
Reviewed-on: https://chromium-review.googlesource.com/1087396Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564702}

TBR=junov@chromium.org

Bug: 849847
Change-Id: I827de83f8c51953906718c6e294d6a0c4e89e3c6
Reviewed-on: https://chromium-review.googlesource.com/1087748
Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Reviewed-by: Mike Klein <mtklein@chromium.org>
Reviewed-by: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564701}