GitLab

It's better to put the class definition in a header file and the implementation
in a C++ source file. Then, the source file is made part of the project, meaning
it is compiled separately.

BUG=791371

Cq-Include-Trybots: luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng
Change-Id: Ic58d0c714b405ced8974aca22c3b20f7b479682f
Reviewed-on: https://chromium-review.googlesource.com/982751Reviewed-by: Miguel Casas <mcasas@chromium.org>
Commit-Queue: Junwei Fu <junwei.fu@intel.com>
Cr-Commit-Position: refs/heads/master@{#547078}

These pieces will be used to store/represent page thumbnails.

Bug: 794828
Change-Id: I242ec8376a36b2b41590bf89fb166a924aa13ca7
Reviewed-on: https://chromium-review.googlesource.com/984952
Commit-Queue: Dan H <harringtond@chromium.org>
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547077}

This adds three new metrics and fixes two existing ones to ensure
they are recorded accurately when we suspend for preload=metadata,
the new metrics are:

Media.PreloadMetadataSuspendWasIdeal.Audio
Media.PreloadMetadataSuspendWasIdeal.AudioVideo
Media.PreloadMetadataSuspendWasIdeal.Video

Which are boolean and set to true if a preload=metadata suspend is
not *immediately* aborted. Immediate abort can only result from
WMPI not knowing the true playback state until HAVE_FUTURE_DATA;
this is a lie we'd like to fix, and these metrics will help us
judge the importance of fixing it.

The fixed metrics are:
Media.HasEverPlayed
Media.TimeToFirstFrame.SRC
Media.TimeToPlayReady.SRC

HasEverPlayed is fixed by not counting the BUFFERING_HAVE_ENOUGH
event when it's issued for a suspended startup (determined by
a new media log property, which is gross, but how the existing
system must work for now).

TimeToFirstFrame and TimeToPlayReady are metrics which are relative
to the time of load start, but this does not work when we stop
after metadata. To ensure these metrics are still accurate once
playback does resume, we cache the |time_to_metadata_| value and
use it account for the section of time prior to metadata suspend.

BUG=694855, 827396
TEST=manually verified chrome://histograms has the right values.

Change-Id: I5cdeea08a798ed0875c2ce603d6ee2b9a31d1e55
Reviewed-on: https://chromium-review.googlesource.com/980589
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547076}

Without this dependency component builds will fail to link.

TBR: sergeyu
Bug: 822474
Change-Id: Ieb8d7309117e6e55c5fa3c8866920e1495dbbc3b
Reviewed-on: https://chromium-review.googlesource.com/987395Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547075}

This reverts commit d3f34a3f.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> [DevTools] prepare tests for new queryObjects
> 
> TBR=pfeldman@chromium.org
> 
> Bug: chromium:825349
> Change-Id: I70390a29c684afa69555b14aa20b96345d5ce1e3
> Reviewed-on: https://chromium-review.googlesource.com/978844
> Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#545600}

TBR=pfeldman@chromium.org,kozyatinskiy@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:825349
Change-Id: I21810896da315aea8179938f32e90a2512012252
Reviewed-on: https://chromium-review.googlesource.com/987332Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547074}

When the P2P Sharing flag is turned on, all existing offline pages will
become legacy pages.  Before they can be shared, they must be published
to a public directory.

This is the first of several changes to publish the file.  This adds the
calls down to publish the file, but doesn't actually do the publishing
yet.

Subsequent changes will publish the file, and update the OfflinePageModel
database with the new file path, and include unit tests for the code
which actually takes the actions.

This change covers one of two entry points.  Here we cover entry via
the chrome overflow menu.  The second entry point is from the downloads
home activity, which will be in another changelist, but should be able
to re-use parts of this change (perhaps the
OfflinePageBridge.publishThenShare method).

Bug: 758690
Change-Id: I31dc8db25b274d98f4bac88c98a96776c1d02c0b
Reviewed-on: https://chromium-review.googlesource.com/982734
Commit-Queue: Peter Williamson <petewil@chromium.org>
Reviewed-by: Yafei Duan <romax@chromium.org>
Reviewed-by: Jian Li <jianli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547073}

Change API contract for IPAddress::AssignFromIPLiteral() such that on failure the original value is reset.

This addresses a TODO, and avoids a copy in the success case.

Change-Id: I8ff0f1154a7e4a8085c6a9f50d72bb99dfb51b7c
Reviewed-on: https://chromium-review.googlesource.com/985907Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547072}

Bug: 821118
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I6233f1767349def3ff810d49af61ebd800ac9b26
Reviewed-on: https://chromium-review.googlesource.com/981788Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547071}

Introducing new OfflinePages.StorageInfo metrics which are collected
after every time an offline page is successfully saved.

The new metrics will report storage info for both internal and external
volumes:
- internal refers to the volume that contains the Chrome app.
- external refers to the volume that contains public download directory.

Also marking old UMAs as deprecated, as they are no longer collected in
taskified offline page model.

Bug: 772204
Change-Id: Id3e7ed89d2106d0c255bc708be8a0b131f8f41f2
Reviewed-on: https://chromium-review.googlesource.com/976688Reviewed-by: Dmitry Titov <dimich@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Yafei Duan <romax@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547070}

This is a precusor cleanup extracted from
https://chromium-review.googlesource.com/c/chromium/src/+/957760/7
in the broader effort to restrict usage of MessageLoop::current().

This CL was uploaded by git cl split.

R=jamiewalch@chromium.org

Bug: 825327
Change-Id: Iaf8fde959a9c7848200e2c08d9c43236b1b331aa
Reviewed-on: https://chromium-review.googlesource.com/986536Reviewed-by: Joe Downing <joedow@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547069}

It has the default implementation of Node::MaxCharacterOffset() = NOTREACEHD(),
and all call sites call it for CharacterData.

After using ToCharacterData(node)->length() to instead of Node::MaxCharacterOffset(),
The api has no use, so remove it.

Bug: 825077
Signed-off-by: Yuhong Sha <yuhong.sha@samsung.com>
Change-Id: Ic624fd70504cdf68a4b5b1e9808ba8cf41d85dd3
Reviewed-on: https://chromium-review.googlesource.com/985678Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547068}

The profile chooser should not be shown when off the record. The button
still shows but cannot be selected.

Bug: chromium:822070
Change-Id: I40d9cf451444d8f16053282c638ee46abcca2af3
Reviewed-on: https://chromium-review.googlesource.com/984398Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547067}

This subpage and link to it are hidden when the
--enable_experimental_accessibility_features flag is on.

Currently the subpage has no functionality, but what exists does match
the UI mock, except that I've also added a description to the link to
the subpage that lets users know they can manage TTS engines from that
page.

Bug: 823359
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ia3e049cb0c9b64e861a7981d29a6642061029275
Reviewed-on: https://chromium-review.googlesource.com/969322Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547066}

Reading blobs that are loaded from IDB seem to be flaky. Large value
wrapping is a big customer of IDB blobs, so disable this for now while
the problem is investigated.

Bug: 756447
Change-Id: I64e46803d7433cbf6c701457c8e96028a015d74f
Reviewed-on: https://chromium-review.googlesource.com/987207
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547065}

BUG=827365

Change-Id: I494e7d01245cd91864cb49ab9a64990f1be93752
Reviewed-on: https://chromium-review.googlesource.com/987240Reviewed-by: Yury Khmel <khmel@chromium.org>
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547064}

This CL adds two classes for the suggestion and keyword views within an
OmniboxResultView. The intent is to move many of the members of
OmniboxResultView to one of the new classes. This CL doesn't move the
code yet. This Cl is boilerplate for the new classes. This is done to
better focus following CLs that will move code.

Bug: None
Change-Id: I0e9c766afef9c8cb13ff3b2a9b01a85c2041c51e
Reviewed-on: https://chromium-review.googlesource.com/980798
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547063}

Add animation for the Android toolbar view to slide in when JavaScript
tab modal dialog is showing and the renderer is blocked on input events.

Bug: 817461
Change-Id: I3ed69ffabe736100ac209be59f34eeedd4189cee
Reviewed-on: https://chromium-review.googlesource.com/942378
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547062}

Change-Id: Ie95ff321b2f5cdb0448e83bbba3a77b7954aab34
Reviewed-on: https://chromium-review.googlesource.com/987102
Commit-Queue: Carlos IL <carlosil@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547061}

This ports the following wiki pages into markdown:
https://www.chromium.org/developers/testing/gpu-testing
https://www.chromium.org/developers/testing/gpu-testing/gpu-bot-details
https://www.chromium.org/developers/how-tos/gpu-wrangling
https://www.chromium.org/developers/how-tos/debugging-gpu-related-code

and updates *some* of the old outdated content.

Bug: 813153
Change-Id: Ic5f1b58659bbdb691343785cb18c50f4d55c177f
Reviewed-on: https://chromium-review.googlesource.com/987233Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547060}

- Creates History Coordinator and TableViewController files.
- The Coordinator presents a TableViewContainer with the newly created HistoryTableVC.
- HistoryTableVC is no-op, only inherits from ChromeTableVC.

Screenshot:
https://drive.google.com/open?id=1FuHK2MaTRNCJ9HhkBZO3zGPjEiRY7Ih1

Bug: 805192
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ia090ed755e5a67097cf21b88fad0d198b405e8bf
Reviewed-on: https://chromium-review.googlesource.com/985235Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547059}

This was just needless indirection.

BUG=none
TEST=none
TBR=rohitrao

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I9b052d50e21b29e5a18181c99f0b4be974e10046
Reviewed-on: https://chromium-review.googlesource.com/987101Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547058}

Bug: 773295
Change-Id: I5a1783b49d8e20119843af96919bc341d6612f6e
Reviewed-on: https://chromium-review.googlesource.com/986675
Commit-Queue: Mark Pilgrim <pilgrim@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547057}

I introduced a bad feature flag infobar for SignedHTTPExchange.
[1] https://chromium.googlesource.com/chromium/src/+/a753229
This CL introduced the bad flag infobar to Android Chrome not only for
SignedHTTPExchange but also for all bad flags which are listed as kBadFlags in
bad_flags_prompt.cc.
Before this CL, Android Chrome didn't show any bad flag infobar.

This change caused parformance regressions because a bad flag
"--ignore-certificate-errors-spki-list" is used for perfomance testing.
(crbug.com/822258#c13)

So I added the check of "--enable-automation" flag in ShowBadFlagsPrompt().
[2] https://chromium.googlesource.com/chromium/src/+/33b13b2
And I added --enable-automation flag in GetFromBrowserOptions() in catapult.
[3] https://chromium.googlesource.com/catapult.git/+/df3154e
I thought that this check already existed in startup_browser_creator_impl.cc for
Desktop not to show the infobar during tests.
But on Desktop, a infobar for the automation is always shown when the flag is set.
https://chromium.googlesource.com/chromium/src/+/7a66b24

After the CL [3] pixel_tests are failing on Windows.
https://chromium-review.googlesource.com/c/chromium/src/+/969827
And Catapult AutoRoll is being blocked by the failure.
https://crbug.com/824779
I think this is due to the shadow of the infobar.

What I wanted to do was to show the infobar for SignedHTTPExchange.
And I think we don't need to show the bad flag infobar on Android for the flags
which can't be added on non-rooted devices.

So this CL changes the behavior of Android Chrome to show the the infobar only
for flags which are available in about:flags.


Bug: 825082,803774,822258
Change-Id: Ieee2bee3f31219645c642d9238599ff82483feeb
Reviewed-on: https://chromium-review.googlesource.com/977252
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547056}

Change-Id: I30afa26406d7313a220fada540f211026bf255f9
Reviewed-on: https://chromium-review.googlesource.com/985963Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Paul Irish <paulirish@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547055}

This cl adds the mechanism to make Keyboard Shortcut Viewer (KSV)
searchable in launcher.
1. Adds an InternalDataSource.
2. Adds an InternalAppResult.
3. Adds unit tests for searching internal app.

Bug: 790748
Test: manual and AppSearchProviderTest.FetchInternalApp
Change-Id: I8cae318b51d75516575c9b02cb7565b1dc748951
Reviewed-on: https://chromium-review.googlesource.com/982995
Commit-Queue: Tao Wu <wutao@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547054}

When ServiceWorkerServicification is enabled, this CL is to make
ServiceWorkerURLLoaderJob and ServiceWorkerSubresourceLoader work without
NetworkService. This CL tries to create an URLLoaderRequestHandler for a service
worker (ServiceWorkerControlleeRequestHandler) even if no NetworkService flag.

ServiceWorkerServicification still doesn't work since
ServiceWorkerURLLoaderJob::ProceedWithResponse() hasn't been implemented yet.

Bug: 752394
Change-Id: I808346f248bba254e20e708d372dde46ecc103fe
Reviewed-on: https://chromium-review.googlesource.com/888361Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547053}

Since notification_helper is a standalone executable, adding UMA support for
it needs extra work. We need to create persistent histograms in memory and
write the memory to a file upon exit of the process. These files are
accumulated inside a new directory called NotificationHelperMetrics under User
Data directory, and will eventually be reported by the browser process.

This CL moves persistent_histogram_storage.{h,cc} from chrome/installer/setup
to base/metrics as the class is now also used by notification_helper.exe, in
addition to setup.exe. This CL updates this class for general-purpose usage,
and adds unit tests for it.

This CL also logs the runtime of the notification_helper process to UMA.

Bug: 734095
Change-Id: Ia95f002378718b0e033f8da1aa7c260ec04030c3
Reviewed-on: https://chromium-review.googlesource.com/959543
Commit-Queue: Xi Cheng <chengx@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547052}

This is a re-land of 865455, which actually works.

TEST=ran video_decoder ppapi example

Bug: 754986
Change-Id: Ibf0e20244173b8ade0c1fca134825b2cd2ace660
Reviewed-on: https://chromium-review.googlesource.com/902459
Commit-Queue: Fredrik Hubinette <hubbe@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547051}

This is a simple mitigation, but not a complete fix, for
crbug.com/488043 and crbug.com/823387. It is intended to improve
robustness against both those sorts of bugs, and also against servers or
proxies which repeatedly request auth for whatever reason.

Although RestartWith* calls are typically associated with a user prompt,
but in other scenarios (remembered preferences, extensions, multi-leg
authentication), they may be triggered automatically. To avoid looping
forever, bound the number of restarts.

This will be followed by the complete fix for crbug.com/823387, but this
is intended to be small enough to hopefully merge.

Bug: 488043, 823387
Change-Id: Ieb0193ba7aad93efe6e7e1e4cf3355c1fb53f811
Reviewed-on: https://chromium-review.googlesource.com/986677Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547050}

Change-Id: I484eff5ebcd86ff973a57eeaa01715a06ac5983f
Reviewed-on: https://chromium-review.googlesource.com/986594Reviewed-by: Helen Li <xunjieli@chromium.org>
Commit-Queue: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547049}

This base::RefCountedMemory subclass owns a base::SharedMemory instance.
Use this class to easily access data in shared memory via the
base::RefCountedMemory interface without having to copy it out to a
std::string or std::vector.

Use this in printing code to avoid a bunch of copying.

Change-Id: I275eacb3af0250d352ec909429d8563b28b1b57e
Reviewed-on: https://chromium-review.googlesource.com/978641
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Wei Li <weili@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547048}

chrome_browser_main_chromeos.cc was only initializing the
DisplayPowerServiceProvider class, which exports the
SetPower method for the org.chromium.DisplayService D-Bus
service, for ash::Config::CLASSIC. We appear to be using
ash::Config::MUS now. Initialize the provider for everything
besides ash::Config::MASH instead.

Bug: 827026
Change-Id: Ic444682d63ff40a762f80b859d1a4795149e4d60
Reviewed-on: https://chromium-review.googlesource.com/987106Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Dan Erat <derat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547047}

Bug: 683256
Change-Id: I3735b47e983028b08b379dfc716eea78e3b977fd
Reviewed-on: https://chromium-review.googlesource.com/985641
Commit-Queue: agrieve <agrieve@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547046}

Due to variable shadowing the exclusion space was always null after
cloning, causing problems with fragment caching.

R=eae@chromium.org
BUG=635619

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I5aca88fdc693f1ad64848f43a108953bf1fc8f65
Reviewed-on: https://chromium-review.googlesource.com/986992Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547045}

https://chromium.googlesource.com/angle/angle.git/+log/a43994c9dd3a..5cf4d06cd460

$ git log a43994c9d..5cf4d06cd --date=short --no-merges --format='%ad %ae %s'
2018-03-29 ynovikov Further reduce number of uniforms in UniformsBenchmark.Run/gles_matrix

Created with:
  roll-dep src/third_party/angle


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=lucferron@chromium.org

Change-Id: I16a75981eaed86da8967c3108e1dc991581a2dcd
Reviewed-on: https://chromium-review.googlesource.com/986875Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#547044}

Per DidFinishNavigation documentation, this callback can be called for
replaced navigations, in which case NavigationContext::HasCommitted will
return false.

This CL adds an early return to HistoryTabHelper::DidFinishNavigation
if the navigation was not committed.

Bug: 813024
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I7a0a1f180faae9715b4992d3f7b810e3287a7cda
Reviewed-on: https://chromium-review.googlesource.com/984376Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547043}

This won't block CQ, but will let us see if a potential fix works.

Bug: 826735
Change-Id: I23c8e9a7b1df04206313df3fdbec58d733d17f7f
Reviewed-on: https://chromium-review.googlesource.com/986947Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547042}

As a preparation for enabling to establish WebSocket connections off the main
thread, this CL reduces dependencies on Document in DocumentWebSocketChannel
for making it thread-safe.

This CL depends on:
https://chromium-review.googlesource.com/c/chromium/src/+/984754

Bug: 825740
Change-Id: I023bb8343415adbf45e99e74218ef70d9b35bf6a
Reviewed-on: https://chromium-review.googlesource.com/985812
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547041}

Background:
The app list goes back when it loses focus or VKEY_BROWSER_BACK is
received. Tapping on the back button on shelf will triggers back actions
twice.

Change:
Prevent handling in AppListPresenterDelegate when the back button is
clicked.

BUG=819668

Change-Id: I8e11e479cbcbe8bf917006cdf8f4ebacda94ace5
Reviewed-on: https://chromium-review.googlesource.com/985417
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547040}

WebRunner will be used on Fuchsia to run web applications.

Bug: 822474
Change-Id: I56b2fd4bf653bb2c77a013b3134f6dba8065289a
Reviewed-on: https://chromium-review.googlesource.com/965255Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Ben Goodger <ben@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547039}