- 23 Jan, 2020 40 commits
-
-
Yuly Novikov authored
Mac trybots were switched in crrev.com/c/1918372, this completes the migration, switching Android, Linux and Windows manual GPU trybots. Also removes gpu-fyi-try-win-xr-builder-64, since it doesn't have a corresponding pool, and looks like it can't be used for the intended purpose of pinpoint jobs. Bug: 1020753, 977735 Change-Id: I7800d10c137010c08bb4ff10cd966dc62df9a161 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015548 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#734695}
-
Archana Simha authored
BUG=1044730 Change-Id: I9b664dfea146371672d1e6488f34fdbd0a4fcb0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013495 Commit-Queue: Archana Simha <archanasimha@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#734694}
-
Maks Orlovich authored
Bug: 1045122 Change-Id: I54beac2185515cf91b6225f9ce1588f2d2ae65e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015430 Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#734693}
-
Sarthak Shah authored
Currently, if experimental fling animation feature is turned on, FlingControllerTest fails with an exception as ScreenWin::GetPixelsPerInch() returns zero. As there is no display instantiated while running FlingController unittest, GetScreenWinDisplayNearestDIPPoint returns default ScreenWin object which has zero value for pixels per inch. This CL fixes the issue by return default value if the value of pixels per inch from ScreenWinDisplay is zero. Change-Id: I9cd7aa2ccfd62fa1896981f09a2dd4a336e49469 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974620Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Daniel Libby <dlibby@microsoft.com> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#734692}
-
Evan Stade authored
New methods are added to Tab: - beginFindInPage - activateNextFindInPageMatch - endFindInPage And a new FindInPageCallback interface is introduced with one method: - onFindResult Also add very basic FIP controls to shell to partially exercise the new API. Notes: 1. The embedder provides the main find in page UI (the text input). 2. The embedder is responsible for ending the find session as appropriate (i.e. when the main find in page UI is dismissed), which cleans up the in-page UI, consisting of a results sidebar and text highlighting. Commonly this would happen if the user cancels the find session or if a navigation occurs. 3. When the active tab loses focus, the find session is ended and the result bar is removed. 4. It is generally expected that the embedder-provided find in page UI will be hosted in the top view. TODO: 1. The top controls should be forced visible when the new web contents overlay view holds children. That will definitely be desired for tab modal dialogs, and is probably desired for find in page as well (at least judging by what Clank does). 2. Write tests. Bug: 1038415 Change-Id: I6183172dc3944157aae2db5ebb0aed983a34bffc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004072Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#734691}
-
Tim Van Patten authored
The test conformance/textures/misc/texture-upload-size.html is flaky on Android with the OpenGL ES backend: https://ci.chromium.org/p/chromium/builders/try/android_angle_rel_ng/10962 https://ci.chromium.org/p/chromium/builders/try/android_angle_rel_ng/10935 https://ci.chromium.org/p/chromium/builders/try/android_angle_rel_ng/10931 https://ci.chromium.org/p/chromium/builders/try/android_angle_rel_ng/10871 This CL will suppress the test while the issue is investigated. Bug: 1044847 Tbr: ynovikov@chromium.org Change-Id: I068b75df073d2e1c39a0027d5642cccea8e0f1fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017644 Commit-Queue: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Auto-Submit: Tim Van Patten <timvp@google.com> Cr-Commit-Position: refs/heads/master@{#734690}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/a5a6e4f5bbda..d87e67684558 git log a5a6e4f5bbda..d87e67684558 --date=short --first-parent --format='%ad %ae %s' 2020-01-23 cwallez@chromium.org Add the webgpu.h swapchain creation path Created with: gclient setdep -r src/third_party/dawn@d87e67684558 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Id9ebeeab4ccc90df0fd625c21915ab9389cd814e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017679Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#734689}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/00bf4462314d..15dccfbf4081 Created with: gclient setdep -r src-internal@15dccfbf4081 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1039877 Tbr: jbudorick@google.com Change-Id: I0c2f0afabec7e5cb87497884c58582dc82fa706e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017654Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#734688}
-
Anqing Zhao authored
Similar to other device policies around, we want to report some information about the crash reports stored in local devices. This newly added policy is used to turn on/off the feature. More details can be found in the policy definition file (policy_templates.json). Bug: 1040078 Change-Id: I477f2007d210085850a0eb964ccbabea9b47e753 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007420 Commit-Queue: Anqing Zhao <anqing@google.com> Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#734687}
-
Adenilson Cavalcanti authored
Due to its history, zlib has to support building for environments without access to basic C functions (e.g. memcpy, memset, etc) or in environments with odd memory management patterns (e.g. MSDOS). Therefore, it is good form to use zmemset/zmemcpy/etc for handling memory and the same applies for initializing a memory block to zero. Bug: 1032721 Change-Id: I8d898872ca00197cc7e961d7c49e1912073895c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016772Reviewed-by:
Chris Blume <cblume@chromium.org> Reviewed-by:
vikas soni <vikassoni@chromium.org> Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org> Cr-Commit-Position: refs/heads/master@{#734686}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/87211cd0bad8..11b05bc11f27 git log 87211cd0bad8..11b05bc11f27 --date=short --first-parent --format='%ad %ae %s' 2020-01-23 reed@google.com Don't make promises about rowbytes 2020-01-23 egdaniel@google.com Treat GrTextureAdjusters mip copy like other producers, i.e. no fallback. 2020-01-23 michaelludwig@google.com Revert "Increase precision of some quad AA calculations" 2020-01-23 mtklein@google.com basic pass at gradients 2020-01-23 reed@google.com remove some memory-based methods, add rc() 2020-01-23 senorblanco@chromium.org Implement support for framebufferOnly render targets. 2020-01-23 egdaniel@google.com GrPixelConfig is DEAD!!!!! 2020-01-23 halcanary@google.com Fix build when (is_ios && !skia_enable_skottie) 2020-01-23 michaelludwig@google.com Increase precision in barycentric_coord calculations 2020-01-23 egdaniel@google.com Remove fConfig from GrSurfaceDesc. 2020-01-23 bsalomon@google.com Fix issue introduced in 33c0f260d28e28dbb5e34be71ffcbd5165a83bb3 2020-01-23 michaelludwig@google.com Increase precision of some quad AA calculations 2020-01-23 herb@google.com Reland "Specialize SkRectanzier to SkRectanizerSkyline" 2020-01-23 reed@google.com row/col methods 2020-01-23 reed@google.com remove obsolete flag SK_SUPPORT_LEGACY_CANVAS_MATRIX_VIRTUALS 2020-01-23 brianosman@google.com Disable Programs test on MacBook10.1-Metal Created with: gclient setdep -r src/third_party/skia@11b05bc11f27 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC benjaminwagner@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:10141204,chromium:1038304,chromium:1044862 Tbr: benjaminwagner@google.com Change-Id: I18cf92a6289d682ad997145d9d245f9009430dc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016337Reviewed-by:
-
Patrick Monette authored
This is a more suitable name for this class as it will be used to track dedicated workers and shared workers in the future. Bug: 1041093 Change-Id: I711aff37886fa63ad8b799694b9ab81f8bcf3d10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993728 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#734684}
-
Toni Barzic authored
AppListItemView ctor was calling SetBackgroundBlurEnabled, which depends on icon_, before the icon view was actually added as the item view child (and thus before icon_ ptr was set). BUG=1043908 Change-Id: I9e5b52c8030899a991e08a462f511bff3292e886 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018123Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#734683}
-
Jonathan Backer authored
This is a speculative fix. As per comment #5 on that bug, we are probably obtaining a WeakPtr from an invalid raw ptr. Bug: 1038776 Change-Id: I0c2a819d53cd83df1e2042cafb3f7fc94bd681b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016344 Commit-Queue: Jonathan Backer <backer@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#734682}
-
Nohemi Fernandez authored
Adds a new option for users in non-managed accounts to clear synced data from their local device when signing out. Bug: 1005509 Change-Id: Iae3b599b3ca3698b2a176bd56b470c6787c74367 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007695 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#734681}
-
Ben Pastene authored
This should be practically a no-op change since we specify *_ld explicitly in both the ebuild and in Simple Chrome (for now). But it will make `gn args --list` print more accurate info wrt these args. Bug: 937821 Change-Id: I155fd8e2fd6a6275522c768ea96c78eb397a7a7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014127Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
George Burgess <gbiv@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#734680}
-
Johannes Kron authored
The zero-crossing frequency estimation is very sensitive to the concealment mechanism in WebRTC. By experimentation this seems to happen more often in the initial transition of the stream. Skip the first 200 ms in the verification to make the frequency estimation more robust. Restore frequency estimation error limit to +/- 50 Hz. Bug: none Change-Id: I8a7169cc20047395cb0c566d98f9d780b73f63d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014906 Commit-Queue: Johannes Kron <kron@chromium.org> Auto-Submit: Johannes Kron <kron@chromium.org> Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Cr-Commit-Position: refs/heads/master@{#734679}
-
Shahbaz Youssefi authored
conformance/textures/misc/canvas-teximage-after-multiple-drawimages.html Observed failing on Win Vulkan NVIDIA Passthrough, but skipping on all Win Vulkan Passthrough as ANGLE doesn't actively support Win Vulkan Passthrough at the moment. Bug: angleproject:4334 Change-Id: If8add00e24ec6fdaeaeeb5e4626ffb7de86c483d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017903Reviewed-by:
-
Liquan (Max) Gu authored
Context: Android Browser Test has no way to control the Web Contents of Payment Handler. However, the control is needed, in order to make it easier to cover Payment App behaviours. Before change: Android Browsertest could not run script in the WebContents of Payment Handler, because the test has no access to the WebContents. After change: Android Browsertest could run script in the WebContents of Payment Handler. Change: * Build the plumbs for Android Browser Tests to get the WebContents from ExpandablePaymentHandler UI. * Added a test to cover the Payment cancel flow. Bug: 1042892 Change-Id: I3b8813eed4c3bd05658aae465b888410954c1fd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013810 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#734677}
-
Malay Keshav authored
This patch implements the serializer function for skottie draw ops. It utilizes the transfer cache to avoid moving the entire skottie byte data across IPC for every frame update. This functionality is not included in android since android will not be using it. To achieve this the following modifications were also made to the SkottieWrapper class: - A unique id is generated using fast hash for a given animation byte data. - Store the raw byte data in the object. - Modify the constructor to differentiate between serializable & non-serializable constructors. Test=Added unit tests for transfer cache and paint op buffer. Bug: 894635 Change-Id: I9fb7b5e7f761a84e6b6112d6e73e5681e9d86342 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003809 Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Reviewed-by:Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#734676}
-
Yi Gu authored
SnapCoordinator needs to update all its scroll containers data if one of them asks for an update until the update is completed. i.e. this state should not be reset by any of its scroll containers. This bug is not exposed because a scroll container only sets the state to false during SnapCoordinator updates all its containers. This patch also updates the name to reduce ambiguity. Bug: None Change-Id: Ibbb2eccc5a9f1b36f5fc1db5bc949ded878a1d0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014980 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by:
-
Rayan Kanso authored
A website can check if its own WebAPK is installed by using the platform value `webapp` and setting url to the Web App Manifest's url. Bug: 1043970 Change-Id: I73853eb4b9ac63b1a918661ca51206611ac666e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013103Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#734674}
-
Josh Nohle authored
We expect SyncMetadataResponse.hasEncryptedGroupPrivateKey() to be true if and only if there was a non-empty group private key for CryptAuth to send. However, this CL guards against an empty group private key string. See also http://b/145600035. Bug: 951969 Change-Id: I4bac0f8cbc3ef4c4b55ea7195a08fea28fd52250 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003799 Auto-Submit: Josh Nohle <nohle@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#734673}
-
Jinsuk Kim authored
This CL defines two new metrics (Activated/Cancelled) for gesture navigation. They will be used in M81 to measure the cancellation rate. The old metrics (Triggered/SwipedOverThreshold) that gave too optimistic results will be left unused. Bug: 1013405 Change-Id: Ie4e4ef85244412af52409f6b255440a295ffd391 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014202Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
-
David Bertoni authored
Bug: 1015136 Change-Id: I2bef165b3fedd21d4a04340a89de6cd235469e02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951970 Commit-Queue: David Bertoni <dbertoni@chromium.org> Reviewed-by:
-
Robert Sesek authored
If a channel sends a message to what turns out to be a dead-name port, before the channel processes the kernel's dead-name notification, the channel would leak the dead-name right. This is because the dead-name notification message contains a port right that must be destroyed, and that right is not transferred as a normal message descriptor. Therefore, the right is not automatically released when the message remains in the kernel message queue and the associated receive right is destroyed. To fix this, if a channel fails to send a message because it is to an invalid destination (namely, a dead-name), do not immediately report the error. Instead, wait for the channel to process the dead-name notification so that the port right can be appropriately disposed. Bug: 1041682 Change-Id: I99ffdea096670ef1e133f62ae269292b1d7e290a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013524Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#734670}
-
Sylvain Defresne authored
The ChromeBrowserState has been moved from the "ios" namespace to the global namespace by http://crrev.com/c/2014913. Fix the uses from ios::ChromeBrowserState to ChromeBrowserState. Also remove includes of chrome_browser_state_forward.h and use a simple forward declaration instead (since the old name is no longer necessary). This CL was uploaded by git cl split. R=michaeldo@chromium.org Bug: 1042208 Change-Id: I76fab1199331f19d4fda31396e4631a16e2c9242 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017343 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#734669}
-
Nick Burris authored
Screen readers read from the top of the page on a scroll to text navigation, instead of the targeted text. This patch adds an AX call that is made when navigating to an anchor, as is done with element fragment anchors. Confirmed this works with TalkBack on Android. Bug: 1044644 Change-Id: If5c905b083189efd7276f64abc4a547f81f6b054 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015132Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
-
Sylvain Defresne authored
The ChromeBrowserState has been moved from the "ios" namespace to the global namespace by http://crrev.com/c/2014913. Fix the uses from ios::ChromeBrowserState to ChromeBrowserState. Also remove includes of chrome_browser_state_forward.h and use a simple forward declaration instead (since the old name is no longer necessary). This CL was uploaded by git cl split. R=jlebel@chromium.org Bug: 1042208 Change-Id: I567615141ce700cd3edc6327de23b331f38c69a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017468 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
Avi Drissman authored
BUG=1044828 Change-Id: I74cf58b4669851006d97f1b81c7a0f5ea6d3e609 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016964 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#734666}
-
Avi Drissman authored
BUG=1044828 Change-Id: I375866984e4878833b19c29a1276af948756b228 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016860 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by:
-
Lei Zhang authored
- Consolidate Pepper code within a BUILDFLAG(ENABLE_PLUGINS) section in browser_prefs.cc. - Make AddStringsForPdf() a no-op if BUILDFLAG(ENABLE_PDF) is not set in resources_private_api.cc. Bug: 1027360 Change-Id: Ie99dcc278d3b30282f4215e36ac95a6434fa0ebf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017663Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#734664}
-
Saman Sami authored
This is a reland of ae629163 Original change's description: > viz: Fix FindLatestSurfaceUpTo when there is conflict > > The condition used in the binary search was wrong. Fixed it and added > a unit test. > > Bug: 1000868 > Change-Id: Iaf4af1bdfdb88db1082bfae89a3783faed860934 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800743 > Auto-Submit: Saman Sami <samans@chromium.org> > Commit-Queue: Jonathan Ross <jonross@chromium.org> > Reviewed-by: Jonathan Ross <jonross@chromium.org> > Cr-Commit-Position: refs/heads/master@{#696170} TBR=jonross@chromium.org,samans@chromium.org Bug: 1000868, 1015120 Change-Id: I2b793035cd689551217e23de5e43d0fd855cbf37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017945Reviewed-by:
Nick Burris <nburris@chromium.org> Commit-Queue: Nick Burris <nburris@chromium.org> Cr-Commit-Position: refs/heads/master@{#734663}
-
Xinghui Lu authored
This metric records the time between a password reuse dialog is shown and a user clicks one of the buttons on the dialog. It will help us understand if users pay less attention to dialogs on Android than on desktop. Bug: 1036042 Change-Id: I2f525778d3b2109b05105f5456e5bc16ddc94f39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013493 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Bettina Dea <bdea@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#734662}
-
Ben Pastene authored
- journal contains system-wide logs (in a machine-readable format). - power_manager contains logs from the daemon that controls system power, and may provide some insight when a device/VM shuts down unexpectedly Bug: 1043953 Change-Id: I14721bdbdc62095d864145bd3d491c2d880b1df2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016665Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
-
Gabriel Charette authored
It was never used and never will be as the IO thread is being phased out altogether. This is a partial revert of https://chromium-review.googlesource.com/c/chromium/src/+/1660340 This CL keeps (diff with the raw revert on PS1): 1) TaskQueueThrottler's Metadata inner class which isolates some logic 2) TaskObserver::OnQueueNextWakeUpChanged dropping the unused TaskQueue* param 3) TaskQueueImpl::SetObserver in favor of TaskQueueImpl::SetOnNextWakeUpChangedCallback (more adaptable to future instrumentation) 4) BrowserTaskQueues::Handle as a ref-counted class (could go back to being copied around but avoiding duplicate state makes state management easier and even essential in some cases like validator_sets_ used to require) Note: The provider of Handle at the time has been renamed from BrowserIOTaskEnvironment to BrowserIOThreadDelegate if you're looking for it. Side-effect: this keeps all the . to -> usage changes for Handle. And removes: A) TaskQueueObserver::OnPostTask B) BrowserTaskQueues::Validator C) ScopedDoNotUseUIDefaultQueueFromIO This is associated to crbug.com/1026641 because supporting BrowserTaskQueues::Validator adds an unnecessary burden (not that it'd be impossible to re-add them if explicitly necessary post-migration). TBR=nasko@chromium.org (BUILD.gn) Bug: 863341, 1026641 Change-Id: I7bfdc8730cacbac33e2e9b57d1936b6755033753 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008462 Commit-Queue: Gabriel Charette <gab@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#734660}
-
Andrew Xu authored
Now hotseat is hidden after restoring the active window from overview. The reason is illustrated in the bug description. Actually the in-app shelf only exists in tablet mode where no mouse is available (if there is the mouse connected, device will switch to clamshell mode). So there is no point to check whether mouse event is enabled for shelf widget in this scenario. So skip that code block in tablet mode. Meanwhile, the CL uses the additional attribute to ensure that hotseat is not hidden by window restoration. Bug: 1044366 Change-Id: I6cd2568f2eb7a32aabb8a6be373118ec6c501634 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015802Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#734659}
-
Demetrios Papadopoulos authored
- Add polymer_modulizer() and js_modulizer() rules as necessary to generate a Polymer3 version of certificate-manager at build time. - Remove unnecessary settings.Router references from tests. - Auto-generate tests for the Polymer3 version (and update Settings WebUI data source as needed) - Add a missing assertion in js_modulizer.py that was discovered. The Polymer3 version will be used by follow up CLs to migrate chrome://certificate-manager and eventually chrome://settings Bug: 1042558 Change-Id: I3a857a45d8f6db578f2059a619720d78fd863e8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006615 Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#734658}
-
Tim Van Patten authored
The test conformance2/rendering/framebuffer-texture-level1.html is flaky on AMD GPUs on Mac Retina: https://ci.chromium.org/p/chromium/builders/try/mac-angle-rel/4837 https://ci.chromium.org/p/chromium/builders/try/mac-angle-rel/4791 This CL will suppress that test while the issue is investigated. Bug: 1044638 Change-Id: Iac30d591a1126d8cbdc373167ce3591b6279b210 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015440 Auto-Submit: Tim Van Patten <timvp@google.com> Reviewed-by:
-
kylechar authored
There is logic in GLOutputSurface to ensure that SetDrawRectangle() is only called once per swap. However, it's possible for Display::DrawAndSwap() to to draw and not swap. GLOutputSurface will ignore the first SetDrawRectangle() after Reshape() if the last swap was skipped. DirectCompositionChildSurfaceWin::Resize() releases the draw texture, so it should be safe to call call SetDrawRectangle() again after Reshape() even if SwapBuffer() wasn't called. This CL also implements equivalent logic in SkiaOutputSurfaceImpl for SkiaRenderer. Bug: 1042007 Change-Id: Ib1a8f5092d004172d37fe4c16d8a7144cbc7ce8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013346Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#734656}
-
