- 15 Feb, 2019 40 commits
-
-
Peter Collingbourne authored
Bug: 916828 Change-Id: I62582adf66fba07ebda6bda9980925ed515fb9dd Reviewed-on: https://chromium-review.googlesource.com/c/1475169Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#632786}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/e1f0d4e639f6..695b68d1009b git log e1f0d4e639f6..695b68d1009b --date=short --no-merges --format='%ad %ae %s' 2019-02-15 cwallez@chromium.org WebGPU error handling 3: CommandEncoder for validation tests Created with: gclient setdep -r src/third_party/dawn@695b68d1009b The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I918187ec7a89ffa7add8d086ce6302839b092103 Reviewed-on: https://chromium-review.googlesource.com/c/1475698Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#632785}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/5212cf739dd8..1f97ac96e633 git log 5212cf739dd8..1f97ac96e633 --date=short --no-merges --format='%ad %ae %s' 2019-02-15 simonhatch@chromium.org Pinpoint - Plumb bucket through to find_isolate_execution Created with: gclient setdep -r src/third_party/catapult@1f97ac96e633 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:931921 TBR=sullivan@chromium.org Change-Id: I541413b8548824f24b7b6b79f14c2c4607d4f676 Reviewed-on: https://chromium-review.googlesource.com/c/1475894Reviewed-by:
-
Evan Stade authored
Bug: none Change-Id: I9c8fcaa966474a059c1b1f910c18488265a9b772 Reviewed-on: https://chromium-review.googlesource.com/c/1474984 Commit-Queue: James Cook <jamescook@chromium.org> Auto-Submit: Evan Stade <estade@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#632783}
-
Patrick Monette authored
This will allows us to assess the performance impact that is has on Chrome. Bug: 928846 Change-Id: I0d4d41efab120c8be56548d2562008b47dff7534 Reviewed-on: https://chromium-review.googlesource.com/c/1452786 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#632782}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/4bb6437ff800..7081b4fe0f79 git log 4bb6437ff800..7081b4fe0f79 --date=short --no-merges --format='%ad %ae %s' 2019-02-15 treehugger-gerrit@google.com Merge "Fix expectation in UnwindingTest." Created with: gclient setdep -r src/third_party/perfetto@7081b4fe0f79 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I2ce35dfdbbc3621c6d56913ae4a48db639672dcc Reviewed-on: https://chromium-review.googlesource.com/c/1475891Reviewed-by:
-
David Trainor authored
This adds real support for inline updates from Play. This hooks up the AppUpdateManager Play class to Chrome's InlineUpdateController and UpdateStateProvider. play core library that are required to support inline updates. Binary-Size: This cl brings in the minimal set of new classes from the Bug: 922714 Change-Id: I1ba932a97502472af956471d8d58c87645a966f7 Reviewed-on: https://chromium-review.googlesource.com/c/1468801 Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Commit-Queue: David Trainor <dtrainor@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#632780}
-
Elly Fong-Jones authored
This change removes these flags: enable-media-controls-expand-gesture enable-modern-media-controls enable-overflow-icons-for-media-controls and adds TODOs to remove the backing features. Bug: None Change-Id: Ie442b114280c19d5fa89b64d79fa8c92ee7021a8 Reviewed-on: https://chromium-review.googlesource.com/c/1475799 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#632779}
-
Morten Stenshorne authored
We don't need to store the sizes on the legacy object at all, since we only need this during layout. Reduces the need for allocating (fairly big) LayoutBoxRareData objects. It also eliminates the need for storing OverrideAvailableInlineSize at all in LayoutBoxRareData, since it's only set from LayoutNG. Change-Id: I291713cac3c20d8fe81d656627eed7c8a830e9fd Reviewed-on: https://chromium-review.googlesource.com/c/1472711 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#632778}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/2bb0864b22e7..0eba65b14b60 git log 2bb0864b22e7..0eba65b14b60 --date=short --no-merges --format='%ad %ae %s' 2019-02-15 chrisforbes@google.com Support loads and stores of interface variables 2019-02-15 chrisforbes@google.com Add SpirvRoutine::getValue helper 2019-02-15 chrisforbes@google.com Implement some common forms of OpAccessChain 2019-02-15 chrisforbes@google.com Implement some common forms of OpStore 2019-02-15 chrisforbes@google.com Implement some common forms of OpLoad 2019-02-15 chrisforbes@google.com Templatize PopulateInterface & friends 2019-02-15 chrisforbes@google.com Split out decoration application helpers to avoid some iterator noise 2019-02-15 chrisforbes@google.com Fix handling of pointer sizes; we want them to be 1 2019-02-15 chrisforbes@google.com Add analysis pass support for OpLoad and OpAccessChain 2019-02-15 chrisforbes@google.com Handle more instructions in spirv analysis pass 2019-02-15 chrisforbes@google.com Remove more obsolete machinery from PixelProcessor 2019-02-15 chrisforbes@google.com Remove depthOverride pixel state bit 2019-02-15 chrisforbes@google.com Correctly determine whether we need to compute centroids 2019-02-15 chrisforbes@google.com Wire up FS input to the shader 2019-02-15 chrisforbes@google.com Remove VertexProcessor shader constants mechanism 2019-02-15 chrisforbes@google.com Wire VS interfaces onto spirv shader 2019-02-15 chrisforbes@google.com Set up VertexIndex builtin properly 2019-02-15 chrisforbes@google.com Do initial integration of spirv code generation with FS 2019-02-15 chrisforbes@google.com Remove various legacy parts of FS plumbing 2019-02-15 chrisforbes@google.com Rework setup, VS->FS structures, etc for Vulkan 2019-02-15 chrisforbes@google.com Start building up code generation Created with: gclient setdep -r src/third_party/swiftshader@0eba65b14b60 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/124388146,chromium:b/124388146,chromium:b/124388146,chromium:b/124388146,chromium:b/124388146,chromium:b/124388146,chromium:b/124388146,chromium:b/124388146,chromium:b/124388146,chromium:b/124388146,chromium:b/124177079,chromium:b/124177079,chromium:b/124177079,chromium:b/124177079,chromium:b/124177079,chromium:b/124177079,chromium:b/124177079,chromium:b/124177079,chromium:b/124177079,chromium:b/120799499,chromium:b/120799499 TBR=swiftshader-team+autoroll@chromium.org Change-Id: I6afcd6abcbdd291cdb106029eb4e31d4241b26ba Reviewed-on: https://chromium-review.googlesource.com/c/1475892Reviewed-by:
-
Adam Langley authored
This change adds request handlers for a future Settings UI to call into in order to drive set/change PIN and reset operations. Change-Id: I6df99d79807e4f87f20d4344a26eef7b896fd254 Reviewed-on: https://chromium-review.googlesource.com/c/1460412 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#632776}
-
Devlin Cronin authored
Fix a crash in revoking extension permissions where the permissions to be revoked didn't seem to be contained within the granted permissions. This was caused because the <all_urls> URLPattern retrieved from ExtensionPrefs (through calls to ExtensionPrefs::GetRuntimeGrantedPermissions) isn't properly scheme- restricted to avoid including chrome:-scheme patterns. As a result of crrev.com/e13eb218, URLPattern::Contains now properly checks schemes, resulting in this contains check failing and triggering a CHECK() failure. As a workaround, hackily adjust the runtime-granted permissions retrieved from ExtensionPrefs in ScriptablePermissionsModifier to properly omit the chrome:-scheme from <all_urls> patterns (adding back chrome://favicon separately). This logic mirrors that in ParseHelper in permissions_parser.cc, which adds the patterns to the extension permissions. This isn't a great solution, since ExtensionPrefs should really not be returning incorrect values for URLPatterns; however, it's the most targeted and easiest to merge. Since this is for a crash, go with this approach for now. A separate bug has been filed to fix ExtensionPrefs behavior. Add a regression test for the previously-crashing behavior. Bug: 930062 Change-Id: I0813c2bc2a462a0ced48f2e1a265c1efe7f2fdea Reviewed-on: https://chromium-review.googlesource.com/c/1471004 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#632775}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/7dc6b1b652fc..34fb6244cfec git log 7dc6b1b652fc..34fb6244cfec --date=short --no-merges --format='%ad %ae %s' 2019-02-15 thestig@chromium.org Add a test to show a case where patterns draw incorrectly. Created with: gclient setdep -r src/third_party/pdfium@34fb6244cfec The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I5e16bee4d92c430f214187b868a45c28c0d12f57 Reviewed-on: https://chromium-review.googlesource.com/c/1475890Reviewed-by:
-
Hiroshige Hayashizaki authored
Bug: None Change-Id: I9dd82cb5b43641dff6a5ee8a0f0788ba4a9165fa Reviewed-on: https://chromium-review.googlesource.com/c/1469373 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#632773}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/abcac71093c8..af2885953ccf Created with: gclient setdep -r src-internal@af2885953ccf The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Idc7159c1299dda3cfc4cda532e7f7074c6332026 Reviewed-on: https://chromium-review.googlesource.com/c/1474497Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#632772}
-
Wenzhao Zang authored
There's a corner case that this message is shown, and the wallpaper picker refresh ignored this case. However, all the messages have consistent style in the new wallpaper picker spec, so we'll reuse the existing spec. Bug: 899872 Change-Id: I4d8834e2f569906943b31ba00a06cd1b7455e461 Reviewed-on: https://chromium-review.googlesource.com/c/1474775Reviewed-by:
May Lippert <maybelle@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#632771}
-
Jordan Taylor authored
web_tests/animations/animationworklet/animate-non-accelerated-property.html -> web_tests/external/wpt/animation-worklet/animate-non-accelerated-property.https.html web_tests/animations/animationworklet/cancel-non-accelerated-property.html -> web_tests/external/wpt/animation-worklet/cancel-non-accelerated-property.https.html Bug: 915352 Change-Id: I7ec16782489a9747920f6e93aa0fab749e25fbe8 Reviewed-on: https://chromium-review.googlesource.com/c/1474634 Commit-Queue: Jordan Taylor <jortaylo@microsoft.com> Reviewed-by:
Yi Gu <yigu@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#632770}
-
Jared Saul authored
Bug: 924021 Change-Id: If18e074621398ac7795523311c024821c7fb6ff1 Reviewed-on: https://chromium-review.googlesource.com/c/1468784Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#632769}
-
Aleks Totic authored
Reland of https://chromium-review.googlesource.com/c/chromium/src/+/1471384 Originals failed wpt import Bug: 907911 Change-Id: Ie97da9f68cf972d31303c7e3ee547e8a184bd52d Reviewed-on: https://chromium-review.googlesource.com/c/1474709Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#632768}
-
Ovidio Henriquez authored
This change updates the OWNERS files for directories that are part of the Blink>USB and IO>USB components to point to the OWNERS file found at //chrome/browser/usb/OWNERS. Change-Id: I014b5ab66c97e1a1ffbcfa2a217c07b57dcecc2c Reviewed-on: https://chromium-review.googlesource.com/c/1474510 Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Auto-Submit: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#632767}
-
kylechar authored
TaskRunner::PostTask() takes a OnceCallback. Replace usage of base::Bind(), which produces a RepeatingCallback, with base::BindOnce() when the callback is created as a temporary inside of PostTask(). The following regex was used to find instances that could be replaced: (Post(?:Delayed)?Task)\((?:\n\s*)?FROM_HERE,(?:\n)?\s*base::Bind\( Also replace any usage of base::Passed(&var) with std::move(var) for variables passed to base::BindOnce(). base::Passed() isn't needed for move-only types with OnceCallbacks. This CL was uploaded by git cl split. R=zea@chromium.org Bug: 714018 Change-Id: I563c61da47057260e97bb3989d571f1edc2514e7 Reviewed-on: https://chromium-review.googlesource.com/c/1475646 Auto-Submit: kylechar <kylechar@chromium.org> Reviewed-by:
Nicolas Zea <zea@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#632766}
-
Tommy C. Li authored
This experiment changes the generic vector icon for search to the same color as RESULTS_TEXT_URL (generally blue). It also changes the search terms presented in omnibox suggestions to that color. Bug: 931836 Change-Id: I7e42c901a984e8762e9c969a219be91008dae7e0 Reviewed-on: https://chromium-review.googlesource.com/c/1474090 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Kevin Bailey <krb@chromium.org> Cr-Commit-Position: refs/heads/master@{#632765}
-
Xianzhu Wang authored
Previously synthetic effects always had double_sided==false, causing the layer disappear when the backface was facing forward. Bug: 928190 Change-Id: I35534b40346d5c5918bc99c00a4ca6b4e3b68796 Reviewed-on: https://chromium-review.googlesource.com/c/1475815Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#632764}
-
Hiroshige Hayashizaki authored
For V8 Code Cache for module scripts, V8CacheOptions is needed and thus this CL adds Modulator::GetV8CacheOptions(). Bug: 841466 Change-Id: I751eb522301035eebeda2fa209ed26c19c79ba26 Reviewed-on: https://chromium-review.googlesource.com/c/1470728 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
-
Hiroshige Hayashizaki authored
Bug: 841466 Change-Id: I3d66c8e74324250ebc2951b519a86276f410b861 Reviewed-on: https://chromium-review.googlesource.com/c/1475150 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
-
Ryan Sturm authored
This CL plumbs an URLLoader Factory (and other related information) from navigation url loader impl to Previews URLLoader during creation. This allows Previews URLLoader to create an underlying network service URLLoader for fetching a lite page preview. This adds URLLoaderClient handling for the serving loader, and allows both URLLoaders to actually handle URLLoaderRequests instead of always falling back. This is the minimal CL to be able to attempt server HTTPS lite page previews. Browser tests will be turned on as more behavior is supported. Bug: 921740 Change-Id: I8993d00d76c1013eb08b06c544f1c1a491a11da1 Reviewed-on: https://chromium-review.googlesource.com/c/1434521 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#632761}
-
Jinsuk Kim authored
This is a reland of 6b9ae2f7 Speculative revert showed that this CL was not an issue. Original change's description: > Android: Clean up unused Tab methods > > Now that https://chrome-internal-review.googlesource.com/c/clank/internal/apps/+/813849 > landed, the methods left unused in Tab can be cleaned up. > > Bug: 925242 > Change-Id: I64e0d8a6868644ce1843fbc965b6a3fa920d8e11 > Reviewed-on: https://chromium-review.googlesource.com/c/1470285 > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> > Cr-Commit-Position: refs/heads/master@{#632406} TBR=tedchoc@chromium.org Bug: 925242 Change-Id: I6622ace18a59b0cf370dddcafdcc6e8fb55b4d6b Reviewed-on: https://chromium-review.googlesource.com/c/1474983Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#632760}
-
John Lee authored
https://i.imgur.com/nDH165a.png Change-Id: I19f7662098f6bee115b2b55f1e695875a5eda822 Reviewed-on: https://chromium-review.googlesource.com/c/1474843 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#632759}
-
Nick Harper authored
Change-Id: Iece05010a8cb249333707fe6e8634099a81d7243 Reviewed-on: https://chromium-review.googlesource.com/c/1469423 Commit-Queue: Nick Harper <nharper@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#632758}
-
Rouslan Solomakhin authored
Intent to deprecate: https://groups.google.com/a/chromium.org/d/msg/blink-dev/ma2J2RumrmM/nmhnTmB5CAAJ (Consensus on the thread is that removal is OK.) Chrome status dashboard entry: https://www.chromestatus.com/feature/4992562146312192 Bug: 877521 Change-Id: I5dc1cce6d313f2b4138b784899cff00078ee2abe Reviewed-on: https://chromium-review.googlesource.com/c/1464225Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#632757}
-
bsheedy authored
Removes the code for using the VrCore-side fake head tracking service in VR tests. This functionality was added a long time ago, but never actually used because enabling it caused VrCore to crash randomly. Equivalent functionality has been around on Chrome's end for a while. Bug: 931414 Change-Id: Icb7c4931b177d1357368add1e915103bfeaef71e Reviewed-on: https://chromium-review.googlesource.com/c/1471511Reviewed-by:
Klaus Weidner <klausw@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#632756}
-
Hiroshige Hayashizaki authored
The test was flaky because the ScriptResource can be garbage collected before the test finished. This CL keeps the ScriptResource alive, by loading the script as a parser-inserted script. This uses a Blink-specific behavior -- a parser-inserted <script> keeps alive its corresponding ScriptResource but a dynamically-inserted <script> doesn't. This is somehow hacky, but seems to work. Bug: 841466, 906320, 927296, 922951 Change-Id: Ia45787d917191d81917e89f6843ad8b0cbcc7e76 Reviewed-on: https://chromium-review.googlesource.com/c/1475077Reviewed-by:
Mythri Alle <mythria@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#632755}
-
Jacob DeWitt authored
Bug: 922200 Change-Id: I3ce9fcbcfee18e98f82f08393c8cae6230b6e84e Reviewed-on: https://chromium-review.googlesource.com/c/1471301 Commit-Queue: Jacob DeWitt <jacde@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#632754}
-
Sidney San Martín authored
Bug: 932670 Change-Id: I5f832dfa54d88dfde2d29a7ff749c0ecb8687862 Reviewed-on: https://chromium-review.googlesource.com/c/1475878 Auto-Submit: Sidney San Martín <sdy@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#632753}
-
Allan Sandfeld Jensen authored
Some compilers are less forgiving about this than clang. Change-Id: Iad07f21fcc38b8701c7c05609048805114d2ef44 Reviewed-on: https://chromium-review.googlesource.com/c/1201854 Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org> Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Cr-Commit-Position: refs/heads/master@{#632752}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 7a5376ac. With Chromium commits locally applied on WPT: 14c11107 "Implement `Sec-CH-Lang`" af3b056c "[WPT] [wasm] Add JS-API tests for wasm threads" df760ab0 "Don't skip past auto-height flexboxes in quirks mode." c3f69282 "New wpt tests for absolute position" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org: external/wpt/resources NOAUTOREVERT=true TBR=kyleju No-Export: true Change-Id: Iaeb1e8fc641b38193b9f6cc19c334b5e906f6fa1 Reviewed-on: https://chromium-review.googlesource.com/c/1475823Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#632751}
-
Madeleine Barowsky authored
The tests that now run for YUV decoding are MipsAddedWhileOriginalInUse, MipsAddedSubsequentDraw, and BasicMips. This change adds a helper method to GpuImageDecodeCache called GetUploadedPlaneForTesting and makes a few additional miscellaneous fixes to the cache. Bug: 900672 Change-Id: I7563206944125cdcea168ca3264c85ea5eb8e7fa Reviewed-on: https://chromium-review.googlesource.com/c/1471261 Commit-Queue: Madeleine Barowsky <mbarowsky@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#632750}
-
Ben Kelly authored
Make a separate android entry for enabling ServiceWorkerForegroundPriority in the fieldtrial_testing_config.json. Bug: 928904 Change-Id: Id94e960c6a2031f854e92855011b585b3c61c4bb Reviewed-on: https://chromium-review.googlesource.com/c/1474112Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#632749}
-
Jun Mukai authored
content::responsiveness::Watcher can cause crashes of DCHECK for checking mismatched events when tab-dragging is involved. This is happening because Watcher watches both MessageLoopUI and WindowEventDispatcher (through NativeEventObserver), but OnWindowEventDispatcherFinishedProcessingEvent can be called unexpectedly. When the dragged tab is attached to another window, it means its WindowTreeHost and WindowEventDispatcher is destructed, which causes FinishedProcessingEvent in a way that Watcher thinks unmatched. More specifically: . MessageLoopUI processes an event, Watcher::WillRunTaskOnUIThread is called. 2. WindowEventDispatcher::OnWindowEventDispatcherStartedProcessing 3. the event is to start dragging, creates a nested message loop. 4. MessageLoopUI processes another event, Watcher::WillRunTaskOnUIThread 5. if this causes attaching of the dragged tab, it closes the dragged browser window 6. close causes WindowEventDispatcher::OnWindowEventDispatcherFinishedProcessing on remaining events (for 2., in this case) 7. On Watcher::DidRunEventOnUIThread, it receives the identifier from 6 (i.e. the event for 2), but the last metadata_ui is from 4 (i.e. the task of messageloopUI), so mismatch happens Absolutely the problem is the timing for 6, but it can happen on other scenarios. This CL simply ignore mismatches on ChromeOS with WindowService, and clears currently_running_metadata_ui_. This will lose some data points for a short period of time, but that can be acceptable for now. Bug: 929813 Test: manually Change-Id: I5f98d084bcbf7674ed62e790ccfbb804cd9cd3e7 Reviewed-on: https://chromium-review.googlesource.com/c/1474688Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#632748}
-
Kayce Basques authored
Bug: 930350 Change-Id: I438dfe6f06cafed09668b1eb885e8f88ec41f1e7 Reviewed-on: https://chromium-review.googlesource.com/c/1461502 Commit-Queue: Kayce Basques <kayce@google.com> Auto-Submit: Kayce Basques <kayce@google.com> Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#632747}
-
