- 27 Feb, 2009 5 commits
-
-
mmoss@chromium.org authored
Review URL: http://codereview.chromium.org/28206 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10545 0039d316-1c4b-4281-b951-d872f2087c98
-
jar@chromium.org authored
The controlling code in filter.cc doesn't significantly distinguish FILTER_OK and FILTER_NEEDS_MORE_DATA, but we *should* transition to a semantic where FILTER_OK becomes instead "FILTER_NEEDS_OUTPUT_SPACE" and then we'd need to do this uniformly for all filter code. We *could* then improve the driving filter code (for example, not have to sniff output buffer usage to deduce that the filter wanted to be called again to emit more data). r=huanr Review URL: http://codereview.chromium.org/28193 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10544 0039d316-1c4b-4281-b951-d872f2087c98
-
finnur@chromium.org authored
Now that the buildbots have cycled, it looks like two tests that I recently rebaselined are now passing on Linux. Update the testlist to reflect that. Review URL: http://codereview.chromium.org/28235 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10543 0039d316-1c4b-4281-b951-d872f2087c98
-
erikkay@google.com authored
TBR=aa Review URL: http://codereview.chromium.org/27248 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10542 0039d316-1c4b-4281-b951-d872f2087c98
-
tc@google.com authored
TBR to get the tree green. Review URL: http://codereview.chromium.org/28236 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10541 0039d316-1c4b-4281-b951-d872f2087c98
-
- 26 Feb, 2009 35 commits
-
-
erikkay@google.com authored
TBR=evan Review URL: http://codereview.chromium.org/28231 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10540 0039d316-1c4b-4281-b951-d872f2087c98
-
darin@chromium.org authored
TBR=tony Review URL: http://codereview.chromium.org/28234 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10539 0039d316-1c4b-4281-b951-d872f2087c98
-
darin@chromium.org authored
TBR=avi Review URL: http://codereview.chromium.org/28233 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10537 0039d316-1c4b-4281-b951-d872f2087c98
-
jhawkins@chromium.org authored
Review URL: http://codereview.chromium.org/28232 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10536 0039d316-1c4b-4281-b951-d872f2087c98
-
pkasting@chromium.org authored
Fix a DCHECK in certain cases when coming out of fullscreen mode. The frame gets to layout before the browser view, but it needs to know what the browser view's tabstrip layout is going to look like, or it will lay out wrong. Review URL: http://codereview.chromium.org/27231 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10535 0039d316-1c4b-4281-b951-d872f2087c98
-
wtc@chromium.org authored
port third-party code that reports memory allocation failures. R=darin,eroman Review URL: http://codereview.chromium.org/28216 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10534 0039d316-1c4b-4281-b951-d872f2087c98
-
mmoss@chromium.org authored
Review URL: http://codereview.chromium.org/27226 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10533 0039d316-1c4b-4281-b951-d872f2087c98
-
darin@chromium.org authored
R=dglazkov Review URL: http://codereview.chromium.org/27222 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10532 0039d316-1c4b-4281-b951-d872f2087c98
-
tc@google.com authored
Defer new tests. Fix wdiff to have deletes be red and new lines be green (it was reversed). Review URL: http://codereview.chromium.org/28213 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10531 0039d316-1c4b-4281-b951-d872f2087c98
-
sky@google.com authored
it wasn't that the bookmark bar was all black, rather that BrowserView thought the bookmark bar was parented when in fact it wasn't. The black was the result of BrowserView reserving the space for the bookmark bar and not painting anything in it's space. BUG=7922 TEST=see bug Review URL: http://codereview.chromium.org/28191 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10530 0039d316-1c4b-4281-b951-d872f2087c98
-
erikkay@google.com authored
Review URL: http://codereview.chromium.org/27236 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10529 0039d316-1c4b-4281-b951-d872f2087c98
-
jhawkins@chromium.org authored
Review URL: http://codereview.chromium.org/27242 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10528 0039d316-1c4b-4281-b951-d872f2087c98
-
ericroman@google.com authored
This corresponds with <http://codereview.chromium.org/28049>. BUG=2764 Review URL: http://codereview.chromium.org/28220 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10526 0039d316-1c4b-4281-b951-d872f2087c98
-
tc@google.com authored
included in data pack files. Review URL: http://codereview.chromium.org/28222 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10525 0039d316-1c4b-4281-b951-d872f2087c98
-
evan@chromium.org authored
While I'm at it, remove references to .dll in comments in the file. Review URL: http://codereview.chromium.org/27223 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10524 0039d316-1c4b-4281-b951-d872f2087c98
-
agl@chromium.org authored
VNC servers don't support Xrender. For this use case, we implement a slow fallback which byte-fiddles the Skia bitmaps as needed to support 32 and 24 bit visuals. Review URL: http://codereview.chromium.org/27227 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10523 0039d316-1c4b-4281-b951-d872f2087c98
-
finnur@google.com authored
The tests below have had their baseline changed upstream and we need to follow suit (see diffs in review folder): -LayoutTests/fast/events/offsetX-offsetY.html -LayoutTests/editing/selection/select-from-textfield-outwards.html -LayoutTests/editing/selection/select-missing-image.html NOTE: For the last test above, we now match the mac baseline so I just removed our text baseline. New tests that just needed to be baselined (only differ in font metrics): -LayoutTests/fast/lists/list-marker-with-line-height.html -LayoutTests/fast/overflow/overflow-float-stacking.html -LayoutTests/fast/overflow/overflow-stacking.html -LayoutTests/fast/replaced/embed-display-none.html -LayoutTests/fast/replaced/applet-display-none.html -LayoutTests/fast/replaced/object-display-none.html Review URL: http://codereview.chromium.org/28211 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10522 0039d316-1c4b-4281-b951-d872f2087c98
-
kuchhal@chromium.org authored
This reverts commit 25b05025dae174c94e6de74fa697a3338175f957. Review URL: http://codereview.chromium.org/27243 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10521 0039d316-1c4b-4281-b951-d872f2087c98
-
agl@chromium.org authored
made once the DelayTimer has been destroyed. Review URL: http://codereview.chromium.org/27234 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10520 0039d316-1c4b-4281-b951-d872f2087c98
-
tc@google.com authored
bug=8139 Review URL: http://codereview.chromium.org/28225 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10519 0039d316-1c4b-4281-b951-d872f2087c98
-
evan@chromium.org authored
Review URL: http://codereview.chromium.org/27232 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10518 0039d316-1c4b-4281-b951-d872f2087c98
-
nsylvain@chromium.org authored
Review URL: http://codereview.chromium.org/28224 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10517 0039d316-1c4b-4281-b951-d872f2087c98
-
tc@google.com authored
Review URL: http://codereview.chromium.org/28218 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10515 0039d316-1c4b-4281-b951-d872f2087c98
-
kuchhal@chromium.org authored
Review URL: http://codereview.chromium.org/28217 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10512 0039d316-1c4b-4281-b951-d872f2087c98
-
jam@chromium.org authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10508 0039d316-1c4b-4281-b951-d872f2087c98
-
jam@chromium.org authored
Fix BrowserTest.ThirtyFourTabs and possibly other ui tests in single-process mode. The problem was that RenderProcess was being destructed on both threads at the same time because of the scoped_ptr. Review URL: http://codereview.chromium.org/27228 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10507 0039d316-1c4b-4281-b951-d872f2087c98
-
mark@chromium.org authored
Review URL: http://codereview.chromium.org/28209 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10506 0039d316-1c4b-4281-b951-d872f2087c98
-
mark@chromium.org authored
ResourceDispatcherTest.CrossSiteAfterCrash PageLoadTest.Reliability CrashRecoveryUITest.Reload CrashRecoveryUITest.LoadInNewTab Review URL: http://codereview.chromium.org/28208 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10505 0039d316-1c4b-4281-b951-d872f2087c98
-
jcampan@chromium.org authored
- when started, the focus was not on the page (it was on the location bar, which is not shown) - ALT-F4 would not work at that point since the location bar was focused but not showing - since the location bar was focusable, tabbing through would focus it (causing the focus to go to the top window). BUG=8124,6046,8126 TEST=See bugs. R=sky Review URL: http://codereview.chromium.org/28202 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10504 0039d316-1c4b-4281-b951-d872f2087c98
-
jhawkins@chromium.org authored
Review URL: http://codereview.chromium.org/28203 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10503 0039d316-1c4b-4281-b951-d872f2087c98
-
ben@chromium.org authored
Makes it so windows opened from links in Windows Live Messenger cause the window to appear instead of being invisible. The discovery is that Windows enforces that you call ShowWindow with the value of STARTUPINFO's wShowWindow field first before calling it with any other value, otherwise all subsequent calls are ignored. I used to have code that flattened the return value of a function into something that would ensure the window is visible, but what I actually needed to do was show the window twice in this case. Ick. http://crbug.com/3126 TEST=Have someone send you a link in a Windows Live Messenger window, click it without Chrome running (Chrome must be default browser), and a Chrome window should appear, visible, loading the link. Also try running chrome.exe from bash to make sure that still works. Review URL: http://codereview.chromium.org/27190 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10502 0039d316-1c4b-4281-b951-d872f2087c98
-
jhawkins@chromium.org authored
TBR=ojan Review URL: http://codereview.chromium.org/31012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10501 0039d316-1c4b-4281-b951-d872f2087c98
-
http://codereview.chromium.org/10925mad@chromium.org authored
It was mistakenly resting the wrong iterator, so I also renamed the outer one to avoid confusion. BUG=2569 Review URL: http://codereview.chromium.org/28200 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10500 0039d316-1c4b-4281-b951-d872f2087c98
-
ananta@chromium.org authored
a response to be incorrectly treated as a multipart response. This would eventually end up sending the ViewHostMsg_DidStopLoading IPC to the browser, which would treat the page as loaded, when it has not. This fixes http://code.google.com/p/chromium/issues/detail?id=7916, which would cause the favicon to not show up on trunk. Bug=7916 Review URL: http://codereview.chromium.org/28199 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10499 0039d316-1c4b-4281-b951-d872f2087c98
-
evan@chromium.org authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10498 0039d316-1c4b-4281-b951-d872f2087c98
-