GitLab

BUG=762641
TBR=derat@chromium.org

Change-Id: I79e7f4adf116aa6c7f14a02fbe1534672d20076e
Reviewed-on: https://chromium-review.googlesource.com/c/1316228Reviewed-by: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Reviewed-by: Dan Erat <derat@chromium.org>
Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#605075}

Change-Id: I12818936e2ebd71c43e7ad42df4a3167f8a107b3
Reviewed-on: https://chromium-review.googlesource.com/c/1316249Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Jered Gray <jegray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605074}

Happened to see this code that's not used anywhere.

Bug: None
Change-Id: Iab81d9125bd191d62e8f756ecfa0b4421ce8e312
Reviewed-on: https://chromium-review.googlesource.com/c/1315710Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605073}

R=cmasso@chromium.org

Change-Id: I907098a48072853f16862e0a079d4db8aae2cefa
Reviewed-on: https://chromium-review.googlesource.com/c/1316435Reviewed-by: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605072}

AcceptLanguageTests have been updated recently [1] to ensure expanded
accept languages header. This patch ensure this also happens in the
Network Service code path.

Impacted tests (fixed by this patch):
- org.chromium.android_webview.test.AcceptLanguageTest#testAcceptLanguage
- org.chromium.android_webview.test.AcceptLanguageTest#testAcceptLanguagesWithenUS

Note:
- verified on android_mojo bot (see tryjobs this patch)
- should also fix the [Mojo Android] fyi waterfall bot [2].

[1] https://crrev.com/c/1286936
[2] https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mojo%20Android

BUG=893561,841556

Change-Id: I638b8ce855fea1a60ccaf623c559f53c1408154d
Reviewed-on: https://chromium-review.googlesource.com/c/1314594
Commit-Queue: Tim Volodine <timvolodine@chromium.org>
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605071}

NOTRY=true
TBR=nednguyen@google.com
CC=ulan@chromium.org

Bug: 901510
Change-Id: I80b10cdf9a378f4286425ba16fa4eb4a9eebae7d
Reviewed-on: https://chromium-review.googlesource.com/c/1316433Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605070}

We need to clear style invalidation on nodes being disconnected from the
document. It was done for various instances of DetachLayoutTree(), but
we would like Attach/DetachLayoutTree to be independent from style
invalidation and recalc and it is more logical to do this in RemovedFrom
on the nodes instead.

Change-Id: If8728cc5ca0f02ee83783b6e8614772cf4d4d0ef
Reviewed-on: https://chromium-review.googlesource.com/c/1314628Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605069}

This arg was defaulting to false when it should have defaulted to true.

TBR=turning off bytecode checks for certain dirs

Bug: 874854
Change-Id: I248ccab0ed52079106b07e43a302927bfa4414c8
Reviewed-on: https://chromium-review.googlesource.com/c/1309973
Commit-Queue: Sam Maier <smaier@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605068}

Upon detecting an out-of-credits scenario on the cellular connection, a
notification is shown to inform the user. Clicking the notification
currently launches the network settings page, which isn't obvious to the
user what they should do next. Instead, this CL changes that by
launching the mobile setup dialog, which brings the user to the online
payment portal to refill the data plan if needed.

      launches the mobile setup dialog.

Bug: 901482
Test: Manually verify that clicking the out-of-credits notification
Change-Id: If276a729395fe9c7c086b98caed6564f67e15bf1
Reviewed-on: https://chromium-review.googlesource.com/c/1315939Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Commit-Queue: Ben Chan <benchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605067}

Bug: none
Change-Id: Ie4f051af9df60911cfef9c0a4b539a22ef92eb58
Reviewed-on: https://chromium-review.googlesource.com/c/1316111
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605066}

NOTRY=true
TBR=nednguyen@google.com
CC=wangxianzhu@chromium.org

Bug: 901493
Change-Id: Iec05bec384214b2e3aa0fad1ea00687c57636f96
Reviewed-on: https://chromium-review.googlesource.com/c/1316407Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605065}

This is a reland of dcb738f9

Adds a definition of RaiseProcessToHighPriority() that went missing
when launch_posix.cc stoped being linked.

Original change's description:
> Reimplement GetAppOutput and friends on Mac with posix_spawn.
>
> Mac no longer uses launch_posix.cc and all process creation goes through
> posix_spawn now.
>
> Bug: 179923
> Change-Id: I5206cace69ea7863a72b58e1a59f2465492d4cbd
> Reviewed-on: https://chromium-review.googlesource.com/c/1313334
> Reviewed-by: Mark Mentovai <mark@chromium.org>
> Commit-Queue: Robert Sesek <rsesek@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#604982}

Tbr: mark@chromium.org
Bug: 179923
Change-Id: I196f406a19a9cbc5f0e29a352062abb8e87638f0
Reviewed-on: https://chromium-review.googlesource.com/c/1315947Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605064}

Allow specifying an allocation alignment to Allocate() that works
similarly to the alignment parameter to aligned_alloc(), e.g. the
alignment parameter must be a power-of-two smaller than size. Unlike
aligned_alloc it doesn't verify that the size is a multiple of alignment
since that's not enforced by some functions like posix_memalign.

Default alignment behavior stays the same if no alignment is specified.

Bug: 896019
Change-Id: I542314aa2405265af03cd6519f5c997ed1e95152
Reviewed-on: https://chromium-review.googlesource.com/c/1310563
Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org>
Reviewed-by: Vitaly Buka <vitalybuka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605063}

The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio
TBR=cr-fuchsia+bot@chromium.org

Change-Id: I810f83f88644911bcb377850b0c1766903a6a5d0
Reviewed-on: https://chromium-review.googlesource.com/c/1315734Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#605062}

This reverts commit c33a38d7.

Reason for revert: causing multiple test failures

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20Tests%20%281%29/85366

* media/controls-after-reload.html
* media/controls-strict.html
* media/controls-styling-strict.html
* media/controls-styling.html
* media/controls-without-preload.html
* media/controls/lazy-loaded-style.html
* media/controls/paint-controls-webkit-appearance-none-custom-bg.html
* media/controls/paint-controls-webkit-appearance-none.html
* media/video-controls-rendering.html
* media/video-display-toggle.html
* media/video-no-audio.html
* virtual/new-remote-playback-pipeline/media/controls/lazy-loaded-style.html
* virtual/new-remote-playback-pipeline/media/controls/paint-controls-webkit-appearance-none-custom-bg.html
* virtual/new-remote-playback-pipeline/media/controls/paint-controls-webkit-appearance-none.html

Original change's description:
> Re-baseline tests after --enable-display-compositor-pixel-dump
> 
> This CL enabled display compositor pixel dumps by default, which caused
> this group of tests to fail due to either a) minor antialiasing artifacts,
> or b) known differences in output due to being captured from the browser
> side.
> 
> https://chromium-review.googlesource.com/c/chromium/src/+/1213864
> 
> These bugs should be resolved with this CL:
>  - crbug.com/881040: Media controls now contain an overflow menu.
>  - crbug.com/667551: A bunch of tests are listed under this bug, and just
>                      require rebaselining to fix non-material single-pixel
>                      antialiasing failures.
>  - crbug.com/895556: These tests double their background size when the flag
>                      is enabled. These were already fixed by another CL,
>                      so they are NOT being rebaselined here, just removed
>                      from TestExpectations.
> 
> 
> Bug: 895912, 881040, 667551, 895556
> Change-Id: I14a1065df604151ed06f2a6be4da7eaa53968705
> Reviewed-on: https://chromium-review.googlesource.com/c/1303179
> Commit-Queue: Mason Freed <masonfreed@chromium.org>
> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#605004}

TBR=chrishtr@chromium.org,mlamouri@chromium.org,masonfreed@chromium.org

Change-Id: Ie9ec56c80e8af1a729479ba28b942913c71f555c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 895912, 881040, 667551, 895556
Reviewed-on: https://chromium-review.googlesource.com/c/1315942Reviewed-by: Mike Wittman <wittman@chromium.org>
Commit-Queue: Mike Wittman <wittman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605061}

This unifies the Perfetto and non-Perfetto TraceEventAgent classes, so
that it's possible to use Perfetto directly even when it's not enabled
as the default TraceLog backend.

Also moved the Mojo bindings of ProducerHost into a StrongBindingSet of PerfettoService
so they get cleaned up if the service gets shut down.

Already reviewed as part of https://chromium-review.googlesource.com/c/chromium/src/+/1161541

Change-Id: I3070d69e92778de8e3b5e33957ab4f4694b782af
Reviewed-on: https://chromium-review.googlesource.com/c/1307998
Commit-Queue: oysteine <oysteine@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: oysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605060}

It's called only once. Use move semantics and make that clear.

Change-Id: I6f6e41a19a8198b9821c7c17d53d1f2c2ca09fef
Reviewed-on: https://chromium-review.googlesource.com/c/1313056Reviewed-by: Paul Miller <paulmiller@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605059}

Also remove extraneous fido namespace for consistency with the rest of
//device/fido.

Bug: 898718
Change-Id: I5d44220ade620459a0f82b0446ba585bd62913bd
Reviewed-on: https://chromium-review.googlesource.com/c/1313732
Commit-Queue: Martin Kreichgauer <martinkr@chromium.org>
Reviewed-by: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605058}

Update the SystemWebViewShell to target Android P (API level 28).
This is a part of the general effort to update apps to API level 28,
see crbug.com/898190 and b/115499280.

This patch also ensures that cleartextTrafficPermitted is set to
true to ensure backwards compatibility for the SystemWebViewShell
(and to allow cleartext traffic, e.g. using unencrypted http
protocol).

This patch also updates trust-anchors to include system and user
certificates.

BUG=898190

Change-Id: I7adb7dbfce1baf3e7b2cf4860709d10fe295217e
Reviewed-on: https://chromium-review.googlesource.com/c/1296601
Commit-Queue: Tim Volodine <timvolodine@chromium.org>
Reviewed-by: Selim Gurun <sgurun@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605057}

Bug: 901107
Change-Id: Ieb943ad33a824318ea391b626285e6c4b8a71fc4
Reviewed-on: https://chromium-review.googlesource.com/c/1313929Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605056}

In order to identify single leading white-spaces as potential line
breaking opportunities we need to know the offset the iterator starts
at for the current text to handle.

When we landed the change in r596406 we incorrectly assumed that
leading white-spaces were always at offset 1. However, this is not
valid when such leading white-spaces are generated by previous broken
lines.

This CL solves the issue by using the stored initial offset to identify
such single leading white-spaces as potential breaking opportunities.

Bug: 900727
Change-Id: Ibc9dda7632d72ed82a61025015489ec3b70d6919
Reviewed-on: https://chromium-review.googlesource.com/c/1311274
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605055}

https://chromium.googlesource.com/media_router.git/+log/475baa8b2eb0..29324b698ccd

$ git log 475baa8b2..29324b698 --date=short --no-merges --format='%ad %ae %s'
2018-10-05 mfoltz Fix/suppress JSCompiler errors in advance of b/117162687 && b/117162806
2018-09-18 mfoltz Added retry behavior for Slarti calls.
2018-09-06 mfoltz Support mirroring with Mirroring Service behind feature flag.
2018-08-08 mfoltz Added extra logging for GCM activity.

Created with:
  roll-dep src/chrome/browser/resources/media_router/extension/src

TBR=jrw@chromium.org

Change-Id: I1d88f7f4a6c427183d89de0a79d6636b07a73ec0
Reviewed-on: https://chromium-review.googlesource.com/c/1315695
Commit-Queue: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605054}

Changes:
Update the y positions of child views to target state upon animation
start to avoid stale positions.

Bug: 901168
Change-Id: I605d20302a7512b82ffe5cf445e7166f64da3280
Reviewed-on: https://chromium-review.googlesource.com/c/1315810
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605053}

This reverts commit 46a9bbb1.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Overview optimizations
> 
> This is 2nd attempt to land: crrev.com/c/1304973
> [2] are the difference from above CL.
> 
> *[2] Added null check in OnStartingAnimationComplete.
> * Pause occusion tracker during overview animation
>  [2] wait 5000ms when exiting overview before resume
>        because a user may re-enter overview
>  [2] wait 50ms when entering overview before resume
>        because it can take 2 frame to finish draing the frame
>        after animation observer is called.
> * Activate the text filter after animation
> * [2]Animate shelf after overview animation.
> * [2] Improve blur animation:
>  Use Compositor's AnimationObesrver to drive animation
>  Progress only by 2 to reduce the frequency.
> * Don't animate backdrop window during overview animation.
> * Fix the bounds change issue in WindowGrid. It shouldn't change
> the parent window's bounds.
> 
> 
> Bug: 898077, 897387, b/118675936
> Test: no functional change. Manually tested visual change by entering/exiting overview mode
>   in both clamshell and tabletmode.
>   The web contents should load after animations without backdrop animation.
>   No gap at the bottom of the screen after exiting overview mode.
> 
> Change-Id: I5e5dc17afd62d4dc477d87becdeee91c55bd81ca
> Reviewed-on: https://chromium-review.googlesource.com/c/1304973
> Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
> Reviewed-by: Sammie Quon <sammiequon@chromium.org>
> Cr-Original-Commit-Position: refs/heads/master@{#604206}
> Reviewed-on: https://chromium-review.googlesource.com/c/1312614
> Reviewed-by: Malay Keshav <malaykeshav@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#604844}

TBR=oshima@chromium.org,sammiequon@chromium.org,malaykeshav@chromium.org

Change-Id: Ia07f696386ce2889a1d6344218be355a3515975c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 898077, 897387, b/118675936
Reviewed-on: https://chromium-review.googlesource.com/c/1316169Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605052}

Adjust a few tests so that they will pass when the
RuntimeHostPermissions feature is enabled on ToT. A follow-up will
flip the default of the feature.

Bug: 869996

Change-Id: I0b677040c228cbd7762330f2f4257d37673fdfe7
Reviewed-on: https://chromium-review.googlesource.com/c/1296814Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605051}

Previous, the calls to check IsCleared() were inside a DCHECK(). We want
to promote them to always happen.

This patch does that.

BUG=897263

Change-Id: I385b4bfeb931b94e62cd88258da8873f9ddff8f9
Reviewed-on: https://chromium-review.googlesource.com/c/1315703Reviewed-by: Leon Scroggins <scroggo@chromium.org>
Commit-Queue: Chris Blume <cblume@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605050}

The problem was only observed on Mali and could even be fixed in recent
driver versions. For now, at least narrow down the workaround to only
apply to Mali GPUs. On other GPUs we observe around 10% improvement in
framerate, which we can't leave on the table.

Bug: 301988
Change-Id: Iab07a60a74555d6935b53dc30af1b798a1c56e8f
Reviewed-on: https://chromium-review.googlesource.com/c/1312158Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Commit-Queue: Kristian H. Kristensen <hoegsberg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605049}

This change includes 2 fixes:
 - When text and UI direction don't match, focusing the tab switch
button homes the cursor in the Omnibox. Now the cursor remains where
it is. (900244)
 - When there is autocomplete text and a tab switch button showing,
right arrow doesn't go to end. Now we check that the selection is
entirely at the end before consuming right arrow for the tab switch
button. (899597)

Bug: 899597, 900244
Change-Id: Ib5c953d22c1b80f6f516a04d8e12e7d8b5b13c19
Reviewed-on: https://chromium-review.googlesource.com/c/1312983
Commit-Queue: Kevin Bailey <krb@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605048}

On Android, we clean up non-resumable interrupted file from the history and
download db. However, the actual files may still be on disk.
This CL removes those files while cleaning up the database.

BUG=899775

Change-Id: I59bdf32c11789448295126b2819d326fedcf54ff
Reviewed-on: https://chromium-review.googlesource.com/c/1310499
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605047}

Tweak the data sent to the extensions page slightly more. Move all
runtime host permissions data into a separate field on the
developerPrivate.Permissions struct, and unconditionally populate all
fields (including specific granted hosts) if the feature is enabled.
This simplifies some of the code we need to pass to the
RuntimeHostPermissions element, since we can now just pass
developerPrivate.RuntimeHostPermissions, and paves the way for adding
a separate toggle-able implementation for extensions that request access
to specific sites.

No observable UI or behavior change is expected in this CL.

Update and add tests for the same.

Bug: 891803

Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Id95d3b0a77d8621db811a28fcdcfd705d60ed0f6
Reviewed-on: https://chromium-review.googlesource.com/c/1295271
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605046}

Bug: 898245
Change-Id: I591cecc162cb86d5925ec67b4bbe6b12cd72a0c2
Reviewed-on: https://chromium-review.googlesource.com/c/1313830Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605045}

Using Time::Now() resulted in a test breakage due to daylight savings time.
Specifically, given Time t, (t+TimeDelta::FromDays(1)).LocalMidnight() results
in the same day due to DST.

To fix, I changed to use a fixed date.

Change-Id: I6278c3dce4654910589649b8f724b240ae983195
Reviewed-on: https://chromium-review.googlesource.com/c/1314614Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Commit-Queue: Dan H <harringtond@google.com>
Cr-Commit-Position: refs/heads/master@{#605044}

Currently, VizMainImpl::ExitProcess has a workaround to avoid deadlock
when shutting down the gpu process. Unfortunately, this is only wired up
to one of the ways to shut down. Other shutdown calls originating from
ChildProcessImpl miss this logic and hit the same deadlock.

This change passes a helper to ChildProcessImpl, allowing it to correctly
handle shutdown. This helper posts a task to the GPU main thread before
starting shutdown to ensure both that we're on the right thread as well
as that we're post-init.

Bug: 901396
Change-Id: I58cff914def5c05f7b9e6b6f58cb319153d685dd
Reviewed-on: https://chromium-review.googlesource.com/c/1315538Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605043}

https://chromium.googlesource.com/catapult.git/+log/a8f088180a1c..468ff3e5a030


git log a8f088180a1c..468ff3e5a030 --date=short --no-merges --format='%ad %ae %s'
2018-11-02 ulan@chromium.org Ensure that the mutator utilization metric always makes progress.


Created with:
  gclient setdep -r src/third_party/catapult@468ff3e5a030

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: Id28357691867e650f0ec92bae70848c202a25fa1
Reviewed-on: https://chromium-review.googlesource.com/c/1315729Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#605042}

https://pdfium.googlesource.com/pdfium.git/+log/d105d2e46b9a..0e8346b53d7a


git log d105d2e46b9a..0e8346b53d7a --date=short --no-merges --format='%ad %ae %s'
2018-11-02 thestig@chromium.org Use constants for name tables in CPDF_FontEncoding.


Created with:
  gclient setdep -r src/third_party/pdfium@0e8346b53d7a

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Idddac1709352aa5b5c1bf5bf60c95285d280635c
Reviewed-on: https://chromium-review.googlesource.com/c/1315732Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#605041}

Right now if there is a touch start that hits a main thread touch action
region, we'd ack the touch start from the renderer and the allowed touch
action is sent together with that ack. For example, when we touch a main
thread touch action region, the InputRouterImpl::TouchEventHandled
callback is executed when the browser receives the ACK from the main
thread.

This CL changes the logic a bit without changing the behavior. Specifically,
we change InputHandlerProxy::HitTestTouchEvent to return
DID_HANDLE_NON_BLOCKING instead of DID_NOT_HANDLE, which means that
we are now sending the ACK for the touch start form the compositor instead
of the main thread. With this change, InputRouterImpl::TouchEventHandled
callback will be executed when the browser receives the ACK from the
compositor, and that the touch action computed from the main thread may
be unknown. Once the TouchEventHandled callback is executed, it calls
the ProcessTouchAck which processes the touch ack and generates gesture
events from them.

To keep the same behavior as what it is now, this CL queues all the generated
gesture events until the effective touch action is received.

To preserve the touch ack timeout behavior, what we did in this CL is that
when calling ProcessTouchAck, don't stop the timeout monitor if the main
thread touch action is not received yet. When the main thread touch action
is received, then stop the timeout monitor.

We can use the existing tests to make sure that there is no behavior
change.

Bug: 772130
Change-Id: I6376f03c938206ad4bd3d3acb00cdb6581ac4f2c
Reviewed-on: https://chromium-review.googlesource.com/c/1255442
Commit-Queue: Xida Chen <xidachen@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605040}

This reverts commit b2457b26.

Reason for revert: suspected of causing assertion failure running merge_web_test_results.py in not_site_per_process_webkit_layout_tests

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests%20%28dbg%29%281%29%2832%29/53956

2018-11-02 10:44:57,220 - root: [INFO] Running with isolated arguments
Traceback (most recent call last):
  File "/b/swarming/w/ir/cache/builder/src/third_party/blink/tools/merge_web_test_results.py", line 12, in <module>
    main(sys.argv[1:])
  File "/b/swarming/w/ir/cache/builder/src/third_party/blink/tools/blinkpy/web_tests/merge_results.py", line 775, in main
    assert args.positional
AssertionError


Original change's description:
> Make layout tests use default isolation (e.g. site-per-process on desktop).
> 
> Summary
> =======
> 
> This CL makes layout tests use the default site isolation from the
> platform they are run on (instead of opting out of strict site isolation
> via LayoutTestContentBrowserClient::ShouldEnableStrictSiteIsolation).
> Additionally, on platforms where strict site isolation is enabled,
> layout tests opt into slightly stricter isolation by enabling isolation
> of same-site origins used by Web Platform Tests - this ensures that
> features covered by WPT also get sufficient coverage of out-of-process
> iframes (OOPIFs).
> 
> After this CL, expectations for tests that differ in behavior with and
> without OOPIFs are being moved from
> LayoutTests/FlagExpectations/site-per-process to:
> - LayoutTests/VirtualTestSuites (virtual/not-site-per-process suite)
> - LayoutTests/virtual/not-site-per-process/README.md
> - LayoutTests/TestExpectations and LayoutTests/NeverFixTests
>   ("Site Isolation failures" section)
> 
> 
> Desirability
> ============
> 
> The CL helps with the following:
> 
> - Focusing on testing the mode that is actually shipped to end users
> - Helping ensure that newly developed features get site-per-process
>   coverage without having to set up a separate step (i.e. it is
>   sufficient to set-up a bot that runs layout tests with
>   --enable-features=NewFeature without also having to have a separate
>   test step for runing layout tests with *both*
>   --enable-features=NewFeature *and* --site-per-process
> 
> This CL does *not* help with reducing requirements for CQ capacity,
> because we need to maintain a separate
> not_site_per_process_webkit_layout_tests step to make sure that tests
> pass without isolation (which is the mode Chrome ships on Android).
> Also note that layout test coverage on Android is very sparse - see
> https://groups.google.com/a/chromium.org/d/topic/blink-dev/SOXhTYysYkE/discussion
> 
> 
> Preserving test coverage
> ========================
> 
> Most tests
> ----------
> 
> The CL preserves covering most layout tests with and without OOPIFs, by
> relying on the fact that CQ/waterfall run layout tests on both kinds of
> platforms - ones that default to strict site isolation (desktop
> platforms) and ones that default to no site isolation (Android).
> 
> 
> Tests that used to be excluded FlagExpectations/site-per-process
> ----------------------------------------------------------------
> 
> Around 40 tests fail when run in presence of OOPIFs.  Such tests are
> disabled by this CL by moving test expectations from
> FlagExpectations/site-per-process into the main TestExpectations file.
> The CL preserves non-OOPIF test coverage provided by the disabled tests
> by introducing virtual/not-site-per-process directory which runs all
> such tests with site isolation disabled.  Using a virtual test suites
> for preserving the test coverage relies on the ability to have separate
> test expectations for these tests (i.e. relying on the fact that
> disabling these tests in TestExpectations doesn't disable their
> virtual/not-site-per-process equivalents).
> 
> Note that the CL keeps isolating "oopif.test" site even in
> virtual/not-site-per-process suite.  This site should only be used by
> tests that require an OOPIF.
> 
> 
> Preserving site-per-process-specific test expectations
> ------------------------------------------------------
> 
> Some tests have site-per-process-specific expectations:
> - http/tests/inspector-protocol/network/security-info-on-response.js
> - http/tests/inspector-protocol/network/raw-headers-for-protected-document.js
> 
> The tests above highlight that cross-origin cookies are not displayed in
> site-per-process mode (a known regression tracked by
> https://crbug.com/849483).  This CL preserves expectations and coverage
> by shuffling things around:
> - old, main expectation -> android expectation
> - old, site-per-process expectation -> main expectation
> 
> 
> There is one additional test with site-per-process-specific
> expectations:
> - external/wpt/dom/events/EventListener-addEventListener.sub.window.js
> 
> Unlike the other 2 tests, it seems less important to preserve exact test
> expectations for the case when the test fails with Site Isolation.
> Therefore this test is covered by virtual/not-site-per-process test
> suite and an expectation for this test is added to the main
> TestExpectations.
> 
> 
> Lost test coverage
> ------------------
> 
> Even with extra caution described above, some test coverage may be lost:
> 
> - Features covered by tests only on one kind of platform (e.g. disabled
>   on Android) are at risk of losing OOPIF or non-OOPIF coverage.
> 
> - Before this CL, site-per-process was also applied to all other
>   `virtual/...` test suites.  After this CL,
>   `virtual/not-site-per-process` will not provide such coverage.
> 
> 
> Cleaned up test expectations
> ----------------------------
> 
> Some additional test expectations clean-up is done, while preserving
> test coverage:
> 
> - The http/tests/perf/large-inlined-script.html test has been already
>   present in `SlowTests` and therefore I didn't include this test in the
>   new `virtual/not-site-per-process` suite.
> 
> - The http/tests/devtools/network/network-datareceived.js test was
>   already marked as expecting a `[Failure]` in TestExpectations and
>   therefore I didn't include this test in the new
>   `virtual/not-site-per-process` suite.
> 
> - The http/tests/devtools/console-cross-origin-iframe-logging.js test
>   was already marked as `[Timeout]` in the old TestExpectations but for
>   Win only.  Since I can repro a timeout on Linux (with and without site
>   isolation), I just extended the old expectation to all platforms and I
>   didn't include this test in the new `virtual/not-site-per-process`
>   suite.  I also removed the test from SlowTests (since timeouts in the
>   test are not expected everywhere).
> 
> 
> Bug: 870761
> Change-Id: I74d8ac4ebee8f0402d449fda2cec46ba3b49cf64
> Reviewed-on: https://chromium-review.googlesource.com/c/1302662
> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#604955}

TBR=dpranke@chromium.org,alexmos@chromium.org,lukasza@chromium.org

Change-Id: I54b6a36922bebfbc8a3f1467bc3d4807c2322604
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 870761
Reviewed-on: https://chromium-review.googlesource.com/c/1315960Reviewed-by: Mike Wittman <wittman@chromium.org>
Commit-Queue: Mike Wittman <wittman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605039}

The PRD in the bug explains how we wanted it to look, and when we wanted it to appear.

SCREENSHOT: https://screenshot.googleplex.com/WEy35zvdt6O.png
SCREENCAST: https://drive.google.com/open?id=1SURR2EP4UN35lPZQYUw2iceivWGnDO2y

Bug:883456

Change-Id: Ib94be66d45cd809f995d01c6429e563371e550f1
Reviewed-on: https://chromium-review.googlesource.com/c/1259806
Commit-Queue: Alexandre Frechette <frechette@chromium.org>
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605038}

This works around a bug where the fallback language (English) doesn't
get installed by Play.

Bug: 901284
Change-Id: Iff059d45903e444fa74335845a0bac280dff456f
Reviewed-on: https://chromium-review.googlesource.com/c/1315692
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605037}

GetNetworkServiceFromConnector() may be called in the early startup before the
full browser starts. Therefore, it can't use
DCHECK_CURRENTLY_ON(content::BrowserThread::UI) to check whether it is called
on the same thread. Instead, we check whether the connector is accessed on the
valid sequence to replace this DCHECK.

Bug: 729596
Change-Id: I97e2b0cae7a4a7e0dded919b9b120f60eb18fea6
Reviewed-on: https://chromium-review.googlesource.com/c/1308977Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Xi Han <hanxi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605036}