GitLab

The tested settings have a button just at the bottom end of the screen on small devices. Tapping the button results in showing a snackbar, which covers the button on small devices. testCopyPasswordToast in particular needs to tap the copy button twice. The second tap was impossible on small devices because the snackbar was still around, blocking the button.

This CL adds two actions to prevent this issue:

(1) While checking for the snackbar, the test also taps it, causing it to close. The test waits for the fade-out animation to finish.

(2) The test also uses usingSearchAction:grey_scrollInDirection to ask EarlGrey to scroll until the control is clickable.

Even though either single option from the above would fix the current issue, the CL contains both: (2) because it will also be useful on smaller devices, e.g., should we start testing in landscape mode (see https://crbug.com/717548 and also https://crbug.com/717163 for another blocker for landscape mode), where the buttons will be off the screen instead of just being covered. It also includes (1), because cleaning up the snackbar explicitly seems like a reasonable thing to do. Speaking of cleaning up, the CL also:

(3) Forcibly closes all passwords-related snackbars on teardown. This will be useful when the test fails in the middle, leaving a snackbar up. If not foce-closed, such snackbar would remain visible for (currently) 4 seconds, which might be enough to interfere with the next test.

The CL also applied (1) and (2) to two other tests in the same suite as well. Those deal with similar buttons, which are currently high enough not to experience the problem with being blocked. This secures them in case that, e.g., the layout changes in the future.

Note that while (2) is clearly beneficial, it also has a drawback: the search action takes a considerable amount of time (about 2 seconds per one scrolling step on my computer). With it, the tests are more likely to time out. If there is an issue with timing out in the future, we should increase kScrollAmount to speed up the scrolling, or split long tests (testCopyPasswordToast is a particular candidate).

BUG=718043

Review-Url: https://codereview.chromium.org/2860453004
Cr-Commit-Position: refs/heads/master@{#469361}

This allows them to be on for the continuous official Win builders.

BUG=629964,717947

Review-Url: https://codereview.chromium.org/2860093002
Cr-Commit-Position: refs/heads/master@{#469360}

No one seems to care about the RedirectInfo. Leave it alone.

BUG=

Review-Url: https://codereview.chromium.org/2855343002
Cr-Commit-Position: refs/heads/master@{#469359}

Combine the 8 keyUsage generator scripts into a single one.
(And delete the redundant keys).

Review-Url: https://codereview.chromium.org/2859053002
Cr-Commit-Position: refs/heads/master@{#469358}

This patch changes the draw dash rect to use SkDashPathEffect instead
of a bitmap shader to produce a dash effect. The visual result is
different, but I think it's still acceptable. Please take a look
at the referenced bug for the list of comparison.

R=danakj@chromium.org, enne@chromium.org
BUG=718084

Review-Url: https://codereview.chromium.org/2863453002
Cr-Commit-Position: refs/heads/master@{#469357}

FirstRunIntegrationTest.testDefaultSearchEngine_ShowExisting was
recently added by https://codereview.chromium.org/2844323003.

However it's been consistently failing on Lollipop Phone Tester, and
flakily failing on other Android bots, so this patch disables it.

BUG=718461
TBR=dfalcantara
NOTRY=true
SKIPTREECHECKS=true

Review-Url: https://codereview.chromium.org/2863653002
Cr-Commit-Position: refs/heads/master@{#469356}

On desktop platforms, this lets you quickly reveal the log file in the shell
after logging has completed.

BUG=718062

Review-Url: https://codereview.chromium.org/2857973003
Cr-Commit-Position: refs/heads/master@{#469355}

This CL removes the following files from bindings/core/v8 and updates
all include sites to use their platform/bindings version:

- V8DOMWrapper.h
- V8GlobalValueMap.h
- V8ObjectConstructor.h
- V0CustomElementBinding.h
- V8Binding.h
- V8BindingMacros.h

BUG=682322
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2856743002
Cr-Commit-Position: refs/heads/master@{#469354}

Move the network quality estimator (NQE) config params from
n_q_e.cc to n_q_e_params class. This is a refactor change with no
functional change. Long term, this would make it easier for net
embedders (Chrome and Cronet embedders) to configure NQE.

BUG=638308
TBR=bengr@chromium.org

Review-Url: https://codereview.chromium.org/2858743002
Cr-Commit-Position: refs/heads/master@{#469353}

BUG=663085
R=pfeldman@chromium.org

Review-Url: https://codereview.chromium.org/2863533002 .
Cr-Commit-Position: refs/heads/master@{#469352}

Some preparatory work for introducing new internal IPC protocol. Cleans
up how Mojo is initialized, deletes some dead code, reoganizes embedder
API surface and extends existing documentation, establishes the basic
concepts of broker and broker client processes, and introduces a nominal
unified API for managing physical process connections.

BUG=696031
TBR=alokp@chromium.org
TBR=tsepez@chromium.org

Change-Id: Ibb8750218dc672e73ecf46aa5c3cb540769d46a0
Reviewed-on: https://chromium-review.googlesource.com/495371Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#469351}

String parameters were being passed by value instead of by const
reference by mistake.

BUG=718242

Review-Url: https://codereview.chromium.org/2862843002
Cr-Commit-Position: refs/heads/master@{#469350}

Downloads, history and bookmarks all have utility methods that open
their UIs. When Chrome Home is enabled, opening these UIs should
open the bottom sheet and show the corresponding BottomSheetContent.
Typed urls (e.g. chrome://history) will still open as native pages
rather than in the sheet.

Also adds tests for the BottomSheetContentController.

BUG=716250

Review-Url: https://codereview.chromium.org/2861453002
Cr-Commit-Position: refs/heads/master@{#469349}

BUG=717483
R=sczs@chromium.org
TEST=See steps in bug.

Review-Url: https://codereview.chromium.org/2862583005
Cr-Commit-Position: refs/heads/master@{#469348}

https://pdfium.googlesource.com/pdfium.git/+log/cbdf926884c4..8384757b2b00

$ git log cbdf92688..8384757b2 --date=short --no-merges --format='%ad %ae %s'
2017-05-04 npm More cleanup in CFX_ScanlineCompositor
2017-05-03 tsepez CPDF_DataAvail: avoid reads into stack buffers.

Created with:
  roll-dep src/third_party/pdfium


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: If9eaedc5b536a85a9647e9b88d453a113444268b
Reviewed-on: https://chromium-review.googlesource.com/495869
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#469347}

TBR=zmo@chromium.org
NOTRY=true

BUG=602688
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2866453002
Cr-Commit-Position: refs/heads/master@{#469346}

The final waitForContentsFullscreenState(false) occasionally times out,
probably because the KEYCODE_BACK got waylaid by some kind of dialog.
This patch adds @RetryOnFailure in the hopes of working around this.

BUG=711005
TBR=mlamouri
NOTRY=true
SKIPTREECHECKS=true

Review-Url: https://codereview.chromium.org/2859243002
Cr-Commit-Position: refs/heads/master@{#469345}

BUG=682299

Review-Url: https://codereview.chromium.org/2848883005
Cr-Commit-Position: refs/heads/master@{#469344}

The anchor constraints syntax is clearer than the old NSLayoutConstraint syntax.

BUG=717974

Review-Url: https://codereview.chromium.org/2860713002
Cr-Commit-Position: refs/heads/master@{#469343}

In Public Sessions, apps and extensions are force-installed by admin policy so the user does not get a chance to review the permissions for these apps. This is not acceptable from a security standpoint, so we:
- scrub the URL available to chrome.tabs.executeScript context (through activeTab permission) down to the origin.

This change also causes the tab object passed to the [page|browser]Action.onClicked to be scrubbed for the given extension.

TEST=
  unit_tests --gtest_filter=DeviceLocalAccountManagementPolicyProviderTest.IsWhitelisted
  unit_tests --gtest_filter=ExtensionTabUtilDelegateChromeOSTest.*
  unit_tests --gtest_filter=ExtensionTabUtilTest.Delegate

BUG=717945

Review-Url: https://codereview.chromium.org/2858643002
Cr-Commit-Position: refs/heads/master@{#469342}

https://skia.googlesource.com/skia.git/+log/b59a9da7eba4..40c0f249e60d

$ git log b59a9da7e..40c0f249e --date=short --no-merges --format='%ad %ae %s'
2017-04-28 benjaminwagner Turn on verbose logging for Valgrind_PreAbandonGpuContext bot.
2017-04-29 benjaminwagner Remove Nexus5 experimental tryjob.
2017-05-04 robertphillips Add GrGpuTextureProxyRef
2017-05-04 msarett Reland "Add SkImage::makeColorSpace() with correct transfer fn behavior"
2017-05-04 ethannicholas Revert "Revert "Revert "eliminated GrGLSLExpr"""
2017-04-17 halcanary src/pdf: code cleanup
2017-05-02 msarett Finish removal of SkImageInfo from SkPixelRef

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=scroggo@chromium.org

Change-Id: I2f58a1a412d86bf2da18c1c50978c37806794221
Reviewed-on: https://chromium-review.googlesource.com/495570Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#469341}

TBR=dpranke@chromium.org,mcgreevy@chromium.org
BUG=718379,717347
NOTRY=true

Review-Url: https://codereview.chromium.org/2859173002
Cr-Commit-Position: refs/heads/master@{#469340}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/342edbef..dabdeb4d

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2863613002
Cr-Commit-Position: refs/heads/master@{#469339}

This case was missing test coverage and had a bug, due to it repurposing
HandleIOError, despite not using any of the existing code. Before
https://codereview.chromium.org/2771263002/, HandleIOError had an
invariant: it would either return an error code (thus continuing to
report failure), or it would reset the state machine and continue.

The new logic had a case where it returned OK without reseting the state
machine, bypassing all logic after the 421 check. Notably,
response_.ssl_info would not get filled in. Should a lower-level layer
of the stack fail with ERR_MISDIRECTED_REQUEST, the new HandleIOError
would also get confused.

Instead, inline the logic. This avoids needing a funny error code at
all. Since logging is still valuable, just add a new event type for it,
which will probably be easier to diagnose anyway. (Otherwise one needs
to know that ERR_MISDIRECTED_REQUEST never comes out of lower layers.)

Add a test that we do not retry in a loop (useful to test), and that
ssl_info is properly filled in (regression test).

BUG=546991

Review-Url: https://codereview.chromium.org/2856313003
Cr-Commit-Position: refs/heads/master@{#469338}

Prior to this CL, SurfaceLayerImpl would always emit a SharedQuadState
for the primary and one for the fallback. This is adding unnecessary
serialization/deserialization overhead. This CL allows the two DrawQuads
to share a SharedQuadState if the device scale factor has not changed
and we are not stretching the surface. In those cases, we don't need
a different scaling transform and thus we don't need a different
SharedQuadState.

BUG=672962
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2857143004
Cr-Commit-Position: refs/heads/master@{#469337}

PlatformFontMac::GetExpectedTextWidth() was wildly over-estimating text widths,
causing dialogs that try to size using Widget::GetLocalizedContentsWidth to be
extremely wide on Mac. This change replaces the guess in PlatformFontMac's
CalculateMetricsAndInitRenderParams() with a more empirically accurate guess.

BUG=654128

Review-Url: https://codereview.chromium.org/2839873003
Cr-Commit-Position: refs/heads/master@{#469336}

(and its callsites) The only remaining callsites are in tests.

BUG=718149,557160
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2857343002
Cr-Commit-Position: refs/heads/master@{#469335}

https://pdfium.googlesource.com/pdfium.git/+log/28b44b03c133..cbdf926884c4

$ git log 28b44b03c..cbdf92688 --date=short --no-merges --format='%ad %ae %s'
2017-05-03 tsepez Move O_BINARY and O_LARGEFILE defintions
2017-05-03 tsepez Remove FXSYS_wfopen(), it is totally unused.

Created with:
  roll-dep src/third_party/pdfium


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: I5bf662c7a67f9a67e36237024cc53a1274f1155e
Reviewed-on: https://chromium-review.googlesource.com/495432
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#469334}

https://drive.google.com/open?id=0ByXziH_JVCGJXzVLNmx6cTVtczA
https://drive.google.com/open?id=0ByXziH_JVCGJQ3BKS2JpOXA5a1k

BUG=661794

Review-Url: https://codereview.chromium.org/2844253003
Cr-Commit-Position: refs/heads/master@{#469333}

BUG=none

Review-Url: https://codereview.chromium.org/2860753004
Cr-Commit-Position: refs/heads/master@{#469332}

This also modifies the ownership of the subresource filter client, which now must
outlive the throttle manager / driver factory.

BUG=717590

Review-Url: https://codereview.chromium.org/2850373002
Cr-Commit-Position: refs/heads/master@{#469331}

Add a minimum test that only enables the login screen apps functionality
via the command line flag. The purpose of this test is to investigate
whether just specifying this command line flag may lead to tests being
timed out. The plan is to remove this test once this investigation
finishes, in favor of more complete end-to-end tests.

BUG=626343

Review-Url: https://codereview.chromium.org/2861723002
Cr-Commit-Position: refs/heads/master@{#469330}

This removes the overhead of emitting trace events from run time
measurement.
On tests like Layout/character_fallback_aat.html, this reduces the
test's duration 3x (0.015ms --> 0.005ms)

BUG=716394, 701059
TBR=wangxianzhu@chromium.org

Review-Url: https://codereview.chromium.org/2857403002
Cr-Commit-Position: refs/heads/master@{#469329}

BUG=718242

Review-Url: https://codereview.chromium.org/2858043005
Cr-Commit-Position: refs/heads/master@{#469328}

Previously, percent-height svg elements in a pure-svg doc would get
their size based on the LayoutView's logical height from the previous
layout pass.  In practice, this didn't show up much because FrameView
always does at least one extra initial layout pass to add and then
subtract scrollbars.  The extra layout pass would cause the percent
height descendants to get the right size.

Setting overlay scrollbars on the FrameView eliminates the extra
layout passes and allows the bug to manifest.

Review-Url: https://codereview.chromium.org/2835153002
Cr-Commit-Position: refs/heads/master@{#469327}

Network traffic annotation is added to network request of .
headless/public/util/http_url_fetcher.cc
headless/public/util/generic_url_request_job_test.cc

BUG=656607

Review-Url: https://codereview.chromium.org/2857623002
Cr-Commit-Position: refs/heads/master@{#469326}

ANGLE now exposes this extension to indicate that floating point textures
are renderable so it is the preferred way to determine if these extensions
should be exposed.

BUG=angleproject:1958
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2795123003
Cr-Commit-Position: refs/heads/master@{#469325}

Revert of Landing Recent QUIC changes until Sat Apr 29 00:22:04 2017 +0000 (patchset #1 id:1 of https://codereview.chromium.org/2862563003/ )

Reason for revert:
Caused net_unittests to consistently time out on https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29 because of a large number of QUIC tests crashing.

Original issue's description:
> Landing Recent QUIC changes until Sat Apr 29 00:22:04 2017 +0000
>
> There are no flags to be updated
>
> deprecate FLAGS_quic_reloadable_flag_quic_bbr_keep_sending_at_recent_rate in disabled state.
>
> It achieved results that were in general comparable to "measuring
> aggregation" approach, but it had worse rtx rate, and worse QoE, and did
> not actually seem to be better in other regards.
>
> Merge internal change: 154601526
>
> https://codereview.chromium.org/2859913003/
>
> fix packet conservation to remove packets from recovery window when they are lost.  Protected by FLAGS_quic_reloadable_flag_quic_bbr_fix_conservation2.
>
> This causes a dramatic reduction in losses compared to the previous patch.
>
> The transfer time is approximately the same.
>
> Merge internal change: 154590929
>
> https://codereview.chromium.org/2857243002/
>
> Fix typo in comments.
>
> Merge internal change: 154539040
>
> https://codereview.chromium.org/2854823004/
>
> QUIC - refactor stream creation. Guarded by --quic_reloadable_flag_quic_refactor_stream_creation.
>
> This CL is in preparation for HTTP stream pairs changes.  A prototype
> of the entire HTTP stream pairs work is in progress.  This CL is one
> subset of that (2nd in the series).
>
> [ HTTP stream pairs builds upon this, by having new QuicSpdySession
> overrides that implicitly create headers streams, and abstracting
> stream accounting as needed. ]
>
> Add a new factory like method QuicSession::CreateStream(), that
> unconditionally creates a new stream.  It's virtual so subclasses of
> QuicSession can create streams that are appropriately specialized from
> QuicStream.  There are new versions of Create*DynamicStream() called
> MaybeCreate*DynamicStream(), and ShouldCreate*DynamicStream() called
> ShouldCreate*DynamicStream2().
>
> Separating this out means that fewer overrides of Create*DynamicStream()
> and ShouldCreate*DynamicStream() will necessary, because many of those
> were actually only needed to specialize the steam types.  Those will go
> away when FLAGS_quic_reloadable_flag_quic_refactor_stream_creation is
> deprecated.
>
> Merge internal changes: 154351257, 154373998.
>
> https://codereview.chromium.org/2861673004/
>
> QUIC - stream id refactor for tests.
>
> // AKA - http stream pairs bikeshed #1.
>
> This CL is in preparation for HTTP stream pairs changes.  A prototype
> of the entire HTTP stream pairs work is in progress.  This CL is one
> subset of that.
>
> Rework QUIC tests so that they do not hard code the assumption that
> all headers are on stream 3.  Also, prepare to calculate stream ids
> according to whether stream pairs are enabled, i.e. whether they
> increment by 2 or 4.
>
> Merge internal change: 150949425
>
> https://codereview.chromium.org/2854833005/
>
>
> R=rch@chromium.org
> BUG=
>
> Review-Url: https://codereview.chromium.org/2862563003
> Cr-Commit-Position: refs/heads/master@{#469218}
> Committed: https://chromium.googlesource.com/chromium/src/+/d60018e0b72b5708797cebe57780ad559877164f

TBR=rch@chromium.org,ckrasic@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review-Url: https://codereview.chromium.org/2856243003
Cr-Commit-Position: refs/heads/master@{#469324}

https://skia.googlesource.com/skia.git/+log/64dbb89efc9d..b59a9da7eba4

$ git log 64dbb89ef..b59a9da7e --date=short --no-merges --format='%ad %ae %s'
2017-05-04 msarett Revert "Add SkImage::makeColorSpace() with correct transfer fn behavior"

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=scroggo@chromium.org

Change-Id: Iabccfd6819f93e0002473c67ae54d80122db3941
Reviewed-on: https://chromium-review.googlesource.com/495410Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#469323}

Flaky on Windows because file handles may be open during shutdown (which
causes TestingProfile to crash on shutdown).

BUG=717648

Review-Url: https://codereview.chromium.org/2860463003
Cr-Commit-Position: refs/heads/master@{#469322}