- 24 Jun, 2019 40 commits
-
-
jorgegil@google.com authored
Fixes issue where multiple threads creating buffers at the same time could result in two GpuMemoryBuffers created with the same id or placed under the same key of the map, replacing one another. Bug: 859020 Test: exo_unittests --gtest_filter=PointerTest.* --gtest_repeat=500 Change-Id: Idc4c157f52670c90071eefb9f5dca1ed8f056182 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663027Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Auto-Submit: Jorge Gil <jorgegil@google.com> Commit-Queue: Jorge Gil <jorgegil@google.com> Cr-Commit-Position: refs/heads/master@{#671760}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 29b821a9. With Chromium commits locally applied on WPT: 9e3affdd "Ship `referer` header length limitation." 845a980a "KV Storage: add timeout=long and reenable disabled test" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: Ied0fa7c669714c9473a45311ef1aab31ff1c2040 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673753Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#671759}
-
Tarun Bansal authored
Extend expiry date of client hints histograms. Also, add more OWNERs. Bug: 975921 Change-Id: Ib2c0ff3e24554f20ad19bd37e3e0a450c797ba82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669572Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#671758}
-
Khushal authored
Each swap for a surfaceless surface must have at least one overlay plane, for the OutputSurface, before SwapBuffers is issued. The SurfaceControl surface assumes this and will crash in SwapBuffers if at least one plane has not been scheduled. Crash reports indicate that we have cases where glScheduleOverlayPlaneCHROMIUM, presumably for the main plane, fails and we end up crashing during CommitPendingTransaction as a result. Handle this failure better by reporting a failed swap, which should always lose the context and recreate the surface. R=piman@chromium.org Bug: 977812 Change-Id: I53028e5494d5da39d91d1f685913c46ec9a1bb4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673026 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#671757}
-
jorgegil@google.com authored
Fixes buggy restore animation BUG=955981 TEST= Manual: maximize Play Store app then click restore: animation is done correctly Unit tests: exo_unittests Change-Id: I4a43b7f52e589603d20768bc4e8b30cb0d07dad4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634418 Commit-Queue: Jorge Gil <jorgegil@google.com> Auto-Submit: Jorge Gil <jorgegil@google.com> Reviewed-by:
-
Caitlin Fischer authored
This applies to labels for credit card suggestions when the credit card number appears in the label. On Android (dropdown and keyboard accessory), a suggestion appears as dropdown: Caitlin Fischer Visa ••••1234 keyboard accessory: Caitlin Fischer Visa ••••1234 After this CL is merged, Android keyboard accessory labels will be shown as Caitlin Fischer ••••1234. Note that the network or bank name is removed. Bug: 968267 Change-Id: Ida9b745a82e98ca164b47fd444858e9f0643bb70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670309 Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#671755}
-
Peter Wen authored
UMA removed: Android.StrictMode.CheckGooglePlayServicesTime We have enough data from this histogram. It is no longer needed. Potential impact according to histogram: https://crbug.com/577190#c14 Bug: 577190, 976000 Change-Id: If24610c7d176a255ecd00fdb53582496c30c249a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673857 Auto-Submit: Peter Wen <wnwen@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#671754}
-
Sinan Sahin authored
This CL also removes a work around from RevampedContextMenuHeaderCoordinator since the ModelListAdapter is updated (see https://chromium-review.googlesource.com/c/chromium/src/+/1654277) and we don't need to create an MCP in #getView anymore. Bug: 971501 Change-Id: If54d3f5f3a529b668863e7a25c7e7d2fa79b4566 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663532Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#671753}
-
Jian Li authored
Bug: 553478 Change-Id: I3407201b6542c01806766887cb66591cb3c9a8e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672453Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Jian Li <jianli@chromium.org> Cr-Commit-Position: refs/heads/master@{#671752}
-
Paul Moy authored
cros_healthd is a new Chrome OS daemon which will provide telemetry and diagnostics support to Chrome OS. This CL adds logic to bootstrap a Mojo connection between the browser and cros_healthd via D-Bus, and exposes cros_healthd's two telemetry methods. BUG=b:128683357 TEST=manual: because cros_healthd is still a work in progress, I built and deployed the Chrome OS diagnostics package with crrev.com/c/1618248, then added an init script which simply started cros_healthd when the machine boots. I then added some test code by adding a call to cros_healthd::ServiceConnection::GetInstance(), and using the instance to request kMemTotal from cros_healthd. Change-Id: I1fec6d1f43e7e35dec6f8511acc3866ae7526b53 Signed-off-by:
Paul Moy <pmoy@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593832Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#671751}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8034ecba..e92b5481 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id9765fe5a4ab4d668b4ca9a34c7201572b0255a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672798Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#671750}
-
Dave Tapuska authored
SharedArrayBuffer support was enabled by default in Chrome and this test suite just duplicates work that already is part of the default test suites. Change-Id: I554310c9ae90618919bde2ccf6f0cb6539b91b96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674328Reviewed-by:
Ben Smith <binji@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#671749}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/ab176bd6b58c..304e5101f382 git log ab176bd6b58c..304e5101f382 --date=short --no-merges --format='%ad %ae %s' 2019-06-24 benjhayden@chromium.org Add hotkeys to alerts-section. 2019-06-24 klausw@chromium.org Clarify the error message for Trace View picture debugging 2019-06-24 khokhlov@google.com Tracing: factor out serializing code Created with: gclient setdep -r src/third_party/catapult@304e5101f382 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:892948,chromium:972025 TBR=sadrul@google.com Change-Id: I14957aab8dfc25bb60a057651569d0b030511ca1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673921Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#671748}
-
Lutz Justen authored
Latest ADMX templates in dev and beta fail to load with error "Invalid value '-1' for attribute minValue". This happens because the admx_writer writes out a minValue of -1, but ADMX types are unsigned and negative values are rejected. However, admx_writer.py actually checks for negative 'minimum' values in line 283: if 'minimum' in schema and schema['minimum'] >= 0: min = schema['minimum'] So, you ask, how can a negative min value possibly slip in? Turns out, schema['minimum'] was a string and '-1' >= 0 is true. The bug was in the grit code that translates policy_templates.json. The code stringified bools and ints. This CL fixes this and adds a regression test. BUG=chromium:960274 TEST=Added regression test to policy_json_unittest.py and ran it. Tested ADMX on Windows machine. Change-Id: I71f5b471f1717c0ccadd67620aa5d4a1f6cc2863 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669928Reviewed-by:Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#671747}
-
Hector Carmona authored
Enterprise users will see Navi onboarding unless disabled by the PromotionalTabsEnabled policy. If Navi onboarding is NOT enabled there will be NO onboarding at all. Onboarding can be disabled by: - Setting PromotionalTabsEnabled to false - Disabling the NuxOnboarding feature - Onboarding won't be available on Chromium unless the NuxOnboardingForceEnabled feature is enabled Bug: 956678 Change-Id: I30fd7c688b1d8772659f5872f575a14d9b7f2163 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600548 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by:Tommy Martino <tmartino@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Stefan Kuhne <skuhne@chromium.org> Reviewed-by:
Esmael El-Moslimany <aee@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#671746}
-
Mike Dougherty authored
Remove old feature success metrics for already shipped context menu iframe suppport. Additionally, extend expiry for still useful metrics. Bug: 852488, 975439, 975752, 975833, 975929 Change-Id: I220af00f64d2353613f2ea1c0144535921d1e80a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666712 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Auto-Submit: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#671745}
-
Ahmed Mehfooz authored
Feature Pods page can now be changed by: Swiping touch gesture in the feature pods area Scrolling / Swiping on touchpad while cursor is in feature pods area Mousewheel scroll while cursor is in feature pods area Added unit tests for FeaturePodsContainerView Bug: 914077 Change-Id: I388f4dc2e70484e34c18bf007c455bed33434532 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610874Reviewed-by:Tim Song <tengs@chromium.org> Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#671744}
-
Yuwei Huang authored
Previously we assumed START_OF_BATCH is always the first event to receive in a ReceiveMessages stream sequence and used it to track the start of the ReceiveMessages stream. This is generally true for most of the time but in rare cases START_OF_BATCH can happen after PONG, which will result in broken state and crash the app. This CL switches to rely on the initial metadata sent by the server to determine if the stream has been started or not. Bug: 976895 Change-Id: I0d075fed4a7cf9e20896b74dab9e37eeab67fc63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672485 Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#671743}
-
Emil A Eklund authored
Bug: 591099 Tbr: cbiesinger@chromium.org Change-Id: I03e707a475e685084bdfbe04203b8c53fdadeacd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674219Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#671742}
-
Karan Bhatia authored
Rename is_browser_side_navigation to is_navigation_request in WebRequestInfo. Since PlzNavigate is launched all navigations are "browser-side". BUG=None Change-Id: Ib0b3b4105186a4ef5bbde1e25fd3aad8a44279d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1668341Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#671741}
-
Robert Ma authored
The previous attempt (r659717) which used a temporary output directory failed because following steps (at least "archive results for webkit_layout_tests") assume that the merged results live in $PWD/layout-test-results on Swarming: https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/chromium_tests/steps.py?l=1328&rcl=0654c98fc1a29640e3a6d99a1350b37efdb9a1df This time, we still use CWD as the output directory but only clearing the `layout-test-results` directory and `output.json` instead of everything in CWD, so that other directories, like `profraw` used by code-coverage won't be affected. While doing so, the flag is renamed to better reflect the behaviour. This change also reverts r658379, which was a temporary workaround from the code-coverage side. A couple of drive-by fixes for temporary output dirs (not related to this bug): * Use a less confusing directory suffix (not ending in .). * Implicitly turn on --allow-existing-output-directory when a temporary output directory is used. Bug: 960994 Change-Id: Ief29562ff3526aaa6ed7ffe364cccb94202bf8d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670152Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#671740}
-
Kevin Babbitt authored
Move the helper functions for loading an accessibility dump expectation file and validating a dump into their own test helper class. This is purely code movement - no changes apart from fixing up dereferences where necessary. I originally wanted to add these methods to AccessibilityTreeFormatter but that failed a presubmit check for LOG(INFO) spam. AccessibilityTreeFormatter isn't test-only code - it's used from the chrome://accessibility page - so I opted for creating a new class for the test helper methods instead. R=nektar@chromium.org Bug: 974397 Change-Id: Ib9d5105747b1418c215c5d11020c92dedade099f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669947 Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#671739}
-
Kelvin Jiang authored
Change page title for the extensions details page in chrome://extensions to Extensions - <extension name> Bug: 867053 Change-Id: I3383ff4f3f0105ca10cbd8609ab5a311e03bf4d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669909Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#671738}
-
chrome-bot authored
Bot config was added in https://crrev.com/c/1649302 but our recipe and tests didn't work yet so we disabled the trigger in https://crrev.com/c/1656969. They should now work (tested with our try bot), so restoring the trigger. Change-Id: Iddec92e74ad9d3d608f6e5fdc05b2f58fde1d576 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670607 Auto-Submit: Mathieu Binette <mbinette@google.com> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#671737}
-
John Budorick authored
also add presubmit pylint & autoformatting to //tools/infra. Bug: 977664 Change-Id: Ib08fc7f6ded5d565cb68a238a5f7839d59496ef4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673081 Auto-Submit: John Budorick <jbudorick@chromium.org> Reviewed-by:
-
Xida Chen authored
Right now in PaintRenderingContext2D, the canvas is scaled after the InitializePaintRecorder. This is too late because we already do canvas->save() at the InitializePaintRecorder. Trying to scale the canvas after save operation doesn't apply the scale. This can be seem by zoom in a paint worklet page and seeing that the drawing isn't zoomed in. This CL fixes the problem and added a layout test. Bug: 970783 Change-Id: Ic0c8a84cc22c8cef9b325e134925e482bee1e65d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670439Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#671735}
-
Suzy Li authored
isUVPAA is currently implemented in AuthenticatorImpl.java by using fingerprintManager. GmsCore SDK v26 now provides its own implementation of isUVPAA as part of the FIDO2 APIs, so Clank should call that API instead. This CL is the initial change to support the implementation on clank. It adds isUVPAA interface and callback, but does not actually use the isUVPAA in Gmscore. Once the implementation on clank landed, will add a follow up change to use it. Bug: 976480 Change-Id: Idc939f798720b413e5f62c7269f9771fad7f9111 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1671707Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Suzy Li <suzyli@google.com> Cr-Commit-Position: refs/heads/master@{#671734}
-
Vadym Doroshenko authored
Bug: 975229, 975768 Change-Id: I22a1680a0beabf2b3604986a1b651026acec6cde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674087Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
-
Kevin Marshall authored
The official builder uses CIPD YAML files that are generated dynamically by GN, so the static files are no longer needed. CIPD documentation is ported to a generic README.md. Bug: 974363 Change-Id: Ia8fd1c1af5fd19ff4a68d36abe0de156d1d5265d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670020 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Auto-Submit: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#671732}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/9d1193b591c5..ad6de6a08a66 git log 9d1193b591c5..ad6de6a08a66 --date=short --no-merges --format='%ad %ae %s' 2019-06-24 asweintraub@google.com Fix ClangTidy-Readability/Naming findings in core/fpdfapi. 2019-06-24 thestig@chromium.org Switch from vector to deque for another CXFA_FFDocView members. 2019-06-24 chinsenj@google.com Fix Heap-buffer-overflow caused by PDF_DataDecode() refactor 2019-06-24 asweintraub@google.com Fix 22 ClangTidy - Readability/Naming findings in fpdfsdk. 2019-06-24 asweintraub@google.com Fix 2 ClangTidy - Readability/Naming findings in core/fdrm Created with: gclient setdep -r src/third_party/pdfium@ad6de6a08a66 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:949425,chromium:977832 TBR=pdfium-deps-rolls@chromium.org Change-Id: Ibae0cc2eab33d9fc235328820b0b550c81857887 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674217Reviewed-by:
-
Matt Simmons authored
Address TODO and remove state from TabListOnScrollListener. R=yusufo@chromium.org Bug: 977955 Change-Id: I45b6020ce855fd0b4cd81c25c5af1b3ca491fd93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673538Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Matt Simmons <mattsimmons@chromium.org> Cr-Commit-Position: refs/heads/master@{#671730}
-
Pavel Yatsuk authored
NTP and ES. BUG=977156 R=skym@chromium.org Change-Id: I9eeaec544e61ed3505b9606ca71b6712dedcdcad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672210Reviewed-by:
Sky Malice <skym@chromium.org> Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#671729}
-
Mehran Mahmoudi authored
Currently, we use AlertDialogs for displaying the dialog that shows up when there is a missing Android permission. This CL replaces this approach with ModalDialogManager for displaying said dialog. This CL also adds support for generating a touchless version of the dialog model for touchless devices. Bug: 974271 Change-Id: I786e2a7f7e2e48f57abd5d3a4674a51c902be51f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1667748Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Becky Zhou <huayinz@chromium.org> Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#671728}
-
Chris Harrelson authored
Change-Id: Ie9adf5ba6dbde516e79db2c2933620675edea43f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669325 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#671727}
-
Mugdha Lakhani authored
changes + few WPT and web_tests. Bug: 925297 Change-Id: I5c8833e236f7cf9b2993e69494ec4dc9797f7120 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660446 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#671726}
-
Allen Bauer authored
TBR: azurewei@chromium.org, shuchen@chromium.org Bug: 945335 Change-Id: I386c03f5d06213ec767cf30ee1e9db83ceeed8b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659272 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#671725}
-
Robert Kroeger authored
This reverts commit 62120966. Reason for revert: Consistent failure in Windows FYI GPU bots per https://crbug.com/978026 Original change's description: > Testing for SwapChainFactoryDXGI > > Updated GLImageDXGISwapChain to use EGL Images instead > of pbuffer surfaces, to avoid creating render target view > for front buffer. > > Bug: 939655 > Change-Id: Iec80f399724ee0509dd95d126c0d3dbb883bb87c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663014 > Reviewed-by: Zhenyao Mo <zmo@chromium.org> > Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org> > Commit-Queue: Ashitha Santhosh <ashithasantosh@google.com> > Cr-Commit-Position: refs/heads/master@{#671369} TBR=zmo@chromium.org,sunnyps@chromium.org,ashithasantosh@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 939655 Change-Id: I70034691f129a0ac4ff1146d3a7742c1d3953e07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673837Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#671724}
-
Mohammad Refaat authored
CRWWebController dismissModals calls LegacyNativeViewController dismissModals which calls nativeViewController (the only rememaining is readingList) dismissModal ReadingListController doesn't implement dismissModal anyway. So this is not needed. Bug: 960950 Change-Id: Ia3f253118b8b5fff9a7eb5aecf2709ef26afc7da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672604Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
-
Michael Lippautz authored
Subsequent CLs will enable the Blink flag and remove dead code paths. Bug: 948807 Change-Id: If8f5b784d4a84aae32817bd91085e1a3c747e84b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672084 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#671722}
-
Natalie Chouinard authored
Migrate Theme settings page from deprecated Framework Preferences to the Preferences Support Library. Bug: 968592 Change-Id: Ib1906faeb230d43870a9243def2b83ba545ff2db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670365Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#671721}
-
